1 2011-05-07T01:02:02 *** grzywacz
2 2011-05-07T02:35:28 <dreimark> jek: yes better
3 2011-05-07T02:35:35 <dreimark> i look tom. at it
4 2011-05-07T02:38:17 <dreimark> ThomasWaldmann: because it did not work as expected
5 2011-05-07T06:19:23 *** Marchael
6 2011-05-07T06:51:13 *** MattMaker
7 2011-05-07T07:47:43 *** Marchael
8 2011-05-07T07:56:42 *** MattMaker
9 2011-05-07T08:57:36 *** Marchael
10 2011-05-07T10:09:10 *** grzywacz
11 2011-05-07T10:09:10 *** grzywacz
12 2011-05-07T10:11:29 *** Marchael
13 2011-05-07T10:38:23 *** Marchael
14 2011-05-07T11:46:54 <ThomasWaldmann> moin
15 2011-05-07T11:53:35 <ThomasWaldmann> xorAxAx: waldi: i don't see much coordination and communication, students seem absent.
16 2011-05-07T11:53:51 <xorAxAx> ThomasWaldmann: did waldi talk to you?
17 2011-05-07T11:54:06 <ThomasWaldmann> about what?
18 2011-05-07T11:54:17 <xorAxAx> about our students tasks
19 2011-05-07T11:54:27 <ThomasWaldmann> not recently
20 2011-05-07T11:54:29 <xorAxAx> we need to know what needs to be done in the py.test realm
21 2011-05-07T11:54:59 <ThomasWaldmann> so why don't you ask? :)
22 2011-05-07T11:55:13 <xorAxAx> because waldi volounteered to ask
23 2011-05-07T11:55:47 <ThomasWaldmann> I'd strongly suggest that there is a common etherpad for this. you are the mentors, create one and put everything there.
24 2011-05-07T11:55:58 <xorAxAx> i suggest a wikipage
25 2011-05-07T11:56:20 <ThomasWaldmann> we can also do that, but not in parallel.
26 2011-05-07T11:56:27 <ThomasWaldmann> so it might be slower.
27 2011-05-07T11:56:36 <xorAxAx> *shrug*
28 2011-05-07T11:56:50 <xorAxAx> can you mail me what needs to be done? then i will put it onto a wikipage
29 2011-05-07T11:57:17 <ThomasWaldmann> no, start with what you know yourself and ask about anything not obvious.
30 2011-05-07T11:57:37 <xorAxAx> well, we dont know what is wrong with the tests
31 2011-05-07T11:57:54 <ThomasWaldmann> well, read them?
32 2011-05-07T11:58:13 <ThomasWaldmann> many tests are much too complicated
33 2011-05-07T11:58:20 <ThomasWaldmann> some might be pointless
34 2011-05-07T11:59:06 <ThomasWaldmann> some might do stuff not needed (like destroying items - they get a fresh backend anyway, see conftest.py)
35 2011-05-07T12:01:52 <ThomasWaldmann> so, a good part of this job is the sanity check part, one has to think about what makes sense to test and what not, also check existing code how it conforms to that
36 2011-05-07T12:03:08 <ThomasWaldmann> also, conftest.py needs sanity check / rewrite. i did some few changes recently, but there is likely more needed.
37 2011-05-07T12:03:37 <ThomasWaldmann> coverage is likely also incomplete
38 2011-05-07T12:03:45 <ThomasWaldmann> lots of tests failing
39 2011-05-07T12:03:51 <ThomasWaldmann> py.test2 migration
40 2011-05-07T12:04:48 <xorAxAx> ok
41 2011-05-07T12:05:47 <ThomasWaldmann> so students and mentors need to get more active on this and communicating / documenting the plan
42 2011-05-07T12:06:14 <xorAxAx> yes
43 2011-05-07T12:06:28 <ThomasWaldmann> and students need to be here on irc, frequent absence and lack of publicly visible communication is a bad sign
44 2011-05-07T12:07:06 * Marchael here
45 2011-05-07T12:07:10 <Marchael> :)\
46 2011-05-07T12:07:31 <ThomasWaldmann> btw, there is also a flask-test extension. one could look at it whether it makes sense for us.
47 2011-05-07T12:07:34 <ThomasWaldmann> Marchael: :)
48 2011-05-07T12:08:35 <ThomasWaldmann> xorAxAx: and maybe in general do the test more in a "real life" environment, like when the moin app is doing stuff when a request comes in
49 2011-05-07T12:08:53 <xorAxAx> yeah
50 2011-05-07T12:09:03 <ThomasWaldmann> quite a lot of tests do some artifical setup and tweaking
51 2011-05-07T12:11:03 <ThomasWaldmann> also, there is still quite some memory leaking. something might be due to the code that is tested, but some might also be due to test infrastructure.
52 2011-05-07T12:13:43 <ThomasWaldmann> also, some tests error out due to failing imports maybe (not sure, but e.g. sphinx docs generation has this issue. e.g. if python-ldap is not installed)
53 2011-05-07T12:15:00 <ThomasWaldmann> we also have a custom / home grown test_sourcecode, iirc py.test2 has a plugin for pep8 checking.
54 2011-05-07T12:15:30 <ThomasWaldmann> of course it should work at least as well as what we have.
55 2011-05-07T12:17:16 <ThomasWaldmann> also, students fail to create wiki pages in wiki markup, they just copied stuff from their applications and didn't fix it so it renders in a nice way
56 2011-05-07T12:19:13 <ThomasWaldmann> http://moinmo.in/pkumar_pytest-2 vs. http://moinmo.in/PrashantKumar/pkumar ???
57 2011-05-07T12:21:49 <ThomasWaldmann> maybe we need to discuss more about sane page names and content also :)
58 2011-05-07T13:12:57 * asmodai pokes ThomasWaldmann
59 2011-05-07T13:19:55 <ThomasWaldmann> hm? :)
60 2011-05-07T13:28:34 <ThomasWaldmann> asmodai:
61 2011-05-07T13:35:00 <asmodai> ThomasWaldmann: heya
62 2011-05-07T13:35:17 <asmodai> ThomasWaldmann: Need a hint to solve a problem in my setup
63 2011-05-07T13:35:54 <asmodai> ThomasWaldmann: fixed the fcgi stuff, so it now loads, does a redirect to /Home but then it 500s out. Enabled flask debug I get an unhandled exception msg
64 2011-05-07T13:36:03 <asmodai> ThomasWaldmann: What should I check?
65 2011-05-07T13:37:10 <ThomasWaldmann> web server error log?
66 2011-05-07T13:37:21 <ThomasWaldmann> traceback > pastebin?
67 2011-05-07T13:37:32 <ThomasWaldmann> permissions?
68 2011-05-07T13:37:59 <ThomasWaldmann> storage pathes in wikiconfig.py?
69 2011-05-07T13:38:53 <asmodai> Well, that's the thing, lighttpd isn't showing much in its logs for this.
70 2011-05-07T13:39:09 <asmodai> ThomasWaldmann: any way I can force a traceback to appear? some flash or moin option?
71 2011-05-07T13:39:09 <ThomasWaldmann> the redirect is a good sign, that means the moin code itself works
72 2011-05-07T13:39:31 <asmodai> ThomasWaldmann: http://wiki.enginedevs.com/ is where I'm building it up
73 2011-05-07T13:39:42 <asmodai> oh wait
74 2011-05-07T13:39:45 <asmodai> wth
75 2011-05-07T13:39:49 <ThomasWaldmann> tracebacks are on stderr, except if you configure moin logging otherwise in your adaptor script
76 2011-05-07T13:39:50 <asmodai> now I get details in the log :|
77 2011-05-07T13:39:55 *** greg_f
78 2011-05-07T13:40:26 <asmodai> mmm, seems related to the themes
79 2011-05-07T13:40:55 <asmodai> http://paste.pocoo.org/show/384482/
80 2011-05-07T13:41:29 <asmodai> probably missed something in copying
81 2011-05-07T13:42:24 <asmodai> Mmm, themes are copied to python lib, aren't they?
82 2011-05-07T13:43:11 <ThomasWaldmann> ehrm, modernized is the builtin one, it should be there
83 2011-05-07T13:43:22 <ThomasWaldmann> better check
84 2011-05-07T13:43:30 <ThomasWaldmann> i usually run stuff in-place
85 2011-05-07T13:43:53 <asmodai> yea, it is not in the eggs
86 2011-05-07T13:44:06 <asmodai> only __init__.py got copied over
87 2011-05-07T13:44:16 <asmodai> looking at build
88 2011-05-07T13:44:24 <asmodai> it's the same there, themes only has __init__.py
89 2011-05-07T13:44:25 <ThomasWaldmann> MoinMoin/themes/modernized/*
90 2011-05-07T13:44:31 <asmodai> yeah, doesn't exist
91 2011-05-07T13:44:34 <ThomasWaldmann> can you fix the setup.py and give me a patch?
92 2011-05-07T13:45:50 <ThomasWaldmann> recursive-include MoinMoin/themes/modernized *
93 2011-05-07T13:46:00 <ThomasWaldmann> at least MANIFEST.in seems correct
94 2011-05-07T13:47:25 <asmodai> mm, how did we deal with these things in setup.py again:
95 2011-05-07T13:47:27 <asmodai> /usr/local/lib/python2.7/site-packages/distribute-0.6.16-py2.7.egg/setuptools/command/install_scripts.py:3: UserWarning: Module MoinMoin was already imported from /home/asmodai/projects/moinmoin2/MoinMoin/__init__.pyc, but /usr/local/lib/python2.7/site-packages/moin-2.0.0a0-py2.7.egg is being added to sys.path
96 2011-05-07T13:48:25 <ThomasWaldmann> not sure what you mean or why this happens
97 2011-05-07T13:48:27 *** Marchael
98 2011-05-07T13:48:52 <asmodai> Think I saw it in babel as well *checks*
99 2011-05-07T13:49:05 <ThomasWaldmann> asmodai: do you have stuff in MoinMoin/static/* and MoinMoin/templates/* ?
100 2011-05-07T13:50:16 <asmodai> static has js and logos
101 2011-05-07T13:50:30 <asmodai> templates has a lot of html
102 2011-05-07T13:50:57 <ThomasWaldmann> the themes/ dir, does it have the json file?
103 2011-05-07T13:51:36 <asmodai> in the build and site-packages, no, only the __init__.py file, nothing else.
104 2011-05-07T13:51:44 <ThomasWaldmann> themes/modernized/info.json ?
105 2011-05-07T13:51:54 <ThomasWaldmann> hmm
106 2011-05-07T13:52:35 <ThomasWaldmann> see line 55 in setup.py
107 2011-05-07T13:52:48 <ThomasWaldmann> it is commented out, check if it changes something when used
108 2011-05-07T13:52:59 * asmodai nods
109 2011-05-07T13:53:24 <ThomasWaldmann> somehow python packaging is annoying
110 2011-05-07T13:54:22 <asmodai> Nope, doesn't change anything.
111 2011-05-07T13:54:38 * asmodai checks some docs
112 2011-05-07T14:45:42 *** m4k3r
113 2011-05-07T15:09:48 *** Marchael
114 2011-05-07T16:03:06 *** m4k3r
115 2011-05-07T16:04:03 *** m4k3r
116 2011-05-07T16:07:19 <ThomasWaldmann> asmodai: and, any insights?
117 2011-05-07T16:11:18 <asmodai> ThomasWaldmann: well, trying to understand something wrt package_data
118 2011-05-07T16:19:59 *** ronny
119 2011-05-07T16:20:52 *** ronny
120 2011-05-07T16:26:00 *** greg_f
121 2011-05-07T16:27:06 *** greg_f
122 2011-05-07T16:54:51 *** m4k3r_
123 2011-05-07T16:55:00 *** m4k3r
124 2011-05-07T18:01:11 *** Marchael
125 2011-05-07T18:09:43 <ronny> sup
126 2011-05-07T18:43:59 *** greg_f
127 2011-05-07T18:44:51 *** greg_f
128 2011-05-07T19:07:45 *** greg_f
129 2011-05-07T19:15:53 *** greg_f
130 2011-05-07T19:25:33 <dreimark> .oO strange result
131 2011-05-07T19:25:34 <dreimark> e.g.
132 2011-05-07T19:25:47 <dreimark> print bind and not bind.optional
133 2011-05-07T19:26:04 <dreimark> <String u'username'; value=None>
134 2011-05-07T19:26:11 <dreimark> but it should be True
135 2011-05-07T19:27:35 <dreimark> can it be that it behaves that way if it is used by jinja ?
136 2011-05-07T19:27:50 *** greg_f
137 2011-05-07T19:27:57 <ThomasWaldmann> try ()
138 2011-05-07T19:28:44 <dreimark> same result
139 2011-05-07T19:28:50 <dreimark> tried that already
140 2011-05-07T19:29:22 <ThomasWaldmann> talk to mitsuhiko :)
141 2011-05-07T19:29:40 <jek> may be my bad in that paste
142 2011-05-07T19:29:51 <jek> try bind is not None
143 2011-05-07T19:31:20 <dreimark> jek: in the paste it works
144 2011-05-07T19:31:28 <ThomasWaldmann> dreimark: if you are implementing jek's solution, can you first revert you last changeset?
145 2011-05-07T19:31:36 <ThomasWaldmann> your*
146 2011-05-07T19:31:40 <dreimark> ThomasWaldmann: thats the plan
147 2011-05-07T19:31:49 <dreimark> i have a different repo
148 2011-05-07T19:31:56 <dreimark> for that playground
149 2011-05-07T19:32:29 <dreimark> i added the keywords because that bind parameter was the main cause why i added keywords
150 2011-05-07T19:32:41 * ThomasWaldmann has a quite big changeset pending
151 2011-05-07T19:32:57 <dreimark> ok, then i revert that now
152 2011-05-07T19:36:51 <CIA-25> Reimar Bauer <rb.proj AT googlemail DOT com> default * 215:d661d49a46dc 2.0/MoinMoin/templates/ (5 files): reverted 214:0f501a426b50, it will be solved differently by a filter for the Generator in util.forms
153 2011-05-07T19:37:51 <dreimark> we have more than once this "and" in filter
154 2011-05-07T19:39:35 <dreimark> ThomasWaldmann: please push
155 2011-05-07T19:52:32 <dreimark> ThomasWaldmann: jek where have you set default values for bind e.g optional
156 2011-05-07T19:52:48 <dreimark> another difference between the paste and our code is
157 2011-05-07T19:53:06 <dreimark> that it is false in the example but true if i add it to the generator
158 2011-05-07T19:54:22 <jek> dreimark: elements implement truthiness, they'll evaluate false if they are empty
159 2011-05-07T19:55:12 <jek> for filters, bind will either be None or an element, so 'if bind is not None' is an appropriate check to see if an element was provided
160 2011-05-07T19:58:45 <dreimark> jek: it always is the String object so that I should check options too
161 2011-05-07T20:01:42 <dreimark> however i need to find where or how bind.optional is set in moin
162 2011-05-07T20:24:56 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 216:661a57c747bd 2.0/MoinMoin/ (26 files in 13 dirs): (log message trimmed)
163 2011-05-07T20:24:56 <CIA-25> replace mimetype by contenttype, use more constants
164 2011-05-07T20:24:56 <CIA-25> to deal correctly with text items, we do not just need the simple mimetype
165 2011-05-07T20:24:56 <CIA-25> like "text/plain", but rather the contenttype like "text/plain;charset=utf-8"
166 2011-05-07T20:24:56 <CIA-25> or, for content from moin 1.9, "text/x.moin.wiki;format=1.9;charset=utf-8" to
167 2011-05-07T20:24:56 <CIA-25> make moin use the moinwiki19_in converter.
168 2011-05-07T20:24:57 <CIA-25> this changeset mostly deals with the stupid task of renaming the constant,
169 2011-05-07T20:24:57 <CIA-25> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 217:60242b1ba235 2.0/MoinMoin/templates/ (5 files): merged main repo
170 2011-05-07T20:26:12 *** ronny
171 2011-05-07T20:28:02 *** ronny
172 2011-05-07T20:29:30 <ThomasWaldmann> ok, now doing the less boring stuff
173 2011-05-07T20:50:14 *** RogerHaase
174 2011-05-07T20:54:03 <TheSheep> hmm, the jython wiki is getting heavily spammed, despite textchas
175 2011-05-07T21:15:19 <dreimark> TheSheep: that textcha is too simple
176 2011-05-07T21:16:30 <ThomasWaldmann> TheSheep: url?
177 2011-05-07T21:16:59 <dreimark> http://wiki.python.org/jython/RecentChanges
178 2011-05-07T21:17:14 <dreimark> ThomasWaldmann: i guess thats it
179 2011-05-07T21:17:24 *** m4k3r_
180 2011-05-07T21:17:51 *** m4k3r
181 2011-05-07T21:18:22 <ThomasWaldmann> TheSheep: that's maybe a human assisted spammer
182 2011-05-07T21:19:08 <ThomasWaldmann> one has to check the logs what questions he did answer correctly and replace those questions by better ones.
183 2011-05-07T21:19:42 <ThomasWaldmann> if nothing else helps, one asks for the edit password which is either secret or requires reading something the wiki users usually read, but not spammers
184 2011-05-07T21:26:19 <ThomasWaldmann> (i have seen that kind of text ... link ... text ... picture ... text ... link ... text spam on many wikis. one has to be careful with adding the links to BadContent because only some of the links are to bad stuff, some just link to other wikis/blogs/forums)
185 2011-05-07T21:26:43 *** m4k3r
186 2011-05-07T21:27:07 *** m4k3r
187 2011-05-07T21:33:06 <TheSheep> ThomasWaldmann: it looks like automated spam with humans checking for textchas
188 2011-05-07T21:33:25 <TheSheep> ThomasWaldmann: I changed the questions again and added more of them
189 2011-05-07T21:33:46 <TheSheep> The IP addresses also seem to all be from philippines
190 2011-05-07T21:33:49 <TheSheep> I blocked them
191 2011-05-07T21:34:32 <TheSheep> ThomasWaldmann: how can I check which question was asked?
192 2011-05-07T21:34:53 <TheSheep> ThomasWaldmann: can't see it in the editlog
193 2011-05-07T21:37:20 <ronny> btw, where is that testing guy?
194 2011-05-07T21:37:51 <TheSheep> ronny: testing guy? like a crashtest dummy?
195 2011-05-07T21:38:17 <ronny> TheSheep: also called gsoc student
196 2011-05-07T21:39:50 <TheSheep> ronny: you are testing on students now? that's the most common test subject around the world :D
197 2011-05-07T21:39:50 <ThomasWaldmann> TheSheep: it is in moin logging output (stderr if not configured otherwise)
198 2011-05-07T21:41:47 <TheSheep> yup, it was the same question
199 2011-05-07T21:41:50 * dreimark strike
200 2011-05-07T21:42:02 <TheSheep> so I need to invent lots of questions now :/
201 2011-05-07T21:42:05 <TheSheep> that is hard
202 2011-05-07T21:42:23 <ronny> hum
203 2011-05-07T21:42:24 <ThomasWaldmann> TheSheep: one non-common sense might be enough
204 2011-05-07T21:42:50 <ThomasWaldmann> like "jython implementation language?"
205 2011-05-07T21:43:17 <ThomasWaldmann> that should be easy to answer for jython users, but not for spammer's assistants
206 2011-05-07T21:48:39 <dreimark> btw. there could be done a combined answer
207 2011-05-07T21:49:00 <dreimark> one answer which users get on irc
208 2011-05-07T21:49:16 <dreimark> and they have to add them concatenated
209 2011-05-07T21:49:39 <dreimark> by that you can verify status of new users
210 2011-05-07T21:56:13 <dreimark> ThomasWaldmann: do we want to keep Cancel in various forms?
211 2011-05-07T22:01:35 *** RogerHaase
212 2011-05-07T22:17:29 *** RogerHaase
213 2011-05-07T22:21:40 <ThomasWaldmann> dreimark: maybe not, a "SAVE" or "OK" button is enough. but it depends a bit on the users. :)
214 2011-05-07T22:31:24 <TheSheep> I added a 'cancel' button to editor because I noticed that it increases the quality of edits greatly
215 2011-05-07T22:31:43 <TheSheep> and reduces trolling
216 2011-05-07T22:41:43 <CIA-25> Reimar Bauer <rb.proj AT googlemail DOT com> default * 218:fd36d76dd0e3 2.0/MoinMoin/util/forms.py: util.forms: new filter for required attributes added, thanks to Jason Kirtland
217 2011-05-07T22:41:43 <CIA-25> Reimar Bauer <rb.proj AT googlemail DOT com> default * 219:96b17384932a 2.0/MoinMoin/apps/frontend/views.py: frontend.views: bug fix for login form, all input is required
218 2011-05-07T22:41:44 <CIA-25> Reimar Bauer <rb.proj AT googlemail DOT com> default * 220:62452154e3a0 2.0/MoinMoin/templates/forms.html: templates.forms: duplicated require class definition removed
219 2011-05-07T22:43:01 <dreimark> TheSheep: yes, there I agree
220 2011-05-07T22:43:19 <dreimark> i just asked because of copy, delete, etc.
221 2011-05-07T22:44:43 <dreimark> it is difficult to require some input if you have more than one submit button
222 2011-05-07T23:35:57 <ThomasWaldmann> huh?
