1 2011-04-09T00:02:17  *** m4k3r has joined #moin-dev
   2 2011-04-09T00:04:04  *** m4k3r has quit IRC
   3 2011-04-09T00:46:41  <ThomasWaldmann> ok, /me is through with reading proposals for today
   4 2011-04-09T00:51:02  *** MattMaker has quit IRC
   5 2011-04-09T02:19:23  <dreimark> re
   6 2011-04-09T02:23:59  * dreimark reads now
   7 2011-04-09T03:23:35  *** ronny has quit IRC
   8 2011-04-09T03:40:40  *** cosmo__ has joined #moin-dev
   9 2011-04-09T03:42:01  *** cosmo_ has quit IRC
  10 2011-04-09T06:53:03  *** xjjk has quit IRC
  11 2011-04-09T06:54:29  *** xjjk has joined #moin-dev
  12 2011-04-09T06:57:41  *** MattMaker has joined #moin-dev
  13 2011-04-09T08:01:18  *** eSyr has quit IRC
  14 2011-04-09T08:01:18  *** MattMaker has quit IRC
  15 2011-04-09T08:08:44  *** eSyr has joined #moin-dev
  16 2011-04-09T09:48:13  <cosmo__> btw did the transfer for the pycon ticket a few days ago :)
  17 2011-04-09T10:01:09  *** ronny has joined #moin-dev
  18 2011-04-09T11:59:37  *** greg_f has joined #moin-dev
  19 2011-04-09T12:13:25  *** m4k3r has joined #moin-dev
  20 2011-04-09T12:42:36  *** m4k3r has quit IRC
  21 2011-04-09T13:42:57  *** greg_f has quit IRC
  22 2011-04-09T13:43:52  *** greg_f has joined #moin-dev
  23 2011-04-09T13:53:45  *** greg_f has quit IRC
  24 2011-04-09T13:54:17  *** greg_f has joined #moin-dev
  25 2011-04-09T13:59:56  *** m4k3r has joined #moin-dev
  26 2011-04-09T14:17:35  *** m4k3r has quit IRC
  27 2011-04-09T14:28:15  *** m4k3r has joined #moin-dev
  28 2011-04-09T14:42:43  <ThomasWaldmann> moin
  29 2011-04-09T14:51:19  *** m4k3r has quit IRC
  30 2011-04-09T15:34:42  * ThomasWaldmann requested some more infos, contributions from SOC applicants
  31 2011-04-09T15:55:25  <ThomasWaldmann> can anybody please review sinha's css/js code?
  32 2011-04-09T15:58:01  <ThomasWaldmann> https://bitbucket.org/sinha/moin-2.0
  33 2011-04-09T16:49:04  * ThomasWaldmann reviews sinha's stuff by some general criteria, but not looking at js/css details
  34 2011-04-09T17:57:15  <dreimark> moin-2.0 / MoinMoin / static / js / navigate-index.js
  35 2011-04-09T17:57:18  <dreimark> misses license
  36 2011-04-09T17:57:43  <dreimark> https://bitbucket.org/sinha/moin-2.0/src/17cdb82ceac9/MoinMoin/static/js/navigate-index.js
  37 2011-04-09T17:58:13  <dreimark> not any indenting level (of course brackets)
  38 2011-04-09T18:03:06  <dreimark> https://bitbucket.org/sinha/moin-2.0/src/tip/MoinMoin/static/js/navigate-index.js#cl-60
  39 2011-04-09T18:03:18  <dreimark> sounds 1.5 moin style for item names
  40 2011-04-09T18:07:40  <ThomasWaldmann> dreimark: i already have a list of basic issues (see above)
  41 2011-04-09T18:10:07  <dreimark> ThomasWaldmann: above?
  42 2011-04-09T18:10:55  <ThomasWaldmann> (16:49) *** ThomasWaldmann reviews sinha's stuff by some general criteria, but not looking at js/css details
  43 2011-04-09T18:11:47  <ThomasWaldmann> http://paste.pocoo.org/show/368555/
  44 2011-04-09T18:12:05  <ThomasWaldmann> just expand that
  45 2011-04-09T18:15:30  <dreimark> seen but until no the list ;)
  46 2011-04-09T18:16:49  <ThomasWaldmann> hm?
  47 2011-04-09T18:16:51  <dreimark> *now not
  48 2011-04-09T18:17:14  <dreimark> i misread that line because of "but not looking at js/css"
  49 2011-04-09T18:17:30  <dreimark> i ignored "details" now it is clear
  50 2011-04-09T18:22:45  *** cosmo__ has quit IRC
  51 2011-04-09T19:04:08  *** MattMaker has joined #moin-dev
  52 2011-04-09T19:14:32  *** cosmo_ has joined #moin-dev
  53 2011-04-09T19:42:29  *** greg_f has quit IRC
  54 2011-04-09T19:47:02  *** sinha has joined #moin-dev
  55 2011-04-09T20:00:50  <ThomasWaldmann> hi sinha
  56 2011-04-09T20:01:16  <ThomasWaldmann> I've done some general (not js/css) review of your recent changes.
  57 2011-04-09T20:01:29  <ThomasWaldmann> http://paste.pocoo.org/show/368555/ here is some stuff i found
  58 2011-04-09T20:20:39  <sinha> hi ThomasWaldmann
  59 2011-04-09T20:22:14  *** ronny has quit IRC
  60 2011-04-09T20:23:35  <sinha> ThomasWaldmann: Re altering in "templates/snippets.html" i know it wasn't the correct way ..but wouldnt it will be good to have that javascript file for the index.html template only
  61 2011-04-09T20:24:02  <sinha> i mean adding them at snippet file wasnt correct,but i guess adding into the block script at index.html file will be good
  62 2011-04-09T20:24:14  <sinha> because that script wont be used anywhere
  63 2011-04-09T20:24:59  <sinha> And also i read your other comments,will try to abide them from next developments and will change the current one accordingly.
  64 2011-04-09T20:27:30  <ThomasWaldmann> sinha: yes, loading it only where required is a good idea.
  65 2011-04-09T20:28:54  <ThomasWaldmann> but my comment was rather about the way you generate the url
  66 2011-04-09T20:28:55  <sinha> ThomasWaldmann: i missed that thing previosuly,but i guess for each other feature which requires a js file it would be better to include them in their respective template file..such that they wont affect page load of other pages
  67 2011-04-09T20:29:36  <sinha> ThomasWaldmann: yes i didnt look for the correct way to include,i was focussed on writing the code
  68 2011-04-09T20:29:45  <sinha> i will take care of these issue from now on
  69 2011-04-09T20:30:59  <sinha> ThomasWaldmann: i have some confusion reg using the bitbucket repo..suppose i have pushed something in it but later i want to withdraw that changes ,is doing this possible ?
  70 2011-04-09T20:31:29  <sinha> something i pushed wrongly or the wrong code
  71 2011-04-09T20:31:44  <sinha> and want to delete them to make my repo clean
  72 2011-04-09T20:34:58  *** ronny has joined #moin-dev
  73 2011-04-09T20:40:01  <ThomasWaldmann> not easily, a commit is permanent
  74 2011-04-09T20:40:21  <ThomasWaldmann> and once you have published it, you have to consider that someone might have pulled it
  75 2011-04-09T20:40:44  <ThomasWaldmann> so you maybe want different repos or review before commit
  76 2011-04-09T20:41:08  <sinha> ThomasWaldmann: means i have to be pretty sure before doing any push to the repo
  77 2011-04-09T20:42:06  <ThomasWaldmann> you have to be rather sure before commit :)
  78 2011-04-09T20:42:58  <sinha> okay,and also i have to do pull very frequently and have to push them at my repo
  79 2011-04-09T20:43:06  <sinha> to keep it updated
  80 2011-04-09T20:43:50  <ThomasWaldmann> yes. sometimes it is good to pull before starting to work. safes some merges.
  81 2011-04-09T20:44:13  <sinha> and regarding the licensing of the icons,where will i write it ? in my commit comment or somewhere else
  82 2011-04-09T20:44:25  <sinha> i have downloaded them from tango library
  83 2011-04-09T20:44:54  <ThomasWaldmann> well a good place would've been the commit comment, but that is too late now
  84 2011-04-09T20:49:32  <sinha> and regarding the usage of  \" in place of '  i did it because the name would have ' character ,so to make it work i replaced the quotes
  85 2011-04-09T20:53:47  <ThomasWaldmann> and if the name has " ?
  86 2011-04-09T20:56:03  <sinha> yes i figured out that one lately and then i adopted of escaping all such chars ..as done in url encode
  87 2011-04-09T20:56:14  <sinha> which works for all such chars
  88 2011-04-09T20:56:43  <sinha> but i didnt change the \" character in js file,thought it would be ok to let it be there
  89 2011-04-09T21:01:52  <sinha> okay i will do the necessary changes and will push them once  again .
  90 2011-04-09T21:04:04  <ThomasWaldmann> thanks
  91 2011-04-09T21:27:03  *** cosmo__ has joined #moin-dev
  92 2011-04-09T21:28:27  *** cosmo_ has quit IRC
  93 2011-04-09T21:30:43  *** sinha has left #moin-dev
  94 2011-04-09T21:30:56  *** cosmo__ has quit IRC
  95 2011-04-09T22:43:38  *** m4k3r has joined #moin-dev
  96 2011-04-09T22:47:51  *** m4k3r has quit IRC
  97

MoinMoin: MoinMoinChat/Logs/moin-dev/2011-04-09 (last edited 2011-04-08 22:45:03 by IrcLogImporter)