1 2011-02-16T00:25:03 *** izibi
2 2011-02-16T01:11:56 <Trip_> patch: adjusted broken URI in comment, for Python logging docs http://paste.pocoo.org/show/339284/
3 2011-02-16T01:34:28 *** Marchael
4 2011-02-16T02:07:30 <Marchael> moin
5 2011-02-16T02:10:00 <Marchael> tanks dreimark I had implemented textcha on revert item :)
6 2011-02-16T02:18:48 <ThomasWaldmann> ah. great :)
7 2011-02-16T02:24:07 <ThomasWaldmann> Trip_: both old and new urls don't work right now
8 2011-02-16T02:25:29 <Trip_> it exists somewhere?
9 2011-02-16T02:26:27 <Trip_> I just wanted to set DEBUG, but nothing was doing it, so I was looking for docs
10 2011-02-16T02:26:38 <Trip_> I finally gave up and set it in MoinMoin/log.py
11 2011-02-16T02:27:01 <Trip_> log level DEBUG I mean
12 2011-02-16T02:27:01 <ThomasWaldmann> ah, new url works now
13 2011-02-16T02:27:12 <Trip_> but it's 2.7, which may be undesirable
14 2011-02-16T02:27:15 <Trip_> ?
15 2011-02-16T02:27:53 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10449:5f4d0fa6f4d0 2.0-dev/MoinMoin/log.py: fix logging configuration docs url
16 2011-02-16T02:31:16 <Trip_> optional patch: catch AttributeError exception that may occur when a page does not exist on a readonly backend http://paste.pocoo.org/show/339311/
17 2011-02-16T02:33:53 <Trip_> patch: tiny little typo in docs/admin/upgrade.rst: http://paste.pocoo.org/show/339312/
18 2011-02-16T02:35:17 <ThomasWaldmann> what's causing the acl attributeerror? traceback?
19 2011-02-16T02:38:05 <ThomasWaldmann> why is that a typo? looks ok.
20 2011-02-16T02:40:00 <Trip_> missing one char
21 2011-02-16T02:40:58 <Trip_> the AttributeError there occurs when actually using the fs19 readonly backend to serve pages
22 2011-02-16T02:41:29 <Trip_> which is why I say it is optional, but it seems nice to let it work
23 2011-02-16T02:42:13 <ThomasWaldmann> well, i'ld like to see the traceback, to see if that is fixing it at the right place
24 2011-02-16T02:42:57 <Trip_> ok, can do
25 2011-02-16T02:43:54 <Trip_> there are three phases to this, so I'll offer some other ones first
26 2011-02-16T02:44:15 <Trip_> I am running them and trying to make the smallest diff I can
27 2011-02-16T02:47:31 <Marchael> ThomasWaldmann: I' think I'm ready to commit my changes, but how can I nuking an item? I already done textchas for modify, delete,destroy, rename and revert.
28 2011-02-16T02:49:17 <ThomasWaldmann> Marchael: iirc, you'll have to provide famous words of destruction as comment :)
29 2011-02-16T02:50:25 <ThomasWaldmann> Trip_: seeing my query?
30 2011-02-16T02:53:10 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10450:da95718ac8f6 2.0-dev/docs/admin/upgrade.rst: upgrade docs: fix format string (thanks to Matt "Trip" Maker)
31 2011-02-16T02:58:40 <ThomasWaldmann> Marchael: hmm, no, looks like i removed that already
32 2011-02-16T02:58:41 <Trip_> vague question: what are the best practices for when you, say, ask a RouterRevision object for a key that it does not have? catch the exception one level up where you do the asking? I assume having objects helpfully scan themselves to tell you if they __contains__
33 said key is not optimal
34 2011-02-16T02:59:26 <Trip_> but maybe there is a magic Python form for doing that one level up
35 2011-02-16T03:01:15 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/339319/
36 2011-02-16T03:01:25 <Trip_> oh wait, maybe this has_item....
37 2011-02-16T03:03:21 <ThomasWaldmann> i am not sure what your question is about
38 2011-02-16T03:04:08 <Trip_> disregard, I'll come back to it in a better way
39 2011-02-16T03:05:31 <ThomasWaldmann> Marchael: did you read that diff?
40 2011-02-16T03:05:54 <ThomasWaldmann> (see line 44/45 vs. 43)
41 2011-02-16T03:06:41 <ThomasWaldmann> 51 vs 52
42 2011-02-16T03:07:20 <ThomasWaldmann> 89 vs 90
43 2011-02-16T03:07:24 <Marchael> oops, useless blanks :)
44 2011-02-16T03:07:48 <ThomasWaldmann> ....
45 2011-02-16T03:09:42 <ThomasWaldmann> Marchael: and btw, nuke == destroy
46 2011-02-16T03:11:06 <Marchael> hm, what's wrong with 51,52 and 89,90?
47 2011-02-16T03:16:00 <ThomasWaldmann> wrong indentation
48 2011-02-16T03:16:53 <ThomasWaldmann> Marchael: yes, destroy item currently crashes with some uuid related error
49 2011-02-16T03:17:14 <Marchael> hm, I leave this for best time :)
50 2011-02-16T03:17:38 <Marchael> s/best/better/
51 2011-02-16T03:20:45 *** cosmos_thought
52 2011-02-16T03:28:29 *** Marchael
53 2011-02-16T03:31:05 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10451:e8b77f8f38b2 2.0-dev/MoinMoin/storage/backends/indexing.py: temporary fix for destroy item
54 2011-02-16T03:39:35 <Trip_> it's a nice big bunch of files I'm running this 1.9.3 -> 2.0 import on. good for testing : )
55 2011-02-16T03:50:59 *** kasun
56 2011-02-16T03:52:31 <Trip_> patch: avoid crashing the fs19 by trying to make it import nonexistent preloaded_items.xml http://paste.pocoo.org/show/339326/
57 2011-02-16T03:54:01 <Trip_> (which it otherwise gets from the current wikiconfig.py)
58 2011-02-16T03:57:47 <Trip_> and then, because the items do not exist, it will try to find them as attachments
59 2011-02-16T03:58:00 <Trip_> and then, because the attachments do not exist, it will try to create them
60 2011-02-16T03:58:14 <Trip_> which fails for fs19 because it is readonly
61 2011-02-16T03:58:51 <Trip_> if we wish to catch that and report it, here is a patch: http://paste.pocoo.org/show/339327/
62 2011-02-16T03:59:25 <Trip_> oops I have a wrong indent there
63 2011-02-16T03:59:34 *** cosmos_thought
64 2011-02-16T04:00:22 <Trip_> http://paste.pocoo.org/show/339329/ with the proper indent
65 2011-02-16T04:03:38 *** cosmos_thought
66 2011-02-16T04:25:48 <Trip_> OK! here is a diff to get past the indexing issues when first loading fs19: http://paste.pocoo.org/show/339335/
67 2011-02-16T04:26:10 <Trip_> that permits you to get far enough to generate the serialized xml file
68 2011-02-16T04:27:18 <Trip_> (here is the sort of traceback it prevents: http://paste.pocoo.org/show/339336/ )
69 2011-02-16T04:29:17 <Trip_> let me know when you can look at that, because the next patch will touch the same file in other spots, for unrelated reasons
70 2011-02-16T04:54:58 *** grzywacz
71 2011-02-16T05:44:49 *** kasun
72 2011-02-16T06:06:33 *** kasun
73 2011-02-16T06:56:32 *** Marchael
74 2011-02-16T07:20:03 *** Marchael
75 2011-02-16T07:54:53 *** Marchael
76 2011-02-16T07:55:28 <Marchael> ThomasWaldmann: http://paste.pocoo.org/show/339412/
77 2011-02-16T07:55:49 <Marchael> deleted some useless blanks
78 2011-02-16T07:59:41 <Marchael> Also, apologize if I will suddenly left a channel, local wi-fi has very weak signal level.
79 2011-02-16T08:09:34 *** Marchael
80 2011-02-16T08:17:46 *** cosmos_thought
81 2011-02-16T08:25:02 *** Marchael
82 2011-02-16T08:30:51 <dreimark> Marchael: did you pulled my recent changes?
83 2011-02-16T08:32:56 <Marchael> I`m pulling for about 4 hours ago
84 2011-02-16T08:35:47 <dreimark> ok
85 2011-02-16T08:36:06 *** kasun
86 2011-02-16T08:36:13 <dreimark> did you run ./pytest from toplevel dir
87 2011-02-16T08:36:34 <dreimark> Marchael: e.g. ./pytest -k test_sourcecode?
88 2011-02-16T08:36:55 <Marchael> oh, I forgot it again :(
89 2011-02-16T08:37:09 * Marchael running now
90 2011-02-16T08:38:33 <dreimark> that will find e.g. 141
91 2011-02-16T08:39:42 <dreimark> line 30 is better readable by adding line breaks similiar to above lines
92 2011-02-16T08:41:55 <dreimark> 52-57 looks like that it can be indented one char more
93 2011-02-16T08:42:09 <dreimark> btw. do you tried eclipse with pydev ?
94 2011-02-16T08:43:15 <Marchael> I'm using vim and rarely gedit
95 2011-02-16T08:44:34 <dreimark> Marchael: then please use http://moinmo.in/CodingStyle
96 2011-02-16T08:44:46 <dreimark> use python.vim from there
97 2011-02-16T08:46:04 <dreimark> don't add empty lines at 225 if there is no good reason for
98 2011-02-16T10:42:06 *** kasun
99 2011-02-16T11:00:28 *** greg_f
100 2011-02-16T11:25:51 *** greg_f
101 2011-02-16T11:26:45 *** greg_f
102 2011-02-16T12:00:52 *** kasun
103 2011-02-16T12:19:13 *** kasun
104 2011-02-16T12:27:30 <ThomasWaldmann> moin
105 2011-02-16T12:49:25 <ThomasWaldmann> Trip_: http://paste.pocoo.org/show/339329/ hmm, that's likely a problematic change, because backend is expected to raise that exception if an item does not exist
106 2011-02-16T12:53:51 <ThomasWaldmann> Trip_: http://paste.pocoo.org/show/339335/ looks like catching exception at wrong place. also, do not use "name is ''" (that is only working due to a python implementation detail, use "name == ''" or even better "not name")
107 2011-02-16T12:56:37 <ThomasWaldmann> Trip_: when you talk about creating items in fs19 failing, is that caused by load_xml not being None? can you just try setting load_xml = None in wikiconfig_local.py?
108 2011-02-16T13:05:25 <CIA-65> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10452:9ae4175a5548 2.0-dev/docs/admin/upgrade.rst: upgrade docs: bring load_xml/save_xml into specific state
109 2011-02-16T13:06:39 *** Pranav_rcmas
110 2011-02-16T13:10:45 <ThomasWaldmann> Marchael: http://paste.pocoo.org/show/339412/ looks better now, no code indenting faults as far as i could see
111 2011-02-16T13:11:20 <ThomasWaldmann> but you maybe could format the parameters of render_template in the same way (it is also about indentation)
112 2011-02-16T13:11:30 <ThomasWaldmann> the code usually used:
113 2011-02-16T13:11:38 <ThomasWaldmann> render_template(x,
114 2011-02-16T13:12:06 <ThomasWaldmann> y,
115 2011-02-16T13:12:16 <ThomasWaldmann> )
116 2011-02-16T13:12:29 <ThomasWaldmann> with y below x and ) below (
117 2011-02-16T13:12:42 <ThomasWaldmann> your new code is sometimes off +/- 1
118 2011-02-16T13:17:32 <Marchael> ok, I check this
119 2011-02-16T13:23:25 <ThomasWaldmann> and destroy item works now
120 2011-02-16T13:26:19 *** Marchael
121 2011-02-16T13:31:42 *** kasun
122 2011-02-16T13:35:22 *** Pranav_rcmas
123 2011-02-16T13:43:04 <Trip_> ThomasWaldman regarding http://paste.pocoo.org/show/339329/ , okay. the patch you accepted for 2.0-dev/docs/admin/upgrade.rst addresses the immediate problem. (setting load_xml = None).
124 2011-02-16T13:48:15 *** Pranav_rcmas
125 2011-02-16T14:24:52 *** Pranav_rcmas
126 2011-02-16T14:26:18 *** kasun
127 2011-02-16T14:32:05 *** Pranav_rcmas
128 2011-02-16T14:39:43 *** Pranav_rcmas
129 2011-02-16T14:39:50 *** kasun
130 2011-02-16T16:17:59 *** Marchael
131 2011-02-16T17:26:52 <ThomasWaldmann> Trip_: ok, if that fixes it, it is the fix at the root cause of the problem :)
132 2011-02-16T17:57:49 <dreimark> moin
133 2011-02-16T17:57:55 <Marchael> moin
134 2011-02-16T18:25:39 *** izibi
135 2011-02-16T18:37:47 *** m4k3r
136 2011-02-16T18:41:46 <Trip_> regarding http://paste.pocoo.org/show/339335/ , I thank you for the comments. I have fixed the "name is" syntax, but I am not sure where else to look now to fix this exception. somewhere for fs19 the StoredRevision is getting created twice, and it's trying to index it the second time, and fails with that AttributeError: Metadata of already existing revisions may not be altered.
137 2011-02-16T18:42:08 <Trip_> or... something
138 2011-02-16T18:42:49 <Trip_> catching the exception does permit me to continue to generate the xml file
139 2011-02-16T18:43:51 <ThomasWaldmann> maybe it should not try to modify StoredRevisions
140 2011-02-16T18:44:34 <ThomasWaldmann> or maybe the StoredRevision of fs19 should look like it does not need modification :)
141 2011-02-16T18:47:38 *** kasun
142 2011-02-16T19:24:23 *** greg_f
143 2011-02-16T19:43:32 <ThomasWaldmann> bbl
144 2011-02-16T20:06:58 *** Marchael
145 2011-02-16T21:30:24 *** grzywacz
146 2011-02-16T21:30:24 *** grzywacz
147 2011-02-16T22:50:19 <Trip_> is there an easy way to get the Winpdb debugger ( http://winpdb.org ) to use the development environment that comes with moin2 via 'source env/bin/activate' ? I tried logging in to X on my MoinMoin server as the moin user, and launching winpdb from inside a terminal window where I had already run 'source env/bin/activate', but that seems to not be the correct magic for this purpose
148 2011-02-16T22:52:33 <ThomasWaldmann> maybe google virtualenv ...
149 2011-02-16T23:35:08 *** m4k3r
150 2011-02-16T23:47:40 <Trip_> thanks ThomasWaldmann, that's what I needed. I may have to set up the debugger inside the virtualenv, looks like
