1 2010-12-23T00:08:10 <ThomasWaldmann> re
2 2010-12-23T00:36:56 *** grzywacz
3 2010-12-23T01:33:30 *** m4k3r
4 2010-12-23T02:45:27 *** Roboraider
5 2010-12-23T02:47:41 <Roboraider> The failing test I'm trying to solve is proving to be harder than I expected. http://paste.pocoo.org/show/307608/ . I found the source of the problem, where the & is being stripped and it is being reinserted automatically.
6 2010-12-23T02:48:02 <Roboraider> Fixing it looks to be difficult
7 2010-12-23T02:48:19 <Roboraider> Do you happen to have any suggestions or help?
8 2010-12-23T03:02:16 *** m4k3r
9 2010-12-23T03:45:20 *** m4k3r
10 2010-12-23T04:08:37 *** m4k3r
11 2010-12-23T04:26:07 *** m4k3r
12 2010-12-23T04:33:28 *** Roboraider
13 2010-12-23T04:46:55 *** m4k3r
14 2010-12-23T05:12:28 *** m4k3r
15 2010-12-23T06:00:13 *** m4k3r
16 2010-12-23T06:19:54 *** skylamer`
17 2010-12-23T08:07:54 *** raignarok
18 2010-12-23T08:29:22 <dreimark> moin
19 2010-12-23T08:31:54 <dreimark> ThomasWaldmann: if we store in meta who edited last we can may be make some stats which contributors stuff always becomes reverted
20 2010-12-23T08:32:24 <dreimark> then we can may be do give a warning and on the next spam we can disable the account
21 2010-12-23T08:33:25 <dreimark> or give that user a textcha which is a bit more complicated then the normal one
22 2010-12-23T08:34:45 <dreimark> at least it would be good to get some information who spams and don't be a regular user
23 2010-12-23T08:35:12 <dreimark> needs to exclude edits in WikiSandBox
24 2010-12-23T08:35:48 <dreimark> s/then/than/
25 2010-12-23T10:03:27 *** Samm
26 2010-12-23T10:31:30 *** rfw
27 2010-12-23T10:46:56 *** NikitaUtiu
28 2010-12-23T10:49:25 *** raignarok
29 2010-12-23T10:51:05 <NikitaUtiu> ThimasWaldmann: hi! are my modifications good ?
30 2010-12-23T11:19:10 *** greg_f
31 2010-12-23T11:51:29 <ThomasWaldmann> NikitaUtiu: last thing i heard was "I'll fix that tomorrow"
32 2010-12-23T12:02:58 <NikitaUtiu> ThomasWaldmann: it was about the sorted list instead of sets
33 2010-12-23T12:03:22 <ThomasWaldmann> yeah, reimar wondered about same stuff as me two days ago ;)
34 2010-12-23T12:03:28 <ThomasWaldmann> but it is ok as you have it
35 2010-12-23T12:04:31 <ThomasWaldmann> http://paste.pocoo.org/show/308518/ is that latest stuff i shall try?
36 2010-12-23T12:05:11 <NikitaUtiu> yeah, that's it
37 2010-12-23T12:06:12 <NikitaUtiu> i mean, just a sec, i'll patch it again to be sure
38 2010-12-23T12:07:29 <NikitaUtiu> http://paste.pocoo.org/show/308825/
39 2010-12-23T12:08:39 <NikitaUtiu> i also fixed the ConverterItemRefs: it can now be called more than once w/o any problems
40 2010-12-23T12:10:23 <ThomasWaldmann> patch unexpectedly ends in middle of line
41 2010-12-23T12:10:59 <NikitaUtiu> ThomasWaldmann: i don't know what's wrong with it, i'm using hg diff
42 2010-12-23T12:11:27 <ThomasWaldmann> the last byte of the file should be a LF, but it is missing
43 2010-12-23T12:12:28 <NikitaUtiu> link.py ?
44 2010-12-23T12:12:42 <ThomasWaldmann> pastebin contents
45 2010-12-23T12:13:13 <NikitaUtiu> i'll try with pastebinit
46 2010-12-23T12:13:29 <ThomasWaldmann> next time then
47 2010-12-23T12:13:39 * ThomasWaldmann fixed it and runs pytest currently
48 2010-12-23T12:14:19 <NikitaUtiu> so the problem was because of the missing LF ?
49 2010-12-23T12:15:04 *** kursor
50 2010-12-23T12:16:12 *** kursor
51 2010-12-23T12:17:15 *** kursor
52 2010-12-23T12:17:42 <ThomasWaldmann> yes
53 2010-12-23T12:18:10 <ThomasWaldmann> patch thinks the last line ends in its middle, because there is no LF at the end
54 2010-12-23T12:19:01 <ThomasWaldmann> trivial to fix, but causes additional work
55 2010-12-23T12:19:25 <ThomasWaldmann> (and one can't be sure it is not something more severe before analysing the patch)
56 2010-12-23T12:20:41 <NikitaUtiu> i copy-pasted the contents of the patch to pocoo and i missed it
57 2010-12-23T12:21:04 *** kursor
58 2010-12-23T12:25:16 <ThomasWaldmann> NikitaUtiu: tests look good (as far as you're concerned)
59 2010-12-23T12:26:19 <NikitaUtiu> ThomasWaldmann: so it's good? i didn't mess anything up ? :D
60 2010-12-23T12:27:19 <ThomasWaldmann> hmm, i get strange failures when trying to create a new item
61 2010-12-23T12:27:29 <ThomasWaldmann> also test_frontend fails because of that
62 2010-12-23T12:28:02 <ThomasWaldmann> File "/home/tw/w/mm20dev/MoinMoin/converter/include.py", line 111, in recurse
63 2010-12-23T12:28:06 <ThomasWaldmann> page_href_new = elem.get(self.tag_page_href)
64 2010-12-23T12:28:08 <ThomasWaldmann> AttributeError: 'NoneType' object has no attribute 'get'
65 2010-12-23T12:30:03 <ThomasWaldmann> without your patch it does not crash
66 2010-12-23T12:31:12 <NikitaUtiu> i have to check it. does anything else fail ?
67 2010-12-23T12:33:02 <ThomasWaldmann> apropriately < typo
68 2010-12-23T12:33:25 <ThomasWaldmann> well, i can't test much manually if it immediately crashes
69 2010-12-23T12:37:24 <ThomasWaldmann> appent < typo
70 2010-12-23T12:56:06 <ThomasWaldmann> NikitaUtiu: it looks a bit like something is inserting None into the dom tree and code running later falls over it
71 2010-12-23T12:56:41 <ThomasWaldmann> but I couldn't find the place by looking at your patch, so maybe you need some debugging
72 2010-12-23T13:00:26 <NikitaUtiu> ThomasWaldmann: i think internal_representation might return a None but i have to check
73 2010-12-23T13:01:36 <ThomasWaldmann> i think it must be somehow related to your change, because if i revert the changes, the crash with new item creation does not happen any more
74 2010-12-23T13:02:38 <NikitaUtiu> it seems that internal_representation from the Item class returns a None
75 2010-12-23T13:04:09 <NikitaUtiu> and that method calls ConverterExternOutput through default_registry
76 2010-12-23T13:06:08 <ThomasWaldmann> NikitaUtiu: __call__ does not return elem any more
77 2010-12-23T13:07:02 <ThomasWaldmann> (and if you don't explicitely return something, return value will be None)
78 2010-12-23T13:07:09 <NikitaUtiu> yep, that was it
79 2010-12-23T13:07:24 <NikitaUtiu> changed it to return self.traverse_tree(*args, **kw)
80 2010-12-23T13:09:08 <NikitaUtiu> i should have refrained from fixing that :)
81 2010-12-23T13:11:16 <ThomasWaldmann> File "/home/tw/w/mm20dev/MoinMoin/converter/html_out.py", line 360, in visit_moinpage_object
82 2010-12-23T13:11:19 <ThomasWaldmann> h = href.path[-1]
83 2010-12-23T13:11:21 <ThomasWaldmann> TypeError: 'NoneType' object is unsubscriptable
84 2010-12-23T13:11:37 <ThomasWaldmann> i got that when saving a test item with some links and transclusions
85 2010-12-23T13:13:03 <ThomasWaldmann> http://paste.pocoo.org/show/308844/ that was the test item (moin wiki markup)
86 2010-12-23T13:13:06 <NikitaUtiu> what test ?
87 2010-12-23T13:13:24 <NikitaUtiu> ok
88 2010-12-23T13:14:48 <ThomasWaldmann> {{http://foo}}
89 2010-12-23T13:14:55 <ThomasWaldmann> that is enough to crash it
90 2010-12-23T13:15:06 <ThomasWaldmann> gtg/bbl
91 2010-12-23T13:15:25 *** Samm
92 2010-12-23T13:20:51 *** Samm
93 2010-12-23T13:56:43 *** Samm
94 2010-12-23T14:01:19 *** Samm
95 2010-12-23T14:08:21 *** Samm
96 2010-12-23T14:11:36 *** Samm
97 2010-12-23T14:19:16 *** m4k3r
98 2010-12-23T14:29:15 *** raignarok
99 2010-12-23T15:07:53 <NikitaUtiu> ThomasWaldmann: i've debugged it and that thing with {{http://google.de}} is not related to my patch
100 2010-12-23T15:07:55 *** raignarok
101 2010-12-23T15:09:18 <NikitaUtiu> ThomasWaldmann: the iri of http://google.de looks like this (it doesn't have a path)
102 2010-12-23T15:09:23 <NikitaUtiu> ThomasWaldmann: Iri(scheme=u'http', authority=IriAuthority(userinfo=None, host=u'google.de', port=None), path=None, query=None, fragment=None)
103 2010-12-23T15:09:41 *** m4k3r
104 2010-12-23T15:10:02 <ThomasWaldmann> NikitaUtiu: so it happens without your patch being applied?
105 2010-12-23T15:10:11 <NikitaUtiu> ThomasWaldmann: yes
106 2010-12-23T15:10:25 <ThomasWaldmann> ok, then it's not your business now, of course :)
107 2010-12-23T15:10:50 <ThomasWaldmann> but if you have debugged it, maybe claim a fix task for it
108 2010-12-23T15:10:52 <NikitaUtiu> should i put an XXX tag to it
109 2010-12-23T15:11:15 <NikitaUtiu> well, after this task, i'll put a tag for now
110 2010-12-23T15:11:21 <ThomasWaldmann> yes
111 2010-12-23T15:16:38 <ThomasWaldmann> ok, so you submit your final diff (with trailing LF :) to melange?
112 2010-12-23T15:16:46 <ThomasWaldmann> and fixed typos :)
113 2010-12-23T15:19:39 <NikitaUtiu> so i should submit it to melange ? or you're asking me? :)
114 2010-12-23T15:24:15 <NikitaUtiu> ThomasWaldman: submitted it :D, hope it now has the LF
115 2010-12-23T15:26:07 <ThomasWaldmann> did you double-click? :)
116 2010-12-23T15:27:09 <NikitaUtiu> whoops, apparently yes :)
117 2010-12-23T15:29:47 *** m4k3r
118 2010-12-23T15:33:23 * ThomasWaldmann finds more typos while reading the diff
119 2010-12-23T15:36:19 <ThomasWaldmann> also copy&paste errros
120 2010-12-23T15:36:22 <ThomasWaldmann> rs*
121 2010-12-23T15:37:39 <NikitaUtiu> duplication ?
122 2010-12-23T15:41:44 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10182:2cdb160bb1df 2.0-dev/MoinMoin/ (4 files in 3 dirs):
123 2010-12-23T15:41:44 <CIA-56> implement creation of ITEMTRANSCLUSIONS metadata similar to ITEMLINKS, add tests (thanks to NikitaUtiu, GCI 2010)
124 2010-12-23T15:41:44 <CIA-56> add a note about a bug if transclusion Iri doesn't have a path.
125 2010-12-23T15:41:44 <CIA-56> reduce code duplication, add docstrings
126 2010-12-23T15:42:35 <ThomasWaldmann> NikitaUtiu: ^^
127 2010-12-23T15:42:51 <ThomasWaldmann> well done :)
128 2010-12-23T15:43:02 <NikitaUtiu> thanks
129 2010-12-23T15:43:14 <ThomasWaldmann> the copy&paste issue was links vs. transclusion
130 2010-12-23T15:43:26 <ThomasWaldmann> the transclusion method's docstring talked about links...
131 2010-12-23T15:43:41 <ThomasWaldmann> i fixed that on the fly
132 2010-12-23T15:43:51 <NikitaUtiu> a, ok
133 2010-12-23T15:44:18 <ThomasWaldmann> btw, i realized that we maybe have another issue in that code
134 2010-12-23T15:45:09 <NikitaUtiu> what issue ?
135 2010-12-23T15:45:09 <ThomasWaldmann> if you have an item foo and it has a link to /bar (or a transclusion), the metadata will have foo/bar
136 2010-12-23T15:45:31 <ThomasWaldmann> it has to be checked what happens if we rename that item to baz
137 2010-12-23T15:46:58 <NikitaUtiu> so if we rename [[/bar]] to [[/baz]] ?
138 2010-12-23T15:47:14 <ThomasWaldmann> no if we rename foo to xxx
139 2010-12-23T15:47:34 <ThomasWaldmann> or baz or whatever
140 2010-12-23T15:48:07 <ThomasWaldmann> the problem is whether the relative links in the markup, that get stored as absolute links in the metadata, will still be correct
141 2010-12-23T15:48:25 <NikitaUtiu> it doesn't get changed
142 2010-12-23T15:48:36 <ThomasWaldmann> yeah, I suspected that :)
143 2010-12-23T15:48:50 <ThomasWaldmann> sounds like another found a bug, want to fix a bug task :D
144 2010-12-23T15:50:24 <NikitaUtiu> but can't the rename action refresh the revision of the page ?
145 2010-12-23T15:50:50 <ThomasWaldmann> the question is rather whether that would be the best way to fix the problem
146 2010-12-23T15:51:35 <NikitaUtiu> so you say that we should have relative paths in the meta ?
147 2010-12-23T15:51:46 <ThomasWaldmann> maybe, yes
148 2010-12-23T15:52:00 <ThomasWaldmann> the getlinks / gettrans method could still expand them to absolute
149 2010-12-23T15:52:17 <ThomasWaldmann> ehrm, no, not that one, but another method
150 2010-12-23T15:52:45 <ThomasWaldmann> or function
151 2010-12-23T15:52:53 <NikitaUtiu> but doesn't the orphaned page action need absolute paths ?
152 2010-12-23T15:53:09 <ThomasWaldmann> yeah, it would use that function
153 2010-12-23T15:54:12 <ThomasWaldmann> maybe one should review the code and think about best way to solve
154 2010-12-23T15:54:28 <ThomasWaldmann> (just look where ITEMLINKS and ITEMTRANSCLUSIONS is used)
155 2010-12-23T15:55:17 <ThomasWaldmann> that reminds me that we have some followup tasks in that code anyway, now that your task is done
156 2010-12-23T15:55:52 <NikitaUtiu> what kind of followups ?
157 2010-12-23T15:57:47 <ThomasWaldmann> see EasyToDo page, search for wanted and orphans
158 2010-12-23T15:58:14 <ThomasWaldmann> it'll use your code :)
159 2010-12-23T15:59:23 <ThomasWaldmann> hmm, i am thinking about making it medium and both wanted+orphans together
160 2010-12-23T16:03:06 <ThomasWaldmann> NikitaUtiu: can you have a look at hg and bitbucket meanwhile?
161 2010-12-23T16:03:24 <NikitaUtiu> ThomsaWaldmann: sure
162 2010-12-23T16:03:33 <ThomasWaldmann> that's much better than patching and you won't have pastebin issues :)
163 2010-12-23T16:04:15 <NikitaUtiu> so, committing instead of patches. ok
164 2010-12-23T16:05:42 <ThomasWaldmann> it needs a bit more discipline maybe (if one wants to reuse changesets 1:1 by pulling them into main repo), but you'll learn it :)
165 2010-12-23T16:06:25 <ThomasWaldmann> it is mostly about focussing on a topic and just changing stuff related to that topic, but doing it completely and systematically
166 2010-12-23T16:06:41 <ThomasWaldmann> that makes great changesets and is easy to review
167 2010-12-23T16:07:30 <NikitaUtiu> i know. i too got distracted by the absolute path bug and the one with __call__ :)
168 2010-12-23T16:08:27 <ThomasWaldmann> (it also avoids one has to read the same stuff again and again)
169 2010-12-23T16:15:13 <ThomasWaldmann> http://moinmo.in/EasyToDo/make%20use%20of%20itemtransclusions%20metadata
170 2010-12-23T16:15:24 <NikitaUtiu> i also noticed this: +something/page. is this the new syntax for actions ?
171 2010-12-23T16:15:35 <ThomasWaldmann> yes
172 2010-12-23T16:15:45 <ThomasWaldmann> we rather call it "view" now
173 2010-12-23T16:16:00 <ThomasWaldmann> NikitaUtiu: read that task idea, whether it is clear enough
174 2010-12-23T16:16:48 <NikitaUtiu> i say it's pretty straightforward
175 2010-12-23T16:17:48 <ThomasWaldmann> with knowledge like you have, i guess it would be rather quick. :)
176 2010-12-23T16:18:20 <NikitaUtiu> brb
177 2010-12-23T16:18:33 <ThomasWaldmann> the "what links here?" part is maybe the most of that task, because that doesn't exist yet
178 2010-12-23T16:34:28 <NikitaUtiu> ThomasWaldmann: back! but isn't that already implemented in moin 1.9 ?
179 2010-12-23T16:34:42 <ThomasWaldmann> it is for moin2
180 2010-12-23T16:35:14 <ThomasWaldmann> and yes, we have similar stuff in 1.9, but it was not as good as what we have in moin2 (or will have soon)
181 2010-12-23T16:35:29 <NikitaUtiu> i think i can do it. i just need to familiarise myself with hg first
182 2010-12-23T16:35:35 <ThomasWaldmann> having real metadata really makes a difference :)
183 2010-12-23T16:36:03 <ThomasWaldmann> we have a short hg intro on the wiki
184 2010-12-23T16:36:31 <ThomasWaldmann> NikitaUtiu: did you use any other revision control yet?
185 2010-12-23T16:37:04 <ThomasWaldmann> http://moinmo.in/MoinDev/MercurialGuide
186 2010-12-23T16:37:34 <NikitaUtiu> ThomasWaldmann: bazaar for some localisation but not extensively
187 2010-12-23T16:37:41 <ThomasWaldmann> (instead of pushing to main repo as shown there, you can also push to your bitbucket repo)
188 2010-12-23T16:38:07 <NikitaUtiu> does that help somehow ?
189 2010-12-23T16:38:12 <ThomasWaldmann> ok, so at least you know a bit about DVCS (bazaar and mercurial are both DVCSes)
190 2010-12-23T16:38:20 <ThomasWaldmann> yes
191 2010-12-23T16:39:35 <ThomasWaldmann> (while CVS, SVN are rather different, old-style centralized VCS). DVCS = distributed/decentral Version Control System
192 2010-12-23T16:40:30 <ThomasWaldmann> btw, mercurial (hg) is written in python and has good platform support for Linux, Mac OS X, Windows, ...
193 2010-12-23T16:43:13 <ThomasWaldmann> NikitaUtiu: what OS do you use?
194 2010-12-23T16:43:40 <NikitaUtiu> ThomasWaldmann: linux
195 2010-12-23T16:44:26 <ThomasWaldmann> ok, then you usuall have a mercurial package
196 2010-12-23T16:44:48 <NikitaUtiu> i already have it installed
197 2010-12-23T16:46:10 <ThomasWaldmann> what version?
198 2010-12-23T16:47:08 <NikitaUtiu> 1.6.3
199 2010-12-23T16:47:58 <ThomasWaldmann> ok
200 2010-12-23T16:58:28 <NikitaUtiu> i think i get the hang of it :D
201 2010-12-23T16:59:30 <NikitaUtiu> but pushing sure takes some time
202 2010-12-23T17:00:17 <ThomasWaldmann> pushing is usually quick
203 2010-12-23T17:00:53 <ThomasWaldmann> but your first clone of the moin/2.0-dev repo (or of a bitbucket repo) will take some time
204 2010-12-23T17:33:07 <NikitaUtiu> it works
205 2010-12-23T17:57:20 *** m4k3r
206 2010-12-23T17:58:02 <NikitaUtiu> ThomasWaldmann: i think i know how to use hg now :D
207 2010-12-23T18:04:09 <ThomasWaldmann> easy, eh? :)
208 2010-12-23T18:04:27 <ThomasWaldmann> NikitaUtiu: did you look at bitbucket already?
209 2010-12-23T18:04:54 <NikitaUtiu> yes, i've also created a repo, and tested some commits
210 2010-12-23T18:05:52 <ThomasWaldmann> you could for moin/2.0-dev from my repo there
211 2010-12-23T18:05:56 <ThomasWaldmann> fork*
212 2010-12-23T18:06:20 <NikitaUtiu> what's your repo called ?
213 2010-12-23T18:08:28 <ThomasWaldmann> search for thomaswaldmann
214 2010-12-23T18:08:41 <ThomasWaldmann> it's pretty obvious from there
215 2010-12-23T18:11:46 <NikitaUtiu> also, is there any way to globally update all revisions of pages ?
216 2010-12-23T18:11:52 <NikitaUtiu> in moin2
217 2010-12-23T18:19:36 <NikitaUtiu> ThomasWaldmann: for refreshing meta on all pages
218 2010-12-23T18:21:41 <ThomasWaldmann> no
219 2010-12-23T18:31:28 <NikitaUtiu> ThomasWaldmann: apparently the transclusion is recursive :)
220 2010-12-23T18:33:27 <NikitaUtiu> ThomasWaldmann: and i got the orphaned working
221 2010-12-23T18:34:07 <ThomasWaldmann> NikitaUtiu: you mean if you transclude self? :)
222 2010-12-23T18:34:40 <NikitaUtiu> or if you transclude other item that transcludes the current page
223 2010-12-23T18:35:46 <ThomasWaldmann> sounds bad :)
224 2010-12-23T18:36:56 <NikitaUtiu> you get recursion depth runtime error
225 2010-12-23T18:37:08 <NikitaUtiu> there should be some sort of escape mechanism
226 2010-12-23T18:37:48 <ThomasWaldmann> could be a medium found/fix bug
227 2010-12-23T18:39:09 <NikitaUtiu> yeah: like displaying an error on the page like 'Transcluding self'
228 2010-12-23T18:42:05 <ThomasWaldmann> iirc the include code has such a thing
229 2010-12-23T18:46:58 <ThomasWaldmann> dreimark: xorAxAx: I'll shoot the 2 tasks now if noone objects
230 2010-12-23T18:48:12 <NikitaUtiu> ThomasWaldmann: orphaned and wanted now also have itemtransclusions
231 2010-12-23T18:48:36 <ThomasWaldmann> NikitaUtiu: first claim the task :)
232 2010-12-23T18:48:42 <NikitaUtiu> oh :)
233 2010-12-23T18:48:48 <NikitaUtiu> link ?
234 2010-12-23T18:49:00 <ThomasWaldmann> i just upload it
235 2010-12-23T18:50:05 <NikitaUtiu> that was the link to the 'EasyToDo
236 2010-12-23T18:51:41 <NikitaUtiu> nvm, claimed
237 2010-12-23T18:54:21 <ThomasWaldmann> xorAxAx: the links in the "fix wikisync" tasks don't work on melange
238 2010-12-23T19:01:52 <xorAxAx> ThomasWaldmann: why is that?
239 2010-12-23T19:02:17 <ThomasWaldmann> because moin emits /foo links, not http://server/foo
240 2010-12-23T19:04:24 <NikitaUtiu> ThomasWaldmann: do i have to write the template for refs_here?
241 2010-12-23T19:05:17 <ThomasWaldmann> NikitaUtiu: maybe have a look at the other templates, maybe you can reuse them as they are
242 2010-12-23T19:20:26 <ThomasWaldmann> http://moinmo.in/EasyToDo/implement%20trashbin%20view
243 2010-12-23T19:20:49 <ThomasWaldmann> xorAxAx: dreimark: ronny: diofeher: please review / comment ^^
244 2010-12-23T19:26:01 <ronny> ThomasWaldmann: i'd allmost call it very hard
245 2010-12-23T19:37:06 <NikitaUtiu> ThomasWaldmann: i've just finished implementing the refs here view
246 2010-12-23T19:40:22 <ThomasWaldmann> ronny: yes, due to which part?
247 2010-12-23T19:40:37 *** greg_f
248 2010-12-23T19:43:02 <ronny> ThomasWaldmann: somehow i sense a impending semantic doom
249 2010-12-23T19:43:23 <ronny> but i might be overanalyzing
250 2010-12-23T19:43:42 <ThomasWaldmann> well, that needs to more specific :)
251 2010-12-23T19:45:57 <NikitaUtiu> gotta gpo
252 2010-12-23T19:46:00 <NikitaUtiu> *go
253 2010-12-23T19:46:01 <NikitaUtiu> bye!
254 2010-12-23T19:46:19 <ThomasWaldmann> cu
255 2010-12-23T19:50:29 *** NikitaUtiu
256 2010-12-23T19:54:19 *** Roboraider
257 2010-12-23T19:59:37 <Roboraider> I'm working on this issue: http://paste.pocoo.org/show/307608/ and I've found the actual source of the problem. The source of the problem is the parsing in the moinwiki_in converter.
258 2010-12-23T20:00:11 *** jbills
259 2010-12-23T20:01:27 <Roboraider> Here's the function that fails. http://paste.pocoo.org/show/309025/ . Note that the parser is commented on.
260 2010-12-23T20:02:12 <Roboraider> The &s are stripped in the converter in and are automatically inserted in the converter out. That's why the test I want to solve fails.
261 2010-12-23T20:04:13 <Roboraider> The regex expression that does the parsing, in _args_wiki.py, strips out the &s. http://paste.pocoo.org/show/309026/
262 2010-12-23T20:05:24 <Roboraider> Fixing the parser would require modifying the parser. This parser looks critical to a lot of other functions. Fixing it could be dangerous.
263 2010-12-23T20:17:39 <ThomasWaldmann> Roboraider: i'll have a look after dinner
264 2010-12-23T20:28:10 <dreimark> re
265 2010-12-23T20:31:17 <Roboraider> I have to go to a robotics meeting this morning. I'll be back in 45 min.
266 2010-12-23T20:31:21 *** Roboraider
267 2010-12-23T20:34:48 *** kennym
268 2010-12-23T20:35:14 <kennym> hi
269 2010-12-23T20:35:58 <kennym> I am a GCI student and would like to get this task done: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964898
270 2010-12-23T20:36:17 <kennym> I have already obtained the moin-2.0-dev repo
271 2010-12-23T20:36:34 <ThomasWaldmann> hi kennym
272 2010-12-23T20:37:26 <ThomasWaldmann> kennym: great. is the list in the task description clear enough?
273 2010-12-23T20:38:26 <kennym> ThomasWaldmann: there's one question I have
274 2010-12-23T20:38:32 <kennym> you define templates as *.html files?
275 2010-12-23T20:40:03 <dreimark> kennym: we use jinja2
276 2010-12-23T20:40:30 <dreimark> http://hg.moinmo.in/moin/2.0-dev/file/2cdb160bb1df/MoinMoin/templates see there
277 2010-12-23T20:40:56 <kennym> dreimark: thanks
278 2010-12-23T20:46:26 <kennym> excuse me, I have a question
279 2010-12-23T20:46:32 <kennym> following code:
280 2010-12-23T20:46:33 <kennym> {{ _('More Actions:') }}
281 2010-12-23T20:47:19 <kennym> should this be {{ gettext('More Actions:') }} to conform the new-style gettext format?
282 2010-12-23T20:47:28 *** grzywacz
283 2010-12-23T20:48:18 <ThomasWaldmann> _ is the usual abbreviation for gettext
284 2010-12-23T20:48:50 <ThomasWaldmann> newstyle refers to the way arguments are passed
285 2010-12-23T20:49:05 <ThomasWaldmann> see the link in details section
286 2010-12-23T20:51:22 <kennym> OK
287 2010-12-23T20:52:09 <kennym> ThomasWaldmann: OK, thanks. I was just being unsure
288 2010-12-23T20:56:33 <ThomasWaldmann> kennym: in the python source, you'ld see:
289 2010-12-23T20:57:07 <ThomasWaldmann> _("foo %(bar)s") % dict(bar="xxx") for old style (or similar)
290 2010-12-23T20:57:30 <ThomasWaldmann> _("foo %(bar)s", bar="xxx") for new style (or similar)
291 2010-12-23T20:58:06 <kennym> ThomasWaldmann: omg, old-style is horrible
292 2010-12-23T20:58:20 <kennym> ThomasWaldmann: thank you for pointing that out
293 2010-12-23T20:58:23 <ThomasWaldmann> yeah :)
294 2010-12-23T20:59:05 <kennym> which files do I have to internationalize specifically?
295 2010-12-23T20:59:28 <ThomasWaldmann> finding these is part of your task
296 2010-12-23T20:59:37 <kennym> understood
297 2010-12-23T20:59:58 <ThomasWaldmann> look below MoinMoin/ :)
298 2010-12-23T21:00:20 <ThomasWaldmann> it is clear why %s or %d is no good?
299 2010-12-23T21:01:02 <kennym> ThomasWaldmann: no, not really. Could you please explain that?
300 2010-12-23T21:01:20 <kennym> you use %(blabla)s instead
301 2010-12-23T21:01:26 *** Roboraider
302 2010-12-23T21:01:38 <Roboraider> I'm back.
303 2010-12-23T21:03:36 <dreimark> kennym: one who later has to translate it knows better what the meaning is
304 2010-12-23T21:03:57 <dreimark> and the grammar logic can be completly different
305 2010-12-23T21:04:00 <kennym> dreimark: so it's only a convention?
306 2010-12-23T21:04:32 <ThomasWaldmann> python / jinja2 has placeholders in strings
307 2010-12-23T21:05:01 <ThomasWaldmann> "%s is %s" depends on sequence
308 2010-12-23T21:05:09 <dreimark> if you have two anonymous placeholders
309 2010-12-23T21:05:21 <kennym> oh, sure!
310 2010-12-23T21:05:26 <dreimark> it can get a different meaning in a translated string
311 2010-12-23T21:05:28 <ThomasWaldmann> if another language wants the left thing not at the left but at the right, you're in trouble
312 2010-12-23T21:06:33 <kennym> I see. Thanks, you're very helpful, guys.
313 2010-12-23T21:06:56 <ThomasWaldmann> so the simple rule is that there MUST NOT be any %s or %d or %x
314 2010-12-23T21:07:12 <ThomasWaldmann> but only %(label)s style stuff
315 2010-12-23T21:07:57 <ThomasWaldmann> then, if you have stuff like "really delete %(count)d items", you need to adapt to ngettext
316 2010-12-23T21:08:09 <ThomasWaldmann> because if it is 1, it is not "items", but "item"
317 2010-12-23T21:08:45 <ThomasWaldmann> ngettext has no abbreviation btw, so you'll write ngettext(...) for that
318 2010-12-23T21:09:10 <ThomasWaldmann> are you a native english speaker?
319 2010-12-23T21:10:00 <kennym> ThomasWaldmann: also in the Jinja templates?
320 2010-12-23T21:10:26 <kennym> ThomasWaldmann: no, I'm a native German speaker, but I hope my English skills are sufficient.
321 2010-12-23T21:10:37 <kennym> My mother speaks English with me ;)
322 2010-12-23T21:11:33 <dreimark> okey
323 2010-12-23T21:11:52 <ThomasWaldmann> ok. good english is important, because fixing that needs to be done at the very beginning.
324 2010-12-23T21:12:09 <ThomasWaldmann> so, in case of doubt, ask your mother :)
325 2010-12-23T21:12:44 <ThomasWaldmann> if we have wrong original (== english) strings and don't fix them now,
326 2010-12-23T21:13:08 *** Kapace_
327 2010-12-23T21:13:13 <ThomasWaldmann> we'll later have to fix 10 times as much (e.g. if we have 9 translations)
328 2010-12-23T21:13:32 <kennym> ThomasWaldmann: I understand.
329 2010-12-23T21:13:55 <ThomasWaldmann> and we'll cause work for 9 translators if we change original string
330 2010-12-23T21:14:07 <kennym> another doubt:
331 2010-12-23T21:14:11 <kennym> {{ _('Revision %(revno)d as of %(date_time)s', revno=revno, date_time=date_time|datetimeformat) }}
332 2010-12-23T21:14:25 <kennym> do I have to change "_" to "ngettext"?
333 2010-12-23T21:14:36 <ThomasWaldmann> for moin 1.9 we have 42 translations btw.
334 2010-12-23T21:14:44 *** skylamer`
335 2010-12-23T21:15:09 <ThomasWaldmann> kennym: only if some count influences choice of words
336 2010-12-23T21:15:52 <dreimark> valeuf: i need this converter example page, can you give me an url?
337 2010-12-23T21:15:53 <ThomasWaldmann> (in math, counts are usually "n", that's why it is ngettext)
338 2010-12-23T21:16:38 * kennym opens Tomboy and writes that down
339 2010-12-23T21:16:48 <ThomasWaldmann> kennym: in that specific example, you don't need ngettext as the phrase is the same, no matter whether it is revision 0 or 1 or 2
340 2010-12-23T21:17:34 *** Kapace_
341 2010-12-23T21:18:04 <ThomasWaldmann> for english and german, the troublemaker is usually count == 1 that changes words.
342 2010-12-23T21:18:15 <ThomasWaldmann> 0 words. 2 words. 1 word.
343 2010-12-23T21:18:46 <TheSheep> 0 słów, 1 słowo, 2 słowa, 5 słów
344 2010-12-23T21:19:26 <kennym> TheSheep: what language is that?
345 2010-12-23T21:19:37 <TheSheep> kennym: polish
346 2010-12-23T21:20:01 <kennym> very cool!
347 2010-12-23T21:20:02 <TheSheep> there are languages with even more plural forms
348 2010-12-23T21:20:08 <ThomasWaldmann> TheSheep: you know how ngettext works for that?
349 2010-12-23T21:20:16 <TheSheep> ThomasWaldmann: yes
350 2010-12-23T21:20:21 <dreimark> btw. goggle translate detects it right
351 2010-12-23T21:20:26 <ThomasWaldmann> tell :)
352 2010-12-23T21:20:29 <TheSheep> ThomasWaldmann: basically the .po file has a formula for it
353 2010-12-23T21:20:48 <TheSheep> ThomasWaldmann: and the translation has as many variants as needed
354 2010-12-23T21:22:30 <kennym> sorry for interrupting; do the table columns here http://fpaste.org/81ks/ have to wrapped in gettext functions?
355 2010-12-23T21:22:40 <TheSheep> with msgstr[0] ""\n msgstr[1] etc.
356 2010-12-23T21:23:14 <kennym> s/to/to be
357 2010-12-23T21:23:26 <TheSheep> ThomasWaldmann: see the example here: http://efreedom.com/Question/1-1161399/Elegant-Way-Deal-Singles-Plurals
358 2010-12-23T21:24:48 <TheSheep> ThomasWaldmann: usuallythe .po file editors will fill in the formula automatically
359 2010-12-23T21:25:36 <ThomasWaldmann> but the original strings are just 2, as english wants it?
360 2010-12-23T21:27:36 <ThomasWaldmann> so msgid is always for == 1?
361 2010-12-23T21:30:03 <ThomasWaldmann> TheSheep: that exotic language in that efreedom post, is it polish? :)
362 2010-12-23T21:31:19 <ThomasWaldmann> 1 okno", "2 okna" and "5 oken"
363 2010-12-23T21:31:25 <TheSheep> souns polish
364 2010-12-23T21:31:49 <ThomasWaldmann> and 3 and 4 are like 2?
365 2010-12-23T21:32:37 <TheSheep> yes, also 22, 32, 42, etc.
366 2010-12-23T21:32:49 <ThomasWaldmann> omg
367 2010-12-23T21:33:16 <TheSheep> that's because it sounds the same 'two windows' and 'twenty-two windows'
368 2010-12-23T21:33:28 <ThomasWaldmann> no wonder you have famous mathematicians :P
369 2010-12-23T21:33:40 <TheSheep> I guess it's only obvious for me XD
370 2010-12-23T21:34:13 <TheSheep> that additional plural comes from the fact that we had a separate word for pairs of things
371 2010-12-23T21:34:22 <TheSheep> like english scissors or pants, sorta
372 2010-12-23T21:36:02 <ThomasWaldmann> is "I speak a good English." good english? :D
373 2010-12-23T21:36:18 <Roboraider> NOt quite
374 2010-12-23T21:36:42 * ThomasWaldmann suspected.
375 2010-12-23T21:36:58 <Roboraider> It would be "I speak English well."
376 2010-12-23T21:37:32 <Roboraider> English and its strange ways...
377 2010-12-23T21:37:39 <ThomasWaldmann> kennym: are you sure(tm)?
378 2010-12-23T21:37:55 <TheSheep> enlish good speak I
379 2010-12-23T21:37:59 <kennym> ThomasWaldmann: about what?
380 2010-12-23T21:38:12 *** rfw
381 2010-12-23T21:38:12 *** rfw
382 2010-12-23T21:38:57 <ThomasWaldmann> kennym: that you speak english well enough?
383 2010-12-23T21:39:47 <TheSheep> it's usually best when the translator is a native speaker
384 2010-12-23T21:39:58 <kennym> ThomasWaldmann: sorry, this won't happen again :)
385 2010-12-23T21:40:04 <kennym> s/this/that
386 2010-12-23T21:40:05 <TheSheep> because there are also cultural nuances that we are not aware off
387 2010-12-23T21:40:08 <TheSheep> of
388 2010-12-23T21:40:15 <ThomasWaldmann> ok, we trust you :)
389 2010-12-23T21:40:28 <TheSheep> like translating 'eraser' to 'rubber' for en-us
390 2010-12-23T21:42:26 <kennym> I am confused. So I *do* have to modify strings now when I see the need for it, or what?
391 2010-12-23T21:44:02 <ThomasWaldmann> yes
392 2010-12-23T21:44:33 <ThomasWaldmann> of course you should be rather sure it is an improvement
393 2010-12-23T21:46:19 <ThomasWaldmann> this task is a technical one as well as checking language - because you'll have to look at any string anyway, for both reasons
394 2010-12-23T21:46:42 <dreimark> TheSheep: it is us-en
395 2010-12-23T21:47:03 <kennym> ThomasWaldmann: understood
396 2010-12-23T21:47:55 <kennym> "Options Settings" is this good English?
397 2010-12-23T21:47:56 <ThomasWaldmann> kennym: you know diff (the utility)?
398 2010-12-23T21:48:01 <ThomasWaldmann> or mercurial?
399 2010-12-23T21:48:01 <kennym> I think not
400 2010-12-23T21:48:18 <kennym> ThomasWaldmann: yes, I'm familiar with Mercurial, git, cvs, svn, etc.
401 2010-12-23T21:48:30 <kennym> and I also know how to use the diff utility
402 2010-12-23T21:48:43 <ThomasWaldmann> cool, then just show "hg diff" now and then
403 2010-12-23T21:49:12 <ThomasWaldmann> if you also have "pastebinit" installed, it gets rather comfortable as "hg diff|pastebinit"
404 2010-12-23T21:49:28 <ThomasWaldmann> alternatively, you could also fork on bitbucket
405 2010-12-23T21:50:15 <ThomasWaldmann> "Options Settings" sounds slightly strange, but I am not sure
406 2010-12-23T21:50:28 <ThomasWaldmann> could be maybe just "Settings" or "Options"
407 2010-12-23T21:51:31 <kennym> Maybe "Options' Settings" or "Option's Settings" is meant.
408 2010-12-23T21:51:47 <ThomasWaldmann> kennym: btw, it is important that you do this review systematically
409 2010-12-23T21:51:52 <kennym> MoinMoin/templates/usersettings.html
410 2010-12-23T21:53:01 <kennym> ok, now is a good point. I've gone through all files in MoinMoin/templates
411 2010-12-23T21:53:17 <kennym> s/point/time
412 2010-12-23T21:54:23 <ThomasWaldmann> there are multiple *Settings there, so it should be somehow consistent and correct
413 2010-12-23T21:55:12 <ThomasWaldmann> Options' Settings?
414 2010-12-23T21:56:27 <TheSheep> option, setting and configuration are all slightly different things
415 2010-12-23T21:57:19 <ThomasWaldmann> kennym: you could create a wiki page with a table which files you have checked for what
416 2010-12-23T21:59:23 <ThomasWaldmann> otherwise you maybe lose oversight what you've already done and where
417 2010-12-23T22:00:01 <kennym> ThomasWaldmann: it's not very clear in the source what to use.
418 2010-12-23T22:00:10 <kennym> ThomasWaldmann: I am using Tomboy for that
419 2010-12-23T22:00:47 <kennym> if you really insist on it, I can create a wiki page for that.
420 2010-12-23T22:01:25 <ThomasWaldmann> if it is a text file, you can also just copy it from tomboy now and then
421 2010-12-23T22:02:08 <ThomasWaldmann> what exactly is not clear? give a url (of file in hg, of pastebin, ...).
422 2010-12-23T22:03:59 <kennym> http://fpaste.org/ZJH5/
423 2010-12-23T22:04:14 <kennym> Lines:
424 2010-12-23T22:04:26 <kennym> 13 and 84
425 2010-12-23T22:05:20 <ThomasWaldmann> ok, and the question is...?
426 2010-12-23T22:05:25 <kennym> I am asking if "Options Settings" is used correctly
427 2010-12-23T22:05:44 <kennym> or if there could be a better translation
428 2010-12-23T22:05:51 <kennym> s/translation/phrase
429 2010-12-23T22:06:07 <ThomasWaldmann> well, that's a question for a native speaker, eh? :D
430 2010-12-23T22:06:23 <kennym> well, let's ask a native speaker :)
431 2010-12-23T22:07:08 <ThomasWaldmann> you see in 89..92 what is being configured there
432 2010-12-23T22:07:39 <ThomasWaldmann> whether it shall use mailto: links or wiki homepage links
433 2010-12-23T22:08:00 <ThomasWaldmann> whether you want to be able to doubleclick to open editor
434 2010-12-23T22:08:07 <ThomasWaldmann> whether you want to show comments
435 2010-12-23T22:08:26 <Roboraider> ??
436 2010-12-23T22:08:32 <ThomasWaldmann> and whether you want to shoot yourself in the foot :)
437 2010-12-23T22:10:00 <kennym> Could "Various Settings" be an alternative?
438 2010-12-23T22:10:19 <ThomasWaldmann> maybe.
439 2010-12-23T22:10:34 <ThomasWaldmann> i guess i chose options because it is on-or-off stuff.
440 2010-12-23T22:11:40 <kennym> yes, that
441 2010-12-23T22:11:46 <kennym> is OK
442 2010-12-23T22:18:03 *** Roboraider_
443 2010-12-23T22:20:08 <ThomasWaldmann> ah, another bb fork, by kennym :)
444 2010-12-23T22:20:12 *** Roboraider
445 2010-12-23T22:20:29 <Roboraider_> Am I online?
446 2010-12-23T22:20:35 <Kapace_> no
447 2010-12-23T22:20:40 <Roboraider_> Thanks :D
448 2010-12-23T22:20:48 <Roboraider_> It said I quit.
449 2010-12-23T22:21:43 <kennym> ThomasWaldmann: this going to take some time here. Do you mind to upload the diffs to pastebin meanwhile for review?
450 2010-12-23T22:21:51 <ThomasWaldmann> your underscore twin is still here
451 2010-12-23T22:22:32 <kennym> s/to upload/uploading
452 2010-12-23T22:22:51 <ThomasWaldmann> kennym: sure, you can use pastebin. we prefer paste.pocoo.org, but every other non-crappy one is ok also.
453 2010-12-23T22:33:58 <kennym> here you go: http://fpaste.org/JFWI/
454 2010-12-23T22:41:02 <Roboraider_> Sorry to bother you, but have you looked at my analysis?
455 2010-12-23T22:43:05 <ThomasWaldmann> Roboraider_: 10mins
456 2010-12-23T22:56:38 * ThomasWaldmann added lots of details to EasyToDo fix converter issues task idea
457 2010-12-23T23:03:52 <ThomasWaldmann> http://paste.pocoo.org/show/307608/ target= is intended as <a> element attr, but comes out (after roundtrip) as querystring arg
458 2010-12-23T23:09:03 <ThomasWaldmann> Roboraider_: http://paste.pocoo.org/show/309025/ so, what you found is that the comment in line 5 is true? :)
459 2010-12-23T23:10:50 <Roboraider_> But the & in the &target=_blank is dropped in the parser. When the &target=_blank goes through the parser, it becomes target=_blank and the correct information is lost.
460 2010-12-23T23:11:53 <Roboraider_> Yes, the comment is true.
461 2010-12-23T23:12:11 <ThomasWaldmann> ok, so this obviously needs fixing :)
462 2010-12-23T23:12:36 <ThomasWaldmann> basically it needs to parse and return 2 dicts:
463 2010-12-23T23:12:47 <ThomasWaldmann> one for element attrs (like target)
464 2010-12-23T23:13:14 <ThomasWaldmann> one for querystring key/values (like &rev=42)
465 2010-12-23T23:13:29 <Roboraider_> I modified the parser to get the & in by changing the regular expression, but it returned a %2526 instead.
466 2010-12-23T23:14:30 <Roboraider_> I'm also not sure if it broke a lot of other things too.
467 2010-12-23T23:14:37 <ThomasWaldmann> well, that would need more processing then
468 2010-12-23T23:14:48 <ThomasWaldmann> currently that code is only made to deal with qs
469 2010-12-23T23:15:03 <ThomasWaldmann> and not with element attrs
470 2010-12-23T23:15:34 <ThomasWaldmann> so, inline_link_repl needs fixing, parser needs fixing
471 2010-12-23T23:16:33 <ThomasWaldmann> and likely some other places where the same syntax is used
472 2010-12-23T23:17:17 <Roboraider_> I'm not sure if I know how to solve it. I'm not very good with regular expressions :(
473 2010-12-23T23:18:17 <ThomasWaldmann> in the one you put into pastebin, you see how negative assertions work
474 2010-12-23T23:19:13 <ThomasWaldmann> maybe you could have one regex for &foo=bar (asserting the &) and another for bar=baz (negatively asserting the &)?
475 2010-12-23T23:19:19 <Roboraider_> How should I convert the %2526 to an &?
476 2010-12-23T23:20:09 <ThomasWaldmann> where exactly do you get that?
477 2010-12-23T23:20:53 <ThomasWaldmann> 25 hex = %
478 2010-12-23T23:21:07 <ThomasWaldmann> 26 hex = &
479 2010-12-23T23:21:50 <ThomasWaldmann> so & -> %26 -> %2526
480 2010-12-23T23:22:00 <Roboraider_> When I modified the parser to include the & to set the key to &target, the converter returned a %2526
481 2010-12-23T23:22:24 <ThomasWaldmann> that's because it is wrong :)
482 2010-12-23T23:22:52 <Roboraider_> Could you clarify what you mean?
483 2010-12-23T23:22:58 <ThomasWaldmann> stuff you give to url_encode is just key: value dict
484 2010-12-23T23:23:09 <ThomasWaldmann> and url_encode will add the & in between
485 2010-12-23T23:23:32 <ThomasWaldmann> so it is wrong if you have & in the key
486 2010-12-23T23:24:22 <Roboraider_> What should I replace the & with?
487 2010-12-23T23:24:28 <ThomasWaldmann> url_encode(dict(foo="bar", bar="baz"}) -> foo=bar&bar=baz
488 2010-12-23T23:24:52 <ThomasWaldmann> for that part, the code works correctly
489 2010-12-23T23:25:14 <ThomasWaldmann> the problem just is that it also catched the stuff without & and puts it into query string
490 2010-12-23T23:25:23 <ThomasWaldmann> but it should get into the element attrs
491 2010-12-23T23:25:34 <ThomasWaldmann> you know the difference between those 2?
492 2010-12-23T23:26:13 <dreimark> Roboraider_: look at kodos
493 2010-12-23T23:26:38 <Roboraider_> No.
494 2010-12-23T23:27:20 <ThomasWaldmann> [[x|label|target=_blank,&rev=42]]
495 2010-12-23T23:27:20 <dreimark> (for training with regexes)
496 2010-12-23T23:27:28 <ThomasWaldmann> shall result in:
497 2010-12-23T23:28:02 <ThomasWaldmann> <a href="/x?rev=42" target="_blank">label</a>
498 2010-12-23T23:28:31 <ThomasWaldmann> you see rev is getting into the url query string, but target gets into the element as attr
499 2010-12-23T23:29:22 <ThomasWaldmann> so these are 2 completely different things and the code is currently very wrong, because it works only for one of them
500 2010-12-23T23:29:47 <ThomasWaldmann> so it should be:
501 2010-12-23T23:30:01 <kennym> there are function calls like this one in the Python code: flash("mail recovery token not implemented yet")
502 2010-12-23T23:30:04 <ThomasWaldmann> link_args, elemet_attrs = parse(that)
503 2010-12-23T23:30:09 <kennym> should those be translated?
504 2010-12-23T23:30:18 <kennym> s/translated/localized
505 2010-12-23T23:30:57 <ThomasWaldmann> kennym: in that special case: no, that is something for developers
506 2010-12-23T23:31:07 <kennym> debug output?
507 2010-12-23T23:31:10 <ThomasWaldmann> but in the general case of flash("something"): YES!
508 2010-12-23T23:31:21 <ThomasWaldmann> yes
509 2010-12-23T23:31:44 <kennym> ThomasWaldmann: why no, in that case?
510 2010-12-23T23:31:52 <ThomasWaldmann> but flash can also be output for users, it is just shown in the next response in a box
511 2010-12-23T23:31:54 <dreimark> we should mark those with TODA
512 2010-12-23T23:31:59 <dreimark> TODO
513 2010-12-23T23:32:03 <ThomasWaldmann> because developers speak english :)
514 2010-12-23T23:32:25 <ThomasWaldmann> and we don't want translators to have to translate our debug stuff
515 2010-12-23T23:32:45 <kennym> I think you really should have given this task a higher difficulty :)
516 2010-12-23T23:33:09 <ThomasWaldmann> it's no quick task, but rather easy
517 2010-12-23T23:33:27 <kennym> that's true
518 2010-12-23T23:33:35 <ThomasWaldmann> once you know what to do, it is rather mechanic
519 2010-12-23T23:33:36 <Roboraider_> So do I just include the & as a url encoded value rather than a straight &?
520 2010-12-23T23:33:55 <ThomasWaldmann> kennym: don't switch off brain completely, though :D
521 2010-12-23T23:34:16 <kennym> ThomasWaldmann: lol
522 2010-12-23T23:36:22 <ThomasWaldmann> kennym: btw, you should use some tools, like grep or something, to locate stuff
523 2010-12-23T23:36:43 <ThomasWaldmann> create a list with that, process that list
524 2010-12-23T23:38:34 <kennym> ThomasWaldmann: good idea. Possible regexes: "flash(", "_(", "N_" . Any more?
525 2010-12-23T23:39:45 * kennym wishes that someone could turn off those annoying text captchas in the MoinMoin wiki
526 2010-12-23T23:40:11 <ThomasWaldmann> well, hardest thing is to find strings that are not marked for translation yet, but should be
527 2010-12-23T23:40:20 <dreimark> kennym: no problem
528 2010-12-23T23:41:36 <kennym> ThomasWaldmann: I'll first check if current i18n is OK, then I'll do that.
529 2010-12-23T23:41:57 <kennym> dreimark: thank you, you're a hero
530 2010-12-23T23:44:29 <dreimark> kennym: look at the changes i did on your homepage
531 2010-12-23T23:46:47 <kennym> dreimark: thanks for adding me to the "Trusted Editor Group"
532 2010-12-23T23:47:35 <dreimark> http://moinmo.in/4ct10n/info/KennyMeyer?action=diff&rev2=6&rev1=5
533 2010-12-23T23:49:17 <kennym> dreimark: oh, I see. You meant that. Sorry, I am still not very proficient with the MoinMoin wiki system.
534 2010-12-23T23:53:54 <dreimark> doing the translation task is a good start
535 2010-12-23T23:54:32 <kennym> oh, yes, it is. I think I will like MoinMoin.
536 2010-12-23T23:54:33 <dreimark> and moin-2 is different to this wiki
537 2010-12-23T23:54:45 <kennym> are you planning to upgrade?
538 2010-12-23T23:54:56 <dreimark> http://test.moinmo.in:8080/MoinMoin2
539 2010-12-23T23:55:57 <dreimark> kennym: we plan moin-2 for end of next year
540 2010-12-23T23:56:39 <kennym> dreimark: so you're still adding a lot of features, right?
541 2010-12-23T23:56:46 <dreimark> to moin-2
542 2010-12-23T23:57:23 <dreimark> moin-1.9 is stable we do only bug fixes and small improvements
543 2010-12-23T23:58:07 <dreimark> we try to stabilize it.
544 2010-12-23T23:58:17 <dreimark> (moin-2.0)
545 2010-12-23T23:59:21 <kennym> maybe I will try myself on a MoinMoin code task after this.
546 2010-12-23T23:59:30 <dreimark> :)
547 2010-12-23T23:59:32 <kennym> are most GCI task 1.9 or 2.0-centric?
548 2010-12-23T23:59:38 <kennym> s/task/tasks
549 2010-12-23T23:59:43 <dreimark> most are for 2.0
550 2010-12-23T23:59:52 <kennym> cool :)
