1 2010-12-21T00:06:30 *** maker__
2 2010-12-21T00:18:48 *** grzywacz
3 2010-12-21T00:53:03 *** waldi
4 2010-12-21T01:13:29 *** waldi
5 2010-12-21T01:26:52 *** jordonwii
6 2010-12-21T01:36:34 <jordonwii> ThomasWaldmann or dreimark: Did you get my message earlier?
7 2010-12-21T01:59:41 *** jordonwii
8 2010-12-21T02:04:59 *** jbills_
9 2010-12-21T02:05:22 <jbills_> Why has no one reviewed my code?
10 2010-12-21T02:06:01 <jbills_> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970449
11 2010-12-21T02:09:47 <jbills> hi
12 2010-12-21T02:15:33 *** jbills_
13 2010-12-21T02:15:54 <jbills> hi
14 2010-12-21T02:15:56 <jbills> hi
15 2010-12-21T02:15:57 <jbills> hi
16 2010-12-21T02:24:35 *** jbills_
17 2010-12-21T02:31:30 *** jbills_
18 2010-12-21T02:43:20 *** jbills_
19 2010-12-21T02:50:21 *** jbills_
20 2010-12-21T04:06:37 *** Roboraider
21 2010-12-21T06:45:12 *** skylamer`
22 2010-12-21T06:57:35 *** skylamer`
23 2010-12-21T07:27:54 <dreimark> jordonwii: two patches, because two different issues
24 2010-12-21T07:28:16 <dreimark> two kind of different cleanup
25 2010-12-21T07:53:02 <dreimark> jbills: when do you add an explaination why you check all that html stuff on the right side of == ?
26 2010-12-21T08:10:46 <dreimark> ThomasWaldmann: please prepare a http://moinmo.in/EasyToDo/find%20a%20bug%2C%20fix%20a%20bug%20%28easy%29 for the fixes by jordowii
27 2010-12-21T08:11:19 <dreimark> so that we can give him an open task for his new patches
28 2010-12-21T08:36:58 <dreimark> bbl
29 2010-12-21T08:50:53 *** pvinogradov_
30 2010-12-21T10:26:26 *** rfw
31 2010-12-21T10:40:20 *** kursor
32 2010-12-21T10:45:07 <ronny> re
33 2010-12-21T10:46:07 <ronny> dreimark: coverage usage in moin should be replaced by the pytest coverage plugin, same goes for pep8
34 2010-12-21T10:59:26 <ThomasWaldmann> dreimark: some tasks are available in the unpublished queue. i published one of them (but you could have done that also).
35 2010-12-21T11:00:26 <ThomasWaldmann> dreimark: jbills commented that code recently and uses some less complicated code now
36 2010-12-21T11:00:43 <ThomasWaldmann> but still there are some fundamental issues, like usage of ids
37 2010-12-21T11:02:49 *** greg_f
38 2010-12-21T11:23:31 *** jbills_
39 2010-12-21T11:32:41 *** jbills
40 2010-12-21T12:22:52 *** NikitaUtiu
41 2010-12-21T12:37:13 *** skylamer`
42 2010-12-21T12:38:26 <xorAxAx> ThomasWaldmann: do you have a gci import pending or should i import my task?
43 2010-12-21T12:51:23 <dreimark> ThomasWaldmann: i didn't saw that one
44 2010-12-21T12:57:56 <dreimark> ThomasWaldmann: deadline for jbills_ tasks is in 3h45min
45 2010-12-21T12:59:19 <ThomasWaldmann> xorAxAx: if you make it ready on the wiki, it'll be automatically in next batch
46 2010-12-21T12:59:26 <xorAxAx> ThomasWaldmann: its ready
47 2010-12-21T13:00:07 <ThomasWaldmann> if you want it in there quickly, you can bulk upload it yourself
48 2010-12-21T13:00:22 <ThomasWaldmann> i usually do that if some few have accumulated there
49 2010-12-21T13:01:08 <ThomasWaldmann> (in general, we should put some major task into the system for xmas vacation)
50 2010-12-21T13:01:31 <dreimark> true
51 2010-12-21T13:01:36 <ThomasWaldmann> xorAxAx: duration 72 == 3d for a difficult task?
52 2010-12-21T13:01:59 <xorAxAx> well, it says 12h per day
53 2010-12-21T13:02:04 <xorAxAx> so i gave 6 days
54 2010-12-21T13:02:09 <ThomasWaldmann> no
55 2010-12-21T13:02:20 <ThomasWaldmann> it says workhours * 12
56 2010-12-21T13:02:26 <ThomasWaldmann> thus 2h per day
57 2010-12-21T13:03:00 <ThomasWaldmann> hours given in the duration values are clock hours
58 2010-12-21T13:03:39 <ThomasWaldmann> so if you expect that it takes 72 man hours, that would give 72*12
59 2010-12-21T13:04:07 <xorAxAx> ah
60 2010-12-21T13:04:50 <xorAxAx> hmm, but 6 hours might be enough
61 2010-12-21T13:05:05 <xorAxAx> nevertheless its difficult .)
62 2010-12-21T13:05:09 <dreimark> xorAxAx: if someone is faster it does not matter
63 2010-12-21T13:05:57 <dreimark> 144h is a good time
64 2010-12-21T13:06:06 <xorAxAx> well, ok
65 2010-12-21T13:19:14 <NikitaUtiu> hey! about the GCI test: what did you exactly mean with 'reduce code duplication' ?
66 2010-12-21T13:19:52 <xorAxAx> NikitaUtiu: code duplication means that you used copy&paste to copy similar code parts
67 2010-12-21T13:20:43 <NikitaUtiu> xorAxAx: and how should i reduce it? rewrite the code ?
68 2010-12-21T13:21:10 <xorAxAx> yes
69 2010-12-21T13:25:29 <ThomasWaldmann> NikitaUtiu: just have a look at that file. that place where it deals with /foo and ../foo pathes was duplicate already when you started (not your fault), but you just added another duplication of it.
70 2010-12-21T13:26:01 <ThomasWaldmann> so, that piece of code should be moved to a function and called from the places where needed
71 2010-12-21T13:26:15 <NikitaUtiu> ok
72 2010-12-21T13:26:53 <ThomasWaldmann> one can also have some docstring in that function then, that tells what this stuff does
73 2010-12-21T13:27:18 <NikitaUtiu> ok, and can this give me a test_sourcecode fail ?
74 2010-12-21T13:27:35 <ThomasWaldmann> btw, it would be good if that was a separate cleanup patch
75 2010-12-21T13:27:47 <ThomasWaldmann> no
76 2010-12-21T13:28:00 <ThomasWaldmann> but afaics you have some trailing blanks in your changes
77 2010-12-21T13:28:09 <ThomasWaldmann> also you added empty lines with no special reason
78 2010-12-21T13:28:26 <ThomasWaldmann> our sourcecode checker is rather picky :)
79 2010-12-21T13:28:43 <ThomasWaldmann> do you use vim?
80 2010-12-21T13:28:56 <NikitaUtiu> well, cream, but still it's vim
81 2010-12-21T13:29:16 <ThomasWaldmann> (a good idea is to completely and slowly read a diff before committing / submitting)
82 2010-12-21T13:29:32 <ThomasWaldmann> often one finds such stuff that way, also typos and stuff to improve
83 2010-12-21T13:30:02 <ThomasWaldmann> http://moinmo.in/CodingStyle see Vim Python PEP8 helper
84 2010-12-21T13:31:58 <NikitaUtiu> i'll diff it and read it again then :) i'll be right back
85 2010-12-21T13:37:20 * ThomasWaldmann uses hg and the usual thing is edit, hg diff, hg status, (loop until completely happy), hg commit
86 2010-12-21T13:38:40 <ThomasWaldmann> btw, that procedure also helps to find sane commit comments, because you have just read the diff and thought about all your changes
87 2010-12-21T13:50:33 <jbills_> dreimark: Where is the equal sign
88 2010-12-21T13:51:13 <jbills_> double equal sign
89 2010-12-21T13:53:18 <jbills_> sorry that was my old code forgot to remove it
90 2010-12-21T13:57:37 <ThomasWaldmann> pvinogradov: i get this when trying to merge your work:
91 2010-12-21T13:57:38 <ThomasWaldmann> - def test_favicon(self):
92 2010-12-21T13:57:38 <ThomasWaldmann> + def stest_favicon(self):
93 2010-12-21T13:58:54 *** NikitaUtiu
94 2010-12-21T13:59:56 <pvinogradov> ThomasWaldmann: hm, sorry
95 2010-12-21T14:00:47 <ThomasWaldmann> also, those 123... passwords are also looking forward to failure if we have pw policy
96 2010-12-21T14:01:39 <ThomasWaldmann> how about Xiwejr622? :)
97 2010-12-21T14:02:20 <jbills_> Submitted more work
98 2010-12-21T14:02:21 <jbills_> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970449
99 2010-12-21T14:02:25 <pvinogradov> ok, prepare last update for this bug
100 2010-12-21T14:02:47 <ThomasWaldmann> hmm, if we don't have pw policy yet in moin2, we should maybe forward port or use the code we have for moin1
101 2010-12-21T14:03:05 *** NikitaUtiu
102 2010-12-21T14:03:11 <ThomasWaldmann> pvinogradov: btw, good changeset, reduced code duplication significantly
103 2010-12-21T14:05:03 <jbills_> I have 2 hours left
104 2010-12-21T14:05:34 <ThomasWaldmann> jbills_: i am looking asap
105 2010-12-21T14:05:43 <jbills_> Thank u
106 2010-12-21T14:06:13 <ThomasWaldmann> that id stuff, did you think about it?
107 2010-12-21T14:07:53 <ThomasWaldmann> -/* support for firefox 3.5/3.6 and safari */
108 2010-12-21T14:07:54 <ThomasWaldmann> +/* support for firefox 3.5/3.6 and safari*/
109 2010-12-21T14:08:04 <ThomasWaldmann> did you read your diff?
110 2010-12-21T14:09:15 <jbills_> I thank so...
111 2010-12-21T14:10:06 <ThomasWaldmann> pvinogradov: btw, maybe you could have a look whether we need a task about pw policy - could be your next one, you're well prepared in that area :)
112 2010-12-21T14:10:42 <ThomasWaldmann> in moin 1.9 it was pw_checker or password_checker or so (in the config)
113 2010-12-21T14:11:00 <ThomasWaldmann> and it knows about US and german and some other keyboards :)
114 2010-12-21T14:11:09 <jbills_> oops probobly windows line breaks
115 2010-12-21T14:11:58 <jbills_> http://pastebin.com/1MFurUJm
116 2010-12-21T14:12:15 <jbills_> here it is with that fixxed
117 2010-12-21T14:12:55 <ThomasWaldmann> ok, ids?
118 2010-12-21T14:13:58 <pvinogradov> ThomasWaldmann: thanks. I'm try to write better code. All your suggestions implemented and commited
119 2010-12-21T14:14:05 <jbills_> yes
120 2010-12-21T14:14:11 <jbills_> I think so
121 2010-12-21T14:14:34 <jbills_> I have changed them to div.***
122 2010-12-21T14:15:06 <ThomasWaldmann> id is an element attribute, not an element type
123 2010-12-21T14:15:22 <jbills_> I now
124 2010-12-21T14:15:35 <ThomasWaldmann> and it is about id uniqueness, classes not required to be unique
125 2010-12-21T14:15:45 <jbills_> I have changed it in the stylesheet to div.***
126 2010-12-21T14:18:39 <ThomasWaldmann> pvinogradov: test_faul_user_...
127 2010-12-21T14:18:47 <ThomasWaldmann> fail maybe?
128 2010-12-21T14:19:01 <ThomasWaldmann> sorry, didn't see this last time
129 2010-12-21T14:19:45 *** Samm
130 2010-12-21T14:20:44 <pvinogradov> yes, fail. Maybe something else?:)
131 2010-12-21T14:20:58 <ThomasWaldmann> still looking, wait a sec :)
132 2010-12-21T14:23:04 <ThomasWaldmann> you sometimes use u'', sometimes '' for name/password. please always use u'...'
133 2010-12-21T14:23:51 <jbills_> ThomasWaldmann: Is there anything else wrong with my patch?
134 2010-12-21T14:25:55 <ThomasWaldmann> jbills_: you mean additionally to ids being used?
135 2010-12-21T14:27:28 <ThomasWaldmann> it is still using elem[0] - i already commented on that
136 2010-12-21T14:28:26 <ThomasWaldmann> the js is still looking inconsistently formatted. in 87 formatting is bad, in 102 it is good.
137 2010-12-21T14:29:25 <ThomasWaldmann> is your js indented by 7 blanks?
138 2010-12-21T14:30:30 * ThomasWaldmann already suggested to not use 8 or tabs, but rather 4 or so
139 2010-12-21T14:30:41 <ThomasWaldmann> 4 blanks, to be precise
140 2010-12-21T14:31:17 <ThomasWaldmann> btw, we could proceed much faster if we would not need to repeat same stuff again
141 2010-12-21T14:31:31 <jbills_> Hows this. Fixxed Ids
142 2010-12-21T14:31:32 <jbills_> http://pastebin.com/jdwT2n1m
143 2010-12-21T14:32:16 <jbills_> It is 4 blanks on my pc
144 2010-12-21T14:32:26 <ThomasWaldmann> + displaytext = {html.id_: 'displaytext',
145 2010-12-21T14:32:37 <ThomasWaldmann> this is an id, right?
146 2010-12-21T14:32:57 <ThomasWaldmann> + showhide = {html.id_: 'showhide'
147 2010-12-21T14:32:59 <ThomasWaldmann> another
148 2010-12-21T14:33:59 <ThomasWaldmann> + html.id_: 'm%s' % count,
149 2010-12-21T14:34:01 <ThomasWaldmann> another
150 2010-12-21T14:34:14 <jbills_> Apparently find replace does not find everythinh
151 2010-12-21T14:34:25 <ThomasWaldmann> + $('<li id="toclimin"
152 2010-12-21T14:34:28 <ThomasWaldmann> another
153 2010-12-21T14:35:24 <ThomasWaldmann> id means "this uniquely identifies this element" - you can't have multiple same IDs
154 2010-12-21T14:35:36 <jbills_> http://pastebin.com/YrQ6gJ62
155 2010-12-21T14:35:46 <jbills_> wait
156 2010-12-21T14:36:06 <jbills_> http://pastebin.com/3LHuP7SN
157 2010-12-21T14:36:23 <ThomasWaldmann> btw, do you know validator.w3.org?
158 2010-12-21T14:36:36 <jbills_> yes
159 2010-12-21T14:37:22 <ThomasWaldmann> hmm, only works for static stuff maybe, not for stuff you dynamically do via js
160 2010-12-21T14:37:41 <jbills_> uhhh
161 2010-12-21T14:37:53 <ThomasWaldmann> (i mean the validator)
162 2010-12-21T14:39:49 <jbills_> I used jslint
163 2010-12-21T14:39:57 <ThomasWaldmann> $('#toclimin') - this only works with id, right?
164 2010-12-21T14:40:52 <jbills_> oops
165 2010-12-21T14:41:45 <jbills_> http://pastebin.com/ETrCJyBg
166 2010-12-21T14:41:47 <ThomasWaldmann> maybe you need to thoroughly test your stuff, practically
167 2010-12-21T14:42:09 <ThomasWaldmann> just use a page that includes 2 other pages that both have a toc on them
168 2010-12-21T14:43:12 <jbills_> pastebin of creole?
169 2010-12-21T14:43:16 <ThomasWaldmann> huh, return of the IDs?
170 2010-12-21T14:43:26 <jbills_> where
171 2010-12-21T14:43:41 <ThomasWaldmann> your latest pastebin line 9?
172 2010-12-21T14:44:39 <ThomasWaldmann> somehow i feel you need better revision control :)
173 2010-12-21T14:45:39 <jbills_> Yes
174 2010-12-21T14:45:42 <jbills_> I du
175 2010-12-21T14:46:58 <jbills_> pastebin of creole?
176 2010-12-21T14:47:06 <jbills_> to use
177 2010-12-21T14:47:49 <NikitaUtiu> should i write the unit test only for itemtransclusions or for both it and itemlinks ?
178 2010-12-21T14:49:10 <jbills_> http://pastebin.com/zMarTi4f
179 2010-12-21T14:51:29 <CIA-56> pavel_vinogradov default * 10164:03fc2038b8ab 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py: Add unit test for "check old password when user change password in wiki"
180 2010-12-21T14:51:31 <CIA-56> pavel_vinogradov default * 10165:88573fe9ca8d 2.0-dev/MoinMoin/apps/frontend/views.py: Add real password check for old user password (on password change action in wiki)
181 2010-12-21T14:51:33 <CIA-56> Pavel Vinogradov <pavel.vinogradov@nixdev.net> default * 10166:33976ea1bed3 2.0-dev/MoinMoin/converter/moinwiki_in.py: Remove trailing whitespace
182 2010-12-21T14:51:34 <CIA-56> pavel_vinogradov default * 10167:9ef4c0799baa 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py: Add new unit tests for password change feature (unicode password, check new password match)
183 2010-12-21T14:51:36 <CIA-56> pavel_vinogradov default * 10168:3ac10db0e0f7 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py:
184 2010-12-21T14:51:36 <CIA-56> reorder form entries in unit tests for password change (e.g. that password old first, password1 and 2 are subsequent lines, submit last)
185 2010-12-21T14:51:36 <CIA-56> create new helper function to fill UserSettingsPasswordorm
186 2010-12-21T14:51:39 <CIA-56> pavel_vinogradov default * 10169:a98c8b4b884d 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py:
187 2010-12-21T14:51:40 <CIA-56> Don't use sample data (with name == password) in unit test
188 2010-12-21T14:51:40 <CIA-56> This behaviour maybe changed latter in moin password policy
189 2010-12-21T14:51:42 <CIA-56> pavel_vinogradov default * 10170:7926267d0b41 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py: Enable favicon unit test, which was disabled by mistake
190 2010-12-21T14:51:43 <CIA-56> pavel_vinogradov default * 10171:fc1134f7a135 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py: Use more complicated passwords in unit tests.
191 2010-12-21T14:51:45 <CIA-56> pavel_vinogradov default * 10172:68b36eb7d7cb 2.0-dev/MoinMoin/apps/frontend/_tests/test_frontend.py:
192 2010-12-21T14:51:45 <CIA-56> Use unicode strings in password change unit tests
193 2010-12-21T14:51:45 <CIA-56> Fix typo in test name
194 2010-12-21T14:51:47 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10173:22af9fe9cd60 2.0-dev/MoinMoin/ (3 files in 3 dirs): merged http://bitbucket.org/pavel_vinogradov/gci10-moin-2.0-dev
195 2010-12-21T14:52:29 <jbills_> ThomasWaldmann: May I have a deadline extension
196 2010-12-21T14:52:37 <jbills_> Or review
197 2010-12-21T14:52:43 <jbills_> of my code?
198 2010-12-21T14:56:00 <ThomasWaldmann> NikitaUtiu: if you could do both, that would be great. most of the code is the same anyway.
199 2010-12-21T14:56:21 <NikitaUtiu> ThomasWaldmann: ok
200 2010-12-21T14:56:35 <ThomasWaldmann> NikitaUtiu: as an implementation hint: maybe test XML/domtree -> link list / transcl. list
201 2010-12-21T14:56:46 <jbills_> ThomasWaldmann: I am clueless about creole can I have a wiki page to test my toc code
202 2010-12-21T14:56:54 <ThomasWaldmann> NikitaUtiu: so you really just test your converter, not lots of other code
203 2010-12-21T14:57:13 <ThomasWaldmann> jbills_: you never tested it practically?
204 2010-12-21T14:57:23 <jbills_> Yes
205 2010-12-21T14:57:27 <ThomasWaldmann> (doesn't need to be creole btw)
206 2010-12-21T14:57:37 <jbills_> any wiki markup than
207 2010-12-21T14:57:58 <jbills_> u said something about embeded pages
208 2010-12-21T14:59:46 <jbills_> how would u do that?
209 2010-12-21T15:00:15 <ThomasWaldmann> jbills_: http://test.moinmo.in:8080/toctest
210 2010-12-21T15:00:40 <ThomasWaldmann> make sure you transfer those 3 pages to a local backup
211 2010-12-21T15:00:44 <jbills_> thanks
212 2010-12-21T15:00:52 <ThomasWaldmann> i plan to kill and reinstall that test wiki soon
213 2010-12-21T15:01:26 <ThomasWaldmann> now you see why using same ids won't work
214 2010-12-21T15:03:03 <ThomasWaldmann> NikitaUtiu: grep the tests for "XML", iirc such stuff is already done at other places
215 2010-12-21T15:03:28 <NikitaUtiu> ThomasWaldmann: sure
216 2010-12-21T15:04:42 <ThomasWaldmann> btw, you could also add a similar, but separate test with links like [[target#anchor]] or [[http://example.org]]
217 2010-12-21T15:05:38 <ThomasWaldmann> if it erroneously finds such stuff in ITEMLINKS or ITEMTRANSCLUSIONS, you can do an extra task for bugfixing that afterwards
218 2010-12-21T15:06:26 <ThomasWaldmann> (ITEMLINKS and ITEMTRANSCLUSION shall only have internal wiki item names, no anchors, no external links)
219 2010-12-21T15:06:46 <NikitaUtiu> so, this one separate? ok i'll try
220 2010-12-21T15:07:41 <ThomasWaldmann> if you make the failing task now, you can just directly claim "find a failing test, fix it"
221 2010-12-21T15:07:51 <ThomasWaldmann> ehrm test*
222 2010-12-21T15:08:23 <ThomasWaldmann> (that breakage was already there before you started working on it :)
223 2010-12-21T15:09:33 <NikitaUtiu> so, a TODO comment next to it ? or how ?
224 2010-12-21T15:10:34 <jbills_> ThomasWaldmann: It works but because of class it minimizes all with same class
225 2010-12-21T15:11:33 <ThomasWaldmann> NikitaUtiu: you could use py.test.xfail
226 2010-12-21T15:11:44 <ThomasWaldmann> because currently it is expected to fail
227 2010-12-21T15:12:04 <NikitaUtiu> oh
228 2010-12-21T15:12:24 <ThomasWaldmann> i mean the anchor/external stuff - IF it fails
229 2010-12-21T15:12:36 <ThomasWaldmann> the standard internal item should work, of course
230 2010-12-21T15:13:21 <jbills_> ThomasWaldmann: It works but because of class it minimizes all of the toc items with that class
231 2010-12-21T15:19:40 <ThomasWaldmann> jbills_: heh, yeah. for that definition of "works". <g>
232 2010-12-21T15:20:25 <jbills_> Do you know how to fix it?
233 2010-12-21T15:21:34 <jbills_> Can you guess how to fix it?
234 2010-12-21T15:26:05 *** jbills_
235 2010-12-21T15:27:56 <NikitaUtiu> ThomasWaldmann: the anchor stuff fails
236 2010-12-21T15:28:21 <jbills> ThomasWaldmann: Can you guess how to fix it?
237 2010-12-21T15:45:46 *** pvinogradov
238 2010-12-21T15:49:56 <jbills> ThomasWaldmann: Can you guess how to fix it?
239 2010-12-21T15:54:13 <NikitaUtiu> ThomasWaldmann: nvm, it doesn't
240 2010-12-21T16:00:23 *** Samm
241 2010-12-21T16:12:54 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5752:657bf0479970 1.9/MoinMoin/search/Xapian/indexing.py: xapian indexing: make sure done_count is initialized early (fix crash when index is locked)
242 2010-12-21T16:13:11 *** Samm
243 2010-12-21T16:49:25 *** NikitaUtiu
244 2010-12-21T16:50:04 *** skylamer`
245 2010-12-21T17:01:04 <ThomasWaldmann> sorry, was busy at work :)
246 2010-12-21T17:09:01 <ThomasWaldmann> jbills: i didn't practically try that code yet (and I am still at work), but you should just try it practically
247 2010-12-21T17:09:38 <ThomasWaldmann> if it does what the user wants, we maybe can live with some other tocs also expanding or collapsing in parallel
248 2010-12-21T17:10:18 <ThomasWaldmann> if one only wants some specific part to collapse/expand, you will have to use unique(!) ids
249 2010-12-21T17:10:36 <ThomasWaldmann> but this will get definitely more complicated then
250 2010-12-21T17:24:09 <jbills> I have submitted my work
251 2010-12-21T17:26:26 <ThomasWaldmann> + displaytext = {html.id_: 'displaytext',
252 2010-12-21T17:27:03 <ThomasWaldmann> hmm, patch submitted is not same as in dropbox
253 2010-12-21T17:27:09 <ThomasWaldmann> looking at the dropbox thing now
254 2010-12-21T17:27:23 <jbills> I no that one was merlange error
255 2010-12-21T17:28:10 <ThomasWaldmann> ok, I'll practically try this one
256 2010-12-21T17:29:26 <jbills> Thanks
257 2010-12-21T17:31:55 <ThomasWaldmann> hmm, i don't see any effect
258 2010-12-21T17:32:23 <ThomasWaldmann> the tocs just have a headline, and entries, but no controls to expand/collapse
259 2010-12-21T17:32:44 <ThomasWaldmann> btw, do you clear the cache when trying a new version?
260 2010-12-21T17:33:50 <jbills> no
261 2010-12-21T17:34:07 <jbills> does the heading have subheadings
262 2010-12-21T17:34:26 <ThomasWaldmann> i used the pages i created on test.moinmo.in
263 2010-12-21T17:34:48 <jbills> hmm
264 2010-12-21T17:35:32 <ThomasWaldmann> does it work for you, after clearing browser cache?
265 2010-12-21T17:36:38 <jbills> http://www.dropmocks.com/mOVSp give me a minute
266 2010-12-21T17:37:00 <jbills> thats what It looks like before clearing the cache
267 2010-12-21T17:37:38 * ThomasWaldmann uses ff3613
268 2010-12-21T17:38:16 <ThomasWaldmann> that upper area of the toc in your screenshot looks a bit strange
269 2010-12-21T17:38:40 <jbills> It works
270 2010-12-21T17:38:50 <jbills> after clearing the cache
271 2010-12-21T17:39:14 <ThomasWaldmann> can you try with ff? and cleared cache in ff?
272 2010-12-21T17:40:53 <jbills> It work after cache clear
273 2010-12-21T17:41:09 <ThomasWaldmann> strange :)
274 2010-12-21T17:41:18 <jbills> It may be that I use an old version of moinmoin2
275 2010-12-21T17:41:30 <ThomasWaldmann> can you use a clean up-to-date repo and apply your patch yourself?
276 2010-12-21T17:41:38 <jbills> ok
277 2010-12-21T17:41:44 <ThomasWaldmann> maybe first make a copy of what you have :)
278 2010-12-21T17:42:02 <jbills> btw the gradient background only works in firefox
279 2010-12-21T17:42:04 <ThomasWaldmann> hg clone myrepo mycleanrepo
280 2010-12-21T17:42:10 <jbills> at least in my version
281 2010-12-21T17:42:15 <ThomasWaldmann> cd mycleanrepo
282 2010-12-21T17:42:21 <ThomasWaldmann> hg pull -u
283 2010-12-21T17:42:26 <ThomasWaldmann> then apply patch there
284 2010-12-21T17:42:32 *** NikitaUtiu
285 2010-12-21T17:42:51 <ThomasWaldmann> jbills: i have recently added compat code for ff and safari
286 2010-12-21T17:43:06 <jbills> ok
287 2010-12-21T17:43:12 <ThomasWaldmann> other than those, it maybe only works if browser has css3 support for such stuff
288 2010-12-21T17:43:17 <jbills> cause it looks gr8
289 2010-12-21T17:43:50 <ThomasWaldmann> i just noticed that on my work tft, it is white enough. on my laptop it is a bit too blue long term.
290 2010-12-21T17:44:10 <jbills> 4 chunks left
291 2010-12-21T17:44:22 <ThomasWaldmann> hm?
292 2010-12-21T17:44:36 <jbills> nevermind
293 2010-12-21T17:45:18 <ThomasWaldmann> argh
294 2010-12-21T17:45:22 <ThomasWaldmann> sorry, was my fault
295 2010-12-21T17:45:40 <ThomasWaldmann> i first had tried with --dry-run to see if it'ld apply cleanly
296 2010-12-21T17:45:50 <ThomasWaldmann> and then forgot the non-dry patching :)
297 2010-12-21T17:46:02 <ThomasWaldmann> it now has the [-]
298 2010-12-21T17:46:27 <ThomasWaldmann> but I see BUGS :)
299 2010-12-21T17:47:00 <ThomasWaldmann> can you click on the [-] right of upper foo1 toc entry? to collapse it?
300 2010-12-21T17:47:10 <jbills> oh
301 2010-12-21T17:47:12 <jbills> :)
302 2010-12-21T17:47:13 <jbills> lol
303 2010-12-21T17:47:15 <ThomasWaldmann> and now look at lower toc
304 2010-12-21T17:49:53 <jbills> what wrong with the lower toc
305 2010-12-21T17:50:06 <ThomasWaldmann> i then has same text as upper toc :)
306 2010-12-21T17:50:21 <jbills> oh...
307 2010-12-21T17:50:24 <ThomasWaldmann> if it was foo2 before, it'll be foo1 afterwards
308 2010-12-21T17:50:34 <jbills> Big bug
309 2010-12-21T17:51:11 <jbills> so... random ids?
310 2010-12-21T17:51:46 <ThomasWaldmann> first another question: those class="liX" or "aX", do you really need them?
311 2010-12-21T17:51:56 <jbills> no
312 2010-12-21T17:52:07 <jbills> but I like to have them just in case
313 2010-12-21T17:52:30 <ThomasWaldmann> hehe
314 2010-12-21T17:52:47 <ThomasWaldmann> but these have potentially the same problem
315 2010-12-21T17:53:07 <ThomasWaldmann> i guess i know what you really want
316 2010-12-21T17:53:21 <ThomasWaldmann> <a class="a1" href="#foo1" ...
317 2010-12-21T17:53:44 <ThomasWaldmann> that #foo1 is an anchor target generated by the system
318 2010-12-21T17:54:01 <ThomasWaldmann> if you assume the system works correctly, that anchor target must be unique
319 2010-12-21T17:54:05 <ThomasWaldmann> so, use that :)
320 2010-12-21T17:54:37 <ThomasWaldmann> and suffix it with something, e.g. foo1toc
321 2010-12-21T17:55:34 <ThomasWaldmann> href="javascript:void()" what does that do, btw?
322 2010-12-21T17:55:52 *** kursor
323 2010-12-21T17:56:07 <jbills> oh it makes the link have a poin cursor
324 2010-12-21T17:56:43 <ThomasWaldmann> and without that href, it would be what?
325 2010-12-21T17:57:12 <jbills> just a normal arrow
326 2010-12-21T17:57:25 <jbills> It does not look good in my opinion
327 2010-12-21T17:57:50 <ThomasWaldmann> ah. just wondered about javascript:
328 2010-12-21T17:57:57 <ThomasWaldmann> such stuff makes me suspicious :)
329 2010-12-21T17:58:45 <ThomasWaldmann> btw, the upper [-] looks a bit alone up there. could you place it right to "Contents"?
330 2010-12-21T17:59:29 <ThomasWaldmann> (it is there when toc is collapsed, but not if it is not collapsed)
331 2010-12-21T18:03:30 <jbills> no I can not its wierd that way
332 2010-12-21T18:03:47 <jbills> its either above or below
333 2010-12-21T18:05:35 <ThomasWaldmann> well, it is likely because it lives in its own div, which is a block element
334 2010-12-21T18:05:52 <jbills> the min
335 2010-12-21T18:05:55 <jbills> ??
336 2010-12-21T18:06:06 <ThomasWaldmann> the [-]
337 2010-12-21T18:06:10 <jbills> ok
338 2010-12-21T18:06:57 <ThomasWaldmann> what would happen if you inject it into table-of-contents div?
339 2010-12-21T18:08:06 <ThomasWaldmann> ehrm, i mean table-of-contents-heading
340 2010-12-21T18:11:57 <NikitaUtiu> hi! do you have a good reference about the elementtree xml syntax, i would have to build the element tree by hand else
341 2010-12-21T18:12:21 <ThomasWaldmann> NikitaUtiu: ehrm, just load a piece of xml?
342 2010-12-21T18:13:31 <NikitaUtiu> ThomasWaldman: yes, i want to learn more about the domtree xml so i can write the test cases in xml
343 2010-12-21T18:14:51 <ThomasWaldmann> you could get the xml by just running the converter on some markup input usable for that test
344 2010-12-21T18:15:42 <ThomasWaldmann> NikitaUtiu: http://localhost:8080/+dom/toctest it is not exactly what you need, but you might get some insight
345 2010-12-21T18:15:51 <ThomasWaldmann> wait :)
346 2010-12-21T18:16:00 <jbills> ThomasWaldmann: almost done.
347 2010-12-21T18:16:02 <NikitaUtiu> that local
348 2010-12-21T18:16:05 <ThomasWaldmann> http://test.moinmo.in:8080/+dom/toctest
349 2010-12-21T18:16:48 <NikitaUtiu> so the dom action returns the xml ?
350 2010-12-21T18:16:59 <ThomasWaldmann> at some specific stage, yes
351 2010-12-21T18:17:09 <ThomasWaldmann> you have to see whether it is the right stage for you
352 2010-12-21T18:17:12 <jbills> ThomasWaldmann: DONE!!!
353 2010-12-21T18:17:27 <ThomasWaldmann> jbills: lets see first .)
354 2010-12-21T18:17:34 <jbills> kk
355 2010-12-21T18:19:09 <ThomasWaldmann> NikitaUtiu: you maybe have to slightly modify how the +dom view works. iirc it is AFTER link converter
356 2010-12-21T18:22:28 <jbills> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970449
357 2010-12-21T18:23:05 <jbills> dont forget to do a real run after the dry-run
358 2010-12-21T18:23:08 <ThomasWaldmann> btw is there any special reason why you use .remove() and not .hide()?
359 2010-12-21T18:23:15 <ThomasWaldmann> hehe, yes :)
360 2010-12-21T18:24:04 <jbills> ok
361 2010-12-21T18:24:23 <jbills> Do you want 30 or so copys in the code?
362 2010-12-21T18:24:46 <ThomasWaldmann> patch: **** malformed patch at line 128: /* support for firefox 3.5/3.6 and safari */
363 2010-12-21T18:24:58 <jbills> ok
364 2010-12-21T18:25:17 <jbills> http://pastebin.com/XCtJfC3d
365 2010-12-21T18:25:34 <jbills> there
366 2010-12-21T18:30:31 <ThomasWaldmann> that's a crap pastebin
367 2010-12-21T18:30:40 <ThomasWaldmann> if you click raw, you still get html :|
368 2010-12-21T18:39:22 <jbills> oh
369 2010-12-21T18:39:53 <jbills> http://pastebin.com/2RUj3eM1
370 2010-12-21T18:40:01 <jbills> this uses diff format
371 2010-12-21T18:45:08 <ThomasWaldmann> ok, that works :)
372 2010-12-21T18:48:59 <ThomasWaldmann> jbills: did you notice that the looks of Contents [*] changes when expanding/collapsing?
373 2010-12-21T18:50:20 <ThomasWaldmann> btw, i did not quite understand "(18:24) < jbills> Do you want 30 or so copys in the code?
374 2010-12-21T18:50:23 <ThomasWaldmann> "
375 2010-12-21T18:51:14 <ThomasWaldmann> isn't .show() and .hide() made for what you are doing with .remove() and .insertBefore()?
376 2010-12-21T18:52:39 <ThomasWaldmann> and that lines where you are using insertBefore() have quite some hardcoded html and one has even a translateable string
377 2010-12-21T18:54:02 <jbills> because the code destroys than inserts. If I used hide it would create copies
378 2010-12-21T18:54:41 <NikitaUtiu> ThomasWaldmann: should i write a separate teste for anchors and external links even if it currently passes it
379 2010-12-21T18:54:42 <ThomasWaldmann> what would create copies exactly?
380 2010-12-21T18:56:12 <ThomasWaldmann> NikitaUtiu: can you show your code in a pastebin (and test input and output)?
381 2010-12-21T18:56:25 <jbills> the insertbefore
382 2010-12-21T18:56:44 <ThomasWaldmann> jbills: and if you use show() instead of insertBefore?
383 2010-12-21T18:56:58 <jbills> It does not work just tested
384 2010-12-21T18:56:59 <NikitaUtiu> ThomasWaldmann: sure, how was the site called ?
385 2010-12-21T18:57:23 <ThomasWaldmann> paste.pocoo.org
386 2010-12-21T18:58:38 <jbills> "jbills: did you notice that the looks of Contents [*] changes when expanding/collapsing?" Yes I did that on purpose so you could maximize with any part of contents
387 2010-12-21T18:58:45 <NikitaUtiu> http://paste.pocoo.org/show/307984/
388 2010-12-21T18:59:38 <jbills> ThomasWaldmann: What should I do instead of hard coded html?
389 2010-12-21T18:59:48 <ThomasWaldmann> jbills: ah. ok, that at least explains it. but still it looks a bit strangely jumping. :)
390 2010-12-21T19:00:15 <jbills> ok
391 2010-12-21T19:00:30 <ThomasWaldmann> jbills: i don't know too much of js (at least not practically), but the basic idea is that the toc is there, expanded, with all it needs
392 2010-12-21T19:00:41 <ThomasWaldmann> this is the html we produce
393 2010-12-21T19:00:42 <NikitaUtiu> i also renamed some classes and methods more verbosely
394 2010-12-21T19:01:07 <ThomasWaldmann> the js then only shows and hides misc. parts of it when you click on [*]
395 2010-12-21T19:01:39 <ThomasWaldmann> it doesn't really need to change the text or the html (except from what show/hide does internally)
396 2010-12-21T19:02:50 <jbills> what do you meen?
397 2010-12-21T19:03:39 <ThomasWaldmann> NikitaUtiu: ns1:href="wiki.local:/moin?" are you linking to an item called "moin?" ?
398 2010-12-21T19:03:59 <ThomasWaldmann> jbills: that that would be much easier and less fragile
399 2010-12-21T19:04:25 <jbills> can you show me the idea I dont really understand
400 2010-12-21T19:04:30 <ThomasWaldmann> if you rip out some html from the dom and put some (other?) html back in there, it can easily happen that this gets out of sync
401 2010-12-21T19:04:42 <jbills> ok
402 2010-12-21T19:04:42 <ThomasWaldmann> e.g. Content could be also Inhaltverzeichnis in german
403 2010-12-21T19:05:04 <jbills> yes
404 2010-12-21T19:05:17 <ThomasWaldmann> so you'ld need i18n for your piece of js (and you maybe want to avoid that :)
405 2010-12-21T19:05:29 <jbills> so toggle() the ol tag
406 2010-12-21T19:05:44 <ThomasWaldmann> also one would need to keep that in sync, your place and the place that emits the original "Content"
407 2010-12-21T19:06:12 <ThomasWaldmann> ah, yes, that sounds good
408 2010-12-21T19:06:25 <ThomasWaldmann> then you maybe even don't need to check for visibility on your own
409 2010-12-21T19:06:36 <jbills> ok
410 2010-12-21T19:07:02 <ThomasWaldmann> just make sure you hide the right thing :D
411 2010-12-21T19:07:21 <ThomasWaldmann> and btw, if you really don't need those classes, don't add stuff "just for the case"
412 2010-12-21T19:07:33 <ThomasWaldmann> it'll just make other devs wonder why it is there
413 2010-12-21T19:07:55 <ThomasWaldmann> and that can burn up more brain cycles then just adding it when one really needs it
414 2010-12-21T19:08:18 <NikitaUtiu> ThomasWaldmann: back! yes, the item is called moin
415 2010-12-21T19:08:29 <ThomasWaldmann> but not "moin?"
416 2010-12-21T19:08:41 <ThomasWaldmann> just wondering about that question mark
417 2010-12-21T19:08:53 <NikitaUtiu> ThomasWaldmann: no
418 2010-12-21T19:10:01 <NikitaUtiu> interesting i didn't notice it, but i debugged the server and converted the elementtree to xml, this is what i got
419 2010-12-21T19:10:14 <ThomasWaldmann> NikitaUtiu: why did you choose ConverterItemRendered?
420 2010-12-21T19:10:44 <NikitaUtiu> ThomasWaldmann: i thought it's more suggestive , aren't the items rendered
421 2010-12-21T19:10:50 <ThomasWaldmann> it doesn't render anything. what I suggested was ...Refs like in References
422 2010-12-21T19:11:01 <ThomasWaldmann> not there :)
423 2010-12-21T19:11:22 <NikitaUtiu> np, i'll change them in a minute
424 2010-12-21T19:12:53 <NikitaUtiu> ThomasWaldmann: ConverterItemRefs or Referenced
425 2010-12-21T19:13:23 <ThomasWaldmann> Refs or References, maybe choose the shorter one
426 2010-12-21T19:14:12 <jbills> ThomasWaldmann: how would I get the first ol tag in table-of-contents using jquery
427 2010-12-21T19:15:32 <jbills> nevermind
428 2010-12-21T19:15:35 <ThomasWaldmann> jbills: i guess you don't really want the first, but the outermost, right?
429 2010-12-21T19:15:51 <jbills> yes fixxed
430 2010-12-21T19:18:26 <jbills> can I have the code to get the outermost?
431 2010-12-21T19:18:52 <jbills> I am going to use it in togglehead
432 2010-12-21T19:22:45 <ThomasWaldmann> better not ask me anything about javascript :)
433 2010-12-21T19:23:00 <jbills> who then
434 2010-12-21T19:23:22 <ThomasWaldmann> TheSheep: xorAxAx: maybe you? ^^
435 2010-12-21T19:26:30 <NikitaUtiu> ThomasWaldmann: this one is better http://paste.pocoo.org/show/307997/ , also i found out that i forgot to remove the debugger
436 2010-12-21T19:29:41 <ThomasWaldmann> NikitaUtiu: please use different item names to test transclusion and links
437 2010-12-21T19:30:24 <ThomasWaldmann> hmm, how about order?
438 2010-12-21T19:30:32 <ThomasWaldmann> if you compare lists, order must be same
439 2010-12-21T19:31:13 <NikitaUtiu> so diffrerent methods for them ?
440 2010-12-21T19:32:22 <ThomasWaldmann> not required, but if it is exactly the same list of names for both, things could go wrong without the test failing
441 2010-12-21T19:33:33 <ThomasWaldmann> # TODO: Deduplicate code
442 2010-12-21T19:33:40 <ThomasWaldmann> didn't you do that? :)
443 2010-12-21T19:33:54 <NikitaUtiu> i'll rename the transclusions to something like moin2
444 2010-12-21T19:34:07 <NikitaUtiu> and i'll sort the lists before comparison
445 2010-12-21T19:34:26 <ThomasWaldmann> you could even use "linked" and "transcluded" in the name :)
446 2010-12-21T19:34:36 <ThomasWaldmann> don't sort
447 2010-12-21T19:34:40 <NikitaUtiu> more verbose
448 2010-12-21T19:34:43 <ThomasWaldmann> sets are made for such stuff
449 2010-12-21T19:34:51 <NikitaUtiu> but i'll deduplicate stuff
450 2010-12-21T19:35:01 <NikitaUtiu> it'll
451 2010-12-21T19:35:27 <ThomasWaldmann> wasn't the internal datastructure where it collect the stuff a set anyway?
452 2010-12-21T19:35:28 <NikitaUtiu> and it won't test whether there are duplicate items in the meta
453 2010-12-21T19:36:00 <NikitaUtiu> yes, but what if somebody modifies the code and it messes up ?
454 2010-12-21T19:36:27 <ThomasWaldmann> ah, that's right, ok use sorted lists and add a comment about the reason for that and not sets
455 2010-12-21T19:38:29 <ThomasWaldmann> you could do a bugfix task afterwards to diagnose that trailing ? :)
456 2010-12-21T19:38:44 <ThomasWaldmann> and fix it, if needed
457 2010-12-21T19:41:32 *** greg_f
458 2010-12-21T19:41:46 <jbills> ThomasWaldmann: how do you do nth-child selector in jquery
459 2010-12-21T19:43:07 <jbills> I need to call toggle on the 3rd child
460 2010-12-21T19:43:48 <ThomasWaldmann> you want to call toggle on an element identified by its id (which is derived from the href + suffix)
461 2010-12-21T19:44:30 <jbills> I cant
462 2010-12-21T19:46:41 <ThomasWaldmann> why not?
463 2010-12-21T19:47:19 <ThomasWaldmann> btw, i need to drive home now. bbl in ~ 20mins.
464 2010-12-21T19:51:55 <NikitaUtiu> ThomasWaldmann: new one http://paste.pocoo.org/show/308020/ be right back
465 2010-12-21T20:03:44 <jbills> TheSheep: http://pastebin.com/P1KU8Y6x I need to figure out how to get the outer element.
466 2010-12-21T20:04:29 <TheSheep> jbills: .parentNode.parentNode ?
467 2010-12-21T20:04:41 *** Roboraider
468 2010-12-21T20:05:02 *** jbills
469 2010-12-21T20:05:30 *** jbills
470 2010-12-21T20:06:41 <jbills> TheSheep: http://pastebin.com/P1KU8Y6x I need to figure out how to get the outer element.
471 2010-12-21T20:07:11 <jbills> or just limit it to selecting the first ol
472 2010-12-21T20:11:01 <Roboraider> I've found the location of the problem, but when I patch the problem, it breaks several others. http://paste.pocoo.org/show/308028/
473 2010-12-21T20:11:39 <Roboraider> I'm working on this issue: http://paste.pocoo.org/show/307608/
474 2010-12-21T20:12:00 <TheSheep> jbills: http://api.jquery.com/parent-selector/
475 2010-12-21T20:12:22 <TheSheep> jbills: sorry, wrong link
476 2010-12-21T20:12:24 <jbills> nevermind I got it
477 2010-12-21T20:12:27 <TheSheep> jbills: http://api.jquery.com/parent/
478 2010-12-21T20:12:39 <jbills> I used eq(0)
479 2010-12-21T20:16:35 *** Samm
480 2010-12-21T20:20:55 <NikitaUtiu> back
481 2010-12-21T20:24:23 * dreimark thinks we got a peak today on MoinMoinChat
482 2010-12-21T20:25:05 <xorAxAx> 23 days ago we had 31 chatters
483 2010-12-21T20:25:20 <xorAxAx> in this channel
484 2010-12-21T20:25:42 <dreimark> now we have more than 464 lines
485 2010-12-21T20:28:24 *** rfw
486 2010-12-21T20:28:30 *** rfw
487 2010-12-21T20:28:30 *** rfw
488 2010-12-21T20:29:14 <jbills> ThomasWaldmann: http://pastebin.com/SLUq0sfq
489 2010-12-21T20:29:18 <jbills> how that
490 2010-12-21T20:30:17 *** Guest12079
491 2010-12-21T20:30:25 <NikitaUtiu> is the new patch good (except the debug lines) ?
492 2010-12-21T20:33:56 <ThomasWaldmann> NikitaUtiu: do you know sorted()?
493 2010-12-21T20:36:42 <NikitaUtiu> ThomasWaldmann: yes, for the assignment ?
494 2010-12-21T20:37:40 <ThomasWaldmann> saves you 4 locs
495 2010-12-21T20:37:45 <ThomasWaldmann> NikitaUtiu: patching file MoinMoin/converter/_tests/test_link.py
496 2010-12-21T20:37:45 <ThomasWaldmann> patching file MoinMoin/converter/link.py
497 2010-12-21T20:37:45 <ThomasWaldmann> patching file MoinMoin/items/__init__.py
498 2010-12-21T20:37:45 <ThomasWaldmann> patch unexpectedly ends in middle of line
499 2010-12-21T20:37:45 <ThomasWaldmann> Hunk #3 succeeded at 1075 with fuzz 1.
500 2010-12-21T20:38:20 * ThomasWaldmann doesn't quite understand why we have so many patching issues - are there that many broken "diff" utils out there?
501 2010-12-21T20:39:47 <ThomasWaldmann> missing LF at EOF
502 2010-12-21T20:40:19 <jbills> ThomasWaldmann: What bout my patch
503 2010-12-21T20:40:23 <ThomasWaldmann> NikitaUtiu: how did you put your diff into the pastebin?
504 2010-12-21T20:40:40 <ThomasWaldmann> jbills: wait a sec, until i tested the other one
505 2010-12-21T20:40:48 <NikitaUtiu> copy&paste ?
506 2010-12-21T20:41:23 <NikitaUtiu> should i make a new one ?
507 2010-12-21T20:42:23 <ThomasWaldmann> no
508 2010-12-21T20:42:36 <ThomasWaldmann> NikitaUtiu: windows, linux?
509 2010-12-21T20:42:43 <NikitaUtiu> linux
510 2010-12-21T20:42:51 <ThomasWaldmann> you know pastebinit?
511 2010-12-21T20:43:04 * ThomasWaldmann usually uses hg diff | pastebinit
512 2010-12-21T20:43:20 <NikitaUtiu> lemme check it
513 2010-12-21T20:43:39 <ThomasWaldmann> i get pdb btw :)
514 2010-12-21T20:44:10 <NikitaUtiu> :) i used it to get the xml
515 2010-12-21T20:45:58 <NikitaUtiu> http://pastebin.com/KabLxSZe
516 2010-12-21T20:46:04 <NikitaUtiu> that's quite handy
517 2010-12-21T20:49:05 <ThomasWaldmann> no loved for sorted and deduplication? :)
518 2010-12-21T20:49:09 <ThomasWaldmann> love*
519 2010-12-21T20:50:59 *** Roboraider
520 2010-12-21T20:52:09 <NikitaUtiu> hm?
521 2010-12-21T20:52:52 <NikitaUtiu> you mean, that i should put the comment before ?
522 2010-12-21T20:54:12 <NikitaUtiu> ok
523 2010-12-21T20:54:45 <ThomasWaldmann> no i meant to use x_sorted = sorted(x)
524 2010-12-21T20:55:16 <ThomasWaldmann> and moving that path manipulation code that's present 2,3,4 times to a function
525 2010-12-21T20:55:45 <NikitaUtiu> i'll do that in a separate patch
526 2010-12-21T20:55:54 <ThomasWaldmann> jbills: one usually does not "( x )", but (x)
527 2010-12-21T20:56:11 <ThomasWaldmann> jbills: otoh, it is "x = y" not "x=y"
528 2010-12-21T20:56:35 <jbills> ok
529 2010-12-21T20:56:36 <ThomasWaldmann> jbills: if you must check visibility for other reasons, don't use toggle, but show and hide
530 2010-12-21T20:56:59 <ThomasWaldmann> (because that likely internally also checks visibility)
531 2010-12-21T20:57:16 <NikitaUtiu> i gotta go now, i'm going to do that tomorrow
532 2010-12-21T20:57:18 <NikitaUtiu> bye
533 2010-12-21T20:57:20 <ThomasWaldmann> NikitaUtiu: ah, ok
534 2010-12-21T20:57:40 <ThomasWaldmann> NikitaUtiu: ok, i guess we'll get that finished then, looks quite good already
535 2010-12-21T20:59:40 <ThomasWaldmann> jbills: #
536 2010-12-21T20:59:41 <ThomasWaldmann> -/* support for firefox 3.5/3.6 and safari */
537 2010-12-21T20:59:41 <ThomasWaldmann> #
538 2010-12-21T20:59:41 <ThomasWaldmann> +/* support for firefox 3.5/3.6 and safari*/
539 2010-12-21T20:59:57 <ThomasWaldmann> that gets annoying
540 2010-12-21T21:00:09 <ThomasWaldmann> why is stuff you already fixes reappearing again and again?
541 2010-12-21T21:00:22 <ThomasWaldmann> fixed*
542 2010-12-21T21:00:51 <ThomasWaldmann> and why don't you read your diffs so you notice such stuff on your own beforehand?
543 2010-12-21T21:01:57 *** NikitaUtiu
544 2010-12-21T21:05:24 *** m4k3r
545 2010-12-21T21:06:39 * dreimark admires the patience of ThomasWaldmann
546 2010-12-21T21:09:54 <ThomasWaldmann> it's shrinking :)
547 2010-12-21T21:10:35 <jbills> http://pastebin.com/BfWUph2m
548 2010-12-21T21:11:57 <jbills> ThomasWaldmann: http://pastebin.com/BfWUph2m
549 2010-12-21T21:12:14 <dreimark> why is 19. removed
550 2010-12-21T21:12:36 <dreimark> ah maybe because of 21
551 2010-12-21T21:12:48 <dreimark> doc string is missing
552 2010-12-21T21:13:41 <jbills> dreimark: are you talking t o me
553 2010-12-21T21:14:51 <ThomasWaldmann> jbills: that olfirst stuff looks strange
554 2010-12-21T21:15:48 <jbills> I use that to get the top level ol
555 2010-12-21T21:15:59 <ThomasWaldmann> am i overlooking something or is that the only child of its parent?
556 2010-12-21T21:16:22 <dreimark> + var topol=$(li +' ol').eq(0);
557 2010-12-21T21:16:43 <dreimark> the line before you format it var li = '.li' + id;
558 2010-12-21T21:17:16 <jbills> ThomasWaldmann: No it also minimizes al sub ols
559 2010-12-21T21:17:27 <jbills> including foo1
560 2010-12-21T21:17:34 <jbills> and bar1
561 2010-12-21T21:19:44 <ThomasWaldmann> sure, i just wondered why you need extra code to find that outer lonely ol
562 2010-12-21T21:20:49 <jbills> http://pastebin.com/EPqpum1u
563 2010-12-21T21:23:15 *** grzywacz
564 2010-12-21T21:23:52 <jbills> ThomasWaldmann: http://pastebin.com/EPqpum1u
565 2010-12-21T21:24:59 <dreimark> http://moinmo.in/ReimarBauer?action=AttachFile&do=view&target=toctest1.png
566 2010-12-21T21:25:15 <dreimark> there is a mismatch in hide/unhide
567 2010-12-21T21:25:42 <jbills> sorry
568 2010-12-21T21:27:02 <dreimark> it happens if you close and open the contents + and the title + on both tocs
569 2010-12-21T21:27:37 <ThomasWaldmann> jbills: what's different now?
570 2010-12-21T21:28:22 <ThomasWaldmann> jbills: next task, you'll use hg :)
571 2010-12-21T21:28:28 <jbills> ok
572 2010-12-21T21:29:44 <jbills> give me a moment
573 2010-12-21T21:30:27 <dreimark> and if you reload the page it can happen
574 2010-12-21T21:30:58 <dreimark> that it changes
575 2010-12-21T21:31:24 <dreimark> but that needs to be documented only
576 2010-12-21T21:31:56 <ThomasWaldmann> of course it changes, we don't keep state
577 2010-12-21T21:34:50 <jbills> ThomasWaldmann: Lets try this http://pastebin.com/tEY5WvM9
578 2010-12-21T21:34:52 <dreimark> yes but it changes state from + to - http://test.moinmo.in:8080/ReimarBauer/toctest2
579 2010-12-21T21:37:22 <ThomasWaldmann> jbills: changes?
580 2010-12-21T21:37:38 <jbills> I made the big maximize work again
581 2010-12-21T21:38:01 <jbills> and reversed the order of the [*] code
582 2010-12-21T21:38:55 <ThomasWaldmann> another thing, can you explain what stack_push does and why?
583 2010-12-21T21:39:14 <jbills> That was in the base toc code not mine
584 2010-12-21T21:39:47 <ThomasWaldmann> ah, ok
585 2010-12-21T21:40:02 <jbills> So what do you think?
586 2010-12-21T21:40:10 <jbills> should I submit
587 2010-12-21T21:40:18 <dreimark> jbills: if i now hide foo2
588 2010-12-21T21:40:44 *** Kapace_
589 2010-12-21T21:40:45 <dreimark> on toc one this did not hide it on toc two
590 2010-12-21T21:40:54 *** Kapace_
591 2010-12-21T21:40:58 <dreimark> but if i hide Contents both got hidden
592 2010-12-21T21:41:06 <ThomasWaldmann> so, why do we need code for marking firstOL?
593 2010-12-21T21:41:08 <dreimark> why is that different
594 2010-12-21T21:41:47 <jbills> It was the simmplist way to fix it I could thank of
595 2010-12-21T21:42:32 <jbills> I could change it to use the same method togglehead
596 2010-12-21T21:44:15 <ThomasWaldmann> Mozilla has released a new beta of Firefox 4 this morning. Originally intended as a quick update for the feature-complete Beta 7 release, the new Beta includes 1415 bugfixes, a fine-tuned add-ons manager, improved WebGL support as well as URL bar enhancements.
597 2010-12-21T21:44:30 <ThomasWaldmann> 1415?
598 2010-12-21T21:45:03 <ThomasWaldmann> jbills: can't jquery easily select such a thing without you needing to mark it?
599 2010-12-21T21:45:17 <jbills> yes will do
600 2010-12-21T21:47:22 <dreimark> we should think about an WebGl item
601 2010-12-21T21:52:42 <dreimark> ThomasWaldmann: i get still b7
602 2010-12-21T21:53:08 <dreimark> with the normal link
603 2010-12-21T21:55:00 <ThomasWaldmann> yeah, web site is not current
604 2010-12-21T21:55:16 <ThomasWaldmann> http://www.mozilla.com/de/download/?product=firefox-4.0b8&os=linux&lang=de
605 2010-12-21T21:55:58 <dreimark> fixed it similiar
606 2010-12-21T21:56:43 <jbills> ThomasWaldmann: here http://pastebin.com/Zs2Ps8ZT
607 2010-12-21T22:00:21 *** Roboraider
608 2010-12-21T22:00:26 <Roboraider> hi
609 2010-12-21T22:03:55 <ThomasWaldmann> jbills: ok, i'll try that one
610 2010-12-21T22:04:01 <jbills> thanks
611 2010-12-21T22:04:06 <ThomasWaldmann> still there are formatting issues btw.
612 2010-12-21T22:04:14 <jbills> where
613 2010-12-21T22:04:20 <ThomasWaldmann> everywhere X)
614 2010-12-21T22:04:31 <ThomasWaldmann> in teh src
615 2010-12-21T22:04:39 <jbills> which file
616 2010-12-21T22:06:22 <Roboraider> I am having a problem with this test: http://paste.pocoo.org/show/307608/
617 2010-12-21T22:07:19 <Roboraider> I found the exact location of the problem, but I am unsure of how I should fix it
618 2010-12-21T22:07:26 <Roboraider> The problem is here: http://paste.pocoo.org/show/308028/
619 2010-12-21T22:07:55 <Roboraider> When I made a fix for the problem, I ended up creating failures in several other tests
620 2010-12-21T22:09:56 <Roboraider> The problem is that it inserts a & right before the target=_blank
621 2010-12-21T22:12:34 <jbills> ThomasWaldmann: How did it go
622 2010-12-21T22:15:34 <ThomasWaldmann> if i click on 2nd tocs [+] it shrinks my 1st toc :D
623 2010-12-21T22:18:55 <ThomasWaldmann> jbills: kill that style color:blue
624 2010-12-21T22:19:02 <jbills> ok
625 2010-12-21T22:19:06 <ThomasWaldmann> because you can't know whether blue is visible
626 2010-12-21T22:19:14 <ThomasWaldmann> if bg is blue, you're in trouble
627 2010-12-21T22:20:36 <ThomasWaldmann> you set "inline" style for a <a> element, why?
628 2010-12-21T22:21:57 <jbills> I cant remember
629 2010-12-21T22:22:11 <ThomasWaldmann> try without
630 2010-12-21T22:22:17 <ThomasWaldmann> a is inline anyway :)
631 2010-12-21T22:22:38 <jbills> ok
632 2010-12-21T22:23:14 <jbills> ok
633 2010-12-21T22:24:00 <ThomasWaldmann> that margin-left stuff (3 places iirc), needs to move to css
634 2010-12-21T22:24:06 <jbills> ok will work on that
635 2010-12-21T22:24:46 <ThomasWaldmann> (it is because not every writing is left to right, e.g. arabic is right to left, so your margin would be wrong)
636 2010-12-21T22:29:30 <jbills> html.class_: 'm%s' % id, html.style_: 'margin-left:10px;' I cant move the margin to css because the class is generated on the fly.
637 2010-12-21T22:30:47 <ThomasWaldmann> sure you can :)
638 2010-12-21T22:31:02 <ThomasWaldmann> class="x y"
639 2010-12-21T22:31:19 <jbills> huh
640 2010-12-21T22:31:24 <ThomasWaldmann> x is dynamic, y is the stuff for the margin
641 2010-12-21T22:31:50 <jbills> can you show me an example
642 2010-12-21T22:34:11 <ThomasWaldmann> html.class_: 'm%s tocmargin'
643 2010-12-21T22:34:27 <ThomasWaldmann> it is just 2 classes separated by a blank
644 2010-12-21T22:34:43 <ThomasWaldmann> maybe use same class for all cases
645 2010-12-21T22:35:41 <jbills> ohhhhhh
646 2010-12-21T23:04:35 <jbills> ThomasWaldmann: How would you make table-of-contents have a unique class name which I can pass to toggletoc?
647 2010-12-21T23:08:05 <ThomasWaldmann> in that case, it is a class, not an id, so all tocs can have same class
648 2010-12-21T23:08:59 <ThomasWaldmann> ehrm, for your unique stuff, you rather want id btw. :)
649 2010-12-21T23:09:33 <ThomasWaldmann> so it is id="uniquestuff" class="moin-toc-whatever"
650 2010-12-21T23:17:55 <jbills> ThomasWaldmann: How would you get uniqe
651 2010-12-21T23:18:41 <ThomasWaldmann> you already have it
652 2010-12-21T23:19:57 <jbills> where
653 2010-12-21T23:20:27 <ThomasWaldmann> "m%s" % id?
654 2010-12-21T23:20:55 <jbills> but that is for the a I need it for the table-of-contents
655 2010-12-21T23:23:12 <ThomasWaldmann> line in your diff?
656 2010-12-21T23:24:14 <jbills> not in diff
657 2010-12-21T23:36:00 <jbills> TheSheep: How do you get the parent node in jquery
658 2010-12-21T23:39:36 <dreimark> jbills: you don't google yourself?
659 2010-12-21T23:40:03 <jbills> I tried no help
660 2010-12-21T23:40:21 <dreimark> i tried the words http://www.google.com/search?client=ubuntu&channel=fs&q=+parent+node+in+jquery&ie=utf-8&oe=utf-8
661 2010-12-21T23:41:13 <dreimark> take the first one http://forum.jquery.com/topic/parentnode-using-jquery
662 2010-12-21T23:41:16 <ThomasWaldmann> http://www.mozilla.com/en-US/firefox/beta/features/ see javascript speed charts
663 2010-12-21T23:42:14 <jbills> I have seen that does not help
664 2010-12-21T23:50:47 <dreimark> that's a name JägerMonkey JavaScript engine
665 2010-12-21T23:55:03 *** m4k3r
666
