1 2010-12-19T00:03:26 <Kapace_> ok, http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129271285782
2 2010-12-19T00:05:32 <ThomasWaldmann> Kapace_: btw, please run tests before and afterwards your fix and compare if results is like expected and test_sourcecode has no fails
3 2010-12-19T00:05:54 <Kapace_> ok
4 2010-12-19T00:10:41 *** m4k3r
5 2010-12-19T00:22:54 *** m4k3r
6 2010-12-19T00:47:49 * ThomasWaldmann runs tests
7 2010-12-19T00:59:58 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10157:14eca6fe8a44 2.0-dev/MoinMoin/converter/_tests/test_html_in_out.py: fixed some converter tests (thanks to David Czech, GCI 2010)
8 2010-12-19T01:00:54 <ThomasWaldmann> Kapace_: ^^
9 2010-12-19T01:04:28 <Kapace_> thanks :)
10 2010-12-19T01:12:21 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10158:c1cf97598e88 2.0-dev/MoinMoin/storage/ (_tests/test_backends.py backends/indexing.py): fix some pep8 issues, removed trailing blanks
11 2010-12-19T01:12:35 * jordonwii is back
12 2010-12-19T01:13:09 * jordonwii is working on things mentioned above
13 2010-12-19T01:30:45 *** m4k3r
14 2010-12-19T01:41:41 *** gry
15 2010-12-19T01:47:00 *** grzywacz
16 2010-12-19T02:00:57 <jordonwii> ThomasWaldmann / dreimark: What should I use for the icon?
17 2010-12-19T02:06:15 <ThomasWaldmann> did you try [+++] ?
18 2010-12-19T02:06:42 <ThomasWaldmann> or >>>
19 2010-12-19T02:07:00 <ThomasWaldmann> maybe define a constant somewhere for these strings
20 2010-12-19T02:13:09 <jordonwii> One sec
21 2010-12-19T02:18:14 <jordonwii> Also, I removed all references to "chevron" =)
22 2010-12-19T02:19:29 <jordonwii> ThomasWaldmann: Is defining a constant at the top of common.js ok?
23 2010-12-19T02:19:35 <jordonwii> Or should I put it elsewhere?
24 2010-12-19T02:38:36 *** jordonwii
25 2010-12-19T02:42:56 *** jordonwii
26 2010-12-19T02:50:32 <jordonwii> ThomasWaldmann: I like >>>
27 2010-12-19T03:27:40 <jordonwii> ThomasWaldmann and dreimark: I'm going to bed -- I uploaded the latest patch to Melange
28 2010-12-19T03:27:42 <jordonwii> 'Night
29 2010-12-19T03:31:06 *** jordonwii
30 2010-12-19T06:00:37 *** jbills
31 2010-12-19T07:41:58 *** kursor
32 2010-12-19T07:56:29 *** Samm
33 2010-12-19T08:59:44 *** Samm
34 2010-12-19T09:55:58 *** NikitaUtiu
35 2010-12-19T10:26:15 <CIA-56> Reimar Bauer <rb.proj AT googlemail DOT com> default * 10159:d978e91e2585 2.0-dev/MoinMoin/static/common/js/common.js: scalibility of quicklinks improved (thanks to JordonWii, GCI2010)
36 2010-12-19T10:30:21 *** rfw
37 2010-12-19T11:18:11 *** gry
38 2010-12-19T11:33:41 *** m4k3r
39 2010-12-19T11:58:52 <ThomasWaldmann> moin
40 2010-12-19T12:03:02 <m4k3r> moin
41 2010-12-19T12:25:38 *** kursor
42 2010-12-19T12:30:18 *** gry
43 2010-12-19T13:01:29 *** greg_f
44 2010-12-19T13:51:45 *** gry
45 2010-12-19T14:32:23 <ThomasWaldmann> can someone review some css changes?
46 2010-12-19T14:35:42 <ThomasWaldmann> http://paste.pocoo.org/show/306909/
47 2010-12-19T14:35:55 <ThomasWaldmann> just have a look at how moin2 looks like, before and after
48 2010-12-19T14:59:59 *** kursor
49 2010-12-19T15:07:52 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10160:481c2d572d32 2.0-dev/MoinMoin/themes/modernized/static/css/screen.css: (log message trimmed)
50 2010-12-19T15:07:52 <CIA-56> fine tune modernized css, see below
51 2010-12-19T15:07:52 <CIA-56> moin-header: remove 1px margin/padding - this was giving an annoying white
52 2010-12-19T15:07:52 <CIA-56> interruption between the edit bar blue and the content border effect
53 2010-12-19T15:07:52 <CIA-56> moin-username: remove top margin, this was causing a white line above the
54 2010-12-19T15:07:53 <CIA-56> header background picture
55 2010-12-19T15:07:53 <CIA-56> moin-pagetrail: set right margin to 12px (same value as other header elements use)
56 2010-12-19T15:26:44 *** skylamer`
57 2010-12-19T15:58:50 *** Samm
58 2010-12-19T16:16:10 *** Samm
59 2010-12-19T16:33:33 *** Samm
60 2010-12-19T16:38:22 *** Samm
61 2010-12-19T16:45:59 <NikitaUtiu> hi, all!
62 2010-12-19T16:47:12 <xorAxAx> hi NikitaUtiu
63 2010-12-19T16:50:00 <NikitaUtiu> i almost got it working, but i was wondering: i get a typeerror when i try to get a page. ist htis a known issue ?
64 2010-12-19T16:50:12 <NikitaUtiu> or i'm just doing something wrong
65 2010-12-19T16:52:34 <xorAxAx> NikitaUtiu: what do you mean by "get a page"?
66 2010-12-19T16:53:24 <NikitaUtiu> just to request a page in the browser and display it
67 2010-12-19T16:55:18 <NikitaUtiu> e.g. i went to localhost:8080/Home and i got TypeError: cannot concatenate 'str' and 'Element' objects
68 2010-12-19T16:55:32 <xorAxAx> NikitaUtiu: which hg branch do you have?
69 2010-12-19T16:55:38 <xorAxAx> and which tip revision
70 2010-12-19T16:55:57 *** jbills
71 2010-12-19T16:57:16 <NikitaUtiu> the default branch for moin 2 and i think the latest revision
72 2010-12-19T16:58:57 <xorAxAx> hmm, you could hg bisect to see whether it goes away
73 2010-12-19T17:01:14 *** jbills
74 2010-12-19T17:06:01 <dreimark> NikitaUtiu: before your work or with your patch?
75 2010-12-19T17:07:06 <NikitaUtiu> no, but i didn't know if it is my fault or it's some other bug
76 2010-12-19T17:07:13 <NikitaUtiu> after the patch
77 2010-12-19T17:07:31 <dreimark> do you have committed already ?
78 2010-12-19T17:07:45 <dreimark> othewise you can do a local clone and just try it
79 2010-12-19T17:08:08 <dreimark> or you do a local clone and revert to the changeset before yours
80 2010-12-19T17:08:20 <dreimark> on my system i don't have that failure
81 2010-12-19T17:08:26 <NikitaUtiu> i cloned it
82 2010-12-19T17:08:52 <NikitaUtiu> i obviously missed something
83 2010-12-19T17:09:36 <dreimark> do you have a unit test done? run the existing tests please too
84 2010-12-19T17:12:21 <ThomasWaldmann> NikitaUtiu: the error msg is rather clear. look at the traceback to see where it happens.
85 2010-12-19T17:18:43 <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10161:26f214de9be1 2.0-dev/MoinMoin/themes/modernized/static/css/screen.css: modernized css: make colour hues more consistent
86 2010-12-19T17:19:32 <ThomasWaldmann> NikitaUtiu: also compare what you are doing with the existing code for itemlinks
87 2010-12-19T17:20:40 <NikitaUtiu> ThomasWaldmann: ok
88 2010-12-19T17:24:42 <NikitaUtiu> ThomasWaldmann: I think i messed the converter cause i tried to do it in the ConverterBase class which is also used for external links
89 2010-12-19T17:25:59 <NikitaUtiu> ThomasWaldmann: I don't think i can do it in the same tree
90 2010-12-19T17:26:10 <ThomasWaldmann> use the itemlinks converter class
91 2010-12-19T17:29:04 <NikitaUtiu> I tried to do so but i also had to modify the ConverterBase class which messed the ConverterExternOutput
92 2010-12-19T17:33:30 <ThomasWaldmann> analyze it, maybe add some debug logging, show a diff, ...
93 2010-12-19T17:38:25 <ThomasWaldmann> btw, please comment on the current content background colour - it is blueish white - should it be more white?
94 2010-12-19T17:39:16 <NikitaUtiu> me?
95 2010-12-19T17:40:00 <ThomasWaldmann> no, everybody :)
96 2010-12-19T17:44:08 *** valeuf
97 2010-12-19T17:44:21 *** valeuf
98 2010-12-19T17:44:54 <ThomasWaldmann> hmm, strange ^^
99 2010-12-19T17:45:07 <NikitaUtiu> well, i think it's ok
100 2010-12-19T17:47:26 <ThomasWaldmann> next time if someone asks for "moin for the cloud" we can say that we have the clouds built-in :D
101 2010-12-19T17:51:14 <NikitaUtiu> ThomasWaldmann: i don't want to be insistent, but are you sure i can do it in the same class ?
102 2010-12-19T17:51:55 <ThomasWaldmann> well, if you'ld make it a completely separate converter, it would require another "pass"
103 2010-12-19T17:52:38 <ThomasWaldmann> so, as the goal of that converter is almost the same as itemlinks, we should save that pass and do in in same traversal
104 2010-12-19T17:53:40 <NikitaUtiu> I thought about that, but the tree pass is done in the ConverterBase which is also used by ConverterExternOutput
105 2010-12-19T17:54:05 <ThomasWaldmann> maybe for same reason :)
106 2010-12-19T18:02:16 *** greg_f
107 2010-12-19T18:07:02 <ThomasWaldmann> NikitaUtiu: can you show your current code in a pastebin?
108 2010-12-19T18:07:14 <ThomasWaldmann> or the diff?
109 2010-12-19T18:08:04 <NikitaUtiu> ok, just a sec
110 2010-12-19T18:10:35 <NikitaUtiu> should i send it to you ?
111 2010-12-19T18:13:32 <ThomasWaldmann> paste.pocoo.org
112 2010-12-19T18:13:35 <NikitaUtiu> https://gist.github.com/747488
113 2010-12-19T18:17:53 <ThomasWaldmann> http://paste.pocoo.org/show/307015/ see there
114 2010-12-19T18:18:17 <ThomasWaldmann> line 31/32 add empty line
115 2010-12-19T18:18:45 <ThomasWaldmann> line 48 - where is this in your code, don't you need that also?
116 2010-12-19T18:19:46 <ThomasWaldmann> (in the end, you'll also have to change those handler method names so they are consistently named again)
117 2010-12-19T18:20:41 <NikitaUtiu> ok
118 2010-12-19T18:20:56 <ThomasWaldmann> and you'll also have to deduplicate the code, it wasn't great and it got worse
119 2010-12-19T18:22:15 <ThomasWaldmann> check your spacing in line 190
120 2010-12-19T18:22:26 <ThomasWaldmann> 210
121 2010-12-19T18:22:49 <ThomasWaldmann> ok, fix that now and retry
122 2010-12-19T18:23:09 <ThomasWaldmann> first fix the functional stuff, of course
123 2010-12-19T18:24:52 <ThomasWaldmann> are you creating new changesets now and then or still working for the first commit?
124 2010-12-19T18:25:21 <NikitaUtiu> got it :D
125 2010-12-19T18:25:34 <NikitaUtiu> i misspelled or to ot
126 2010-12-19T18:26:31 <ThomasWaldmann> hm?
127 2010-12-19T18:27:17 <NikitaUtiu> i wrote 'ot' instead of 'or' and got a syntax error, it works like a charm
128 2010-12-19T18:28:55 <ThomasWaldmann> ah, 192, right :)
129 2010-12-19T18:29:29 <NikitaUtiu> it couldn't import the module because of it :)
130 2010-12-19T18:29:40 <ThomasWaldmann> submit a new file to paste.pocoo.org (not gist) after you're finished
131 2010-12-19T18:29:46 <NikitaUtiu> i already did
132 2010-12-19T18:30:51 <NikitaUtiu> well, i'll clean the code up a little 'though
133 2010-12-19T18:30:55 <ThomasWaldmann> and that works?
134 2010-12-19T18:31:24 <NikitaUtiu> yes, i even get the itemtransclusions meta correctly
135 2010-12-19T18:31:43 <ThomasWaldmann> i am just wondering about the Iri stuff
136 2010-12-19T18:32:43 <NikitaUtiu> which line ?
137 2010-12-19T18:33:18 <ThomasWaldmann> (18:18) < ThomasWal> line 48 - where is this in your code, don't you need that also?
138 2010-12-19T18:35:18 <ThomasWaldmann> btw, remove those blanks before the parens in a function call
139 2010-12-19T18:35:26 <ThomasWaldmann> it is foo(), not foo ()
140 2010-12-19T18:35:49 <ThomasWaldmann> (maybe read pep8, the python style guide)
141 2010-12-19T18:36:18 <NikitaUtiu> sorry about that , i got used to writing like this
142 2010-12-19T18:37:32 <ThomasWaldmann> hopefully not with python :)
143 2010-12-19T18:38:26 <NikitaUtiu> unfortunately, yes. and about the Iri, i think the xinclude element actually returns an Iri
144 2010-12-19T18:40:23 <ThomasWaldmann> and the href does not?
145 2010-12-19T18:40:56 <ThomasWaldmann> what was causing this "can't concat element and str" you had?
146 2010-12-19T18:43:01 <NikitaUtiu> i don't actually know
147 2010-12-19T18:43:50 <ThomasWaldmann> (18:24) < ThomasWal> are you creating new changesets now and then or still working for the first commit?
148 2010-12-19T18:45:04 <NikitaUtiu> haven't committed it yet, i don't even know how to do this with mercurial
149 2010-12-19T18:46:07 <ThomasWaldmann> it's almost the same as with git :)
150 2010-12-19T18:46:20 <ThomasWaldmann> ok, so cleanup the stuff and submit a new pastebin url
151 2010-12-19T18:46:38 <NikitaUtiu> ok
152 2010-12-19T18:48:12 <ThomasWaldmann> and add that Iri stuff, it does no harm if you already have an Iri - just for consistency
153 2010-12-19T18:48:56 <NikitaUtiu> sure :)
154 2010-12-19T18:50:17 <NikitaUtiu> does pep8 say anything about assignment spacing ?
155 2010-12-19T18:51:46 *** m4k3r
156 2010-12-19T18:52:12 *** m4k3r
157 2010-12-19T19:03:43 *** gry
158 2010-12-19T19:13:23 <ThomasWaldmann> NikitaUtiu: shall i read it to you? :)
159 2010-12-19T19:15:10 <NikitaUtiu> ThomasWaldmann: :) no thanks, that was a stupid question from me
160 2010-12-19T19:18:59 <NikitaUtiu> ThomasWaldmann: http://paste.pocoo.org/show/307049/ cleaned the code a little, also modified the items/__init__.py code so that it loads the itemtransclusions meta http://paste.pocoo.org/show/307050/
161 2010-12-19T19:20:56 <dreimark> this is no diff
162 2010-12-19T19:22:59 <NikitaUtiu> ?
163 2010-12-19T19:25:13 <NikitaUtiu> there are some differences
164 2010-12-19T19:28:24 <dreimark> why do you show all 220 lines and not only your contribution ?
165 2010-12-19T19:29:28 <NikitaUtiu> should i put a diff ?
166 2010-12-19T19:35:14 <NikitaUtiu> ok, sorry about that, http://paste.pocoo.org/show/307060/ this is the converter/link.py
167 2010-12-19T19:35:34 <NikitaUtiu> http://paste.pocoo.org/show/307062/ and items/__init__.py
168 2010-12-19T19:37:53 <ThomasWaldmann> if you create diffs, please create unified diffs
169 2010-12-19T19:38:03 <ThomasWaldmann> if you use diff utility, that is -u
170 2010-12-19T19:38:58 <ThomasWaldmann> and use old -> new, not reverse
171 2010-12-19T19:39:02 <ThomasWaldmann> NikitaUtiu: ^
172 2010-12-19T19:39:22 <NikitaUtiu> ok
173 2010-12-19T19:42:10 *** skylamer`
174 2010-12-19T19:44:29 <NikitaUtiu> http://paste.pocoo.org/show/307065/ links http://paste.pocoo.org/show/307064/ __init__
175 2010-12-19T19:56:52 <dreimark> btw. if you have a clone you can do it by hg diff
176 2010-12-19T19:58:19 <dreimark> what is the difference between a handle_wiki_transclusion and handle_wikilocal_transclusion
177 2010-12-19T19:58:53 <dreimark> there is also a blank too much at the method declaration
178 2010-12-19T20:00:45 <dreimark> -500 flight from FFO today - good that we are at home
179 2010-12-19T20:01:01 <dreimark> but for those there it is no fun
180 2010-12-19T20:03:26 <dreimark> NikitaUtiu: did you run the pytest ?
181 2010-12-19T20:06:01 <dreimark> i have still no idea what the difference between wikilocal and wiki is
182 2010-12-19T20:07:52 *** grzywacz
183 2010-12-19T20:07:52 *** grzywacz
184 2010-12-19T20:09:50 <NikitaUtiu> well i don't know either what the difference is, but i put it because i saw that itemlinks had one
185 2010-12-19T20:10:30 <dreimark> def handle_wiki_transclusion (self, elem, link):
186 2010-12-19T20:10:37 <dreimark> no blank before (
187 2010-12-19T20:10:59 <NikitaUtiu> ok
188 2010-12-19T20:11:15 *** kursor
189 2010-12-19T20:12:25 <dreimark> if path [0] == '':
190 2010-12-19T20:12:31 <dreimark> also no blank before [
191 2010-12-19T20:12:47 <dreimark> and run pytest there may be more pep8 problems
192 2010-12-19T20:13:08 <dreimark> e.g. lines with blanks
193 2010-12-19T20:13:56 <NikitaUtiu> what do i have to do (have never used it) ?
194 2010-12-19T20:14:14 <dreimark> just execute pytest from the toplevel dir
195 2010-12-19T20:14:20 <dreimark> ./pytest
196 2010-12-19T20:14:56 <NikitaUtiu> ok
197 2010-12-19T20:15:05 *** rfw
198 2010-12-19T20:15:05 *** rfw
199 2010-12-19T20:17:03 * ThomasWaldmann tries flattr
200 2010-12-19T20:24:57 <NikitaUtiu> i got a lot of output. what am i looking for ?
201 2010-12-19T20:25:02 *** jbills
202 2010-12-19T20:32:42 <ThomasWaldmann> NikitaUtiu: whether the failure count changes due to your changes
203 2010-12-19T20:33:29 <NikitaUtiu> and how many were before ?
204 2010-12-19T20:36:54 <ThomasWaldmann> test it
205 2010-12-19T20:37:04 <ThomasWaldmann> (it depends a bit on stuff you have installed)
206 2010-12-19T20:38:22 <NikitaUtiu> ThomasWaldmann: i got 51 fails
207 2010-12-19T20:46:48 <dreimark> how much test_sourcecode failures
208 2010-12-19T20:47:32 <ThomasWaldmann> just compare before to afterwards
209 2010-12-19T20:47:49 <NikitaUtiu> they actually decreased form 53 to 51 ?!
210 2010-12-19T20:48:36 <dreimark> without your patches?
211 2010-12-19T20:49:00 <NikitaUtiu> yes
212 2010-12-19T20:49:39 <dreimark> a bit more precise 51 without your patches?
213 2010-12-19T20:50:03 <NikitaUtiu> no ,the other way around, 51 with my patches
214 2010-12-19T20:50:19 *** Roboraider
215 2010-12-19T20:50:30 <ThomasWaldmann> interesting. find out what exactly does not fail any more.
216 2010-12-19T20:50:41 <NikitaUtiu> i cloned it again, so it might be because of a revision in the last few days
217 2010-12-19T20:51:26 <dreimark> = 50 failed, 2434 passed, 270 skipped, 4 xfailed, 5 xpassed in 282.34 seconds
218 2010-12-19T20:51:40 <dreimark> with current repo
219 2010-12-19T20:51:54 <NikitaUtiu> let me test it again
220 2010-12-19T20:53:24 <NikitaUtiu> well with, the new revision i get 51
221 2010-12-19T20:53:47 <dreimark> post the whole results line
222 2010-12-19T20:54:06 <dreimark> it depends a bit which libs one has installed
223 2010-12-19T20:54:47 <NikitaUtiu> 51 failed, 2655 passed, 13 skipped, 3 xfailed, 5 xpassed, 1 error in 443.50 seconds
224 2010-12-19T20:55:47 <dreimark> i guess the difference is the 1 error
225 2010-12-19T20:56:15 <dreimark> but me has also more skipped currently
226 2010-12-19T20:56:56 <dreimark> we always have to compare on our systems without and with changes
227 2010-12-19T20:57:15 <dreimark> if some more becomes broken
228 2010-12-19T20:58:34 <NikitaUtiu> i gotta go now
229 2010-12-19T20:58:40 <NikitaUtiu> bye!
230 2010-12-19T21:01:20 <ThomasWaldmann> cu
231 2010-12-19T21:02:32 *** NikitaUtiu
232 2010-12-19T21:06:13 <dreimark> ThomasWaldmann: a new toc review
233 2010-12-19T21:19:19 *** Samm
234 2010-12-19T21:39:57 *** grzywacz
235 2010-12-19T21:48:20 <Roboraider> I'm working on fixing fix moinwiki_in and moinwiki19_in. I ran the pytest and I found a lot of errors similar to the one in moinwiki19_in.
236 2010-12-19T21:48:34 <Roboraider> Some of them are in test_moinwiki_in_out
237 2010-12-19T21:48:41 <Roboraider> am I supposed to fix all of them?
238 2010-12-19T21:48:59 <Roboraider> I see 22 errors that are different.
239 2010-12-19T21:59:19 <ThomasWaldmann> you are only supposed to fix errors that are fixed in same way
240 2010-12-19T21:59:44 <Roboraider> I understand. Thanks
241 2010-12-19T22:00:32 <ThomasWaldmann> if there are MANY more than the 2 in the moinwiki*_in converters, you can have another task for them
242 2010-12-19T22:00:56 <ThomasWaldmann> if it is just a few more, please just fix them :)
243 2010-12-19T22:01:44 <Roboraider> I've solved 5 already. There are at least 10 more.
244 2010-12-19T22:02:12 <ThomasWaldmann> ok, then submit what you have and get another task afterwards for the rest.
245 2010-12-19T22:02:22 <Roboraider> Thanks!
246 2010-12-19T22:06:48 <ThomasWaldmann> thanks for fixing :)
247 2010-12-19T22:06:50 <jbills> ThomasWaldmann: http://paste.pocoo.org/show/306846/ what would be a better way to do line 239? The right side is IE code.
248 2010-12-19T22:07:28 <jbills> oh and on line 251 ie trows error if indented
249 2010-12-19T22:11:41 <ThomasWaldmann> with "right side" i mean the stuff to the right of == operator
250 2010-12-19T22:11:55 <jbills> ohh
251 2010-12-19T22:12:11 <ThomasWaldmann> that's quite a lot of hardcoded html you are comparing there and if something in that html changes, your comparison will fail
252 2010-12-19T22:12:24 <ThomasWaldmann> so, what's the point of doing this?
253 2010-12-19T22:15:11 *** ChanServ
254 2010-12-19T22:15:12 *** xjjk
255 2010-12-19T22:15:13 *** Kapace_
256 2010-12-19T22:15:13 *** ThomasWaldmann
257 2010-12-19T22:15:13 *** Samm
258 2010-12-19T22:15:15 *** valeuf
259 2010-12-19T22:15:16 *** kapace__
260 2010-12-19T22:15:17 *** jbills
261 2010-12-19T22:15:17 *** m4k3r
262 2010-12-19T22:20:05 *** Samm
263 2010-12-19T22:20:05 *** jbills
264 2010-12-19T22:20:05 *** m4k3r
265 2010-12-19T22:20:05 *** valeuf
266 2010-12-19T22:20:05 *** Kapace_
267 2010-12-19T22:20:05 *** kapace__
268 2010-12-19T22:20:05 *** xjjk
269 2010-12-19T22:20:05 *** ChanServ
270 2010-12-19T22:20:05 *** ThomasWaldmann
271 2010-12-19T22:20:05 *** barjavel.freenode.net
272 2010-12-19T22:20:26 <jbills> ok
273 2010-12-19T22:20:47 <ThomasWaldmann> well, i can't read that stuff. so i don't understand it. so i can't tell you what to do.
274 2010-12-19T22:20:58 * ThomasWaldmann is no js coder btw.
275 2010-12-19T22:21:12 <ThomasWaldmann> but i am feeling you want to check state
276 2010-12-19T22:21:13 <jbills> no anyone who is?
277 2010-12-19T22:21:46 <ThomasWaldmann> so you should maybe access some specific element and check whether it is there or what class it has or so
278 2010-12-19T22:22:14 <ThomasWaldmann> xorAxAx: TheSheep: can you help?
279 2010-12-19T22:22:48 <jbills> I will try to sett display to none then insert a node above it with th a link in it
280 2010-12-19T22:22:55 <ThomasWaldmann> maybe work on all the other issues meanwhile
281 2010-12-19T22:23:07 <jbills> :)
282 2010-12-19T22:23:12 <jbills> or :(
283 2010-12-19T22:26:44 <ThomasWaldmann> then post a new, cleaner pastebin to discuss
284 2010-12-19T22:27:58 <diofeher> hey
285 2010-12-19T22:29:35 <diofeher> in your patch, jbills , instead of use "<div id=\""
286 2010-12-19T22:29:42 <diofeher> you could use '<div id="'
287 2010-12-19T22:29:50 <diofeher> i think it's better
288 2010-12-19T22:31:08 <ThomasWaldmann> Roboraider: there are issues with your patch
289 2010-12-19T22:31:29 <Roboraider> What's wrong
290 2010-12-19T22:32:09 <Roboraider> I manually edited it. That might be the problem.
291 2010-12-19T22:32:58 <ThomasWaldmann> &target=_blank
292 2010-12-19T22:33:09 <ThomasWaldmann> that looks wrong
293 2010-12-19T22:34:08 <Roboraider> Could you explain why the &target looks wrong?
294 2010-12-19T22:34:56 <ThomasWaldmann> well, the goal of find failing tests & fix is to get correct behaviour of moin and tests succeeding because moin works correct
295 2010-12-19T22:35:09 <ThomasWaldmann> not tuning the tests so they accept wrong stuff :)
296 2010-12-19T22:36:10 <ThomasWaldmann> target=_blank in the 3rd element of link markup means that it'll set this as an attr of the <a> element
297 2010-12-19T22:37:00 <ThomasWaldmann> &foo=bar means that it will add this as and querystring key/value
298 2010-12-19T22:38:21 <ThomasWaldmann> and the tests you modified in moinwiki_in_out are maybe just for testing roundtrip behaviour
299 2010-12-19T22:39:15 <ThomasWaldmann> where's the moinwiki19 stuff btw?
300 2010-12-19T22:41:10 <Roboraider> So I need to look at the key values?
301 2010-12-19T22:41:50 <Roboraider> I forgot to insert the moinwiki19 stuff.
302 2010-12-19T22:46:59 <ThomasWaldmann> most important is first to understand what a test should test
303 2010-12-19T22:47:11 <ThomasWaldmann> then see why it is failing
304 2010-12-19T22:47:24 <ThomasWaldmann> see if test is wrong, or the code that is tested
305 2010-12-19T22:47:29 <ThomasWaldmann> fix right thing
306 2010-12-19T22:47:55 <ThomasWaldmann> just submit the moinwiki*_in fixes for now, as they are correct afaics
307 2010-12-19T22:48:06 <ThomasWaldmann> we'll look at the other stuff afterwards
308 2010-12-19T22:53:57 <jbills> ThomasWaldmann: I have got the basic idea working.
309 2010-12-19T22:53:59 <jbills> http://pastebin.com/QDZ1fdKd
310 2010-12-19T22:54:04 <Roboraider> I don't quite understand why my first patch was correct, but the other changes were not. Is it the & in target =_blank?
311 2010-12-19T22:54:14 <Roboraider> Is there documentation on this?
312 2010-12-19T22:55:27 <ThomasWaldmann> just try on a moin wiki: [[foo|bar|target=_blank]] vs. [[foo|bar|&target=_blank]]
313 2010-12-19T22:55:39 <ThomasWaldmann> HelpOnLinking should have this
314 2010-12-19T22:59:22 *** Samm
315 2010-12-19T22:59:44 <Roboraider> Thanks for the link.
316 2010-12-19T23:00:39 <Roboraider> So I shouldn't modify the ones that are used to link to a target?
317 2010-12-19T23:02:15 <ThomasWaldmann> jbills: use sane variable names :) if that is doing the same thing as the old html comparing code, yeah, that's better.
318 2010-12-19T23:03:16 <ThomasWaldmann> but note that ids must be unique
319 2010-12-19T23:03:57 <jbills> ok
320 2010-12-19T23:04:06 <jbills> But I am not sane
321 2010-12-19T23:04:12 <ThomasWaldmann> hehe
322 2010-12-19T23:04:25 <diofeher> i would say that too... x is not a good variable name =p try to put something that explain what is it
323 2010-12-19T23:11:12 <jbills> like visible?
324 2010-12-19T23:18:27 <ThomasWaldmann> sure
325 2010-12-19T23:25:47 <diofeher> or is_visible
