1 2010-12-17T00:01:09  <m4k3r> ThomasWaldmann:  have to go.
   2 2010-12-17T00:01:16  <m4k3r> What should I do?
   3 2010-12-17T00:01:30  <ThomasWaldmann> i had a quick look at abort
   4 2010-12-17T00:02:04  <ThomasWaldmann> it raises a proxyexception when you give a non-int
   5 2010-12-17T00:03:58  <m4k3r> Yep. And simply the fact handle_login calls a [..]exceptions.Aborter instead of something like show_page(redirect()) is simply wrong.
   6 2010-12-17T00:04:25  <ThomasWaldmann> eh?
   7 2010-12-17T00:04:30  <m4k3r> But I have no idea about how to display a page from there, using flask and moinmoin.
   8 2010-12-17T00:04:50  <ThomasWaldmann> if you want to redirect, it just does a redirect, everything else is next request
   9 2010-12-17T00:06:20  <m4k3r> ThomasWaldmann: seems like it doesn't. Or am I missing something in my code?
  10 2010-12-17T00:07:17  <m4k3r> Unfortunately the documentation don't cover well these aspects, so may I missed something reading the code.
  11 2010-12-17T00:07:26  <ThomasWaldmann> redirect_url = request.redirectURL(...) what's that?
  12 2010-12-17T00:07:47  <ThomasWaldmann> request is wsgi request?
  13 2010-12-17T00:08:06  <ThomasWaldmann> btw, be careful, moin 1.9 request is very different from moin2 request
  14 2010-12-17T00:09:30  <m4k3r> I gave just a quick look to moinmoin1.9; I already answered your question.
  15 2010-12-17T00:10:08  <m4k3r> http://openidenabled.com/files/python-openid/docs/1.2.0/openid.consumer.consumer.AuthRequest-class.html#redirectURL
  16 2010-12-17T00:10:44  <ThomasWaldmann> uuh, yet another request
  17 2010-12-17T00:10:53  <ThomasWaldmann> maybe name it somehow else
  18 2010-12-17T00:11:09  <m4k3r> Ok.
  19 2010-12-17T00:11:50  <m4k3r> But what can I do to redirect to that page?
  20 2010-12-17T00:12:31  <ThomasWaldmann> well, maybe do an abort(500) to see whether it executes that code
  21 2010-12-17T00:12:53  <ThomasWaldmann> if it does, it also should work with redirect(target)
  22 2010-12-17T00:13:06  <ThomasWaldmann> maybe log target, to see what it wants to redirect to
  23 2010-12-17T00:13:24  <ThomasWaldmann> or use a debugger to see why it is not working, if nothing else helps
  24 2010-12-17T00:13:47  <m4k3r> I don't understand. I should return a '500' int instead of my url?
  25 2010-12-17T00:13:56  <ThomasWaldmann> most cases I've seen when googling, is that they return redirect(target)
  26 2010-12-17T00:14:12  <ThomasWaldmann> but that is usally from a view function, not from deep in some code
  27 2010-12-17T00:14:38  <m4k3r> ThomasWaldmann:  the problem here is from the specific moinmoin authentication method, not a simple flask example.
  28 2010-12-17T00:14:52  <ThomasWaldmann> dreimark: why shall student specify the page_groups? i have given them in the task.
  29 2010-12-17T00:15:34  <ThomasWaldmann> sure, that's what I mean with deep in some code :)
  30 2010-12-17T00:18:45  <m4k3r> ThomasWaldmann: is it possible for me to contact the writer of that code?
  31 2010-12-17T00:18:58  <ThomasWaldmann> of which exactly?
  32 2010-12-17T00:19:33  <m4k3r> Also, it seems simply copied from moinmoin1.9, so it's also quite old to have been forgot.
  33 2010-12-17T00:19:47  <m4k3r> ThomasWaldmann:  of moinmoin.auth.__init__.handle_login.
  34 2010-12-17T00:20:20  <ThomasWaldmann> that was initially written by johannes berg (including the openid stuff in 1.9)
  35 2010-12-17T00:21:27  <m4k3r> And you said that the authentication methods are handled in a completely different way, right?
  36 2010-12-17T00:21:29  <ThomasWaldmann> but as I already told, I did not fully port the multistage stuff to moin2, because I don't use openid and did not port openid auth to moin2.
  37 2010-12-17T00:22:10  <ThomasWaldmann> no, code is similar minus openid/multistage.
  38 2010-12-17T00:23:07  *** TheSheep has quit IRC
  39 2010-12-17T00:23:07  *** TheSheep has joined #moin-dev
  40 2010-12-17T00:23:08  <m4k3r> Which is the aspects I was interested in, gh.
  41 2010-12-17T00:27:10  <m4k3r> I don't know how to proceed from there, and reviewing that stuff isn't my task. So I'm going to submit my actual work and these chat logs, hope they will be useful later.
  42 2010-12-17T00:30:30  <ThomasWaldmann> i told you some options about how to debug why it doesn't work
  43 2010-12-17T00:30:47  <m4k3r> Which?
  44 2010-12-17T00:31:27  <m4k3r> Use a debugger? I already know where the code goes, and which are the values of the variables I'm interested in.
  45 2010-12-17T00:31:37  <ThomasWaldmann> (00:12) < ThomasWal> well, maybe do an abort(500) to see whether it executes that code
  46 2010-12-17T00:31:41  <ThomasWaldmann> (00:12) < ThomasWal> if it does, it also should work with redirect(target)
  47 2010-12-17T00:31:43  <ThomasWaldmann> (00:13) < ThomasWal> maybe log target, to see what it wants to redirect to
  48 2010-12-17T00:31:45  <ThomasWaldmann> (00:13) < ThomasWal> or use a debugger to see why it is not working, if nothing else helps
  49 2010-12-17T00:32:00  <m4k3r> <m4k3r> I don't understand. I should return a '500' int instead of my url?
  50 2010-12-17T00:32:11  <ThomasWaldmann> yes
  51 2010-12-17T00:32:49  <ThomasWaldmann> it won't redirect then of course, but if it doesn't blow up with 500, you'll know that it does not execute the code
  52 2010-12-17T00:33:33  <ThomasWaldmann> a logging line might do the same job, see next suggestion
  53 2010-12-17T00:33:38  <ThomasWaldmann> + tell url
  54 2010-12-17T00:33:56  *** jbills has joined #moin-dev
  55 2010-12-17T00:35:40  <m4k3r> ThomasWaldmann:  I know that code is executed becouse I've putted many prints in there before.
  56 2010-12-17T00:36:05  <m4k3r> And: File "/home/maker/dev/moinmoin/MoinMoin/auth/__init__.py", line 384, in handle_login
  57 2010-12-17T00:36:05  <m4k3r> url = url.replace('%return_form', url_quote_plus(nextstage))
  58 2010-12-17T00:36:05  <m4k3r> AttributeError: 'int' object has no attribute 'replace'
  59 2010-12-17T00:36:52  <m4k3r> ^ this is becouse of  giving a int('500') to redirect.
  60 2010-12-17T00:37:44  <ThomasWaldmann> i said abort(500), not redirect(500)
  61 2010-12-17T00:41:32  *** m4k3r has quit IRC
  62 2010-12-17T00:42:18  *** m4k3r has joined #moin-dev
  63 2010-12-17T00:43:18  <m4k3r>  ThomasWaldmann: I'm still getting «File "/home/maker/dev/moinmoin/MoinMoin/support/werkzeug/exceptions.py", line 450, in __call__       raise _ProxyException(code)              _ProxyException: <unprintable _ProxyException object>»
  64 2010-12-17T00:44:40  <ThomasWaldmann> full traceback > pastebin
  65 2010-12-17T00:47:00  <m4k3r> http://bpaste.net/show/12345/
  66 2010-12-17T00:48:13  <ThomasWaldmann> hah 12345
  67 2010-12-17T00:49:01  <m4k3r> Sorry, without the redirect I get an Internal Server Error, as expected.
  68 2010-12-17T00:49:13  * m4k3r has to sleep =_=
  69 2010-12-17T00:50:18  <m4k3r> http://bpaste.net/show/12346/
  70 2010-12-17T00:50:24  <m4k3r> Here's the traceback.
  71 2010-12-17T00:52:54  <ThomasWaldmann> hmm, it might be because it happens in preprocess_request, not in dispatch_request
  72 2010-12-17T00:53:58  <ThomasWaldmann> dispatch_request catches HTTPException internally
  73 2010-12-17T00:55:56  <m4k3r> SHould Icareabouttaht?
  74 2010-12-17T00:56:28  <m4k3r> *Should I care about
  75 2010-12-17T00:56:30  <ThomasWaldmann> that's why abort() doesn't work
  76 2010-12-17T00:56:40  <m4k3r> Oh, cool.
  77 2010-12-17T00:57:00  <ThomasWaldmann>  /join #pocoo
  78 2010-12-17T00:57:13  <m4k3r> /join #bed
  79 2010-12-17T00:57:19  <m4k3r> gn :)
  80 2010-12-17T00:58:33  <ThomasWaldmann> hehe
  81 2010-12-17T00:58:36  <ThomasWaldmann> gn
  82 2010-12-17T01:04:10  *** m4k3r has quit IRC
  83 2010-12-17T01:08:07  *** grzywacz has quit IRC
  84 2010-12-17T01:29:46  <CIA-62> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10132:3cba8e72dbd5 2.0-dev/MoinMoin/themes/modernized/static/css/ (common.css screen.css): box-shadow: add browser specific attrs for browsers not supporting this css3
  85 2010-12-17T01:29:48  <ThomasWaldmann> ronny: ^^
  86 2010-12-17T01:30:08  <ThomasWaldmann> (that is why that border stuff did not work on ff3.6)
  87 2010-12-17T03:41:44  *** eSyr has quit IRC
  88 2010-12-17T03:54:29  *** eSyr has joined #moin-dev
  89 2010-12-17T05:19:05  *** kursor has joined #moin-dev
  90 2010-12-17T05:19:30  *** kursor has joined #moin-dev
  91 2010-12-17T05:19:50  *** kursor_ has joined #moin-dev
  92 2010-12-17T05:23:40  *** kursor__ has joined #moin-dev
  93 2010-12-17T05:23:58  *** kursor has quit IRC
  94 2010-12-17T05:23:58  *** kursor__ is now known as kursor
  95 2010-12-17T05:24:24  *** kursor_ has quit IRC
  96 2010-12-17T07:17:31  *** kursor has quit IRC
  97 2010-12-17T07:24:32  *** CIA-62 has quit IRC
  98 2010-12-17T07:36:46  *** raignarok has joined #moin-dev
  99 2010-12-17T07:48:16  *** m4k3r has joined #moin-dev
 100 2010-12-17T07:49:17  <m4k3r> ThomasWaldmann:  last night you suggested me to join #poocoo. But why?
 101 2010-12-17T07:52:48  *** CIA-56 has joined #moin-dev
 102 2010-12-17T08:03:00  *** m4k3r has quit IRC
 103 2010-12-17T08:09:29  *** raignarok has quit IRC
 104 2010-12-17T08:18:51  <dreimark> moin
 105 2010-12-17T08:20:07  <dreimark> ThomasWaldmann: i found not a amount of what to translate
 106 2010-12-17T08:28:58  *** maker900 has joined #moin-dev
 107 2010-12-17T08:29:08  <maker900> re.
 108 2010-12-17T08:34:17  *** franklin has quit IRC
 109 2010-12-17T08:34:21  *** franklin has joined #moin-dev
 110 2010-12-17T08:44:36  <ThomasWaldmann> dreimark: the amount varies by language. and that doesn't necessarily improve by requesting the groups.
 111 2010-12-17T08:45:12  <ThomasWaldmann> maker900: because i discussed the redirect issue there
 112 2010-12-17T08:46:48  <ThomasWaldmann> (one can return the response object (result of redirect(url)), but raising an exception with abort() is not supported)
 113 2010-12-17T08:48:09  <maker900> Uhm. But we neither need to return the redirect, becouse there's a loop which must continue.
 114 2010-12-17T08:51:45  <ThomasWaldmann> it must?
 115 2010-12-17T08:53:14  <maker900> Yep. After the redirect, another login handler is called. This is the way moinmoin expects you login using redirects.
 116 2010-12-17T08:54:08  <maker900> If you break the loop with a return, you are going to skip the next call to the loginhandler.
 117 2010-12-17T08:54:49  <ThomasWaldmann> i am speaking of the return value of before() btw
 118 2010-12-17T08:55:12  *** maker900 has quit IRC
 119 2010-12-17T08:55:34  *** maker900 has joined #moin-dev
 120 2010-12-17T08:55:46  <maker900> Re.
 121 2010-12-17T08:55:54  <ThomasWaldmann> i am speaking of the return value of before() btw
 122 2010-12-17T08:56:11  <maker900> Mh?
 123 2010-12-17T08:56:23  <ThomasWaldmann> look in the code
 124 2010-12-17T08:56:30  <maker900> K.
 125 2010-12-17T09:03:41  *** maker900 has quit IRC
 126 2010-12-17T09:04:07  *** maker900 has joined #moin-dev
 127 2010-12-17T09:05:01  <maker900> Ok, I should look at?
 128 2010-12-17T09:06:38  <dreimark> ThomasWaldmann: i comment on http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970175
 129 2010-12-17T09:09:37  *** maker900 has quit IRC
 130 2010-12-17T09:09:53  *** maker900 has joined #moin-dev
 131 2010-12-17T09:10:34  <maker900> Re. My connection really sucks >.<
 132 2010-12-17T09:13:36  <ThomasWaldmann> dreimark: as long as we don't have a markup converter to remove attachment: we need to support that. so the question rather is whether it works correctly.
 133 2010-12-17T09:13:45  *** maker900 has quit IRC
 134 2010-12-17T09:14:41  <dreimark> ThomasWaldmann: ok, then i am fine with the result of the task
 135 2010-12-17T09:16:07  <dreimark> hmm, after christmas we may be can collect ideas for the next gsoc
 136 2010-12-17T09:16:35  <dreimark> or better after berlin
 137 2010-12-17T09:24:37  <dreimark> bbl
 138 2010-12-17T09:29:58  *** maker900 has joined #moin-dev
 139 2010-12-17T10:00:25  <dreimark> re
 140 2010-12-17T10:05:06  *** greg_f has joined #moin-dev
 141 2010-12-17T10:08:29  *** maker900 has quit IRC
 142 2010-12-17T10:08:55  *** maker900 has joined #moin-dev
 143 2010-12-17T10:20:06  <ThomasWaldmann> dreimark: as we want to release near end of year, soc might be primarily about getting it release-ready
 144 2010-12-17T10:20:54  * ThomasWaldmann added some more comments to the creole docs task
 145 2010-12-17T10:30:08  <maker900> ThomasWaldmann: where should I look at?
 146 2010-12-17T10:31:07  <maker900> I didn't see any answer.
 147 2010-12-17T10:31:16  *** rfw has quit IRC
 148 2010-12-17T10:34:48  <ThomasWaldmann> maker900: you didn't find the before() function?
 149 2010-12-17T10:39:04  <maker900> No. I'm looking at moinmoin.auth.__init__. Right now I can look only from the source on my bitbucket repo.
 150 2010-12-17T10:41:31  <ThomasWaldmann> if you are searching for something, you need the right tools and a local checkout.
 151 2010-12-17T10:41:44  <ThomasWaldmann> just for this time: before is in MoinMoin/__init__.py
 152 2010-12-17T10:47:47  <maker900> Yeah. It calls setup_user.
 153 2010-12-17T10:52:26  <maker900> What'is interesting in that function?
 154 2010-12-17T10:53:22  <ThomasWaldmann> if you return redirect(url) there, it might work.
 155 2010-12-17T10:56:17  <maker900> I have no idea about how to retrive the url from the login form there.
 156 2010-12-17T11:03:58  <ThomasWaldmann> well, if you can do it in the way it was intended (abort()-like), you could just catch that exception there
 157 2010-12-17T11:08:43  <ThomasWaldmann> bbl
 158 2010-12-17T11:13:17  *** maker900 has quit IRC
 159 2010-12-17T11:20:33  *** maker900 has joined #moin-dev
 160 2010-12-17T12:05:00  <ThomasWaldmann> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 i think this is done with the latest changeset there:
 161 2010-12-17T12:05:21  <ThomasWaldmann> https://bitbucket.org/pavel_vinogradov/gci10-moin-2.0-dev/changeset/eafcbf5cc205
 162 2010-12-17T12:06:34  <ThomasWaldmann> hmm, the review, was this done?
 163 2010-12-17T12:38:36  * dreimark looks at tasks 
 164 2010-12-17T13:09:31  *** Samm has joined #moin-dev
 165 2010-12-17T13:23:30  <ThomasWaldmann> waldi: xorAxAx: http://www.pythonsecurity.org/wiki/hashing/ see "multiple rounds" - what's your opinion on this?
 166 2010-12-17T13:25:55  <ThomasWaldmann> btw, our salt is a random string of 32 chars
 167 2010-12-17T13:26:01  <ThomasWaldmann> (for sha256)
 168 2010-12-17T13:30:13  <waldi> nothing
 169 2010-12-17T13:31:01  <ThomasWaldmann> does that mean "no opinion"?
 170 2010-12-17T13:31:19  <waldi> 1. to do it correct you need to apply the salt on every round, hmac specifies why
 171 2010-12-17T13:32:00  <waldi> 2. we have to do it ourself, so we need to waste cpu cycles, not the attacker
 172 2010-12-17T13:32:37  <ThomasWaldmann> ad 2.: we only need to compute it at login, so rather rarely
 173 2010-12-17T13:33:18  <ThomasWaldmann> and I am thinking whether this is maybe pointless anyway - doesn't salting effectively countermeasure usage of e.g. rainbox tables?
 174 2010-12-17T13:33:23  <ThomasWaldmann> bow*
 175 2010-12-17T13:33:36  <waldi> yes
 176 2010-12-17T13:34:11  <waldi> and rainbow tables will still work with many iterations
 177 2010-12-17T13:34:45  <waldi> they need more time to generate, but the usability is the same
 178 2010-12-17T13:34:45  <ThomasWaldmann> yeah, but they take even longer to compute then :) and your need n tables for n different round counts
 179 2010-12-17T13:35:24  <waldi> most likely the round count would be rather fixed. so it is only m, with m <<< n
 180 2010-12-17T13:36:09  <ThomasWaldmann> ok, so do we agree that we do not need to follow this "1000 rounds advisory"?
 181 2010-12-17T13:37:01  <ThomasWaldmann> (current best method after pavel's patch will be salted-sha256)
 182 2010-12-17T13:38:44  <ThomasWaldmann> pvinogradov: ^^ we are doing the review together :D
 183 2010-12-17T13:42:05  *** maker900 has quit IRC
 184 2010-12-17T13:56:49  <pvinogradov> ThomasWaldmann: Hi. I'm glad to see new comments and suggestion about my code.
 185 2010-12-17T14:22:05  <pvinogradov> where i can read about existing guidelines for code security review in moin?
 186 2010-12-17T14:35:07  *** m4k3r has joined #moin-dev
 187 2010-12-17T14:39:38  *** skylamer` has joined #moin-dev
 188 2010-12-17T14:40:10  <jbills> dreimark: The title does not show?
 189 2010-12-17T14:44:40  <ThomasWaldmann> pvinogradov: there is a link in your task description
 190 2010-12-17T14:44:52  <ThomasWaldmann> but feel free to google for other stuff
 191 2010-12-17T15:03:47  <CIA-56> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10133:f3fb8a488dac 2.0-dev/docs/user/ (creolewiki.rst markups.rst mediawiki.rst): add sphinx/rst docs for creole wiki and mediawiki markup (thanks to Sam T. and Peter Hoffmann, GCI 2010)
 192 2010-12-17T15:13:45  <jbills> dreimark: Sorry my js was in a different copy of moinmoin2
 193 2010-12-17T16:08:59  <dreimark> jbills: i have no title, only a [+] last time I tried it
 194 2010-12-17T16:09:10  <jbills> dreimark: Sorry my js was in a different copy of moinmoin2
 195 2010-12-17T16:09:37  <jbills> I will make a new patch from the latest moinmoin
 196 2010-12-17T16:09:54  <dreimark> :)
 197 2010-12-17T16:10:48  <jbills> tortoisehg takes forever to clone
 198 2010-12-17T16:12:06  <ThomasWaldmann> you should only need to clone once (from our repo), next clone you need can be done locally then
 199 2010-12-17T16:16:54  <dreimark> jbills: if you want to update your already existing clone
 200 2010-12-17T16:17:11  <dreimark> you can execute  hg pull -u
 201 2010-12-17T16:17:15  <jbills> no I have used the zips from the mirror
 202 2010-12-17T16:17:21  <dreimark> in the directory
 203 2010-12-17T16:18:21  <dreimark> jbills: you can also try to clone from https://bitbucket.org/thomaswaldmann/moin-2.0-dev
 204 2010-12-17T16:18:43  <jbills> I know
 205 2010-12-17T16:26:30  *** kursor has joined #moin-dev
 206 2010-12-17T16:27:00  *** kursor has joined #moin-dev
 207 2010-12-17T16:36:03  <dreimark> bbl
 208 2010-12-17T16:48:39  *** Samm has quit IRC
 209 2010-12-17T16:50:00  *** raignarok has joined #moin-dev
 210 2010-12-17T17:15:57  *** kursor has quit IRC
 211 2010-12-17T17:39:58  *** eSyr has quit IRC
 212 2010-12-17T17:39:59  *** aa_ has quit IRC
 213 2010-12-17T17:39:59  *** waldi has quit IRC
 214 2010-12-17T17:41:49  *** eSyr has joined #moin-dev
 215 2010-12-17T17:41:49  *** aa_ has joined #moin-dev
 216 2010-12-17T17:41:49  *** waldi has joined #moin-dev
 217 2010-12-17T18:13:30  *** fucheeno has joined #moin-dev
 218 2010-12-17T18:18:05  *** fucheeno has quit IRC
 219 2010-12-17T18:18:05  *** fucheeno_ has joined #moin-dev
 220 2010-12-17T18:18:05  *** fucheeno_ is now known as fucheeno
 221 2010-12-17T18:25:29  *** pvinogradov is now known as pvinogradov_
 222 2010-12-17T18:36:34  *** raignarok has quit IRC
 223 2010-12-17T18:46:30  *** fucheeno has left #moin-dev
 224 2010-12-17T18:47:54  *** grzywacz has joined #moin-dev
 225 2010-12-17T18:47:54  *** grzywacz has joined #moin-dev
 226 2010-12-17T18:48:16  *** fucheeno_ has joined #moin-dev
 227 2010-12-17T18:48:17  *** fucheeno_ is now known as fucheeno
 228 2010-12-17T19:18:29  *** fucheeno_ has joined #moin-dev
 229 2010-12-17T19:18:29  *** fucheeno has quit IRC
 230 2010-12-17T19:18:29  *** fucheeno_ is now known as fucheeno
 231 2010-12-17T19:46:21  *** fucheeno has left #moin-dev
 232 2010-12-17T19:50:12  *** greg_f has quit IRC
 233 2010-12-17T19:52:15  *** raignarok has joined #moin-dev
 234 2010-12-17T20:19:13  *** jdwcornell has joined #moin-dev
 235 2010-12-17T20:24:02  *** jdwcornell has quit IRC
 236 2010-12-17T20:40:33  *** raignarok has quit IRC
 237 2010-12-17T21:13:09  *** rfw has joined #moin-dev
 238 2010-12-17T21:15:35  *** skylamer` has quit IRC
 239 2010-12-17T21:22:22  <dreimark> ThomasWaldmann: can you rebuild the sphinx docu please
 240 2010-12-17T21:37:50  *** NikitaUtiu has joined #moin-dev
 241 2010-12-17T21:46:20  <NikitaUtiu> hello, all!
 242 2010-12-17T21:48:13  <ThomasWaldmann> hi NikitaUtiu
 243 2010-12-17T21:48:45  <NikitaUtiu> i have looked over the code several times, but i'm not sure i can complete it
 244 2010-12-17T21:51:16  <ThomasWaldmann> http://moinmo.in/EasyToDo/redesign%20theme%20footer comments please
 245 2010-12-17T21:51:32  <ThomasWaldmann> NikitaUtiu: give a url what your are referring to
 246 2010-12-17T21:52:02  <ThomasWaldmann> and ask more specific questions, we are here to help you :)
 247 2010-12-17T21:52:47  *** raignarok has joined #moin-dev
 248 2010-12-17T21:53:01  <NikitaUtiu> i am little confused by the code of the converter, the one that extracts all the outgoing links
 249 2010-12-17T21:53:18  <NikitaUtiu> i don't know exactly how the function is called
 250 2010-12-17T21:54:30  <ThomasWaldmann> that's normal :D
 251 2010-12-17T21:55:39  <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev/file/f3fb8a488dac/MoinMoin/items/__init__.py#l1074 see there
 252 2010-12-17T21:56:08  <ThomasWaldmann> and 1081/1082
 253 2010-12-17T22:03:10  <ThomasWaldmann> NikitaUtiu: clearer now?
 254 2010-12-17T22:03:59  <NikitaUtiu> i think i'm getting a little hang of it
 255 2010-12-17T22:04:49  <ThomasWaldmann> it operates on a "moin-dom" tree in memory, the input wiki markup was already converted to that tree representation
 256 2010-12-17T22:05:49  <NikitaUtiu> oh, i thought it is given markup
 257 2010-12-17T22:05:55  <ThomasWaldmann> (that makes this task a lot easier, just imagine you had to modify n different parsers to do that)
 258 2010-12-17T22:07:10  <ThomasWaldmann> see 1079 - that converts input markup to the tree (doc is a tree)
 259 2010-12-17T22:14:03  <ThomasWaldmann> is it clear what wiki.local means?
 260 2010-12-17T22:14:45  <NikitaUtiu> i have to leave now, but i'll be more free this weekend
 261 2010-12-17T22:14:48  <NikitaUtiu> bye
 262 2010-12-17T22:14:53  <ThomasWaldmann> cu
 263 2010-12-17T22:17:10  *** Roboraider has joined #moin-dev
 264 2010-12-17T22:18:28  <Roboraider> what program should I use for debugging pytest?
 265 2010-12-17T22:19:21  *** NikitaUtiu has quit IRC
 266 2010-12-17T22:20:56  <ThomasWaldmann> what's the problem?
 267 2010-12-17T22:22:51  <Roboraider> I'm using pytest to look at the unittests and understand where they fail.  I'm currently trying to do this without a debugger.
 268 2010-12-17T22:22:54  <Roboraider> Is there a way to start a debugger to set a break point and look at the values
 269 2010-12-17T22:23:34  <ThomasWaldmann> if a unit test fails and you have no idea why, it is maybe a bad test
 270 2010-12-17T22:23:50  <ThomasWaldmann> it should at least give some information
 271 2010-12-17T22:24:43  <Roboraider> It gives information, but I'm trying to do another find a failing test, determine problem, fix it and a debugger would really help
 272 2010-12-17T22:25:13  <ThomasWaldmann> eclipse/pydev has a debugger
 273 2010-12-17T22:25:34  <jbills> is the background supposed to be #F3F7FD
 274 2010-12-17T22:26:08  <ThomasWaldmann> jbills: that very light bluecyan?
 275 2010-12-17T22:27:00  <ThomasWaldmann> yes, that is intended. we'll test if for a while, maybe it needs some minor adjustment.
 276 2010-12-17T22:30:33  <jbills> its th same color as the toc
 277 2010-12-17T22:30:59  <Roboraider> I have an editor eric running. Should I switch to eclipse?
 278 2010-12-17T22:32:35  *** raignarok has quit IRC
 279 2010-12-17T22:34:06  <ThomasWaldmann> eric has also a debugger, didn't use that recently, though
 280 2010-12-17T22:34:59  *** kursor has joined #moin-dev
 281 2010-12-17T22:36:07  <Roboraider> How would I run pytest in an IDE?
 282 2010-12-17T22:36:41  <ThomasWaldmann> i guess i would use google :)
 283 2010-12-17T22:37:13  <Roboraider> How would I run it in eclipse?
 284 2010-12-17T22:37:50  <ThomasWaldmann> debug ...
 285 2010-12-17T22:38:29  <ThomasWaldmann> maybe you need some python entry point, use google :)
 286 2010-12-17T22:45:51  <Roboraider> I see that pytest has a --pdb option.  Can  I use that for setting break points?
 287 2010-12-17T22:46:05  <Roboraider> If so, how would I set break points?
 288 2010-12-17T22:47:45  <ThomasWaldmann> if nothing else helps, try the docs :D
 289 2010-12-17T22:48:07  <Roboraider> Which docs?
 290 2010-12-17T22:49:02  <ThomasWaldmann> py.test docs?
 291 2010-12-17T23:03:08  *** raignarok has joined #moin-dev
 292 2010-12-17T23:16:47  *** Roboraider has quit IRC
 293 2010-12-17T23:25:43  <ThomasWaldmann> any comments on the easytodo tasks that are pending for upload?
 294 2010-12-17T23:42:13  <dreimark> ThomasWaldmann: this are the translation tasks?
 295 2010-12-17T23:42:35  <dreimark> we should define a minimum amount
 296 2010-12-17T23:45:16  <dreimark> gn
 297 2010-12-17T23:47:43  <ThomasWaldmann> we don't need to accept if it's not enough

MoinMoin: MoinMoinChat/Logs/moin-dev/2010-12-17 (last edited 2010-12-16 23:45:03 by IrcLogImporter)