1 2010-12-11T00:05:47  *** grzywacz has joined #moin-dev
   2 2010-12-11T00:13:22  <ThomasWaldmann> dreimark: can you look through the translation tasks and approve them?
   3 2010-12-11T00:15:35  <m4k3r> ThomasWaldmann:  !
   4 2010-12-11T00:16:18  <ThomasWaldmann> m4k3r: you know what a contentless ping is? :)
   5 2010-12-11T00:18:37  <m4k3r> ThomasWaldmann:  no, but previously I had written a question; and now I am wondering if you could check the draft for opneid support.
   6 2010-12-11T00:19:13  <ThomasWaldmann> i can try, but it is rather bedtime for me
   7 2010-12-11T00:19:25  <ThomasWaldmann> so if you hear me snoring .... :)
   8 2010-12-11T00:19:59  <m4k3r> Yep, for me too, so just a quick check of 2 minutes.
   9 2010-12-11T00:20:03  <ThomasWaldmann> m4k3r: and if you have a question either tell date/time or post it again
  10 2010-12-11T00:22:01  <ThomasWaldmann> ok, 3 new tasks published, 3 more coming from dreimark
  11 2010-12-11T00:22:10  <m4k3r> ThomasWaldmann:  first of all → http://bitbucket.org/maker/moin-2.0-dev/src/7c3a5b7bb64c/MoinMoin/apps/frontend/views.py#cl-813
  12 2010-12-11T00:23:22  <m4k3r> using_openid is defined here: http://bitbucket.org/maker/moin-2.0-dev/src/7c3a5b7bb64c/MoinMoin/config/default.py#cl-124
  13 2010-12-11T00:24:17  * ThomasWaldmann looks
  14 2010-12-11T00:25:30  <ThomasWaldmann> you didn't try that, right? :)
  15 2010-12-11T00:25:44  *** grzywacz has quit IRC
  16 2010-12-11T00:25:44  <m4k3r> And this is my template file for OpenID login. http://bitbucket.org/maker/moin-2.0-dev/src/tip/MoinMoin/templates/login_oid.html
  17 2010-12-11T00:25:50  <m4k3r> ThomasWaldmann:  yep, I tried it.
  18 2010-12-11T00:26:20  <ThomasWaldmann> so how does it work without self. ?
  19 2010-12-11T00:26:36  <m4k3r> There's something buggy becouse it says  I'm logged in although I'm not really :D
  20 2010-12-11T00:26:43  <m4k3r> ThomasWaldmann:  where.
  21 2010-12-11T00:27:43  <ThomasWaldmann> there where you define using_openid
  22 2010-12-11T00:28:45  *** h_peter has joined #moin-dev
  23 2010-12-11T00:28:51  <m4k3r> I'll check that tomorrow, I wanted from you to tell me everything is in the right place.
  24 2010-12-11T00:29:26  <m4k3r> Here http://bitbucket.org/maker/moin-2.0-dev/src/tip/MoinMoin/user.py#cl-127  and here http://bitbucket.org/maker/moin-2.0-dev/src/tip/MoinMoin/user.py#cl-83
  25 2010-12-11T00:30:00  <m4k3r> There is some extra stuff for dealing with openids and users (search for, add openid url)
  26 2010-12-11T00:30:16  <ThomasWaldmann> try to render the get template only at one place in the handler
  27 2010-12-11T00:31:21  <m4k3r> ThomasWaldmann:  you mean, in views, the return render_template()?
  28 2010-12-11T00:31:44  <ThomasWaldmann> yes
  29 2010-12-11T00:31:48  <m4k3r> Ok.
  30 2010-12-11T00:31:56  <ThomasWaldmann> and if you use translatable strings, use _()
  31 2010-12-11T00:32:28  <ThomasWaldmann>              flash(u'Successfully signed in')
  32 2010-12-11T00:32:31  <m4k3r> I've missed something? Actually I use it in the template film.
  33 2010-12-11T00:32:49  <m4k3r> *file (ok, I have to go to bed) :)
  34 2010-12-11T00:33:08  <ThomasWaldmann> hehe
  35 2010-12-11T00:34:03  <m4k3r> Anything else?
  36 2010-12-11T00:35:16  <ThomasWaldmann> i had a quick look at user.py, looks ok afaics
  37 2010-12-11T00:35:48  <ThomasWaldmann> do you intend to integrate this with moin's auth list somehow?
  38 2010-12-11T00:37:22  <m4k3r> I tried to add a MoinMoin.auth.openid_login file, but actually it's impossible using flask-openid. It has almost everything on the decorators in views.py :\
  39 2010-12-11T00:38:09  <m4k3r> And modules such as "oid.try_login" are built up to be used inside the decorated function.
  40 2010-12-11T00:39:19  <dreimark> ThomasWaldmann: will do
  41 2010-12-11T00:39:32  <ThomasWaldmann> dreimark: done :)
  42 2010-12-11T00:39:40  <ThomasWaldmann> thought you were already sleeping
  43 2010-12-11T00:40:05  <ThomasWaldmann> i gave 9d btw, so that this and next weekend is included
  44 2010-12-11T00:40:49  <m4k3r> gn o/ and thanks.
  45 2010-12-11T00:41:38  <dreimark> ThomasWaldmann: no i got distracted by a mail, did some remote server configuration
  46 2010-12-11T00:41:38  <ThomasWaldmann> gn m4k3r
  47 2010-12-11T00:42:01  <dreimark> gn m4k3r
  48 2010-12-11T00:42:04  *** m4k3r has quit IRC
  49 2010-12-11T00:44:13  <h_peter> ThomasWaldmann: I updated mwhelp in the test wiki
  50 2010-12-11T00:44:31  <ThomasWaldmann> hi h_peter
  51 2010-12-11T00:45:25  <h_peter> hi.
  52 2010-12-11T00:47:08  <ThomasWaldmann> maybe use some other main headline
  53 2010-12-11T00:47:50  <ThomasWaldmann> this is for end users, maybe "MediaWiki markup overview" or so?
  54 2010-12-11T00:48:07  <ThomasWaldmann> quick reference?
  55 2010-12-11T00:49:01  <h_peter> is it really a quick reference?
  56 2010-12-11T00:50:49  <dreimark> good night
  57 2010-12-11T00:51:45  <ThomasWaldmann> gn dreimark
  58 2010-12-11T00:52:20  <ThomasWaldmann> h_peter: choose whatever you think it is. just "MediaWiki format" sounded a bit too formal.
  59 2010-12-11T00:52:44  <h_peter> ok, i used Mediawiki markup overview
  60 2010-12-11T00:52:47  <h_peter> what next?
  61 2010-12-11T00:53:03  <ThomasWaldmann> btw, nice that we found some more stuff to fix at misc. places. obviously it helps to try to use stuff practically :)
  62 2010-12-11T00:53:16  <ThomasWaldmann> did you check it for completeness?
  63 2010-12-11T00:54:51  <h_peter> i used the formatting help of mediawiki as template so it should be complete
  64 2010-12-11T00:55:24  <ThomasWaldmann> ^ \#\#
  65 2010-12-11T00:55:32  <ThomasWaldmann> block comment?
  66 2010-12-11T00:57:36  <ThomasWaldmann> does mediawiki markup do comments like this:
  67 2010-12-11T00:57:39  <ThomasWaldmann>  ## ....
  68 2010-12-11T00:57:55  <ThomasWaldmann>  /* ... */
  69 2010-12-11T00:58:10  <h_peter> no, it uses html comments <!-- ... -->
  70 2010-12-11T00:58:48  <ThomasWaldmann> hmm, our mw parser seems to parse that stuff :)
  71 2010-12-11T00:58:57  <ThomasWaldmann> is it wrong?
  72 2010-12-11T00:59:41  <h_peter> shall i include it?
  73 2010-12-11T00:59:46  <ThomasWaldmann> entities? &foo; &#xxxx;
  74 2010-12-11T01:00:07  <ThomasWaldmann> please check if the parser is wrong or your reference is incomplete
  75 2010-12-11T01:00:30  <ThomasWaldmann> if mw does not do that, add a MWTODO rather than just documenting it
  76 2010-12-11T01:00:48  <h_peter> ok
  77 2010-12-11T01:01:05  <ThomasWaldmann> <ref ... for footnotes?
  78 2010-12-11T01:01:50  <ThomasWaldmann> h_peter: you know python and regex a bit?
  79 2010-12-11T01:04:37  <ThomasWaldmann> that's all i could find for now, i just went through converter/mediawiki_in.py in moin/2.0-dev
  80 2010-12-11T01:05:31  *** h_peter has quit IRC
  81 2010-12-11T01:07:31  *** h_peter has joined #moin-dev
  82 2010-12-11T01:08:54  <ThomasWaldmann> wb :)
  83 2010-12-11T01:09:10  <ThomasWaldmann> h_peter: what was the last you got via irc?
  84 2010-12-11T01:10:46  <h_peter> whether i knew python and regex
  85 2010-12-11T01:11:50  <ThomasWaldmann> (01:04) < ThomasWal> that's all i could find for now, i just went through converter/mediawiki_in.py in moin/2.0-dev
  86 2010-12-11T01:12:27  <ThomasWaldmann> so comments, entities and footnotes to check
  87 2010-12-11T01:12:47  <ThomasWaldmann> other than that, I think you're mostly done
  88 2010-12-11T01:13:57  <h_peter> ok
  89 2010-12-11T01:16:35  <ThomasWaldmann> btw, if you notice that something from original mw is missing that we could maybe easily do, some note about that would be also interesting
  90 2010-12-11T01:55:49  * h_peter updated it
  91 2010-12-11T01:58:41  <ThomasWaldmann> h_peter: please check for typos, e.g. symol
  92 2010-12-11T01:59:15  <ThomasWaldmann> and is it "Symbol entities" or rather "Symbolic entities"?
  93 2010-12-11T01:59:58  <h_peter> mw manual says symbol entities
  94 2010-12-11T02:00:19  <ThomasWaldmann> how about numeric entities?
  95 2010-12-11T02:04:26  <h_peter> but i think it would be the best to just mention them and do not give any examples
  96 2010-12-11T02:06:15  <ThomasWaldmann> yes :)
  97 2010-12-11T02:16:47  *** grzywacz has joined #moin-dev
  98 2010-12-11T02:19:08  <h_peter> ok, i added one sentence about numeric entities, is this appropriate?
  99 2010-12-11T02:20:51  <ThomasWaldmann> ; ?
 100 2010-12-11T02:23:49  *** h_peter has quit IRC
 101 2010-12-11T04:12:29  *** grzywacz has quit IRC
 102 2010-12-11T09:18:56  *** samm has joined #moin-dev
 103 2010-12-11T09:20:03  <samm> Hi there!
 104 2010-12-11T09:20:24  <samm> I'm interested for a MoinMoin Task
 105 2010-12-11T09:20:40  <samm> And I want some explains for it.
 106 2010-12-11T09:20:46  <samm> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129202087976
 107 2010-12-11T09:24:31  <ThomasWaldmann> hi samm
 108 2010-12-11T09:24:42  <samm> ThomasWaldmann: hi Thomas
 109 2010-12-11T09:25:07  <samm> ThomasWaldmann: I'm looking after this MoinMoin task:http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129202087976
 110 2010-12-11T09:25:18  <ThomasWaldmann> yes?
 111 2010-12-11T09:25:27  <samm> ThomasWaldmann: of course after I will finish my current task, I will probably claim this task
 112 2010-12-11T09:25:53  <samm> ThomasWaldmann: could you tell me what image should I make
 113 2010-12-11T09:26:04  <samm> ThomasWaldmann: is specified that a Background Image
 114 2010-12-11T09:26:56  <samm> ThomasWaldmann: but it can be , header background image(on Banner Line) or body background
 115 2010-12-11T09:27:00  <ThomasWaldmann> well, we expect some artistic skill and taste :) so simply have a look at how moin2 looks like and decide yourself
 116 2010-12-11T09:27:31  <ThomasWaldmann> we already have a clouds-style header bg image
 117 2010-12-11T09:28:05  <ThomasWaldmann> samm: can you use mercurial to check out current moin2?
 118 2010-12-11T09:29:23  <ThomasWaldmann> you could either to header bg (something different / better), or body bg
 119 2010-12-11T09:29:42  <ThomasWaldmann> just try to follow the guidelines in the task
 120 2010-12-11T09:32:45  <samm> isn't any webinterface for mercurial?
 121 2010-12-11T09:37:13  <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev is the current version
 122 2010-12-11T09:37:58  <ThomasWaldmann> if you don't like to use mercurial, you can also click on the bz2 link there to get the current version
 123 2010-12-11T09:41:15  <ThomasWaldmann> you can run moin by starting "moin" in the toplevel directory
 124 2010-12-11T09:44:09  <ThomasWaldmann> samm: still there?
 125 2010-12-11T09:46:55  <samm> ThomasWaldmann: yes
 126 2010-12-11T09:55:48  <dreimark> moin
 127 2010-12-11T09:58:18  <ThomasWaldmann> moin dreimark
 128 2010-12-11T09:58:42  * ThomasWaldmann will be away for most of today btw.
 129 2010-12-11T09:58:54  <samm> ThomasWaldmann: Ok thomas, we'll talk later
 130 2010-12-11T09:59:40  *** samm is now known as samm|brb_drop_a_
 131 2010-12-11T09:59:47  *** samm|brb_drop_a_ is now known as samm|brb
 132 2010-12-11T10:44:38  *** greg_f has joined #moin-dev
 133 2010-12-11T10:49:24  *** rfw has quit IRC
 134 2010-12-11T12:23:07  <dreimark> bbl
 135 2010-12-11T13:52:46  *** kursor has joined #moin-dev
 136 2010-12-11T13:55:30  *** grzywacz has joined #moin-dev
 137 2010-12-11T16:37:21  <ThomasWaldmann> anything urgent? :)
 138 2010-12-11T17:40:43  *** h_peter has joined #moin-dev
 139 2010-12-11T17:40:56  <h_peter> hi
 140 2010-12-11T17:43:49  <ThomasWaldmann> ho
 141 2010-12-11T17:48:07  <h_peter> is there still anything to do for mwhelp?
 142 2010-12-11T17:48:55  <ThomasWaldmann> did you check what we talked last time?
 143 2010-12-11T17:49:20  <ThomasWaldmann> comments stuff
 144 2010-12-11T17:50:16  <h_peter> yes, i already added a comments section
 145 2010-12-11T17:50:22  <h_peter> and checked with moin2
 146 2010-12-11T17:51:34  <ThomasWaldmann> and you checked that the stuff i told ( ## ... and /* ... */ ) is definitely NOT supported by mw?
 147 2010-12-11T17:52:26  <ThomasWaldmann> if that is the case please put some MWTODO remove ## ... and /* ... */ comments
 148 2010-12-11T17:54:11  <ThomasWaldmann> (but please thoroughly research that first / try it in mw and moin2, so that we don't remove something accidentally :)
 149 2010-12-11T17:55:03  <ThomasWaldmann> after that, submit a copy of the current version as mwhelp.txt or so to melange and request review, so we can close it
 150 2010-12-11T17:55:38  <h_peter> as for me, /* .. */ is not supported (neither by mw nor by moin2!)
 151 2010-12-11T17:55:54  <ThomasWaldmann> ok and
 152 2010-12-11T17:55:57  <ThomasWaldmann>  # ...
 153 2010-12-11T17:56:05  <ThomasWaldmann> ^ note the blank at start of line
 154 2010-12-11T17:56:11  <ThomasWaldmann> ehrm
 155 2010-12-11T17:56:13  <ThomasWaldmann>  ## ...
 156 2010-12-11T17:56:17  <ThomasWaldmann> ^ note the blank at start of line
 157 2010-12-11T17:56:43  <ThomasWaldmann> it looks like our mw parser has some incomplete support to parse that
 158 2010-12-11T17:56:55  <h_peter> # and ## are strange...
 159 2010-12-11T17:57:20  <h_peter> that should be numbered lists, but it works only if a space is typed after the number sign
 160 2010-12-11T17:57:55  <h_peter> else, ## is treated as comment (in moin2)
 161 2010-12-11T17:58:07  <ThomasWaldmann> even if a blank is at start of line?
 162 2010-12-11T17:58:21  <h_peter> without blank at start of line
 163 2010-12-11T17:58:47  <ThomasWaldmann> if you have the moin2 src checked out, see converter/mediawiki_in.py to see what I mean
 164 2010-12-11T17:59:10  * h_peter looking…
 165 2010-12-11T18:02:50  <h_peter> i found what you mentioned, but as for me, moin2 interpretes ## (without blank) as comment
 166 2010-12-11T18:04:14  <h_peter> but i would simply remove this as it is too similar to the syntax of numbered lists…
 167 2010-12-11T18:05:21  <ThomasWaldmann> i don't know what the developer thought when implementing this
 168 2010-12-11T18:05:33  <ThomasWaldmann> maybe he just copied another parser and forgot to remove it
 169 2010-12-11T18:05:49  <h_peter> ok, so i'll simply add a mwtodo
 170 2010-12-11T18:06:02  <ThomasWaldmann> ok, so if original mediawiki does not do such comments, add a MWTODO to remove that
 171 2010-12-11T18:06:17  <ThomasWaldmann> and same for /* .... */ if mediawiki does not know that
 172 2010-12-11T18:07:38  <ThomasWaldmann> MoinMoin:DmitryAndreev < we need to ask him :)
 173 2010-12-11T18:08:01  <ThomasWaldmann> but that's not part of YOUR task :)
 174 2010-12-11T18:20:56  <h_peter> ok, i'm going to submit it now
 175 2010-12-11T18:21:37  <ThomasWaldmann> great :)
 176 2010-12-11T18:22:31  <ThomasWaldmann> ehrm, /* ... */ is still unclear?
 177 2010-12-11T18:22:44  <ThomasWaldmann> if not, please add a comment for that also
 178 2010-12-11T18:23:12  * ThomasWaldmann looked at the mwhelp page on the test wiki
 179 2010-12-11T18:24:20  * ThomasWaldmann will leave soon
 180 2010-12-11T18:24:29  <h_peter> with my checked out moin2, /* ... */ is not interpreted
 181 2010-12-11T18:24:43  <ThomasWaldmann> but it has code / regex for it :)
 182 2010-12-11T18:24:56  <h_peter> oh, but it is simply printed…
 183 2010-12-11T18:25:15  <ThomasWaldmann> so the question is whether original mediawiki implements that or not
 184 2010-12-11T18:25:23  <ThomasWaldmann> if not, we should remove that
 185 2010-12-11T18:25:32  <ThomasWaldmann> and have a todo for it
 186 2010-12-11T18:32:05  <h_peter> i cannot reproduce it, but as it is in the code i added a todo
 187 2010-12-11T18:32:31  <ThomasWaldmann> reproduce what?
 188 2010-12-11T18:32:56  <ThomasWaldmann> what happens in mediawiki with /* foo */ ?
 189 2010-12-11T18:32:57  <h_peter> comments like /* */ in moin2
 190 2010-12-11T18:33:16  <h_peter> in mediawiki, it is not interpreted as comment
 191 2010-12-11T18:33:22  <h_peter> and for me, in moin2 also
 192 2010-12-11T18:33:29  <ThomasWaldmann> ok, then it is a remove from code
 193 2010-12-11T18:33:40  <ThomasWaldmann> and discuss with dmitry
 194 2010-12-11T18:34:17  <ThomasWaldmann> if you submit for review now, i can close it
 195 2010-12-11T18:34:34  <h_peter> but the mwtodo for these comments is ok?
 196 2010-12-11T18:34:39  <ThomasWaldmann> otherwise someone else has to, because I'll leave rsn
 197 2010-12-11T18:35:08  <ThomasWaldmann> yes
 198 2010-12-11T18:35:49  * h_peter submitted.
 199 2010-12-11T18:38:05  * ThomasWaldmann leaves, bbl
 200 2010-12-11T18:38:44  <h_peter> thanks for accepting!
 201 2010-12-11T18:40:46  *** h_peter1 has joined #moin-dev
 202 2010-12-11T18:43:10  *** h_peter has quit IRC
 203 2010-12-11T19:07:23  *** h_peter1 has left #moin-dev
 204 2010-12-11T19:19:32  *** greg_f has quit IRC
 205 2010-12-11T19:30:44  *** rfw has joined #moin-dev
 206 2010-12-11T20:07:17  *** jbills has joined #moin-dev
 207 2010-12-11T20:10:54  <jbills> my code does this: http://dropmocks.com/mM3DJ
 208 2010-12-11T20:11:03  *** GCIBot has joined #moin-dev
 209 2010-12-11T20:13:55  <jbills> here it is: http://paste.pocoo.org/show/303622/
 210 2010-12-11T20:14:22  <jbills> Can someone tell me why my code has paragraph symbols in it?
 211 2010-12-11T20:27:17  <jbills> Is any one here?
 212 2010-12-11T20:32:46  *** Roboraider has joined #moin-dev
 213 2010-12-11T20:33:48  <Roboraider> hi, i'm looking to do the find a bug, fix a bug task and i'm wondering if you could help me choose a bug
 214 2010-12-11T20:33:52  <Roboraider> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965081
 215 2010-12-11T20:45:36  *** m4k3r has joined #moin-dev
 216 2010-12-11T20:54:12  <Roboraider> hello?
 217 2010-12-11T20:55:34  <jbills> Roboraider: I dont think anyone is home right now
 218 2010-12-11T20:56:07  *** samm|brb has quit IRC
 219 2010-12-11T21:32:05  <jbills> Any one here yet?
 220 2010-12-11T21:43:55  *** m4k3r has quit IRC
 221 2010-12-11T21:46:26  *** Roboraider has quit IRC
 222 2010-12-11T21:47:55  <dreimark> re
 223 2010-12-11T21:49:16  <dreimark> jbills: where do you have paragraph symbols?
 224 2010-12-11T21:49:45  <jbills> right before the minimize buttons
 225 2010-12-11T21:49:51  <dreimark> line
 226 2010-12-11T21:51:01  <dreimark> this is no patch, for us applying a patch is much easier than inserting it manually
 227 2010-12-11T21:51:21  <dreimark> don't use str
 228 2010-12-11T21:51:32  *** samm has joined #moin-dev
 229 2010-12-11T21:52:03  <dreimark> rather "something %s" % parameter (read about string substitution)
 230 2010-12-11T21:52:23  <dreimark> read PEP8
 231 2010-12-11T21:53:05  *** samm has quit IRC
 232 2010-12-11T21:53:27  *** Samm has joined #moin-dev
 233 2010-12-11T21:55:11  *** Roboraider has joined #moin-dev
 234 2010-12-11T21:55:35  <dreimark> or run pytest MoinMoin/_test/test_sourcecode.py until it is happy
 235 2010-12-11T22:04:09  <Roboraider> Hi, I'm interested in the find a bug, fix a bug task.  Could you help me select a bug to fix?
 236 2010-12-11T22:04:13  <Roboraider> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965081
 237 2010-12-11T22:04:22  <dreimark> and ?
 238 2010-12-11T22:06:17  <Roboraider> oops
 239 2010-12-11T22:06:20  <Roboraider> sorry
 240 2010-12-11T22:06:55  <Roboraider> i meant find a failing test, determine problem, and fix it
 241 2010-12-11T22:06:59  <Roboraider> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696
 242 2010-12-11T22:09:11  <dreimark> you can look at MoinMoinBugs for 1.9 or run pytest in moin-2.0
 243 2010-12-11T22:09:36  <dreimark> depends a bit on your interests.
 244 2010-12-11T22:11:45  <dreimark> we need to discuss after you selected something to fix about the difficulty
 245 2010-12-11T22:12:12  <dreimark> for some it is also difficult for us to give the right grade
 246 2010-12-11T22:12:25  <dreimark> e.g. http://moinmo.in/MoinMoinBugs/SearchResultsURLContainsRepr
 247 2010-12-11T22:12:43  <dreimark> would be easy if it is not related to xapian and medium if it is
 248 2010-12-11T22:12:48  <Roboraider> i ran the pytest and i think i found one
 249 2010-12-11T22:13:35  <dreimark> some supereasy or pep8 don't count
 250 2010-12-11T22:22:34  <Roboraider> is this one okay?
 251 2010-12-11T22:22:37  <Roboraider> _________________________________ TestACLMiddleware.test_history_size_after_rename _________________________________
 252 2010-12-11T22:22:41  <Roboraider> self = <MoinMoin.storage._tests.test_middleware_acl.TestACLMiddleware object at 0x877a63d0>
 253 2010-12-11T22:22:45  <Roboraider>     def test_history_size_after_rename(self):
 254 2010-12-11T22:22:47  <Roboraider>         item = self.backend.create_item(u'first')
 255 2010-12-11T22:22:49  <Roboraider>         item.create_revision(0)
 256 2010-12-11T22:22:51  <Roboraider>         item.commit()
 257 2010-12-11T22:22:53  <Roboraider>         item.rename(u'second')
 258 2010-12-11T22:22:55  <Roboraider>         item.create_revision(1)
 259 2010-12-11T22:22:57  <Roboraider>         item.commit()
 260 2010-12-11T22:22:59  <Roboraider> >       assert len([rev for rev in self.backend.history()]) == 2
 261 2010-12-11T22:23:01  <Roboraider> E       assert len([<MoinMoin.storage.backends.router.StoredRouterRevision object at 0x878db510>]) == 2
 262 2010-12-11T22:23:05  <Roboraider> MoinMoin/storage/_tests/test_backends.py:637: AssertionError
 263 2010-12-11T22:23:12  <ronny> omg
 264 2010-12-11T22:23:22  <ronny> Roboraider: please use paste.pocoo.org for such stuff
 265 2010-12-11T22:23:39  <Roboraider> sorry
 266 2010-12-11T22:25:06  <Roboraider> http://paste.pocoo.org/show/303657/
 267 2010-12-11T22:26:24  <jbills> dreimark: where did I still used string
 268 2010-12-11T22:37:08  <dreimark> jbills: line 39 of your pastebin
 269 2010-12-11T22:38:10  <jbills> dreimark: Oops
 270 2010-12-11T22:39:35  <Roboraider> does the error I posted qualify as a suitable failing test?
 271 2010-12-11T22:40:11  <jbills> dreimark: http://paste.pocoo.org/show/303667/
 272 2010-12-11T22:40:34  <Roboraider> http://paste.pocoo.org/show/303657/
 273 2010-12-11T22:47:51  <dreimark> Roboraider: which py.test version have yo uused
 274 2010-12-11T22:48:21  <Roboraider> pytest-1.3.4?
 275 2010-12-11T22:48:57  <Roboraider> i ran ./pytest
 276 2010-12-11T22:49:04  <dreimark> ok, it qualifies
 277 2010-12-11T22:49:14  <Roboraider> yay
 278 2010-12-11T22:51:16  <Roboraider> is there a way to run only the test that I want to fix?
 279 2010-12-11T22:51:46  <xorAxAx> py.test test name
 280 2010-12-11T22:51:50  <xorAxAx> i.e. ./pytest test name
 281 2010-12-11T22:51:56  <Roboraider> thanks
 282 2010-12-11T22:51:58  <xorAxAx> umm, ./pytest testfile.py
 283 2010-12-11T22:52:09  <xorAxAx> or ./pytest -k someword
 284 2010-12-11T22:54:39  <Roboraider> well
 285 2010-12-11T22:55:11  <Roboraider> i tried doing that using ./pytest test name
 286 2010-12-11T22:55:28  <Roboraider> but my error doesnt appear for some reason
 287 2010-12-11T22:55:31  <Roboraider> http://paste.pocoo.org/show/303673/
 288 2010-12-11T22:55:52  <xorAxAx> it doesnt run any tests
 289 2010-12-11T22:55:56  <Roboraider> oh
 290 2010-12-11T22:56:20  <Roboraider> what do you mean?
 291 2010-12-11T22:56:24  <xorAxAx> MoinMoin/storage/_tests/test_backends.py
 292 2010-12-11T22:56:27  <xorAxAx> exists?
 293 2010-12-11T22:56:41  <xorAxAx> Roboraider: that it doesnt discover any tests in the file
 294 2010-12-11T22:58:31  *** m4k3r has joined #moin-dev
 295 2010-12-11T23:01:18  *** kursor has quit IRC
 296 2010-12-11T23:01:44  <Roboraider> thanks
 297 2010-12-11T23:01:48  <Roboraider> figure it out
 298 2010-12-11T23:01:48  <dreimark>  ~/workspace/moin-2.0-dev/pytest test_middleware_acl.py -k test_history_size_after_rename
 299 2010-12-11T23:04:11  * dreimark VOX is interesting
 300 2010-12-11T23:07:01  *** Samm has quit IRC
 301 2010-12-11T23:08:29  <dreimark> jbills: fix pep8 white space issues and provide a patch
 302 2010-12-11T23:09:14  <dreimark> you see you mistakes by running moin-2.0-dev$ pytest MoinMoin/_tests/test_sourcecode.py
 303 2010-12-11T23:10:11  <dreimark> indenting looks somehow also strange, docstrings and comments missing
 304 2010-12-11T23:15:12  <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696 (find a failing test, determine problem, fix it (difficulty: easy) 3/3)
 305 2010-12-11T23:21:17  *** Samm has joined #moin-dev
 306 2010-12-11T23:45:19  <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964696 (find a failing test, determine problem, fix it (difficulty: easy) 3/3)

MoinMoin: MoinMoinChat/Logs/moin-dev/2010-12-11 (last edited 2010-12-10 23:45:03 by IrcLogImporter)