1 2010-12-08T00:00:23 *** rfw
2 2010-12-08T00:00:44 <rfw> ThomasWaldmann: submitted again
3 2010-12-08T00:01:25 <ThomasWaldmann> http://www.spaceweather.com/ seen already?
4 2010-12-08T00:05:14 <dreimark> meteor shower
5 2010-12-08T00:06:06 * ThomasWaldmann meant the CME
6 2010-12-08T00:09:19 <rfw> ThomasWaldmann: can you check over that new moin2 patch
7 2010-12-08T00:10:29 *** nickr5
8 2010-12-08T00:11:13 <ThomasWaldmann> works now
9 2010-12-08T00:11:21 <rfw> hooray
10 2010-12-08T00:11:24 <rfw> am i done yet D:
11 2010-12-08T00:11:38 <ThomasWaldmann> (23:58) < ThomasWal> hmm, shouldn't that stuff maybe be in security/textcha.py ?
12 2010-12-08T00:12:00 <ThomasWaldmann> i mean the Form subclass and the validator
13 2010-12-08T00:12:01 <rfw> hm i could put the validator in there
14 2010-12-08T00:12:02 <rfw> i guess
15 2010-12-08T00:12:05 <rfw> yeah
16 2010-12-08T00:12:15 <ThomasWaldmann> do you use hg btw?
17 2010-12-08T00:13:14 <rfw> yes
18 2010-12-08T00:13:23 <rfw> well, i can use it
19 2010-12-08T00:13:26 <rfw> i mostly use git though
20 2010-12-08T00:13:56 <ThomasWaldmann> do you want to make an own changeset or shall i commit it?
21 2010-12-08T00:14:06 <rfw> hm can you commit it?
22 2010-12-08T00:14:11 <ThomasWaldmann> yes
23 2010-12-08T00:14:12 <rfw> i don't have an hg repo for 1.9
24 2010-12-08T00:14:18 <rfw> only for 2.0
25 2010-12-08T00:15:01 <ThomasWaldmann> ok, so the last 1.9 submission is tested? and expires?
26 2010-12-08T00:15:30 <rfw> yes
27 2010-12-08T00:18:11 <ThomasWaldmann> what shall I use in "Thanks to ..."?
28 2010-12-08T00:18:24 <rfw> just rfw
29 2010-12-08T00:18:52 <CIA-62> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5749:5d5ec86e40a2 1.9/MoinMoin/ (config/multiconfig.py security/textcha.py): improve textcha security (thanks to rfw, GCI 2010)
30 2010-12-08T00:19:00 <rfw> :D
31 2010-12-08T00:20:05 <ThomasWaldmann> you move the stuff for moin2?
32 2010-12-08T00:20:12 <rfw> hm not yet
33 2010-12-08T00:20:15 <rfw> there's a tiny edge case
34 2010-12-08T00:20:24 <rfw> that i should clean up
35 2010-12-08T00:20:35 <rfw> it happens in exceptional circumstances but
36 2010-12-08T00:24:55 <rfw> ThomasWaldmann: submitted
37 2010-12-08T00:32:33 <ThomasWaldmann> The entered TextCha was incorrect.
38 2010-12-08T00:32:38 <ThomasWaldmann> no, but it was expired
39 2010-12-08T00:32:44 <ThomasWaldmann> didn't you change the msg?
40 2010-12-08T00:33:21 <rfw> hm
41 2010-12-08T00:33:34 <rfw> odd
42 2010-12-08T00:36:22 <ThomasWaldmann> 2010-12-08 00:32:24,902 WARNING MoinMoin.security.textcha:126 TextCha: Non-existing question 'None'. User '127.0.0.1' trying to cheat?
43 2010-12-08T00:36:39 <ThomasWaldmann> ehrm, it was an existing question and i didn't cheat
44 2010-12-08T00:36:52 <ThomasWaldmann> i just waited until it expired
45 2010-12-08T00:37:34 <ThomasWaldmann> btw, do you fill in the old answer into the new textcha?
46 2010-12-08T00:37:48 <ThomasWaldmann> that'ld only make sense if question is the same
47 2010-12-08T00:40:34 <rfw> yeah i'm fixing that right now
48 2010-12-08T00:43:53 *** m4k3r
49 2010-12-08T00:54:33 <rfw> okay
50 2010-12-08T00:54:34 <rfw> i think
51 2010-12-08T00:54:35 <rfw> i've done it
52 2010-12-08T00:55:14 <rfw> ThomasWaldmann: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129098518356
53 2010-12-08T00:59:53 <ThomasWaldmann> i suggest you test it yourself. i'll have another look tomorrow.
54 2010-12-08T01:00:07 <rfw> eh
55 2010-12-08T01:00:10 * ThomasWaldmann found it broken
56 2010-12-08T01:00:17 <rfw> is it?
57 2010-12-08T01:00:40 <ThomasWaldmann> doesn't accept valid input
58 2010-12-08T01:02:43 <rfw> ThomasWaldmann: works perfectly here
59 2010-12-08T01:03:52 <rfw> yours might be wrong
60 2010-12-08T01:05:11 <ThomasWaldmann> applied your "final" diff :)
61 2010-12-08T01:23:03 <rfw> odd
62 2010-12-08T01:24:29 <rfw> ThomasWaldmann: what is the error
63 2010-12-08T01:24:35 <rfw> because i just reapplied it here :|
64 2010-12-08T01:25:13 <rfw> you sure you don't have your expiry time to some really low value
65 2010-12-08T01:43:19 <ThomasWaldmann> i have
66 2010-12-08T01:43:25 <ThomasWaldmann> it works if i am quick enough
67 2010-12-08T01:43:52 <ThomasWaldmann> if i am not, it says invalid or expired, but then, if i fill out the form again, i don't get in, even if i am quick
68 2010-12-08T01:45:00 <rfw> well then don't make it expire really quick
69 2010-12-08T01:46:35 <ThomasWaldmann> i think i was below for 2nd try
70 2010-12-08T01:47:44 <rfw> ThomasWaldmann: shouldn't that be fine then if you set the expiry to say 10 minutes
71 2010-12-08T01:53:50 <rfw> ThomasWaldmann: i don't think that counts as much of an issue though
72 2010-12-08T01:53:56 <ThomasWaldmann> 1st try: The TextCha question was invalid or has expired. Please reload the form and try again.
73 2010-12-08T01:54:08 <ThomasWaldmann> this is ok, because i waited until it expired
74 2010-12-08T01:54:18 <rfw> ah
75 2010-12-08T01:54:27 <ThomasWaldmann> 2nd try: same msg
76 2010-12-08T01:54:40 <rfw> you have to reload the form
77 2010-12-08T01:54:45 <ThomasWaldmann> this is not ok, because i didn't wait until expiry time was over
78 2010-12-08T01:54:53 <rfw> as in
79 2010-12-08T01:54:56 <rfw> refresh the page
80 2010-12-08T01:55:04 <ThomasWaldmann> why?
81 2010-12-08T01:55:12 <ThomasWaldmann> i didn't use back button
82 2010-12-08T01:55:20 <rfw> it doesn't regenerate a question
83 2010-12-08T01:55:45 <ThomasWaldmann> that's a bug then :)
84 2010-12-08T01:55:51 <rfw> well
85 2010-12-08T01:55:54 <rfw> i did say "please reload the page"
86 2010-12-08T01:55:56 <rfw> in the message
87 2010-12-08T01:56:06 <rfw> but if you insist
88 2010-12-08T01:56:11 <ThomasWaldmann> and it doesn't need to regenerate the question, but of course set a new timeout, sign it freshly
89 2010-12-08T01:56:26 <rfw> ah no
90 2010-12-08T01:56:27 <rfw> that's bad
91 2010-12-08T01:56:34 <ThomasWaldmann> and it should select new question randomly
92 2010-12-08T01:56:34 <rfw> because then a bot could just use the same question
93 2010-12-08T01:56:39 <rfw> send it to a server
94 2010-12-08T01:56:44 <rfw> then send it again
95 2010-12-08T01:56:50 <rfw> with the signed value
96 2010-12-08T01:57:01 <rfw> so it's better to actually regenerate a question
97 2010-12-08T01:57:23 <ThomasWaldmann> yeah, but it might be the same, due to random
98 2010-12-08T01:57:29 <rfw> well
99 2010-12-08T01:57:31 <ThomasWaldmann> but it needs new timeout
100 2010-12-08T01:57:34 <rfw> that's all luck isn't it
101 2010-12-08T01:57:35 <rfw> or timing
102 2010-12-08T01:57:48 <ThomasWaldmann> you know the dilbert with the rng daemon?
103 2010-12-08T01:57:56 <rfw> no
104 2010-12-08T01:58:26 <rfw> oh i see it
105 2010-12-08T01:58:27 <rfw> heh
106 2010-12-08T01:59:05 <ThomasWaldmann> http://www.random.org/analysis/
107 2010-12-08T01:59:36 <rfw> does it matter though
108 2010-12-08T01:59:40 <rfw> if it gives it the same question
109 2010-12-08T02:00:06 <ThomasWaldmann> it can be any random question
110 2010-12-08T02:00:19 <ThomasWaldmann> and it maybe should clear answer field
111 2010-12-08T02:01:51 <rfw> ah yeah
112 2010-12-08T02:02:13 <rfw> sorry for taking so long with this
113 2010-12-08T02:02:16 <rfw> and makign so many stupid mistakes
114 2010-12-08T02:03:02 <rfw> there we go
115 2010-12-08T02:03:21 <rfw> it generates a new question and clears the field
116 2010-12-08T02:03:23 <rfw> once it expires
117 2010-12-08T02:03:47 * ThomasWaldmann will be in sleep mode soon :)
118 2010-12-08T02:03:56 <rfw> can you wait for a bit longer
119 2010-12-08T02:03:58 <rfw> i think i've got it
120 2010-12-08T02:04:51 <ThomasWaldmann> my clock shows 2:03 am btw. |-)
121 2010-12-08T02:05:17 <rfw> oh sorry
122 2010-12-08T02:05:25 <rfw> i really want to get this finished though :(
123 2010-12-08T02:05:57 <ThomasWaldmann> haha, googling for wikileaks gives its ip address on 1st place
124 2010-12-08T02:06:26 <rfw> mine just has wikileaks.org
125 2010-12-08T02:06:37 <rfw> oh not on german google
126 2010-12-08T02:06:48 <rfw> i don't really like assange though :(
127 2010-12-08T02:08:01 <rfw> ThomasWaldmann: submitted
128 2010-12-08T02:12:53 <ThomasWaldmann> ok, final try for tonight :)
129 2010-12-08T02:13:00 <rfw> :D
130 2010-12-08T02:13:18 <ThomasWaldmann> "final" is overused
131 2010-12-08T02:13:31 <rfw> maybe i should use some synonyms
132 2010-12-08T02:13:34 <rfw> like ultimate
133 2010-12-08T02:13:40 <rfw> and thisreallyisthelastpatchipromise
134 2010-12-08T02:17:10 <ThomasWaldmann> service pack 3 :)
135 2010-12-08T02:17:22 <ThomasWaldmann> ok, it works now
136 2010-12-08T02:17:30 <rfw> yay!
137 2010-12-08T02:17:42 <rfw> can you mark it as complete :D
138 2010-12-08T02:18:44 <CIA-62> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 10129:7e9b52391e52 2.0-dev/MoinMoin/ (4 files in 4 dirs): improve textcha security (thanks to rfw, GCI 2010)
139 2010-12-08T02:19:25 <rfw> yay
140 2010-12-08T02:19:30 <rfw> sorry for taking so long
141 2010-12-08T02:19:33 <rfw> and bothering you so much
142 2010-12-08T02:20:40 <ThomasWaldmann> no problem :)
143 2010-12-08T02:20:47 <rfw> thanks!
144 2010-12-08T02:20:48 <ThomasWaldmann> closed the task
145 2010-12-08T02:20:58 <rfw> got the email
146 2010-12-08T02:21:03 <rfw> have a nice sleep :)
147 2010-12-08T02:24:21 <ThomasWaldmann> Wikileaks is currently mirrored on 1005 sites - hah, nice example for the Streisand effect.
148 2010-12-08T04:29:24 *** nickr5
149 2010-12-08T05:15:46 *** kursor
150 2010-12-08T05:47:06 *** jordonwii
151 2010-12-08T05:55:16 *** GCIBot
152 2010-12-08T05:55:33 *** GCIBot
153 2010-12-08T06:01:50 *** kursor
154 2010-12-08T06:25:22 *** jordonwii
155 2010-12-08T07:43:16 *** m4k3r
156 2010-12-08T07:56:50 *** m4k3r
157 2010-12-08T09:04:12 <dreimark> moinBot:
158 2010-12-08T09:04:14 <dreimark> moin
159 2010-12-08T09:04:44 <dreimark> ThomasWaldmann: can you upload the how to do a patch screencast
160 2010-12-08T09:05:01 <dreimark> so that we can link it to http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970449#ws22001
161 2010-12-08T09:29:30 *** gwork
162 2010-12-08T09:42:15 *** m4k3r
163 2010-12-08T09:50:05 <dreimark> bbl
164 2010-12-08T10:32:37 <ThomasWaldmann> moin
165 2010-12-08T10:35:53 *** rfw
166 2010-12-08T10:58:15 <ThomasWaldmann> dreimark: http://static.moinmo.in/files/screencast/moin_patch/moin_patch.ogv / .avi
167 2010-12-08T11:02:18 <dreimark> :)
168 2010-12-08T11:08:09 *** greg_f
169 2010-12-08T11:08:29 *** m4k3r
170 2010-12-08T11:11:08 *** m4k3r
171 2010-12-08T14:15:45 <eSyr> ThomasWaldmann: cc-by-sa/by-nc-sa is usually better, gpl/gfdl is rather hard at applying to multimedia content.
172 2010-12-08T14:17:17 <xorAxAx> also gfdl is incompatible to gpl
173 2010-12-08T14:17:50 <eSyr> not using hg commands was in requirements? because avoiding it looks rather odd.
174 2010-12-08T14:18:30 <eSyr> (also, some noises can be cut or muted -_-)
175 2010-12-08T14:19:13 <ThomasWaldmann> the task is closed, so if you want the video changed, it is a bit late
176 2010-12-08T14:19:40 <ThomasWaldmann> the task was to create a video for applying and creating patches
177 2010-12-08T14:19:52 <ThomasWaldmann> there's a separate one for hg
178 2010-12-08T14:23:05 <ThomasWaldmann> eSyr: and cc nc is hardly compatible with gpl
179 2010-12-08T14:29:54 <ThomasWaldmann> btw, iirc the hg screencast task was taken recently, so what its progress early
180 2010-12-08T14:30:03 <ThomasWaldmann> watch* %)
181 2010-12-08T14:45:48 <eSyr> ok :)
182 2010-12-08T15:09:39 *** h_peter
183 2010-12-08T15:38:34 <h_peter> Thomas Waldmann, I have almost finished the mediawiki reference but there are some markups that do not work with moin2. Is this still under progress?
184 2010-12-08T15:42:58 *** m4k3r
185 2010-12-08T15:43:29 *** m4k3r
186 2010-12-08T15:43:41 <ThomasWaldmann> h_peter: yes, you have to mark those somehow
187 2010-12-08T15:53:19 *** kursor
188 2010-12-08T17:10:50 *** gwork
189 2010-12-08T17:39:35 <h_peter> I've finished the reference now. May I submit it at GCI?
190 2010-12-08T17:49:14 <ThomasWaldmann> did you try it with moin2
191 2010-12-08T17:50:09 <h_peter> i tried every markup with moin2 and marked those that worked not with "TODO"
192 2010-12-08T18:19:38 <ThomasWaldmann> ok
193 2010-12-08T18:19:45 <ThomasWaldmann> (sorry, was at the phone)
194 2010-12-08T18:20:04 <ThomasWaldmann> can you put a copy onto the test wiki for first review?
195 2010-12-08T18:20:06 <ThomasWaldmann> h_peter: ^^
196 2010-12-08T18:20:49 <h_peter> oh, sorry I already submitted it...
197 2010-12-08T18:23:55 <ThomasWaldmann> http://test.moinmo.in:8080/mwhelp
198 2010-12-08T18:24:51 <ThomasWaldmann> "Bold and italic text – not possible in ReST?" - i don't know - did you research this on your own?
199 2010-12-08T18:25:43 <h_peter> i researched and didn't found anything
200 2010-12-08T18:26:05 <ThomasWaldmann> is there a way to make the table headings prettier with rst?
201 2010-12-08T18:27:28 <ThomasWaldmann> hmm maybe this is a shortcoming of our rst -> dom -> html translation
202 2010-12-08T18:28:15 <ThomasWaldmann> hmm, could you replace mediawiki slang by moin2 slang? ;)
203 2010-12-08T18:28:16 <h_peter> table headings work for me (with sphinx) but it seems that they are displayed as normal text at moin
204 2010-12-08T18:28:31 <ThomasWaldmann> e.g. Article -> Item
205 2010-12-08T18:28:59 <ThomasWaldmann> page -> item
206 2010-12-08T18:29:13 <ThomasWaldmann> subpage -> subitem
207 2010-12-08T18:29:46 <ThomasWaldmann> if you like, you can work on the test wiki :)
208 2010-12-08T18:30:01 <ThomasWaldmann> but make backup copies, just for the case :)
209 2010-12-08T18:30:20 <h_peter> ok ;)
210 2010-12-08T18:30:36 <ThomasWaldmann> the [[media:xxx]] stuff is something that is fundamentally different in moin
211 2010-12-08T18:30:54 <ThomasWaldmann> the only sane thing we could do for that is to just ignore the media: prefix
212 2010-12-08T18:31:23 <ThomasWaldmann> but i guess we keep that on the help page for now, just as a reminder
213 2010-12-08T18:32:10 <h_peter> ok, but what about images?
214 2010-12-08T18:32:54 <ThomasWaldmann> maybe we do your page top-down
215 2010-12-08T18:33:57 <ThomasWaldmann> btw, Levels are shifted somehow
216 2010-12-08T18:34:02 <ThomasWaldmann> for headlines
217 2010-12-08T18:35:06 <ThomasWaldmann> the hr example doesn't display a hr for me
218 2010-12-08T18:36:14 <h_peter> again, it works for me with sphinx so it has to be a problem of moin
219 2010-12-08T18:36:43 <h_peter> oh, and lines starting with ".." should be comments in ReST (moin displays them)
220 2010-12-08T18:36:54 <ThomasWaldmann> then place a TODO please
221 2010-12-08T18:38:04 <ThomasWaldmann> hmm, indention vs. indentation? I am somehow more familiar with the second one. But I am no native speaker, so take this with a grain of salt.
222 2010-12-08T18:38:40 <ThomasWaldmann> spaceis -> space is
223 2010-12-08T18:38:55 <ThomasWaldmann> possibleto -> possible to
224 2010-12-08T18:39:02 *** kursor
225 2010-12-08T18:39:58 <h_peter> yeah, that thing startswith and possibleto should be preformatted
226 2010-12-08T18:39:59 <ThomasWaldmann> underline and strikethrough – not possible in ReST? <- sounds strange, would've expected that is possible. But I am rarely using rst, so do own research.
227 2010-12-08T18:40:46 <ThomasWaldmann> oh, ok, so this is a TODO also
228 2010-12-08T18:41:28 <h_peter> should I place these TODOs in this item?
229 2010-12-08T18:41:40 <ThomasWaldmann> ehrm, we maybe should differentiate between MWTODO and RSTTODO :)
230 2010-12-08T18:41:48 <ThomasWaldmann> depending on where it is broken
231 2010-12-08T18:42:53 <ThomasWaldmann> mw uses style xhtml attr?
232 2010-12-08T18:42:59 <ThomasWaldmann> sounds like xss fun :D
233 2010-12-08T18:43:17 <h_peter> but e.g. this preformatted thing and table headers too don't work on ReST and mw
234 2010-12-08T18:43:52 <ThomasWaldmann> write that on your page, so the one who tries to fix that stuff later has it easier
235 2010-12-08T18:44:38 <ThomasWaldmann> now about the image stuff
236 2010-12-08T18:44:57 <ThomasWaldmann> [[File: always means this is an image?
237 2010-12-08T18:45:41 <h_peter> no, it could also be a pdf or similar
238 2010-12-08T18:46:07 <ThomasWaldmann> but it always means "embed"?
239 2010-12-08T18:46:19 <ThomasWaldmann> or how does it decide what to do exactly?
240 2010-12-08T18:46:32 <ThomasWaldmann> file extensions ftw? :D
241 2010-12-08T18:46:55 <ThomasWaldmann> that reminds me of moin < 1.6 :)
242 2010-12-08T18:47:44 <ThomasWaldmann> ok, i need to go soon, but i guess you have some todo now :)
243 2010-12-08T18:48:04 <h_peter> ok, it always means embed
244 2010-12-08T18:48:17 <h_peter> if you use a pdf, you have to define the page-number
245 2010-12-08T18:48:54 <ThomasWaldmann> interesting.
246 2010-12-08T18:49:33 <ThomasWaldmann> for moin markup, we fundamentally have different markup for linking [[...]] and embedding/transclusion {{...}}
247 2010-12-08T18:50:04 <ThomasWaldmann> and as everything in the wiki is a mimetyped item, there is no File: or Media: or something
248 2010-12-08T18:50:47 <h_peter> mw works with namespaces: File: is a namespace for an embeddable object
249 2010-12-08T18:51:05 <ThomasWaldmann> btw, if you could easily submit a html file also (rendered by sphinx, that would make review a bit quicker/easier)
250 2010-12-08T18:52:35 <ThomasWaldmann> maybe think about order of the stuff also
251 2010-12-08T18:52:57 <ThomasWaldmann> e.g. images are also pretty basic
252 2010-12-08T18:53:47 <ThomasWaldmann> although the many options offered make it more complex
253 2010-12-08T18:58:39 <h_peter> ok, i will put images above tables, but all points above it are simple, text-based things
254 2010-12-08T18:59:29 <ThomasWaldmann> i was thinking about whether block level vs. inline level makes sense, not sure
255 2010-12-08T18:59:42 <ThomasWaldmann> anyway, gtg. thanks for far for your work.
256 2010-12-08T18:59:46 * ThomasWaldmann bbl
257 2010-12-08T19:08:44 *** h_peter
258 2010-12-08T19:26:01 *** greg_f
259 2010-12-08T19:40:54 <jbills> I have used one copy of moinmoin 2.0 in three tasks. If I use the method in http://static.moinmo.in/files/screencast/moin_patch/moin_patch.avi this video I will get extra changes I will not know ho to remove.
260 2010-12-08T19:44:18 *** jbills_
261 2010-12-08T19:44:32 <jbills> this is a test
262 2010-12-08T19:44:37 <TheSheep> failed
263 2010-12-08T19:46:03 <jbills> dreimark: I have used one copy of moinmoin 2.0 in three tasks. If I use the method in http://static.moinmo.in/files/screencast/moin_patch/moin_patch.avi this video I will get extra changes I will not know ho to remove.
264 2010-12-08T19:46:14 *** jbills_
265 2010-12-08T20:37:26 *** rfw
266 2010-12-08T20:37:26 *** rfw
267 2010-12-08T20:48:49 *** h_peter
268 2010-12-08T21:46:42 <jbills> Anyone here?
269 2010-12-08T21:47:00 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 (more secure password storage)
270 2010-12-08T21:47:52 <xorAxAx> jbills: yes
271 2010-12-08T21:48:13 <jbills> dreimark: I have used one copy of moinmoin 2.0 in three tasks. If I use the method in http://static.moinmo.in/files/screencast/moin_patch/moin_patch.avi this video I will get extra changes I will not know ho to remove.
272 2010-12-08T21:48:46 <xorAxAx> jbills: what did you apply?
273 2010-12-08T21:49:00 <jbills> css
274 2010-12-08T21:49:15 <xorAxAx> which patch?
275 2010-12-08T21:49:37 <jbills> I am trying to make a patch
276 2010-12-08T21:49:44 <jbills> not apply one.
277 2010-12-08T21:51:22 <xorAxAx> ah
278 2010-12-08T21:51:36 <xorAxAx> what does the video tell?
279 2010-12-08T21:52:13 <jbills> to use diff on the whole directory
280 2010-12-08T21:52:50 <xorAxAx> then dont use it on the whole directory :)
281 2010-12-08T21:57:58 <jbills> I have more than one files
282 2010-12-08T22:00:15 <xorAxAx> then put them all on the command line
283 2010-12-08T22:00:36 <jbills> here is what one of the files looks like
284 2010-12-08T22:01:00 <xorAxAx> transfer failed
285 2010-12-08T22:01:05 <xorAxAx> please use paste.pocoo.org
286 2010-12-08T22:01:13 <jbills> k
287 2010-12-08T22:01:43 <jbills> http://paste.pocoo.org/show/302447/
288 2010-12-08T22:02:06 <xorAxAx> doesnt the video say that you need at least diff -u?
289 2010-12-08T22:02:26 *** grzywacz
290 2010-12-08T22:18:07 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 (more secure password storage)
291 2010-12-08T22:26:43 <jbills> ok
292 2010-12-08T22:34:02 <jbills> xorAxAx:ok
293 2010-12-08T22:48:40 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 (more secure password storage)
294 2010-12-08T23:09:04 <jbills> xorAxAx: Are you there?
295 2010-12-08T23:09:12 <xorAxAx> jbills: yes
296 2010-12-08T23:10:39 <jbills> xorAxAx: http://paste.pocoo.org/show/302495/ Is this how a pach should look?
297 2010-12-08T23:10:56 <xorAxAx> technically, yes
298 2010-12-08T23:11:15 <jbills> thanks
299 2010-12-08T23:11:36 <jbills> and not so technically?
300 2010-12-08T23:12:46 <xorAxAx> well, it looks like this is a patch against a revision created by you
301 2010-12-08T23:12:59 <xorAxAx> because it deletes many commented out lines which are likely not in the original
302 2010-12-08T23:18:43 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 (more secure password storage)
303 2010-12-08T23:32:13 <dreimark> re
304 2010-12-08T23:35:05 <jbills> Oh yeah those where test lines
305 2010-12-08T23:36:53 <dreimark> ThomasWaldmann: we have a t-shirt "python: programming the way guido indented it"
306 2010-12-08T23:49:46 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037966331 (more secure password storage)
307 2010-12-08T23:50:29 *** h_peter
308
