1 2010-12-03T00:00:04 <jrabbit> ThomasWaldmann: hm
2 2010-12-03T00:00:05 <jrabbit> ok
3 2010-12-03T00:00:15 <jrabbit> print('Moin does not support Python 3 at this time.')
4 2010-12-03T00:01:18 <jrabbit> ThomasWaldmann: to resubmitt you need to select "needs review"
5 2010-12-03T00:01:19 <ThomasWaldmann> usually we use logging.warning(...)
6 2010-12-03T00:01:30 <m4k3r> *.error
7 2010-12-03T00:01:31 <jrabbit> ThomasWaldmann: will that work under py3?
8 2010-12-03T00:01:37 <m4k3r> jrabbit: yep.
9 2010-12-03T00:01:37 <ThomasWaldmann> no idea :)
10 2010-12-03T00:02:01 <jrabbit> m4k3r: MoinMoin.log ?
11 2010-12-03T00:02:21 <m4k3r> jrabbit: MoinMoin.log uses stdlib logging.
12 2010-12-03T00:02:41 <m4k3r> Which AFAIK didn't change in py3.
13 2010-12-03T00:02:51 <jrabbit> SyntaxError: invalid syntax
14 2010-12-03T00:02:52 <jrabbit> nope.
15 2010-12-03T00:03:19 <jrabbit> m4k3r: in your defence it was an exception comma thing
16 2010-12-03T00:03:36 <jrabbit> print() it is :)
17 2010-12-03T00:03:48 <m4k3r> jrabbit: yeah, may you have to fix some stupid syntaxErrors.
18 2010-12-03T00:04:06 <m4k3r> 2to3 may be useful.
19 2010-12-03T00:04:31 <moin2> i need review
20 2010-12-03T00:04:54 <jrabbit> m4k3r: I'm not making it 3k compat, just sane failure
21 2010-12-03T00:04:58 <jrabbit> or warning
22 2010-12-03T00:05:55 <m4k3r> ThomasWaldmann: just found how to switch between different types of login \o/
23 2010-12-03T00:07:27 <jrabbit> ThomasWaldmann: how about this https://gist.github.com/726286
24 2010-12-03T00:10:52 <dreimark> moin2: the diff looks strange. for me it has only 65 line after download
25 2010-12-03T00:11:20 <moin2> i don't understand
26 2010-12-03T00:11:32 <moin2> i did the same thing i did for the previous changesets
27 2010-12-03T00:12:47 <ThomasWaldmann> jrabbit: i think in the py3 case, it is really about exiting
28 2010-12-03T00:13:01 <jrabbit> want it to sys.exit isntead>
29 2010-12-03T00:13:03 <jrabbit> thats not hard
30 2010-12-03T00:13:07 <ThomasWaldmann> and you don't need to talk about py3 then in that warning, because you won't get there
31 2010-12-03T00:13:24 <jrabbit> hm?
32 2010-12-03T00:13:31 <jrabbit> oh I see.
33 2010-12-03T00:13:33 <m4k3r> Gn
34 2010-12-03T00:13:36 <m4k3r> o/
35 2010-12-03T00:13:46 *** m4k3r
36 2010-12-03T00:13:53 <ThomasWaldmann> yes, sys.exit(). py3 is really not worth trying, it can't work.
37 2010-12-03T00:14:13 <jrabbit> kk
38 2010-12-03T00:14:23 <moin2> dreimark what is it doing now?
39 2010-12-03T00:14:43 <jrabbit> https://gist.github.com/726286 updated
40 2010-12-03T00:15:22 <dreimark> do you have windows line breaks?
41 2010-12-03T00:16:12 <moin2> don't know
42 2010-12-03T00:16:51 <moin2> what would that look like?
43 2010-12-03T00:17:14 <jrabbit> ThomasWaldmann: https://gist.github.com/726286 updated
44 2010-12-03T00:19:16 <ThomasWaldmann> ok, looks good
45 2010-12-03T00:19:32 <dreimark> moin2: http://paste.pocoo.org/show/299274/
46 2010-12-03T00:19:46 <dreimark> the ^M is a windows line break
47 2010-12-03T00:20:19 <ThomasWaldmann> jrabbit: but it doesn't work because of:
48 2010-12-03T00:20:21 <ThomasWaldmann> File "/home/tw/w/mm20dev/MoinMoin/support/flaskext/themes.py", line 21, in <module>
49 2010-12-03T00:20:25 <ThomasWaldmann> from flask import (Module, send_from_directory, render_template, json,
50 2010-12-03T00:20:27 <ThomasWaldmann> ImportError: cannot import name 'json'
51 2010-12-03T00:20:43 <jrabbit> oh theres more json?
52 2010-12-03T00:20:50 <jrabbit> I didn't run into it during testing...
53 2010-12-03T00:20:56 <jrabbit> odd
54 2010-12-03T00:21:15 <ThomasWaldmann> i just used "pypy moin" :)
55 2010-12-03T00:21:23 <jrabbit> oh
56 2010-12-03T00:21:29 <jrabbit> I was using pytest still
57 2010-12-03T00:21:44 <jrabbit> MoinMoin/static/applets/svg-edit/extras/update-langs.py:import json
58 2010-12-03T00:21:52 <moin2> is that showing up in what i submitted, it's not in mine
59 2010-12-03T00:21:53 <jrabbit> ^ is that needed too?
60 2010-12-03T00:22:45 <moin2> is it possible that results can get skewed by the way i made it. i used the manual way through check final status in the one i submitted. but i get a slightly different result for hg diff in command line
61 2010-12-03T00:22:54 <ThomasWaldmann> jrabbit: not sure, maybe not
62 2010-12-03T00:23:16 <jrabbit> I'll do it just in case it won't cause any problems
63 2010-12-03T00:23:24 <jrabbit> warn on those as well?
64 2010-12-03T00:24:08 <jrabbit> MoinMoin/support/flask/__init__.py: from .helpers import json
65 2010-12-03T00:24:08 <ThomasWaldmann> the problem is a bit that flaskext/themes.py is 3rd party code, same for svg-edit
66 2010-12-03T00:24:27 <jrabbit> ThomasWaldmann: well it can be merged?
67 2010-12-03T00:24:37 <ThomasWaldmann> yeah, i already mentioned helpers
68 2010-12-03T00:24:45 <jrabbit> what is it though
69 2010-12-03T00:24:53 <ThomasWaldmann> depends on whether author wants to support < 2.6
70 2010-12-03T00:25:49 <jrabbit> oh
71 2010-12-03T00:25:53 <jrabbit> helpers trys to import json
72 2010-12-03T00:28:35 <jrabbit> it does what I'm doing
73 2010-12-03T00:29:41 <jrabbit> odd
74 2010-12-03T00:30:57 <jrabbit> crap
75 2010-12-03T00:31:04 <jrabbit> 2.7 implements sys.version_info.major
76 2010-12-03T00:31:08 <jrabbit> but 2.5 and 2.6 don't
77 2010-12-03T00:31:47 <jrabbit> ThomasWaldmann: will "if sys.version_info.major and sys.version_info.major == 3" work like it sounds?
78 2010-12-03T00:32:32 <ThomasWaldmann> if it is not there, it won't
79 2010-12-03T00:33:37 <ThomasWaldmann> >>>> sys.version_info
80 2010-12-03T00:33:38 <ThomasWaldmann> (2, 5, 2, 'beta', 42)
81 2010-12-03T00:33:55 <ThomasWaldmann> that's pypy 1.4 btw
82 2010-12-03T00:37:40 <dreimark> moin2: dos2unix changeset.txt helps me, so you have windows CRLF
83 2010-12-03T00:38:17 <moin2> i found a problem, i need to resubmit
84 2010-12-03T00:40:42 <jrabbit> ThomasWaldmann: do I need to nest the ifs?
85 2010-12-03T00:41:02 <moin2> do i need to change the format
86 2010-12-03T00:41:36 <ThomasWaldmann> jrabbit: you can do a 2-tuple comparison
87 2010-12-03T00:41:38 <dreimark> 439 has a whitespace in the new line test_sourcecode tells that
88 2010-12-03T00:41:39 *** moin2
89 2010-12-03T00:41:52 <jrabbit> ThomasWaldmann: its not a tuple in 3.1 though
90 2010-12-03T00:41:58 <jrabbit> nor 2.7
91 2010-12-03T00:42:16 <ThomasWaldmann> sys.version_info?
92 2010-12-03T00:42:22 <jrabbit> yeah
93 2010-12-03T00:42:25 <ThomasWaldmann> hmpf
94 2010-12-03T00:42:58 *** moin2
95 2010-12-03T00:42:59 <jrabbit> sys.version_info(major=3, minor=1, micro=3, releaselevel='final', serial=0)
96 2010-12-03T00:43:12 <moin2> i'm back sorry, do i need to change the format?
97 2010-12-03T00:43:23 <dreimark> yes
98 2010-12-03T00:43:33 <moin2> to what?
99 2010-12-03T00:43:58 <dreimark> to linux/unix line ending. looks also for pep8 whitespace problems
100 2010-12-03T00:45:11 <moin2> how can i do that on win7?
101 2010-12-03T00:45:12 <dreimark> at a first glance it dit not look optimized, bevause of del.
102 2010-12-03T00:45:30 <dreimark> moin2: the editor has ussually a switch for that
103 2010-12-03T00:45:56 <ThomasWaldmann> >>>> hex(sys.hexversion)
104 2010-12-03T00:45:57 <ThomasWaldmann> '0x20502b0'
105 2010-12-03T00:46:56 <moin2> on notepad how?
106 2010-12-03T00:47:09 <jrabbit> ThomasWaldmann: I sovled it another way
107 2010-12-03T00:47:14 <jrabbit> it works
108 2010-12-03T00:47:22 <moin2> ah i see
109 2010-12-03T00:47:25 <moin2> !!
110 2010-12-03T00:47:38 <jrabbit> jsut check to see if it uses the new format then if its 3
111 2010-12-03T00:48:15 <ThomasWaldmann> show code :)
112 2010-12-03T00:49:01 <jrabbit> https://gist.github.com/726286
113 2010-12-03T00:49:15 <moin2> unix ending right
114 2010-12-03T00:50:09 <moin2> ?
115 2010-12-03T00:50:36 <dreimark> http://cs.calvin.edu/curriculum/cs/112/resources/eol/
116 2010-12-03T00:50:39 <dreimark> yes
117 2010-12-03T00:50:52 <ThomasWaldmann> hahaha, thinkgeek's canned unicorn meat held at the german customs
118 2010-12-03T00:51:27 <ThomasWaldmann> http://www.thinkgeek.com/blog/2010/12/our-magical-unicorn-customs-ad.html
119 2010-12-03T00:51:29 <moin2> ok, submitted
120 2010-12-03T00:51:31 <jrabbit> ThomasWaldmann: https://gist.github.com/726286
121 2010-12-03T00:54:50 <ThomasWaldmann> AttributeError: 'tuple' object has no attribute 'major'
122 2010-12-03T00:54:54 <ThomasWaldmann> on 2.5
123 2010-12-03T00:55:19 <jrabbit> huh
124 2010-12-03T00:55:38 <jrabbit> how the heck did it pass if sys.version_info.major
125 2010-12-03T00:55:42 <ThomasWaldmann> and 2.6
126 2010-12-03T00:55:44 <jrabbit> if it doesn't exist???
127 2010-12-03T00:55:56 <ThomasWaldmann> that is this check
128 2010-12-03T00:56:32 <ThomasWaldmann> sometimes simple things are hard
129 2010-12-03T00:56:38 <jrabbit> oh
130 2010-12-03T00:56:41 <ThomasWaldmann> this is rather unpythonic :|
131 2010-12-03T00:56:55 <jrabbit> maybe I should check if major is in sys.version_info
132 2010-12-03T00:57:05 <jrabbit> ThomasWaldmann: not supporting python versions is unpythonic :)
133 2010-12-03T00:58:02 <ThomasWaldmann> i mean that one can't check version in same way easily, not even for 2.x
134 2010-12-03T00:58:08 <jrabbit> aha got it
135 2010-12-03T00:58:10 <ThomasWaldmann> maybe try the hex stuff
136 2010-12-03T00:58:14 <jrabbit> if 'major' in sys.version_info
137 2010-12-03T01:00:03 <jrabbit> https://gist.github.com/726286
138 2010-12-03T01:00:04 <jrabbit> there
139 2010-12-03T01:00:12 <jrabbit> waht was I doing now?
140 2010-12-03T01:00:22 <jrabbit> ThomasWaldmann: did I need to fix a flask bit?
141 2010-12-03T01:02:56 <moin2> dreimark is it merging now?
142 2010-12-03T01:03:07 <dreimark> moin2: merging works, did you tried your code ?
143 2010-12-03T01:03:48 <moin2> yes
144 2010-12-03T01:04:50 <ThomasWaldmann> jrabbit: merge line 8 and 10
145 2010-12-03T01:04:51 <dreimark> does a link on the right point to an existing item for you?
146 2010-12-03T01:04:56 <dreimark> moin2: ^
147 2010-12-03T01:05:10 <jrabbit> ThomasWaldmann: you sure I can?
148 2010-12-03T01:05:23 <moin2> yes it does
149 2010-12-03T01:05:37 <ThomasWaldmann> yes
150 2010-12-03T01:06:13 <jrabbit> kk
151 2010-12-03T01:06:22 <dreimark> moin2: for me not. I get e.g. 1. SiblingItem : moin , creole. If I click on creole it tries to create the item SiblingItem http://localhost:8080/SiblingItem
152 2010-12-03T01:06:23 <jrabbit> updated
153 2010-12-03T01:06:33 <dreimark> moin2: and it did not go to wiki
154 2010-12-03T01:06:44 <dreimark> s/wiki/moin/
155 2010-12-03T01:07:01 <ThomasWaldmann> and do the 2.6 check + warning after logging is available
156 2010-12-03T01:07:03 <moin2> can you do a pastebin of my changeset
157 2010-12-03T01:07:21 <ThomasWaldmann> from MoinMoin import log
158 2010-12-03T01:07:21 <ThomasWaldmann> logging = log.getLogger(__name__)
159 2010-12-03T01:07:26 <ThomasWaldmann> below that
160 2010-12-03T01:07:40 <ThomasWaldmann> logging.warning("...")
161 2010-12-03T01:07:48 <moin2> i actually just now fixed that and might not have submitted the right thing
162 2010-12-03T01:08:35 <moin2> i need to see it though, so can you pastebin it
163 2010-12-03T01:08:52 <jrabbit> ThomasWaldmann: I thoguh you wanted 3k failure quick.
164 2010-12-03T01:08:53 <jrabbit> :P
165 2010-12-03T01:09:02 <jrabbit> ThomasWaldmann: logging doesmn't improt udner 3k anyway
166 2010-12-03T01:09:05 <dreimark> moin2: http://localhost:8080/+wanteds
167 2010-12-03T01:09:14 <dreimark> you should have it on your wiki too
168 2010-12-03T01:09:15 <jrabbit> ThomasWaldmann: try it yourself
169 2010-12-03T01:09:51 <moin2> when you click "creole", what does it do>
170 2010-12-03T01:09:57 <ThomasWaldmann> jrabbit: you exit if it is py3
171 2010-12-03T01:10:08 <moin2> can you pastebin the changeset please?
172 2010-12-03T01:10:17 <ThomasWaldmann> if it is 2.x, you emit a warning after logging is there
173 2010-12-03T01:10:23 <jrabbit> Ah.
174 2010-12-03T01:10:24 <dreimark> moin2: it wants to open SiblingItem
175 2010-12-03T01:10:29 <dreimark> moin2: which changeset?
176 2010-12-03T01:10:37 <jrabbit> ThomasWaldmann: so in the 2.6 you want it to be logged?
177 2010-12-03T01:10:37 <moin2> the one i submitted
178 2010-12-03T01:11:16 <dreimark> moin2: do you have deleted it - don't you have access to submitted cs ?
179 2010-12-03T01:11:38 <jrabbit> logging.warn ?
180 2010-12-03T01:11:46 <ThomasWaldmann> jrabbit: .warning
181 2010-12-03T01:11:58 <ThomasWaldmann> iirc
182 2010-12-03T01:12:13 <jrabbit> logging.warning("MoinMoin requires Python 2.6 or greater.")
183 2010-12-03T01:12:21 <moin2> did you select my most recent submition?
184 2010-12-03T01:12:25 <ThomasWaldmann> yes
185 2010-12-03T01:12:42 <dreimark> moin2: i look
186 2010-12-03T01:15:05 <moin2> did you?
187 2010-12-03T01:16:42 <dreimark> moin2: obviously not, the new one has not that pro
188 2010-12-03T01:16:44 <dreimark> blem
189 2010-12-03T01:16:59 <moin2> it works?
190 2010-12-03T01:17:13 <dreimark> I look currently
191 2010-12-03T01:17:17 <moin2> ok
192 2010-12-03T01:19:52 <dreimark> the focstring should be formatted similar to the others in that file
193 2010-12-03T01:19:58 <dreimark> s/f/d/
194 2010-12-03T01:20:39 * ThomasWaldmann will go to sleep mode soon
195 2010-12-03T01:20:50 <dreimark> gn ThomasWaldmann
196 2010-12-03T01:22:28 <moin2> what do those things mean?
197 2010-12-03T01:22:44 <dreimark> moin2: what?
198 2010-12-03T01:22:53 <dreimark> gn ? good night
199 2010-12-03T01:23:21 <moin2> no focstring and s/f/d
200 2010-12-03T01:23:29 <dreimark> i did a typo
201 2010-12-03T01:23:35 <dreimark> s is a shortcut for sed
202 2010-12-03T01:23:40 <moin2> so what do i need to fix
203 2010-12-03T01:23:43 <dreimark> it replaces f by d
204 2010-12-03T01:24:02 <dreimark> look how the others are written look at pep8 whitespace
205 2010-12-03T01:24:10 <dreimark> run test_sourceode
206 2010-12-03T01:24:20 <dreimark> by pytest
207 2010-12-03T01:25:14 <moin2> anything else besides pep8
208 2010-12-03T01:26:04 <jrabbit> ThomasWaldmann: can someone else accept it if you're asleep?
209 2010-12-03T01:26:32 <dreimark> i am a bit tired too, have to wake up in 4-5 h too. currently i a not happy with all dels
210 2010-12-03T01:27:27 <ThomasWaldmann> i am still here until you hear me snoring :D
211 2010-12-03T01:29:18 <dreimark> moin2: output sorted
212 2010-12-03T01:29:33 <moin2> alphabetically?
213 2010-12-03T01:29:39 <dreimark> yes
214 2010-12-03T01:32:19 <moin2> anything else other than sort and pep8?
215 2010-12-03T01:32:41 <dreimark> moin2: please validate the html you use
216 2010-12-03T01:32:49 <moin2> meaning?
217 2010-12-03T01:32:56 <dreimark> http://html5.validator.nu/
218 2010-12-03T01:33:25 <moin2> was the pep8 just in the function description?
219 2010-12-03T01:33:30 <dreimark> feed it by the html page source
220 2010-12-03T01:33:49 <dreimark> pytest MoinMoin/_test/test_sourcecode
221 2010-12-03T01:33:57 <dreimark> there were 4
222 2010-12-03T01:34:45 <dreimark> gn
223 2010-12-03T01:43:57 <moin2> sorting workings
224 2010-12-03T02:03:44 *** moin2
225 2010-12-03T03:07:09 <jrabbit> ThomasWaldmann: still around I think I'm going to try and finish this
226 2010-12-03T03:11:48 <jrabbit> ok
227 2010-12-03T03:11:53 <jrabbit> ThomasWaldmann: it works with 2.5
228 2010-12-03T03:12:02 <jrabbit> its not perfect but its fairly robust
229 2010-12-03T03:12:08 <jrabbit> a page loads at least
230 2010-12-03T03:12:41 *** dennda
231 2010-12-03T03:12:50 *** dennda
232 2010-12-03T03:13:12 *** dennda
233 2010-12-03T03:19:29 <jrabbit> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037965167 someone want to accept that?
234 2010-12-03T03:47:37 *** nickr5
235 2010-12-03T04:32:04 *** xjjk
236 2010-12-03T05:14:43 *** kursor
237 2010-12-03T06:47:13 *** xjjk
238 2010-12-03T06:53:59 <ThomasWaldmann> jrabbit: commented
239 2010-12-03T06:54:33 <jrabbit> ThomasWaldmann: you checked the gist one not the fiel right?
240 2010-12-03T06:54:42 <jrabbit> melange doesn't make that clear.
241 2010-12-03T06:54:46 <ThomasWaldmann> both
242 2010-12-03T06:54:57 <jrabbit> I can't remove the patch that was plaoded.
243 2010-12-03T06:55:00 <jrabbit> so its old
244 2010-12-03T06:55:04 <jrabbit> use the one from gist.
245 2010-12-03T06:55:24 <jrabbit> you looked at the old file.
246 2010-12-03T06:55:29 <ThomasWaldmann> my comment still applies
247 2010-12-03T06:55:45 <jrabbit> and flasktheme uses flask's json I believe
248 2010-12-03T06:55:51 <jrabbit> is it not used in running moin?
249 2010-12-03T06:56:56 <ThomasWaldmann> did you run moin?
250 2010-12-03T06:56:59 <jrabbit> moni runs on my patchset with 2.5
251 2010-12-03T06:57:00 <jrabbit> yes
252 2010-12-03T06:57:18 <ThomasWaldmann> logging.warning?
253 2010-12-03T06:58:09 <jrabbit> oh my bad I don't know if I updated the git repo
254 2010-12-03T06:58:27 <jrabbit> 1 files changed, 3 insertions(+), 3 deletions(-)
255 2010-12-03T06:59:04 <jrabbit> gah didn't save
256 2010-12-03T06:59:19 <jrabbit> too many damn windows
257 2010-12-03T06:59:46 <jrabbit> https://gist.github.com/726286
258 2010-12-03T07:01:28 <ThomasWaldmann> patch or hg changeset?
259 2010-12-03T07:02:48 <ThomasWaldmann> ah, found the raw link
260 2010-12-03T07:03:19 <jrabbit> :)
261 2010-12-03T07:03:38 <jrabbit> eventually I'll figure out how to do a proper hg pull
262 2010-12-03T07:03:50 <jrabbit> *request
263 2010-12-03T07:05:37 <ThomasWaldmann> remove the py3 check, doesn't work
264 2010-12-03T07:06:32 <jrabbit> you told me to do that exactl anguage
265 2010-12-03T07:06:36 <jrabbit> what do you mean it doesn't work
266 2010-12-03T07:06:45 <jrabbit> it succeeds on 3.x
267 2010-12-03T07:06:50 <jrabbit> fails on 2.7 in part 2
268 2010-12-03T07:06:59 <jrabbit> and fails in 2.5,6 in part one
269 2010-12-03T07:09:04 <jrabbit> This is turning into quite a bit of a patch for "easy" :P
270 2010-12-03T07:09:07 <ThomasWaldmann> it fails on 3.1 with SyntaxError
271 2010-12-03T07:09:21 <ThomasWaldmann> because it is failing to parse that file
272 2010-12-03T07:09:28 <ThomasWaldmann> therefore: remove that check
273 2010-12-03T07:09:55 <ThomasWaldmann> yes, the python version check got a bit more than expected
274 2010-12-03T07:10:17 <ThomasWaldmann> but easy doesn't mean quick btw :D
275 2010-12-03T07:10:41 <jrabbit> the check works the code just fails because 3.1 doesn't follow top to bottom syntactically :(
276 2010-12-03T07:10:53 <jrabbit> does 2.6 do... yeah it does doesn't it
277 2010-12-03T07:10:56 <jrabbit> bah thats stupid
278 2010-12-03T07:11:07 <ThomasWaldmann> and flask theme works if simplejson is installed, so ignore that
279 2010-12-03T07:11:11 <jrabbit> ThomasWaldmann: technically
280 2010-12-03T07:11:25 <jrabbit> ThomasWaldmann: we could move it into ./moin
281 2010-12-03T07:11:31 <ThomasWaldmann> it just doesnt give a good error msg if it is not, but that's not your problem
282 2010-12-03T07:11:41 <jrabbit> its failing at from MoinMoin import create_app
283 2010-12-03T07:12:25 <ThomasWaldmann> well, that won't be executed for wsgi
284 2010-12-03T07:12:30 <jrabbit> oh
285 2010-12-03T07:12:32 <jrabbit> hm
286 2010-12-03T07:12:34 <ThomasWaldmann> so i guess we just remove it
287 2010-12-03T07:12:39 <jrabbit> kk
288 2010-12-03T07:13:02 <ThomasWaldmann> py3 is not supported at all, so who try that failed to read the requirements anyway
289 2010-12-03T07:13:30 <ThomasWaldmann> *
290 2010-12-03T07:13:32 <ThomasWaldmann> TypeError: unbound method openssl_sha1() must be called with Session instance as first argument (got nothing instead)
291 2010-12-03T07:13:50 <ThomasWaldmann> that's what pypy gives now (not part of your task)
292 2010-12-03T07:14:29 <ThomasWaldmann> btw, submit a patch to melange, not github url
293 2010-12-03T07:14:47 <jrabbit> it doesn't matter if melange has it
294 2010-12-03T07:14:57 <jrabbit> I submitted via trac on other tasks
295 2010-12-03T07:16:51 <ThomasWaldmann> you can remove the github repo?
296 2010-12-03T07:16:59 <jrabbit> ?
297 2010-12-03T07:17:00 <jrabbit> why
298 2010-12-03T07:17:06 <ThomasWaldmann> can you?
299 2010-12-03T07:17:27 <ThomasWaldmann> could you?
300 2010-12-03T07:17:27 <jrabbit> i can in theory
301 2010-12-03T07:17:34 <jrabbit> I don't know why I woudl though.
302 2010-12-03T07:17:45 <ThomasWaldmann> ok, so your submission would be gone
303 2010-12-03T07:18:06 <jrabbit> gist != github
304 2010-12-03T07:18:09 <ThomasWaldmann> btw, you didn't want to use the hexversion check?
305 2010-12-03T07:18:24 <jrabbit> gist is a tiny little git repo for pastes
306 2010-12-03T07:18:40 <jrabbit> I have hundreds :P
307 2010-12-03T07:18:43 <ThomasWaldmann> because currently it detects version by failing json import
308 2010-12-03T07:19:05 <jrabbit> ThomasWaldmann: well the hexversion looked liek a pain to parse
309 2010-12-03T07:19:06 <ThomasWaldmann> which is usually ok, but in case there is something else wrong with json, it could give misleading output
310 2010-12-03T07:19:19 <jrabbit> the sys info bit is ok but its not consistent
311 2010-12-03T07:19:24 <ThomasWaldmann> you don't need to parse, just compare numbers
312 2010-12-03T07:19:33 <jrabbit> if sysinfo were consitent it'd be pythonic
313 2010-12-03T07:20:54 <ThomasWaldmann> >>>> sys.hexversion < 0x2060000
314 2010-12-03T07:20:54 <ThomasWaldmann> True
315 2010-12-03T07:21:03 <ThomasWaldmann> for pypy (2.5.2)
316 2010-12-03T07:21:12 <jrabbit> hah
317 2010-12-03T07:21:23 <jrabbit> craziness
318 2010-12-03T07:22:05 <ThomasWaldmann> works for 3.1 also
319 2010-12-03T07:22:26 *** kursor
320 2010-12-03T07:22:41 <ThomasWaldmann> yeah, agreed, crazy, but seems to be the most compatible way
321 2010-12-03T07:23:08 <ThomasWaldmann> and if you do that before trying json stuff ...
322 2010-12-03T07:23:53 <ThomasWaldmann> btw, we don't accept pastebin or dropbox submissions
323 2010-12-03T07:24:17 <ThomasWaldmann> it's ok for discussion, but you didn't really submit to melange then
324 2010-12-03T07:25:39 <ThomasWaldmann> http://www.nerdcore.de/wp/wp-content/uploads/2010/12/FVOBHBTGDTLDZHD.MEDIUM.jpg haha
325 2010-12-03T07:25:41 <jrabbit> its a full repo of my stuff.
326 2010-12-03T07:32:27 <jrabbit> ThomasWaldmann: they don't ask for the patch.
327 2010-12-03T07:32:32 <jrabbit> its provided for convience.
328 2010-12-03T08:32:45 <dreimark> Once you finish a Task you have claimed, you submit an Entry by uploading your original work product as an attachment and/or link to the Task.
329 2010-12-03T08:32:56 <dreimark> in your case it is an attachment
330 2010-12-03T08:33:03 <dreimark> if one works on the wiki it is a link
331 2010-12-03T08:33:07 <dreimark> moin
332 2010-12-03T08:35:47 <dreimark> 6.c
333 2010-12-03T08:40:45 <dreimark> bbl
334 2010-12-03T10:09:21 <dreimark> re
335 2010-12-03T10:32:03 *** rfw
336 2010-12-03T12:52:12 *** achshar
337 2010-12-03T12:52:22 <achshar> hello
338 2010-12-03T12:52:37 <achshar> i have completed mytask.. thanks alot everybody :D
339 2010-12-03T12:53:04 <achshar> now i am intrested in another task of moin project only
340 2010-12-03T12:53:13 <achshar> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964841
341 2010-12-03T12:53:33 <achshar> but needed a litle more clerification on the task..
342 2010-12-03T12:54:24 <achshar> Currently we can't define text colour (for a word or sentence) using markup
343 2010-12-03T12:54:34 <achshar> can anyone please elaborate on that
344 2010-12-03T12:56:30 <TheSheep> achshar: sometimes you want some part of your wiki page to have different text color
345 2010-12-03T12:56:38 <TheSheep> achshar: some wikis let you do that
346 2010-12-03T12:57:13 <achshar> so you mean something bigger than just a span.. maybe a div
347 2010-12-03T12:57:47 <TheSheep> achshar: the task is to find the wiki engines that let you do that, write down how they do it, and come up with a similar solution for moin
348 2010-12-03T12:57:51 <TheSheep> achshar: no, it's for span
349 2010-12-03T12:58:03 <TheSheep> achshar: just the current solution is not very good
350 2010-12-03T12:58:15 <TheSheep> achshar: we want you to find a better way to do it
351 2010-12-03T12:58:23 <TheSheep> achshar: just find it, we will implement it
352 2010-12-03T12:58:51 <achshar> hmm ok i think i get it
353 2010-12-03T12:58:53 <TheSheep> achshar: you have to look at other wikis and maybe even other web applications that use markup
354 2010-12-03T12:59:33 <TheSheep> you would probably also want to see what the users actually need it for
355 2010-12-03T12:59:47 <TheSheep> so that you can decide which solution is the best
356 2010-12-03T13:00:56 <achshar> i use some meathods for my own site.. i can modyfiy it
357 2010-12-03T13:01:17 <achshar> how do you want the solution?
358 2010-12-03T13:01:31 <achshar> maybe a text file explaing it?
359 2010-12-03T13:02:38 <TheSheep> yes, a text file listing different solutions, discussing their pros and cons
360 2010-12-03T13:03:03 <achshar> ok i am claiming it now :)
361 2010-12-03T13:06:01 *** achshar
362 2010-12-03T13:25:18 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964841 (colour - can you think about a good way to use colour in moin wiki content?)
363 2010-12-03T13:55:46 <GCIBot> ClaimRequested: http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037964841 (colour - can you think about a good way to use colour in moin wiki content?)
364 2010-12-03T14:16:31 *** greg_f
365 2010-12-03T14:24:49 *** m4k3r
366 2010-12-03T15:53:24 <m4k3r> ThomasWaldmann: ping
367 2010-12-03T15:58:25 <ThomasWaldmann> peng
368 2010-12-03T16:00:18 <ThomasWaldmann> m4k3r:
369 2010-12-03T16:00:49 <ThomasWaldmann> (in general, on irc, it is a good idea to just tell / just ask), that might reduce round-trip-delay significantly
370 2010-12-03T16:01:15 <m4k3r> ThomasWaldmann: would you prefer openid login on login.html or into another page?
371 2010-12-03T16:01:29 <m4k3r> s/on/in/
372 2010-12-03T16:01:47 <ThomasWaldmann> i can tell you after i see it :)
373 2010-12-03T16:03:06 <ThomasWaldmann> maybe first doing it on the normal login page is not that bad. if we think it confuses non-openid people too much, we can either hide/show it with js or move it to another page
374 2010-12-03T16:03:10 <ThomasWaldmann> view*
375 2010-12-03T16:10:30 <pvinogradov> ThomasWaldmann: Hi
376 2010-12-03T16:11:30 <pvinogradov> Did you plan to pull my two last changes into 1.9 tree
377 2010-12-03T16:12:21 <pvinogradov> i send pull request two days ago, this changes include comment fix and use htpassword generated hashes instead of python-generated
378 2010-12-03T16:12:47 <ThomasWaldmann> did you resolve the mismathc?
379 2010-12-03T16:14:21 <pvinogradov> which mistmach?
380 2010-12-03T16:14:52 <ThomasWaldmann> didn't you tell there was an issue with md5?
381 2010-12-03T16:15:38 <ThomasWaldmann> https://bitbucket.org/pavel_vinogradov/gci10-moin-1.9-pass/changeset/ff282aaf7912
382 2010-12-03T16:15:52 <ThomasWaldmann> why is line 103 202 231 identical?
383 2010-12-03T16:17:09 <pvinogradov> this is my mystake on line 231
384 2010-12-03T16:17:42 <pvinogradov> i can't find solution to generate md5crypt compatible hash without python code from md5crypt.py
385 2010-12-03T16:19:11 <ThomasWaldmann> maybe we need to put at least some comment into the tests documenting that this is unclear and TODO
386 2010-12-03T16:19:32 <ThomasWaldmann> other than that, I'm fine with your changes and will pull them later today
387 2010-12-03T16:19:57 <ThomasWaldmann> how's your progress on moin2 port?
388 2010-12-03T16:20:40 *** jbills
389 2010-12-03T16:21:23 <pvinogradov> i'm already port current test and hashed password support to moin2
390 2010-12-03T16:21:36 <pvinogradov> and reading about sha256 hashes
391 2010-12-03T16:21:56 <pvinogradov> i'm use https://bitbucket.org/pavel_vinogradov/gci10-moin-2.0-dev for 2.0 tree
392 2010-12-03T16:22:49 <jbills> In the toc macro how would you get only list items with sub items?
393 2010-12-03T16:23:24 <dreimark> TheSheep: ^ if you have a minute
394 2010-12-03T16:24:34 <ThomasWaldmann> dreimark: can we close MoinMoinWikis cleanup task?
395 2010-12-03T16:25:02 <TheSheep> dreimark: which one?
396 2010-12-03T16:26:25 <dreimark> jbills: please provide the url
397 2010-12-03T16:26:40 <jbills> what url?
398 2010-12-03T16:26:47 <dreimark> of your task
399 2010-12-03T16:26:58 <jbills> http://www.google-melange.com/gci/task/show/google/gci2010/moinmoin/t129037970449
400 2010-12-03T16:29:19 <dreimark> ThomasWaldmann: the student must use first the review tag
401 2010-12-03T16:29:26 <dreimark> then yes we can close it
402 2010-12-03T16:29:45 <dreimark> ah you wrote it
403 2010-12-03T16:29:52 <TheSheep> jbills: something like $('li:not(empty)') maybe?
404 2010-12-03T16:30:26 <ThomasWaldmann> dreimark: yes, i told that in a melange msg
405 2010-12-03T16:30:28 <jbills> thats on the client side. I need it to be on the server side
406 2010-12-03T16:30:28 <TheSheep> $('li:not(:empty)')
407 2010-12-03T16:30:37 <TheSheep> jbills: ah, in jinja?
408 2010-12-03T16:31:19 <TheSheep> jbills: which template is it?
409 2010-12-03T16:31:20 <jbills> yes
410 2010-12-03T16:31:42 <jbills> not template.html_out.py in converter
411 2010-12-03T16:32:14 <dreimark> bbl
412 2010-12-03T16:32:19 <TheSheep> which line approximately?
413 2010-12-03T16:32:34 <jbills> 1 minute
414 2010-12-03T16:34:01 <jbills> 526
415 2010-12-03T16:34:29 <jbills> approximately
416 2010-12-03T16:36:01 <TheSheep> waldi: any ideas?
417 2010-12-03T16:36:33 <TheSheep> I'm not familiar with the new converters, sorry :(
418 2010-12-03T16:36:41 <TheSheep> maybe waldi will help you
419 2010-12-03T16:37:23 <TheSheep> in the worst case, keep a reference to the element you added, then count the items and if the count is 0 then add something to that element
420 2010-12-03T16:40:39 <jbills> currently you can expand and hide any of the elements see toc_open.png
421 2010-12-03T16:48:35 <waldi> -v?
422 2010-12-03T16:56:54 <jbills> what does -v mean?
423 2010-12-03T16:57:08 <jbills> verbose>
424 2010-12-03T16:57:10 <jbills> ?
425 2010-12-03T16:58:30 <dreimark> jbills: ask
426 2010-12-03T17:00:47 <jbills> ask what?
427 2010-12-03T17:01:08 <m4k3r> ThomasWaldmann: is openid supporto to be considered required by the wiki? I have to edit views.py, adding there some oid controls. I can make a big 'if' instance and add there my functions, or consider flask-openid as required. Which one do you prefer?
428 2010-12-03T17:02:56 <jbills> for elem, headings in special.tocs(): attrib_h = {html.class_: 'table-of-contents-heading'} elem_h = html.p( attrib=attrib_h, children=[_('Contents')]) attrib_z={html.id_: 'displaytext',html.style_:'color:blue;text-align:right;'} attrib_s={html.id_:'showhide',html.href_:'javascript:toggle()'} elem_s=html.a(attrib=attrib_s,childre
429 2010-12-03T17:03:08 <jbills> lines through 570
430 2010-12-03T17:09:34 <dreimark> waldi: ^^ (jbills please use the nick of the person you want to talk to)
431 2010-12-03T17:09:54 <dreimark> and use a pastebin or link to the hg repository
432 2010-12-03T17:31:55 <ThomasWaldmann> m4k3r: no, we don't require openid support
433 2010-12-03T17:32:17 <ThomasWaldmann> try: import openidstuff except ImportError: openidstuff = None
434 2010-12-03T17:32:47 <m4k3r> ThomasWaldmann: and the a big 'if' clause?
435 2010-12-03T17:32:53 <m4k3r> *then
436 2010-12-03T17:33:58 <jbills> k
437 2010-12-03T17:34:03 <jbills> sorry
438 2010-12-03T17:36:20 <jbills> https://gist.github.com/727189
439 2010-12-03T17:41:09 <pvinogradov> moin-2.0: Did you plan convert users password to sha256 (instead of ssha) on login?
440 2010-12-03T17:41:58 <waldi> why?
441 2010-12-03T17:42:13 <pvinogradov> i see answer in task description: auto-upgrade passwords on login to SSHA256
442 2010-12-03T17:43:16 <waldi> jbills: this is a stack machine. so you have to check on stack pop
443 2010-12-03T17:45:09 <ThomasWaldmann> m4k3r: if openidstuff: ...
444 2010-12-03T17:45:26 <ThomasWaldmann> don't require it
445 2010-12-03T17:45:55 <ThomasWaldmann> m4k3r: so you go for the flask-openid stuff? did you check our old openid code?
446 2010-12-03T17:47:21 <m4k3r> ThomasWaldmann: ok. But I have to edit also logout() function, adding a check for users logged via openid.
447 2010-12-03T17:48:14 <ThomasWaldmann> just make sure nothing crashes if there is no openid stuff installed
448 2010-12-03T17:48:52 <m4k3r> ThomasWaldmann: quickly. I thought flask-openid would be more maintenaible and easy to work on; both for me and you.
449 2010-12-03T17:49:31 <ThomasWaldmann> m4k3r: and you can integrate it well into our auth system?
450 2010-12-03T17:50:50 <m4k3r> ThomasWaldmann: it is surely well-integrable with views, I'm just checking how I could integrate with an auth.OpenIDAuth class.
451 2010-12-03T18:04:16 *** kursor
452 2010-12-03T18:21:04 <ThomasWaldmann> http://moinmo.in/EasyToDo/make%20file%20upload%20more%20comfortable any comments on that one?
453 2010-12-03T18:21:40 <ThomasWaldmann> (yes, it is for 1.9, due to some negative feedback about how uncomfortable that is currently)
454 2010-12-03T18:22:08 <ThomasWaldmann> (we can have a follow up task, porting it to moin2)
455 2010-12-03T19:18:28 <ThomasWaldmann> brb
456 2010-12-03T19:24:57 *** rfw
457 2010-12-03T19:26:26 *** rfw
458 2010-12-03T19:26:46 *** rfw
459 2010-12-03T19:31:44 *** rfw
460 2010-12-03T19:32:00 *** rfw
461 2010-12-03T19:32:00 *** rfw
462 2010-12-03T19:36:20 *** rfw
463 2010-12-03T19:37:50 *** rfw
464 2010-12-03T19:37:50 *** rfw
465 2010-12-03T19:39:40 *** greg_f
466 2010-12-03T20:09:55 <ThomasWaldmann> re
467 2010-12-03T21:28:27 *** kursor
468 2010-12-03T22:15:40 *** moin4
469 2010-12-03T22:16:14 <moin4> I'm having trouble with permissions can anyone help me here?
470 2010-12-03T22:17:20 <moin4> Here is the error: data_dir "/usr/local/share/moin/data" does not exist, or has incorrect ownership or permissions
471 2010-12-03T22:17:39 <moin4> but the folder exists and the permissions look correct to me. what else could cause this?
472 2010-12-03T22:18:57 *** moin4
473 2010-12-03T22:54:56 *** rfw
474 2010-12-03T23:07:51 *** rfw
475 2010-12-03T23:10:00 <jrabbit> ThomasWaldmann: do you gewt the GCI emails?
476 2010-12-03T23:10:12 <jrabbit> I submitted a new patch
477 2010-12-03T23:10:30 <jrabbit> using platform
478 2010-12-03T23:10:37 <jrabbit> which is standard across all pythons
479 2010-12-03T23:13:49 <ThomasWaldmann> re
480 2010-12-03T23:17:40 <ThomasWaldmann> jrabbit: look at version.diff yourself
481 2010-12-03T23:18:14 <jrabbit> did I upload an old one?
482 2010-12-03T23:18:24 <jrabbit> ThomasWaldmann: this is why I use gist.
483 2010-12-03T23:19:36 <ThomasWaldmann> it's not THAT difficult
484 2010-12-03T23:22:11 <jrabbit> there
485 2010-12-03T23:24:14 <ThomasWaldmann> same again?
486 2010-12-03T23:24:41 <jrabbit> If its showing something other than the git repo then it's GCI messing up.
487 2010-12-03T23:25:22 <ThomasWaldmann> can you maybe look yourself before requesting review by others?
488 2010-12-03T23:29:00 <jrabbit> ThomasWaldmann: deal with the GCI's failure yourself
489 2010-12-03T23:29:27 <jrabbit> wait
490 2010-12-03T23:29:50 <jrabbit> I think my changes were removed somehow
491 2010-12-03T23:39:51 *** rfw
492 2010-12-03T23:41:19 <jrabbit> I don't know how it happeend but I've corrected it
493 2010-12-03T23:44:17 <ThomasWaldmann> +if not platform.python_version()[:3] >= 2.6:
494 2010-12-03T23:46:44 *** moin2
495 2010-12-03T23:46:59 <jrabbit> Yes that is a line in the patch.
496 2010-12-03T23:47:35 <ThomasWaldmann> that's a notable line, because it has 1 bug and 1 imperfection :)
497 2010-12-03T23:47:53 <ThomasWaldmann> and what was the problem with .hexversion again?
498 2010-12-03T23:48:08 <jrabbit> pypy doesn't report it acurately.
499 2010-12-03T23:49:11 <ThomasWaldmann> why do you think so? in my case it does.
500 2010-12-03T23:49:35 <ThomasWaldmann> >>>> hex(sys.hexversion)
501 2010-12-03T23:49:36 <ThomasWaldmann> '0x20502b0'
502 2010-12-03T23:49:59 <ThomasWaldmann> that means 2.5.2...
503 2010-12-03T23:50:03 <jrabbit> Oh.
504 2010-12-03T23:50:09 <jrabbit> this works fine
505 2010-12-03T23:51:12 <ThomasWaldmann> and you can just compare it against 0x2060000
506 2010-12-03T23:52:39 <jrabbit> this is a bit more readable I don't see a reason to use that
507 2010-12-03T23:52:59 <ThomasWaldmann> eh?
508 2010-12-03T23:53:47 <jrabbit> its readable
509 2010-12-03T23:54:15 <jrabbit> thoguh the if not >= bit is changeable but it works as is
510 2010-12-03T23:55:40 <ThomasWaldmann> yes, but it has multiple issues, not only that "not >=" should be "<"
511 2010-12-03T23:55:56 <ThomasWaldmann> then function call returns a string
512 2010-12-03T23:56:12 <ThomasWaldmann> you take the first 3 chars of it and compare it to a float
513 2010-12-03T23:56:56 <ThomasWaldmann> and even if that would also be a string: comparing string version numbers has other issues due to they way how string comparisons work
514 2010-12-03T23:57:00 <jrabbit> import platform; platform.python_version()[:3] >= 2.6
515 2010-12-03T23:57:12 <jrabbit> results true
516 2010-12-03T23:57:13 <jrabbit> :P
517 2010-12-03T23:57:28 <jrabbit> Er ok its always true.
518 2010-12-03T23:57:33 *** rfw
519 2010-12-03T23:59:02 <jrabbit> hex(sys.hexversion) < 0x2060000
520 2010-12-03T23:59:02 <jrabbit> False
521 2010-12-03T23:59:05 <jrabbit> on 2.5
522 2010-12-03T23:59:06 <jrabbit> ...
