1 2010-09-04T00:38:59 *** grzywacz
2 2010-09-04T05:10:21 *** RogerHaase
3 2010-09-04T05:10:47 *** RogerHaase
4 2010-09-04T07:54:15 *** grzywacz
5 2010-09-04T09:25:14 *** valeuf
6 2010-09-04T09:29:41 *** grzywacz
7 2010-09-04T09:47:48 <valeuf> moin
8 2010-09-04T09:49:31 <ThomasWaldmann> wb valeuf
9 2010-09-04T10:32:02 *** valeuf
10 2010-09-04T10:34:37 *** vjaniaut
11 2010-09-04T10:34:45 <vjaniaut> \o/
12 2010-09-04T10:39:24 <ThomasWaldmann> hey :)
13 2010-09-04T10:39:50 <ThomasWaldmann> (if anyone else needs a moin developer account on shell.moinmo.in, talk to me)
14 2010-09-04T10:45:40 <ThomasWaldmann> (one can use it e.g. to run irssi in a screen, so client is permanently connected to IRC)
15 2010-09-04T10:49:55 <TheSheep> ThomasWaldmann: that would be nice
16 2010-09-04T10:51:20 <ThomasWaldmann> same pubkey as for repo?
17 2010-09-04T10:52:30 <TheSheep> ThomasWaldmann: yes, althought it would be nice to have password too
18 2010-09-04T10:57:35 <dreimark> moin
19 2010-09-04T11:05:31 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9850:a2800312d36d 2.0-dev/MoinMoin/_tests/__init__.py: tests: remove make_macro (not used any more)
20 2010-09-04T11:05:34 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9851:832c7ace466c 2.0-dev/MoinMoin/ (9 files in 7 dirs): test support code: remove some unneeded request params
21 2010-09-04T11:13:05 * ThomasWaldmann tries to kill the formatters now
22 2010-09-04T11:21:43 *** TheSheep_
23 2010-09-04T11:22:09 *** TheSheep
24 2010-09-04T11:22:42 *** TheSheep
25 2010-09-04T11:41:29 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9852:58bfbea6fa38 2.0-dev/MoinMoin/ (9 files in 5 dirs): (log message trimmed)
26 2010-09-04T11:41:29 <CIA-36> remove all formatters, details below
27 2010-09-04T11:41:29 <CIA-36> remove text_html formatter (we use html_out converter since quite a while)
28 2010-09-04T11:41:29 <CIA-36> remove groups formatter (no replacement code yet, so groups will not work)
29 2010-09-04T11:41:29 <CIA-36> wikidicts and wikigroups should use the DOM in moin2, could work in a similar
30 2010-09-04T11:41:29 <CIA-36> way as extracting the itemlinks and saving them to metadata (see item saving
31 2010-09-04T11:41:30 <CIA-36> code and link converter).
32 2010-09-04T11:41:40 <ThomasWaldmann> \o/
33 2010-09-04T11:44:26 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9853:6076cb7bde86 2.0-dev/MoinMoin/ (__init__.py util/_tests/test_uidgen.py util/uidgen.py): remove UniqueIDGenerator, was only used by formatter
34 2010-09-04T11:44:55 <dreimark> global history does not work on test
35 2010-09-04T11:46:23 <ThomasWaldmann> see BUGS
36 2010-09-04T11:46:40 <dreimark> yeah, sorry
37 2010-09-04T11:52:58 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9854:4401d085ac56 2.0-dev/MoinMoin/ (theme/__init__.py user.py wikiutil.py):
38 2010-09-04T11:52:58 <CIA-36> rename getInterwikiHomePage -> getInterwikiHome
39 2010-09-04T11:52:58 <CIA-36> reasons:
40 2010-09-04T11:52:58 <CIA-36> avoid false positives when searching for Page()
41 2010-09-04T11:52:58 <CIA-36> we have items now, not pages (otoh "homepage" is a usual expression,
42 2010-09-04T11:52:59 <CIA-36> so calling it "homeitem" doesn't make too much sense either, so it is
43 2010-09-04T11:53:00 <CIA-36> just "home" now)
44 2010-09-04T11:55:22 <ThomasWaldmann> Page() is next on kill list
45 2010-09-04T11:55:48 <ThomasWaldmann> you can help by refactoring stuff that still uses Page() to use new API
46 2010-09-04T11:57:53 <ThomasWaldmann> e.g. wiki_dicts/wiki_groups
47 2010-09-04T12:09:37 <dreimark> good
48 2010-09-04T12:17:42 <ThomasWaldmann> s/use new api/rewrite it/
49 2010-09-04T12:18:23 <ThomasWaldmann> i guess it should just return stuff from item's latest revision's metadata
50 2010-09-04T12:19:46 <ThomasWaldmann> and that there will be a 'group' and 'dict' key that has ready-to-use data
51 2010-09-04T12:20:16 <ThomasWaldmann> put there by a converter at reision save time
52 2010-09-04T12:20:52 <dreimark> makes sense meta can be much faster accessed and it is always the same type of data indep. of item mimetype
53 2010-09-04T12:21:44 * ThomasWaldmann tries writing that converter
54 2010-09-04T12:21:48 <dreimark> category needs to be similiar later on
55 2010-09-04T12:22:22 <ThomasWaldmann> i think categories will be entered using a form in the end
56 2010-09-04T12:23:56 <dreimark> yes, type should be may be sim. to a tuple with uniq data, so order is given
57 2010-09-04T12:24:31 <dreimark> or may be over engineered we don't care currently, but that will make it able to hace a hierarchy
58 2010-09-04T12:26:35 * dreimark needs to take a shower bbl
59 2010-09-04T13:04:21 <ThomasWaldmann> hmm, is our list/dicts approach maybe too complicated?
60 2010-09-04T13:04:46 <ThomasWaldmann> (i mean the markup-page-using lists/dicts definitions)
61 2010-09-04T13:05:04 <ThomasWaldmann> we could just have a json item
62 2010-09-04T13:06:25 <ThomasWaldmann> in fact, we already use json for metadata
63 2010-09-04T13:06:47 <ThomasWaldmann> so maybe all we need is a "group" and "dict" metadata key and we're done? :)
64 2010-09-04T13:08:34 * ThomasWaldmann will choose the lazy way if noone objects :)
65 2010-09-04T13:16:15 <ThomasWaldmann> ok, seems to work :D
66 2010-09-04T13:16:59 <ThomasWaldmann> item.rev.get('group', [])
67 2010-09-04T13:17:17 <ThomasWaldmann> item == highlevel item, rev = storage revision
68 2010-09-04T13:17:32 <ThomasWaldmann> item.rev.get('dict', {})
69 2010-09-04T13:35:02 <ThomasWaldmann> dreimark: are you working on one of dicts/groups?
70 2010-09-04T13:47:33 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9855:2e4279c016a8 2.0-dev/MoinMoin/items/__init__.py: define key constants for groups/dicts within metadata
71 2010-09-04T13:48:58 <ThomasWaldmann> dreimark: use these, so code using those keys is easier to locate
72 2010-09-04T13:49:04 <dreimark> re
73 2010-09-04T13:49:22 * dreimark hmm good they did a little bit shopping before starting
74 2010-09-04T13:49:32 <dreimark> s/they/that I/
75 2010-09-04T13:50:24 <dreimark> ThomasWaldmann: btw. thought you have thought on this before
76 2010-09-04T13:59:18 <ThomasWaldmann> putting into meta yes, just using json as for other meta no
77 2010-09-04T14:19:33 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/258432/ the filter i did manually now, do you have something in the convertor I can use?
78 2010-09-04T14:24:52 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9856:b02836cf74f0 2.0-dev/MoinMoin/macro2/SystemInfo.py:
79 2010-09-04T14:24:52 <CIA-36> remove SystemInfo macro, see below
80 2010-09-04T14:24:52 <CIA-36> * partly pointless, checking/displaying stuff we do not use any more
81 2010-09-04T14:24:52 <CIA-36> * should be done as a (admin) view, not as macro
82 2010-09-04T14:24:52 <CIA-36> * should use jinja2 template
83 2010-09-04T14:24:52 <CIA-36> * think about which information can be disclosed to whom, some stuff
84 2010-09-04T14:24:53 <CIA-36> might help attackers (like sw version info, installed extensions etc.)
85 2010-09-04T14:26:28 <ThomasWaldmann> dreimark: well, that approach doesn't scale
86 2010-09-04T14:26:51 <ThomasWaldmann> (if you add one param per metadata key someone could use)
87 2010-09-04T14:28:52 <dreimark> we always have item data. me thought the filtered valid dict data becomes meta data then. and that this is done on item save
88 2010-09-04T14:29:35 <ThomasWaldmann> maybe it should be just meta and data
89 2010-09-04T14:30:55 <dreimark> yes becomes meta then (-data)
90 2010-09-04T14:31:28 <dreimark> but the item data is shown (by +show)
91 2010-09-04T14:32:19 * dreimark needs scale my wording fsck data is everything from a global scope
92 2010-09-04T14:36:43 <ThomasWaldmann> ?
93 2010-09-04T14:43:15 <dreimark> item.save always writes data and meta. so one has to enter first e.g. a dict definition at item data. on saving the dict definition becomes saved as meta.
94 2010-09-04T14:48:50 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9857:b8c33b288f50 2.0-dev/MoinMoin/macro2/RandomQuote.py: remove RandomQuote macro, needs to be reimplemented (working on DOM level)
95 2010-09-04T14:50:04 <ThomasWaldmann> dreimark: why not just give binary data and a dict as meta to that function?
96 2010-09-04T14:50:48 <ThomasWaldmann> there could be a small type check so it also accepts unicode for data (and encodes it internally before saving)
97 2010-09-04T14:51:26 <ThomasWaldmann> there could be a small type check so it also accepts json for meta (and processes it same way as when saved from editor)
98 2010-09-04T14:52:03 <dreimark> understand now, what not scales
99 2010-09-04T14:53:55 <dreimark> ThomasWaldmann: meta has no revisions, it is only the latest
100 2010-09-04T14:54:26 <dreimark> (at least i thought this)
101 2010-09-04T14:54:45 <ThomasWaldmann> ?
102 2010-09-04T14:57:46 * dreimark rads some code - sorry
103 2010-09-04T14:57:49 <dreimark> +e
104 2010-09-04T14:58:55 <dreimark> i don't currently not understand if you want to change meta "dict" data without creating a new revision
105 2010-09-04T14:59:56 <dreimark> or if it is meta "dict" data added how the ui will look like
106 2010-09-04T15:00:20 <ThomasWaldmann> i didn't tell that
107 2010-09-04T15:00:54 <ThomasWaldmann> i just pointed out that you don't want to add N params to create_item for N different metadata keys
108 2010-09-04T15:01:21 <ThomasWaldmann> but just give the metadata as a dict or as json (or as **kw maybe?)
109 2010-09-04T15:01:47 <ThomasWaldmann> same for data, should be binary (str), so it can be used for anything
110 2010-09-04T15:02:06 <ThomasWaldmann> plus stuff as mentioned above for a little more comfort
111 2010-09-04T15:05:56 <dreimark> yes, the filter i thought about first is nonsense
112 2010-09-04T15:09:01 <dreimark> we kill the regex too ? because we can have a meta key on the item itselfs?
113 2010-09-04T15:09:52 <dreimark> i mean page_group_regex and others
114 2010-09-04T15:10:26 <ThomasWaldmann> i am not completely sure about the regex filter yet
115 2010-09-04T15:11:14 <ThomasWaldmann> if one knows the group name, one doesn't need it of course
116 2010-09-04T15:11:39 <ThomasWaldmann> but if you want to search in which groups e.g. a username is contained,
117 2010-09-04T15:11:59 <ThomasWaldmann> it is a bit more efficient if you don't have to read all item's metadata
118 2010-09-04T15:12:54 <ThomasWaldmann> otoh, maybe we could optimize that later with the index
119 2010-09-04T15:29:38 <ThomasWaldmann> (maybe just a flag in the fast primary index "this is a group defining item" should be enough)
120 2010-09-04T15:30:36 <ThomasWaldmann> then we could kill group/dict regex
121 2010-09-04T16:12:17 <dreimark> ok, had unfort. a long phone call
122 2010-09-04T16:12:54 <dreimark> it can become a search query too
123 2010-09-04T16:15:14 *** RogerHaase
124 2010-09-04T16:15:20 <dreimark> hi RogerHaase
125 2010-09-04T16:22:08 <RogerHaase> hi dreimark
126 2010-09-04T16:23:46 <dreimark> we should prefix moins css ids to avoid name conflicts
127 2010-09-04T16:25:13 <RogerHaase> Yes, I like that idea. diofeher made a start.
128 2010-09-04T17:01:07 <dreimark> search from eclipse must be improved
129 2010-09-04T17:02:32 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9858:61573c99cf21 2.0-dev/MoinMoin/apps/frontend/views.py: fix change password view title
130 2010-09-04T17:18:20 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9859:5f0f805e7f73 2.0-dev/MoinMoin/config/default.py: use an empty ConfigDicts/ConfigGroups instance until the WikiDicts/WikiGroups is refactored to use new api
131 2010-09-04T17:18:37 <ThomasWaldmann> dreimark: ^^ be careful when testing
132 2010-09-04T17:29:28 *** dennda
133 2010-09-04T17:32:05 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9860:9f234db26da0 2.0-dev/MoinMoin/datastruct/__init__.py: don't import WikiDicts/WikiGroups until they don't import Page any more
134 2010-09-04T17:41:54 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9861:c35cb7f02a7f 2.0-dev/MoinMoin/ (script/maint/cleancache.py Page.py _tests/test_Page.py):
135 2010-09-04T17:41:54 <CIA-36> removed old Page module (+ tests), see below
136 2010-09-04T17:41:54 <CIA-36> * mostly replaced by MoinMoin.items/storage/templates
137 2010-09-04T17:41:54 <CIA-36> * still used by search and some macros (need refactoring/rewrite)
138 2010-09-04T17:42:00 <ThomasWaldmann> \o/
139 2010-09-04T18:34:50 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9862:93603f5d4258 2.0-dev/MoinMoin/ (_tests/test_wikiutil.py util/_tests/test_web.py wikiutil.py):
140 2010-09-04T18:34:50 <CIA-36> removed wikiutil.parseQueryString/makeQueryString
141 2010-09-04T18:34:50 <CIA-36> most code uses url_encode/decode from werkzeug now or url_for from flask
142 2010-09-04T18:50:51 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9863:2510aaa54308 2.0-dev/MoinMoin/ (storage/backends/fs19_logfile.py wikiutil.py): remove wikiutil.version2timestamp/timestamp2version and some unused code that used it
143 2010-09-04T18:55:38 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9864:061ec4dcd998 2.0-dev/MoinMoin/wikiutil.py: remove wikiutil.MetaDict - not used any more
144 2010-09-04T19:19:29 *** grzywacz
145 2010-09-04T19:20:07 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9865:1ed1ef8af81f 2.0-dev/MoinMoin/ (config/__init__.py wikiutil.py): remove wikiutil.isPicture and .link_tag - not used any more
146 2010-09-04T19:26:00 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9866:f3d6703d8f79 2.0-dev/MoinMoin/wikiutil.py: remove wikiutil.taintfilename and .mapURL, not used any more
147 2010-09-04T20:09:34 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9867:d077560d2224 2.0-dev/MoinMoin/ (7 files in 4 dirs): move Version class from wikiutil to version module (similar for tests)
148 2010-09-04T20:21:49 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9868:fe5ddfa96818 2.0-dev/MoinMoin/macro2/NewPage.py:
149 2010-09-04T20:21:49 <CIA-36> removed NewPage macro, should be cleanly reimplemented later, see below
150 2010-09-04T20:21:49 <CIA-36> In moin 1.9, this stuff was split into a macro and an action, but for
151 2010-09-04T20:21:49 <CIA-36> reimplementation, all code needs to be put into the macro and adapted
152 2010-09-04T20:21:49 <CIA-36> to moin2 api.
153 2010-09-04T20:28:14 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9869:ffa0fed68da6 2.0-dev/MoinMoin/ (_tests/test_wikiutil.py wikiutil.py):
154 2010-09-04T20:28:14 <CIA-36> remove wikiutil.pagelinkmarkup and .quoteWikinameURL - not used any more
155 2010-09-04T20:28:14 <CIA-36> note: if we need something like pagelinkmarkup again, it needs to be replaced
156 2010-09-04T20:28:14 <CIA-36> by a converter application/x-moin-document -> real markup (so we can support
157 2010-09-04T20:28:14 <CIA-36> different markups).
158 2010-09-04T21:22:58 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9870:9e0d71856525 2.0-dev/MoinMoin/ (8 files in 7 dirs): remove wikiutil.escape, use werkzeug.escape
159 2010-09-04T21:32:54 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9871:8ae4a9cba087 2.0-dev/MoinMoin/wikiutil.py: wikiutil: misc. cleanup
160 2010-09-04T21:53:30 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9872:76f279c4a494 2.0-dev/MoinMoin/ (_tests/test_wikiutil.py wikiutil.py security/ticket.py): move tickets code from wikiutil to MoinMoin.security.ticket
161 2010-09-04T22:06:00 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9873:616fd8520f74 2.0-dev/MoinMoin/wikiutil.py: replace filterCategoryPages by isCategoryItem
162 2010-09-04T22:32:16 <CIA-36> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 9874:22fcd88b7cbf 2.0-dev/MoinMoin/ (_tests/test_wikiutil.py wikiutil.py): wikiutil: rename Abs/RelPageName to Abs/RelItemName, cosmetics for ParentItemName
