1 2010-07-08T00:12:36 *** valeuf
2 2010-07-08T00:13:01 *** valeuf
3 2010-07-08T00:23:37 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8600:7a66fe5f9b2d 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (5 files in 3 dirs): [templating] changed default argument in render_template (now it is layout.html. dropped link_to in username(). adapted templates according new structure (newaccount and login)
4 2010-07-08T00:24:20 <diofeher> ThomasWaldmann: don't know well.. i just changed this to drop link_to.. and i did't see this working
5 2010-07-08T00:33:12 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8601:54221afdb80d 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (action/userprefs.py templates/content.html): [templating] creating a template to use instead of send_title (can pass content here). adapting userprefs actions
6 2010-07-08T00:35:48 *** grzywa
7 2010-07-08T00:35:56 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8602:ef68fec8733a 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/userprefs.py: [templating] adapting rest of userprefs to new templates
8 2010-07-08T00:36:21 *** grzywacz
9 2010-07-08T00:37:24 *** RogerHaase
10 2010-07-08T00:41:35 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8603:4960ed964fab 2.0-dev-jinja2-plugins-dfeher/MoinMoin/action/userprefs.py: [templating] reverting send_page in userprefs
11 2010-07-08T00:52:02 *** grzywacz
12 2010-07-08T00:55:44 <diofeher> this send_page is waiting me (marvelous laugh)
13 2010-07-08T01:12:28 <diofeher> bbl
14 2010-07-08T03:44:13 <diofeher> re
15 2010-07-08T05:43:46 <diofeher> TheSheep: i'm using that project that you told me
16 2010-07-08T05:43:47 <diofeher> ack
17 2010-07-08T05:44:01 <diofeher> man, it's really good! and have nice output :)
18 2010-07-08T06:53:51 <diofeher> gn
19 2010-07-08T07:29:48 *** DmitryAndreev_
20 2010-07-08T08:35:30 *** DmitryAndreev_
21 2010-07-08T08:36:14 *** DmitryAndreev_
22 2010-07-08T09:03:38 <valeuf> moin ^^
23 2010-07-08T09:07:02 <ThomasWaldmann> moin
24 2010-07-08T09:13:15 *** gwork
25 2010-07-08T09:18:21 <ThomasWaldmann> diofeher: TheSheep: http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/rev/7a66fe5f9b2d#l5.12
26 2010-07-08T09:19:44 <ThomasWaldmann> i think we should tear that into multiple pieces: login_link, userhome_link, logout_link
27 2010-07-08T09:19:55 <ThomasWaldmann> so that more can be done in the template
28 2010-07-08T09:22:14 <ThomasWaldmann> diofeher: the userhome link doesn't work correctly for home page in other wiki
29 2010-07-08T09:24:57 <ThomasWaldmann> and why are login and newaccount in "item" blocks?
30 2010-07-08T09:30:18 <valeuf> do you know if some people did template for smartphone browser with Jinja ?
31 2010-07-08T09:31:28 <ThomasWaldmann> this is the first jinja2 moin theme being created
32 2010-07-08T09:32:15 <valeuf> ThomasWaldmann: ? you mean that there is already a jinja2 theme for smartphone browser ?
33 2010-07-08T09:39:49 <ThomasWaldmann> no, the one that dio creates is the first
34 2010-07-08T09:40:00 <ThomasWaldmann> and it is not for smartphone
35 2010-07-08T09:44:10 <valeuf> aaah
36 2010-07-08T09:44:20 <valeuf> sorry :) misunderstood
37 2010-07-08T09:54:37 <ThomasWaldmann> valeuf: http://moinmo.in/DOM%20DocBook%20and%20HTML%202010/HTML-DOM/Tests
38 2010-07-08T09:54:52 <ThomasWaldmann> please clarify, what "before", "after" and "result" means
39 2010-07-08T09:57:17 <valeuf> ThomasWaldmann: refresh the page,
40 2010-07-08T09:57:54 <valeuf> ThomasWaldmann: before mean the HTML I give to the converter, and after it is the HTML we got after the roundtrip conversion ( HTML--> DOM --> HTML)
41 2010-07-08T09:59:41 <valeuf> typically, for the WYSIWYG editor, I just create an item, modify it by adding content using the editor, and then when I show the item
42 2010-07-08T09:59:59 <valeuf> I have the roundtrip conversion done
43 2010-07-08T10:07:50 <valeuf> waldi: is there any magic trick for the get action ?
44 2010-07-08T10:08:24 <ThomasWaldmann> ok
45 2010-07-08T10:08:36 <valeuf> waldi: I find the code in the Item, but it seems that only request.status_code = 304 return the object !
46 2010-07-08T10:10:10 <waldi> valeuf: not yet i presume
47 2010-07-08T10:10:29 <valeuf> I will continue my investigation :)
48 2010-07-08T10:17:06 <waldi> okay, some questions after a real code review. why is the moinmoin output implemented iterative instead of recursive? Why open and close functions, especially as most of them are empty and only contribute to the computing time?
49 2010-07-08T10:17:29 <valeuf> waldi: you are talking about moinmoin_out ?
50 2010-07-08T10:17:50 <waldi> please always use helper classes/methods, MoinMoin.util.iri.Iri, MoinMoin.converter2._args_wiki.unparse
51 2010-07-08T10:18:09 <waldi> yes. please note that in english no blank is added before a question mark
52 2010-07-08T10:18:51 * valeuf is thinking to hit himself each time he forget this ***** space rule!
53 2010-07-08T10:18:58 <waldi> it have to use unicode all the time
54 2010-07-08T10:20:04 <waldi> well, it is even the wrong space for french
55 2010-07-08T10:21:40 <valeuf> waldi: no there is non-breakable space before all the punctuation signs except comma and point in French
56 2010-07-08T10:23:37 <waldi> wikipedia say something different ("No-break thin space, known in Unicode as "NARROW NO-BREAK SPACE" (U+202F). This is required for French punctuation (before ?, ! or ;).")
57 2010-07-08T10:24:43 <valeuf> yep, so there is space before ?
58 2010-07-08T10:24:51 <valeuf> (in french at least)
59 2010-07-08T10:25:13 <waldi> yeah, but no normal space. anyway, thats irrelevant now
60 2010-07-08T10:25:21 <valeuf> ^ ^
61 2010-07-08T11:09:52 <valeuf> waldi: the code to get an item has been tested extensively ? Or it is not surprising if there is bugs ?
62 2010-07-08T11:21:36 *** DmitryAndreev
63 2010-07-08T11:44:29 *** valeuf
64 2010-07-08T11:44:37 *** valeuf
65 2010-07-08T12:01:39 *** DmitryAndreev
66 2010-07-08T12:06:23 *** gwork
67 2010-07-08T12:25:06 *** DmitryAndreev
68 2010-07-08T12:25:48 *** DmitryAndreev
69 2010-07-08T12:27:31 *** ritinardo
70 2010-07-08T12:44:45 *** DmitryAndreev
71 2010-07-08T12:46:26 *** DmitryAndreev
72 2010-07-08T12:59:04 *** vpv
73 2010-07-08T12:59:11 *** vpv
74 2010-07-08T13:55:14 <valeuf> \o/ I can use do=get to convert from a format to another one :)
75 2010-07-08T13:55:17 <valeuf> need to clean the code now
76 2010-07-08T13:55:39 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8549:f67fe80aa395 2.0-dev-docbook-html-vjaniaut/MoinMoin/converter2/docbook_out.py: Register correctly the DocBook_out converter to the converter foctory
77 2010-07-08T14:12:53 <ThomasWaldmann> valeuf: wasn't do=get intended to deliver the raw item data?
78 2010-07-08T14:43:20 *** DmitryAndreev
79 2010-07-08T14:55:20 *** DmitryAndreev
80 2010-07-08T14:55:41 *** DmitryAndreev
81 2010-07-08T15:23:05 <dreimark> valeuf: typos in commits
82 2010-07-08T15:35:18 <valeuf> ThomasWaldmann: well, I do not know exactly, we can use show instead of get, it will be same
83 2010-07-08T15:35:34 <valeuf> ThomasWaldmann: any we should give the correct mimetype
84 2010-07-08T15:35:47 <valeuf> if no mimetype is specified, it return the raw data
85 2010-07-08T15:41:44 <valeuf> anyway I will polish the code, so we can use it as example later, it is not a big problem to change the action (get, show or whatever)
86 2010-07-08T15:41:56 <valeuf> but at least we can use that for tests purpose
87 2010-07-08T16:06:16 <ThomasWaldmann> well, have a look what get does right now
88 2010-07-08T16:06:44 <ThomasWaldmann> it is already a bit complex, because it supports 304, getting from cache, getting from tar files
89 2010-07-08T16:25:17 <valeuf> ThomasWaldmann: right, actually my implementation let all these stuffs working fine, except when a conversion occur
90 2010-07-08T16:25:35 <valeuf> ThomasWaldmann: we should discuss also with waldi to see what can be the best solution
91 2010-07-08T16:26:17 <ThomasWaldmann> i have to see code to tell
92 2010-07-08T16:26:29 <valeuf> ThomasWaldmann: I commit that soon, I got some problem to clean it
93 2010-07-08T16:45:11 <diofeher> moin
94 2010-07-08T16:45:22 <valeuf> hi diofeher :)
95 2010-07-08T16:47:52 <diofeher> valeuf hi ^^
96 2010-07-08T16:53:51 *** RogerHaase
97 2010-07-08T16:59:27 <ThomasWaldmann> diofeher: see 09:18
98 2010-07-08T17:00:00 <ThomasWaldmann> or irc log of 07:18 UTC rather
99 2010-07-08T17:02:56 *** ritinardo
100 2010-07-08T17:09:24 *** DmitryAndreev
101 2010-07-08T17:11:33 <diofeher> ThomasWaldmann: ok
102 2010-07-08T17:16:59 <diofeher> lunch, brb
103 2010-07-08T17:34:31 <CIA-98> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8550:42f8a67c8020 2.0-dev-docbook-html-vjaniaut/MoinMoin/items/__init__.py: Add a draft implementation to handel conversion using converter2 and the get action
104 2010-07-08T17:34:40 <diofeher> re
105 2010-07-08T17:34:49 <valeuf> well, I definitely think that what I did is not at the good place
106 2010-07-08T17:35:24 <valeuf> but more generally, I think that this __init__.py file need to be refactored, probably split into different file for each mimetype, is definitely too big ^ ^
107 2010-07-08T17:35:48 <valeuf> so we can see later : to add a special action (like maybe convert) to care especially about conversion
108 2010-07-08T17:36:36 <valeuf> and also add some method for the different mimetype to handle some post-process operation, because usually converter does not return a perfectly compliant file (like doctype can be missing)
109 2010-07-08T17:37:38 <valeuf> another option (much nicer), would be just to keep the current action, and detect if the mimetype parameter from the request is different from the object mimetype, and then process the correct conversion
110 2010-07-08T17:38:04 <valeuf> so we could allow user to edit item wrote using creole syntax with moinmoin syntax or even more complicate things
111 2010-07-08T17:51:30 <ThomasWaldmann> gtg/bbl
112 2010-07-08T18:14:59 *** kursor
113 2010-07-08T18:23:55 *** DmitryAndreev
114 2010-07-08T18:57:39 *** grzywacz
115 2010-07-08T20:19:08 *** kursor
116 2010-07-08T20:36:48 *** franklin_
117 2010-07-08T20:40:13 *** franklin
118 2010-07-08T20:48:47 <diofeher> ThomasWaldmann: i'm trying to figure out why this homelink is not working
119 2010-07-08T20:49:24 <ThomasWaldmann> interwiki can't work that way
120 2010-07-08T20:51:15 <diofeher> yes.. i'm seeing to do this in other way
121 2010-07-08T21:24:20 <diofeher> ThomasWaldmann: i'm really stucked with this interwikilink :S
122 2010-07-08T21:37:12 <diofeher> maybe can i use this directly?
123 2010-07-08T21:59:10 <diofeher> ah man, discovered my problem
124 2010-07-08T21:59:24 <diofeher> i'm looking for interwikilink in formatter.__init__
125 2010-07-08T21:59:42 <diofeher> and when running it's using interwikilink from text_html
126 2010-07-08T21:59:45 <diofeher> thanks pdb :P
127 2010-07-08T22:15:06 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8604:03f8961b411f 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (formatter/text_html.py theme/jinja.py): [templating] creating a function in formatter (interwiki_item_name) that return interwiki name, instead of link, and build url in JinjaTheme.username.
128 2010-07-08T22:17:21 <CIA-98> Diogenes Augusto <diofeher@gmail.com> default * 8605:5bc67d5e7393 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (formatter/text_html.py theme/jinja.py): [templating] changing some parameters in calling interwiki_item_name and fixing return (not return with querystr)
129 2010-07-08T22:38:23 <ThomasWaldmann> diofeher: you know the formatter is going away?
130 2010-07-08T22:38:54 <ThomasWaldmann> and even if it would stay, there is no point in putting arbitrary functions in there that are not related to formatting
131 2010-07-08T22:40:11 <diofeher> ThomasWaldmann: didn't know...
132 2010-07-08T22:40:22 <diofeher> i just follow where they called
133 2010-07-08T22:40:31 <diofeher> but well, where did i put this function?
134 2010-07-08T22:40:41 <ThomasWaldmann> so, move this somewhere else, e.g. into wikiutil, near the other interwiki related functions
135 2010-07-08T22:40:49 <ThomasWaldmann> also, think about a sane name
136 2010-07-08T22:40:56 <ThomasWaldmann> and cleanup that code
137 2010-07-08T22:42:42 * ThomasWaldmann want to see hg diff before next commit with a fix for that
138 2010-07-08T22:47:20 <ThomasWaldmann> also, please fix arg names: wikiname, itemname. and if you don't use **kw any more, then remove it.
139 2010-07-08T22:49:06 <ThomasWaldmann> you also kill that strange try/except in there
140 2010-07-08T22:49:09 <diofeher> ok, gonna work on this now
141 2010-07-08T22:49:38 <ThomasWaldmann> and give it itemname_current as additional param
142 2010-07-08T22:50:39 <ThomasWaldmann> or even better: first check if that thing ever gets called with relative item names
143 2010-07-08T22:50:53 <ThomasWaldmann> like /SubPage
144 2010-07-08T22:51:12 <ThomasWaldmann> because only for that you need that AbsPageName thing
145 2010-07-08T22:51:50 <CIA-98> Dmitry Andreev <klieg.polar@gmail.com> default * 8447:38849e93b6be 2.0-dev-wiki-rest-dandreev/MoinMoin/converter2/ (_tests/test_rst_out.py rst_out.py): DOM->ReStructuredText: various bugfixes and more tests
146 2010-07-08T23:04:09 <valeuf> weird I am not able to push my commits ...
147 2010-07-08T23:08:00 <ThomasWaldmann> hg heads
148 2010-07-08T23:08:29 <valeuf> changeset: 8554:bc91958c34a4
149 2010-07-08T23:08:30 <valeuf> tag: tip
150 2010-07-08T23:08:30 <valeuf> user: Valentin Janiaut <valentin.janiaut@utbm.fr>
151 2010-07-08T23:08:30 <valeuf> date: Thu Jul 08 22:59:13 2010 +0200
152 2010-07-08T23:08:30 <valeuf> summary: Add conversion for orderedlist in the DocBook_IN converter
153 2010-07-08T23:08:50 <valeuf> I got a timeout : remote: Connection to hg.moinmo.in closed by remote host.
154 2010-07-08T23:08:50 <valeuf> abandon : no suitable response from remote hg !
155 2010-07-08T23:17:41 <ThomasWaldmann> push url?
156 2010-07-08T23:18:51 <valeuf> it is in my hgrc so there is no reason but : ssh://hg@hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/
157 2010-07-08T23:19:25 <valeuf> I tried to merge against moin/2.0-dev, but still it does not want to push (but pull is working)
158 2010-07-08T23:21:21 <valeuf> well, maybe some problem with my network
159 2010-07-08T23:24:35 <ThomasWaldmann> what happens if you ssh there?
160 2010-07-08T23:26:10 <valeuf> ah good question
161 2010-07-08T23:26:12 <valeuf> I will try
162 2010-07-08T23:26:31 <valeuf> O . O
163 2010-07-08T23:26:39 <valeuf> PTY allocation request failed on channel 0
164 2010-07-08T23:26:39 <valeuf> Connection to hg.moinmo.in closed.
165 2010-07-08T23:26:43 <valeuf> what's that ?
166 2010-07-08T23:28:11 <TheSheep> out of ptys?
167 2010-07-08T23:30:42 <ThomasWaldmann> that's expected
168 2010-07-08T23:31:12 <valeuf> ah yes I remember that anyway we was not able to get a tty using ssh
169 2010-07-08T23:33:19 <dreimark> valeuf: use an agent
170 2010-07-08T23:33:34 <valeuf> dreimark: an agent ?
171 2010-07-08T23:35:33 <valeuf> dreimark: you mean ssh-agent ?
172 2010-07-08T23:35:41 <ThomasWaldmann> agent orange :P
173 2010-07-08T23:35:44 <valeuf> dreimark: what that would change ?
174 2010-07-08T23:36:12 <valeuf> ( except that I won't have to type my long key at each time )
175 2010-07-08T23:37:44 <valeuf> well, I will see that tomorrow, I need to sleep
176 2010-07-08T23:37:46 <valeuf> gn ^ ^
177 2010-07-08T23:42:32 *** grzywacz
178
