1 2010-06-22T00:03:01 <dreimark> gn
2 2010-06-22T00:30:14 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8371:7d219fa0b5e7 2.0-dev/MoinMoin/ (8 files in 3 dirs): templating: replace urlquote usage by href, add href and abs_href to env
3 2010-06-22T00:36:05 <ThomasWaldmann> diofeher: ^^ please also add abs_href to "your" env
4 2010-06-22T01:02:43 <diofeher> ThomasWaldmann: understood the problem, my mistake (download edit_bar) :P
5 2010-06-22T01:09:37 <ThomasWaldmann> merge and go on :)
6 2010-06-22T01:09:57 * ThomasWaldmann plays with some table template
7 2010-06-22T01:13:27 <diofeher> table templates? nooo :P
8 2010-06-22T01:17:58 <ThomasWaldmann> hm?
9 2010-06-22T01:19:56 <CIA-49> Diogenes Augusto <diofeher@gmail.com> default * 8406:c34545824c28 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/editbar.html theme/jinja.py): [templating] dropped downloadLink() and moved to editbar.html
10 2010-06-22T01:20:42 <diofeher> templates without tableless?
11 2010-06-22T01:22:08 <ThomasWaldmann> i don't understand you
12 2010-06-22T01:22:32 <ThomasWaldmann> i am playing with html table generation using jinja2 templating
13 2010-06-22T01:23:50 <diofeher> oooooh
14 2010-06-22T01:23:59 <diofeher> sorry, i understanding another thing
15 2010-06-22T01:24:12 <CIA-49> Diogenes Augusto <diofeher@gmail.com> default * 8436:6f8e7b295a26 2.0-dev-jinja2-plugins-dfeher/ (53 files in 26 dirs): [templating] merged with main repo
16 2010-06-22T01:24:26 <diofeher> layouts made with table, instead of divs and go on
17 2010-06-22T01:29:45 *** xorAxAx
18 2010-06-22T01:29:45 *** grzywacz
19 2010-06-22T01:29:47 *** xjjk
20 2010-06-22T01:32:28 *** xjjk
21 2010-06-22T01:34:42 <ThomasWaldmann> ah :) no i don't do table layouts
22 2010-06-22T01:39:02 <ThomasWaldmann> http://paste.pocoo.org/show/228241/ that was easy :)
23 2010-06-22T01:40:21 <diofeher> haha nice
24 2010-06-22T01:40:36 <diofeher> ThomasWaldmann: do you know about dependency injection in frameworks?
25 2010-06-22T01:44:03 *** xorAxAx
26 2010-06-22T01:44:38 <ThomasWaldmann> not really. does one need that? :)
27 2010-06-22T01:45:56 <diofeher> yes, it's a principle to separate frameworks to libs :P
28 2010-06-22T01:46:17 <diofeher> but i remembered that moinmoin is not framework haha
29 2010-06-22T01:46:38 <diofeher> i have a college presentation about this subject tomorrow ^^
30 2010-06-22T01:47:13 <diofeher> my group wants that I talk about java frameworks, but i'm gonna talk about python framework.. i think django
31 2010-06-22T02:08:12 <CIA-49> Diogenes Augusto <diofeher@gmail.com> default * 8437:86bc244c8747 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/editbar.html theme/jinja.py): [templating] dropped modifyLink and made TODO (immutable page witithout link
32 2010-06-22T02:11:07 <CIA-49> Diogenes Augusto <diofeher@gmail.com> default * 8438:6d2558c9661b 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] fixed a typo
33 2010-06-22T02:12:35 <diofeher> wow dreimark, this pylint is very nice
34 2010-06-22T02:12:44 <diofeher> liked the output
35 2010-06-22T03:13:34 <ThomasWaldmann> diofeher: modify link url is wrong
36 2010-06-22T03:13:58 <ThomasWaldmann> download link url is wrong
37 2010-06-22T03:14:58 <diofeher> ThomasWaldmann: why? they're only with actions do=get and do=modify
38 2010-06-22T03:15:57 <diofeher> well, modify is really wrong :x
39 2010-06-22T03:15:58 <diofeher> sry
40 2010-06-22T03:18:13 <diofeher> fixed
41 2010-06-22T03:18:31 <CIA-49> Diogenes Augusto <diofeher@gmail.com> default * 8439:5d342e493d74 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/editbar.html: [templating] fixed errors in modify and download urls
42 2010-06-22T03:19:41 <ThomasWaldmann> better
43 2010-06-22T08:30:26 *** gwork
44 2010-06-22T09:09:48 *** AshishG
45 2010-06-22T09:09:53 <AshishG> moin
46 2010-06-22T09:58:25 <dreimark> moin
47 2010-06-22T10:08:25 *** gwork
48 2010-06-22T11:13:59 *** CIA-49
49 2010-06-22T11:47:11 *** CIA-47
50 2010-06-22T12:46:52 <ThomasWaldmann> http://pastebin.com/kivMw2cA < span macro, please review
51 2010-06-22T12:51:57 <dreimark> ThomasWaldmann: can we have some highlighting e.g. yellow background
52 2010-06-22T12:52:17 <dreimark> hmm may be that is only a other css class?
53 2010-06-22T12:54:25 <dreimark> (I want a background color)
54 2010-06-22T12:58:10 *** AshishG
55 2010-06-22T12:59:16 <dreimark> if it makes sense I would prefer to setup defaults and list of valid arguments dir=("ltr", "rtl"), align=("left", "right", "center", "justify")
56 2010-06-22T13:11:58 <ThomasWaldmann> <<span(red)>> works if red is a css class that makes it red
57 2010-06-22T13:12:32 <ThomasWaldmann> ah, yeah, good idea
58 2010-06-22T13:12:38 <ThomasWaldmann> (the choices)
59 2010-06-22T13:27:26 <ThomasWaldmann> hmm, choices are troublesome
60 2010-06-22T13:27:45 <ThomasWaldmann> i want an empty default and not requiring that arg
61 2010-06-22T13:40:22 <dreimark> the first is the default
62 2010-06-22T13:41:06 <dreimark> so you have to start with a choice of ""
63 2010-06-22T13:54:59 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 531:bd8e88710547 extensions/data/plugin/macro/span.py: span macro - see MoinMoin:MacroMarket/span
64 2010-06-22T13:58:08 <ThomasWaldmann> http://moinmo.in/MacroMarket/span
65 2010-06-22T14:19:34 <ThomasWaldmann> hmm, just gonna kill align again as it is deprecated and we have css classes for that
66 2010-06-22T14:22:08 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 532:942f9b55773e extensions/data/plugin/macro/span.py: span macro: remove support for align attr as it is deprecated
67 2010-06-22T14:33:19 * ThomasWaldmann adds indirect style support
68 2010-06-22T15:29:54 <ThomasWaldmann> bah, style sucks :|
69 2010-06-22T15:56:02 *** gwork
70 2010-06-22T16:21:51 *** gwork
71 2010-06-22T16:48:48 *** RogerHaase
72 2010-06-22T17:26:45 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 533:1f9926e7f5b5 extensions/data/plugin/macro/span.py: span macro: add (hopefully safe) style support, let through only properties on whitelist
73 2010-06-22T17:26:47 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 534:7bcfe0b3823a extensions/data/plugin/macro/span.py: span macro: reformat docstring
74 2010-06-22T17:26:59 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 535:4599602f00e5 extensions/data/plugin/macro/span.py: span macro: refactor some code, make whitelist a param, clean up
75 2010-06-22T17:26:59 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 536:c937dca76e96 extensions/data/plugin/macro/span.py: span macro: fix bug, minor other changes
76 2010-06-22T17:26:59 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 537:61621f711b18 extensions/data/plugin/macro/span.py: span macro: avoid empty style (if all was crap)
77 2010-06-22T17:26:59 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 538:6cb5b60276b1 extensions/data/plugin/macro/span.py: span macro: handle special case if style given is all unsafe crap
78 2010-06-22T17:54:10 <ThomasWaldmann> maybe someone should do a security review for this ^^ (i mean the style safety stuff, etc.)
79 2010-06-22T18:17:27 <xorAxAx> valeuf: http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/e8cdaf67aa2d -- i dont see an added unittest for that code path, please add (dont forget TDD)
80 2010-06-22T18:17:45 <xorAxAx> valeuf: i would also like you to reuse code instead of copy&paste code when ever possible
81 2010-06-22T18:18:28 <xorAxAx> valeuf: this affects http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/0f112ff7b5ac http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/33b9870c4001 http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/36f770789c51 http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/f9829fd65e7e http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/af6281bd536f
82 2010-06-22T18:18:30 <xorAxAx> http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/36bad095224f and others
83 2010-06-22T18:20:17 <ThomasWaldmann> CPD :)
84 2010-06-22T18:20:26 <xorAxAx> CPD?
85 2010-06-22T18:20:37 <ThomasWaldmann> copy & paste development :D
86 2010-06-22T18:20:40 <xorAxAx> yeah :)
87 2010-06-22T18:35:27 <dreimark> eSyr: DmitryAndreev should look by pylint on his convertors
88 2010-06-22T18:36:05 <eSyr> dreimark: ok.
89 2010-06-22T18:36:59 <dreimark> and may be tell him to run all tests test_sourcecode has lots of PEP8 issues
90 2010-06-22T18:37:40 <eSyr> oh.
91 2010-06-22T18:37:43 <ThomasWaldmann> eSyr: and join in here so we can talk directly
92 2010-06-22T18:37:54 <eSyr> i thought i've told him about using py.testbefore comitting.
93 2010-06-22T18:38:13 <eSyr> ok.
94 2010-06-22T18:38:27 <ThomasWaldmann> maybe he ran only his own tests because so much was broken otherwise
95 2010-06-22T18:38:38 <ThomasWaldmann> it is not any more btw, just merge
96 2010-06-22T18:38:53 <dreimark> yes last merge was 11 days ago
97 2010-06-22T18:39:24 <ThomasWaldmann> btw, that style support switch in the span code has 2 usage scenarios
98 2010-06-22T18:39:35 <ThomasWaldmann> a) "I want it even safer."
99 2010-06-22T18:40:00 <ThomasWaldmann> b) "Don't annoy me with big green text on pink background."
100 2010-06-22T18:42:10 <zenhase> hmm, copy&paste-development :)
101 2010-06-22T18:42:21 * zenhase calls it cargo cult programming
102 2010-06-22T18:42:40 <zenhase> oh wait
103 2010-06-22T18:42:52 <zenhase> you meant code duplication problems :)
104 2010-06-22T18:44:20 <ThomasWaldmann> hi zenhase
105 2010-06-22T18:45:47 <ThomasWaldmann> brb
106 2010-06-22T18:46:43 <dreimark> eSyr: it tells lots of todo but i think it helps him to find something like that http://hg.moinmo.in/moin/2.0-dev-wiki-rest-dandreev/file/7293fb648410/MoinMoin/converter2/rst_out.py#l109
107 2010-06-22T18:47:00 <dreimark> E:109:Table.complete_line: Undefined variable 'table'
108 2010-06-22T18:47:14 <dreimark> that means also there is no test covering that code yet
109 2010-06-22T18:48:42 <eSyr> hehe.
110 2010-06-22T18:48:44 <eSyr> ok.
111 2010-06-22T18:49:11 <eSyr> i was rather busy last two weeks so read diffs only partially.
112 2010-06-22T18:49:21 <dreimark> he can call py.test with -C if he adds a coverage line at the end of his tests
113 2010-06-22T18:49:34 * dreimark too
114 2010-06-22T18:49:46 <dreimark> i started yesterday to peek in all project
115 2010-06-22T18:49:48 <dreimark> s
116 2010-06-22T18:50:43 <dreimark> hmm, it is not -C lets look
117 2010-06-22T18:52:28 <dreimark> ah it is - just one has to do easy_install -U coverage beforehand
118 2010-06-22T18:52:37 <dreimark> (that was missing on that box)
119 2010-06-22T18:53:28 <zenhase> oh yes ... hi thomas, hi everybody else
120 2010-06-22T18:53:35 <dreimark> hi zenhase
121 2010-06-22T19:07:33 <valeuf> xorAxAx: ok, I will make the appropriate changes soon
122 2010-06-22T19:07:46 <xorAxAx> very nice, student
123 2010-06-22T19:09:50 <ThomasWaldmann> http://paste.pocoo.org/show/228554/ table support class
124 2010-06-22T19:10:05 <ThomasWaldmann> much simpler than dbw
125 2010-06-22T19:11:43 <dreimark> bbl
126 2010-06-22T19:23:53 *** DmitryAndreev
127 2010-06-22T19:23:58 <DmitryAndreev> moin
128 2010-06-22T19:24:14 <DmitryAndreev> the internet is back to my house)
129 2010-06-22T19:24:44 <DmitryAndreev> dreimark, thx for easy_install -U coverage
130 2010-06-22T19:34:18 <ThomasWaldmann> wb to the internets :)
131 2010-06-22T20:01:00 <dreimark> DmitryAndreev: you can then run it with py.test -C
132 2010-06-22T20:01:12 <dreimark> see the other tests for the coverage line
133 2010-06-22T20:04:01 <DmitryAndreev> dreimark, yes. thx, i'll try it, when I get back to the tests
134 2010-06-22T20:04:28 <dreimark> ok
135 2010-06-22T20:16:13 *** DmitryAndreev_
136 2010-06-22T20:17:05 <ThomasWaldmann> do we need tfoot?
137 2010-06-22T20:17:50 *** DmitryAndreev
138 2010-06-22T20:21:03 *** DmitryAndreev_
139 2010-06-22T20:52:54 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8372:1d4ada46fe6c 2.0-dev/MoinMoin/widget/table.py: add a simple-to-use Table class to build html tables
140 2010-06-22T20:56:08 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8373:ef534f23c294 2.0-dev/MoinMoin/items/__init__.py: use Table class to build content listings of zip and tar items (css still missing)
141 2010-06-22T20:57:34 <ThomasWaldmann> css class assignment has to be seen ^^
142 2010-06-22T20:58:32 <ThomasWaldmann> currently, the table has a class, the th has a class and the TDs use same class as their th, except if it is specified otherwise
143 2010-06-22T20:59:40 <ThomasWaldmann> default for rendering: thead yes, tfoot no, tbody yes
144 2010-06-22T22:23:08 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8374:f94215b56e46 2.0-dev/MoinMoin/macro2/Hits.py: remove Hits macro, it is based on code that was already deleted
145 2010-06-22T22:53:08 <CIA-47> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8375:67562d138a94 2.0-dev/MoinMoin/ (caching.py wikiutil.py): removed deprecated and unused caching method, fix pep8 error
146 2010-06-22T23:16:49 <diofeher> good evening!
147 2010-06-22T23:17:45 <ThomasWaldmann> hi diofeher
148 2010-06-22T23:18:33 <diofeher> i didn't entered in morning because i have a presentation and i was studying
149 2010-06-22T23:18:43 <diofeher> about dependecy injection :P gonna work now
150 2010-06-22T23:21:27 <ThomasWaldmann> eh?
151 2010-06-22T23:22:19 <ThomasWaldmann> ah, you've finished your presentation.
152 2010-06-22T23:22:56 <ThomasWaldmann> look through your todo please and if there are questions, ask within next hour or so
153 2010-06-22T23:24:23 <diofeher> ok ^^
154 2010-06-22T23:26:30 <diofeher> ThomasWaldmann: i was wondering about a mechanism to move easy actions between editbar and actions
155 2010-06-22T23:27:21 <diofeher> i thought in a class Editbar, and the user can move 'Download' between 'edit_bar' and 'actions' config for example
156 2010-06-22T23:27:28 <diofeher> TheSheep: are you there?
157 2010-06-22T23:28:03 <diofeher> i'm gonna write piece of code to show what i'm thinking
158 2010-06-22T23:30:30 <ThomasWaldmann> maybe don't lose too much time on that now
159 2010-06-22T23:30:49 <ThomasWaldmann> that's a detail, you have important bigger stuff todo
160 2010-06-22T23:32:53 <diofeher> hmm, ok
161 2010-06-22T23:39:02 <ThomasWaldmann> diofeher: you forgot to update diary. do it today when you finish coding.
162 2010-06-22T23:42:08 <ThomasWaldmann> http://hg.moinmo.in/moin/2.0-dev-jinja2-plugins-dfeher/file/tip/MoinMoin/theme/jinja.py#l26 .. 31
163 2010-06-22T23:42:49 <ThomasWaldmann> why is that still there? didn't you look at my changeset how i removed rss feed and replaced it with atom?
164 2010-06-22T23:43:21 <diofeher> i looked your changeset, and replaced rss with atom
165 2010-06-22T23:43:30 <diofeher> but didn't saw this piece, sry
166 2010-06-22T23:59:44 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8440:a61717e239c9 2.0-dev-jinja2-plugins-dfeher/MoinMoin/theme/jinja.py: [templating] fixed some errors detected by pylint
