1 2010-06-21T00:28:57 <dreimark> re
2 2010-06-21T00:29:18 <dreimark> fscking umts and windows system in schools
3 2010-06-21T00:30:04 <dreimark> ei-grad: you can if you send it first to google translate_t
4 2010-06-21T00:30:20 <dreimark> at least if it does not give translations you know
5 2010-06-21T00:33:09 <dreimark> ThomasWaldmann: uniq check becomes easier
6 2010-06-21T00:33:56 <dreimark> currently we can block renaming - that is still needed
7 2010-06-21T00:34:50 <dreimark> but also if it is wanted to rename a user we have no mapping in edit and event log to the old name
8 2010-06-21T00:35:48 <ThomasWaldmann> event-log is gone
9 2010-06-21T00:35:52 <dreimark> ok
10 2010-06-21T00:36:05 <ThomasWaldmann> and for edit-log, we use uids (since moin 0.x)
11 2010-06-21T00:36:25 <ThomasWaldmann> so changing the name is no problem
12 2010-06-21T00:36:27 <dreimark> won't that change with your changeset
13 2010-06-21T00:36:54 <ThomasWaldmann> well, i wanted to use uuids for items anyway
14 2010-06-21T00:37:32 <ThomasWaldmann> (not fully implemented yet)
15 2010-06-21T00:38:31 <dreimark> disabling a user could also be changed to move the user to a disabled trashbin
16 2010-06-21T00:39:14 <ThomasWaldmann> we just would no accept trashed users for login
17 2010-06-21T00:39:19 <ThomasWaldmann> +t
18 2010-06-21T00:39:39 <ThomasWaldmann> dreimark: when do we need to block renaming user?
19 2010-06-21T00:40:07 <dreimark> i block it always if i use many acl definition
20 2010-06-21T00:40:34 <dreimark> because if the user renames himself he has no access
21 2010-06-21T00:40:57 <dreimark> until I change all group definition
22 2010-06-21T00:41:07 <dreimark> s
23 2010-06-21T00:41:29 <dreimark> and it is blocked for various auth e.g. ldap
24 2010-06-21T00:42:55 <ThomasWaldmann> if ldap auth worked by associating the user dn with the user profile, renaming user would be no problem
25 2010-06-21T00:44:04 <dreimark> hmm currently we use alias that would not be needed then and it does not alias in a way i would prefer
26 2010-06-21T00:44:12 <ThomasWaldmann> and users renaming themselves out of groups -> WYGIWYD
27 2010-06-21T00:44:13 <dreimark> currently it is on mouseover showing
28 2010-06-21T00:44:50 <dreimark> what you get is what you do - half right because they don't setup groups
29 2010-06-21T00:45:02 <dreimark> and mostly because they are not technicans
30 2010-06-21T00:45:49 <dreimark> if groups behave similiar that they have only uids then renaming is no problem
31 2010-06-21T00:46:19 <dreimark> somehow that is similiar to renaming a page
32 2010-06-21T00:46:36 <ThomasWaldmann> s/do/deserve/ :)
33 2010-06-21T00:46:51 <dreimark> ah
34 2010-06-21T00:47:27 <ThomasWaldmann> yes, it is
35 2010-06-21T00:47:39 <ThomasWaldmann> but uids are a bit unpractical on the UI
36 2010-06-21T00:48:28 * ThomasWaldmann thinks about using yaml to fill metadata into editbox
37 2010-06-21T00:48:59 <ThomasWaldmann> and editbox data -> data structure (using safe_load, of course)
38 2010-06-21T01:12:50 <dreimark> gn
39 2010-06-21T01:54:29 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8345:cb737118a056 2.0-dev/MoinMoin/items/__init__.py: replace homebrew metadata <-> text conversion with json
40 2010-06-21T02:00:41 <diofeher> hm, href(translated_item_name('Download'), do='get') don't behave as expected
41 2010-06-21T02:01:58 <diofeher> hm, it's working well, my mistake :P
42 2010-06-21T02:06:32 <diofeher> TheSheep ThomasWaldmann are you there?
43 2010-06-21T02:09:22 <diofeher> wondering if it's a good idea to render editbar this way: http://paste.pocoo.org/show/227808/
44 2010-06-21T02:10:31 <ThomasWaldmann> btw, students working on moin2 (all except ei-grad) may officially use py 2.6 now
45 2010-06-21T02:11:49 <ThomasWaldmann> diofeher: think before coding
46 2010-06-21T02:18:38 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8346:56f41b71ba4a 2.0-dev/docs/REQUIREMENTS: update docs/REQUIREMENTS: raising python minimum requirement to 2.6
47 2010-06-21T02:27:21 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8347:7df88dd42580 2.0-dev/MoinMoin/ (items/__init__.py support/python_compatibility.py): more minor py2.6 related changes
48 2010-06-21T02:36:10 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8348:f61253e2237f 2.0-dev/MoinMoin/util/SubProcess.py: util.SubProcess: removed stuff only needed for py < 2.6
49 2010-06-21T02:52:22 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8349:4053cf564275 2.0-dev/moin.spec: fixed python requirement in moin.spec
50 2010-06-21T02:52:24 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8350:b5f0adbd980a 2.0-dev/MoinMoin/util/filesys.py: remove broken/deprecated dircache stuff
51 2010-06-21T02:52:24 *** grzywacz
52 2010-06-21T02:53:29 <ThomasWaldmann> diofeher: you see it now? if there are questions left for today, be quick, I am in sleep mode soon.
53 2010-06-21T03:10:43 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8351:82d762d774e8 2.0-dev/MoinMoin/ (14 files in 9 dirs): remove py 2.4 python_compatibility stuff
54 2010-06-21T03:46:58 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8352:c7d8cf295a44 2.0-dev/ (15 files in 11 dirs): remove py 2.5 python_compatibility stuff
55 2010-06-21T04:32:45 *** RogerHaase
56 2010-06-21T04:32:49 *** RogerHaase
57 2010-06-21T04:37:34 *** RogerHaase
58 2010-06-21T04:48:51 <diofeher> ThomasWaldmann: sorry for the delay, but i think it's not wrong to render editbar in this way... gonna wait your answer to see the problem =)
59 2010-06-21T05:20:35 *** RogerHaase
60 2010-06-21T05:20:38 *** RogerHaase
61 2010-06-21T08:49:56 <ThomasWaldmann> diofeher: "Download" is no item name, thus translated_item_name is nonsense
62 2010-06-21T08:50:44 <ThomasWaldmann> and how did you get that "working well"? :)
63 2010-06-21T08:53:43 <ThomasWaldmann> what you need is <a href="?do=get">{{ _("Download") }}</a> or so
64 2010-06-21T10:54:17 *** gwork
65 2010-06-21T11:56:26 *** mikema
66 2010-06-21T12:16:15 *** mikema
67 2010-06-21T12:38:51 <dreimark> moin
68 2010-06-21T13:20:53 *** gwork
69 2010-06-21T13:25:31 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8353:1a29489967b3 2.0-dev/MoinMoin/ (9 files in 5 dirs): kill MoinMoin.util.timefuncs (unused, not needed, replaced by werkzeug)
70 2010-06-21T13:42:28 *** gwork
71 2010-06-21T13:59:13 *** gwork
72 2010-06-21T14:37:00 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8354:5f4e2424b1c1 2.0-dev/MoinMoin/converter2/html_out.py: html_out converter: ugly workaround for ugly traceback
73 2010-06-21T14:38:09 <ThomasWaldmann> waldi: see comments in changeset ^^
74 2010-06-21T14:39:03 <ThomasWaldmann> (and that rfind crash likely happened since the switch (or half-switch) to Iri)
75 2010-06-21T14:43:45 <ThomasWaldmann> btw, 1143 passed, 21 skipped in 189.41 seconds
76 2010-06-21T14:44:55 <ThomasWaldmann> diofeher: ei-grad: valeuf: please merge
77 2010-06-21T14:45:23 <ThomasWaldmann> ehrm, no, ei-grad you don't need to merge
78 2010-06-21T14:45:38 <ThomasWaldmann> (he is using 1.9)
79 2010-06-21T15:12:36 <dreimark> ThomasWaldmann: i get: 1 failed, 1485 passed, 24 skipped in 208.14 seconds
80 2010-06-21T15:12:50 <dreimark> moin-2.0-dev/MoinMoin/macro2/Date.py:17:1: W291 trailing whitespace
81 2010-06-21T15:13:51 <ThomasWaldmann> maybe some old pep8 issue
82 2010-06-21T15:14:02 <ThomasWaldmann> the check only checks recently changed files
83 2010-06-21T15:14:24 <dreimark> me has 3 more skipped
84 2010-06-21T15:15:36 <ThomasWaldmann> depends on your optional modules maybe
85 2010-06-21T15:15:58 <dreimark> probably
86 2010-06-21T15:20:46 <ThomasWaldmann> dreimark: yes, after touching I have that, too. you fix it?
87 2010-06-21T15:20:53 <dreimark> ei-grad: Im sorry for missing the meeting I have had problems with my umts connection
88 2010-06-21T15:22:27 <dreimark> please explain why you removed encoding http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/diff/ac5cf827b731/MoinMoin/auth/ldap_login.py#l1.260
89 2010-06-21T15:22:55 <dreimark> ThomasWaldmann: yes
90 2010-06-21T15:25:27 <ThomasWaldmann> http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/ac5cf827b731/MoinMoin/util/ldap_connection.py#l134
91 2010-06-21T15:25:33 <ThomasWaldmann> because of that ^^
92 2010-06-21T15:30:28 <CIA-49> Reimar Bauer <rb.proj AT googlemail DOT com> default * 8355:dc618ab6aceb 2.0-dev/MoinMoin/macro2/Date.py: macro2.Date: PEP8 whitespace fix
93 2010-06-21T15:30:30 <dreimark> ok
94 2010-06-21T15:41:49 <ThomasWaldmann> btw, try the json metadata editing
95 2010-06-21T15:59:06 <dreimark> 2010-06-21 15:58:49,060 WARNING MoinMoin.log:111 /private/icg105/workspace/moin-2.0-dev/MoinMoin/support/sqlalchemy/engine/default.py:230: SAWarning: Unicode type received non-unicode bind param value ''
96 2010-06-21T16:00:16 <dreimark> ThomasWaldmann: do you have tried adraw after the refactoring?
97 2010-06-21T16:00:30 <dreimark> AttributeError: 'DummyRev' object has no attribute 'seek'
98 2010-06-21T16:00:42 <dreimark> workspace/moin-2.0-dev/MoinMoin/items/__init__.py", line 784, in list_members
99 2010-06-21T16:01:33 <dreimark> http://localhost:8080/dummy2?do=modify&mimetype=application/x-anywikidraw
100 2010-06-21T16:01:39 <dreimark> tfraw seems to work
101 2010-06-21T16:01:50 <dreimark> s/tfraw/tdraw/
102 2010-06-21T16:03:09 <dreimark> with modifying a draw file the text box for metadata is shrinked to a width of one char
103 2010-06-21T16:22:44 <dreimark> ei-grad: in ldap_groups.py you don't use tls_keyfile as you do in ldap_login.py
104 2010-06-21T16:23:07 <dreimark> please check
105 2010-06-21T16:26:13 <dreimark> please look at test_ldap_connection.py there are various not needed imports
106 2010-06-21T16:30:01 *** RogerHaase
107 2010-06-21T16:32:56 <dreimark> diofeher: please look with pylint at MoinMoin/userprefs/prefs.py
108 2010-06-21T16:33:10 <dreimark> e.g. E:224:Settings.handle_form: Undefined variable '_'
109 2010-06-21T16:33:25 <dreimark> W:332:Settings.create_form: Redefining built-in 'type'
110 2010-06-21T16:34:23 <dreimark> me does not like to short var names as u for request.user - but we have to discuss that
111 2010-06-21T16:36:03 <dreimark> MoinMoin/theme/jinja.py has various not used imports
112 2010-06-21T16:36:12 <dreimark> W:1169:JinjaTheme.render: Dangerous default value {} as argument
113 2010-06-21T16:36:39 <dreimark> W:1161:JinjaTheme.sidebar: Redefining built-in 'buffer'
114 2010-06-21T16:38:01 <dreimark> C: 92:JinjaTheme.translated_item_name: Operator not preceded by a space item_lang_request= request.getText(item_en)
115 2010-06-21T17:01:01 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8356:d320dde25e7f 2.0-dev/MoinMoin/items/__init__.py: items: for modifying item, filter out metadata that is determined otherwise on save
116 2010-06-21T17:01:03 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8357:02806b437c4b 2.0-dev/MoinMoin/macro2/Date.py: merged main
117 2010-06-21T17:02:17 <dreimark> valeuf: please use logging instead of print http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/rev/5b9acac86fcb#l1.7
118 2010-06-21T17:07:49 <dreimark> http://hg.moinmo.in/moin/2.0-dev-docbook-html-vjaniaut/file/5b9acac86fcb/MoinMoin/converter2/html_in.py#l352 explain
119 2010-06-21T17:11:29 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8358:b701bb6683ee 2.0-dev/MoinMoin/items/__init__.py: items: DummyRev: implement seek/tell, fix read to fix creation of new AnyWikiDraw items
120 2010-06-21T17:19:31 <dreimark> valeuf: we need to discuss but at least me didn't like default values of {} or []
121 2010-06-21T17:19:47 <dreimark> a description what can go wrong
122 2010-06-21T17:19:53 <dreimark> http://garybernhardt.blogspot.com/2006/12/default-arguments-are-tricky.html
123 2010-06-21T17:20:23 <dreimark> def handle_input(self, input, args=None):
124 2010-06-21T17:20:35 <dreimark> args = args or {}
125 2010-06-21T17:21:54 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8359:35bb5dd48d94 2.0-dev/MoinMoin/items/__init__.py: twikidraw/anywikidraw: give metadata editor size to 'modify' template
126 2010-06-21T17:27:14 *** grzywacz
127 2010-06-21T17:32:06 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8360:2356e673ed2b 2.0-dev/MoinMoin/items/__init__.py: item editor: use constants for meta/data editor size, increase metadata editor rows
128 2010-06-21T17:42:41 <ThomasWaldmann> hmm, trail stuff is too complicated for what it does
129 2010-06-21T17:43:06 <ThomasWaldmann> we have trail_size (config only), and show_trail (userprefs checkbox)
130 2010-06-21T17:44:05 <ThomasWaldmann> i think it either should be just trail_size (config AND userprefs field to set length) and no show_trail (trail_size = 0 is same as not show_trail)
131 2010-06-21T17:44:11 <ThomasWaldmann> OR
132 2010-06-21T17:44:40 <ThomasWaldmann> we kill it completely and let the theme determince trail size and whether it shows one or not
133 2010-06-21T17:45:07 <dreimark> trail_size = 0
134 2010-06-21T17:45:19 <dreimark> for None
135 2010-06-21T17:45:53 <dreimark> it is a short navigation history, some like it some not
136 2010-06-21T17:46:24 <ThomasWaldmann> so we need an integer on userprefs for it?
137 2010-06-21T17:46:51 <ThomasWaldmann> TheSheep: ^^
138 2010-06-21T17:52:36 <valeuf> dreimark: thank for your feedback
139 2010-06-21T17:55:09 <valeuf> for the regsitry stuff,
140 2010-06-21T17:55:21 <valeuf> this is the code to regsiter the converter in to the factory
141 2010-06-21T17:55:35 <valeuf> you can check the other converter, they have similar code at the end
142 2010-06-21T17:55:55 <valeuf> for the default value {} and [], what would you do instead ?
143 2010-06-21T18:02:27 *** xorAxAx
144 2010-06-21T18:05:46 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8361:7655ae9223fc 2.0-dev/MoinMoin/ (3 files in 3 dirs): change cfg.url_prefix_fckeditor to ..._ckeditor, use it in the template
145 2010-06-21T18:06:47 <ThomasWaldmann> waldi: i currently use text/html mimetype for unsafe html, text/x-safe-html for "safe html"
146 2010-06-21T18:07:17 <ThomasWaldmann> safe html = processed with some filtering of dangerous tags
147 2010-06-21T18:07:35 <ThomasWaldmann> first works, second seems broken
148 2010-06-21T18:08:25 <ThomasWaldmann> shall we use that text/x-safe-html mimetype or do you have a better idea how to steer the different processing?
149 2010-06-21T18:11:25 *** xorAxAx
150 2010-06-21T18:14:31 <waldi> ThomasWaldmann: is text/html also rendered into a theme currently?
151 2010-06-21T18:15:12 <waldi> ah, yes. this is handled with the old text/html parser
152 2010-06-21T18:16:03 <waldi> while none exists for the safe variant.
153 2010-06-21T18:16:44 <waldi> i would start with some types for xml-encoded html (application/html+xml) because this can use the cheaper xml parser
154 2010-06-21T18:16:49 <dreimark> valeuf: see the example
155 2010-06-21T18:17:03 <dreimark> 17:20 < dreimark> def handle_input(self, input, args=None):
156 2010-06-21T18:17:54 <valeuf> dreimark: ok got it, sorry I sread it quickly
157 2010-06-21T18:18:17 <valeuf> dreimark: I add that to my ToDo list, and quite busy with exams, but I am going to fix that on next Thursday
158 2010-06-21T18:18:36 <dreimark> it makes reviewing of code easier if we don't need to check for problems like that
159 2010-06-21T18:19:56 <dreimark> bbl
160 2010-06-21T19:18:27 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8362:2fa3140fa03c 2.0-dev/MoinMoin/ (log.py wsgiapp.py): exception.message is deprecated in py2.6, reenable warning about string exceptions
161 2010-06-21T19:24:11 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8363:06cccffdcf65 2.0-dev/MoinMoin/log.py: reenable popen-module warning
162 2010-06-21T19:42:31 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8364:123d0c1138b6 2.0-dev/MoinMoin/util/ (__init__.py filesys.py lock.py): remove support code and comments for windows versions not supported by py2.6
163 2010-06-21T19:45:55 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8365:4668724e0304 2.0-dev/MoinMoin/util/filesys.py: remove filesys.realPathCase - not used any more
164 2010-06-21T20:04:05 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8366:d33db86e5a59 2.0-dev/MoinMoin/wikiutil.py: wikiutil: remove cgi and urllib imports, use werkzeug instead of urllib
165 2010-06-21T20:42:37 * ThomasWaldmann cleans up in wikiutil
166 2010-06-21T20:51:52 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8367:80f79362bd49 2.0-dev/MoinMoin/ (4 files in 3 dirs): (log message trimmed)
167 2010-06-21T20:51:52 <CIA-49> wikiutil: remove url_quote, url_quote_plus, url_unquote (werkzeug has better stuff)
168 2010-06-21T20:51:52 <CIA-49> Typically needed change:
169 2010-06-21T20:51:52 <CIA-49> -from MoinMoin import wikiutil
170 2010-06-21T20:51:52 <CIA-49> +import werkzeug
171 2010-06-21T20:51:53 <CIA-49> +from MoinMoin import config
172 2010-06-21T20:51:53 <CIA-49> - wikiutil.url_quote(x)
173 2010-06-21T21:26:06 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8368:46de085b8012 2.0-dev/MoinMoin/ (converter2/moinwiki_in.py wikiutil.py): deprecate wikiutil.makeQueryString/parseQueryString, use werkzeug.url_encode/url_decode in new code
174 2010-06-21T21:27:54 <ei-grad> dreimark: i removed encoding because of it is done in LDAPConnection.get_connection http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/d14637b92742/MoinMoin/util/ldap_connection.py#l137
175 2010-06-21T21:28:51 <ThomasWaldmann> waldi: see last changeset ^^ do we want url_encode in Iri, when it gets a dict as query?
176 2010-06-21T21:33:14 <waldi> Iri is designed as implementation of the rfc, it have to be able to parse all syntactically valid Iris. the query string is opaque in this spec. we can subclass Iri and extend it the way we want it to work for our urls
177 2010-06-21T21:46:25 <ei-grad> i have a problem with mercurial, accidentally made the second head in the local repository, and do not know how to remove it http://paste.pocoo.org/show/228167/
178 2010-06-21T21:46:35 <waldi> ei-grad: hg rebase?
179 2010-06-21T21:46:39 <waldi> or merge
180 2010-06-21T21:47:01 <ei-grad> http://paste.pocoo.org/show/228168/
181 2010-06-21T21:47:06 <ei-grad> merge ^^
182 2010-06-21T21:47:34 <waldi> well, if you like non-linear history, then yes
183 2010-06-21T21:48:04 <ei-grad> i don't like
184 2010-06-21T21:52:57 <ThomasWaldmann> try to not push a mess to your public repo
185 2010-06-21T21:54:45 <ei-grad> of course, i think i will remove local repo and clone it again from server...
186 2010-06-21T21:55:24 <waldi> ei-grad: why?
187 2010-06-21T21:55:28 <ThomasWaldmann> diofeher: i miss some changesets from you
188 2010-06-21T21:57:31 <ei-grad> waldi: i am not too familar with mercurial to resolve this problem (i don't understand fully what happened)
189 2010-06-21T21:58:06 <waldi> ei-grad: you pulled from a repository that had already more commits then yours
190 2010-06-21T21:58:14 <ei-grad> yes
191 2010-06-21T22:00:04 <ei-grad> more corretly, i pulled into a repository that had a commit that does not exist in a repository from which i pulled
192 2010-06-21T22:00:48 <ei-grad> is there a way to rollback pull operation, and then rollback that commit?
193 2010-06-21T22:02:39 <xorAxAx> valeuf: what did ya do today? :)
194 2010-06-21T22:07:26 <waldi> ei-grad: hg rollback may do something
195 2010-06-21T22:10:04 <ThomasWaldmann> only one change
196 2010-06-21T22:10:20 * ei-grad reading http://mercurial.selenic.com/wiki/PruningDeadBranches
197 2010-06-21T22:11:12 <ThomasWaldmann> ei-grad: before next push, you check with hg out what it would transfer and whether you really want that
198 2010-06-21T22:22:05 <CIA-49> Andrew Grigorev <andrew@ei-grad.ru> default * 5714:8b54d11a843c 1.9-ldap-kerberos-agrigorev/MoinMoin/datastruct/backends/ldap_groups.py: [LDAP2010] missed tls_keyfile
199 2010-06-21T22:26:47 *** RogerHaase
200 2010-06-21T22:29:42 <dreimark> re
201 2010-06-21T22:29:52 <ei-grad> hi dreimark
202 2010-06-21T22:30:19 <dreimark> ei-grad: do you have seen my second question too?
203 2010-06-21T22:30:38 <ei-grad> about?
204 2010-06-21T22:31:00 <ei-grad> oh, ok
205 2010-06-21T22:31:09 <dreimark> 16:22 < dreimark> ei-grad: in ldap_groups.py you don't use tls_keyfile as you do in ldap_login.py
206 2010-06-21T22:31:27 <dreimark> ThomasWaldmann ha explained me the encoding change
207 2010-06-21T22:32:14 <dreimark> ei-grad: i see
208 2010-06-21T22:32:18 <dreimark> 22:22 < CIA-49>
209 2010-06-21T22:32:32 <dreimark> me was reading backlog and asking before I was at the end
210 2010-06-21T22:33:00 <dreimark> s/end/bottom/
211 2010-06-21T22:34:27 <dreimark> ei-grad: i would prefer commit message sounding more positive or just a sentence.
212 2010-06-21T22:34:45 <dreimark> e.g. [LDAP2010] missed tls_keyfile
213 2010-06-21T22:35:11 <dreimark> for example i need to read the cs to get that you added it
214 2010-06-21T22:35:41 <dreimark> or e.g. [LDAP2010] bind_once not needed for LDAPGroups
215 2010-06-21T22:35:53 <dreimark> you can explain why it is not needed
216 2010-06-21T22:35:55 <valeuf> xorAxAx: I have exam until Thursday as I explained, so I won't have time to work this week, but I will wrek hard this week-end to recover ^ ^
217 2010-06-21T22:36:04 <xorAxAx> valeuf: indeed :)
218 2010-06-21T22:36:28 <valeuf> xorAxAx: but feel you free to review my previous code, and add comments about it
219 2010-06-21T22:36:42 <ei-grad> dreimark: it should be like 'added missed tls_keyfile parameter for LDAPConnection' and 'removed not needed bind_once parameter from LDAPGroups'?
220 2010-06-21T22:36:50 <valeuf> xorAxAx: or check my equivalences http://moinmo.in/DOM%20DocBook%20and%20HTML%202010/HTML-DOM%20Equivalences
221 2010-06-21T22:36:53 <xorAxAx> valeuf: yes, thats planned :)
222 2010-06-21T22:37:18 <valeuf> great :) I am always happy with code review ... even if sometimes I realized that my code is crappy ...
223 2010-06-21T22:37:51 <dreimark> first yes, for the second it would be good to know why it is not needed
224 2010-06-21T22:38:01 <dreimark> ei-grad: ^
225 2010-06-21T22:38:36 <dreimark> because now the question is if there is another reason to remove it as deprecated?
226 2010-06-21T22:39:01 <ei-grad> hm... how to say, 'it is not needed because that it was not ever needed'?
227 2010-06-21T22:40:09 <dreimark> ok. i understand it now.
228 2010-06-21T22:40:42 <dreimark> and we have it now in the dev log.
229 2010-06-21T22:41:15 <dreimark> but from some changes and not detailed commit messages i did in the past i knoe
230 2010-06-21T22:41:20 <dreimark> know*
231 2010-06-21T22:41:41 <dreimark> it is not easy to remember why one changed the api
232 2010-06-21T22:41:51 <dreimark> or removed functionality
233 2010-06-21T22:42:12 <dreimark> the easiest way to find informations is the commit string
234 2010-06-21T22:42:34 <dreimark> if you look at annotate you find the cs which may be responsible
235 2010-06-21T22:42:34 <ei-grad> ok, i understand, will try to produce more information in commit messages
236 2010-06-21T22:42:56 <dreimark> thx
237 2010-06-21T22:47:12 <CIA-49> Andrew Grigorev <andrew@ei-grad.ru> default * 5715:131103bed099 1.9-ldap-kerberos-agrigorev/MoinMoin/util/_tests/test_ldap_connection.py: [LDAP2010] removed unused imports from test_ldap_connection.py
238 2010-06-21T22:49:09 <dreimark> ei-grad: http://hg.moinmo.in/moin/1.9-ldap-kerberos-agrigorev/file/8b54d11a843c/wiki/config/more_samples/ldap_wikiconfig_snippet#l1
239 2010-06-21T22:49:20 <dreimark> please adjust
240 2010-06-21T22:49:42 <dreimark> it is more than about auth
241 2010-06-21T22:50:50 <dreimark> group_name_format='%sGroup', # a format string to get MoinMoin group name
242 2010-06-21T22:51:20 <dreimark> this is dependent from the page_group_regex
243 2010-06-21T22:54:56 *** RogerHaase
244 2010-06-21T23:13:26 <ei-grad> what to do with group_name_format? i asked some time ago how to get MoinMoin group name from LDAP group name, but didn't got the answer iirc... :-(
245 2010-06-21T23:17:48 <dreimark> ei-grad: this name is for setting in acls and for showing up in e.g. SystemAdmin do user browser?
246 2010-06-21T23:19:12 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8369:c378eda727c5 2.0-dev/MoinMoin/ (items/__init__.py web/request.py): item URLs: sort querystring with do= first and from_tar= last
247 2010-06-21T23:20:37 <dreimark> ei-grad: i think i haven't got in the past the question - sorry
248 2010-06-21T23:22:46 <dreimark> hmm, not sure yet but at least you should give a hint that one wants to set it similiar to the regex
249 2010-06-21T23:23:33 <dreimark> what i am not sure about is who serves if one sets up moin groups and ldap groups
250 2010-06-21T23:23:45 <dreimark> is there an order defined?
251 2010-06-21T23:37:35 <ei-grad> hm... i remembered... i needed this for LDAPGroups.__iter__, and ThomasWaldmann said me to check, where it is used...
252 2010-06-21T23:37:45 <ei-grad> ok, i'll add a hint
253 2010-06-21T23:37:47 <ei-grad> bbl
254 2010-06-21T23:44:41 <CIA-49> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 8370:4f66ccc88f7d 2.0-dev/MoinMoin/ (items/__init__.py user.py): getting rid of most url_quote usage in the py code (use request.(abs_)href!)
255 2010-06-21T23:55:56 *** RogerHaase
256
