1 2010-06-04T00:05:39 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5678:4fe9951788cb 1.9/MoinMoin/action/SlideShow.py: Fixing issue similiar to MoinMoinBugs/1.9.2XSSTemplateParameter
2 2010-06-04T00:05:41 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5679:e50b087c4572 1.9/MoinMoin/ (14 files in 2 dirs):
3 2010-06-04T00:05:41 <CIA-47> merge moin/1.7
4 2010-06-04T00:05:41 <CIA-47> Fixing security issues related to MoinMoinBugs/1.9.2UnescapedInputForThemeAddMsg (possible XSS)
5 2010-06-04T00:05:46 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5680:8604ed2e370c 1.9/ (3 files in 2 dirs): Merge.
6 2010-06-04T00:05:54 <eSyr> uuh
7 2010-06-04T00:06:13 <eSyr> hg is totally unusual for me.
8 2010-06-04T00:06:34 <ThomasWaldmann> you need to use it more often :D
9 2010-06-04T00:06:36 <eSyr> after git hg's logic looks rather strange.
10 2010-06-04T00:07:00 <eSyr> i thinking about finally configuring githg >:3
11 2010-06-04T00:09:19 <eSyr> sad part is there 3 pages (plus one untranslated and 2 poorly translated) which still need translation update.
12 2010-06-04T00:10:11 <eSyr> and looks like i will have not finish thtem till 1.9.3 release.
13 2010-06-04T00:13:04 <valeuf> waldi: so is there a solution to test my converte with data from wiki
14 2010-06-04T00:13:06 <valeuf> ?
15 2010-06-04T00:13:24 <waldi> valeuf: write your own item for now
16 2010-06-04T00:13:37 <valeuf> waldi: where is the code for that L
17 2010-06-04T00:13:38 <valeuf> ?
18 2010-06-04T00:14:03 <waldi> MoinMoin.items
19 2010-06-04T00:15:39 <valeuf> waldi: ok thanks, I will have a look about that
20 2010-06-04T00:20:02 <ThomasWaldmann> dreimark: http://paste.pocoo.org/show/221656/
21 2010-06-04T00:20:12 <ThomasWaldmann> you'll need something like this ^^
22 2010-06-04T00:23:52 <eSyr> ThomasWaldmann: tfor many languages there are messages "List of pages with same master-page", like on this page: http://master19.moinmo.in/4ct10n/CheckTranslation/ГлавнаяСтраница?action=CheckTranslation&pageset=all_pages&language=cs
23 2010-06-04T00:24:07 <eSyr> Can fixing this be automated via gettext somehow?
24 2010-06-04T00:24:35 <eSyr> (i don't like idea to parse .po's manually)
25 2010-06-04T00:26:05 <ThomasWaldmann> i don't understand the problem
26 2010-06-04T00:26:37 <eSyr> ThomasWaldmann: the problem is: translated page names doesn't written down in po files.
27 2010-06-04T00:26:40 <dreimark> ThomasWaldmann: ok, i work on it after some sleep ;)
28 2010-06-04T00:27:51 <dreimark> eSyr: they are missing?
29 2010-06-04T00:28:53 <dreimark> but they are in the en po file?
30 2010-06-04T00:29:34 <eSyr> dreimark: the opposite: they are exist but haven't mentioned in po as msgstr of appropriate msgids.
31 2010-06-04T00:29:47 <ThomasWaldmann> eSyr: msgmerge?
32 2010-06-04T00:29:52 <eSyr> *hm.
33 2010-06-04T00:30:06 <eSyr> generate po and msgmerge?
34 2010-06-04T00:30:10 <eSyr> good idea.
35 2010-06-04T00:32:23 <dreimark> but that is a bit strange to me check_i18n should find all calls of _()
36 2010-06-04T00:32:42 <dreimark> so we should have en strings to translate
37 2010-06-04T00:33:33 <dreimark> and if we have more than those then they may be obsolete
38 2010-06-04T00:34:11 <eSyr> dreimark: sorry, i haven't understand your idea.
39 2010-06-04T00:34:59 <dreimark> eSyr: me wonders why they exists but there are not mentioned in the po file
40 2010-06-04T00:35:26 <ThomasWaldmann> because noone cares about the po
41 2010-06-04T00:35:32 <dreimark> it could be that check_i18n is broken because it hasn't found them before
42 2010-06-04T00:36:09 <eSyr> dreimark: funding those is rather magic.
43 2010-06-04T00:36:43 <eSyr> because there are no links to pages, because they are not mentioned in po as msgstrs.
44 2010-06-04T00:37:10 <eSyr> Assumption made by CheckTranslation is based on master-page and translatetd page language.
45 2010-06-04T00:39:03 <eSyr> well, looks like another feature to CheckTranslate - update po files with missed page name msgstrs.
46 2010-06-04T00:39:09 <dreimark> http://hg.moinmo.in/moin/1.9/file/8604ed2e370c/MoinMoin/i18n/tools/check_i18n.py#l82
47 2010-06-04T00:39:19 <dreimark> ignore the line
48 2010-06-04T00:39:34 <dreimark> i meant that script
49 2010-06-04T00:40:16 <dreimark> i mean they must be somewhere in the code user as _('something')
50 2010-06-04T00:40:29 <dreimark> and then the script should find them
51 2010-06-04T00:40:55 *** grzywacz
52 2010-06-04T00:41:02 <dreimark> s/user/used
53 2010-06-04T00:42:00 <dreimark> gn
54 2010-06-04T00:42:06 <eSyr> dreimark: we have page 'BlaBla' with #master-page WikiWikiWeb and #langluage bla, and bla.po has empty msgstr at msgid "WikiWikiWeb". How check_i18n can help with finding out that we should set msgstr to "BlaBla"?
55 2010-06-04T00:42:36 <eSyr> gn
56 2010-06-04T00:42:45 * dreimark dreams from that
57 2010-06-04T00:43:38 <dreimark> i was believing that we don't have a missing msgid for WikiWikiWeb
58 2010-06-04T00:44:13 <dreimark> i think my conflict occures because of a misunderstanding as i asked if the string is in the en po file
59 2010-06-04T00:45:16 <dreimark> now it is clear
60 2010-06-04T00:46:14 <dreimark> anyway - sleep now
61 2010-06-04T00:53:06 <eSyr> gn
62 2010-06-04T00:54:13 <eSyr> hm, i'd like to integrate into CheckTranslation color table for displaying status of all translations.
63 2010-06-04T01:03:07 *** grzywacz
64 2010-06-04T01:20:40 *** vpv
65 2010-06-04T02:16:19 *** RogerHaase
66 2010-06-04T04:39:07 *** DmitryAndreev
67 2010-06-04T08:38:15 <ThomasWaldmann> moin
68 2010-06-04T08:56:18 <ThomasWaldmann> eSyr: how comes that the xss fix changeset from 1.8 is not contained in 1.9?
69 2010-06-04T08:56:57 <ThomasWaldmann> (if one pulls, usually the changesets are transferred and followed by a merge changeset - but there is only the merge changeset)
70 2010-06-04T08:59:29 <ThomasWaldmann> http://hg.moinmo.in/moin/1.8/rev/37306fba2189 and http://hg.moinmo.in/moin/1.7/rev/37306fba2189
71 2010-06-04T08:59:40 <dreimark> moin
72 2010-06-04T09:56:32 <dreimark> eSyr: ThomasWaldmann http://hg.moinmo.in/moin/1.9/file/8604ed2e370c/MoinMoin/action/RenamePage.py#l120
73 2010-06-04T09:56:37 <dreimark> merge conflicts ß
74 2010-06-04T09:56:38 <dreimark> ?
75 2010-06-04T10:06:00 *** DmitryAndreev
76 2010-06-04T10:22:40 <dreimark> ei-grad: please don't merge 1.9 until eSyr fixed the merge issue
77 2010-06-04T10:36:32 *** vpv
78 2010-06-04T11:10:50 <valeuf> hard to find how to test htmtl conversion directly on the wiki ...
79 2010-06-04T11:22:47 <eSyr> moin
80 2010-06-04T11:23:38 <eSyr> oops, sorry.
81 2010-06-04T11:23:52 <eSyr> my fault.
82 2010-06-04T11:28:45 <valeuf> success :) I got my converter working in MoinMoin :)
83 2010-06-04T11:29:54 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5681:60fde500cbc2 1.9/MoinMoin/action/RenamePage.py:
84 2010-06-04T11:29:54 <CIA-47> Fixing unclean merge
85 2010-06-04T11:29:54 <CIA-47> /me failed at merging
86 2010-06-04T11:43:07 <CIA-47> Valentin Janiaut <valentin.janiaut@utbm.fr> default * 8251:21b1254c6f2a 2.0-dev-docbook-html-vjaniaut/MoinMoin/ (converter2/html_in.py items/__init__.py): Add a new mimetype for HTML converted in DOM Tree
87 2010-06-04T11:44:06 <valeuf> wow, not big change, but it took me a while !
88 2010-06-04T12:06:01 <eSyr> valeuf: when working with big (and relatively unknown) codebase, not all work can be represented in diffs, because there are no diff of acquired knowledge during this work.
89 2010-06-04T12:06:14 <valeuf> ?
90 2010-06-04T12:07:08 *** DmitryAndreev
91 2010-06-04T12:07:08 <eSyr> yes, that is.
92 2010-06-04T12:11:07 <valeuf> ah I understand :) well, understanding big chunk of code can take time, even if at the end you change almost nothing,
93 2010-06-04T12:11:34 <valeuf> anyway I hope that nobody measure the performance according to the size of the diffs !
94 2010-06-04T12:19:09 <waldi> okay, where to put a todo list for the overall converter infrastructure? i have some points with questionable design decisions i made that may need further input. and also the points that needs global fixes
95 2010-06-04T12:20:01 <valeuf> yep, I have also some thoughts about converters2
96 2010-06-04T12:21:13 <valeuf> we probably need tu create : http://moinmo.in/MoinMoin2.0/Converters
97 2010-06-04T12:26:25 *** DmitryAndreev_
98 2010-06-04T12:59:28 *** elmo
99 2010-06-04T14:05:43 *** DmitryAndreev_
100 2010-06-04T14:35:37 <dreimark> do we have something which finds not used attachments of a page?
101 2010-06-04T14:37:10 <ThomasWaldmann> define "not used"
102 2010-06-04T14:37:43 <dreimark> not linked or not transcluded on the page
103 2010-06-04T14:38:28 <ThomasWaldmann> well, even if we had that, what do you get? users can just use AttachFile and "use" the files
104 2010-06-04T14:38:58 <TheSheep> something like OrphanedPages for attachments
105 2010-06-04T14:39:29 <TheSheep> orphaned pages also may be linked from outside, from recent changes (as author) or found with search
106 2010-06-04T14:39:39 <TheSheep> still it's useful to have a list of them
107 2010-06-04T14:41:09 <ThomasWaldmann> see how good the orphaned pages list works
108 2010-06-04T14:41:36 <dreimark> me needs that because i want to delete the orphaned attachments
109 2010-06-04T14:41:45 <eSyr> ThomasWaldmann: what for? Something wrong with it?
110 2010-06-04T14:42:19 <ThomasWaldmann> it can't read wiki users' mind :)
111 2010-06-04T14:42:53 <TheSheep> don't, let the users decide, just provide them with information that you can get
112 2010-06-04T14:43:06 <ThomasWaldmann> e.g. if you auto-create a list of subpages via search function, that's pretty ok for some use cases, but the pages are not officially linked then and considered orphan
113 2010-06-04T14:43:37 <ThomasWaldmann> so, if you do that, you get a huge unusable list of orphaned pages
114 2010-06-04T14:43:54 <TheSheep> ThomasWaldmann: for every possible solution there is at least one plausible use case where that doesn't work. This doesn't mean the solution should be removed.
115 2010-06-04T14:44:34 <TheSheep> ThomasWaldmann: as it still works for many other use cases
116 2010-06-04T14:44:51 <ThomasWaldmann> also, it is wasted effort (we didn't have orphaned attachments for moin since 10 years and if one implements that now, one can just throw it away for moin2)
117 2010-06-04T14:45:31 <TheSheep> this is a better argument :)
118 2010-06-04T14:46:19 <dreimark> it was just a question if someone has something like that already
119 2010-06-04T14:47:01 <dreimark> didn't want to add that to official codebase because of ^^
120 2010-06-04T14:49:05 <ThomasWaldmann> btw, for moin2, do we already have "this item links to / transcludes item X" infrastructure?
121 2010-06-04T14:49:43 <ThomasWaldmann> I mean that the converters can collect links (and update some linksto cache / metadata)?
122 2010-06-04T14:50:13 <TheSheep> this is the responsibility of indexer, isn't it?
123 2010-06-04T14:50:38 <ThomasWaldmann> yes and no :)
124 2010-06-04T14:51:01 <ThomasWaldmann> it is kind of metadata, so yes, it is for metadata indexer
125 2010-06-04T14:51:30 <ThomasWaldmann> but the metadata indexer itself does not know what markup is used to link/transclude, so this must be provided by converter2
126 2010-06-04T14:51:50 <TheSheep> doesn't it get the dom tree anyways?
127 2010-06-04T14:52:21 <ThomasWaldmann> currently it just sits on the storage
128 2010-06-04T14:52:44 <ThomasWaldmann> (at two places: on top of router middleware, on top of final storage backend)
129 2010-06-04T14:53:10 <TheSheep> looks like it needs a thrid place :)
130 2010-06-04T14:53:34 <ThomasWaldmann> X)
131 2010-06-04T14:54:20 <ThomasWaldmann> eSyr: did you pull 1.7 -> 1.8, merge, pull 1.8 -> 1.9, merge?
132 2010-06-04T14:55:11 <eSyr> ThomasWaldmann: no, i did pull 1.7 -> 1.9
133 2010-06-04T14:55:20 <ThomasWaldmann> oh
134 2010-06-04T14:55:38 <ThomasWaldmann> but even then, whey is that changeset missing?
135 2010-06-04T14:55:42 <ThomasWaldmann> -e
136 2010-06-04T14:55:57 <eSyr> hm.
137 2010-06-04T14:57:50 <eSyr> err, which changeset?
138 2010-06-04T14:58:13 <eSyr> http://hg.moinmo.in/moin/1.7/rev/37306fba2189 this?
139 2010-06-04T14:59:02 <ThomasWaldmann> yes
140 2010-06-04T14:59:29 <eSyr> well, i don't know. I did pull, merge, fixed conflicts, clear conflict marks (resolve -m) and commit.
141 2010-06-04T15:00:07 <ThomasWaldmann> eSyr: please pull 1.8 into 1.9 and merge again
142 2010-06-04T15:00:12 <eSyr> may be i misunderstood hg merging process.
143 2010-06-04T15:00:14 <eSyr> ok.
144 2010-06-04T15:00:17 <ThomasWaldmann> (because that is the usual way)
145 2010-06-04T15:08:57 <ThomasWaldmann> huh x.moin.html?
146 2010-06-04T15:09:09 <dreimark> hmm?
147 2010-06-04T15:09:24 <ThomasWaldmann> valeuf: ^^ why that mimetype?
148 2010-06-04T15:09:47 <valeuf> ThomasWaldmann: heuh :p
149 2010-06-04T15:09:55 <ThomasWaldmann> ah, i read it in next diff
150 2010-06-04T15:10:09 <valeuf> ThomasWaldmann: this is temporary until we can use html mimetype
151 2010-06-04T15:10:33 <ThomasWaldmann> well, there is still the question why not now use the correct type
152 2010-06-04T15:10:39 <valeuf> ThomasWaldmann: I choose that because the html will be converted into the moin DOM tree
153 2010-06-04T15:11:14 <valeuf> ThomasWaldmann: waldi suggested to me to use another Item with specific mimetype (If I understood well) at this time
154 2010-06-04T15:11:18 <ThomasWaldmann> that is rather kind of processing than mimetype
155 2010-06-04T15:11:28 <ThomasWaldmann> ok
156 2010-06-04T15:11:50 <valeuf> yep, actually I think I did not undersand him well, there is probably a solution to do same with html mimetype
157 2010-06-04T15:13:26 <valeuf> anyway I think we should discuss all the elegant way to use the different converter we are writing (Dmitry and me)
158 2010-06-04T15:13:52 <valeuf> but at least I could see how is working conversion from the wiki
159 2010-06-04T15:15:18 <valeuf> ThomasWaldmann: especially I want to see how the converter is working with big HTML page from others website
160 2010-06-04T15:15:51 <ThomasWaldmann> yes, that'll get interesting :D
161 2010-06-04T15:16:30 <valeuf> ThomasWaldmann: but at least I think that the converter will be perfect to use the HTML output from the WYSIWG editor
162 2010-06-04T15:16:41 <ThomasWaldmann> when (x)html > dom > wiki (or rest or docbook) starts working, you can also try the CKeditor
163 2010-06-04T15:17:01 <valeuf> exactly ^ ^
164 2010-06-04T15:17:39 <valeuf> (it should work with other editor, link my favorite one : WYMEditor)
165 2010-06-04T15:39:01 <waldi> valeuf: i added several things to http://moinmo.in/MoinMoin2.0/Converters
166 2010-06-04T15:40:44 <valeuf> waldi: great, I will see to add my thought on this page later
167 2010-06-04T15:42:16 <eSyr> ThomasWaldmann: 'abort: /data/programs/moin.hg-1.9/wiki/underlay.tar looks like a binary file.' what can be done with this?
168 2010-06-04T15:44:41 <ThomasWaldmann> don't change it
169 2010-06-04T15:45:09 * ThomasWaldmann bbl
170 2010-06-04T16:22:41 <diofeher> moin
171 2010-06-04T16:50:40 *** RogerHaase
172 2010-06-04T16:55:34 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5687:bf0b4b96dcb4 1.9/ (15 files in 4 dirs): Merged moin/1.8
173 2010-06-04T17:00:57 <eSyr> finally.
174 2010-06-04T17:01:17 <eSyr> the problem was there: http://comments.gmane.org/gmane.comp.version-control.mercurial.general/20122
175 2010-06-04T17:01:52 <eSyr> (and commit log looks a bit strange: one of last changes to underlay looks like from 1.8, but in tip the correct underlay in place)
176 2010-06-04T17:08:08 <RogerHaase> How should I be restarting wikiserver.bat under Windows/7? If I change a .py file in a subdirectory (MoinMoin/parser/text.py) and stop and restart wikiserver.bat, the changed text.py is not loaded. If I delete /MoinMoin/Page.pyc, and then stop and restart wikiserver.bat, the changed text.py is loaded.
177 2010-06-04T17:32:14 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5688:80c5a662e132 1.9/MoinMoin/action/RenamePage.py: Preventing RenamePage action from throwing exception due to abscence of configuration option show_rename_redirect.
178 2010-06-04T18:20:47 *** grzywacz
179 2010-06-04T18:40:40 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8243:db5aa4b9b44e 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (4 files in 3 dirs): [templating] Themebase.actionsMenu is now rendered with Jinja2
180 2010-06-04T18:58:07 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8244:37e6ca121c7a 2.0-dev-jinja2-plugins-dfeher/MoinMoin/templates/actions_menu.html: [templating] fixed html error in actions_menu.html
181 2010-06-04T18:58:09 <CIA-47> Diogenes Augusto <diofeher@gmail.com> default * 8245:3857ed03877b 2.0-dev-jinja2-plugins-dfeher/MoinMoin/ (templates/head.html theme/jinja.py):
182 2010-06-04T18:58:09 <CIA-47> [templating
183 2010-06-04T18:58:09 <CIA-47> ] fixed a error in Theme and changed html_head to rendering in template with Jinja2
184 2010-06-04T19:04:00 <diofeher> ops, sorry for the linebreak
185 2010-06-04T19:13:14 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 3896:f8871116c6b3 1.7/MoinMoin/action/login.py: Fixed missed wikiutil module import.
186 2010-06-04T19:14:44 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 4508:bb27a4b9dfe3 1.8/MoinMoin/action/login.py:
187 2010-06-04T19:14:44 <CIA-47> Merged moin/1.7
188 2010-06-04T19:14:44 <CIA-47> Fixed missed wikiutil module import.
189 2010-06-04T19:17:05 <CIA-47> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5691:282ff1a50c4d 1.9/MoinMoin/action/login.py:
190 2010-06-04T19:17:05 <CIA-47> Merged moin/1.8
191 2010-06-04T19:17:05 <CIA-47> Fixed missed wikiutil module import.
192 2010-06-04T20:00:55 *** vpv
193 2010-06-04T20:04:16 *** JosefMeier
194 2010-06-04T20:06:40 *** JosefMeier
195 2010-06-04T20:10:04 <ThomasWaldmann> re
196 2010-06-04T20:11:04 *** vpv
197 2010-06-04T20:11:10 <diofeher> ThomasWaldmann: what it means 're'? :P
198 2010-06-04T20:11:17 *** DmitryAndreev
199 2010-06-04T20:11:26 <ThomasWaldmann> RogerHaase: iirc, python usually looks at whether the .py is newer than .pyc and if you, it loads the py
200 2010-06-04T20:12:43 <ThomasWaldmann> diofeher: irc abbreviation for re-enter, returned, ...
201 2010-06-04T20:13:31 <ThomasWaldmann> http://www.irc-faq.de/irc-slang.php
202 2010-06-04T20:18:25 <diofeher> hehe nice, didn't know
203 2010-06-04T20:20:15 <RogerHaase> ThomasWaldmann: That works if I change something in the MoinMoin directory, but not in the MoinMoin/parser directory. Do you need to stop and restart the server under Linux, or does it use polling to notice changes?
204 2010-06-04T20:27:02 *** DmitryAndreev
205 2010-06-04T20:48:19 *** DmitryAndreev
206 2010-06-04T21:22:25 <ThomasWaldmann> RogerHaase: if you change code, you need to restart the moin process
207 2010-06-04T21:22:39 <ThomasWaldmann> but, you shouldn't need to remove .pyc manually
208 2010-06-04T21:43:45 <RogerHaase> ThomasWaldmann: Ok, I think I should load the repository on a Ubuntu system and see how it works there in comparison to Windows. In the meantime, I will change my wikiserver.bat file to delete Page.pyc to force a reload.
209 2010-06-04T21:48:45 *** grzywacz
210 2010-06-04T22:01:13 *** grzywacz
211 2010-06-04T22:32:36 <ThomasWaldmann> eSyr: http://hg.moinmo.in/moin/1.9/rev/80c5a662e132
212 2010-06-04T22:32:45 <ThomasWaldmann> why that?
213 2010-06-04T23:52:34 *** grzywacz
214
