1 2010-04-04T00:01:14 <ThomasWaldmann> the question then also will be whether the double click editing should be enabled by default
2 2010-04-04T00:01:24 <ThomasWaldmann> otherwise anon users won't get it
3 2010-04-04T00:08:37 <ThomasWaldmann> hmm, doesn't work currently
4 2010-04-04T00:33:26 *** JosefMeier
5 2010-04-04T00:33:35 *** JosefMeier
6 2010-04-04T00:39:46 <dreimark> i haven't tried that patch yet.
7 2010-04-04T00:40:31 <ThomasWaldmann> last time i tried, it worked, but that was at the demo site
8 2010-04-04T00:40:57 <dreimark> i think we should not change the double click behaviour
9 2010-04-04T00:41:22 <dreimark> anon users should setup an account
10 2010-04-04T00:41:36 <ThomasWaldmann> then it will require some non-trivial configuration if you want to enable for anon
11 2010-04-04T00:42:29 <dreimark> there are other reasons already why you want users to create an account
12 2010-04-04T00:42:43 <ThomasWaldmann> sure, but some won't
13 2010-04-04T00:43:21 <dreimark> well then they have a reason more do think about why they didn't before
14 2010-04-04T00:50:45 <dreimark> currently me has disabled the doubleclick feature. I have had it enabled in the past but sometimes i was annoyed by editing a page which i wanted to read only
15 2010-04-04T00:52:44 *** JosefMeier
16 2010-04-04T00:53:01 <ThomasWaldmann> yes, if it is just to start editing, it is not enough advantage
17 2010-04-04T00:53:32 <ThomasWaldmann> but having it position correctly is nice and might be worth to care about dblclicking
18 2010-04-04T00:59:40 <dreimark> if it does start the text editor people will be annoyed if they want to have the gui editor
19 2010-04-04T01:00:04 <dreimark> may be i think different about it when i have tried it
20 2010-04-04T01:00:14 *** RogerHaase
21 2010-04-04T01:00:25 <dreimark> currently i am not sure how it works with tables and twd or awd using links
22 2010-04-04T01:04:01 <dreimark> some windows user (me has also some) currently do a db click on a link
23 2010-04-04T01:04:27 <dreimark> or any other navigation.
24 2010-04-04T01:13:57 <dreimark> gn
25 2010-04-04T01:14:56 <RogerHaase> dreimark: I do not use twdraw or awdraw, so I did not test double-click with either.
26 2010-04-04T01:22:09 <ThomasWaldmann> hi RogerHaase
27 2010-04-04T01:22:49 <ThomasWaldmann> RogerHaase: it doesn't position the cursor into a simple wiki page in text editor
28 2010-04-04T01:23:01 <ThomasWaldmann> (no table, no twd, no gui)
29 2010-04-04T01:29:22 <RogerHaase> Does the text area scroll? No javascript errors?
30 2010-04-04T01:31:48 <RogerHaase> You installed from the 4/1 autoscroll.diff?
31 2010-04-04T01:35:37 <ThomasWaldmann> no scroll
32 2010-04-04T01:35:51 <ThomasWaldmann> if i try to begin typing, nothing happens
33 2010-04-04T01:36:11 <ThomasWaldmann> there is only one diff on that page, I applied that to current 1.9
34 2010-04-04T01:36:58 <ThomasWaldmann> i did it as anon user btw, after enabling dblclick editing in userpref defaults
35 2010-04-04T01:39:32 <RogerHaase> Is there public access or are you on a private wiki?
36 2010-04-04T01:39:56 <ThomasWaldmann> that's localhost :)
37 2010-04-04T01:40:17 <ThomasWaldmann> just wanted to give it a final test before committing
38 2010-04-04T01:40:42 <ThomasWaldmann> want my current diff?
39 2010-04-04T01:41:03 <ThomasWaldmann> http://paste.pocoo.org/show/197358/
40 2010-04-04T01:41:25 <ThomasWaldmann> == same as on the wiki page + anon dblclicking
41 2010-04-04T01:44:33 <RogerHaase> The symptoms sound like you have the old double-click action. Your diff looks OK (given a quick once-over).
42 2010-04-04T01:45:26 <RogerHaase> Could you do a quick view source and verify there is no dblclick on the body tag?
43 2010-04-04T01:45:38 <ThomasWaldmann> sure
44 2010-04-04T01:47:38 <ThomasWaldmann> <body lang="de" dir="ltr">
45 2010-04-04T01:50:18 <ThomasWaldmann> problem is that cursor is not even in the editor
46 2010-04-04T01:50:33 <ThomasWaldmann> i repeated test with a shorter page
47 2010-04-04T01:51:44 <RogerHaase> This is same Firefox 3.5.8 that you tested on my site?
48 2010-04-04T01:51:49 <ThomasWaldmann> yes
49 2010-04-04T01:52:24 <ThomasWaldmann> do you have the same code on your site?
50 2010-04-04T01:53:57 <RogerHaase> Yes, same code for double-click. I have a couple of other mods -- checking.
51 2010-04-04T01:59:19 <RogerHaase> One mod is to dump.py and the other to prefs.py. Both look innocent.
52 2010-04-04T02:01:35 <ThomasWaldmann> if you do a hg clone of moin/1.9, apply patch (pastebin) and start wikiserver.p,you should be able to reproduce
53 2010-04-04T02:02:44 <RogerHaase> OK, let me try that to see if I can reproduce.
54 2010-04-04T02:02:53 <RogerHaase> Will take a while.
55 2010-04-04T02:11:08 <ThomasWaldmann> GET /foo?action=edit&line=3 < request looks correct
56 2010-04-04T02:18:12 <RogerHaase> Have updated repository to tip. Do you know the command to apply the patch on windows - I am an HG lightweight!
57 2010-04-04T02:21:28 <ThomasWaldmann> cd workdir
58 2010-04-04T02:21:41 <ThomasWaldmann> patch -p1 < patch
59 2010-04-04T02:32:05 <RogerHaase> I only have hg tools, trying hg import --no-commit patch /... but I get cannot find file. still trying.
60 2010-04-04T02:33:53 <ThomasWaldmann> shall i create an export for you to import?
61 2010-04-04T02:39:57 <RogerHaase> No, I got it from pocoo. Seems like this hg import patch... wants something after patch besides the filename.
62 2010-04-04T02:40:18 <RogerHaase> It does not like the pocoo url either.
63 2010-04-04T02:40:59 <ThomasWaldmann> first get the file from the raw link
64 2010-04-04T02:41:20 <RogerHaase> did that.
65 2010-04-04T02:45:34 <RogerHaase> Progress, it likes hg import --no-commit /filename but rejected everything.
66 2010-04-04T03:00:21 <RogerHaase> Problem was DOS line endings. Have changes applied using pocoo raw.
67 2010-04-04T03:00:48 <ThomasWaldmann> ah
68 2010-04-04T03:04:13 <RogerHaase> How to start the built in server?
69 2010-04-04T03:04:39 <ThomasWaldmann> just start wikiserver.py from that directory
70 2010-04-04T03:10:14 <RogerHaase> Server started, but now have configuration error, underlay does not exist or permission error.
71 2010-04-04T03:23:10 <RogerHaase> I have the same problem. Double-click gets into edit mode with no cursor.
72 2010-04-04T03:24:13 <ThomasWaldmann> cd wiki
73 2010-04-04T03:24:25 <ThomasWaldmann> tar xf underlay.tar
74 2010-04-04T03:24:43 <ThomasWaldmann> or copy it from last release
75 2010-04-04T03:26:20 <RogerHaase> I had already copied it and have reproduced the problem. Now to figure out what the problem is...
76 2010-04-04T03:35:53 <ThomasWaldmann> anyway, needsleep, gn
77 2010-04-04T03:37:47 <RogerHaase> gn
78 2010-04-04T04:12:50 *** RogerHaase
79 2010-04-04T09:58:18 <dreimark> moin
80 2010-04-04T10:17:38 *** selevt
81 2010-04-04T10:49:51 *** valeuf
82 2010-04-04T10:57:41 *** valeuf
83 2010-04-04T11:48:15 *** valeuf_
84 2010-04-04T11:48:55 *** valeuf
85 2010-04-04T11:48:55 *** valeuf_
86 2010-04-04T12:21:29 * dreimark thinks that double click edit feature needs further enhancements
87 2010-04-04T12:23:14 *** eraser
88 2010-04-04T12:25:34 <ThomasWaldmann> dreimark: anything serious?
89 2010-04-04T12:25:58 <dreimark> it is limited to wiki markup
90 2010-04-04T12:26:37 <dreimark> if you have a format statement it just didn't open the editor
91 2010-04-04T12:27:12 <dreimark> also i would wish to see a box what i have selected as shown by the webdeveloper
92 2010-04-04T12:27:41 <dreimark> a similiar feature i have seen at a cms system. there it changes the background color of the selected area
93 2010-04-04T12:29:20 <ThomasWaldmann> it has nothing to do with wiki markup
94 2010-04-04T12:30:00 <ThomasWaldmann> but i think it needs line-anchors
95 2010-04-04T12:30:17 <dreimark> i tried with #format html
96 2010-04-04T12:30:21 <dreimark> and it didn't work
97 2010-04-04T12:30:27 <dreimark> also it didn't for arnica
98 2010-04-04T12:32:11 <ThomasWaldmann> try #format python
99 2010-04-04T12:33:04 <dreimark> that works also the highlight parser
100 2010-04-04T12:35:02 <dreimark> bbl
101 2010-04-04T13:17:14 *** eraser
102 2010-04-04T13:17:38 *** _buck
103 2010-04-04T13:33:05 <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5646:e45e3ae9e540 1.9/MoinMoin/ (4 files in 3 dirs): (log message trimmed)
104 2010-04-04T13:33:05 <CIA-55> scrolling the text editor to the double clicked line
105 2010-04-04T13:33:05 <CIA-55> If you have edit_on_doubleclick enabled (either by configuration default or
106 2010-04-04T13:33:05 <CIA-55> by user preferences), double clicking into the wiki page text will enter edit
107 2010-04-04T13:33:05 <CIA-55> mode and (for the text editor) position the cursor near the place where you
108 2010-04-04T13:33:06 <CIA-55> clicked (for some browsers it will be the correct line, for others it will be
109 2010-04-04T13:33:07 <CIA-55> just near).
110 2010-04-04T13:33:07 <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5647:7248a38409bd 1.9/MoinMoin/config/multiconfig.py: enable double-click-editing by default for easier testing
111 2010-04-04T13:33:25 <ThomasWaldmann> TheSheep: ^^
112 2010-04-04T14:24:46 <TheSheep> yay
113 2010-04-04T14:25:10 <TheSheep> great work guys
114 2010-04-04T14:25:44 *** _buck
115 2010-04-04T14:38:08 *** valeuf_
116 2010-04-04T14:41:03 *** valeuf
117 2010-04-04T14:41:03 *** valeuf_
118 2010-04-04T15:48:56 *** selevt_
119 2010-04-04T15:49:51 *** selevt
120 2010-04-04T16:12:14 <dreimark> re
121 2010-04-04T16:24:57 *** _buck
122 2010-04-04T16:36:18 *** moin6
123 2010-04-04T16:41:54 *** valeuf_
124 2010-04-04T16:42:23 *** valeuf
125 2010-04-04T16:42:23 *** valeuf_
126 2010-04-04T16:46:14 <dreimark> ThomasWaldmann: we should change the version string to something else than 1.9.2
127 2010-04-04T16:46:45 *** moin6
128 2010-04-04T16:51:50 <RogerHaase> dreimark: The red box in the Where to Double-Click section is the Firefox Web Developer add-on.
129 2010-04-04T16:52:37 <dreimark> RogerHaase: i know i asked on #moin for a similiar feature
130 2010-04-04T16:52:38 <RogerHaase> If you have it, ctl-shift-y turns it on/off.
131 2010-04-04T16:53:07 <dreimark> i want it on mouse over to show the region what i can select by db click for editing
132 2010-04-04T16:58:40 <RogerHaase> I do not understand how all the line-nnn gets generated out of sequence and sometimes duplicate numbers.
133 2010-04-04T16:58:46 *** _buck
134 2010-04-04T16:59:30 <dreimark> duplicate numbers is a bug, example?
135 2010-04-04T17:00:19 <RogerHaase> But if you dblclick anywhere on your table, line-617 is chosen. This is from the span tag in front of the second Titel: in your table.
136 2010-04-04T17:01:21 <RogerHaase> Maybe Radomir can explain how that line is chosen.
137 2010-04-04T17:01:51 <valeuf> moin
138 2010-04-04T17:04:54 <RogerHaase> My mistake, the dups I was seeing are classes for <p> tags. No IDs.
139 2010-04-04T17:05:14 *** selevt_
140 2010-04-04T17:09:13 <ThomasWaldmann> re
141 2010-04-04T17:09:30 <dreimark> these p class line numbers where inserted into the code for debugging
142 2010-04-04T17:09:53 <dreimark> because we won't change the parser in 1.9 we could remove these now
143 2010-04-04T17:10:49 <CIA-55> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5648:06908566d7bd 1.9/MoinMoin/version.py: bump version number to 1.9.3
144 2010-04-04T17:14:40 <valeuf> I am looking for the Unit Test stuffs
145 2010-04-04T17:14:41 <RogerHaase> OK, I see for your table, there is no span tag with an ID generated for the header row,
146 2010-04-04T17:15:13 <valeuf> and I was wondering if a diff between an expected Docbook file, and the generated one would be a good unit test ?
147 2010-04-04T17:15:49 <RogerHaase> but there are span tags with IDs generated for all the data rows, from line-613 to line-618.
148 2010-04-04T17:16:10 <ThomasWaldmann> valeuf: likely not
149 2010-04-04T17:16:22 <ThomasWaldmann> see current test failures
150 2010-04-04T17:16:40 <dreimark> or better look at the skipped tests
151 2010-04-04T17:16:46 <dreimark> because of that
152 2010-04-04T17:17:02 <valeuf> ThomasWaldmann: I checked the unit test in the Moin2 branch
153 2010-04-04T17:17:15 <valeuf> ThomasWaldmann: I will have a look for the test in the current branch so
154 2010-04-04T17:17:20 <RogerHaase> But the whole table selects line-617? Seems like it could do better and hit the right row.
155 2010-04-04T17:18:40 <dreimark> RogerHaase: i see the cursor always on the bottom line of the table.
156 2010-04-04T17:20:26 <ThomasWaldmann> valeuf: in moin 1.9, quite some tests have troubles because the test with some given parser input and check the formatter output against some expected output
157 2010-04-04T17:21:36 <ThomasWaldmann> and each time a little bit changes somewhere in between, you get lots of failures
158 2010-04-04T17:21:45 <RogerHaase> driemark: Right, the result of the whole table being set with line-617. This happens in the javascript setSpanTags function.
159 2010-04-04T17:22:32 <ThomasWaldmann> btw, see bottom of that page for some improvements that could be made
160 2010-04-04T17:27:49 *** _buck
161 2010-04-04T17:30:33 <dreimark> RogerHaase: i tried the feature with http://moinmo.in/MoinAPI/Beispiele and it makes working on that document easier
162 2010-04-04T17:30:46 <dreimark> also i have some further ideas
163 2010-04-04T17:31:32 <dreimark> if i use it with SlideShow http://moinmo.in/4ct10n/SlideShow/MoinMoinTalks/DLR-2009-09-08?action=SlideShow
164 2010-04-04T17:31:50 <dreimark> i want it also working
165 2010-04-04T17:32:20 <dreimark> please make it work to edit for example slide 10
166 2010-04-04T17:32:28 <dreimark> if i am on that slide
167 2010-04-04T17:34:08 <dreimark> (that example is not editable by you)
168 2010-04-04T17:38:04 <RogerHaase> driemark: OK, will look for a local slide I can edit.
169 2010-04-04T17:39:41 <dreimark> RogerHaase: me becomes highligthed if you don't do a typo in my nick. I often use the tab key for autocompletion ;)
170 2010-04-04T17:45:58 <RogerHaase> dreimark: Will try harder, I recently rcorded a rock art site named Riemar and my mother's maiden name is Riechers.
171 2010-04-04T17:47:53 <RogerHaase> dreimark: To edit a slideshow, there must be a <meta name="edit_on_doubleclick" content="1"> added to the header.
172 2010-04-04T17:53:39 <dreimark> RogerHaase: me had always heard my firstname as we have paid with the old currency
173 2010-04-04T17:53:55 <dreimark> in memorial to this i have choosen this nick
174 2010-04-04T17:54:55 <dreimark> i look at the action after i am done with the action i am working on now
175 2010-04-04T17:59:42 * dreimark enjoys bpython
176 2010-04-04T18:00:13 <valeuf> after reading converter2/_tests/test_html_out.py I think I understand more how is working the unit test for the converter2, so there is indeed no need to diif !!
177 2010-04-04T18:05:12 <dreimark> valeuf: but you need to write tests - thats clear or?
178 2010-04-04T18:05:23 <valeuf> dreimark: yes naturally
179 2010-04-04T18:05:34 <dreimark> good
180 2010-04-04T18:05:35 <valeuf> dreimark: but I was not sure about how to write efficient test
181 2010-04-04T18:11:36 *** _buck
182 2010-04-04T18:14:57 *** valeuf_
183 2010-04-04T18:16:04 *** valeuf
184 2010-04-04T18:16:05 *** valeuf_
185 2010-04-04T18:30:36 *** _buck
186 2010-04-04T19:15:17 *** _buck
187 2010-04-04T19:15:31 *** _buck
188 2010-04-04T20:58:19 <ThomasWaldmann> valeuf: http://moinmo.in/MoinMoinPatch/PretifyDocbookOutput i can apply that, is it what one usually wants? any downsides?
189 2010-04-04T21:16:50 <dreimark> RogerHaase: http://paste.pocoo.org/show/197581/
190 2010-04-04T21:16:57 <dreimark> TheSheep:
191 2010-04-04T21:17:18 <dreimark> that won't work with the action SingleSlideshow
192 2010-04-04T21:17:39 <dreimark> because we create always id starting from 0 for each slide
193 2010-04-04T21:18:37 <dreimark> the js code is based on counting, can it be also based on a unique id (not enumerated)
194 2010-04-04T21:19:56 <dreimark> if there are pragmas used on a page we will always have an offset on SiSlSh
195 2010-04-04T21:25:31 <TheSheep> dreimark: all the editor's js needs is the line number, if you can somehow add that to the url, it will work
196 2010-04-04T21:28:25 * dreimark looks
197 2010-04-04T21:46:26 <RogerHaase> dreimark: I applied your patch. When I run HelpOnSlideShow from the underlay, I get ..?action=print&media=projection and there is no meta tag.
198 2010-04-04T21:53:41 <ThomasWaldmann> 287/288 wtf?
199 2010-04-04T21:57:44 <valeuf> ThomasWaldmann: well, without this small change, you get a one line XML document ... which is not really convenient to edit after
200 2010-04-04T21:57:47 <ThomasWaldmann> ah, i see now. ignore.
201 2010-04-04T21:58:10 <ThomasWaldmann> valeuf: and editing afterwards is happening frequently?
202 2010-04-04T21:58:33 <valeuf> ThomasWaldmann: with the pretty output, you get the correct indentation, and a nice looking PDF
203 2010-04-04T21:58:49 <ThomasWaldmann> any downsides?
204 2010-04-04T21:59:46 <valeuf> ThomasWaldmann: No Idea, personally yes, I usually change few stuff in the final DocBook document, but usually we do not really edit manually DocBook source
205 2010-04-04T21:59:59 <valeuf> ThomasWaldmann: normally no, but maybe it is a little bit slower
206 2010-04-04T22:00:18 <valeuf> ThomasWaldmann: (I do not think so, but I can check quickly on a big document)
207 2010-04-04T22:03:19 <ThomasWaldmann> i don't mean speed. but maybe whitespace related issues?
208 2010-04-04T22:04:45 <valeuf> ThomasWaldmann: never heard about it, but I think it has been intentionally turn off by the previous author of the DocBook formatter, There was probably a reason
209 2010-04-04T22:05:23 <valeuf> ThomasWaldmann: But I cannot figure it out, to me it makes more sense to produce human-readable document since the purpose of XML is to be human-readable,
210 2010-04-04T22:07:27 <valeuf> ThomasWaldmann: the indent are not using the tabulation character, but just two whitespace characters
211 2010-04-04T22:10:56 <dreimark> valeuf: isn't it relevant for fast reading. i think it is much faster in one line
212 2010-04-04T22:11:06 <ThomasWaldmann> valeuf: it has been intentionally turned off?
213 2010-04-04T22:11:32 <valeuf> dreimark: yep, It was what I was thinking about when I said it is slower
214 2010-04-04T22:11:42 <valeuf> not to generate, but to process the docbook file after
215 2010-04-04T22:11:49 <valeuf> (Sorry I have not been clear)
216 2010-04-04T22:12:04 <valeuf> ThomasWaldmann: I think so, because the PrettyPrint module was already imported
217 2010-04-04T22:12:24 <ThomasWaldmann> yes, maybe
218 2010-04-04T22:13:13 <dreimark> RogerHaase: <meta name="edit_on_doubleclick" content="1">
219 2010-04-04T22:13:21 <valeuf> ThomasWaldmann: on line 104 : from xml.dom.ext import PrettyPrint, Print
220 2010-04-04T22:13:33 <valeuf> ThomasWaldmann: so I guess that PrettyPrint was used before
221 2010-04-04T22:13:37 <dreimark> i have the meta tag there. but the line numbers are wrong
222 2010-04-04T22:14:19 <dreimark> valeuf: big documents also could have memory problems
223 2010-04-04T22:14:54 <valeuf> ThomasWaldmann: I will make some search about PrettyPrint to see if there is any comparaison with the normal Print function
224 2010-04-04T22:15:46 <valeuf> dreimark: what kind of memory problem ? I do not see why a multi-line document can have more problem than an "all-in-one" line document ??
225 2010-04-04T22:16:41 <dreimark> valeuf: because of blanks and linebreaks
226 2010-04-04T22:17:25 <valeuf> dreimark: hum ... that's true, there is a small size difference between the two kind of document
227 2010-04-04T22:17:32 <valeuf> dreimark: let me make a test
228 2010-04-04T22:20:01 * dreimark remembers a TALK
229 2010-04-04T22:20:39 <dreimark> on pycologne about that, and there it was necessary to split a one liner in several hunks after it was formatted for human reading
230 2010-04-04T22:27:07 <dreimark> RogerHaase: may be it needs a editable page
231 2010-04-04T22:30:08 <valeuf> dreimark: you are probably right, I just test on different document from my personal wiki
232 2010-04-04T22:30:39 <valeuf> dreimark: it is 13~16% for the 4 documents I tried
233 2010-04-04T22:31:10 <ThomasWaldmann> there is no memory problem
234 2010-04-04T22:31:11 <valeuf> thes documents was all having more than 70 000 char for the one line output
235 2010-04-04T22:32:04 <valeuf> ThomasWaldmann: for some really big document, I think it can be a problem
236 2010-04-04T22:35:37 <ThomasWaldmann> making something big 16% bigger leads to a problem?
237 2010-04-04T22:36:22 <ThomasWaldmann> and how big could such a document be?
238 2010-04-04T22:37:00 <valeuf> ThomasWaldmann: forget about what I said, I think it was quite stupid in fact, I keep in mind a problem with XML parsing on Windows Mobile
239 2010-04-04T22:37:30 <valeuf> ThomasWaldmann: but I guess that people will not process DocBook document on embedded platform ...
240 2010-04-04T22:39:09 <valeuf> ThomasWaldmann: BTW, I checked and prettyXML does not intro
241 2010-04-04T22:39:20 <valeuf> introduce significant whitespace
242 2010-04-04T22:40:25 <valeuf> (whitespace in the content are significant)
243 2010-04-04T22:41:16 *** RogerHaase
244 2010-04-04T22:41:49 <dreimark> ThomasWaldmann: it was a thesis something about 120 pages
245 2010-04-04T22:44:05 <ThomasWaldmann> dreimark: ?
246 2010-04-04T22:45:00 <ThomasWaldmann> valeuf: if you are sure, I can commit that change. I won't have problems with it as I don't use it anyway. :D
247 2010-04-04T22:45:36 <valeuf> ThomasWaldmann: well, I am not 100% sure, but it was useful for me ... Maybe we can just keep a
248 2010-04-04T22:46:01 <valeuf> ThomasWaldmann: Maybe I can add to the DocBook documentation a message about this
249 2010-04-04T22:46:15 <valeuf> ThomasWaldmann: To explain to people how to switch between the two printing mode
250 2010-04-04T22:48:49 <dreimark> valeuf: that also should go into CHANGES
251 2010-04-04T23:06:33 *** moin9
252 2010-04-04T23:06:44 *** moin9
253 2010-04-04T23:07:46 <RogerHaase> dreimark: I found MergeNavigationMacroAndSlideShowAction and now understand there are two kinds of slideshows.
254 2010-04-04T23:08:38 <RogerHaase> dreimark: If I add ?action=SlideShow to a wiki page url, then doubleclick works with you patch.
255 2010-04-04T23:15:17 <RogerHaase> dreimark: But maybe rather than just adding the meta tag always, we should add the tests as in /theme/__init__.py.
256 2010-04-04T23:24:51 *** ashishg
257 2010-04-04T23:28:00 <dreimark> RogerHaase: yes, this was only for testing
258 2010-04-04T23:28:16 <dreimark> and recognizing that it won't work as it is
259 2010-04-04T23:58:02 *** _buck
260
