1 2009-11-28T00:09:40 <ThomasWaldmann> how does escape look like now?
2 2009-11-28T00:11:05 <JosefMeier> mom
3 2009-11-28T00:12:14 <JosefMeier> ThomasWaldmann: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/9d84087ce141
4 2009-11-28T00:13:56 <ThomasWaldmann> ehrm, you know that you don't need to escape quotes except if you put the result into quotes? like an html attribute value?
5 2009-11-28T00:19:58 * ThomasWaldmann .sleep() # gn
6 2009-11-28T00:31:56 <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5310:1f0c87a833a8 1.9/MoinMoin/action/edit.py: action.edit: bug fix for MoinMoinBugs/MissingPageShouldn'tOfferToCreatePageForReadonlyUsers
7 2009-11-28T00:44:23 <dreimark> gn
8 2009-11-28T00:55:57 *** grzywacz
9 2009-11-28T01:28:10 <JosefMeier> gn
10 2009-11-28T01:28:25 *** JosefMeier
11 2009-11-28T04:06:41 *** grzywacz
12 2009-11-28T09:05:01 *** JosefMeier
13 2009-11-28T09:05:26 <JosefMeier> Moin Moin
14 2009-11-28T09:07:48 <JosefMeier> ThomasWaldmann: Thus the escaping should be a defense against XSS where bad guys could try anything to break the Moin system, I would recommend to escape also the quotes.
15 2009-11-28T09:08:26 <JosefMeier> If you don't have further remarks on the code, what about pushing it to the RC1 now?
16 2009-11-28T10:18:31 *** grzywacz
17 2009-11-28T10:36:11 <ThomasWaldmann> moin
18 2009-11-28T10:36:38 <ThomasWaldmann> JosefMeier: is 1.117 needed?
19 2009-11-28T10:37:38 <ThomasWaldmann> see also 1.94 with idx == -1
20 2009-11-28T10:38:00 <JosefMeier> ThomasWaldmann: Sometimes you guys scare me :-)
21 2009-11-28T10:38:11 <JosefMeier> 1.117 is a "Leiche"
22 2009-11-28T10:39:46 <ThomasWaldmann> hm, why?
23 2009-11-28T10:40:49 <JosefMeier> cause you find everything
24 2009-11-28T10:41:02 <ThomasWaldmann> and if you find 1.117 is not needed, you can remove some code duplication there
25 2009-11-28T10:41:04 <JosefMeier> 1.94: idx = -1 -> idx+1 = 0
26 2009-11-28T10:41:28 <JosefMeier> so 1.94 has always a valid result
27 2009-11-28T10:41:40 <ThomasWaldmann> yeah
28 2009-11-28T10:44:25 <ThomasWaldmann> btw "dialog" is AE, "dialogue" is BE
29 2009-11-28T10:45:30 <JosefMeier> I like dialog more
30 2009-11-28T10:46:30 <JosefMeier> I removed the code duplication on 1.117
31 2009-11-28T10:47:32 * JosefMeier does final tests also on the l&f of the new image dialog
32 2009-11-28T10:48:38 <ThomasWaldmann> 1.128 please check
33 2009-11-28T10:50:18 <ThomasWaldmann> 1.126 also
34 2009-11-28T10:54:16 <JosefMeier> ok. removed it.
35 2009-11-28T10:55:29 <ThomasWaldmann> ok, time for testing and a new cs :)
36 2009-11-28T11:01:08 <JosefMeier> During testing my new image dialog I found out that roundtripping does work for attachment transclusions but not for drawing transclusions.
37 2009-11-28T11:01:40 <JosefMeier> {{drawing:test.adraw}} where test.adraw doesn't exist makes a link out of it while round tripping. -> Bug report?
38 2009-11-28T11:07:41 <ThomasWaldmann> we first finish the attachment dialog
39 2009-11-28T11:08:06 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/503e951dd1f4
40 2009-11-28T11:08:23 <JosefMeier> also tested
41 2009-11-28T11:11:35 <JosefMeier> for functionality and also for py.test errors
42 2009-11-28T11:11:41 <dreimark> JosefMeier: do you have looked by pylint on your changes?
43 2009-11-28T11:12:08 <JosefMeier> dreimark: No. But this is also true for most of the moin code I think
44 2009-11-28T11:12:29 <dreimark> we often check pylint
45 2009-11-28T11:13:03 <dreimark> for what is l8 needed?
46 2009-11-28T11:13:20 <JosefMeier> do you have a pylint config file for moinmoin ?
47 2009-11-28T11:13:21 <ThomasWaldmann> 131 vs 141 is 90%% vs 100%%, intended?
48 2009-11-28T11:13:27 <dreimark> (thats why I ask)
49 2009-11-28T11:14:01 <dreimark> JosefMeier: it tells always if you added code which is not used
50 2009-11-28T11:14:03 <JosefMeier> dreimark: Could you give me your pylint config file? My pylint only can handle one py file but not the whole moin project
51 2009-11-28T11:14:11 <dreimark> therefore you don't need a config file
52 2009-11-28T11:14:56 <dreimark> moin-1.9$ pylint MoinMoin/action/fckdialog.py
53 2009-11-28T11:15:15 <dreimark> uses all imports if you mean this problem
54 2009-11-28T11:16:07 <JosefMeier> It checks on its own for the imports?
55 2009-11-28T11:16:22 <dreimark> you need to call it from the correct level
56 2009-11-28T11:16:23 <dreimark> then yes
57 2009-11-28T11:16:30 <ThomasWaldmann> can we please continue fixing your changeset, so we finally get this done?
58 2009-11-28T11:17:09 * ThomasWaldmann would really like to commit that :)
59 2009-11-28T11:17:23 * dreimark too
60 2009-11-28T11:17:35 <dreimark> l8 is not needed
61 2009-11-28T11:18:32 * dreimark is quiet now
62 2009-11-28T11:19:10 <JosefMeier> ThomasWaldmann: dreimark: Cause you like it so much :-) ?
63 2009-11-28T11:19:34 <ThomasWaldmann> yes, it has much better functionality than the stuff before
64 2009-11-28T11:20:13 <JosefMeier> Thanks. Nice to hear that.
65 2009-11-28T11:20:14 <ThomasWaldmann> so, if we get the code into a good shape, that'll be really an improvement
66 2009-11-28T11:20:33 <JosefMeier> ThomasWaldmann: I changed the 90% / 100% to only 100%
67 2009-11-28T11:20:50 <ThomasWaldmann> then, about the code duplication
68 2009-11-28T11:21:08 <JosefMeier> where?
69 2009-11-28T11:21:31 <JosefMeier> cause I use "100%" on two places?
70 2009-11-28T11:21:44 <ThomasWaldmann> 1.118/119 path == currAttachname ?
71 2009-11-28T11:23:02 <ThomasWaldmann> if you find that this is True, you can just move 1.112/113 and 1.118/119 to below the if/else block
72 2009-11-28T11:23:39 <JosefMeier> Hm ...
73 2009-11-28T11:24:31 <ThomasWaldmann> there is still 1.126 overwriting the stuff you do in that if/else block
74 2009-11-28T11:26:06 <ThomasWaldmann> btw, i am just reading the code, not executing it
75 2009-11-28T11:26:10 <JosefMeier> then it seems this is ok but I can remove the 1.111 and 1.117
76 2009-11-28T11:26:26 <JosefMeier> but your thoughts seem logically
77 2009-11-28T11:26:37 <JosefMeier> and shorter js code is always better for execution performance
78 2009-11-28T11:26:53 <ThomasWaldmann> that would mean you don't need the if/else at all
79 2009-11-28T11:27:18 <ThomasWaldmann> because the other two lines can be outside, see above
80 2009-11-28T11:27:41 <ThomasWaldmann> but better check that :)
81 2009-11-28T11:29:39 <JosefMeier> try this already.
82 2009-11-28T11:34:04 <JosefMeier> it works
83 2009-11-28T11:42:56 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/5771cb307d20
84 2009-11-28T11:48:20 <ThomasWaldmann> lol @ fefe
85 2009-11-28T11:56:33 <ThomasWaldmann> JosefMeier: the code talks about "image" at multiple places, shouldn't that be "attachment"?
86 2009-11-28T12:05:08 <ThomasWaldmann> function SetBasePageAttachName(path)
87 2009-11-28T12:05:32 <ThomasWaldmann> ^^ that function confuses me. are you sure you handled all cases?
88 2009-11-28T12:08:06 <JosefMeier> yes
89 2009-11-28T12:13:05 <ThomasWaldmann> that referred to which question?
90 2009-11-28T12:13:49 <JosefMeier> I have to change image to attachment. I tested setbasepageattachname a lot
91 2009-11-28T12:17:39 <JosefMeier> requestedPagename always is "" if the dialog is called the first time. If it reloads cause an attachment is on a different page, then this page's name is inside of requestedPagename.
92 2009-11-28T12:20:54 <ThomasWaldmann> i am just wondering about the nested ifs there
93 2009-11-28T12:21:45 <ThomasWaldmann> and 1.96 an 97 doesn't seem to really explain it
94 2009-11-28T12:24:19 * JosefMeier looking
95 2009-11-28T12:25:07 <JosefMeier> the inner if (requestedPagename == "")
96 2009-11-28T12:25:28 <JosefMeier> is needed to prevent the dialog for infinit reloads
97 2009-11-28T12:25:51 <JosefMeier> the dialog is allowed to only reload once
98 2009-11-28T12:25:55 <JosefMeier> automatically
99 2009-11-28T12:29:18 <ThomasWaldmann> currPagename = 'Foo', attachmentsPagename = 'Bar', requestedPagename = 'Foo'
100 2009-11-28T12:30:24 <ThomasWaldmann> that'll make 1.98..1.111 do nothing
101 2009-11-28T12:30:52 <ThomasWaldmann> is that correct?
102 2009-11-28T12:35:27 <JosefMeier> this can only happen if you press the refresh button on the current pagename
103 2009-11-28T12:35:51 <JosefMeier> and yes. then 98 ... 111 arent executed. but thats ok
104 2009-11-28T12:36:20 <JosefMeier> but ... attachmentspagename and requestedpagename normally are equal
105 2009-11-28T12:36:32 <JosefMeier> attachmentspagename is the name of the page the attachments are listed for
106 2009-11-28T12:36:51 <JosefMeier> you requested this page name before with requestedpagename
107 2009-11-28T12:37:29 <ThomasWaldmann> if i request Bar before, then edit pagename to be Foo, then refresh...
108 2009-11-28T12:37:35 <JosefMeier> try that
109 2009-11-28T12:38:03 <JosefMeier> if you refresh than attachmentspage will be set to foo also
110 2009-11-28T12:38:07 <JosefMeier> then
111 2009-11-28T12:38:27 <JosefMeier> this happens in python
112 2009-11-28T12:40:05 <ThomasWaldmann> so you tried that?
113 2009-11-28T12:40:33 <JosefMeier> thats normal behaviour
114 2009-11-28T12:41:33 <JosefMeier> thats the core functionally of the "load attachments from different page" feature
115 2009-11-28T12:46:50 <ThomasWaldmann> while playing with it, i have the case that it overwrites the pagename i entered with an invalid pagename
116 2009-11-28T12:47:23 <ThomasWaldmann> i am on page Foo, entered attachtest as pagename, hit refresh
117 2009-11-28T12:48:06 <ThomasWaldmann> sometimes it makes "at" out of the pagename
118 2009-11-28T12:53:30 <JosefMeier> hm
119 2009-11-28T12:53:43 <ThomasWaldmann> it doesn't handle it correctly if i choose something from the dropdown the browser offers me for completion of the pagename input field
120 2009-11-28T12:53:53 <JosefMeier> can you reproduce this behaviour?
121 2009-11-28T12:54:09 <ThomasWaldmann> i see the correct value on screen, but it processes only what I typed
122 2009-11-28T12:54:46 <ThomasWaldmann> this is likely some onXXX not getting triggered
123 2009-11-28T12:55:20 <JosefMeier> does this happen by random?
124 2009-11-28T12:55:37 <ThomasWaldmann> no, should be reproducable
125 2009-11-28T12:55:41 <ThomasWaldmann> use FF
126 2009-11-28T12:55:49 <ThomasWaldmann> gui edit page Foo
127 2009-11-28T12:55:56 <ThomasWaldmann> create att link
128 2009-11-28T12:56:26 <ThomasWaldmann> overwrite pagename by typing attachtest
129 2009-11-28T12:56:41 <ThomasWaldmann> refresh -> OK
130 2009-11-28T12:57:05 <ThomasWaldmann> delete all from pagename field
131 2009-11-28T12:57:25 <ThomasWaldmann> type att -> FF offers completions, choose attachtest, refresh
132 2009-11-28T12:57:43 <ThomasWaldmann> it'll show just "att" as pagename
133 2009-11-28T12:58:12 <JosefMeier> ah. so you used the autocompletion. That's why formerly I used onchange also
134 2009-11-28T12:58:34 <ThomasWaldmann> so there is a comment missing
135 2009-11-28T12:58:43 <JosefMeier> thats why onkeyup + onchange are needed
136 2009-11-28T12:58:55 <ThomasWaldmann> if you are doing something non-obvious, comment it
137 2009-11-28T13:00:05 <ThomasWaldmann> in case onchange is the more generic event and includes the other one, maybe you have just killed the wrong one
138 2009-11-28T13:03:00 <JosefMeier> maybe I should switch autocompletion off?
139 2009-11-28T13:03:50 <ThomasWaldmann> no?
140 2009-11-28T13:05:01 <JosefMeier> autocompletion doesn't fire an event
141 2009-11-28T13:05:53 <ThomasWaldmann> maybe you should just take the value from the input field when someone presses refresh
142 2009-11-28T13:06:45 <ThomasWaldmann> (that somehow sounds like a KISS approach :)
143 2009-11-28T13:07:31 <JosefMeier> kiss ?
144 2009-11-28T13:07:57 <TheSheep> keep it simple stupid
145 2009-11-28T13:08:29 <JosefMeier> i have no event for the fckeditors ok button
146 2009-11-28T13:08:44 <JosefMeier> or ...
147 2009-11-28T13:08:47 <JosefMeier> ahm
148 2009-11-28T13:08:49 <JosefMeier> moment
149 2009-11-28T13:08:52 <TheSheep> onsubmit?
150 2009-11-28T13:09:33 <JosefMeier> on the form?
151 2009-11-28T13:09:45 <JosefMeier> form tag
152 2009-11-28T13:11:43 <JosefMeier> hm. yes, that works ;-)
153 2009-11-28T13:17:12 <JosefMeier> also onchange works. I edited the wrong file before :-(
154 2009-11-28T13:21:31 <JosefMeier> now I use onkeyup and onchange but not onsubmit. And it works
155 2009-11-28T13:25:24 <ThomasWaldmann> so onchange does not include onkey*?
156 2009-11-28T13:27:34 <JosefMeier> onchange only happens if the field looses the focus. but we want do stuff while typing
157 2009-11-28T13:28:10 <JosefMeier> like graying out the attachment list if the pagename changes to a different page name
158 2009-11-28T13:28:43 <JosefMeier> if you put in the original pagename again, the attachment list will be available end selectable again
159 2009-11-28T13:30:36 <ThomasWaldmann> ok
160 2009-11-28T13:31:49 <JosefMeier> one question: If you commit something to the official repo and a few weeks later you find out that there is an error in this changeset, you could switch to this changeset, correct the problem and than switch back to the current changeset. right?
161 2009-11-28T13:32:13 <JosefMeier> for sure you would have to merge first
162 2009-11-28T13:32:23 <JosefMeier> after you switched back to the current changeset
163 2009-11-28T13:42:47 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5311:a1215ba14417 1.9/MoinMoin/PageEditor.py: PageEditor: remove relative=False arg to p.url() because it is default
164 2009-11-28T13:43:03 <ThomasWaldmann> dreimark: http://moinmo.in/MoinMoinBugs/LoginDialogIfLoggedIn looks fine
165 2009-11-28T13:43:51 <JosefMeier> ...
166 2009-11-28T13:43:53 <ThomasWaldmann> JosefMeier: you can also just fix it and commit
167 2009-11-28T13:44:21 <JosefMeier> ThomasWaldmann: But then there is no relation to the former changeset.
168 2009-11-28T13:45:04 <ThomasWaldmann> that's not required
169 2009-11-28T13:45:09 <JosefMeier> ok
170 2009-11-28T13:45:18 <JosefMeier> how do we proceed with the attachment dialog?
171 2009-11-28T13:46:45 <ThomasWaldmann> did you test it after your last changeset?
172 2009-11-28T13:47:20 <JosefMeier> yes
173 2009-11-28T13:47:52 <JosefMeier> I always push it to my server. If it is pushed, you already can test it, cause the live system works on the repo.
174 2009-11-28T13:51:20 <CIA-34> Josef Meier <jo.meier@gmx.de> default * 5312:fd6e62d305a6 1.9/MoinMoin/ (3 files in 2 dirs): (log message trimmed)
175 2009-11-28T13:51:20 <CIA-34> Improved attachment dialog for GUI editor.
176 2009-11-28T13:51:20 <CIA-34> New features:
177 2009-11-28T13:51:20 <CIA-34> - attachments for current page are listed in a listbox
178 2009-11-28T13:51:20 <CIA-34> - attachments for a different page can be listed in a listbox
179 2009-11-28T13:51:22 <CIA-34> - page and attachment can be entered in separated edit fields
180 2009-11-28T13:51:26 <CIA-34> - i18n support
181 2009-11-28T13:51:28 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5313:37b22f678801 1.9/MoinMoin/ (3 files in 2 dirs): merged Josef's GUI editor attachment dialog improvements
182 2009-11-28T13:51:48 <JosefMeier> ThomasWaldmann: If you would be here, you could see me crying ;-)
183 2009-11-28T13:51:57 <ThomasWaldmann> hehe
184 2009-11-28T13:52:13 <JosefMeier> ok. now to the image dialog ;-)
185 2009-11-28T13:52:27 <JosefMeier> I assume you want to publich RC2 this weekend?
186 2009-11-28T13:52:32 <JosefMeier> publish
187 2009-11-28T13:52:33 <ThomasWaldmann> yes
188 2009-11-28T13:53:03 <JosefMeier> the image dialog ... does it has a chance to be included between RC2 and the final release?
189 2009-11-28T13:53:25 <ThomasWaldmann> btw, &do=get was a missing feature of att dialog
190 2009-11-28T13:53:48 <JosefMeier> we can add that before 1.19
191 2009-11-28T13:53:51 <ThomasWaldmann> and I know that people will ask for that
192 2009-11-28T13:55:49 <JosefMeier> and what about the image dialog? It's very similar to the attachment dialog. Differences: attachment:, http, https, file, ... support; width, height, alignment can be set; not only images, but also drawings and other mime types are supported
193 2009-11-28T13:56:59 <JosefMeier> the new "image" dialog should rather be called "embeddable object" dialog cause it doesn't check the extension of the selected attachmen. It only checks, if the attachment is a drawing (.adraw, .tdraw, .svg) or not.
194 2009-11-28T13:57:19 <JosefMeier> you also can embed pdf files with it
195 2009-11-28T13:58:18 <JosefMeier> I don't think that I will have it ready until RC2. But it will for sure be ready for the final release
196 2009-11-28T13:58:23 <JosefMeier> if that is possible
197 2009-11-28T14:01:54 <ThomasWaldmann> dreimark: http://moinmo.in/4ct10n/info/MoinMoinBugs/InvalidHtmlInPageHistoryDueToNestedForms?action=diff&rev2=4&rev1=2
198 2009-11-28T14:06:00 <ThomasWaldmann> JosefMeier: well, when looking at release timing, i don't think there will be enough time for it
199 2009-11-28T14:06:25 <ThomasWaldmann> and also, best approach is still unclear
200 2009-11-28T14:07:11 <ThomasWaldmann> when considering attachments, much of the UI will be pretty much the same as for the stuff we just added
201 2009-11-28T14:07:57 <JosefMeier> In my opinion we could combine the attachment and the link button in a further release
202 2009-11-28T14:08:46 <ThomasWaldmann> make a good plan :)
203 2009-11-28T14:09:23 <ThomasWaldmann> toplevel differentiation could be link vs. embed
204 2009-11-28T14:09:45 <JosefMeier> yes. this would mean, that the link button will have the ui of the attachment button
205 2009-11-28T14:10:49 <JosefMeier> thus the link dialog has everything I would also put into the image dialog, there could finally be only one button which does the linking and also the embedding
206 2009-11-28T14:11:06 <ThomasWaldmann> maybe that attachment ui should be usable within link and embed dialog, without duplicating all the stuff
207 2009-11-28T14:11:56 <JosefMeier> ok. I'll make some design proposals.
208 2009-11-28T14:12:03 <JosefMeier> when do you plan to relese 1.9 ?
209 2009-11-28T14:12:07 <JosefMeier> release
210 2009-11-28T14:12:10 <ThomasWaldmann> alternatively, esp. when looking at moin2 (attachment -> dead), it could also make sense to do toplevel differentiation by attachments vs. other stuff
211 2009-11-28T14:12:39 <ThomasWaldmann> depends :)
212 2009-11-28T14:13:13 <JosefMeier> on what?
213 2009-11-28T14:13:47 <ThomasWaldmann> on manhours available for release process and rc testing outcome
214 2009-11-28T14:14:17 <ThomasWaldmann> while I am discussing with you, i am not working on release stuff :)
215 2009-11-28T14:16:42 <JosefMeier> ThomasWaldmann: Thanks god that discussing with me is always a pleasure for you :-)
216 2009-11-28T14:17:11 <ThomasWaldmann> yeah
217 2009-11-28T14:24:23 <ThomasWaldmann> dreimark: http://moinmo.in/MoinMoinBugs/1.6XmlRpcPutPagePagenameEscape looks good, please test it
218 2009-11-28T14:28:56 <ThomasWaldmann> brb
219 2009-11-28T14:35:24 <JosefMeier> bbl
220 2009-11-28T14:35:30 *** JosefMeier
221 2009-11-28T15:47:45 * ThomasWaldmann improves xapian index rebuild
222 2009-11-28T16:37:44 *** eSyr
223 2009-11-28T16:38:10 <eSyr> Hello everyone.
224 2009-11-28T16:39:54 <ThomasWaldmann> hi eSyr
225 2009-11-28T16:40:15 <TheSheep> wow, Holger actually wrote that issue tracker he talked about on Europython!
226 2009-11-28T16:40:25 <TheSheep> http://codespeak.net/ciss/
227 2009-11-28T16:40:32 <TheSheep> looks very simple
228 2009-11-28T16:41:20 <ThomasWaldmann> ciss is just starting, it’s alpha software - but be assured: it has more tests than code :)
229 2009-11-28T16:41:47 <TheSheep> good start
230 2009-11-28T16:45:26 <ThomasWaldmann> let's see, currently it is not much more than you could also do just with that text editor
231 2009-11-28T16:47:13 <TheSheep> obviously
232 2009-11-28T16:48:56 <TheSheep> but I'm going to try and write a web tool for reporting bugs for it :)
233 2009-11-28T16:49:10 <ThomasWaldmann> or a wiki importer :)
234 2009-11-28T16:50:03 *** JosefMeier
235 2009-11-28T16:50:34 <TheSheep> I like the format
236 2009-11-28T16:51:02 <TheSheep> maybe it would need some comments though
237 2009-11-28T16:53:25 <ThomasWaldmann> looks a bit like reST
238 2009-11-28T16:53:44 <ThomasWaldmann> maybe he could just use reST?
239 2009-11-28T16:54:22 <TheSheep> I think it is rest
240 2009-11-28T16:54:37 * ThomasWaldmann .oO(soon we have a less disruptive index rebuild)
241 2009-11-28T16:54:44 <TheSheep> or actually a subset
242 2009-11-28T16:56:47 <TheSheep> uh, that parser is hacky
243 2009-11-28T17:00:34 <eSyr> ThomasWaldmann, can this patch be added to 1.9? http://moinmo.in/FeatureRequests/LeaveRedirectInPlaceWhenRenamingPages
244 2009-11-28T17:03:39 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5314:e005834bbf85 1.9/MoinMoin/ (3 files in 3 dirs): (log message trimmed)
245 2009-11-28T17:03:39 <CIA-34> less disruptive xapian index rebuild (details below)
246 2009-11-28T17:03:39 <CIA-34> Improved --mode=rebuild:
247 2009-11-28T17:03:39 <CIA-34> Previously it first killed the old index files, then started to build a new
248 2009-11-28T17:03:39 <CIA-34> index (takes quite long for big wikis) - until the new index was finished,
249 2009-11-28T17:03:43 <CIA-34> search was either falling back to slow search or was having even bigger trouble.
250 2009-11-28T17:03:45 <CIA-34> Now it builds the new index to a separate directory, then kills the old index,
251 2009-11-28T17:06:13 <ThomasWaldmann> eSyr: I'll have to look at it later, have to leave now.
252 2009-11-28T17:06:40 <ThomasWaldmann> it has to be seen whether this works for non-wiki pages
253 2009-11-28T17:07:00 <ThomasWaldmann> "Those patches also fix MoinMoinBugs/RenamePageDestroysSubPageNaming."
254 2009-11-28T17:07:10 <ThomasWaldmann> please don't mix features and bug fixes
255 2009-11-28T17:08:26 <eSyr> well, i've written this because i have need to masse rename moved pages, then noticed that this patch suddenly fixes this bug.
256 2009-11-28T17:08:40 <ThomasWaldmann> and i for sure won't accept it being "on" by default, i don't want to have lots of crap redirect pages in the wiki, just because people forget to deselect the option
257 2009-11-28T17:09:02 <ThomasWaldmann> anyway, gtg/bbl
258 2009-11-28T17:09:23 <eSyr> ThomasWaldmann, it isn't "on".
259 2009-11-28T17:09:28 <eSyr> ThomasWaldmann, good bye
260 2009-11-28T17:09:37 <eSyr> (by default)
261 2009-11-28T17:23:41 <dreimark> re
262 2009-11-28T17:25:21 <eSyr> hello, dreimark.
263 2009-11-28T17:34:05 <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5315:329241cd48b6 1.9/MoinMoin/action/login.py: action.login: bug fix for MoinMoinBugs/LoginDialogIfLoggedIn. A valid user is redirected to the page without the login form.
264 2009-11-28T17:55:57 <CIA-34> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5316:5060bec6a284 1.9/MoinMoin/xmlrpc/__init__.py:
265 2009-11-28T17:55:57 <CIA-34> xmlrpc.__init__: bug fix for MoinMoinBugs/1.6XmlRpcPutPagePagenameEscape
266 2009-11-28T17:55:57 <CIA-34> the pagename must be normalized
267 2009-11-28T18:04:03 <dreimark> hi eSyr
268 2009-11-28T18:16:30 <dreimark> TheSheep: ideas wanted http://moinmo.in/MoinMoinBugs/HeadingIdConfusion
269 2009-11-28T18:24:35 <dreimark> bbl
270 2009-11-28T22:48:24 <ThomasWaldmann> re
271 2009-11-28T22:48:56 * ThomasWaldmann returned from "2012" :)
272 2009-11-28T22:54:49 <eSyr> oh, shi.
273 2009-11-28T22:55:26 <eSyr> ever emerich's film is worst.
274 2009-11-28T22:56:06 <eSyr> *emmerich
275 2009-11-28T22:57:21 * ThomasWaldmann found it quite nice. well, at least the effects were overwhelming.
276 2009-11-28T22:58:31 <ThomasWaldmann> of course it's not that realistic, but don't the heroes always survive and get the girl? :D
277 2009-11-28T23:00:26 <eSyr> well, i think, i shouldn't discuss modern films, my flavours are rather specific.
278 2009-11-28T23:01:16 <eSyr> (at least, unpopular, comparing them by revenues)
279 2009-11-28T23:01:46 <ThomasWaldmann> for example?
280 2009-11-28T23:02:29 <eSyr> well, i don't like manymodern films.
281 2009-11-28T23:04:14 <eSyr> and some of films which i like have bad revenue or critics reception.
282 2009-11-28T23:05:41 <ThomasWaldmann> well, who cares for revenues or critics (except the industry :)
283 2009-11-28T23:06:43 <dreimark> v
284 2009-11-28T23:06:47 <eSyr> well, revenues are significant: they reveals, what mob likes and what have success, and those sort of films are repeating.
285 2009-11-28T23:07:35 <eSyr> for example, i know very small amount of successfull good films.
286 2009-11-28T23:08:20 <eSyr> less than 1999—2004 and much less than 1994—1999/
287 2009-11-28T23:09:40 * dreimark reads FR
288 2009-11-28T23:09:50 <eSyr> i'm afraid that in next five yers i will not be able to go to the cinema and watch somthing intresting, Only indy, arthouse (which in many cases i can't at least understand, not even enjoy) or something.
289 2009-11-28T23:10:58 <ThomasWaldmann> there are still google tech talks :D
290 2009-11-28T23:11:51 <eSyr> yeah :)
291 2009-11-28T23:19:17 * ThomasWaldmann continues on rc2
292 2009-11-28T23:19:59 <eSyr> oh, there will be rc2.
293 2009-11-28T23:20:13 <eSyr> good.
294 2009-11-28T23:22:31 <ThomasWaldmann> yay, xapian searching WHILE index rebuilding works
295 2009-11-28T23:22:54 <eSyr> hehe, as it should after your commit :)
296 2009-11-28T23:23:15 <eSyr> excuse me for annoying you,but if you'll checkpatches forcreating redirects on renaming it will be great.
297 2009-11-28T23:24:01 <eSyr> (because it is one of those few fetaures which has mw and moin still hasn't)
298 2009-11-28T23:26:05 <dreimark> TheSheep: http://moinmo.in/FeatureRequests/AddQuestionMarkSmiley
299 2009-11-28T23:26:54 <ThomasWaldmann> eSyr: what's that ="1" if not enabling?
300 2009-11-28T23:27:19 <eSyr> err, by default it's 0.
301 2009-11-28T23:29:54 <ThomasWaldmann> could you use .get() please?
302 2009-11-28T23:30:07 <eSyr> oh, ok.
303 2009-11-28T23:31:28 <ThomasWaldmann> that makes 1 line instead of 5 :)
304 2009-11-28T23:31:46 <eSyr> yes, i know.
305 2009-11-28T23:33:26 <ThomasWaldmann> hah, the code display talks russian to me X)
306 2009-11-28T23:33:43 <eSyr> err, what?
307 2009-11-28T23:34:22 <ThomasWaldmann> Переключить отображение номеров строк
308 2009-11-28T23:34:59 <eSyr> oh, suddenly.
309 2009-11-28T23:36:02 <eSyr> and remaining interface is normal?
310 2009-11-28T23:37:42 <ThomasWaldmann> yes, it's likely a caching related bug
311 2009-11-28T23:38:01 <ThomasWaldmann> do you see english now?
312 2009-11-28T23:38:23 <eSyr> well, i use russian interface and see russian messages.
313 2009-11-28T23:39:10 <ThomasWaldmann> really?
314 2009-11-28T23:39:25 <ThomasWaldmann> i deleted the cache and would've expected you see english now
315 2009-11-28T23:40:29 <eSyr> oh, yes.
316 2009-11-28T23:40:45 <eSyr> (i didn't refreshed page, sorry)
317 2009-11-28T23:42:00 <dreimark> ThomasWaldmann: refresh page cache
318 2009-11-28T23:44:56 <dreimark> eSyr: the caching should change it dependent on a different default lang
319 2009-11-28T23:45:59 <dreimark> ThomasWaldmann: http://moinmo.in/FeatureRequests why is that not alphabetical sorted
320 2009-11-28T23:48:02 <eSyr> ThomasWaldmann, i've fixed patch
321 2009-11-28T23:48:59 <dreimark> gn
322 2009-11-28T23:52:18 <ThomasWaldmann> gn dreimark
323 2009-11-28T23:52:49 <eSyr> dreimark, good night
324 2009-11-28T23:54:48 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5317:c3316c25365c 1.9/docs/CHANGES: updated CHANGES
325 2009-11-28T23:54:50 <CIA-34> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5318:5dc9e1f2a640 1.9/MoinMoin/ (action/login.py xmlrpc/__init__.py): merged main
