1 2009-11-16T00:01:59 <ThomasWaldmann> well, I would have guessed that data contains the complete url from the html
2 2009-11-16T00:03:04 <JosefMeier> no. it doesnt
3 2009-11-16T00:03:13 <JosefMeier> the server address is missing
4 2009-11-16T00:03:30 <ThomasWaldmann> 39..43 is strange. what you got is a MultiDict, why are you "searching" over its items, if you already know what you want?
5 2009-11-16T00:03:37 <JosefMeier> it contains scriptpath?action=...
6 2009-11-16T00:03:53 <ThomasWaldmann> that is not just a querystring
7 2009-11-16T00:04:08 <JosefMeier> ThomasWaldmann: there is a dict key "/test?action"
8 2009-11-16T00:04:19 <ThomasWaldmann> (the part after the ? is called qs)
9 2009-11-16T00:04:49 <ThomasWaldmann> yeah, it is because you are feeding it with unexpected stuff
10 2009-11-16T00:04:59 <JosefMeier> but ...
11 2009-11-16T00:05:01 <JosefMeier> umpf
12 2009-11-16T00:05:19 <ThomasWaldmann> decode_url is a bit a misnomer, it should be rather decode_qs
13 2009-11-16T00:05:36 <JosefMeier> yes
14 2009-11-16T00:05:41 <ThomasWaldmann> so, search the lib again :)
15 2009-11-16T00:05:45 <JosefMeier> can't we leave it as it is?
16 2009-11-16T00:05:50 <ThomasWaldmann> no
17 2009-11-16T00:05:56 <JosefMeier> I'm mean ... shall I beg for having that in 1.9 :-D ???
18 2009-11-16T00:06:16 <JosefMeier> Are you the male version of Heidi Klum :-) ?
19 2009-11-16T00:06:26 <ThomasWaldmann> you have a few days left :)
20 2009-11-16T00:06:31 <JosefMeier> f**ck
21 2009-11-16T00:06:42 <ThomasWaldmann> as you might have seen, I did rather big changes to xapian indexing
22 2009-11-16T00:07:00 <JosefMeier> And?
23 2009-11-16T00:07:06 <ThomasWaldmann> that means: some testing on moinmo.in, and likely also a rc2
24 2009-11-16T00:07:38 <ThomasWaldmann> so you have time until rc2
25 2009-11-16T00:08:15 <ThomasWaldmann> also, the translators should get a chance to translate the few new strings
26 2009-11-16T00:08:27 <ThomasWaldmann> dreimark: fix the string into final state asap
27 2009-11-16T00:09:22 <ThomasWaldmann> who is heidi klum? :)
28 2009-11-16T00:10:03 <JosefMeier> welcome in 2009 ;-)
29 2009-11-16T00:13:31 <JosefMeier> I think it's ok to split the qs by ? and then send it to url_decode ?
30 2009-11-16T00:20:26 <ThomasWaldmann> JosefMeier: http://docs.python.org/library/urlparse.html
31 2009-11-16T00:21:11 <JosefMeier> I know. But urlparse needs a complete url. process_object doesn't get that
32 2009-11-16T00:21:36 <ThomasWaldmann> you have a complete url
33 2009-11-16T00:21:46 <dreimark> ThomasWaldmann: eSyr Syntax highlighting of \"%s\" not supported, see HelpOnSyntaxHighlighting.
34 2009-11-16T00:22:10 <ThomasWaldmann> no \
35 2009-11-16T00:22:40 <ThomasWaldmann> and the page name should not be directly included there, but be a named placeholder
36 2009-11-16T00:23:27 <JosefMeier> and where do I get the complete url from?
37 2009-11-16T00:23:33 <JosefMeier> data doesn't contain it
38 2009-11-16T00:24:13 <ThomasWaldmann> Syntax highlighting not supported for '%(syntax)s', see %(highlight_help_page)s.
39 2009-11-16T00:24:23 <ThomasWaldmann> it does
40 2009-11-16T00:24:28 <JosefMeier> data = data attribute from the object tag coming from fckeditor
41 2009-11-16T00:24:51 <JosefMeier> and this doesn't contain the server data but only everything after that
42 2009-11-16T00:24:57 <ThomasWaldmann> btw, / is a complete url :)
43 2009-11-16T00:25:07 <JosefMeier> ?
44 2009-11-16T00:25:10 <JosefMeier> hm
45 2009-11-16T00:25:22 <JosefMeier> you mean urlparse doesn't need the server address?
46 2009-11-16T00:25:26 <ThomasWaldmann> no
47 2009-11-16T00:25:40 <ThomasWaldmann> guess why it can result in empty parts
48 2009-11-16T00:26:46 <ThomasWaldmann> (and if you only have a path, the user agent will just use same protocol, same server, same port)
49 2009-11-16T00:28:31 <JosefMeier> ahhh
50 2009-11-16T00:28:35 <JosefMeier> seems to work :-)
51 2009-11-16T00:28:39 <JosefMeier> damn it.
52 2009-11-16T00:35:44 <JosefMeier> ThomasWaldmann: http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/178053e34906
53 2009-11-16T00:36:12 <JosefMeier> Is it ok to commit it now?
54 2009-11-16T00:39:17 <ThomasWaldmann> impatient? :)
55 2009-11-16T00:40:08 <JosefMeier> I have so much stuff in the pipeline. This patch is only the beginning ;-)
56 2009-11-16T00:41:10 <ThomasWaldmann> getting better, but still missing good names
57 2009-11-16T00:41:16 <JosefMeier> ???
58 2009-11-16T00:41:28 <ThomasWaldmann> you know how the url components are called?
59 2009-11-16T00:41:33 <JosefMeier> no
60 2009-11-16T00:41:37 <ThomasWaldmann> (see urlparse)
61 2009-11-16T00:42:23 <ThomasWaldmann> and then just use foo, bar, baz, ... = urlparse.urlparse(url)
62 2009-11-16T00:43:22 <ThomasWaldmann> decodedUrl -> args (or query_args, if you like)
63 2009-11-16T00:45:02 <ThomasWaldmann> (see also request.args, that uses same attribute name for same thing)
64 2009-11-16T00:45:33 <ThomasWaldmann> code gets so much easier to read with good names :)
65 2009-11-16T00:45:55 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/fb4cfaa4d1f2
66 2009-11-16T00:46:32 <ThomasWaldmann> you don't need a # Parse URL comment btw, if the next line reads ... urlparse(...) :)
67 2009-11-16T00:47:18 <JosefMeier> ThomasWaldmann: I hope you're having fun
68 2009-11-16T00:48:19 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/28ae18437e09
69 2009-11-16T00:48:19 <ThomasWaldmann> I hope you're learning. :)
70 2009-11-16T00:48:35 <JosefMeier> I hope we never met in reality :-
71 2009-11-16T00:48:42 <JosefMeier> my mouth is missing
72 2009-11-16T00:50:48 <ThomasWaldmann> ?
73 2009-11-16T00:51:19 <JosefMeier> from my smiley
74 2009-11-16T00:51:30 <JosefMeier> Is the code okay now?
75 2009-11-16T00:51:51 <ThomasWaldmann> well, if you would just fix everything at once, it would proceed faster
76 2009-11-16T00:52:02 <JosefMeier> the next time ;-)
77 2009-11-16T00:53:24 <ThomasWaldmann> The return value is actually an instance of a subclass of tuple. This class has the following additional read-only convenience attributes:
78 2009-11-16T00:53:39 <ThomasWaldmann> did you read that and the table below?
79 2009-11-16T00:53:50 <JosefMeier> from what?
80 2009-11-16T00:54:03 <ThomasWaldmann> http://docs.python.org/library/urlparse.html
81 2009-11-16T00:54:19 <JosefMeier> which return value?
82 2009-11-16T00:55:11 <ThomasWaldmann> hmm, no, ignore that.
83 2009-11-16T00:55:15 <ThomasWaldmann> doesn't work for 2.4
84 2009-11-16T00:55:20 <JosefMeier> ok. thanks :-)
85 2009-11-16T00:55:30 <ThomasWaldmann> but still you could use those names from the table
86 2009-11-16T00:56:09 <ThomasWaldmann> if you call the path "path", it is much easier to understand than if you call it "pagename"
87 2009-11-16T00:56:15 <ThomasWaldmann> or "url" or whatever
88 2009-11-16T00:57:19 * ThomasWaldmann meanwhile checks the semantics
89 2009-11-16T00:57:20 <JosefMeier> I mistyped it. It should be called path instead of url
90 2009-11-16T00:58:24 <ThomasWaldmann> what happens if qs does not have target=...?
91 2009-11-16T00:59:12 <JosefMeier> this never can happen (i guess)
92 2009-11-16T01:00:02 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/cdfe235c958b
93 2009-11-16T01:00:14 <ThomasWaldmann> famous last words :D
94 2009-11-16T01:01:15 <ThomasWaldmann> {{http://google.com/google.png}}
95 2009-11-16T01:02:11 <JosefMeier> ?
96 2009-11-16T01:02:56 <ThomasWaldmann> there is no target=...
97 2009-11-16T01:03:34 <JosefMeier> It never reaches process_object
98 2009-11-16T01:04:01 <ThomasWaldmann> {{http://google.com/google.pdf}} ? :)
99 2009-11-16T01:04:59 <JosefMeier> the same
100 2009-11-16T01:06:27 <ThomasWaldmann> >>> url_decode("")["target"]
101 2009-11-16T01:06:27 <ThomasWaldmann> Traceback (most recent call last):
102 2009-11-16T01:06:27 <ThomasWaldmann> File "<stdin>", line 1, in <module>
103 2009-11-16T01:06:27 <ThomasWaldmann> File "werkzeug/datastructures.py", line 283, in __getitem__
104 2009-11-16T01:06:27 <ThomasWaldmann> raise self.KeyError(key)
105 2009-11-16T01:06:29 <ThomasWaldmann> werkzeug.datastructures.KeyError: 'target'
106 2009-11-16T01:07:06 <ThomasWaldmann> >>> repr(url_decode("").get("target"))
107 2009-11-16T01:07:06 <ThomasWaldmann> 'None'
108 2009-11-16T01:07:46 <JosefMeier> where did you get this message from?
109 2009-11-16T01:07:56 <ThomasWaldmann> from python :)
110 2009-11-16T01:08:34 <ThomasWaldmann> (I just tried it out on the interpreter)
111 2009-11-16T01:08:55 <JosefMeier> I copied {{http://google.com/google.png}} on my live demo site. nothing happened there
112 2009-11-16T01:09:10 <JosefMeier> http://s15358202.onlinehome-server.info/1.9_modified/test
113 2009-11-16T01:10:36 <ThomasWaldmann> yes, because it creates <img> for png
114 2009-11-16T01:10:56 <ThomasWaldmann> but anyway: why not write robust code if it is easy?
115 2009-11-16T01:11:09 <JosefMeier> but I don't get errors on the live demo
116 2009-11-16T01:11:29 <JosefMeier> and process_object shouldn't be called with no attachments
117 2009-11-16T01:11:42 <ThomasWaldmann> you will as soon as you get some object data ref that has no target=, obviously
118 2009-11-16T01:12:22 <ThomasWaldmann> html <object> tag is not limited to moin attachments
119 2009-11-16T01:12:22 <JosefMeier> What should I change?
120 2009-11-16T01:12:38 <ThomasWaldmann> maybe currently we don't create such html, not sure
121 2009-11-16T01:12:42 <ThomasWaldmann> use .get
122 2009-11-16T01:13:55 <JosefMeier> ?
123 2009-11-16T01:14:03 <ThomasWaldmann> dr. evil of course would feed {{http://someotherwiki/Pagename?action=AttachFile&target=foo}} :D
124 2009-11-16T01:14:27 <ThomasWaldmann> i showed you at 01:06
125 2009-11-16T01:14:51 <ThomasWaldmann> or rather 01:07
126 2009-11-16T01:15:23 <ThomasWaldmann> btw, if you feel tired, we don't need to finish that now
127 2009-11-16T01:15:25 <JosefMeier> I also don't get an error on my live demo site with this
128 2009-11-16T01:15:45 <JosefMeier> I would like to finish that now. 10 hours is worth that ;-)
129 2009-11-16T01:16:21 <ThomasWaldmann> if you access a (multi)dict with a now existing key, it WILL blow up with a KeyError
130 2009-11-16T01:16:55 <JosefMeier> can you give me a hint how to make my code robust? then maybe we could finish this session
131 2009-11-16T01:17:07 <ThomasWaldmann> thus, it is not: targetname = decodedUrl["target"], but targetname = decodeUrl.get("target")
132 2009-11-16T01:18:04 <JosefMeier> Ok. What else?
133 2009-11-16T01:18:13 <ThomasWaldmann> same server check, somehow
134 2009-11-16T01:18:21 <JosefMeier> why?
135 2009-11-16T01:18:26 <ThomasWaldmann> see 01:14 dr. evil :)
136 2009-11-16T01:19:38 <JosefMeier> how could I fix that?
137 2009-11-16T01:20:01 <ThomasWaldmann> maybe just check "not scheme and not netloc". that is maybe not perfect, but iirc moin doesn't create scheme and netloc for attachments
138 2009-11-16T01:20:37 <JosefMeier> uhm. and were do I have to check for that?
139 2009-11-16T01:22:12 <ThomasWaldmann> before you decide to refer to a local attachment
140 2009-11-16T01:22:36 <ThomasWaldmann> btw, you're lucky, AttachFile doesn't use url_prefix_action
141 2009-11-16T01:22:56 <JosefMeier> this means? I have to change nothing
142 2009-11-16T01:22:57 <JosefMeier> ?
143 2009-11-16T01:23:46 <ThomasWaldmann> currently your code will happily create a reference to a local attachment if it gets a url to a remove wiki's attachment
144 2009-11-16T01:24:40 <ThomasWaldmann> maybe we should use a shared editor :)
145 2009-11-16T01:25:51 <JosefMeier> :-)
146 2009-11-16T01:25:58 <JosefMeier> So ... how do we proceed?
147 2009-11-16T01:31:22 <ThomasWaldmann> http://paste.pocoo.org/show/150924/ (original, wait for reply)
148 2009-11-16T01:36:30 <JosefMeier> ok
149 2009-11-16T01:37:39 <ThomasWaldmann> http://paste.pocoo.org/show/150925/ (not tested)
150 2009-11-16T01:38:33 <ThomasWaldmann> s/targetname/attachname/
151 2009-11-16T01:39:48 <ThomasWaldmann> btw, the url_unquote call might be a bit misplaced
152 2009-11-16T01:40:21 <ThomasWaldmann> that likely should only process pagename, not everything
153 2009-11-16T01:42:34 * ThomasWaldmann kills misbehaving gnome-panel
154 2009-11-16T01:43:25 * ThomasWaldmann creates a better reply
155 2009-11-16T01:45:02 * JosefMeier testing
156 2009-11-16T01:46:02 <ThomasWaldmann> http://paste.pocoo.org/show/150927/
157 2009-11-16T01:46:20 <ThomasWaldmann> looks like not many people are using that pastebin right now :=)
158 2009-11-16T01:49:54 <ThomasWaldmann> btw, please test with non-ascii pagename / attachname, just to make sure :)
159 2009-11-16T01:51:49 <ThomasWaldmann> btw, maybe use: import urlparse .... urlparse.urlparse(...)
160 2009-11-16T01:52:05 <ThomasWaldmann> (that makes it more clear where it comes from)
161 2009-11-16T01:53:52 <JosefMeier> Ok. It works
162 2009-11-16T01:53:59 <JosefMeier> Can we commit it now :-) ?
163 2009-11-16T01:54:11 <ThomasWaldmann> changeset url?
164 2009-11-16T01:54:40 <JosefMeier> http://s15358202.onlinehome-server.info/hg/moin-19-modified-clean-changesets/rev/dca103c60cf8
165 2009-11-16T01:54:48 <ThomasWaldmann> did you try ümlauts?
166 2009-11-16T01:54:57 <JosefMeier> yes. I tried it with flürzel.pdf
167 2009-11-16T01:55:10 <ThomasWaldmann> pagename also?
168 2009-11-16T01:56:30 <ThomasWaldmann> ok, import change please, add a comment about the "type" exclusion in the list comprehension ("why?") and then we commit
169 2009-11-16T01:56:36 <ThomasWaldmann> ah, and run py.test over it all
170 2009-11-16T01:57:11 <ThomasWaldmann> if 12 and 20 are accidental changes, please revert those lines
171 2009-11-16T01:57:42 <ThomasWaldmann> aka "create clean changesets"
172 2009-11-16T01:59:52 <JosefMeier> hm. with umlaut pagenames it doesn't include the pdf on the destination page
173 2009-11-16T02:00:28 <JosefMeier> I wrote {{attachment:trüstel/märtyrer.pdf}}
174 2009-11-16T02:00:39 <JosefMeier> märtyrer.pdf lies on page trüstel
175 2009-11-16T02:00:56 <JosefMeier> but it isn't shown on page test where the transclusion markup was written on
176 2009-11-16T02:01:04 <ThomasWaldmann> blog.fefe.de
177 2009-11-16T02:01:39 <ThomasWaldmann> oops
178 2009-11-16T02:01:43 <ThomasWaldmann> html?
179 2009-11-16T02:01:51 <JosefMeier> hm?
180 2009-11-16T02:02:01 <ThomasWaldmann> data="...?
181 2009-11-16T02:03:58 <JosefMeier> hm. look at http://s15358202.onlinehome-server.info/1.9_modified/test
182 2009-11-16T02:04:04 <JosefMeier> it doesnt create an object
183 2009-11-16T02:07:25 <ThomasWaldmann> it generates link html for me
184 2009-11-16T02:08:13 <ThomasWaldmann> bug! :)
185 2009-11-16T02:08:50 <ThomasWaldmann> ok, so for now, we assume that your code works for nonascii pagenames :)
186 2009-11-16T02:09:52 <ThomasWaldmann> if you have done all the changes, you could export a changeset and mail it to me, then I could just import it
187 2009-11-16T02:10:12 <ThomasWaldmann> or a diff, but then it'll use my name as author
188 2009-11-16T02:11:37 <JosefMeier> why does it create a link html ?
189 2009-11-16T02:13:24 <JosefMeier> hg export <changesetname> ?
190 2009-11-16T02:15:05 <ThomasWaldmann> http://www.skytopia.com/project/fractal/mandelbulb.html
191 2009-11-16T02:15:09 <ThomasWaldmann> it's a bug
192 2009-11-16T02:15:19 <JosefMeier> from me
193 2009-11-16T02:15:19 <ThomasWaldmann> hg export --help
194 2009-11-16T02:15:21 <JosefMeier> ?
195 2009-11-16T02:15:25 <ThomasWaldmann> no
196 2009-11-16T02:15:38 <JosefMeier> ah. so we should fix that tomorrow
197 2009-11-16T02:15:44 <JosefMeier> ah. so we should fix that today
198 2009-11-16T02:15:48 <ThomasWaldmann> :)
199 2009-11-16T02:15:55 <JosefMeier> :-)
200 2009-11-16T02:16:29 <dreimark> do we have already somewhere an example where a wikiname is rendered in a msg text?
201 2009-11-16T02:16:45 <JosefMeier> dreimark ... you guys never sleep, hm?
202 2009-11-16T02:17:32 <dreimark> i can't believe that I need wikiutil.renderText
203 2009-11-16T02:17:34 <dreimark> http://paste.pocoo.org/show/150929/
204 2009-11-16T02:17:55 <dreimark> JosefMeier: i sleep soon
205 2009-11-16T02:19:27 <JosefMeier> ThomasWaldmann: http://paste.pocoo.org/show/150930/ Is that what you need?
206 2009-11-16T02:19:30 <ThomasWaldmann> how about using formatter?
207 2009-11-16T02:21:05 <ThomasWaldmann> did you read 01:56?
208 2009-11-16T02:21:15 <ThomasWaldmann> and 01:57?
209 2009-11-16T02:23:48 <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/150933/ didn't work as I thought
210 2009-11-16T02:24:11 <dreimark> gives Syntax highlighting not supported for 'pythons', see <a href="/HelpOnSyntaxHighlighting">HelpOnSyntaxHighlighting</a>.
211 2009-11-16T02:24:34 <dreimark> (no link, text)
212 2009-11-16T02:24:55 <ThomasWaldmann> because it runs through text formatter somewhere
213 2009-11-16T02:25:03 <ThomasWaldmann> maybe just drop the link for now
214 2009-11-16T02:25:17 <dreimark> yes, but i wonder why renderText makes it
215 2009-11-16T02:25:40 <ThomasWaldmann> it happens in codearea, likely
216 2009-11-16T02:25:45 <dreimark> renderText works but it is a bit ugly
217 2009-11-16T02:31:47 <ThomasWaldmann> no ugly hacks early in the morning :)
218 2009-11-16T02:32:35 <dreimark> yeah or late in the evening
219 2009-11-16T02:34:43 <JosefMeier> ThomasWaldmann: http://paste.pocoo.org/show/150934/ ???
220 2009-11-16T02:36:06 <CIA-43> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5285:be3d5338f0a3 1.9/MoinMoin/parser/highlight.py: parser highlight: error message changed
221 2009-11-16T02:39:22 <dreimark> JosefMeier: (k, v) for k, v may be look with pylint
222 2009-11-16T02:39:34 <dreimark> it should tell a pep8 violation
223 2009-11-16T02:40:49 <dreimark> gn
224 2009-11-16T02:40:55 <JosefMeier> gn
225 2009-11-16T02:41:02 <JosefMeier> ThomasWaldmann: Commit it :D !!!!
226 2009-11-16T02:42:47 * ThomasWaldmann looks
227 2009-11-16T02:47:28 <CIA-43> Josef Meier <jo.meier@gmx.de> default * 5286:668606f6a255 1.9/MoinMoin/converter/text_html_text_moin_wiki.py: Roundtripping works now for PDF, Doc, ...from GUI editor to text editor and vice versa.
228 2009-11-16T02:47:55 <ThomasWaldmann> and later we talk about good commit comments :)
229 2009-11-16T02:48:00 <ThomasWaldmann> JosefMeier: ^^
230 2009-11-16T02:48:13 <JosefMeier> yiehaaa :-D :-D :-D
231 2009-11-16T02:49:02 <JosefMeier> Omg. And that all for my new image dialog. My wife's almost killing me ;-)
232 2009-11-16T02:49:10 <JosefMeier> Good night, Thomas
233 2009-11-16T02:49:15 <ThomasWaldmann> gn :)
234 2009-11-16T02:49:15 <JosefMeier> And thanks for the review
235 2009-11-16T02:49:44 <ThomasWaldmann> you're welcome
236 2009-11-16T02:51:36 *** JosefMeier
237 2009-11-16T04:06:49 *** grzywacz
238 2009-11-16T04:29:00 *** eSyr
239 2009-11-16T05:49:38 *** eSyr
240 2009-11-16T07:23:50 <eSyr> dreimark, ThomasWaldmann, http://moinmo.in/MacroMarket/PygmentsLexerList
241 2009-11-16T07:31:15 <ThomasWaldmann> ah, great. moin eSyr!
242 2009-11-16T07:31:39 <eSyr> moin, Thomas.
243 2009-11-16T07:32:38 <ThomasWaldmann> if you tell sort=True in the macro head, doesn't it typecheck that anyway, so you don't need line 46?
244 2009-11-16T07:33:50 <eSyr> mmm, in new macro system type conversions made automagically?
245 2009-11-16T07:35:03 <ThomasWaldmann> http://hg.moinmo.in/moin/1.9/file/668606f6a255/MoinMoin/wikiutil.py#l1481
246 2009-11-16T07:35:26 <ThomasWaldmann> yes, you don't even need to call that code ^^
247 2009-11-16T07:35:36 <eSyr> oh, hehe, how many times i've done it manually -_-
248 2009-11-16T07:37:09 <ThomasWaldmann> and if you use a tuple of unicode, you can define choices
249 2009-11-16T07:37:38 <ThomasWaldmann> http://hg.moinmo.in/moin/1.9/file/668606f6a255/MoinMoin/wikiutil.py#l1755
250 2009-11-16T07:37:49 <ThomasWaldmann> that is the thing doing all the magic
251 2009-11-16T07:38:05 <eSyr> mmm, like ('name', 'aliases', 'patterns', 'mimetypes') forsort_column?
252 2009-11-16T07:38:25 * eSyr reading code
253 2009-11-16T07:40:09 <ThomasWaldmann> yes
254 2009-11-16T07:40:31 <eSyr> ok, i've understood.
255 2009-11-16T07:40:36 <ThomasWaldmann> 33 import pygments.lexers as lexers -> as you only need that once, better don't use "as lexers"
256 2009-11-16T07:41:12 <eSyr> ok.
257 2009-11-16T07:41:39 <ThomasWaldmann> there are some pep8 errors (spacing), license is same as moin?
258 2009-11-16T07:41:56 <eSyr> yes, GNU GPL.
259 2009-11-16T07:42:32 <ThomasWaldmann> ok, after some few fixes we'll commit that into 1.9 :)
260 2009-11-16T07:42:41 <eSyr> ehrm, can you repeat, where pep8 checker is placed?
261 2009-11-16T07:42:56 <ThomasWaldmann> do you have py.test installed?
262 2009-11-16T07:43:07 <eSyr> hm, i think no
263 2009-11-16T07:43:12 * eSyr apt-caches
264 2009-11-16T07:43:28 <ThomasWaldmann> codespeak py lib or so
265 2009-11-16T07:43:43 <eSyr> yes, python-codespeak-lib.
266 2009-11-16T07:44:17 <ThomasWaldmann> just install it and then run py.test from the toplevel dir (above MoinMoin/)
267 2009-11-16T07:44:36 <eSyr> ok.
268 2009-11-16T07:44:45 <ThomasWaldmann> it will run all tests, including test_sourcecode which checks for pep8 and similar stuff
269 2009-11-16T07:45:08 <ThomasWaldmann> and just put your macro into MoinMoin/macro/ before that
270 2009-11-16T07:45:50 <eSyr> oh shi—
271 2009-11-16T07:46:46 * eSyr .oO( thanks to 5000 scrollback terminal, i haven't need run it one more time in less )
272 2009-11-16T07:47:24 <ThomasWaldmann> :D
273 2009-11-16T07:47:49 <ThomasWaldmann> btw, the pep8 checker only fails for first thing of a kind
274 2009-11-16T07:48:10 <ThomasWaldmann> thus, you'll have to rerun it until it doesn't fail any more
275 2009-11-16T07:48:26 <eSyr> ehrm.
276 2009-11-16T07:48:33 <eSyr> i think i'm missing something
277 2009-11-16T07:48:38 <ThomasWaldmann> py.test -k source # will only run that
278 2009-11-16T07:48:42 <eSyr> (and 5000 lines didn't save me)
279 2009-11-16T07:49:08 <eSyr> oh, ok.
280 2009-11-16T07:49:43 <ThomasWaldmann> about the macro name:
281 2009-11-16T07:49:49 <eSyr> yes?
282 2009-11-16T07:49:57 <ThomasWaldmann> PygmentsLexerList is very precise and specific
283 2009-11-16T07:50:22 <eSyr> well, this macro done exact this thing.
284 2009-11-16T07:50:26 <eSyr> *do
285 2009-11-16T07:50:28 <ThomasWaldmann> it could just happen that user doesn't relate that to highlight parser
286 2009-11-16T07:50:29 <eSyr> *does
287 2009-11-16T07:50:49 <eSyr> oh, i haven't though about it.
288 2009-11-16T07:51:28 <ThomasWaldmann> so for a end user not caring about how it works internally, HighlighterList() could be easier, not sure
289 2009-11-16T07:51:55 <eSyr> but, on other hand, this parser is supposed to be used only on HelpOnSyntaxHighlighting page.
290 2009-11-16T07:51:59 <eSyr> ok, i'll rename it.
291 2009-11-16T07:52:12 <ThomasWaldmann> yes, so end user doesn't need to know
292 2009-11-16T07:52:27 <ThomasWaldmann> i guess it doesn't make a big difference
293 2009-11-16T07:52:47 <eSyr> ye. of course.
294 2009-11-16T07:53:23 <ThomasWaldmann> that was a short night, eh? :)
295 2009-11-16T07:53:55 <eSyr> well, at least it was :)
296 2009-11-16T07:54:26 <eSyr> (i've slept for 4 hours, but i'm not sleepy now for unknown reason)
297 2009-11-16T07:56:47 <ThomasWaldmann> http://master19.moinmo.in/HelpOnFormatting?highlight=(highlight)
298 2009-11-16T07:57:32 <ThomasWaldmann> http://master19.moinmo.in/HelpOnParsers?highlight=(highlight)
299 2009-11-16T07:58:16 <ThomasWaldmann> http://master19.moinmo.in/HelpOnMoinWikiSyntax?highlight=(highlight)
300 2009-11-16T08:00:19 <ThomasWaldmann> http://master19.moinmo.in/HelpOnCreoleSyntax?highlight=(highlight)
301 2009-11-16T08:00:34 <eSyr> data_underlay_dir "/data/programs/moin-1.9.0rc1/MoinMoin/_tests/../../tests/wiki/underlay" does not exist, or has incorrect ownership or permissions.
302 2009-11-16T08:00:39 <ThomasWaldmann> that's all places afaics where highlight is referenced
303 2009-11-16T08:00:45 <eSyr> (i think i'm missing something)
304 2009-11-16T08:00:52 <ThomasWaldmann> are you working from a repo?
305 2009-11-16T08:01:25 <eSyr> hehe, i'm fixing this now
306 2009-11-16T08:01:34 <ThomasWaldmann> or from release archive unpacked?
307 2009-11-16T08:01:40 <eSyr> release archive.
308 2009-11-16T08:01:45 <ThomasWaldmann> cd wiki/
309 2009-11-16T08:01:59 <ThomasWaldmann> tar cf underlay.tar underlay # make it happy
310 2009-11-16T08:02:33 <ThomasWaldmann> it is because we don't have all underlay pages seperately in the repo, just that tar file
311 2009-11-16T08:03:17 <ThomasWaldmann> but otoh, we don't bundle the tar with the release, but we pack the pagepacks
312 2009-11-16T08:05:31 <eSyr> well, now i'm working from repo :)
313 2009-11-16T08:06:41 <ThomasWaldmann> make sure you create your ~/.hgrc with good username before committing
314 2009-11-16T08:10:03 <ThomasWaldmann> xapian seems to behave rather well (when looking at amount of changes)
315 2009-11-16T08:10:17 <ThomasWaldmann> i just used your upload to check whether it got indexed
316 2009-11-16T08:13:08 <eSyr> heh, cool.
317 2009-11-16T08:13:52 <eSyr> heh, it treats as error even trailing whitespaces inside docstrings
318 2009-11-16T08:15:51 <ThomasWaldmann> yeah, it is quite picky about stuff
319 2009-11-16T08:16:28 <ThomasWaldmann> but that helps keeping code fluctuations low, esp. if one runs it before committing
320 2009-11-16T08:16:52 <eSyr> yes, i inderstand.
321 2009-11-16T08:17:39 <ThomasWaldmann> it's not a complete pep8 checker btw, some stuff it doesn't find, some stuff it misdetects
322 2009-11-16T08:17:46 <ThomasWaldmann> but better than nothing
323 2009-11-16T08:18:04 <ThomasWaldmann> i additionally have that vim plugin
324 2009-11-16T08:18:15 <ThomasWaldmann> same holds true for this, btw
325 2009-11-16T08:18:29 <eSyr> hm, is there any analog of gitk in hg?
326 2009-11-16T08:18:46 <ThomasWaldmann> gui interface?
327 2009-11-16T08:19:04 <ThomasWaldmann> (i don't know git tools)
328 2009-11-16T08:19:13 <eSyr> yes.
329 2009-11-16T08:19:32 <ThomasWaldmann> I am sure there is, but i don't use it.
330 2009-11-16T08:19:43 <eSyr> oh, ok.
331 2009-11-16T08:19:47 <ThomasWaldmann> either console or web for me.
332 2009-11-16T08:19:59 <ThomasWaldmann> hg serve # does web locally
333 2009-11-16T08:21:27 * ThomasWaldmann is very happy with hg and didn't need git yet
334 2009-11-16T08:22:39 <eSyr> well, and you'll don't need until begin hacking Linux kernel :)
335 2009-11-16T08:23:26 <eSyr> http://moinmo.in/MacroMarket/HighlighterList?action=AttachFile&do=view&target=HighlighterList-1.9.0-2.py
336 2009-11-16T08:23:46 <ThomasWaldmann> I guess I won't. I am so happy with Python, I don't miss C much. :D
337 2009-11-16T08:24:33 <eSyr> You do not write kernel drivers.
338 2009-11-16T08:24:47 <ThomasWaldmann> yeah
339 2009-11-16T08:24:51 <ThomasWaldmann> typo in 9
340 2009-11-16T08:24:52 <eSyr> (but, with fuse, you can do even this with Python though)
341 2009-11-16T08:25:47 <eSyr> fixed.
342 2009-11-16T08:25:50 <ThomasWaldmann> 12 16 21 23: maybe add a colon after the param name
343 2009-11-16T08:26:25 <eSyr> well, i've used doxygen syntax there.
344 2009-11-16T08:26:42 <eSyr> If epydoc support colons, i'll add them.
345 2009-11-16T08:27:52 <eSyr> (fixed)
346 2009-11-16T08:27:54 <ThomasWaldmann> doxygen doesn't?
347 2009-11-16T08:28:21 * ThomasWaldmann recently looked at doxygen after being annoyed by crashing epydoc
348 2009-11-16T08:28:25 <eSyr> well, 3 years ago it didn't support colon, maybe now it does.
349 2009-11-16T08:29:16 <ThomasWaldmann> 23 - does it accept true or True?
350 2009-11-16T08:29:32 <ThomasWaldmann> or both?
351 2009-11-16T08:29:41 <eSyr> any case.
352 2009-11-16T08:29:47 <eSyr> (well, it was any case)
353 2009-11-16T08:30:13 <ThomasWaldmann> 27 if you commit that to moin repo, use same thing as in MoinMoin/_template.py
354 2009-11-16T08:30:52 <ThomasWaldmann> 35 move stdlib import to above all others
355 2009-11-16T08:31:11 <eSyr> yes, doxygen doesn't support colon in parameter name.
356 2009-11-16T08:31:34 <ThomasWaldmann> oh, sounds like fun in case we should switch :|
357 2009-11-16T08:31:48 <ThomasWaldmann> 38/39 - align under macro, ?
358 2009-11-16T08:32:41 <ThomasWaldmann> 38 you don't want to use tuple for sort_column?
359 2009-11-16T08:33:25 <ThomasWaldmann> 39 _kwargs is used for what?
360 2009-11-16T08:33:48 <eSyr> hm, i haven't used it.
361 2009-11-16T08:34:13 <ThomasWaldmann> 42 kill "macro."
362 2009-11-16T08:34:18 <eSyr> (but it makes macro working even on passing unknown params)
363 2009-11-16T08:35:47 <eSyr> (two-way compatibility is so two-way)
364 2009-11-16T08:36:19 <ThomasWaldmann> i guess the sort_column processing can be simplified if the framework already checks for valid values
365 2009-11-16T08:36:51 <ThomasWaldmann> not sure how it handles default then
366 2009-11-16T08:37:46 <eSyr> well, as i've understood, exception occured on wrong column name passed.
367 2009-11-16T08:38:22 <ThomasWaldmann> sure, but what does it take if you give nothing?
368 2009-11-16T08:38:33 <ThomasWaldmann> None? first element?
369 2009-11-16T08:38:44 * eSyr is going to read code
370 2009-11-16T08:38:55 <eSyr> in my code, it's first column
371 2009-11-16T08:39:34 <eSyr> 1650 if arg is None:
372 2009-11-16T08:39:34 <eSyr> 1651 return choices[0]
373 2009-11-16T08:39:47 <eSyr> (from wikiutil.py)
374 2009-11-16T08:39:50 <ThomasWaldmann> ok
375 2009-11-16T08:41:38 <ThomasWaldmann> btw, you copied that bgcolor stuff, I guess?
376 2009-11-16T08:42:08 <eSyr> hm, i've written it seeing on code of text_html formatter
377 2009-11-16T08:42:23 <ThomasWaldmann> i am still wondering that happens in case a theme accidentally uses same fgcolor
378 2009-11-16T08:42:34 <eSyr> oh, hehe.
379 2009-11-16T08:42:45 <ThomasWaldmann> or similar fgcolor
380 2009-11-16T08:43:12 <ThomasWaldmann> we are use to light themes, but I know there are people who prefer dark stuff
381 2009-11-16T08:43:27 <eSyr> (i've always wondering why moin misses <th> analog)
382 2009-11-16T08:43:56 <eSyr> *wondered
383 2009-11-16T08:45:39 <ThomasWaldmann> maybe because the table code is complicated and noone likes to touch it :D
384 2009-11-16T08:45:49 <eSyr> hehe, understood.
385 2009-11-16T08:46:10 <eSyr> because i've missed this thing so many times.
386 2009-11-16T08:46:19 <eSyr> and need to emulate it.
387 2009-11-16T08:46:35 <ThomasWaldmann> we can add it to moin2
388 2009-11-16T08:46:38 <eSyr> (for example, there are many places in help pages with tables)
389 2009-11-16T08:47:04 <eSyr> it will be great.
390 2009-11-16T08:48:55 <ThomasWaldmann> btw, if you're finished with it, you could locally commit it and export the changeset
391 2009-11-16T08:49:35 <eSyr> well, i've done 3 commits already :)
392 2009-11-16T08:49:46 <ThomasWaldmann> :)
393 2009-11-16T08:49:53 * eSyr commits every iteration which leads to working code
394 2009-11-16T08:50:12 <ThomasWaldmann> good practice
395 2009-11-16T08:50:20 <eSyr> so, on code cleanup i'm producing many commits.
396 2009-11-16T08:50:43 <eSyr> hg bundle?
397 2009-11-16T08:51:08 <eSyr> or hg import?
398 2009-11-16T08:51:19 <ThomasWaldmann> vs bad practice "here is the one changeset with the work I did in my closet for the last 3 months"
399 2009-11-16T08:51:21 <eSyr> *hg export
400 2009-11-16T08:51:54 <eSyr> hehe.
401 2009-11-16T08:52:24 <ThomasWaldmann> hg export is fine unless you have binary stuff
402 2009-11-16T08:53:41 <eSyr> ok.
403 2009-11-16T08:54:08 <ThomasWaldmann> btw, do both Lexer name and Lexer alias work when given to highlight?
404 2009-11-16T08:54:24 <eSyr> err, i think no.
405 2009-11-16T08:55:34 <ThomasWaldmann> the user should somehow intuitively pick the right thing from that table
406 2009-11-16T08:56:11 <eSyr> oh.
407 2009-11-16T08:56:29 <eSyr> maybe, name->description, alias->name?
408 2009-11-16T08:57:11 <ThomasWaldmann> maybe that's better.
409 2009-11-16T09:03:35 <eSyr> and how can i export patch from several revisions?
410 2009-11-16T09:06:00 <ThomasWaldmann> hg export works for multiple changesets
411 2009-11-16T09:06:10 <ThomasWaldmann> maybe keep them in order :)
412 2009-11-16T09:13:07 <dreimark> moin
413 2009-11-16T09:13:19 <ThomasWaldmann> moin dreimark
414 2009-11-16T09:13:34 <eSyr> moin
415 2009-11-16T09:17:00 <eSyr> ThomasWaldmann, http://paste.pocoo.org/show/150956/
416 2009-11-16T09:17:13 <eSyr> or i can send you these 4 files.
417 2009-11-16T09:17:22 <eSyr> (or attach somewhere on moinmo.in)
418 2009-11-16T09:18:36 <eSyr> (upload new version on macro page)
419 2009-11-16T09:18:46 <eSyr> *uploaded
420 2009-11-16T09:21:00 <ThomasWaldmann> if i try importing them (only works 1 per import), i get fails with the 2nd export
421 2009-11-16T09:21:15 <eSyr> -__"
422 2009-11-16T09:21:23 <eSyr> *-_-"
423 2009-11-16T09:23:15 <eSyr> how should i do export properly?
424 2009-11-16T09:23:38 <eSyr> (i ve learned that export create separate file for each commit)
425 2009-11-16T09:23:49 <ThomasWaldmann> you used hg export rev1 rev2 rev3?
426 2009-11-16T09:24:19 <ThomasWaldmann> the file looks ok btw, I am wondering why it doesn't get accepted without trouble
427 2009-11-16T09:25:03 <eSyr> yes, hg export -o%h_%n.patch b0fea8eab4bc 90c06bceb2a4 68fd3e0fd020 53f614f02e52
428 2009-11-16T09:26:21 <ThomasWaldmann> hah
429 2009-11-16T09:26:28 <eSyr> i think it's ok to commit resulting file.
430 2009-11-16T09:26:37 <eSyr> http://moinmo.in/MacroMarket/HighlighterList?action=AttachFile&do=view&target=HighlighterList-1.9.0-2.py
431 2009-11-16T09:26:48 <ThomasWaldmann> i suspect it just parsed the first hg header and then applied ALL diffs below
432 2009-11-16T09:27:17 <eSyr> oh
433 2009-11-16T09:27:21 <ThomasWaldmann> well, i guess that is what it did now :D
434 2009-11-16T09:30:21 <CIA-43> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5287:ad509ff9d8c5 1.9/MoinMoin/macro/HighlighterList.py: Added HighlighterList macro, initial release.
435 2009-11-16T09:30:23 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5288:c97e004300ac 1.9/MoinMoin/macro/HighlighterList.py: HighlighterList: fix src formatting
436 2009-11-16T09:30:55 <ThomasWaldmann> you can link now to the repo (instead of attachments) :)
437 2009-11-16T09:31:27 <eSyr> :)
438 2009-11-16T09:31:48 <eSyr> i've made some stub: http://master19.moinmo.in/HelpOnSyntaxHighlighting
439 2009-11-16T09:32:45 <ThomasWaldmann> btw, output table reads a bit repr-ish :)
440 2009-11-16T09:33:02 <eSyr> http://moinmo.in/InterWikiMap shouldn't 1.8 be changed to 1.9?
441 2009-11-16T09:33:13 <eSyr> hm.
442 2009-11-16T09:35:11 <ThomasWaldmann> http://master19.moinmo.in/HelpOnSyntaxHighlighting < works now, yay! :)
443 2009-11-16T09:35:42 <ThomasWaldmann> yes, now or after release
444 2009-11-16T09:36:48 <ThomasWaldmann> I guess I'll make a small mod later, removing all those () and ''
445 2009-11-16T09:37:50 <ThomasWaldmann> eSyr: thanks for coding that, this definitely helps with documenting highlight parser
446 2009-11-16T09:38:21 <eSyr> ThomasWaldmann, i've already done that
447 2009-11-16T09:44:01 <ThomasWaldmann> where?
448 2009-11-16T09:44:29 <eSyr> well, i'm testing it right now
449 2009-11-16T09:45:21 <ThomasWaldmann> cool :)
450 2009-11-16T09:45:28 <ThomasWaldmann> brb
451 2009-11-16T09:55:38 <dreimark> ThomasWaldmann: have you looked at spinx?
452 2009-11-16T10:01:47 <eSyr> ThomasWaldmann, http://paste.pocoo.org/show/150961/ http://paste.pocoo.org/show/150962/ http://paste.pocoo.org/show/150963/
453 2009-11-16T10:06:13 <ThomasWaldmann> i already fixed the first
454 2009-11-16T10:08:10 <eSyr> well, this may lead to conflict then.
455 2009-11-16T10:15:28 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5289:e0e6cd609789 1.9/MoinMoin/macro/HighlighterList.py: HighlighterList macro: use more readable display, docstring changes
456 2009-11-16T10:15:40 * dreimark misses features of 1.9 in 1.8
457 2009-11-16T10:15:46 <ThomasWaldmann> yeah, therefore i fixed it manually
458 2009-11-16T10:16:15 <ThomasWaldmann> eSyr: do we really need the last one? it's all a bit out of sync
459 2009-11-16T10:16:48 <eSyr> well, it's only some prettifying of output
460 2009-11-16T10:17:10 <ThomasWaldmann> but a normal comma and one as code is hardly to differentiate?
461 2009-11-16T10:17:13 <eSyr> like displaying names, mimetypes and patterns in monospace.
462 2009-11-16T10:17:33 <ThomasWaldmann> ehrm, maybe i got it the wrong way
463 2009-11-16T10:17:55 <ThomasWaldmann> yeah, i see it now
464 2009-11-16T10:18:02 <eSyr> (yes, it's rather dirty hack)
465 2009-11-16T10:18:44 <ThomasWaldmann> can you clone the current 1.9 repo so we are in sync again?
466 2009-11-16T10:19:09 <eSyr> yes.
467 2009-11-16T10:19:52 <ThomasWaldmann> dreimark: that's why we need to release it asap :)
468 2009-11-16T10:21:17 <ThomasWaldmann> (of course we could backport some minor stuff to 1.8, but we also can resist, so people have a few reasons more to use current release :)
469 2009-11-16T10:22:32 <eSyr> btw, about backporting. At some point in time i want to backport translation to 1.8 before it became to recieve security only updates.
470 2009-11-16T10:24:19 <ThomasWaldmann> well, then you should do that soon :)
471 2009-11-16T10:24:58 <ThomasWaldmann> that might happen after 1.9.0 or 1.9.1 release
472 2009-11-16T10:25:09 <eSyr> http://paste.pocoo.org/show/150965/
473 2009-11-16T10:25:19 <eSyr> ok.
474 2009-11-16T10:26:12 <ThomasWaldmann> from a maintaining pov, one should maybe backport more. otoh, we don't have that much developer resources and development in 2.0 should finally speed up again
475 2009-11-16T10:27:13 <ThomasWaldmann> there is so much todo in 2.0 that we currently can't afford doing much non-bugfixing work in 1.9 or non-security work in 1.8
476 2009-11-16T10:27:56 <eSyr> i understand.
477 2009-11-16T10:28:27 <ThomasWaldmann> and also, 2.0 is that different from 1.x that any feature we add to 1.x might cause quite some merging/reimplementation effort in 2.0
478 2009-11-16T10:28:31 <eSyr> (it's strange that such rather popular wiki has so little amount of active developers)
479 2009-11-16T10:29:08 <ThomasWaldmann> well, many devs do plugins, or translator help maintaining a language,
480 2009-11-16T10:29:30 <ThomasWaldmann> but for core stuff, we definitely miss some active high-profile developers
481 2009-11-16T10:33:03 <CIA-43> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5290:8d2629718603 1.9/MoinMoin/macro/HighlighterList.py: macro/HighlighterList.py: some output prettifying.
482 2009-11-16T10:37:24 <eSyr> ThomasWaldmann, should i add macro description as subpage of HelpOnMacros?
483 2009-11-16T10:45:04 <ThomasWaldmann> i think we don't need that. it's not a macro some user usually will want to use.
484 2009-11-16T10:45:24 <eSyr> ok.
485 2009-11-16T10:48:35 <eSyr> ThomasWaldmann, can you push this little patch? http://paste.pocoo.org/show/150967/ I've forgot to fix this when did rename of column names.
486 2009-11-16T10:49:39 <dreimark> ThomasWaldmann: PageList behaves different in 1.9
487 2009-11-16T10:49:52 <dreimark> or with xapian, can't destinguish currently
488 2009-11-16T10:50:05 <dreimark> you get all attachments too while I want only titles
489 2009-11-16T10:50:24 <dreimark> however I think getting attachments should be optional
490 2009-11-16T10:50:29 <dreimark> in this case
491 2009-11-16T10:54:09 <dreimark> http://moinmo.in/MoinMoinBugs/PageListTooVerbose
492 2009-11-16T10:54:29 <ThomasWaldmann> sort of moin2 behaviour :)
493 2009-11-16T10:55:00 <dreimark> yeah but wrong here can give easy unreadable output
494 2009-11-16T11:08:23 <CIA-43> Eugene Syromyatnikov <evgsyr@gmail.com> default * 5291:14575ba5aeef 1.9/MoinMoin/macro/HighlighterList.py: macro/HighlighterList.py: little docstring fix.
495 2009-11-16T11:08:30 <ThomasWaldmann> bbl
496 2009-11-16T11:32:40 <eSyr> ThomasWaldmann, http://paste.pocoo.org/show/150968/ — Added linking in unknown pygments lexer message
497 2009-11-16T11:45:17 <eSyr> dreimark, do you know, new gettext entities added via script or not?
498 2009-11-16T12:23:34 <CIA-43> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5292:65276fd92460 1.9/MoinMoin/macro/HighlighterList.py: macro HighlighterList: defined background color for column header
499 2009-11-16T12:24:07 <dreimark> eSyr: I have fixed the color
500 2009-11-16T12:24:30 <dreimark> eSyr: http://hg.moinmo.in/moin/1.8/rev/d78c35783dd8
501 2009-11-16T12:24:49 <dreimark> after merging of 1.8 main it will go automaticly in 1.9
502 2009-11-16T12:34:18 <eSyr> err.
503 2009-11-16T12:34:28 <eSyr> i've already done it in one of commits.
504 2009-11-16T12:35:02 <eSyr> but Thomas say that this may works bad on dark themes.
505 2009-11-16T12:35:09 <eSyr> (i think, there need some "table_header" css style)
506 2009-11-16T12:37:04 <dreimark> not now
507 2009-11-16T12:37:16 <eSyr> i can do it myself.
508 2009-11-16T12:37:28 <eSyr> and send a patch :)
509 2009-11-16T12:37:30 <dreimark> because it does not matter if there are other tables on the master wiki
510 2009-11-16T12:37:41 <dreimark> which were not build by a macro
511 2009-11-16T12:37:52 <eSyr> they can use css class to
512 2009-11-16T12:37:58 <dreimark> and we don't have an idea how to style those variable
513 2009-11-16T12:38:02 <dreimark> ok
514 2009-11-16T12:38:13 <dreimark> but that needs much changes on the master wiki
515 2009-11-16T12:38:34 <eSyr> well, these changes can be scripted.
516 2009-11-16T12:38:50 <dreimark> ok, ThomasWaldmann needs to do this then
517 2009-11-16T12:38:58 <eSyr> (i wrote many scripts for doing mass content changing on moin -_-)
518 2009-11-16T12:39:10 <dreimark> good
519 2009-11-16T12:40:20 <eSyr> well, i do not think so, these scripts used editmoin for proper page saving and EDITOR variable overriden by page processor scripts.
520 2009-11-16T12:40:35 <eSyr> (at least, first iterations looked like this)
521 2009-11-16T12:41:59 <dreimark> u can do it by writing a simple moin command tool, but also it can be not so simple and will be more a migration script for the master wiki. I don't know the amount of cases currently. but I think there not much
522 2009-11-16T12:43:24 <eSyr> dreimark, well, now i'm useng my custom action.
523 2009-11-16T12:43:37 <dreimark> at least we have enough time
524 2009-11-16T12:44:12 <eSyr> hm, enough time for what?
525 2009-11-16T12:46:00 <dreimark> rereading fixing master page if something got broken
526 2009-11-16T12:48:55 <eSyr> oh, yes.
527 2009-11-16T12:50:25 <ThomasWaldmann> re
528 2009-11-16T13:28:12 <eSyr> ThomasWaldmann, can you add path with link to HelpOnSyntaxHighlighting in error msg?
529 2009-11-16T13:31:40 <dreimark> eSyr: we do this later, we need to change how the msg is outputted
530 2009-11-16T13:31:51 <dreimark> without making it easy to do xss by that
531 2009-11-16T13:31:55 <dreimark> +not
532 2009-11-16T13:47:07 <eSyr> oh, i understand.
533 2009-11-16T13:55:56 *** grzywacz
534 2009-11-16T14:02:32 *** ChanServ
535 2009-11-16T14:02:47 *** eSyr
536 2009-11-16T14:04:40 *** ChanServ
537 2009-11-16T14:04:40 *** irc.freenode.net
538 2009-11-16T14:10:03 *** ChanServ
539 2009-11-16T14:14:49 *** ChanServ
540 2009-11-16T14:14:49 *** irc.freenode.net
541 2009-11-16T14:15:14 *** ChanServ
542 2009-11-16T14:18:25 *** ChanServ
543 2009-11-16T14:18:25 *** irc.freenode.net
544 2009-11-16T15:44:27 *** ChanServ
545 2009-11-16T15:45:44 *** ChanServ
546 2009-11-16T15:45:44 *** irc.freenode.net
547 2009-11-16T15:55:34 *** ChanServ
548 2009-11-16T16:01:12 *** ChanServ
549 2009-11-16T16:01:12 *** irc.freenode.net
550 2009-11-16T20:36:18 <ThomasWaldmann> re
551 2009-11-16T23:43:25 *** grzywacz
552
