2009-10-12T00:02:10 <TheSheep> ThomasWaldmann: and some will fail even if you did
2009-10-12T00:02:12 <TheSheep> like ldap
2009-10-12T00:03:17 <ThomasWaldmann> yeah, we need another improvement :)
2009-10-12T00:04:13 <TheSheep> argh
2009-10-12T00:13:01 <dreimark> TheSheep: can you add this imap plugin to the codebase?
2009-10-12T00:44:53 <JosefMeier> ThomasWaldmann: My prototype for missing attachments is ready. I know that you don't like to have that in 1.9.1 but maybe you could nevertheless have a look on my changeset which I will push tomorrow
2009-10-12T00:48:46 <dreimark> JosefMeier: do you have checked py.test
2009-10-12T00:49:03 <dreimark> and it would be nice to have a testcase for that change
2009-10-12T00:51:29 <JosefMeier> dreimark: py.test runs at the moment
2009-10-12T00:51:47 <JosefMeier> had a few pep8 errors. Didn't know that empty lines are not allowed to have blanks in it
2009-10-12T00:52:30 <JosefMeier> dreimark: Is there a page in underlay where attachments are stored on?
2009-10-12T00:52:43 <JosefMeier> which is suitable for testing wantedattachments?
2009-10-12T00:52:52 <dreimark> likly there were Attachments are described
2009-10-12T00:53:15 <dreimark> I remember that I have added images to explain the attachfile action
2009-10-12T00:53:20 *** thiagocrepaldi has quit IRC
2009-10-12T00:53:26 <JosefMeier> for tests is no special page needed? cause the test will have to rename an attachment
2009-10-12T00:53:26 <dreimark> also LanguageSetup
2009-10-12T00:53:52 <dreimark> that's not a good idea for underlay because
2009-10-12T00:54:02 <dreimark> there are some tests which creates attachments#
2009-10-12T00:54:26 <dreimark> underlay change goes into data
2009-10-12T00:55:46 <JosefMeier> dreimark: do the tests change something in underlay? or where are the pages which are manipulated?
2009-10-12T00:55:46 *** tpfennig has joined #moin-dev
2009-10-12T00:58:06 <dreimark> the pages by tests go to go into the testwiki
2009-10-12T00:58:28 <JosefMeier> ok
2009-10-12T00:58:59 <dreimark> there are some common function for tests you can use e.g. create_page, nuke_page
2009-10-12T00:59:14 <JosefMeier> ok
2009-10-12T01:01:01 <JosefMeier> one question about committing: Can I commit all files which belong to a certain feature with the same comment? Maybe I made this wrong in the past. I committed every file with a different comment.
2009-10-12T01:01:18 <JosefMeier> even if they belong to the same feature
2009-10-12T01:01:46 <dreimark> you bundle stuff for the same scop
2009-10-12T01:01:47 <dreimark> e
2009-10-12T01:02:00 <JosefMeier> 1 changeset = changes to several files + only 1 comment ?
2009-10-12T01:02:00 <dreimark> but sometimes it is better to split that scope in many parts
2009-10-12T01:02:23 <JosefMeier> so 1 feature could consist of more than only one commit ?
2009-10-12T01:02:42 <JosefMeier> sorry: 1 feature could consist of more than one changeset ?
2009-10-12T01:02:51 <dreimark> yes, if it is for example collecting data, processing data
2009-10-12T01:03:00 <JosefMeier> ok. good to know
2009-10-12T01:03:00 <dreimark> then you can have two commits
2009-10-12T01:03:09 <dreimark> or much more
2009-10-12T01:03:30 <dreimark> it is for reading changes important that there not 50 files changed for a big thing
2009-10-12T01:03:39 <JosefMeier> Then I should split my changes to the broken attachment links in several commits.
2009-10-12T01:03:43 <dreimark> because that is logical splitted in many parts
2009-10-12T01:03:54 <dreimark> it makes reading of cs much easier
2009-10-12T01:05:03 <JosefMeier> Today I had the problem that I pushed some stuff to 1.8-jmeier which I don't like to have there. After that I cloned a local repo of 1.8 and forced a push of that to 1.8-jmeier online. I did this to throw my formerly pushed changes in the online repo away. Correct?
2009-10-12T01:07:59 <dreimark> that is quite the same than a revert it now still in the online repo
2009-10-12T01:09:02 <JosefMeier> it's ok how I did it ?
2009-10-12T01:09:15 <JosefMeier> at least for this situation
2009-10-12T01:11:54 <dreimark> I've not looked at the repo
2009-10-12T01:12:20 <dreimark> but you can do a revert to a revision name this in the commit message and push it again
2009-10-12T01:12:25 <dreimark> than it is tip
2009-10-12T01:13:30 <JosefMeier> ah ok.
2009-10-12T01:14:35 <dreimark> the last action can be rollbacked always. but that helps only if it is not pushed
2009-10-12T01:15:41 *** grzywacz has quit IRC
2009-10-12T01:18:43 <JosefMeier> ok. gn8
2009-10-12T01:19:06 *** JosefMeier has quit IRC
2009-10-12T04:03:09 *** tpfennig has quit IRC
2009-10-12T12:54:28 *** tpfennig has joined #moin-dev
2009-10-12T15:25:08 *** ser has quit IRC
2009-10-12T15:28:26 *** ser has joined #moin-dev
2009-10-12T18:01:44 *** grzywacz has joined #moin-dev
2009-10-12T19:16:03 *** starshine_away is now known as starshine
2009-10-12T19:17:26 *** JosefMeier has joined #moin-dev
2009-10-12T19:27:15 *** tpfennig has quit IRC
2009-10-12T20:22:26 <JosefMeier> Moin Moin
2009-10-12T20:23:33 <starshine> moin :)
2009-10-12T20:28:30 <TheSheep> hello starshine!
2009-10-12T20:29:00 <TheSheep> starshine: I haven't seen you for quite some time
2009-10-12T20:29:16 <starshine> yes I have been very busy outside my computer
2009-10-12T20:31:26 <TheSheep> your computer has an outside? neat! I need to install one in mine too!
2009-10-12T20:31:46 <starshine> lol
2009-10-12T20:47:40 *** starshine is now known as starshine_away
2009-10-12T20:55:19 *** franklin_ has joined #moin-dev
2009-10-12T20:56:41 *** franklin has quit IRC
2009-10-12T23:28:10 *** franklin_ has quit IRC
2009-10-12T23:28:13 *** franklin has joined #moin-dev
2009-10-12T23:28:31 *** franklin has joined #moin-dev
MoinMoin: MoinMoinChat/Logs/moin-dev/2009-10-12 (last edited 2009-10-11 22:15:02 by IrcLogImporter)