MoinMoin: MoinMoinChat/Logs/moin-dev/2009-10-01

2009-10-01T00:15:37  <dreimark> ThomasWaldmann: can you look at the irc collector script (logs are missing)
2009-10-01T00:17:49  <dreimark> for some reason (or the reason is me) the calendar macro seems not to work at http://moinmo.in/MoinMoinChat/Logs/moin-dev
2009-10-01T00:18:21  <dreimark> I can't go back
2009-10-01T00:18:41  <ThomasWaldmann> re
2009-10-01T00:44:27  *** grzywacz has quit IRC
2009-10-01T01:08:37  *** tpfennig has joined #moin-dev
2009-10-01T02:40:05  *** tpfennig has quit IRC
2009-10-01T03:57:17  *** amartani has quit IRC
2009-10-01T08:40:21  <ThomasWaldmann> moin
2009-10-01T08:50:07  <dreimark> moin
2009-10-01T09:01:40  *** tpfennig has joined #moin-dev
2009-10-01T09:31:19  *** moinBot has joined #moin-dev
2009-10-01T09:33:04  <ThomasWaldmann> dreimark: irclog is broken because cli request object has not attribute cfg
2009-10-01T09:47:22  <ThomasWaldmann> hm, maybe just a wrong --wiki-url, we'll see soon
2009-10-01T10:26:14  *** JosefMeier has joined #moin-dev
2009-10-01T10:26:27  <JosefMeier> Moin Moin
2009-10-01T10:27:08  <JosefMeier> dreimark: I saw your comment on the missing cfg field in the request object. Thats why I had to provide two versions of the freemind macro!
2009-10-01T10:27:22  <JosefMeier> All macros for Moin < 1.9 have to be adjusted cause of that
2009-10-01T10:27:44  <JosefMeier> Is it possible to add this cfg field to the request object?
2009-10-01T10:27:57  <JosefMeier> ThomasWaldmann:
2009-10-01T12:06:56  <ThomasWaldmann> in my recent case, it was just a wrong --wiki-url
2009-10-01T12:13:41  <JosefMeier> ThomasWaldmann: dreimark: Is it wanted, that the request object lacks of the cfg variable?
2009-10-01T12:14:26  <ThomasWaldmann> i don't think so
2009-10-01T12:21:33  <JosefMeier> ThomasWaldmann: Does it have to get fixed for the final release?
2009-10-01T12:28:37  <ThomasWaldmann> do we have a bug for it?
2009-10-01T12:28:47  <ThomasWaldmann> (on the wiki?)
2009-10-01T12:29:08  * ThomasWaldmann didn't see that bug in practice yet
2009-10-01T12:34:29  <JosefMeier> ThomasWaldmann: Some macros and actions won't work
2009-10-01T12:35:02  <ThomasWaldmann> i need a bug report on the wiki, including tracebacks, references to stuff that doesn't work, etc.
2009-10-01T12:35:35  <ThomasWaldmann> (and best is if you can reproduce it easily, with builtin stuff)
2009-10-01T12:36:29  <JosefMeier> ThomasWaldmann: action.getHandler has a different behaviour between 1.8 and 1.9
2009-10-01T12:37:31  <ThomasWaldmann> dimazest: btw, we could still need some xapian fixes. i'ld like to fix some bugs this weekend and/or release a beta5
2009-10-01T12:38:53  <JosefMeier> ThomasWaldmann: Is the missing cfg a bug? At least some 3rd party macros dont work which worked for 1.8
2009-10-01T12:39:39  <ThomasWaldmann> maybe. i have to look at it first. :)
2009-10-01T12:39:54  <ThomasWaldmann> i need a bug report on the wiki, see above.
2009-10-01T12:42:50  <JosefMeier> So I will write a bug report alto
2009-10-01T12:43:01  <JosefMeier> although its not clear if it is a bug :-) ?
2009-10-01T12:44:08  <JosefMeier> Reimars bug report about the Month calendar seems to go in the same direction. He reports a missing cfg variable also
2009-10-01T12:44:32  <ThomasWaldmann> JosefMeier: if it is not a bug: we have a category for that or one can just delete the page
2009-10-01T12:45:05  <ThomasWaldmann> about the getHandler: 1.8 wants request, 1.9 wants request.cfg as 1st argument
2009-10-01T12:45:55  <JosefMeier> ThomasWaldmann: Why?
2009-10-01T12:45:57  <ThomasWaldmann> if you file another bug for that, we can revert that change easily. moin has only 2 callers for that function.
2009-10-01T12:46:04  <JosefMeier> 3
2009-10-01T12:46:10  <JosefMeier> 4 :-)
2009-10-01T12:46:18  <JosefMeier> Think about 3rd party macros also
2009-10-01T12:46:51  <ThomasWaldmann> so if you can give more than 2 3rd party callers that we'll break, we have a good reason to stay compatible
2009-10-01T12:47:17  <ThomasWaldmann> -> bug report
2009-10-01T12:48:40  <JosefMeier> ThomasWaldmann: If I'm allowed to summarize our conversation: You want me to write a bug report?
2009-10-01T12:48:58  <ThomasWaldmann> yes
2009-10-01T12:49:01  <JosefMeier> :-D
2009-10-01T12:50:02  <ThomasWaldmann> it is just easier to process than stuff splattered on irc logs of some hours/days
2009-10-01T12:56:47  <JosefMeier> bug report: done
2009-10-01T13:11:33  <ThomasWaldmann> JosefMeier: i renamed the page
2009-10-01T13:12:51  * dreimark is not sure if that should be workarounded because if an action uses forms it needs to get changes anyway
2009-10-01T13:13:24  <dreimark> may be we could backport the wikiutil version class to 1.8
2009-10-01T13:13:37  <dreimark> and show an example how to use it
2009-10-01T13:14:22  <JosefMeier> dreimark: you want the interface of getHandler to be changed?
2009-10-01T13:14:36  <JosefMeier> back to 1.8 or leave it as is in 1.9 ?
2009-10-01T13:15:03  <ThomasWaldmann> dreimark: the forms stuff is for a good reason, the getHandler stuff is for a reason too, but a rather minor one
2009-10-01T13:15:19  <dreimark> see http://hg.moinmo.in/moin/extensions/file/89b8539eebd9/data/plugin/action/arnica_slides.py#l350
2009-10-01T13:15:42  <dreimark> that needs to refactored for wikiutil.version stuff now with 1.9 again
2009-10-01T13:17:07  <dreimark> JosefMeier: I mean the problem is that if it makes sense to change getHandler while the user also has to change the other part
2009-10-01T13:17:26  <dreimark> I am not sure currently.
2009-10-01T13:18:13  <JosefMeier> dreimark: I don't think there are a lot of extensions for 1.9 yet. But if this change of the interface will stay in 1.9 a few macros could need changes.
2009-10-01T13:18:15  <dreimark> and I have no idea now if there are actions that won't need this change because of form change
2009-10-01T13:18:22  <ThomasWaldmann> i think we'll change getHandler to be 1.8 compatible, but we won't change form/args/values because the new approach is cleaner and mandated by werkzeug
2009-10-01T13:19:15  <dreimark> look at our builtin stuff first
2009-10-01T13:19:19  <ThomasWaldmann> and while looking at ensureversion, I think we need that Version class from 2.0 wikiutil :)
2009-10-01T13:19:20  <dreimark> htg, bbl
2009-10-01T13:19:40  <dreimark> ThomasWaldmann: isn't it in 1.9 now?
2009-10-01T13:19:45  <dreimark> we need it !
2009-10-01T13:20:06  <ThomasWaldmann> not sure, have to look
2009-10-01T13:20:11  <dreimark> bbl
2009-10-01T13:20:51  <JosefMeier> ThomasWaldmann: did you check how much modules access the "new" getHandler interface?
2009-10-01T13:20:56  <JosefMeier> in 1.9
2009-10-01T13:27:12  <ThomasWaldmann> 2?
2009-10-01T13:32:07  <JosefMeier> sounds not too much. So you will make it 1.8 compatible again?
2009-10-01T13:34:29  <ThomasWaldmann> i think so
2009-10-01T13:34:33  <ThomasWaldmann> gtg/bbl
2009-10-01T15:26:09  *** TheSheep has quit IRC
2009-10-01T15:26:09  *** vpv has quit IRC
2009-10-01T15:26:09  *** ser has quit IRC
2009-10-01T15:26:09  *** ThomasWaldmann has quit IRC
2009-10-01T15:26:40  *** ThomasWaldmann has joined #moin-dev
2009-10-01T15:26:40  *** vpv has joined #moin-dev
2009-10-01T15:26:40  *** ser has joined #moin-dev
2009-10-01T15:26:40  *** TheSheep has joined #moin-dev
2009-10-01T15:49:47  *** JosefMeier has quit IRC
2009-10-01T17:23:33  *** grzywacz has joined #moin-dev
2009-10-01T18:26:33  *** TheSheep has quit IRC
2009-10-01T18:26:33  *** vpv has quit IRC
2009-10-01T18:26:33  *** ser has quit IRC
2009-10-01T18:28:55  *** TheSheep has joined #moin-dev
2009-10-01T18:29:26  *** vpv has joined #moin-dev
2009-10-01T18:45:55  *** ser has joined #moin-dev
2009-10-01T18:56:28  <dimazest> moin
2009-10-01T18:57:19  <dimazest> ThomasWaldmann: i'll have time on Saturday, also tomorow
2009-10-01T18:58:07  *** JosefMeier has joined #moin-dev
2009-10-01T19:25:43  <JosefMeier> bbl
2009-10-01T20:21:32  <dreimark> dimazest: perfect :)
2009-10-01T20:24:34  <dreimark> was macht eigentlich Dein Deutschkurs?
2009-10-01T20:35:28  *** tpfennig has quit IRC
2009-10-01T22:00:53  *** tpfennig has joined #moin-dev
2009-10-01T22:11:41  *** xorAxAx has quit IRC
2009-10-01T23:28:30  *** JosefMeier has quit IRC