2009-08-01T00:30:30 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6314:9a89cb8c18b2 2.0-storage/MoinMoin/ (5 files in 3 dirs): fix some more create acl related test failures, skip broken wikisync tests
2009-08-01T01:19:40 *** grzywacz has quit IRC
2009-08-01T04:49:40 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6401:94458736c4f5 2.0-storage-editor-amartani/MoinMoin/items/lock.py: Real-time editor: itemlock use correct caching scope
2009-08-01T04:49:42 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6402:a89911f513c9 2.0-storage-editor-amartani/MoinMoin/templates/ (modify_binary.html modify_text.html): Real-time editor: Align all save-related buttons in one row
2009-08-01T04:49:44 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6403:77ddec7adf3a 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/common/js/text_editor.js: Real-time editor: Don't enable save and continue button right after load
2009-08-01T04:49:47 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6404:0c5edef65d78 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/applets/Mobwrite/mobwrite_moinmoin.js: Real-time editor: Change enable sharing button label when mobwrite is activated
2009-08-01T05:12:07 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6437:ff47833598cc 2.0-storage-editor-amartani/ (81 files in 23 dirs): merge 2.0-storage
2009-08-01T06:38:47 <amartani> dennda: ThomasWaldmann: I'm getting an error when I try to login with wrong username/password http://paste.pocoo.org/show/132004/
2009-08-01T06:42:11 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6438:91e076c5cbfd 2.0-storage-editor-amartani/MoinMoin/web/static/htdocs/applets/Mobwrite/mobwrite_moinmoin.js: Real-time editor: Don't enable button automatically when enabling mobwrite
2009-08-01T06:42:11 <CIA-43> Alexandre Martani <amartani AT gmail DOT com> default * 6439:a95516f19e1b 2.0-storage-editor-amartani/MoinMoin/action/modify.py: Real-time editor: release lock when cancel editing
2009-08-01T07:08:29 *** amartani has quit IRC
2009-08-01T09:02:44 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6315:4899f92518ad 2.0-storage/MoinMoin/datastruct/backends/_tests/test_wiki_groups.py: fix some group tests
2009-08-01T10:27:08 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6316:50f1415a2372 2.0-storage/MoinMoin/ (action/copy.py action/rename.py items/__init__.py): Item: move copy/rename urlarg processing from Item method to action
2009-08-01T10:27:10 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6317:7260aba96e32 2.0-storage/MoinMoin/ (2 files in 2 dirs): group tests: fix and extend copy/rename tests
2009-08-01T11:49:42 <ThomasWaldmann> hmm, i have an idea about delete:
2009-08-01T11:49:50 <ThomasWaldmann> we'll have both :)
2009-08-01T11:51:10 <ThomasWaldmann> a) nobody will hold you back from saving an empty revision and it will just show an empty page then (not setting some deleted flag, not showing page creation dialogue)
2009-08-01T11:52:30 <ThomasWaldmann> (that will also remove the [ ] delete item checkbox from the UI)
2009-08-01T11:52:53 <ThomasWaldmann> b) have a "move to trashbin" action in the menu
2009-08-01T11:53:52 <ThomasWaldmann> comments?
2009-08-01T12:12:02 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6318:e32793a0b24c 2.0-storage/MoinMoin/items/__init__.py: do not crash if someone saves an empty non-text item by NOT uploading content
2009-08-01T12:13:15 <ThomasWaldmann> dennda: wake up :)
2009-08-01T12:34:51 * dennda yawns
2009-08-01T12:38:28 <dennda> ThomasWaldmann: That's not that different from how I understood it
2009-08-01T12:39:08 <dennda> Isn't a) already how it is?
2009-08-01T12:40:04 <ThomasWaldmann> not if you read it completely
2009-08-01T12:44:05 <dennda> well yes, minor changes
2009-08-01T12:44:58 <ThomasWaldmann> from the ui, that's significant change
2009-08-01T12:45:52 <ThomasWaldmann> (i was thinking about killing deleted flag completely)
2009-08-01T13:07:14 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6319:ff8cffbbe656 2.0-storage/MoinMoin/items/__init__.py: fix bug in previous commit
2009-08-01T13:15:56 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6320:715f395fa419 2.0-storage/MoinMoin/items/__init__.py: Item saving: fix type problem when saving empty textarea
2009-08-01T13:17:04 <dennda> We'd need to do that anyways if we'd go the trashbin way...
2009-08-01T13:25:51 <dennda> bloody firefox crashes when viewing one of your changesets
2009-08-01T13:39:04 <ThomasWaldmann> which?
2009-08-01T13:39:12 <ThomasWaldmann> ah, i bet the xml change
2009-08-01T13:39:31 <ThomasWaldmann> (that is a looooong line)
2009-08-01T13:39:44 <dennda> the first
2009-08-01T13:40:01 <dennda> the del item is superfluous imho
2009-08-01T13:40:32 <dennda> confused me at first
2009-08-01T13:42:31 <dennda> hm
2009-08-01T13:42:50 <dennda> grep -RL underlay . | xargs $EDITOR
2009-08-01T13:42:52 <dennda> baaaad idea
2009-08-01T13:43:02 <dennda> it also includes .hg and all binary files
2009-08-01T13:43:35 <ThomasWaldmann> use mc :P
2009-08-01T13:43:45 <dennda> midnight commander?
2009-08-01T13:43:48 <ThomasWaldmann> yes
2009-08-01T13:43:53 <dennda> how does that help?
2009-08-01T13:44:09 <ThomasWaldmann> find -> underlay, in *.py
2009-08-01T13:44:53 * dennda installs
2009-08-01T13:46:44 <dennda> nice
2009-08-01T13:50:39 <dennda> Overwrites underlay pages. Implementational detail: This needs to be
2009-08-01T13:50:39 <dennda> kept in sync with the page class.
2009-08-01T13:50:47 * dennda is afraid
2009-08-01T14:10:52 <dimazest> ThomasWaldmann: do i need to take care of string encoding/decoding if xappy assumes that all text passed to it is utf-8?
2009-08-01T14:21:35 <ThomasWaldmann> dennda: Trash/LanguageSetup (2009-08-01 12:19:00)
2009-08-01T14:22:15 <ThomasWaldmann> dimazest: sure
2009-08-01T14:22:52 <dennda> ThomasWaldmann: what did you do? :-)
2009-08-01T14:24:08 <ThomasWaldmann> i deleted LanguageSetup
2009-08-01T14:25:14 <dennda> and then the miracle happened and it ended up in Trash/ somehow
2009-08-01T14:25:37 <ThomasWaldmann> yes, by uncommitted code, though
2009-08-01T14:48:01 * ThomasWaldmann .oO(non-glare display -> sitting in teh sun :)
2009-08-01T14:50:47 * dennda removes reducewiki script
2009-08-01T14:57:01 <dennda> wow
2009-08-01T14:57:17 <dennda> wiki still works after I made my way through the code removing underlay :-)
2009-08-01T14:57:43 <CIA-43> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6321:c69c4aab720e 2.0-storage/ (23 files in 12 dirs): storage: Start to get rid of underlay stuff
2009-08-01T14:57:45 <CIA-43> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6322:c561ed9dbf0f 2.0-storage/MoinMoin/script/maint/reducewiki.py: storage: Remove obsolete reducewiki script
2009-08-01T15:01:59 <ThomasWaldmann> :)
2009-08-01T15:02:14 <dennda> mc rocks for that
2009-08-01T15:07:54 <ThomasWaldmann> - pagenames = list(request.rootpage.getPageList(include_underlay=underlay))
2009-08-01T15:07:54 <ThomasWaldmann> + pagenames = list(request.rootpage.getPageList())
2009-08-01T15:08:14 <ThomasWaldmann> you likely need to replace that by include_system_pages
2009-08-01T15:09:30 <ThomasWaldmann> - ('storage', None,
2009-08-01T15:09:30 <ThomasWaldmann> - 'Data/User storage backends; the None default will make Moin construct a backend.'), # XXX Elaborate?
2009-08-01T15:09:33 <ThomasWaldmann> ?
2009-08-01T15:10:53 <dennda> hm should have kept that. just replacing it isn't sufficient
2009-08-01T15:12:39 <ThomasWaldmann> - 'domain': 'XDOMAIN', # standard or underlay
2009-08-01T15:12:39 <ThomasWaldmann> + 'domain': 'XDOMAIN', # standard
2009-08-01T15:12:43 <ThomasWaldmann> ... or system?
2009-08-01T15:13:34 <dennda> yes
2009-08-01T15:13:55 <dennda> How do we best get rid of the "Exclude Underlay" strings in all the .po files?
2009-08-01T15:14:41 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6323:b5fb761f98f4 2.0-storage/MoinMoin/ (items/__init__.py theme/__init__.py action/delete.py): delete action (== rename to Trash/Foo (timestamp))
2009-08-01T15:14:43 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6324:29ea33db6281 2.0-storage/ (24 files in 12 dirs): merge main
2009-08-01T15:15:23 <ThomasWaldmann> no need, just make sure the string is gone in the src (or replaced by "Exclude system pages"
2009-08-01T15:15:27 <ThomasWaldmann> )
2009-08-01T15:17:10 <dennda> great
2009-08-01T15:33:46 <dennda> http://hg.moinmo.in/moin/2.0-storage/diff/c69c4aab720e/MoinMoin/Page.py#l1.71
2009-08-01T15:33:50 <dennda> do you think that has been a bug?
2009-08-01T15:34:06 <dennda> why not?
2009-08-01T15:37:48 * ThomasWaldmann grills dennda
2009-08-01T15:42:38 <dennda> ThomasWaldmann: I'm not that tasty
2009-08-01T15:45:09 * ThomasWaldmann will heat the fire with TABs
2009-08-01T15:45:23 <dennda> uh
2009-08-01T15:45:24 <dennda> where?
2009-08-01T15:45:44 <dennda> i was editing the files with the standard editor which may not have my tab settings applied
2009-08-01T15:46:02 <xorAxAx> then thomas will delegate the grilling to his hessian colleague, he likes everybody :)
2009-08-01T15:46:12 <ThomasWaldmann> wait until after my next comit
2009-08-01T15:46:23 <xorAxAx> (where is he currently btw? in the jail?)
2009-08-01T15:46:24 <ThomasWaldmann> xorAxAx: i guess he's not available :D
2009-08-01T15:46:49 <xorAxAx> ThomasWaldmann: ah
2009-08-01T15:48:48 <dennda> you are affiliated with cannibals?
2009-08-01T15:53:15 <ThomasWaldmann> he also worked at the Kassel Computing Center in 1999
2009-08-01T15:53:56 <dennda> whom did he eat?
2009-08-01T15:54:15 <ThomasWaldmann> some volunteer :)
2009-08-01T15:54:50 * ThomasWaldmann kills DELETE
2009-08-01T15:54:52 <dennda> crazy
2009-08-01T15:55:08 <dennda> reminds me of it crowd
2009-08-01T15:55:13 <xorAxAx> "der kannibale von rothenburg"
2009-08-01T15:55:28 <dennda> oh i've heard that
2009-08-01T15:56:16 <dennda> http://www.youtube.com/watch?v=4vkuyMp5CnE&feature=related
2009-08-01T16:00:57 <CIA-43> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6325:670071019a81 2.0-storage/Makefile: storage: Makefile: get rid of underlay stuff
2009-08-01T16:00:58 <CIA-43> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6326:4716655d5557 2.0-storage/MoinMoin/ (4 files in 4 dirs): storage: Fixes for previous commit
2009-08-01T16:01:00 <CIA-43> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 6327:96eb45253120 2.0-storage/MoinMoin/ (items/__init__.py theme/__init__.py action/delete.py): storage: merge remote 2.0-storage
2009-08-01T16:08:42 <dimazest> ThomasWaldmann: xappy from svn trunk has Query object, which can be combined like query1 & query2, but xappy 0.5 does not provide this functionality. should i use 0.5 or update to the trunk?
2009-08-01T16:20:44 <ThomasWaldmann> for now, use last release
2009-08-01T16:21:30 <dimazest> ok
2009-08-01T16:54:48 <ThomasWaldmann> + syspages = int(request.values.get('underlay', True))
2009-08-01T16:54:54 <ThomasWaldmann> dennda:
2009-08-01T16:55:33 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6328:398627bc7b17 2.0-storage/MoinMoin/ (21 files in 14 dirs): removed DELETED metadata support, DELETE capability and everything related
2009-08-01T16:55:35 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 6329:3e2152deb8c0 2.0-storage/ (5 files in 5 dirs): merge main
2009-08-01T16:57:11 <ThomasWaldmann> ok, now we have just delete as trashbin
2009-08-01T16:57:18 <ThomasWaldmann> code got a bit easier by that
2009-08-01T17:05:44 <ThomasWaldmann> ok, so now all the trash just ends up in Trash/* in the normal wiki namespace
2009-08-01T17:06:39 <ThomasWaldmann> "undelete" is very easy: just rename it back
2009-08-01T17:07:28 <ThomasWaldmann> i guess next thing we need is namespaces :)
2009-08-01T17:24:47 <ThomasWaldmann> dennda: the presence of "user" backend in router middleware seems a bit artificial
2009-08-01T17:25:35 <ThomasWaldmann> how about a namespace middleware for data, user, trash?
2009-08-01T17:45:41 <ThomasWaldmann> dennda: there is still underlay stuff
2009-08-01T17:59:35 <CIA-43> Dmitrijs Milajevs <dimazest@gmail.com> default * 4930:af698a181b01 1.9-xapian-dmilajevs/MoinMoin/search/ (Xapian.py builtin.py queryparser.py):
2009-08-01T17:59:35 <CIA-43> Xapian2009: AndExpression and TextSearch xapian_term() refactoring. It does not receive allterms parameter, but xappy.SearchConnection.
2009-08-01T17:59:35 <CIA-43> Index.search takes AndExpression as a query and converts it to a xapian query by xapian_term().
2009-08-01T17:59:35 <CIA-43> Xapian.Index.allterms() was deleted.
2009-08-01T18:12:13 <CIA-43> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4926:7a8e1567e7e4 1.9/MoinMoin/script/account/check.py: removed moin account check's --lastsaved option, it is default now (checking last use with trail file did not work in 1.9 anyway)
2009-08-01T18:29:44 *** grzywacz has joined #moin-dev
2009-08-01T18:32:40 <dennda> ThomasWaldmann: You mean just RouterBackend((('User/': UserBackend), ('Trash/': TrashBackend), ('/': Root)))?
2009-08-01T18:38:50 <ThomasWaldmann> that looks like mounting, not seperate namespaces
2009-08-01T18:39:15 <dennda> so what are you talking about exactly?
2009-08-01T18:39:45 <ThomasWaldmann> well, just think about the Trash/* items - how many of them do you want to see on TitleIndex?
2009-08-01T18:39:55 <dennda> none
2009-08-01T18:40:23 <ThomasWaldmann> right, there are 2 ways to do that
2009-08-01T18:40:46 <ThomasWaldmann> either specialcase some part of the namespace
2009-08-01T18:40:56 <ThomasWaldmann> or have some different namespace
2009-08-01T18:45:14 <dennda> ThomasWaldmann: Why not just provide another backend (as we do with userbackend currently) for trash in the routerbackend?
2009-08-01T18:47:31 <dennda> hm that'd make delete a potentially expensive operation
2009-08-01T18:48:14 <ThomasWaldmann> because that's hardcoding and not easily extendable?
2009-08-01T18:48:50 <ThomasWaldmann> yes, it has to copy stuff over to trash
2009-08-01T18:49:21 <ThomasWaldmann> otoh, you get rid of it and have the data backend small and fast
2009-08-01T18:49:38 <dennda> sure it has it's pros and cons
2009-08-01T18:50:15 <ThomasWaldmann> also less to back up
2009-08-01T18:50:51 <ThomasWaldmann> i am also thinking about maybe changing caching module one day to use a storage backend
2009-08-01T18:52:56 <dennda> so what exactly is the plan? i'm not sure I understood how you'd want that namespace stuff to look like
2009-08-01T18:54:35 <ThomasWaldmann> that namespace is a param you can give to the namespace middleware and it'll return the respective backend
2009-08-01T18:58:15 <dennda> namespace middleware != routing middleware?
2009-08-01T18:58:49 <ThomasWaldmann> well, it could be done in the routing middleware, but maybe easier to keep it separate
2009-08-01T18:59:15 <ThomasWaldmann> router -> mounts stuff together
2009-08-01T18:59:27 <ThomasWaldmann> namespace -> keeps stuff separate
2009-08-01T19:00:33 <dennda> To what call exactly would you pass that namespace parameter?
2009-08-01T19:03:43 <ThomasWaldmann> get_backend(namespace) maybe :)
2009-08-01T19:08:02 <dennda> ThomasWaldmann: And then it would be: backend = get_backend(USER_PREFIX) where USER_PREFIX was set to 'User/' in config?
2009-08-01T19:08:09 <dennda> same for TRASH_PREFIX
2009-08-01T19:10:38 <dennda> (if yes: How would that be different from having a router backend do the same thing based on the item name?)
2009-08-01T19:19:37 <ThomasWaldmann> rather 'User' (or User:)
2009-08-01T19:20:06 <dennda> ok, where's the difference?
2009-08-01T19:20:23 <ThomasWaldmann> trash and user are not mounted into the data namespace
2009-08-01T19:20:52 <ThomasWaldmann> (nor are they now)
2009-08-01T19:22:10 <dennda> ThomasWaldmann: but both have dedicated backends?
2009-08-01T19:22:27 <ThomasWaldmann> yes
2009-08-01T19:22:29 <ThomasWaldmann> http://en.wikipedia.org/wiki/Namespace
2009-08-01T19:22:46 <ThomasWaldmann> click on discussion link there :)
2009-08-01T19:23:19 <ThomasWaldmann> (you see it adds Talk: to switch namespace)
2009-08-01T19:24:05 <dennda> which would still make delete a possibly expensive operation
2009-08-01T19:24:26 <dennda> so basically all you want is the same we already have, just seperated into it's own module?
2009-08-01T19:24:26 <ThomasWaldmann> http://en.wikipedia.org/w/index.php?title=Special:Search&fulltext=Search&advanced=1&ns0=1&redirs=0&search=
2009-08-01T19:24:47 <ThomasWaldmann> no, currently it is hardcoded
2009-08-01T19:25:04 <ThomasWaldmann> and just user and data, not configurable
2009-08-01T19:25:55 <ThomasWaldmann> hmm
2009-08-01T19:26:17 * ThomasWaldmann looks at router again
2009-08-01T19:27:52 <ThomasWaldmann> maybe we can just use another router and remove the user specialcase stuff from router code
2009-08-01T19:29:08 <ThomasWaldmann> or, we use just one router, but a bit differently than now
2009-08-01T19:29:13 <dennda> So you specify data_backend =...; user_backend =...; trash_backend = ..;?
2009-08-01T19:30:10 <ThomasWaldmann> let me write it down...
2009-08-01T19:30:45 <dennda> good idea
2009-08-01T19:47:30 <dennda> argh sorry, gotta go (friend of mine leaving for a year. need to say goodbye before he's gone) MoinMoin: MoinMoinChat/Logs/moin-dev/2009-08-01 (last edited 2009-07-31 22:45:02 by IrcLogImporter)
