MoinMoin: MoinMoinChat/Logs/moin-dev/2009-06-10

2009-06-10T00:01:14  <ThomasWaldmann> dimazest: what's the point of __contains__ calling _exists_group?
2009-06-10T00:02:16  <ThomasWaldmann> (BaseBackend)
2009-06-10T00:02:51  <dimazest> you are right, no point
2009-06-10T00:03:21  <dimazest> it was, somwhere in the middle, because __contain__ converted the name
2009-06-10T00:03:43  <dimazest> but now it does _exists_group
2009-06-10T00:03:51  <dimazest> so, _exists_group should go away
2009-06-10T00:04:25  <dimazest> probably, same for __getitem__
2009-06-10T00:04:25  <ThomasWaldmann> same q. for __getitem__ and _get_group
2009-06-10T00:04:31  <ThomasWaldmann> yes :)
2009-06-10T00:04:36  <dimazest> :)
2009-06-10T00:07:32  <dimazest> any other comments? tomorrow i plan to do config backend
2009-06-10T00:07:40  <dimazest> work on tests
2009-06-10T00:11:47  <ThomasWaldmann> BackendManager is still alive?
2009-06-10T00:12:23  <dimazest> tomorrow it will be killed, as part of the work on config backend
2009-06-10T00:13:04  <ThomasWaldmann> ok
2009-06-10T00:13:27  <ThomasWaldmann> tomorrow = today
2009-06-10T00:14:41  <dimazest> yes
2009-06-10T00:17:50  *** grzywacz has quit IRC
2009-06-10T00:17:59  <ThomasWaldmann> ok, the backend stuff looks good. just do the small fixes noted above.
2009-06-10T00:20:42  <ThomasWaldmann>    132     # These methods should be overridden in children classes.
2009-06-10T00:21:01  <ThomasWaldmann> somehow I feel "child classes" sounds better, but not sure
2009-06-10T00:23:29  <ThomasWaldmann> dimazest: the config group stuff should be trivial to do now.
2009-06-10T00:23:56  <ThomasWaldmann> and you don't need caching, parsing there
2009-06-10T00:24:07  <dimazest> i do not know. unt es ist zu spät für die Grammatik :) the german exam is approaching
2009-06-10T00:24:25  <ThomasWaldmann> you just define a dict of groups in the config
2009-06-10T00:24:31  <ThomasWaldmann> hehe
2009-06-10T00:24:38  <dimazest> and then use that dict
2009-06-10T00:24:47  <dimazest> *und
2009-06-10T00:24:49  <ThomasWaldmann> wir koennen etwas trainieren, wenn du willst. :)
2009-06-10T00:24:54  <dimazest> aaaa typos
2009-06-10T00:25:12  <dimazest> naturlich
2009-06-10T00:25:33  <ThomasWaldmann> ue or ü
2009-06-10T00:25:57  <dimazest> ü
2009-06-10T00:27:22  <dimazest> gute Nacht, ich gehe schlafen
2009-06-10T00:27:50  <ThomasWaldmann> Schlaf gut. :)
2009-06-10T00:28:43  <dimazest> danke
2009-06-10T02:27:21  *** ext has quit IRC
2009-06-10T06:41:11  <CIA-19> Alexandre Martani <amartani AT gmail DOT com> default * 5928:9ce3768d3b5c 2.0-storage-editor-amartani/MoinMoin/ (2 files in 2 dirs): Real-time editor: Enable save and continue button only when content change
2009-06-10T06:44:25  *** amartani has quit IRC
2009-06-10T06:46:02  *** amartani has joined #moin-dev
2009-06-10T08:13:38  <ThomasWaldmann> moin
2009-06-10T09:00:15  <dimazest> morning
2009-06-10T10:11:23  *** grzywacz has joined #moin-dev
2009-06-10T11:05:46  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4776:4539a7956eac 1.9-groups-dmilajevs/MoinMoin/groups/backends/ (__init__.py wiki_group.py): Groups2009: BaseBackend _exists_group, _get_group and _get_group_names methods were removed.
2009-06-10T11:32:34  <ThomasWaldmann> dimazest: looks good (I guess it is easier that way)
2009-06-10T11:33:28  <ThomasWaldmann> amartani: when looking at your changeset, indentation looks a bit strange. do you use tab chars?
2009-06-10T11:33:44  <dimazest> yes, less code is better
2009-06-10T11:35:29  <ThomasWaldmann> amartani: http://hg.moinmo.in/moin/2.0-storage-editor-amartani/rev/9ce3768d3b5c see line 2.8 vs 2.9, 2.5 vs 2.6
2009-06-10T12:55:06  *** amartani has quit IRC
2009-06-10T12:55:47  *** amartani has joined #moin-dev
2009-06-10T13:28:33  <dreimark> moin
2009-06-10T13:37:01  <dreimark> guten nachmittag dimazest
2009-06-10T13:38:00  * dreimark looks at 1.8.4
2009-06-10T13:54:31  * dreimark did a stanbdalone test and it looks good to me
2009-06-10T15:08:16  <dreimark> quite silent today
2009-06-10T15:22:01  <dimazest> dreimark: hallo
2009-06-10T15:43:12  <dimazest> dreimark: ThomasWaldmann i was thinking to test backends
2009-06-10T15:44:28  <dimazest> the thing is that, that these tests repeat each other, the only difference is which backends has GroupManager, and how to make use cases
2009-06-10T15:44:51  <dimazest> for example, for wiki backend, wiki pages must be created
2009-06-10T15:45:16  <dimazest> for a config backend dictionary passed
2009-06-10T15:46:06  <dimazest> it would be nice, if it was possible to define groups once, and run backends against this setup
2009-06-10T15:46:18  <dimazest> am i clear enought?
2009-06-10T15:48:16  <ThomasWaldmann> dimazest: good idea
2009-06-10T15:49:03  <ThomasWaldmann> so maybe create page content from tests data (you can use the same dict as for config groups as source of test information)
2009-06-10T15:50:18  <ThomasWaldmann> and you can subclass the TestBase class with the common stuff then with the TestConfigGroup TestWikiGroup classes and just add the method to fill the group backend with data
2009-06-10T15:51:31  <dimazest> ok, i've started doing that already, is there something similar in other moin tests?
2009-06-10T15:51:41  <dimazest> just to see how it can be done
2009-06-10T15:52:23  <ThomasWaldmann> that's simple subclassing
2009-06-10T16:10:12  <dreimark> bb
2009-06-10T16:11:21  <dreimark> dimazest: please do also some tests for two different backends
2009-06-10T16:12:17  <dreimark> I think we should also store in the users data how the user was auto created if so
2009-06-10T16:13:00  <dimazest> dreimark: sure, i'll do it
2009-06-10T16:14:16  <dreimark> ThomasWaldmann: dimazest I am quite sure I can't be online on sat/sun (I take the XO with me) I am at a wedding party. I think it is ok if Thomas manages you at the meeting
2009-06-10T16:14:49  <dimazest> it's fine with me
2009-06-10T16:16:07  <ThomasWaldmann> dreimark: ok
2009-06-10T16:16:52  <ThomasWaldmann> btw, I will be travelling/away at friday, maybe also Thu or Sat
2009-06-10T16:17:25  <dreimark> good
2009-06-10T16:18:02  <dreimark> I am hopefully get on friday fixed the provider bug at home
2009-06-10T16:18:07  <dimazest> me too *) what a coinsedence
2009-06-10T16:20:40  <ThomasWaldmann> dreimark: i guess they will be low on technicians at friday
2009-06-10T16:22:56  <dreimark> what do we want to do if a user was auto created and has a cookie while the backend is not available
2009-06-10T16:23:17  <dreimark> not available because of: switched off, configuration change
2009-06-10T16:23:42  <dreimark> I think we should identify those and kill there sesseion cookie
2009-06-10T16:26:19  <dreimark> ThomasWaldmann: hopefully more people work on friday than on thursday
2009-06-10T16:26:49  <ThomasWaldmann> "Blau ist die Hoffnung." :)
2009-06-10T16:27:37  <dreimark> naja, ist auch die kde farbe. hab ner kollegin ubuntu und kbuntu gezeigt und auch angemerkt das letzteres Problem hat.
2009-06-10T16:27:54  <dreimark> war alles egal, denn "ich hasse braun" also kbuntu
2009-06-10T16:29:07  <ThomasWaldmann> it's not problem to install a nice background pic. :)
2009-06-10T16:33:16  <dreimark> http://twitter.com/pyCologne (me talks about mercurial)
2009-06-10T16:39:09  <ThomasWaldmann> yeah, already seen it :) have fun! :)
2009-06-10T16:47:06  <ThomasWaldmann> dreimark: btw, in case you have windows users there: point them to tortoisehg
2009-06-10T16:50:56  <dreimark> good idea. I have looked at it some weeks ago, very nice.
2009-06-10T16:51:37  <ThomasWaldmann> take it with a grain of salt, though, last time i tried (6m ago) it had quite some bugs and missing features
2009-06-10T16:52:42  <ThomasWaldmann> but it at least was quite promising, assuming that the bugs get fixed at some time. btw, thg is ALL you need on windows, all dependencies are included
2009-06-10T17:28:33  <dreimark> htg
2009-06-10T17:41:43  <dimazest> ThomasWaldmann: dreimark i think for wiki_group backend there is no need for name mapping
2009-06-10T17:42:19  <dimazest> i think it should not use it at all
2009-06-10T17:42:31  <dimazest> hg st
2009-06-10T17:47:36  <ThomasWaldmann> sure
2009-06-10T17:47:57  <ThomasWaldmann> so you can just use an identity function
2009-06-10T17:53:23  <dimazest> identity?
2009-06-10T17:57:51  <ThomasWaldmann> a function returning its argument unchanged
2009-06-10T17:58:06  <ThomasWaldmann> f(x) == x
2009-06-10T17:58:17  <dimazest> i think it better to ignore identity
2009-06-10T17:58:48  <ThomasWaldmann> if you completely override the code, you can also not call a function :)
2009-06-10T17:58:52  <dimazest> and use name, because code then becomes messy, and what more important, it needed to be tested
2009-06-10T17:59:27  <dimazest> that's what i'm doing *not* calling a function
2009-06-10T17:59:47  <dimazest> in the code, which is in wiki_page backend
2009-06-10T18:01:17  <ThomasWaldmann> Apache/1.3.41 Ben-SSL/1.59 Server at outam.com Port 443
2009-06-10T18:01:28  <ThomasWaldmann> old stuff...
2009-06-10T18:10:52  <ThomasWaldmann> dennda: maybe do not copy all of underlay, but just the english set of pages, see MoinMoin.18n.strings
2009-06-10T18:11:39  <ThomasWaldmann> dennda: and converting only has 2 "n", not 3 :)
2009-06-10T18:15:29  <ThomasWaldmann> dennda: RuntimeError: maximum recursion depth exceeded
2009-06-10T18:16:17  <ThomasWaldmann> that what I get from a fresh 2.0-storage clone, after creating the persistent dev wiki and then starting ./wikiserver.py
2009-06-10T18:18:15  <ThomasWaldmann> dennda: crash is somehow scan_dicts related
2009-06-10T18:19:26  <ThomasWaldmann> ... and acl related
2009-06-10T18:19:39  <ThomasWaldmann> dimazest: we need your code! :)
2009-06-10T18:31:57  <dimazest> which?
2009-06-10T18:32:48  <waldi> boah, really bad style: provide mimetype and item_name_ as interface. this have to be an object, which can use lazy loading
2009-06-10T18:33:41  <ThomasWaldmann> dimazest: the group code
2009-06-10T18:34:07  <ThomasWaldmann> waldi: hm?
2009-06-10T18:34:19  <ThomasWaldmann> everything is an object in python :)
2009-06-10T18:36:45  <TheSheep> at least anything that has a name
2009-06-10T18:41:57  * ThomasWaldmann tries to help with some "hacked" moin wiki
2009-06-10T19:00:56  *** ser has quit IRC
2009-06-10T19:04:35  <dimazest> By default, config groups are defined in config_groups in the config file.
2009-06-10T19:04:50  <dimazest> this doesn't not sound good
2009-06-10T19:11:56  *** ser has joined #moin-dev
2009-06-10T19:18:44  <ThomasWaldmann> well you'll have to create a group backend or manager in the config somehow
2009-06-10T19:19:05  <ThomasWaldmann> which will be later used for request.groups
2009-06-10T20:14:04  <dennda> ThomasWaldmann: without doing anything? havn't seen that before
2009-06-10T20:41:15  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4777:ed977dd981ce 1.9-groups-dmilajevs/MoinMoin/groups/ (__init__.py backends/__init__.py): Groups2009: repr for GroupManager and BaseBackend.
2009-06-10T20:41:19  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4778:fde7471cb2a3 1.9-groups-dmilajevs/MoinMoin/ (4 files in 2 dirs): Groups2009: The config_group backend initial commit. By default, config groups are defined in config_groups in the config file.
2009-06-10T20:41:21  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4779:3b05bf18c0d1 1.9-groups-dmilajevs/MoinMoin/groups/backends/ (5 files in 2 dirs): Groups2009: The BackendTest class provides basic test methods for testing backends. It should be inherited to test backends.
2009-06-10T20:41:23  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4780:1d90fe5f1bcf 1.9-groups-dmilajevs/MoinMoin/groups/backends/wiki_group.py: Groups2009: wiki_group backend does not use name mapping.
2009-06-10T20:41:26  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4781:878b5a87ba3b 1.9-groups-dmilajevs/MoinMoin/groups/ (4 files in 2 dirs): Groups2009: BackendManager was killed. GroupManager tests updated to use config_group.
2009-06-10T20:58:52  <dennda> ThomasWaldmann: Can't reproduce
2009-06-10T21:12:03  <dennda> ThomasWaldmann: Where did I misspell converting?
2009-06-10T21:13:53  <ThomasWaldmann> in the connverting ... output
2009-06-10T21:16:27  <ThomasWaldmann> and i did nothing else than:
2009-06-10T21:17:03  <ThomasWaldmann> run converter
2009-06-10T21:17:15  <ThomasWaldmann> edit config as described in converter
2009-06-10T21:17:21  <ThomasWaldmann> run wikiserver.py
2009-06-10T21:17:29  <ThomasWaldmann> access any wiki page
2009-06-10T21:17:57  <dennda> ah sec
2009-06-10T21:20:59  <dennda> hm
2009-06-10T21:21:11  <dennda> No recursion error but some infinite loop
2009-06-10T21:21:31  <dennda> and a few typeerros
2009-06-10T21:21:34  <dennda> *errors
2009-06-10T21:24:17  <dennda> ThomasWaldmann: And that happens as soon as I'm in the editor for some (nonexisting) page and click that page's link next to the MM logo (below the login)
2009-06-10T21:27:51  <dennda> ThomasWaldmann: As soon as I click that link on any page, actually.
2009-06-10T21:27:54  <dennda> got an idea?
2009-06-10T21:28:32  <xorAxAx> wednesday passed and no devilsadvocate :-(
2009-06-10T21:29:27  <dennda> no more musicals?
2009-06-10T21:29:46  <ThomasWaldmann> gtg/bbl
2009-06-10T21:29:57  <xorAxAx> dennda: musicals?
2009-06-10T21:30:04  <xorAxAx> do you mean the raga?
2009-06-10T21:30:10  <dennda> whatever
2009-06-10T21:31:05  <xorAxAx> he had very good written up stuff before he started, now he is kind of gone
2009-06-10T21:31:44  <dennda> Yes I noticed that he's not dumb
2009-06-10T23:38:27  <dennda> Finding the right words when writing documentation is not that easy a task
2009-06-10T23:53:32  <ThomasWaldmann> re
2009-06-10T23:59:32  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5930:bf8f9d69e304 2.0-storage/MoinMoin/storage/backends/acl.py: storage: First improvement of overall documentation of MoinMoin.storage.backends.acl; epydoc still largely missing