MoinMoin: MoinMoinChat/Logs/moin-dev/2009-06-01

2009-06-01T00:30:41  <dreimark> can the meta be guessed if it does not exist ?
2009-06-01T00:35:33  * ThomasWaldmann watches google wave demo
2009-06-01T00:35:51  <ThomasWaldmann> dreimark: no
2009-06-01T00:36:19  <ThomasWaldmann> (wave == cool stuff)
2009-06-01T00:36:51  <dreimark> yeah. I entered a wish already for our intr
2009-06-01T00:36:53  <dreimark> anet
2009-06-01T00:37:26  <dreimark> (it was the right time to tell them not to make too much plans)
2009-06-01T00:38:28  <dreimark> why is _save an internal method?
2009-06-01T00:39:31  <ThomasWaldmann> it maybe shouldn't be
2009-06-01T00:45:37  <dreimark> tests seem to look for workspace/moin-2.0-storage/MoinMoin/_tests/wiki/data/plugin
2009-06-01T00:45:59  <dreimark> good night
2009-06-01T00:50:15  <ThomasWaldmann> gn
2009-06-01T02:42:14  *** devilsadvocate has quit IRC
2009-06-01T02:42:33  *** devilsadvocate has joined #moin-dev
2009-06-01T05:35:00  *** devilsadvocate has quit IRC
2009-06-01T05:39:19  *** devilsadvocate has joined #moin-dev
2009-06-01T09:23:41  <dimazest> moin!
2009-06-01T11:18:31  <ThomasWaldmann> moin
2009-06-01T11:27:25  <ThomasWaldmann> devilsadvocate: how about working on your project?
2009-06-01T12:29:57  <ThomasWaldmann> dreimark: does 1.9 show unzip (install) for you?
2009-06-01T13:10:48  <ThomasWaldmann> dreimark: solved. getting superuser in desktop mode requires log in as any user.
2009-06-01T13:26:03  <ThomasWaldmann> dreimark: searchpackage is not specified well enough. where does it search for the search term? page names? page content?
2009-06-01T13:32:32  <ThomasWaldmann> same is true for the script command using it, help string is not helpful
2009-06-01T13:33:59  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4727:9b6b7ff7f5ac 1.9/MoinMoin/ (_tests/test_wikiutil.py theme/__init__.py): fix system pages group tests, fix pep8 issue
2009-06-01T14:03:24  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4337:5eccbe592847 1.8/MoinMoin/config/__init__.py: fix pep8 issue
2009-06-01T14:09:01  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4728:4d2bc24c7723 1.9/MoinMoin/theme/__init__.py: fix typo in IE conditional comment
2009-06-01T14:09:03  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4729:2a55ba43afb3 1.9/MoinMoin/filter/EXIF.py: filter.EXIF: reduce renamed to reduce_size (avoid name clash)
2009-06-01T14:09:04  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4730:614dac6122cb 1.9/MoinMoin/filter/EXIF.py: merged moin/1.7
2009-06-01T14:09:06  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4731:512aeb66b980 1.9/MoinMoin/auth/http.py: http auth: do auth_type comparisons case-insensitive
2009-06-01T14:09:07  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4732:e9a2cbcf5479 1.9/MoinMoin/action/CopyPage.py: action.CopyPage: added textcha feature
2009-06-01T14:09:09  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4733:742ace271d41 1.9/MoinMoin/ (action/CopyPage.py auth/http.py): merged moin/1.7
2009-06-01T14:09:12  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 4734:c538e2b0bba9 1.9/MoinMoin/ (config/__init__.py macro/EmbedObject.py): macro.EmbedObject: changed default width value for pdf files to 100%.
2009-06-01T14:09:17  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4736:d887cc013e76 1.9/MoinMoin/ (6 files in 6 dirs): merged moin/1.8
2009-06-01T14:15:51  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5702:d87cf99cd525 1.9-storage/MoinMoin/parser/text_irssi.py: replace our text_irssi parser with a wrapper around pygments' irc highlighter
2009-06-01T14:15:51  <dennda> ThomasWaldmann: there's become_superuser et al. but there's nothing like become_admin... How would I do that in order to fix the tests?
2009-06-01T14:15:54  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5703:273ec9b3bf7d 1.9-storage/MoinMoin/ (4 files in 3 dirs): remove dumpFormData debug stuff, use logging.debug/repr/etc.
2009-06-01T14:15:55  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5704:0817780f35d4 1.9-storage/MoinMoin/i18n/ (7 files): updated i18n
2009-06-01T14:15:57  <CIA-19> Reimar Bauer <rb.proj AT googlemail DOT com> default * 5705:70c8457d68ab 1.9-storage/ (2 files in 2 dirs): PEP8 whitespace fix
2009-06-01T14:16:00  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5717:6642bfe0ba9f 1.9-storage/ (22 files in 13 dirs): merged moin/1.9
2009-06-01T14:16:58  <ThomasWaldmann> dennda: add what you need
2009-06-01T14:22:59  <dennda> ThomasWaldmann: got a hint on how to make the user admin programatically?
2009-06-01T14:25:36  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5847:9e970b5c686a 2.0-storage/MoinMoin/caching.py: the "sha" module is deprecated, use the compatibility wrapper!
2009-06-01T14:25:38  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5848:8019a8b5a7bf 2.0-storage/MoinMoin/ (3 files in 2 dirs): the "md5" module is deprecated, use the compatibility wrapper!
2009-06-01T14:25:45  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 5865:7c2f80921e30 2.0-storage/ (22 files in 13 dirs): merged moin/1.9-storage
2009-06-01T14:26:42  <ThomasWaldmann> dennda: have a test Config class with acl_rights_before = u"All:admin,..."?
2009-06-01T14:28:06  <ThomasWaldmann> (then you don't need become_admin ...)
2009-06-01T14:33:22  <ThomasWaldmann> ok, tests are now rather ok except for searchpackages and still some major problems in 1.9-storage and 2.0-storage
2009-06-01T14:33:26  <ThomasWaldmann> brb
2009-06-01T16:21:38  <ThomasWaldmann> we have >1000 master19 pages in the needs_fixing package :|
2009-06-01T16:30:25  <ThomasWaldmann> how about merging HelpOnLanguages and SystemPagesSetup?
2009-06-01T16:49:19  <dennda> ThomasWaldmann: How exactly would I do that properly? Tried several things but none worked. I'm likely doing it wrong, but there's no proper documentation and I'd need to dive through a quite a few different Config classes
2009-06-01T16:52:14  <ThomasWaldmann> show me how you did it
2009-06-01T16:52:32  <dennda> several things
2009-06-01T16:52:53  <dennda> tried just assigning that u"All:admin" string to request.cfg.acl_rights_before in setUp; didn't work
2009-06-01T16:53:36  <dennda> tried defining class Config(wikiconfig.Config):\n\t acl_rights_before = u"All:admin" and putting that as request.given_config didn't work.
2009-06-01T16:54:13  <dennda> tried to pass it to init_test_request() and assign the result to self.request in setUp; didn't work
2009-06-01T16:55:16  <ThomasWaldmann> you just need to define the Config class within your test, nothing else
2009-06-01T16:56:36  <dennda> ThomasWaldmann: http://paste.pocoo.org/show/120356/ like so?
2009-06-01T16:57:06  <dennda> because that still raises the ADErrors
2009-06-01T16:58:30  <ThomasWaldmann> maybe just "admin" is not enough...
2009-06-01T17:00:00  <dennda> ok let's forget these last three lines :-)
2009-06-01T17:01:04  <dennda> it should be acl_rights_default and not _before, though
2009-06-01T17:01:48  <ThomasWaldmann> why?
2009-06-01T17:02:17  <dennda> because there's no acl at all when creating an item out of nothing and then _default is used
2009-06-01T17:02:33  <dennda> if I use _before I get a bunch of DID NOT RAISE, because first match counts...
2009-06-01T17:07:32  <dennda> one test has quite nice stderr output
2009-06-01T17:08:12  <ThomasWaldmann> of course you only use that acl for test where the user shall have admin rights
2009-06-01T17:09:48  <dennda> whatÃ's the default behavior if somebody creates a new page with no acl on it. is he admin automatically?
2009-06-01T17:10:06  <ThomasWaldmann> if course not :P
2009-06-01T17:10:17  <dennda> http://hg.moinmo.in/moin/2.0-storage/rev/f71e7a7a4fe8#l1.67
2009-06-01T17:10:43  <dennda> that is correct then, isn't it?
2009-06-01T17:12:10  <ThomasWaldmann> looks ok
2009-06-01T17:12:41  <ThomasWaldmann> hmm, no
2009-06-01T17:13:41  <ThomasWaldmann> of course it is allowed to copy the acl from the last existing rev to the new rev without change
2009-06-01T17:14:32  <ThomasWaldmann> so you need to check whether the ACL changes, not whether someone sets it
2009-06-01T17:14:44  <dennda> true
2009-06-01T17:15:37  <dennda> in all tests that don't test the admin capability itself I want All:admin by default, though
2009-06-01T17:55:35  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4737:ebe54f59e87c 1.9/MoinMoin/ (3 files in 3 dirs): system/help page packages: build all pagesets, use LanguageSetup as front page (unifies old SystemPagesSetup with the setup specific part of HelpOnLanguages)
2009-06-01T18:00:22  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5866:ef18f9815a35 2.0-storage/MoinMoin/storage/_tests/test_middleware_acl.py: storage: Tests: Use All:admin,read,write by default when item is newly created
2009-06-01T18:00:26  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5867:cd0609ffb4d9 2.0-storage/MoinMoin/storage/ (_tests/test_middleware_acl.py backends/acl.py): storage: Allow to keep the preceeding revision's ACL in the succeeding revision
2009-06-01T18:01:20  <ThomasWaldmann> dennda: previous and next :)
2009-06-01T18:01:55  <dennda> sounds too proletarian
2009-06-01T18:03:29  <ThomasWaldmann>     19     Test the AMW       < please fix such comments
2009-06-01T18:03:52  <ThomasWaldmann> if the comment doesn't tell more than the class or method name, it is useless.
2009-06-01T18:04:08  <dennda> 3dd
2009-06-01T18:04:09  <dennda> fixed
2009-06-01T18:06:36  <ThomasWaldmann>     52     def test_write_after_create(self): < so one may create an item, but not a revision in it?
2009-06-01T18:08:36  <ThomasWaldmann>     57     def test_copy_without_acl_change(self): < maybe better not call that "copy", but rather "modify"
2009-06-01T18:08:38  <dennda> ThomasWaldmann: create_item_acl already created a rev with acl == "All:" so the user has no 'write' and may hence not create a revision
2009-06-01T18:09:34  <ThomasWaldmann> ok, then a test for create without having the permissions is missing
2009-06-01T18:10:24  <dennda> i.e. when creating rev 0?
2009-06-01T18:10:32  <ThomasWaldmann> btw, did you think about whether a "create" capability makes sense?
2009-06-01T18:10:40  <ThomasWaldmann> no, when calling create_item
2009-06-01T18:11:16  <dennda> whether that makes sense depends on what you want I think
2009-06-01T18:11:50  <ThomasWaldmann> for what do you want to create an item if you can't create a revision in it?
2009-06-01T18:12:31  <dennda> that was an answer to your "create" capability question
2009-06-01T18:12:45  <dennda> (users are stored as revision-less items, btw)
2009-06-01T18:13:07  <ThomasWaldmann> yes, and there are no ACLs (yet)
2009-06-01T18:14:42  <dennda> I'm under the impression our discussion went out of sync :-)
2009-06-01T18:15:30  <ThomasWaldmann> e.g. on a publically editable wiki, you could have Known:read,create,write,delete All:read,write(,delete?)
2009-06-01T18:16:21  <ThomasWaldmann> so unknown users can freely edit, but not create new pages
2009-06-01T18:17:27  <dennda> well if you want that I think we might indeed need an extra privilege for that
2009-06-01T18:19:18  <ThomasWaldmann> the question is if anything speaks against doing that
2009-06-01T18:21:11  <dennda> create "foo", write to "foo", ..., delete "foo", may somebody with write and not create still edit that page?
2009-06-01T18:21:46  <dennda> e.g. revert it after vandalism?
2009-06-01T18:22:32  <dennda> if not that would effectively introduce a new 'revert' as a synonym of 'create' in that specific case
2009-06-01T18:24:08  <ThomasWaldmann> write == creating a new revision
2009-06-01T18:24:17  <ThomasWaldmann> create = creating a new item
2009-06-01T18:24:33  <dennda> i know
2009-06-01T18:25:00  <ThomasWaldmann> revert is already gone, because it is equivalent to write
2009-06-01T18:25:06  <dennda> so he may?
2009-06-01T18:25:48  * ThomasWaldmann thinks
2009-06-01T18:26:40  <ThomasWaldmann> from one standpoint (he is just creating a new rev) "write" should be enough
2009-06-01T18:27:08  <dennda> that'd make it impossible to deny having a page that was once accepted
2009-06-01T18:27:33  <dennda> e.g. somebody accidentially created "CollectionOfPorn"
2009-06-01T18:27:39  <ThomasWaldmann> otoh, the current behaviour of the wiki just behaves the same way no matter whether there is no item or just a deleted item, so handling it differently would be a bit strange
2009-06-01T18:27:51  <dennda> you'd never get rid of that without some nuke_item
2009-06-01T18:28:16  <dennda> current behaviour == < 2.0?
2009-06-01T18:28:25  <ThomasWaldmann> but that brings us back to delete implementation :)
2009-06-01T18:28:39  <ThomasWaldmann> also 2.0
2009-06-01T18:29:09  <ThomasWaldmann> i guess we first have to solve delete
2009-06-01T18:29:15  <dennda> is there even a user asking for that? the use case itself doesn't seem that widespread
2009-06-01T18:29:45  <ThomasWaldmann> yes, there were requests iirc
2009-06-01T18:31:35  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4738:4cf58f58fff3 1.9/MoinMoin/i18n/ (43 files): updated i18n
2009-06-01T18:33:30  <dennda> ThomasWaldmann: >           NoSuchRevisionError: No Revision #-1 on Item SomeGroup - Available revisions: []
2009-06-01T18:33:34  <dennda> did you mean that?
2009-06-01T18:35:58  <ThomasWaldmann> yesterday? yes.
2009-06-01T18:36:19  <dennda> if there's no revision then -1 won't work of course
2009-06-01T18:36:20  <ThomasWaldmann> and also some "None" problems
2009-06-01T18:37:19  <ThomasWaldmann> of course, but still some code is wrong then :)
2009-06-01T18:39:08  <ThomasWaldmann> also, the traceback somehow looked strange
2009-06-01T18:41:10  <dennda> everything below MoinMoin.items looks normal
2009-06-01T18:42:14  <dennda> actually
2009-06-01T18:42:22  <dennda> why isn't that caught by the exception handler...
2009-06-01T18:44:28  <dennda> as soon as it raises the NoSuchRevisionError the testcase ends and py.test reports that as the tests outcome, but you have an exception handler for that exception
2009-06-01T18:45:51  <ThomasWaldmann> is that maybe that strange acl wrapper function?
2009-06-01T18:46:11  <dennda> hm?
2009-06-01T18:46:34  <ThomasWaldmann> your decorator. it somehow looks a bit too complicated (not sure).
2009-06-01T18:46:59  <dennda> http://paste.pocoo.org/show/120387/
2009-06-01T18:49:26  <dennda> problem persists even if decorator is commented out
2009-06-01T18:50:15  <ThomasWaldmann> _save is there twice, going back in time
2009-06-01T18:50:23  <dennda> that's another odd thing, yes
2009-06-01T18:50:25  <ThomasWaldmann> looks like some lazy eval trouble
2009-06-01T18:51:08  <dennda> can we rule out py.test fuckup?
2009-06-01T18:51:26  <ThomasWaldmann> hehe, how funny. the radio played a song that just said "Access denied". :D
2009-06-01T18:51:39  <dennda> :-)
2009-06-01T18:51:43  <ThomasWaldmann> di.fm / trance
2009-06-01T18:52:14  <dennda> didn't know you were into trance
2009-06-01T18:52:29  <ThomasWaldmann> i would first search the bug in our code.
2009-06-01T18:53:21  <dennda> i have no idea how it could *possibly* walk back in time there
2009-06-01T18:56:21  <ThomasWaldmann> maybe use a debugger?
2009-06-01T19:15:11  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4739:25c99926e6aa 1.9/ (3 files in 3 dirs): LanguageSetup: fix pathes, use it as initial front page
2009-06-01T19:20:09  <ThomasWaldmann> btw, i would like some comments on current 1.9 and it's way to deal with help and system pages (which is quite different from the past)
2009-06-01T19:25:56  <dennda> talking to me?
2009-06-01T19:28:03  <ThomasWaldmann> dennda: to *
2009-06-01T20:15:57  *** grzywacz has joined #moin-dev
2009-06-01T20:21:21  <CIA-19> Dmitrijs Milajevs <dimazest@gmail.com> default * 4739:3f9147c23d9c 1.9-groups-dmilajevs/ (11 files in 9 dirs): Groups2009: MoinMoin.GroupDict became MoinMoin.groups.backends.wiki_pages.Backend. request.groups proviedes access to group definitions. request.dicts was removed.
2009-06-01T20:28:56  <ThomasWaldmann> ah, new group code
2009-06-01T20:29:38  <dimazest> is something wrong?
2009-06-01T20:33:36  <ThomasWaldmann> i am looking at it right now :)
2009-06-01T20:33:39  <ThomasWaldmann>     4.12 +            except AttributeError:
2009-06-01T20:33:39  <ThomasWaldmann>     4.13 +                pass
2009-06-01T20:34:23  <ThomasWaldmann> be careful with such stuff. noone tells that the AttributeError is due to the missing update_cache, it could also be an AttributeError within that method
2009-06-01T20:36:08  <ThomasWaldmann> (and you'll never find that problem then, because you catch the exception...)
2009-06-01T20:39:34  <ThomasWaldmann> in general, always be careful with except/pass
2009-06-01T20:40:34  <ThomasWaldmann> btw, what's the difference between load_cache and update_cache?
2009-06-01T20:42:55  <dimazest> load cahche reads it, and update writes it
2009-06-01T20:43:19  <dimazest> are read, write better names?
2009-06-01T20:43:20  <ThomasWaldmann> btw, I just killed that SystemPages*Group stuff, maybe use something else for testing
2009-06-01T20:43:46  <dimazest> :) ok
2009-06-01T20:43:58  <dimazest> btw, should i pull changes from 1.9?
2009-06-01T20:44:08  <ThomasWaldmann> (you could create an own *Group page in test setup)
2009-06-01T20:44:56  * dimazest hopes that doing small often merges is better then one and big
2009-06-01T20:45:03  <ThomasWaldmann> maybe after you have fixed other stuff. in generall, pulling all 1..2 weeks or so is a good idea, so it doesn't get out of sync too much.
2009-06-01T20:45:12  <ThomasWaldmann> yes, definitely.
2009-06-01T20:46:18  <dimazest> btw, i think this commit was too big, because in the end it was hard for me to track changes :)
2009-06-01T20:46:29  *** ser has quit IRC
2009-06-01T20:46:36  *** ser has joined #moin-dev
2009-06-01T20:46:39  <ThomasWaldmann> btw, for longer code, it is often useful to start with: request = self.request, so you don't need the "self." all the time
2009-06-01T20:47:51  *** grzywacz has quit IRC
2009-06-01T20:48:22  *** grzywacz has joined #moin-dev
2009-06-01T20:48:22  <ThomasWaldmann> dimazest: testSystemPagesGroupInDicts < that looks strange. isn't that checking some code behaviour against same code's behaviour?
2009-06-01T20:49:15  <ThomasWaldmann> maybe rather start with writing some own group page with a few members and then use your wiki_group code to check whether it is there
2009-06-01T20:50:42  <ThomasWaldmann> btw, if the stuff isn't called "dicts" any more, the test shouldn't be named ...InDicts either
2009-06-01T20:50:50  <dimazest> ok
2009-06-01T20:51:40  <dimazest> there are some naming glitches, i'm fix them in the future
2009-06-01T20:52:01  <ThomasWaldmann> grouppages = ... # but it isn't used later!?
2009-06-01T20:52:14  <dimazest> group expanding is needed to be done. together i tried, but without any luck
2009-06-01T20:52:18  <dimazest> ??
2009-06-01T20:52:54  <ThomasWaldmann> see the test code, maybe read it again, line by line, word by word
2009-06-01T20:54:34  <dimazest> what i did is codied Moinoin._test.test_wikidicts
2009-06-01T20:55:16  *** grzywacz has quit IRC
2009-06-01T20:55:17  <ThomasWaldmann> and please refactor the code after doing the module restructuring
2009-06-01T20:55:19  <dimazest> and then changed code in critical places, so i need to reread this tests
2009-06-01T20:55:50  *** grzywacz has joined #moin-dev
2009-06-01T20:56:20  <ThomasWaldmann> and kill that DictBase/DictDict
2009-06-01T20:57:01  <ThomasWaldmann> also, wikidicts shall get removed in the end
2009-06-01T20:57:52  * dimazest thinking to take Melitas backend
2009-06-01T20:58:00  <dimazest> was it working?
2009-06-01T20:59:08  <ThomasWaldmann> in general I would say "no", but that's maybe too general
2009-06-01T20:59:31  <dimazest> ThomasWaldmann:  http://host121-107-dynamic.5-87-r.retail.telecomitalia.it:8000 this is my local repo, changest there shows which files were moed or copied
2009-06-01T20:59:35  <ThomasWaldmann> maybe just rewrite the code and don't stick too much at what you see somewhere.
2009-06-01T20:59:37  <dimazest> *moved
2009-06-01T20:59:45  <dimazest> :)
2009-06-01T21:00:19  <ThomasWaldmann> having groups and members is not THAT complicated as the code that handles it currently.
2009-06-01T21:12:20  <ThomasWaldmann> dimazest:     10.8 \ No newline at end of file  (always have a newline at EOF)
2009-06-01T21:13:32  <dennda> Is that part of PEP8? Oo
2009-06-01T21:14:27  <ThomasWaldmann> no, that is part of having nice diffs with no complaints at the end :P
2009-06-01T21:14:38  <dennda> aha
2009-06-01T21:15:05  <dimazest> :)
2009-06-01T21:26:22  <dennda> ThomasWaldmann: could you delete the garbage that is left in MoinMoin.actions? Afaict there's a few obsolete things (looking at newpage.py)
2009-06-01T21:26:34  <dennda> 2.0 works even when that file is deleted
2009-06-01T21:26:44  <dennda> you got the better overview :-)
2009-06-01T21:33:12  <ThomasWaldmann> i already deleted the crap
2009-06-01T21:33:27  <dennda> newpage.py is still there
2009-06-01T21:33:38  <ThomasWaldmann> newpage is not completely superfluous (although some simple case can be done with link markup)
2009-06-01T21:34:08  <ThomasWaldmann> (that doesn't mean that there is no stuff left needing fixing)
2009-06-01T21:34:48  <dennda> grepping for may it's still used in a bunch of places
2009-06-01T21:35:08  <dennda> but we havn't decided yet how that should be done
2009-06-01T21:35:45  <dennda> (that's why I was asking the other day how some things know whether the user has the appropriate permission)
2009-06-01T21:39:44  <CIA-19> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4740:97601c1c1cdd 1.9/MoinMoin/i18n/tools/mail_i18n-maintainers.txt: new translation maintainer notification text
2009-06-01T21:40:52  <ThomasWaldmann> dennda: i already told you that we likely need to keep some "may" functionality exposed for these purposes
2009-06-01T21:41:40  <dennda> yes, so what should I do now?
2009-06-01T21:41:56  <ThomasWaldmann> how about thinking about it? :)
2009-06-01T21:42:33  <ThomasWaldmann> if you have multiple suggestions, we can choose together
2009-06-01T21:45:50  <ThomasWaldmann> one choice seems rather obvious, btw
2009-06-01T21:46:19  <dennda> exposure of the AMWs may?
2009-06-01T21:46:54  <ThomasWaldmann> well, all the code is calling user.may.read(pagename)
2009-06-01T21:47:37  <ThomasWaldmann> so, if you just keep that (and make it use your other _may), wouldn't that be easy?
2009-06-01T21:48:04  <dennda> i refrain from judging that without having looked at the code, but yes, it /sounds/ easy
2009-06-01T21:58:39  * ThomasWaldmann sent some wakeup mail to the translators :)
2009-06-01T22:03:47  <dennda> py.test --pdb
2009-06-01T22:03:49  <dennda> how cool is that
2009-06-01T22:05:42  <dennda> hm
2009-06-01T22:05:45  <dennda> isinstance checks in tests
2009-06-01T22:05:50  <dennda> does that sound bad?
2009-06-01T22:06:00  <dennda> (in a duck-typed language)
2009-06-01T22:10:55  <ThomasWaldmann> like?
2009-06-01T22:11:04  <dennda> isinstance(item, Item)
2009-06-01T22:11:47  <dennda> that obviously can't work if isinstance(item, AclWrapperItem)
2009-06-01T22:12:05  <dennda> hm actually
2009-06-01T22:12:08  <dennda> for item it may
2009-06-01T22:12:12  * dennda thinks
2009-06-01T22:27:16  <dennda> I think I found the -1 bug
2009-06-01T22:27:26  <dennda> And I think I fixed that already when coding started
2009-06-01T22:29:02  <dennda> Ah no, I didn't
2009-06-01T23:08:32  <dennda> wtf
2009-06-01T23:14:44  <dennda> there's several generic backend testcases that create items with the exact same name, commit them and go on. why, for example, do the memorybackend tests NOT raise any ItemAlreadyExistsError but the AMW tests do? (as they should)
2009-06-01T23:15:46  <dennda> http://hg.moinmo.in/moin/1.9-storage/file/6642bfe0ba9f/MoinMoin/storage/_tests/test_backends.py#l298
2009-06-01T23:15:50  <dennda> the same in 2.0
2009-06-01T23:16:00  <dennda> note that there's three testcases creating item_13
2009-06-01T23:16:12  <dennda> that's done in a bunch of other places as well
2009-06-01T23:17:37  <dennda> ah
2009-06-01T23:17:44  <dennda> hm
2009-06-01T23:22:36  <dennda> gotcha
2009-06-01T23:27:14  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5868:77d116c6f64d 2.0-storage/MoinMoin/storage/backends/acl.py: storage: Indentation fix
2009-06-01T23:27:16  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5869:6efa38dc73ce 2.0-storage/MoinMoin/storage/backends/acl.py: storage: wrapper fix
2009-06-01T23:27:18  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5870:e1f4b92c8342 2.0-storage/MoinMoin/storage/_tests/test_middleware_acl.py: storage: Run AMW through normal backend tests as well (checks for API compatibility)
2009-06-01T23:27:19  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5871:930b8178101b 2.0-storage/MoinMoin/storage/backends/acl.py: storage: Make AMWItem and AMWNewRevision inherit from Item/NewRevision. Does no harm and makes tests happy
2009-06-01T23:27:21  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5872:3dc7fb306a56 2.0-storage/MoinMoin/storage/backends/acl.py: storage: Fix get_revision(-1) error
2009-06-01T23:27:24  <CIA-19> Christopher Denter <moin GUESSWHAT the DASH space DASH station ROUNDTHING com> default * 5873:ab2fcbee88f4 2.0-storage/MoinMoin/storage/_tests/test_middleware_acl.py: storage: AMW now runs through all the generic backend tests successfully
2009-06-01T23:27:57  * ThomasWaldmann pulls
2009-06-01T23:30:58  <dennda> down to 48 failing tests at a whole
2009-06-01T23:33:02  <dennda> it's not fully fixed yet
2009-06-01T23:33:08  <dennda> there's still that odd behaviour in other places
2009-06-01T23:34:33  <dennda> any idea how one only starts one specific testcase with py.test?
2009-06-01T23:35:29  <ThomasWaldmann> hmm, test output still looks similar (maybe at other places?)
2009-06-01T23:35:50  <dennda> just said that :-)
2009-06-01T23:35:59  <ThomasWaldmann> i usually give nothing or the filename of the test
2009-06-01T23:36:18  <dennda> yes, with testcase I meant the actual function
2009-06-01T23:41:02  <ThomasWaldmann> dennda: -k foo
2009-06-01T23:41:21  <dennda> great, thanks
2009-06-01T23:41:52  <dennda> ah didn't realize that's what I was looking for when I found it ;)
2009-06-01T23:44:15  <ronny> the docs for the -k parameter suck
2009-06-01T23:44:36  <ronny> its easy to miss
2009-06-01T23:44:39  <ronny> btw, sup
2009-06-01T23:44:58  <ThomasWaldmann> it's the "i feel lucky" opt
2009-06-01T23:46:39  <ronny> hm, i have the nagging feeling my refactorings on 25c3 have benn rather suboptimal since the road i proposed for config didn't meet approval
2009-06-01T23:54:57  <ThomasWaldmann> hm?
2009-06-01T23:57:42  <ThomasWaldmann> ronny: what do you mean?