MoinMoin: MoinMoinChat/Logs/moin-dev/2008-10-12

2008-10-12T00:23:58  <dreimark> re
2008-10-12T00:24:03  <dreimark> gn TheSheep
2008-10-12T00:26:52  <CIA-26> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4383:e25b00b3a308 1.9/MoinMoin/parser/ (highlight.py text_diff.py): replace the diff parser by a thin wrapper around the highlight parser (to keep syntax like {{{#!diff ... working)
2008-10-12T00:27:11  <ThomasWaldmann>  (scnr)
2008-10-12T00:28:47  <dreimark> ThomasWaldmann: we forgot to mention the new config macros in CHANGES by johill
2008-10-12T00:33:00  * dreimark adds some docs on the HelpOnMacro page
2008-10-12T00:34:17  <ThomasWaldmann> iirc I did
2008-10-12T00:34:48  <ThomasWaldmann>     * New macros "WikiConfig" and "WikiConfigHelp".
2008-10-12T00:44:13  <dreimark> yeah me has overlooked it
2008-10-12T00:45:31  <ThomasWaldmann> dreimark: btw, I won't remove ParserBase for now, but I'll add a deprecation warning
2008-10-12T00:46:04  * dreimark has readed and edited the wrong master wiki
2008-10-12T00:46:12  <dreimark> ok
2008-10-12T00:46:23  <ThomasWaldmann> so extension highlighting parsers will continue to work until we finally remove it (likely when the dom changes get merged)
2008-10-12T00:50:14  <dreimark> ThomasWaldmann: is html now highlighted or rendered, I have not tried it, how can it destinguish?
2008-10-12T00:50:52  <dreimark> I mean you want both for "attachments"
2008-10-12T00:59:18  <CIA-26> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 4384:09328e4aab45 1.9/MoinMoin/parser/_ParserBase.py: deprecate ParserBase syntax highlighter
2008-10-12T00:59:53  <ThomasWaldmann> dreimark: the text_html parser does safe html rendering
2008-10-12T01:01:22  <dreimark> I mean we have to destinguish if #!html renders save or highlights. and for attachments somone would like to highlight and one other may be want to look at the rendered output
2008-10-12T01:01:41  <ThomasWaldmann> yes
2008-10-12T01:02:37  <dreimark> in 1.8 it is always rendered in 1.9 it means another ui parameter
2008-10-12T01:02:43  <dreimark> is possible
2008-10-12T01:03:46  <dreimark> or necessary
2008-10-12T01:04:25  <ThomasWaldmann> yes, that's a generic thing
2008-10-12T01:04:55  <ThomasWaldmann> pygments can highlight rst, moin, html, ... - but we could also render it
2008-10-12T01:06:15  <ThomasWaldmann> we can by default try to render, if no renderer is available (or highlight action is used), we highlight
2008-10-12T01:10:01  <dreimark> may be can show a link to the rendered source too. we should have the fallback showing the source if we can't render it
2008-10-12T01:11:19  <dreimark> and for the parsers I currently think we should only use the #!parser syntax for parsers which render
2008-10-12T01:11:34  <dreimark> otherwise it is confusing, that some do render and some highlight
2008-10-12T01:12:11  <dreimark> that change can be delayed.
2008-10-12T01:14:11  <ThomasWaldmann> everything going via the highlight parser is quite clear
2008-10-12T01:15:25  <dreimark> yes, but #!csv renders  and #!diff highlights or #!python highligths and #!html renders
2008-10-12T01:15:34  <ThomasWaldmann> the only "old" highlighting parser left over currently is text_irssi
2008-10-12T01:16:20  <ThomasWaldmann> diff/pascal  /python/cplusplus
2008-10-12T01:16:35  <ThomasWaldmann> these are just there for markup compatibility
2008-10-12T01:17:11  <dreimark> I know but I think long term they need to be migrated to the highligth parser
2008-10-12T01:18:03  <ThomasWaldmann> yes, lets wait until it has stabilized and someone wrote a markup converter :)
2008-10-12T01:18:24  * ThomasWaldmann has still to write another converter, so it won't be me
2008-10-12T01:43:18  <dreimark> gn
2008-10-12T01:43:39  <ThomasWaldmann> gn dreimark
2008-10-12T10:49:08  <dreimark> moin
2008-10-12T11:49:06  <ThomasWaldmann> moin
2008-10-12T11:56:11  <CIA-26> Radomir Dopieralski <moindev@sheep.art.pl> default * 4385:68998671e2ae 1.9/MoinMoin/parser/highlight.py: parser/highlight.py: highlight Token.Operator.Word as a ResWord
2008-10-12T11:56:12  <CIA-26> Radomir Dopieralski <moindev@sheep.art.pl> default * 4386:fad86749fe04 1.9/MoinMoin/parser/ (7 files): merge main
2008-10-12T11:56:13  <CIA-26> Radomir Dopieralski <moindev@sheep.art.pl> default * 4387:539ce55c4731 1.9/MoinMoin/parser/highlight.py: parser/highlight.py: include css classes for diff
2008-10-12T11:56:30  <TheSheep> moin
2008-10-12T12:03:31  <ThomasWaldmann> TheSheep: i already added the diff stuff tonight
2008-10-12T12:05:43  <TheSheep> argh
2008-10-12T12:06:02  <TheSheep> you are right
2008-10-12T12:06:35  * TheSheep rollbacks
2008-10-12T12:07:01  <TheSheep> hmm... now how do I "push" that rollback?
2008-10-12T12:07:22  <ThomasWaldmann> you can't
2008-10-12T12:07:46  <ThomasWaldmann> either I rollback it on the server (hoping nobody pulled it already)
2008-10-12T12:08:01  <ThomasWaldmann> or you commit a reverse changeset
2008-10-12T12:08:22  <TheSheep> I'm sorry, I should have looked through the changes
2008-10-12T12:09:53  <ThomasWaldmann> I am also sorry (you told you wanna do it today), but I couldn't resist kicking diff out and deprecating ParserBase
2008-10-12T12:21:55  <CIA-26> Radomir Dopieralski <moindev@sheep.art.pl> default * 4388:5a43d52e2110 1.9/MoinMoin/parser/highlight.py: parser/highlight.py: rollback the duplicated css classes for diff
2008-10-12T18:49:28  <ThomasWaldmann>  re
2008-10-12T20:24:55  <dreimark> re