MoinMoin: MoinMoinChat/Logs/moin-dev/2008-10-08

2008-10-08T10:10:01  <dreimark> moin
2008-10-08T16:26:19  <PawelPacana> moin
2008-10-08T16:27:07  <TheSheep> hello PawelPacana :)
2008-10-08T16:27:21  <TheSheep> PawelPacana: did you settle down finally?
2008-10-08T16:27:39  <PawelPacana> not yet
2008-10-08T16:27:43  <PawelPacana> few boxes left
2008-10-08T16:28:05  <PawelPacana> but generaly speaking: yes
2008-10-08T16:28:28  <TheSheep> great
2008-10-08T16:28:30  <PawelPacana> time to dig the irc logs
2008-10-08T16:28:48  <dreimark> hi PawelPacana
2008-10-08T16:28:56  <PawelPacana> hi dreimark
2008-10-08T16:31:55  <PawelPacana> are there parts of moin code which need some refactoring / covering with unit tests  other than 'attachfile'?
2008-10-08T16:33:36  <PawelPacana> i'm obliged for one of my university courses to do such refactoring for chosen open source project
2008-10-08T16:34:14  <PawelPacana> so i thought it could fit into nearest moin plans
2008-10-08T16:49:57  <ThomasWaldmann> hi pawel
2008-10-08T16:50:56  <ThomasWaldmann> PawelPacana: attachfile will die sooner or later, but in general, we need more tests
2008-10-08T16:52:42  <ThomasWaldmann> if you want to work on the current state of attachfile, you could do 2 things:
2008-10-08T16:53:19  <ThomasWaldmann> a) either work on the moin/1.9 code (contains WSGI work of zenhase) and just write tests for the status quo
2008-10-08T16:54:23  <ThomasWaldmann> b) work on it in the storage refactoring branch. attachfile was modified there to use the storage backend, dennda knows more.
2008-10-08T16:55:44  <ThomasWaldmann> one small/medium sizes nice refactoring would be to move to attachment name into PATH_INFO
2008-10-08T16:56:17  <ThomasWaldmann> (needs some digging in crap code :)
2008-10-08T16:56:52  <ThomasWaldmann> goal of all this, mid term is that AttachFile will die completely and item handlers will do all that stuff
2008-10-08T16:57:39  <ThomasWaldmann> but as no UI for this stuff exists yet, that would be a bigger project
2008-10-08T17:00:34  <ThomasWaldmann> PawelPacana: btw, greetings to that professor that had the idea of working on OSS projects :)
2008-10-08T17:00:47  <ThomasWaldmann> s/that/who/
2008-10-08T17:08:26  <PawelPacana> ThomasWaldmann: ok, so i'll explore this options further
2008-10-08T17:08:45  <dreimark> cool
2008-10-08T17:10:37  <dreimark> PawelPacana: is it common that courses are done on OS projects?
2008-10-08T17:12:04  <PawelPacana> no
2008-10-08T17:12:30  <PawelPacana> however this professor is active OSS user
2008-10-08T17:12:51  <PawelPacana> regularly submits tracks for open gps maps of Poland
2008-10-08T17:13:13  <PawelPacana> and is the owner of polish usenet hierarchy
2008-10-08T17:17:14  <ThomasWaldmann> cool :) tell him that OSS projects appreciate this kind of projects (and I hope the students also rather like to do something that makes sense than to write throw-away code just for doing the excercise)
2008-10-08T17:20:53  <ThomasWaldmann> PawelPacana: how long do you have for that project?
2008-10-08T17:21:47  <PawelPacana> until the end of the year
2008-10-08T17:21:56  <PawelPacana> calendar year
2008-10-08T17:22:10  <PawelPacana> so, about two months
2008-10-08T17:22:11  <ThomasWaldmann> another thing could be the ACL code. it needs to be refactored to the storage api.
2008-10-08T17:23:29  <ThomasWaldmann> and good tests are very important at that place
2008-10-08T17:24:55  <ThomasWaldmann> PawelPacana: ^^
2008-10-08T17:25:33  <ThomasWaldmann> (btw, without ACL code, we can't merge storage into main)
2008-10-08T17:25:42  * dreimark has to go to pycologne 
2008-10-08T17:25:45  <PawelPacana> so it is even more important
2008-10-08T17:25:51  <dreimark> bbl or tom.
2008-10-08T17:25:57  <dreimark> depends on DSL at home
2008-10-08T17:26:50  <ThomasWaldmann> PawelPacana: maybe do some quick test with attachments in storage branch. iirc they work more or less, so we maybe could live with that for merging.
2008-10-08T17:27:31  <ThomasWaldmann> but no ACLs or wrong working ACLs are a blocker.
2008-10-08T17:28:25  <ThomasWaldmann> btw, in case you get bored in the last weeks of that project, there is also http://moinmo.in/FeatureRequests/AclRefactoring
2008-10-08T17:33:48  <ThomasWaldmann> PawelPacana:
2008-10-08T17:33:54  <ThomasWaldmann> http://hg.moinmo.in/moin/1.8-storage/file/tip/MoinMoin/storage/backends/acl.py
2008-10-08T17:34:03  <ThomasWaldmann> TODO: needs more work, does not work yet
2008-10-08T17:38:50  <PawelPacana> ok, just let me think about it later