2008-07-26T00:10:26 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4044:70d8c7dabfad 1.8-dom-bblank/MoinMoin/converter2/include.py: Include converter - Warn on include cycle, check permissions
2008-07-26T00:16:04 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4045:27d2abbae659 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Implement sysmsg
2008-07-26T00:27:36 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4046:3157ab475e39 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Implement transclusion
2008-07-26T01:00:37 <waldi> one way to kill the server: <<Include(^)>>
2008-07-26T01:02:05 <ThomasWaldmann> hehe
2008-07-26T01:03:40 <waldi> macro converter finished, next step ...
2008-07-26T01:04:08 <waldi> uh, not yet
2008-07-26T01:04:57 <waldi> hmm, does the unmodified version survive this test?
2008-07-26T01:11:11 <ThomasWaldmann> list index out of range
2008-07-26T01:11:25 <waldi> hihi
2008-07-26T01:11:40 <waldi> 12 cpu minutes and still not finished with macros
2008-07-26T01:14:54 <waldi> i think it should limit the actual number of includes to 20-50
2008-07-26T01:18:12 <waldi> ThomasWaldmann: i get many "pagelinks formatter failed, traceback follows" during the run
2008-07-26T01:23:35 <waldi> canceled, lets try again without macros
2008-07-26T01:25:57 * ThomasWaldmann .sleep()
2008-07-26T01:36:04 <waldi> okay, another bug in the moin parser
2008-07-26T01:54:54 <waldi> -rw-r----- 1 bastian bastian 12063219 26. Jul 01:50 Test5
2008-07-26T01:55:03 <waldi> a page including anything :
2008-07-26T10:26:28 <dreimark> moin
2008-07-26T10:26:48 <dreimark> waldi: <<RandomQuote(WikiTipOfTheDay2)>> shows nothing
2008-07-26T10:27:15 <dreimark> ||<tablestyle="width: 99%; background: #E6EAF0; font-size: 0.85em;"> <<RandomQuote(WikiTipOfTheDay)>>||
2008-07-26T10:27:39 <dreimark> on RC hows only the border of the table
2008-07-26T10:27:50 <dreimark> +s
2008-07-26T10:31:29 <dreimark> using the Verbatim macro gives a traceback
2008-07-26T10:31:32 <dreimark> http://moinmo.in/BastianBlank/TreeOutputFormatter?action=AttachFile&do=view&target=traceback.html
2008-07-26T10:36:02 <dreimark> <<InterWiki>>
2008-07-26T10:36:08 <dreimark> shows http://moinmo.in/BastianBlank/TreeOutputFormatter?action=AttachFile&do=get&target=interwiki_traceback.html
2008-07-26T10:40:31 <dreimark> MonthCalendar shows an other one http://localhost:8080/HelpOnMacros/MonthCalendar
2008-07-26T10:41:21 <dreimark> bbl
2008-07-26T11:49:18 <waldi> "Keine Zitate auf Seite WikiTipOfTheDay2 gefunden."
2008-07-26T12:15:44 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4047:8dc2ce5df4fe 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Fix transclusion, never drop the bottom element, don't choke on empty parser sections
2008-07-26T12:15:44 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4048:82610726ad48 1.8-dom-bblank/MoinMoin/converter2/macro.py: Macro converter - Catch AssertionError from compatibility formatter and fallback
2008-07-26T12:15:45 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4049:c85406eb7772 1.8-dom-bblank/MoinMoin/ (Page.py formatter/text_html.py request/__init__.py): Page, HTML formatter, request - Remove old section numbers code
2008-07-26T12:15:46 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4050:2e25522d41bd 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Fix list type, fix escaped text
2008-07-26T12:15:49 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4051:c73eb3c3c55c 1.8-dom-bblank/MoinMoin/converter2/macro.py: Macro converter - Produce error on macros which uses request.write
2008-07-26T12:15:52 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4052:c790e1d65253 1.8-dom-bblank/MoinMoin/converter2/macro.py: Macro converter - Write warning if a macro uses request.write
2008-07-26T12:31:02 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4053:6e561688ece3 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Bail out if definition lists are not correct
2008-07-26T12:31:03 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4054:4c856e5d71f8 1.8-dom-bblank/MoinMoin/macro/InterWiki.py: InterWiki old-style macro - Fix list item close formatter call
2008-07-26T12:37:55 <gizmach> moin got opportunity to push code
2008-07-26T12:38:02 <gizmach> done changes for the simplifying
2008-07-26T12:38:24 <gizmach> need to fix some small things but tests passed and I changed that
2008-07-26T12:38:29 <gizmach> tried with wiki
2008-07-26T12:38:46 <gizmach> and need to change only userform, that does not work properly
2008-07-26T12:38:51 <gizmach> yet
2008-07-26T12:39:08 <gizmach> will com on irc at evening or afternoon again
2008-07-26T12:39:32 <ThomasWaldmann> gizmach: you didnt push
2008-07-26T12:39:34 <CIA-53> MelitaMihaljevic default * 3967:f60af3adf560 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/group_ldap.py: removed comments
2008-07-26T12:39:36 <CIA-53> MelitaMihaljevic default * 3968:78e2a395a904 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/_tests/ (test_groupconfig.py test_groupldap.py): fixed comments in tests
2008-07-26T12:39:37 <CIA-53> MelitaMihaljevic default * 3969:47da43fa8abf 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/_tests/test_groupldap.py: changed attr name from lo to ldap_conn
2008-07-26T12:39:38 <CIA-53> MelitaMihaljevic default * 3970:8ab7c77a8279 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/ (_tests/test_groupldap.py group_ldap.py): gave ldap_conn as first ldap related argument
2008-07-26T12:39:39 <CIA-53> MelitaMihaljevic default * 3971:f943853a45cc 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/ (group_config.py group_ldap.py group_wiki.py): removed ManagerFatory (simplifying code)
2008-07-26T12:39:40 <gizmach> ThomasWaldmann: doing that
2008-07-26T12:39:42 <CIA-53> MelitaMihaljevic default * 3972:159a09f603fa 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/__init__.py: removed GroupManagerFactory class from datastruct code (simplifying)
2008-07-26T12:39:45 <CIA-53> MelitaMihaljevic default * 3973:a03055516d97 1.8-ldapgroups-mmihaljevic/MoinMoin/config/multiconfig.py: fixed group* default option - to work with siplified group backend code
2008-07-26T12:39:48 <CIA-53> MelitaMihaljevic default * 3974:f61780d468ff 1.8-ldapgroups-mmihaljevic/MoinMoin/request/__init__.py: removed unused code
2008-07-26T12:39:55 <CIA-53> MelitaMihaljevic default * 3975:6dd1d5f93aec 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/__init__.py: changed GroupManager - uses simplified code
2008-07-26T12:39:58 <CIA-53> MelitaMihaljevic default * 3976:45860596e7ec 1.8-ldapgroups-mmihaljevic/MoinMoin/security/__init__.py: changed acl code to use simplified group manager call
2008-07-26T12:40:01 <CIA-53> MelitaMihaljevic default * 3977:4f856785dc03 1.8-ldapgroups-mmihaljevic/MoinMoin/userform/admin.py: changed code to use siplified group backend code
2008-07-26T12:40:04 <CIA-53> MelitaMihaljevic default * 3978:a147fc3b35ef 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/backend/_tests/ (4 files): fixed tests to use simplified code
2008-07-26T12:40:07 <CIA-53> MelitaMihaljevic default * 3979:7fb0ed212525 1.8-ldapgroups-mmihaljevic/wiki/config/more_samples/config_backend_wikiconfig_snippet: fixed group config snippet
2008-07-26T12:40:10 <CIA-53> MelitaMihaljevic default * 3980:715a6da96233 1.8-ldapgroups-mmihaljevic/wiki/config/more_samples/wiki_backend_wikiconfig_snippet: fixed wiki backend snippet
2008-07-26T12:40:11 <dreimark> re
2008-07-26T12:40:14 <ThomasWaldmann> ah, now it comes
2008-07-26T12:40:32 <dreimark> waldi: I was nut sure if I have to use #format creole
2008-07-26T12:40:40 <dreimark> so i copied that page
2008-07-26T12:40:48 <gizmach> :)
2008-07-26T12:40:51 <CIA-53> MelitaMihaljevic default * 3981:ce0afd107c3d 1.8-ldapgroups-mmihaljevic/wiki/config/more_samples/multi_backend_wikiconfig_snippet: fixed multiconfig backend snippet
2008-07-26T12:40:56 <dreimark> (and found the rename bug because of a typo)
2008-07-26T12:41:03 <gizmach> ok thats almostly all :) I hope
2008-07-26T12:41:10 <gizmach> yes it's all
2008-07-26T12:41:22 <gizmach> bbl at afternoon/evening
2008-07-26T12:41:31 <gizmach> gtg have a nice day
2008-07-26T12:42:16 <dreimark> hi gizmach
2008-07-26T12:42:36 <gizmach> dreimark: hi any bye, sorry got opportunity to psuh code
2008-07-26T12:42:44 <gizmach> push*
2008-07-26T12:42:45 <gizmach> bbly
2008-07-26T12:42:47 <gizmach> bye
2008-07-26T12:43:45 <ThomasWaldmann> dreimark: we don't need X snippets for groups, 1 commented one showing the different methods is enough
2008-07-26T12:45:11 <dreimark> yes one file with comments and not x snippets
2008-07-26T12:46:07 <ThomasWaldmann> - self.request.group_manager = self.request.cfg.group_manager.create_group_manager(self.request)
2008-07-26T12:46:10 <ThomasWaldmann> + self.request.group_manager = self.request.cfg.group_manager_factory
2008-07-26T12:46:17 <ThomasWaldmann> obviously wrong
2008-07-26T12:46:22 <dreimark> group_manager_factory
2008-07-26T12:46:37 <dreimark> the naming schmee has to be changed
2008-07-26T12:46:59 <dreimark> group_manager_factory = lambda request: d....
2008-07-26T12:48:54 <ThomasWaldmann> she systematically did that wrong change without thinking :|
2008-07-26T12:49:28 <ThomasWaldmann> http://hg.moinmo.in/moin/1.8-ldapgroups-mmihaljevic/rev/a147fc3b35ef
2008-07-26T12:50:52 * ThomasWaldmann begins to get annoyed by her constant misleading choice of names although she was told 10 times at least
2008-07-26T12:51:32 * dreimark too and I have no clue yet how we can improve the selction process for the next soc students
2008-07-26T12:51:55 <dreimark> without making it boring for all
2008-07-26T12:52:02 <ThomasWaldmann> also, request still is not the first param
2008-07-26T12:53:18 <dreimark> + and annoying
2008-07-26T12:53:40 <ThomasWaldmann> - ('manager', datastruct.GroupManagerFactory([]), 'instancing an empty GroupManagerFactory object' ),
2008-07-26T12:53:43 <ThomasWaldmann> + ('manager_factory', datastruct.GroupManager([],None), 'instancing an empty GroupManagerFactory object' ),
2008-07-26T12:53:55 <ThomasWaldmann> wrong default
2008-07-26T12:55:58 <xorAxAx> dreimark: well, wesnoth was comparably strict and requested a patch for a bugfix or feature request from every student
2008-07-26T12:56:31 <xorAxAx> and nevertheless they ended up with a lot of applications. i think we could just suggest that somebody could do that to get a better chance, but not require them to do so
2008-07-26T12:56:50 <dreimark> I think that's a good idea
2008-07-26T12:59:04 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4055:0d86c2eb30d0 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Preserve table attributes
2008-07-26T12:59:05 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4056:2aba4c7a7e8b 1.8-dom-bblank/MoinMoin/converter2/html_out.py: HTML output formatter - Add new style attributes, convert attributes for table
2008-07-26T12:59:18 <ThomasWaldmann> she removed GM init from request.__init__!?
2008-07-26T13:01:16 <ThomasWaldmann> http://hg.moinmo.in/moin/1.8-ldapgroups-mmihaljevic/rev/f61780d468ff
2008-07-26T13:04:56 <dreimark> she had written tests which should help to find bugs from refactoring. obviously she didn't call them
2008-07-26T13:06:38 * ThomasWaldmann runs tests before pulling (and then afterwards)
2008-07-26T13:07:19 <dreimark> ok I did today only afterwards
2008-07-26T13:08:37 <dreimark> fun the tests showed only PEP8 failures
2008-07-26T13:10:16 <waldi> okay, MonthCalender also falls over the xhtml/html problem
2008-07-26T13:13:18 <dreimark> the tests of melita don't cover the refactoring
2008-07-26T13:13:29 <dreimark> http://localhost:8080/SystemAdmin?sysadm=users crashes
2008-07-26T13:13:37 <waldi> ThomasWaldmann: how should footnotes in included pages behave?
2008-07-26T13:13:50 <ThomasWaldmann> dreimark: yes. (she can't do much about the test framework limitations, though)
2008-07-26T13:14:42 <ThomasWaldmann> waldi: i think by default they should show at same position as on included page
2008-07-26T13:16:19 <ThomasWaldmann> dreimark: what do you think of putting a TODO directly into her repo (and also some in-source markers/todos)?
2008-07-26T13:17:43 <xorAxAx> waldi: hehe, monthcalendar has a long history of failure :)
2008-07-26T13:18:01 <xorAxAx> for a long time, it had been abusing moins apis a bit when constructing urls
2008-07-26T13:18:27 <waldi> xorAxAx: it produces <script src="bla" />
2008-07-26T13:19:01 <ThomasWaldmann> btw, I am doing some MC changes currenlty, so maybe don't create conflicts
2008-07-26T13:19:05 <xorAxAx> waldi: thats incorrect?
2008-07-26T13:19:15 <waldi> xorAxAx: for xml its correct, for html not
2008-07-26T13:19:36 <dreimark> ThomasWaldmann: I am not sure if this will help her
2008-07-26T13:19:44 <xorAxAx> waldi: umm, are legacy thingies expect to generate html?
2008-07-26T13:20:08 <waldi> its the xml serializer
2008-07-26T13:20:29 <xorAxAx> but the xml serializer is not prat of the macro, i dont understand the issue currently
2008-07-26T13:20:59 <waldi> the legacy macros may return html. this html is pushed through a html parser and then serialized as xml
2008-07-26T13:21:23 <xorAxAx> yeah, so MC doesnt use rawhtml properly?
2008-07-26T13:21:31 <waldi> yes, it does
2008-07-26T13:21:43 <xorAxAx> regarding the api ... have you thought about some ET wrapper? thats horribly boilerplatish -- http://hg.moinmo.in/moin/1.8-dom-bblank/file/2aba4c7a7e8b/MoinMoin/macro2/GoTo.py
2008-07-26T13:21:54 <ThomasWaldmann> dreimark: better ideas? obviously discussing that stuff on IRC does not have enough effect.
2008-07-26T13:21:55 <waldi> xorAxAx: ET.XML works
2008-07-26T13:22:33 <waldi> GoTo was completely handcoded
2008-07-26T13:22:40 <xorAxAx> as opposed to?
2008-07-26T13:22:45 <ThomasWaldmann> waldi: then please use it / show how it works :)
2008-07-26T13:23:32 <xorAxAx> yeah, probably MC is a good example :)
2008-07-26T13:23:53 <xorAxAx> ThomasWaldmann: if you are not working on his branch, he needs to port it anyway so conflicts cant be resolved by blocking him
2008-07-26T13:24:46 <xorAxAx> (he would just look at your changes because the new MC will be a partly rewrite probably)
2008-07-26T13:24:46 <ThomasWaldmann> ?
2008-07-26T13:24:54 <xorAxAx> you said he shouldnt work on MC
2008-07-26T13:24:56 <dreimark> ThomasWaldmann: no but it also doesn't helped her to write herself own comments for each line on supplied code
2008-07-26T13:25:25 <ThomasWaldmann> if i do changes there and he also does changes, he has to merged my changes, possibly with conflicts
2008-07-26T13:25:40 <ThomasWaldmann> if he merges my changes before doing own changes there, there is no conflict
2008-07-26T13:26:07 <xorAxAx> ThomasWaldmann: i was suggesting to port it to the new api
2008-07-26T13:26:11 <xorAxAx> as a non-trivial example
2008-07-26T13:26:21 <xorAxAx> and in that case, automatic merging doesnt work :)
2008-07-26T13:26:38 <dreimark> and she didn't tried to write a documentation which will help to get a deeper understanding
2008-07-26T13:26:39 <ThomasWaldmann> what i tell still holds true for that case
2008-07-26T13:26:56 <xorAxAx> a bit at least, yes
2008-07-26T13:27:40 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4057:ef81afaa1963 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Add col element to ignore end, readd id handling
2008-07-26T13:27:41 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4058:c114fd7182e0 1.8-dom-bblank/MoinMoin/macro2/GoTo.py: GoTo macro - Use ElementTree.XML
2008-07-26T13:27:42 <CIA-53> Bastian Blank <bblank@thinkmo.de> default * 4059:3f6666e0d685 1.8-dom-bblank/MoinMoin/formatter/compatibility.py: Compatibility formatter - Remove debugging code
2008-07-26T13:27:50 <waldi> ThomasWaldmann, xorAxAx: done
2008-07-26T13:28:34 <xorAxAx> hmm
2008-07-26T13:28:52 <xorAxAx> now the next natural step would be to refactor the large string into a separate file
2008-07-26T13:28:56 <xorAxAx> for various reasons
2008-07-26T13:30:29 <xorAxAx> but that can be done later as well
2008-07-26T13:30:44 <xorAxAx> (its usually much nicer to edit xml in a separate file because of better workflow and editor support)
2008-07-26T13:30:56 <dreimark> bbl
2008-07-26T13:31:05 <xorAxAx> hmm, i wonder how a macro would look like that didnt need rawhtml in the old version
2008-07-26T13:31:49 <xorAxAx> waldi: can you probably port something aalong the lines of pagelist or pagehits?
2008-07-26T13:46:02 <xorAxAx> waldi: what do you think?
2008-07-26T14:04:37 <gizmach> moin
2008-07-26T14:05:35 <waldi> xorAxAx: should work, but i'm away now
2008-07-26T14:21:17 <dreimark> re
2008-07-26T14:21:43 <dreimark> hi gizmach do you use your local wiki instance of your repo
2008-07-26T14:21:50 <dreimark> to wite some stuff?
2008-07-26T14:22:23 <dreimark> s/wite/write/
2008-07-26T14:24:19 * dreimark is not amused about your last commits
2008-07-26T14:25:05 <xorAxAx> hehe
2008-07-26T14:29:05 <dreimark> gizmach: we try to avoid committing b0rked code. A change in a repo should not lead into everything or partially something is broken
2008-07-26T14:29:59 <gizmach> dreimark: I only write wikiconfig_local and try with it on my local wiki
2008-07-26T14:30:44 <dreimark> do you have useres with different pagegroups and and different rights on pages created ?
2008-07-26T14:31:11 <gizmach> dreimark: yes
2008-07-26T14:31:17 <dreimark> and does RC work?
2008-07-26T14:32:02 <gizmach> I tested only for some, will do more tests a bit later and I know that userform does not work
2008-07-26T14:32:02 <dreimark> or http://localhost:8080/SystemAdmin?sysadm=users
2008-07-26T14:32:28 <gizmach> dreimark: that does not work, I've written before that this does not wirk
2008-07-26T14:33:23 <dreimark> it will never work this way
2008-07-26T14:34:32 <gizmach> hm...
2008-07-26T14:36:13 <dreimark> 12:43 and following lines
2008-07-26T14:37:38 <gizmach> dreimark: ok
2008-07-26T14:42:45 <dreimark> gizmach: it looks like you ignore issues we have already many times repeated
2008-07-26T14:47:59 <gizmach> dreimark: I done some things witouth thinkig, but I'm not sure why this won't eokr
2008-07-26T14:48:03 <gizmach> self.request.group_manager = self.request.cfg.group_manager_factory
2008-07-26T14:56:32 <ThomasWaldmann> gizmach: try to not do unusual things in your tests. e.g. don't create the TestConfig in another way as you would configure in wikiconfig
2008-07-26T14:59:09 <gizmach> ThomasWaldmann: oh ok
2008-07-26T15:08:16 * dennda is desperately installing eclipse and pydev
2008-07-26T15:16:04 <dennda> ThomasWaldmann: Now imagine I want to manually step through all steps involved in rendering a page, starting with a request. How would I do that?
2008-07-26T15:23:29 <ThomasWaldmann> dennda: set a breakpoint and run wikiserver.py with eclipse/pydev debugger
2008-07-26T15:23:55 <dennda> Where would I set that breakpoint ideally?
2008-07-26T15:24:14 <ThomasWaldmann> request.__init__
2008-07-26T15:24:20 <dennda> thanks
2008-07-26T15:24:24 <dennda> I will try that
2008-07-26T15:24:40 <dennda> And then I must open that page in my browser I suppose? :)
2008-07-26T15:24:46 <dennda> to trigger the server functionality
2008-07-26T15:25:01 <ThomasWaldmann> (maybe also at beginning of send_page if you have seen that once :)
2008-07-26T15:25:05 <ThomasWaldmann> yes
2008-07-26T15:38:41 <dennda> ThomasWaldmann: Isn't it supposed to stop and drop me into debug mode as soon as it reaches the breakpoint?
2008-07-26T15:39:08 <johill> you still haven't created a web page with your questions, have you?
2008-07-26T15:40:19 <dennda> ah ok now
2008-07-26T15:40:25 <dennda> No I havn't
2008-07-26T15:40:33 <dennda> If this doesn't work too, I will
2008-07-26T15:41:04 <johill> s/too/either/
2008-07-26T15:41:05 <johill> ;)
2008-07-26T15:41:12 <dennda> yeah
2008-07-26T15:41:14 <johill> I'm in Canada right now :P
2008-07-26T15:41:24 * dennda reconfigures his grammar checker
2008-07-26T15:41:32 * johill leaves for talks
2008-07-26T15:41:35 <dennda> well, that's old news, isn't it?
2008-07-26T15:43:23 <xorAxAx> therefore olds
2008-07-26T15:46:29 <ThomasWaldmann> dennda: yes, it is
2008-07-26T15:46:42 <dennda> ThomasWaldmann: Works now
2008-07-26T15:46:48 <dennda> trying to get used to it
2008-07-26T15:48:50 <dennda> hmpf, crashed
2008-07-26T15:49:15 <dreimark> dennda: use sun's java
2008-07-26T15:52:06 <dennda> I do (I think)
2008-07-26T15:52:14 <dennda> not that gcj garbage
2008-07-26T15:59:38 <dennda> "An internal error occurred during: "Launching""
2008-07-26T15:59:47 <dennda> very helpful message
2008-07-26T16:01:18 <dreimark> brb 1h
2008-07-26T16:01:46 <dreimark> no still here
2008-07-26T16:03:16 <ThomasWaldmann> dennda: runs flawlessly here
2008-07-26T16:03:42 <ThomasWaldmann> except moin process termination from the debugger (kill -9 helps :)
2008-07-26T16:04:53 <ThomasWaldmann> eclipse from eclipse.org, put into home dir. latest pydev stuff from the pydev site. sun-java6-jre from ubuntu.
2008-07-26T16:05:11 <dennda> hm ok it obviously runs with gcj
2008-07-26T16:05:19 * dennda checks how to change that
2008-07-26T16:14:04 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3982:a47de31738c7 1.8-ldapgroups-mmihaljevic/MoinMoin/datastruct/ (9 files in 3 dirs): (log message trimmed)
2008-07-26T16:14:04 <CIA-53> TODO for the current code base added:
2008-07-26T16:14:04 <CIA-53> see code hints to be fixed:
2008-07-26T16:14:04 <CIA-53> **SP = check SPelling / grammar
2008-07-26T16:14:05 <CIA-53> **NA = sane NAme required
2008-07-26T16:14:07 <CIA-53> **FO = check FOrmatting
2008-07-26T16:14:09 <CIA-53> **WR = WRong
2008-07-26T16:15:56 <dreimark> bbl
2008-07-26T16:19:25 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3777:4431145e4994 1.7/MoinMoin/macro/MonthCalendar.py: MonthCalendar macro: fix height6,anniversary,template params parsing / url generation
2008-07-26T16:38:05 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2670:836b64b84dda 1.6/MoinMoin/macro/MonthCalendar.py: MonthCalendar macro: fix height6,anniversary,template params parsing / url generation (backport from 1.7)
2008-07-26T17:55:18 * ThomasWaldmann looks for backports to do for 1.6.4
2008-07-26T19:14:31 <dennda> sheesh
2008-07-26T19:14:45 <dennda> eclipse is just too buggy here.. crashes on startup. even with sun-java6
2008-07-26T19:27:50 <ThomasWaldmann> ubuntu eclipse or eclipse eclipse? :)
2008-07-26T19:28:34 <ThomasWaldmann> and which version?
2008-07-26T19:28:38 <ThomasWaldmann> dennda:
2008-07-26T19:30:47 <dennda> ubuntu eclipse
2008-07-26T19:30:48 <dennda> 3.2
2008-07-26T19:30:55 <dennda> trying my arch version now
2008-07-26T19:33:35 <ThomasWaldmann> i am using 3.2 from e.o, no problems
2008-07-26T19:34:01 <ThomasWaldmann> and i also installed 3.4 from e.o recently, not used it much yet, but also no problems yet
2008-07-26T19:34:02 <dennda> Havn't had these issues before myself
2008-07-26T19:34:16 <dennda> (when I was tortured with java)
2008-07-26T19:34:27 <dennda> 3.4 already out? wow
2008-07-26T19:45:03 <ThomasWaldmann> duck!
2008-07-26T19:45:17 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2671:2237e1ba5bbd 1.6/MoinMoin/request/request_modpython.py: request_modpython: doing dirty tricks to work around mod_python 3.3.1 problems
2008-07-26T19:45:17 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2672:b57ee5eba2f1 1.6/MoinMoin/request/__init__.py: surge protection: exclude localnet no matter whether user is known or not (backport from 1.7)
2008-07-26T19:45:19 <CIA-53> Reimar Bauer <rb.proj AT googlemail DOT com> default * 2673:b7493d629ed8 1.6/MoinMoin/ (action/SyncPages.py xmlrpc/__init__.py): SyncPages, xmlrpc.process: bug fix for WikiSyncMissingInterWikiNameOnRemoteSide (thanks to Alexander Schremmer)
2008-07-26T19:45:20 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2674:f95d31f6f0bd 1.6/MoinMoin/PageEditor.py:
2008-07-26T19:45:22 <CIA-53> revert 384135a7bb0a ("PageEditor.renamePage: bugfix added missing comment var", backport from 1.7)
2008-07-26T19:45:24 <CIA-53> The comment isn't really missing, it may be empty if the user didn't provide
2008-07-26T19:45:26 <CIA-53> one and in that case if you want to know what it was renamed from you have
2008-07-26T19:45:28 <CIA-53> to look at the 'extra' field in the edit log, RecentChanges does that and
2008-07-26T19:45:30 <CIA-53> displays "#01 Renamed from 'test'." or similar.
2008-07-26T19:45:32 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2675:6dabab22fc9c 1.6/MoinMoin/PageEditor.py: fix tests failing due to rename by making the comment default u'' rather than None (backport from 1.7)
2008-07-26T19:45:37 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2676:a919cfc16263 1.6/MoinMoin/wikidicts.py: wikidicts: simplify regex compiling (backport from 1.7)
2008-07-26T19:45:40 <CIA-53> Johannes Berg <johannes AT sipsolutions DOT net> default * 2677:3ed1f4b6d579 1.6/MoinMoin/action/MyPages.py: fix MyPages action
2008-07-26T19:45:43 <CIA-53> Johannes Berg <johannes AT sipsolutions DOT net> default * 2678:c2fcd4b6b965 1.6/MoinMoin/action/MyPages.py: fix MyPage action link markup
2008-07-26T19:45:48 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2679:6097547295e7 1.6/MoinMoin/config/multiconfig.py: add MyPages and CopyPage to actions_excluded because first doesn't work without special SecurityPolicy anyway and second has questionable behaviour
2008-07-26T19:48:01 <gizmach> moin
2008-07-26T19:48:38 <gizmach> dreimark: thank you for TODO
2008-07-26T19:53:35 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2680:8de1cba39de6 1.6/MoinMoin/macro/MonthCalendar.py: MonthCalendar macro: fix MoinMoinBugs/MonthCalendarBreaksOnApostrophe
2008-07-26T19:55:45 <dennda> sigh...
2008-07-26T19:56:59 <dennda> It once failed to terminate wikiserver.py correctly and now keeps claiming the adress is in use. Restarting eclipse didn't work. lsof | grep 8080 doesn't report anything either. Nor does htop...
2008-07-26T19:59:02 <gizmach> lsof -i :8080
2008-07-26T19:59:05 <gizmach> dennda:
2008-07-26T20:01:09 <dennda> gizmach: Thanks, that reports the problem. But killing the id doesn't work for some reason
2008-07-26T20:01:45 <gizmach> kill -9
2008-07-26T20:01:54 <gizmach> that works probably
2008-07-26T20:02:00 <dennda> yeah
2008-07-26T20:02:04 <dennda> heh, you hacker :)
2008-07-26T20:02:14 <gizmach> I had same problems :)
2008-07-26T20:02:21 <dennda> I see
2008-07-26T20:02:53 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2681:873bdd17c1dc 1.6/MoinMoin/search/queryparser.py: xapian_stemming: removed some strange code (fixes search title:lowercaseword with xapian_stemming enabled)
2008-07-26T20:20:27 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2682:06e7e2a34967 1.6/MoinMoin/search/builtin.py: xapian search results: remove strange statement disabling moin's weighting, fixes result list ordering
2008-07-26T20:20:28 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2683:056f5bc5d11d 1.6/MoinMoin/search/builtin.py: xapian search: clean up some code, add i18n for 'about'
2008-07-26T20:20:29 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2684:2770117c39e5 1.6/MoinMoin/search/Xapian.py: Xapian indexing: remove crappy hostname tokenization, works better without (backport from 1.7)
2008-07-26T20:20:31 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2685:37de3afca6e8 1.6/MoinMoin/search/Xapian.py: Xapian indexer/tokenizer: tokenize CamelCase parts of non-wikiwords
2008-07-26T20:28:12 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2686:f4d93a82c970 1.6/MoinMoin/search/ (Xapian.py queryparser.py): category search: ignore traling whitespace after ----
2008-07-26T21:26:33 <CIA-53> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2687:bd6798b7630c 1.6/docs/CHANGES: updated CHANGES
2008-07-26T21:28:44 <dennda> Once it works, that debugger is cool. Hopefully it helps me find the issue :)
2008-07-26T21:30:37 <ThomasWaldmann> did you find out why it made troubles?
2008-07-26T21:39:13 <dennda> Not yet
2008-07-26T21:39:19 <dennda> (eclipse or moin?)
2008-07-26T21:47:08 <ThomasWaldmann> both :)
2008-07-26T21:49:42 <dennda> Neither
2008-07-26T21:49:53 <dennda> I think I will have to create a wiki page :(
2008-07-26T22:19:53 * ThomasWaldmann deployed 1.6.current to some wikis. lets see if there will be complaints.
2008-07-26T22:21:52 <dennda> When saving a simple page with just a few characters, I would expect no "attachment"-operations to be involved at all. Is that correct?
2008-07-26T22:22:06 <ThomasWaldmann> maybe not
2008-07-26T22:23:45 <dennda> why?
2008-07-26T22:26:37 <dennda> oh wow, that debugger gave me a hint at last :)
2008-07-26T22:26:39 <dennda> examining...
2008-07-26T22:50:18 <dennda> puh..
2008-07-26T23:02:09 <xorAxAx> dennda: rendering a page might enumerate all attachments
2008-07-26T23:04:35 <dennda> Yeah it somehow looped over all files in my /tmp directory
2008-07-26T23:04:56 <dennda> But I give up now, too difficult to get the whole process at once. /me writes a wikipage
2008-07-26T23:05:33 <xorAxAx> well, looping over /tmp doesnt sound like it the bug is spread all over moin but at a single place
2008-07-26T23:06:07 <xorAxAx> dennda: do you know which places enumerate all files of /tmp?
2008-07-26T23:06:18 <dennda> you mean which places in the code?
2008-07-26T23:06:21 <xorAxAx> yes
2008-07-26T23:06:35 <dennda> just a sec, I set a bookmark in eclipse. I hope it's still there if I restart eclipse
2008-07-26T23:06:38 <xorAxAx> i mean, in the storage code that you already saw
2008-07-26T23:06:44 <xorAxAx> why do you restart it?
2008-07-26T23:07:19 <xorAxAx> (i usually needed to when the memory was badly fragmented)
2008-07-26T23:08:58 <dennda> no worries, the seem to be still there
2008-07-26T23:09:02 <dennda> just found one
2008-07-26T23:09:16 <xorAxAx> ah ,you had it closed
2008-07-26T23:09:52 <dennda> but eclipse doesn't offer a mechanism to go through all bookmarks, nor wants to show the useful text I wrote to help me memorize what that piece of code did
2008-07-26T23:09:55 <dennda> yeah
2008-07-26T23:10:17 <xorAxAx> it can show all bookmarks in a bookmark view probably
2008-07-26T23:11:00 <dennda> yeah, just discovered that
2008-07-26T23:11:06 <dennda> I don't use eclipse that often
2008-07-26T23:11:33 <dennda> AttachFile.py, line 388
2008-07-26T23:11:44 <dennda> send_link_rel, that is
2008-07-26T23:12:51 <xorAxAx> yes, thats used for rendering
2008-07-26T23:13:04 <xorAxAx> now whats unclear (i.e. what will be on the wiki page?) :)
2008-07-26T23:13:14 <dennda> Did you try my latest changeset?
2008-07-26T23:13:18 <dennda> If no, do so
2008-07-26T23:13:22 <xorAxAx> no
2008-07-26T23:13:40 <dennda> wow, not even the rhyme convinced you
2008-07-26T23:14:00 <xorAxAx> fdaf7be4c0f4?
2008-07-26T23:14:07 <xorAxAx> jul 23 that is
2008-07-26T23:14:12 <dennda> well, I could try to explain the problem, but it'd be easier of you tried yourself
2008-07-26T23:14:34 <dennda> 4351:fdaf7be4c0f4
2008-07-26T23:14:35 <dennda> yes
2008-07-26T23:15:12 <xorAxAx> it still needs underlay, thats a bit weird
2008-07-26T23:15:32 <dennda> that's another story, yes.
2008-07-26T23:15:54 <xorAxAx> pagebackend has no get_item
2008-07-26T23:16:32 <dennda> is that from a traceback!?
2008-07-26T23:16:32 <xorAxAx> dennda:
2008-07-26T23:16:35 <xorAxAx> yes
2008-07-26T23:16:46 <xorAxAx> if i18n_page.exists():
2008-07-26T23:16:49 <xorAxAx> is failing with that
2008-07-26T23:17:10 <xorAxAx> while trying to load a non existing page
2008-07-26T23:17:22 <xorAxAx> hmm, or an existing one
2008-07-26T23:18:05 <xorAxAx> basically Page(request, "StartSeite").exists() is failing
2008-07-26T23:18:12 <dennda> cannot reproduce that here
2008-07-26T23:18:21 <xorAxAx> why doesnt that have get_item?
2008-07-26T23:18:26 <xorAxAx> the file system backend
2008-07-26T23:18:43 <dennda> it should
2008-07-26T23:19:03 <xorAxAx> ah, pagebackend
2008-07-26T23:19:32 <dennda> Did you create a wikiconfig_local.py?
2008-07-26T23:19:52 <dennda> http://paste.pocoo.org/raw/80436/
2008-07-26T23:20:05 <xorAxAx> no i didnt
2008-07-26T23:20:08 <xorAxAx> why is that necessary?
2008-07-26T23:20:43 <xorAxAx> ok, now its running
2008-07-26T23:20:52 <xorAxAx> and whats your question now? :)
2008-07-26T23:21:02 <dreimark> re
2008-07-26T23:21:03 <dennda> So, create a new page, edit it, save it
2008-07-26T23:21:06 <dennda> wb dreimark
2008-07-26T23:21:20 <dennda> then click to hide that message thanking you for your effort
2008-07-26T23:21:28 <dennda> you will see that the save seems to have worked
2008-07-26T23:21:37 <xorAxAx> its completly broken
2008-07-26T23:21:41 <xorAxAx> no, nothing worked for me
2008-07-26T23:21:47 <dennda> sigh...
2008-07-26T23:21:56 <dennda> what exactly went wrong?
2008-07-26T23:21:59 <xorAxAx> its showing the "no page found" message and above that the "thanks for saving" msg
2008-07-26T23:22:07 <xorAxAx> then i edit again, change something, save
2008-07-26T23:22:17 <xorAxAx> then its showing old page contents and the thanks msg
2008-07-26T23:22:27 <xorAxAx> then i edit again and see old page content again
2008-07-26T23:22:31 <xorAxAx> this could be browser caching
2008-07-26T23:22:39 <dennda> I appreciate any hints
2008-07-26T23:22:42 <xorAxAx> now i canceled and got PageEditor' object has no attribute '_items'
2008-07-26T23:22:43 <dennda> this is driving me nuts :)
2008-07-26T23:23:06 <xorAxAx> in PageEditor
2008-07-26T23:23:07 <xorAxAx> 539 if self.getRevList() == []:
2008-07-26T23:23:07 <xorAxAx> 540 del self._items[self.page_name]
2008-07-26T23:23:21 <xorAxAx> no, its not a browser cachign problem
2008-07-26T23:23:25 <dennda> yes, I reproduced that
2008-07-26T23:23:28 <dennda> let me check
2008-07-26T23:23:37 <xorAxAx> well, i would start with a debugger :)
2008-07-26T23:23:43 <xorAxAx> to peek into internal state
2008-07-26T23:23:52 <xorAxAx> personally, i prefer pdb++
2008-07-26T23:24:13 <xorAxAx> which is easily integrated by writing a 2 line action :)
2008-07-26T23:24:29 <xorAxAx> (without heavy eclipses, cough :))
2008-07-26T23:24:37 <xorAxAx> (but eclipse is fine as well if it works)
2008-07-26T23:24:54 <xorAxAx> so, could you find out what the actual data saved in the backend is?
2008-07-26T23:24:55 <dennda> I spent the whole afternoon trying to come to terms with that debugger
2008-07-26T23:25:13 <dennda> Wasn't that much of a treasure chest, unfortunately
2008-07-26T23:25:17 <xorAxAx> hmm, then its probably the wrong choice, with pdb its less than 5 min :)
2008-07-26T23:25:37 <xorAxAx> do you want to try it?
2008-07-26T23:25:41 <dennda> No, I meant "finding the problem" took the whole afternoon and still I found nothing, despite having a debugger
2008-07-26T23:25:45 <dennda> of course I want
2008-07-26T23:25:49 <dennda> I want to get rid of that bug
2008-07-26T23:25:55 <xorAxAx> well, did you check the state of the backend?
2008-07-26T23:26:03 <xorAxAx> or was the tool an issue while trying that?
2008-07-26T23:26:23 <xorAxAx> its important to know if garbage is in the backend
2008-07-26T23:26:26 <dennda> well, let's just change the backends to be FSBackends...
2008-07-26T23:26:36 <dennda> then we can check the files
2008-07-26T23:26:54 <xorAxAx> or like that :)
2008-07-26T23:27:54 <dennda> http://paste.pocoo.org/show/80439/
2008-07-26T23:27:56 <dennda> like this
2008-07-26T23:28:58 <dennda> both folders must already exist
2008-07-26T23:30:20 <dennda> nope, that looks good to me
2008-07-26T23:30:24 <dreimark> zenhase: what do I have to do when I want to try out your repo?
2008-07-26T23:30:26 <dennda> I think it's more of a rendering issue
2008-07-26T23:30:48 <dennda> and a "get data issue"
2008-07-26T23:31:09 <dennda> because when entering the editor again, as you noticed, you get old data, but there is a revision created in the FSBackend having the correct data
2008-07-26T23:33:17 <xorAxAx> dennda: well, but the above attachment stuff is unrelated to the page contents
2008-07-26T23:33:24 <xorAxAx> which problem are you trying to track down? :)
2008-07-26T23:33:45 <dennda> xorAxAx: all of them :)
2008-07-26T23:33:48 <dennda> starting with this one
2008-07-26T23:33:53 <dennda> where the wrong contents are shown
2008-07-26T23:34:12 <dennda> despite the fact that storage itself is done properly
2008-07-26T23:34:50 <xorAxAx> dennda: the piece of code that delivers the wrong page contents is the edit action
2008-07-26T23:35:17 <xorAxAx> which delegates to the PageEditor class
2008-07-26T23:35:20 <xorAxAx> and does sendEditor
2008-07-26T23:35:40 <dennda> ok now we are talking of the wrong contents being shown in the editor after clicking "edit" again, right?
2008-07-26T23:35:58 <dennda> or is that also responsible for rendering normal pages?
2008-07-26T23:36:11 <xorAxAx> lets talk about editing first
2008-07-26T23:36:13 <xorAxAx> thats much easier
2008-07-26T23:36:23 <xorAxAx> ... which does a very important step in line 274
2008-07-26T23:36:29 <xorAxAx> and 277
2008-07-26T23:36:36 <xorAxAx> and 285
2008-07-26T23:36:48 <dennda> I wonder how you can tell that fast
2008-07-26T23:36:58 <xorAxAx> by reading code :)
2008-07-26T23:37:22 <xorAxAx> now i would insert prints into the lines i just enumerated to see which "state" is seen by this method
2008-07-26T23:37:57 <dennda> yes, that's my usual debugging approach :)
2008-07-26T23:37:59 <dennda> let me do that
2008-07-26T23:38:15 <dennda> shall I commit the print statements so you can follow my debugging-process?
2008-07-26T23:38:57 <xorAxAx> no
2008-07-26T23:39:10 * xorAxAx tries to listen to radio mojn through his soundbridge
2008-07-26T23:39:24 * ThomasWaldmann .oO(the gold old print debugging from the pre debugger ages)
2008-07-26T23:39:37 <xorAxAx> dennda: i assume that you can either give the output that you saw a name ("oh its seeing revno. -1!") or at least give me the line no
2008-07-26T23:41:14 <xorAxAx> dennda: so what does it output? :)
2008-07-26T23:43:13 <dennda> current rev is: -1
2008-07-26T23:43:13 <dennda> repr of raw_body is:
2008-07-26T23:43:13 <dennda> u'Describe FrontPage here.asdasd\n'
2008-07-26T23:43:25 <xorAxAx> ah
2008-07-26T23:43:25 <dennda> which seems a bit wrong
2008-07-26T23:43:31 <xorAxAx> old or wrong?
2008-07-26T23:43:42 <xorAxAx> hmm, where does the -1 come from ...
2008-07-26T23:43:51 <xorAxAx> does current_rev return -1?
2008-07-26T23:43:52 <xorAxAx> why?
2008-07-26T23:43:58 * dennda checks what current_rev does
2008-07-26T23:44:16 <xorAxAx> hah, weird code
2008-07-26T23:44:32 <xorAxAx> INBAND SIGNALING
2008-07-26T23:44:47 <xorAxAx> very evil
2008-07-26T23:45:14 * dennda fires up wikipedia
2008-07-26T23:45:41 <xorAxAx> http://en.wikipedia.org/wiki/In-band
2008-07-26T23:46:02 *** irc.freenode.net sets mode: +o ChanServ
2008-07-26T23:46:17 <xorAxAx> the metadata bit "error condition" is encoded in the same domain as the data
2008-07-26T23:46:25 <xorAxAx> an exception would be better but might break callers
2008-07-26T23:46:54 <xorAxAx> but, if _item is not set, its a programming error
2008-07-26T23:47:00 <xorAxAx> because exists() returned true beforehand
2008-07-26T23:47:03 <dennda> how can it get any more broken ;)
2008-07-26T23:47:11 <xorAxAx> so the method is obviously pretty void
2008-07-26T23:47:39 <dennda> what do you mean by that?
2008-07-26T23:48:07 <xorAxAx> that somebody hould repair current_rev()
2008-07-26T23:48:10 <xorAxAx> +s
2008-07-26T23:48:28 <xorAxAx> and remove the -1 from it
2008-07-26T23:50:59 <xorAxAx> dennda: your saving code is pretty much ignorant of metadata somehow
2008-07-26T23:51:10 <dennda> what Exception do you think is appropriate?
2008-07-26T23:51:13 <xorAxAx> you probably should add XXX in such cases
2008-07-26T23:51:18 <xorAxAx> dennda: assert self._item
2008-07-26T23:51:38 <xorAxAx> or no idea
2008-07-26T23:51:51 <xorAxAx> well, whats the invariant of the page class? when does _item exist and when not?
2008-07-26T23:51:57 <dennda> I don't know, do we always assert a page to have an item?
2008-07-26T23:52:05 <dennda> that's the question
2008-07-26T23:52:14 * dennda checks
2008-07-26T23:53:38 <xorAxAx> well, thats depends on how one can satisfy enough of the old's interface requirements
2008-07-26T23:53:44 <dennda> it is a property
2008-07-26T23:54:05 <dennda> a lazily loaded one
2008-07-26T23:54:36 <dennda> So imho, it should always exist
2008-07-26T23:54:53 <xorAxAx> did you understand what i meant with my comment about the saving?
2008-07-26T23:55:48 <dennda> I know what you mean by XXXing, what piece code do you mean precisely?
2008-07-26T23:55:51 <dennda> +of
2008-07-26T23:56:02 <xorAxAx> the pageeditor code where the old _write_file call was
2008-07-26T23:56:17 <xorAxAx> write_file does more than the inlined code you added there and you didnt add XXX for that
2008-07-26T23:57:19 <dennda> true
2008-07-26T23:57:24 <dennda> ok, I'll XXX
2008-07-26T23:57:38 <xorAxAx> (and probably add the old code sometime as well :)
2008-07-26T23:57:48 <dennda> ;)
2008-07-26T23:57:51 <xorAxAx> (but hopefully not at the old place but in a spot where it makes more sense)
2008-07-26T23:58:37 <xorAxAx> maybe one could use the decorator pattern for this conflict metadata
2008-07-26T23:58:55 <dennda> i will use assert self._item then, ok?
2008-07-26T23:59:22 <xorAxAx> well, or no assert at all (which would also fail)
2008-07-26T23:59:41 <dennda> let's be implicit here MoinMoin: MoinMoinChat/Logs/moin-dev/2008-07-26 (last edited 2008-07-25 22:15:02 by IrcLogImporter)
