2008-04-22T00:00:46 <xorAxAx> zenhase: do you know "donkey rhubarb"?
2008-04-22T07:28:18 <gizmach> moin
2008-04-22T07:36:13 <dennda> ARGH
2008-04-22T07:36:24 <gizmach> dennda: wha?
2008-04-22T07:36:31 <dennda> my mailbox was like unread messages yesterday night when I went to bed
2008-04-22T07:36:41 <gizmach> dennda: hahahhahah :D
2008-04-22T07:36:44 <dennda> now LH added me to the gsoc list and it's 250
2008-04-22T07:36:47 <gizmach> I understand everything
2008-04-22T07:36:49 <gizmach> :)
2008-04-22T07:37:05 <dennda> honestly, does anybody read that?
2008-04-22T07:37:09 * dennda applies a filter
2008-04-22T07:37:10 <gizmach> but it's realy great to read some of those mails
2008-04-22T07:37:11 <gizmach> I do
2008-04-22T07:37:28 <gizmach> cause you se how people realy want that and how they love to code
2008-04-22T07:37:30 <dennda> or even better withdraw from the list if it isn't needed
2008-04-22T07:37:31 <dennda> is it?
2008-04-22T07:37:35 <gizmach> and it's realy amasing
2008-04-22T07:37:53 <gizmach> cause I don't see that on my college very often
2008-04-22T07:40:35 <gizmach> well I think you could just put to not receive it in a mailbox but still look at it at the google groups
2008-04-22T07:40:47 <gizmach> I know it's a bit annoying to have a ful mailbox
2008-04-22T07:43:15 <dennda> that's what I was thinking of
2008-04-22T07:43:18 <dennda> anyway
2008-04-22T07:43:21 <dennda> --> university
2008-04-22T07:43:35 <dennda> bbl
2008-04-22T08:17:56 <dreimark> moin
2008-04-22T08:56:16 <ThomasWaldmann> moin
2008-04-22T11:48:51 <zenhase> moin
2008-04-22T11:52:41 <PawelPacana> moin
2008-04-22T11:53:28 <TheSheep> hi PawelPacana
2008-04-22T11:57:15 <gizmach> moin all
2008-04-22T11:57:38 <TheSheep> hi gizmach
2008-04-22T12:13:56 <ThomasWaldmann> btw http://moinmo.in/GoogleSoc2008 has some new stuff what soc students can already do
2008-04-22T12:17:15 <ThomasWaldmann> PawelPacana: when creating your wiki homepage, decide whether you want that "l" striked or rather a pretty (ASCII) URL - fix the link on the soc page to match your decision
2008-04-22T12:18:39 <PawelPacana> ThomasWaldmann: i`ll stick with ascii
2008-04-22T12:21:11 <ThomasWaldmann> dennda: mitsuhiko: please also create a wiki homepage (follow the link on GoogleSoc2008 page, use HomepageTemplate)
2008-04-22T12:22:41 <ThomasWaldmann> (and everybody please subscribe to your wiki homepage)
2008-04-22T12:27:00 <ThomasWaldmann> (and everybody please create an account matching your homepage and log in :)
2008-04-22T12:46:49 <dennda> ThomasWaldmann: Is that meant to contain my applications in a nice-looking form? (as zenhase and gizmach did)
2008-04-22T12:48:20 <dreimark> johill: we will need a converter for the unit parser if we require for EmbedObject units. But we don't currently for the {{..}} syntax. Currently I do think refacroring of the latter should be done after 1.7 and we should do it similiar on EmbedObject.
2008-04-22T12:49:05 <johill> hm?
2008-04-22T12:49:11 <dreimark> The interesting question is now if we can use as default the first defined unit in the list
2008-04-22T12:50:40 <dreimark> The usage of EmbedObject 1.6 is <<EmbedObject(a.pdf,width=100,height=100)>>
2008-04-22T12:51:05 <dreimark> in 1.7dev it's e.g. <<EmbedObject(a.pdf,width=100px,height=100px)>>
2008-04-22T12:51:15 <johill> ah
2008-04-22T12:51:27 <johill> I guess a default unit could be doable
2008-04-22T12:51:40 <dreimark> great
2008-04-22T12:53:04 <johill> although that's a bit cornering on bad use
2008-04-22T12:53:05 <dreimark> can be the default unit be the first of the list
2008-04-22T12:53:06 <dreimark> ?
2008-04-22T12:53:15 <dreimark> of required units
2008-04-22T12:53:18 <johill> yes
2008-04-22T12:53:20 <johill> but
2008-04-22T12:54:58 <johill> consider something where the value isn't a number
2008-04-22T12:55:01 <johill> and you still have units
2008-04-22T12:55:21 <johill> then is '1cm' with or w/o unit?
2008-04-22T12:55:42 <johill> I guess the ambiguity doesn't really matter though
2008-04-22T12:56:30 <dreimark> if we want strict usage of the argparser than it is an int with an required unit
2008-04-22T12:57:02 <dreimark> so it needs to be refactored
2008-04-22T12:57:42 <johill> I don't have a good plan right now, and I'm going for lunch now :)
2008-04-22T12:58:13 <dreimark> "mahlzeit"
2008-04-22T12:58:20 <johill> :)
2008-04-22T12:58:26 * dreimark is back from lunch
2008-04-22T13:07:34 * dreimark http://master17.moinmo.in/HelpOnMacros will refactor the first example later on
2008-04-22T13:12:28 <dreimark> johill: if it is easy can you list the valid units if one fails to add a propper one
2008-04-22T13:12:46 <dreimark> instead onl <<EmbedObject: Invalid unit in value 100pxa>>
2008-04-22T13:12:59 <dreimark> (this is not as urgent as the other one)
2008-04-22T13:25:28 <zenhase> now for some lunch and an university course
2008-04-22T13:25:43 <zenhase> i am back at 6pm
2008-04-22T13:29:19 <zenhase> (CEST)
2008-04-22T13:29:26 <zenhase> :)
2008-04-22T13:51:11 <dennda> johill: thanks by the way
2008-04-22T14:02:34 <dreimark> PawelPacana: please do login on MM it is easier in RecentChanges to identify who did changes
2008-04-22T14:05:40 <PawelPacana> dreimark: i already did (sorry for the first two)
2008-04-22T14:13:04 <dreimark> :)
2008-04-22T14:13:43 <dreimark> does one wants another unit in ['px', 'em', 'pt', 'in', 'mm', '%'] for EmbedObject?
2008-04-22T14:30:18 <johill> dreimark: the latter is easier :)
2008-04-22T14:30:38 <johill> dennda: for?
2008-04-22T14:31:02 <dreimark> johill: yep. if the first is to difficult we can use px as default too
2008-04-22T14:31:24 <dreimark> for 1.7 and do make it more flexible in 1.8
2008-04-22T14:31:39 <CIA-48> Johannes Berg <johannes AT sipsolutions DOT net> default * 3515:9821253655db 1.7/MoinMoin/wikiutil.py: UnitArgument: show list of valid units in error message
2008-04-22T14:32:24 <dennda> johill: being the target of my annoying questions
2008-04-22T14:34:03 <johill> heh
2008-04-22T14:34:17 <johill> no worries
2008-04-22T14:34:24 <johill> I'm used to much worse :)
2008-04-22T14:35:47 <gizmach> Is ther any chance to see all accepted students from particular country?
2008-04-22T14:36:05 <johill> besides, I have an interest that you understand it as best as possible :)
2008-04-22T14:36:35 <johill> dreimark: problem is that with unit argument we'd have to check that the given value is proper
2008-04-22T14:36:43 <johill> i.e. not accept '7pxa' as '7pxa px'
2008-04-22T14:47:33 <CIA-48> Johannes Berg <johannes AT sipsolutions DOT net> default * 3516:a81ad9e5d220 1.7/MoinMoin/wikiutil.py: allow UnitArgument to have a default unit
2008-04-22T14:47:36 <johill> dreimark: there
2008-04-22T15:00:46 <dreimark> johill: sorry phonecall will look now
2008-04-22T15:00:53 <johill> np
2008-04-22T15:12:15 <dreimark> johill: oh EmbedObject has width=wikiutil.UnitArgument(None, float, ['px', 'em', 'pt', 'in', 'mm', '%'])
2008-04-22T15:12:31 <johill> add ", 'px'" then
2008-04-22T15:27:38 <dreimark> works doing width=wikiutil.UnitArgument(None, float, ['px', 'em', 'pt', 'in', 'mm', '%'], defaultunit='px') (me should read more)
2008-04-22T15:28:35 <dreimark> johill: thanks
2008-04-22T15:28:37 <johill> :)
2008-04-22T15:32:59 <ThomasWaldmann> don't forget to update the docs for extension developers :)
2008-04-22T15:33:55 <kikka> Moin
2008-04-22T15:37:02 <TheSheep> "given the way that web standards are created, js is much better than we deserve"
2008-04-22T15:55:35 <CIA-48> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3517:41bfc5d6e3d3 1.7/MoinMoin/macro/EmbedObject.py: macro.EmbedObject: use default unit px if None is given
2008-04-22T15:56:08 <dreimark> ThomasWaldmann: it's already on my list will do it later today
2008-04-22T15:56:36 <dreimark> hi kikka
2008-04-22T15:57:12 <kikka> Huhu dreimark
2008-04-22T16:10:09 <dreimark> do you have already a moinmoin wiki at school?
2008-04-22T16:10:17 <dreimark> kikka:
2008-04-22T16:10:25 <kikka> Nope.
2008-04-22T16:37:35 <dreimark> do we have already a macro which can be used to go to the previous / next moin-dev log page
2008-04-22T16:39:07 <johill> navigation() maybe ni some way?
2008-04-22T16:42:56 <dreimark> <<Navigation(slides)>>
2008-04-22T16:43:55 <dreimark> probably should do it
2008-04-22T16:45:26 <dreimark> ThomasWaldmann: xorAxAx if you do think it's a good idea please could you add it to the logimporter page creater
2008-04-22T16:47:31 <xorAxAx> no, i dont think that it is :)
2008-04-22T16:49:30 <dreimark> can it be done at the time we have the date switch ?
2008-04-22T16:54:28 <xorAxAx> doesnt make it a better idea
2008-04-22T16:54:40 <xorAxAx> IMHO its nicer to add it to the irc log parser
2008-04-22T16:54:57 <xorAxAx> (hmm, which is not used at all? :))
2008-04-22T16:57:52 <dreimark> it user #!plain. using the irc parser and adding it there makes more sense yes
2008-04-22T17:11:19 <kikka> ThomasWaldmann: If you've some time, join #olpc-de :) we're talking about the olpc-de wikisystem which is powered by you, i think ;)
2008-04-22T17:14:41 <gizmach> re
2008-04-22T17:16:26 <TheSheep> hmm... I wonder if it would be worthwhile to make a moin theme using some templating language
2008-04-22T17:16:53 <dreimark> ... and do refactoring sendpage ...
2008-04-22T17:17:01 <TheSheep> haha
2008-04-22T17:17:20 <TheSheep> that'd be definitely worthwhile
2008-04-22T17:31:21 <zenhase> re
2008-04-22T17:35:13 * xorAxAx wrote a mail to his student
2008-04-22T17:50:05 <dreimark> LOL My F5 key can go to sleep too.
2008-04-22T17:50:40 <zenhase> what's with the f5 key anyway? :)
2008-04-22T17:51:04 <dreimark> refresh in FF
2008-04-22T17:51:13 <zenhase> doesn't gmail check automatically via ajax calls every few seconds?
2008-04-22T17:51:57 <dreimark> don't know what's the rate is
2008-04-22T17:52:02 <dreimark> but it refreshes often
2008-04-22T17:52:40 <dreimark> zenhase: that note was from the code discussion list
2008-04-22T17:56:13 <ThomasWaldmann> waldi: can you please refactor you soc application and all the q/a to a wiki page?
2008-04-22T17:57:00 <zenhase> now for some food *sneaks to the fridg^Wuniversity cafeteria*
2008-04-22T17:57:33 <ThomasWaldmann> waldi: kind of a project specification we can use for clarification / discussion / further refinement
2008-04-22T18:05:41 <ThomasWaldmann> btw, I suggest that every student does some braindump into some wiki pages with an much more detailed project specification / plan
2008-04-22T18:10:03 <xorAxAx> hmm, there are only 300 korean family names
2008-04-22T18:14:20 <dreimark> A long history of the use of family names has caused surname extinction.
2008-04-22T18:15:08 <dreimark> There are only about 250 Korean family names currently in use, and the three most common (Kim, Lee, and Park) account for nearly half of the population.
2008-04-22T18:15:17 <dreimark> xorAxAx:
2008-04-22T18:15:31 <xorAxAx> yes
2008-04-22T18:22:05 <ThomasWaldmann> now name your child Kim Kim or Lee Lee and the confusion is complete :P
2008-04-22T18:35:51 <dennda> echtenamen.de <-- we can do better :)
2008-04-22T18:45:46 <dreimark> dennda: KAPITALMARKT
2008-04-22T18:47:19 * dreimark goes home
2008-04-22T18:47:22 <dreimark> bbl
2008-04-22T19:31:50 <ThomasWaldmann> gizmach: eric?
2008-04-22T19:35:57 <gizmach> ThomasWaldmann: my alterego :D
2008-04-22T19:40:44 <TheSheep> gizmach: with goatee?
2008-04-22T19:46:42 <dreimark> bb
2008-04-22T19:47:21 <zenhase> TheSheep: *g*
2008-04-22T19:47:52 * zenhase removed his goatee some weeks ago
2008-04-22T19:48:56 <gizmach> huh
2008-04-22T19:49:20 <TheSheep> gizmach: evil twins usually have goatee
2008-04-22T19:50:32 <zenhase> hmm, seems mitsuhiko is still busy
2008-04-22T19:50:55 <zenhase> i'll go cllimbing now, be back in 3h. then i will fix up a wiki page for my soc project
2008-04-22T19:55:16 <gizmach> TheSheep :also :) :D
2008-04-22T20:12:56 <dreimark> we should extend the search to sort language dependent
2008-04-22T20:13:42 <dreimark> and the users lang should be set on top
2008-04-22T20:15:02 <TheSheep> dreimark: and have some fuzzy language guessing
2008-04-22T20:15:18 <dreimark> TheSheep: why?
2008-04-22T20:15:37 <dreimark> you know it from the logged in once
2008-04-22T20:15:45 <TheSheep> dreimark: of pages
2008-04-22T20:16:05 <dreimark> ah, right but on mmaster it would be helpful
2008-04-22T20:16:34 <TheSheep> dreimark: I can see two approaches: search for the stop words, or look at the languages of the users who edit the pages
2008-04-22T20:16:43 <dreimark> if marian implements his categorizer then guessing would be nice
2008-04-22T20:17:07 <TheSheep> the stop word approach actually works pretty well, except for very similar languages
2008-04-22T20:18:43 <dreimark> it can look for the stop words and sort the results to the users lang on top
2008-04-22T20:20:01 <dreimark> btw. I was not aware of this general var generates_headings = False
2008-04-22T20:21:01 <dreimark> global var
2008-04-22T20:22:39 <TheSheep> nice for embedding, I guess
2008-04-22T21:07:09 <dreimark> ThomasWaldmann: User instance has no attribute 'want_trivial'
2008-04-22T21:07:20 <dreimark> on master17
2008-04-22T21:07:32 <dennda> 440 emails from gsoc mailing list since yesterday
2008-04-22T21:07:38 <dennda> insane
2008-04-22T21:22:43 <ThomasWaldmann> dreimark: was removed by johill in 1.7 cs 0cd1152b8da5
2008-04-22T21:24:38 <johill> it was supposed to be handled by the stuff grzywacz did
2008-04-22T21:25:24 <johill> i.e. at that point no users should have existed :)
2008-04-22T21:25:24 <ThomasWaldmann> well, some code still wants it :)
2008-04-22T21:25:36 <johill> where? :)
2008-04-22T21:26:09 <ThomasWaldmann> Page.py
2008-04-22T21:26:13 <johill> huh
2008-04-22T21:26:19 <dreimark> ThomasWaldmann: can it be that a user does not have this entry?
2008-04-22T21:26:53 <dreimark> that he misses a migration
2008-04-22T21:27:09 <johill> new user
2008-04-22T21:27:19 <johill> but it shouldn't ... hrm
2008-04-22T21:27:27 <johill> grzywacz: can you take a look if anything needs that?
2008-04-22T21:27:33 <johill> grzywacz: I thought we had a new event for that
2008-04-22T21:28:48 <dreimark> ok happens on test17 too
2008-04-22T21:29:55 <johill> I think it can just all be removed
2008-04-22T21:30:05 <johill> users = [u for u in subscribers[lang]
2008-04-22T21:30:05 <johill> if ev.PageChangedEvent.name in u.email_subscribed_events]
2008-04-22T21:30:08 <johill> filters it too
2008-04-22T21:30:11 <johill> since the event name is different
2008-04-22T21:30:22 <johill> ev.PageChangedEvent vs. ev.TrivialPageChangedEvent
2008-04-22T21:30:26 <johill> grzywacz: comments?
2008-04-22T21:34:30 <johill> that particular cs didn't actually remove the want_trivial anyway :)
2008-04-22T21:38:52 <johill> http://johannes.sipsolutions.net/patches/moin/all/LATEST/001-no-trivial.patch
2008-04-22T21:38:56 <johill> dreimark: can you try that?
2008-04-22T21:39:25 <johill> why does moin do all that 'kw.get()' btw?
2008-04-22T21:39:27 <johill> I hate that :)
2008-04-22T21:41:27 <dreimark> after dinner
2008-04-22T21:41:36 <johill> k
2008-04-22T21:57:40 <ThomasWaldmann> johill: btw, you did a migration from 1.6earlyalpha to 1.6 iirc, right?
2008-04-22T21:58:19 * dreimark hates typing ci instead of vi
2008-04-22T22:00:12 <johill> I used those all along
2008-04-22T22:00:15 <johill> not sure I ever migrated
2008-04-22T22:02:19 <ThomasWaldmann> hmm? the old versions used markup like ["foo bar" the foo bar page]
2008-04-22T22:02:33 <johill> oh yeah I did a migration for that
2008-04-22T22:02:36 <ThomasWaldmann> or attachment:"foo bar.txt"
2008-04-22T22:02:48 <johill> just the regular migration, I think I pretended to be coming from 1.5
2008-04-22T22:03:01 <ThomasWaldmann> but you didn't write a converter?
2008-04-22T22:03:05 <johill> no
2008-04-22T22:03:11 <ThomasWaldmann> pity X)
2008-04-22T22:03:16 * ThomasWaldmann needs one
2008-04-22T22:04:25 <johill> what was different from 1.5 in early 1.6?
2008-04-22T22:04:50 <ThomasWaldmann> what I told above was the difference. quoting for stuff with blanks
2008-04-22T22:04:52 <ThomasWaldmann> brb
2008-04-22T22:05:07 <ThomasWaldmann> MoinMoin:"foo bar"
2008-04-22T22:05:09 <johill> oh
2008-04-22T22:05:24 <johill> I had used [: syntax consistently
2008-04-22T22:09:37 <dreimark> I do miss in userprefs "Subscribe to trivial changes"
2008-04-22T22:09:51 <dreimark> was that removed ?
2008-04-22T22:10:07 <dreimark> but then the flag does not make sense too+
2008-04-22T22:12:23 <dreimark> johill: it does not crash with the patch (I do use only dummy for the mail vars currently)
2008-04-22T22:12:58 <johill> dreimark: look at the notification prefs
2008-04-22T22:13:01 <johill> it's a new thing
2008-04-22T22:15:37 <johill> I'll commit that I'm pretty sure it's correc
2008-04-22T22:15:49 <dreimark> cool, but then the patch is wrong I have not subscribed trivial
2008-04-22T22:16:06 <johill> hm?
2008-04-22T22:16:33 <johill> did you get a notification?
2008-04-22T22:16:46 <johill> trivial events have a different class name
2008-04-22T22:17:32 <dreimark> have selected trivial change by edit/save and gots a message (sended to ..)
2008-04-22T22:18:02 <johill> hm
2008-04-22T22:18:13 <dreimark> the subscribed user has not enabled "Page has been modified in a trivial fashion"
2008-04-22T22:18:27 <johill> ok so there's a bug
2008-04-22T22:18:30 <johill> somewhere
2008-04-22T22:18:40 <dreimark> but Page has been modified
2008-04-22T22:19:16 <johill> that's odd since the event is TrivialPageChangedEvent
2008-04-22T22:20:30 <dreimark> the notification trivial switch seems to be useless
2008-04-22T22:20:40 <johill> it shouldn
2008-04-22T22:20:42 <johill> shouldn't
2008-04-22T22:20:51 <johill> if trivial:
2008-04-22T22:20:51 <johill> e = events.TrivialPageChangedEvent(self.request, self, comment)
2008-04-22T22:20:54 <johill> else:
2008-04-22T22:20:56 <johill> e = events.PageChangedEvent(self.request, self, comment)
2008-04-22T22:20:59 <johill> results = events.send_event(e)
2008-04-22T22:21:01 <johill> (PageEditor)
2008-04-22T22:21:04 <dreimark> if it is enabled and page modified off then no mail
2008-04-22T22:21:38 <johill> hm ok
2008-04-22T22:21:49 <dreimark> it is quite easy to test locally
2008-04-22T22:21:58 <dreimark> mail_smarthost = 'dummy'
2008-04-22T22:22:05 <dreimark> mail_from = 'dummy'
2008-04-22T22:22:17 <dreimark> then you get shown the msgs
2008-04-22T22:22:38 <johill> yeah
2008-04-22T22:22:46 <johill> can you add a print statement to filter_subscriber_list and show event_name?
2008-04-22T22:23:01 <johill> ah no n/m
2008-04-22T22:23:54 <johill> ok I see
2008-04-22T22:27:05 <johill> give me a minute
2008-04-22T22:27:23 <dreimark> ok I take a showe
2008-04-22T22:27:26 <dreimark> ;)
2008-04-22T22:34:18 <johill> dreimark: should be better now
2008-04-22T22:47:05 * dreimark looks
2008-04-22T22:48:07 <johill> we probably need a converter for want_trivial -> pagetrivialevent
2008-04-22T22:48:49 <dreimark> I do get local variable 'page' referenced befor assigment
2008-04-22T22:49:05 <dreimark> in events.emailnotify line 76
2008-04-22T22:49:44 <johill> oops.
2008-04-22T22:49:51 <johill> my mistake, wrong ordering there, fixed
2008-04-22T22:51:06 <johill> can you also check if http://moinmo.in/MoinMoinBugs/AttachmentUploadError exists?
2008-04-22T22:51:18 <johill> that might be because they have a three-week old snapshot
2008-04-22T22:52:54 <dreimark> another one
2008-04-22T22:53:10 <johill> bah I really should set up notification and test
2008-04-22T22:53:11 <dreimark> handle_page_change does not have request
2008-04-22T22:53:32 <johill> add request = event.request
2008-04-22T22:55:05 * dreimark can test now no crash at first trial
2008-04-22T22:55:17 <johill> :)
2008-04-22T22:56:01 <dreimark> trivial changes alone (./)
2008-04-22T22:56:54 <dreimark> page edit + trivial enabled and flag trivial (./)
2008-04-22T22:59:10 <johill> thanks :)
2008-04-22T22:59:14 <johill> I'll commit it
2008-04-22T23:00:13 <dreimark> I do check some of the other flags tomorrow
2008-04-22T23:00:50 <CIA-48> Johannes Berg <johannes AT sipsolutions DOT net> default * 3518:ef612c82bdfd 1.7/MoinMoin/ (Page.py events/emailnotify.py events/jabbernotify.py): remove want_trivial completely, fix trivial notifications
2008-04-22T23:00:51 <johill> thanks for testing
2008-04-22T23:01:59 <dreimark> can you do some of the notification tests
2008-04-22T23:02:30 <dreimark> too ?
2008-04-22T23:02:51 <johill> which ones?
2008-04-22T23:03:30 <johill> or rather what do you mean?
2008-04-22T23:03:33 <johill> do you think we can write tests?
2008-04-22T23:04:51 <dreimark> 22:53 < johill> bah I really sho....
2008-04-22T23:04:58 <johill> heh
2008-04-22T23:05:19 <johill> yeah I can get a few tests done. actually, I run this code on all my wikis. wonder why nobody complained about the trivial stuff fyet
2008-04-22T23:05:30 <dreimark> I think we should write some tests
2008-04-22T23:05:59 <dreimark> it was a bit annoying at the weekend to do several times the same manually tests
2008-04-22T23:06:25 <johill> I don't know how we can test email
2008-04-22T23:06:43 <dreimark> we need to test msg only
2008-04-22T23:07:25 <dreimark> if we get the propper msg we know the half of it
2008-04-22T23:07:51 <johill> we could write a testnotify.py
2008-04-22T23:08:03 <johill> but that wouldn't test the email code which actually had the bug here
2008-04-22T23:08:06 <dreimark> we can may be redirect to a file instead sending a mail
2008-04-22T23:08:18 <johill> stringio would be nicer
2008-04-22T23:08:28 <dreimark> right
2008-04-22T23:08:53 <johill> heh
2008-04-22T23:08:58 <johill> I guess we can import MoinMoin.mail.sendmail
2008-04-22T23:09:08 <johill> and then reassign MoinMoin.mail.sendmail.sendmail = mytestfunction
2008-04-22T23:10:51 <johill> that should work
2008-04-22T23:11:34 <johill> ahrg more stupid **kw foo
2008-04-22T23:11:40 <johill> why?!
2008-04-22T23:12:21 <dreimark> no idea
2008-04-22T23:14:22 <CIA-48> Johannes Berg <johannes AT sipsolutions DOT net> default * 3519:db35fff4d5ec 1.7/MoinMoin/mail/sendmail.py: sendmail.sendmail: don't use **kw
2008-04-22T23:15:00 <johill> **kw sucks. it means that the API to that function isn't well-defined
2008-04-22T23:16:02 <dreimark> inheritance is not easy to describe in the param definition
2008-04-22T23:16:23 <dreimark> so at least not much people know wath the parameters are
2008-04-22T23:17:17 <dreimark> good night
2008-04-22T23:18:16 <johill> hm? anyway, good plan, need sleep too
2008-04-22T23:18:45 <dreimark> the next day is coming soon ....
2008-04-22T23:29:08 <zenhase> re MoinMoin: MoinMoinChat/Logs/moin-dev/2008-04-22 (last edited 2008-04-21 22:15:02 by IrcLogImporter)
