MoinMoin: MoinMoinChat/Logs/moin-dev/2008-04-20

2008-04-20T00:01:23  <ThomasWaldmann> gn dreimark
2008-04-20T00:01:28  <lanius> hi
2008-04-20T00:12:23  <ThomasWaldmann> moin lanius
2008-04-20T00:52:48  * ThomasWaldmann tries to fix userform in 1.6
2008-04-20T02:04:10  <ThomasWaldmann> http://moinmo.in/MoinMoinBugs/ChangeOtherAccountsPassword < please someone review / test this
2008-04-20T08:33:28  * dreimark helps testing after breakfast
2008-04-20T09:25:45  <kikka> moin
2008-04-20T10:39:24  <dreimark> moin
2008-04-20T10:47:09  <dreimark> ThomasWaldmann: seems I do have a different userform. 1 out of 6 hunks FAILED -- saving rejects to file MoinMoin/userform.py.re
2008-04-20T11:05:16  <dreimark> ThomasWaldmann: I tried to apply the missing hunks
2008-04-20T11:06:57  <dreimark> it seems now not be possible to change the email address
2008-04-20T11:56:02  <ThomasWaldmann> it is for current 1.6
2008-04-20T12:08:26  <ThomasWaldmann> dreimark: line 281 add a "email_user and" as first term of the if
2008-04-20T12:09:43  <dreimark> missed to use "patch -p0" did hg import
2008-04-20T12:09:48  * dreimark tries again
2008-04-20T12:11:28  <dreimark> ThomasWaldmann: same result (patch -p0 gives 1 out of 6 hunks FAILED)
2008-04-20T12:11:42  <dreimark> and I have used a fresh clone this time
2008-04-20T12:14:35  <ThomasWaldmann> wait, i'll create a fresh patch
2008-04-20T12:17:43  <ThomasWaldmann> dreimark: http://moinmo.in/MoinMoinBugs/ChangeOtherAccountsPassword?action=AttachFile&do=get&target=userform.patch
2008-04-20T12:20:40  <dreimark> ThomasWaldmann: import without problems
2008-04-20T12:20:46  * dreimark tries again
2008-04-20T12:24:22  <dreimark> ThomasWaldmann: the email change works
2008-04-20T12:25:23  <ThomasWaldmann> can you try to reproduce both bugs that should be fixed by it?
2008-04-20T12:40:12  <dreimark> ThomasWaldmann: seems to work the question is more what else do we have to try out
2008-04-20T12:41:58  <ThomasWaldmann> i think the name changing stuff (not changing to an existing name) and the stuff in su-mode (== not overwriting wrong profile) is most critical
2008-04-20T12:42:53  <ThomasWaldmann> xorAxAx: can you also have a look please?
2008-04-20T12:45:01  <CIA-48> Reimar Bauer <rb.proj AT googlemail DOT com> default * 2625:3bc325b03a93 1.6/MoinMoin/macro/EmbedObject.py: macro.EmbedObject: fixes to use blanks in the parameter list
2008-04-20T13:12:22  <dreimark> ThomasWaldmann: found a new problem
2008-04-20T13:13:06  <dreimark> seems not to be a major one, but if you change the name without entering passwords twice
2008-04-20T13:13:46  <dreimark> in the superuser form. then the login name is changed in the theme
2008-04-20T13:13:54  <dreimark> but not the data
2008-04-20T13:15:50  <dreimark> message tells "Please specify a password!" in select user nothing is changed but in the theme
2008-04-20T13:16:16  <dreimark> and in the formfield name
2008-04-20T13:20:40  <ThomasWaldmann> yeah, the newuser detection is wrong for that case
2008-04-20T13:28:33  <dreimark> if i do set superuser to two defined users
2008-04-20T13:29:13  <dreimark> then twice time selecting the same non su user removes the su form
2008-04-20T13:31:24  <dreimark> you get it back if you select preferences again
2008-04-20T13:35:20  <dreimark> (with one defined su user too)
2008-04-20T13:41:48  <dreimark> bbl
2008-04-20T14:30:03  <ThomasWaldmann> fixed superuser lost after twice selecting normal user
2008-04-20T15:34:12  <ThomasWaldmann> fresh userform2.patch uploaded for review/testing
2008-04-20T15:58:23  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2626:2ba6342eec2d 1.6/MoinMoin/i18n/ (10 files): updated i18n
2008-04-20T15:58:23  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2627:02954cdb3577 1.6/MoinMoin/macro/EmbedObject.py: merged main
2008-04-20T16:00:10  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2628:26ebc6d92fb6 1.6/docs/INSTALL.html: make install-docs interwiki
2008-04-20T16:38:29  <ThomasWaldmann> btw, I want to release 1.6.3 asap - but the userform stuff still needs more testing (see above).
2008-04-20T16:45:12  * dreimark looks
2008-04-20T16:50:34  <dreimark> ThomasWaldmann: now I can change the username without twice entering the password
2008-04-20T16:51:06  <dreimark> moment testcase check
2008-04-20T16:51:48  <dreimark> yep it's changed too.
2008-04-20T16:51:48  <ThomasWaldmann> dreimark: you use the userform2.patch?
2008-04-20T16:51:53  <dreimark> :)
2008-04-20T16:55:14  <dreimark> ThomasWaldmann: a new user is not logged in with creating the account
2008-04-20T16:56:13  <dreimark> but if I create an other user the first one is logged in
2008-04-20T16:56:42  <dreimark> DesktopEdition = false and superuser
2008-04-20T16:56:52  <dreimark> no superuser
2008-04-20T16:59:15  <ThomasWaldmann> hmm, autologin after profile creation worked for me.
2008-04-20T17:04:10  <dreimark> for me it looks like first user created, second user created then first user logged in
2008-04-20T17:12:15  <dreimark> happens for me on an other wiki too
2008-04-20T17:15:38  <dreimark> no difference in DE mode
2008-04-20T17:17:00  * ThomasWaldmann tries again
2008-04-20T17:20:42  <ThomasWaldmann> dreimark: works
2008-04-20T17:21:58  <ThomasWaldmann> did you click away the msg box after user creation?
2008-04-20T17:22:35  <dreimark> no
2008-04-20T17:23:09  <ThomasWaldmann> one always should do "another request" as some stuff might get effective starting with next request
2008-04-20T17:23:53  <ThomasWaldmann> (or, for session bugs, might start failing in next request :)
2008-04-20T17:23:58  <dreimark> that's true
2008-04-20T17:25:22  <dreimark> currently I think if autologin is not needed for the patch it should be removed
2008-04-20T17:25:37  <dreimark> because it can lead in confusing
2008-04-20T17:29:02  <ThomasWaldmann> it is just 1 line of code. and even the msg it emits can be read in the way it works then. :)
2008-04-20T17:30:35  <dreimark> yeah but that msg is more than only an info. if you ignore it you made a big mistake
2008-04-20T17:31:39  <dreimark> you don't get in trouble for msgs like given from canceling edit
2008-04-20T17:32:15  <ThomasWaldmann> it tells "created an account for you. you can now use that data to login..."
2008-04-20T17:32:54  <ThomasWaldmann> before that 1 line change it had to be read "you need to re-enter your stuff again right now or you won't be logged in"
2008-04-20T17:33:07  <dreimark> that's better
2008-04-20T17:33:44  <ThomasWaldmann> after the change then "now" means rather "from now on, but you don't have to reenter it right NOW, because you are already logged in"
2008-04-20T17:37:07  <ThomasWaldmann> dreimark: maybe the "logged in effect" would be visible immediately if it sets theuser.valid at the end
2008-04-20T17:38:03  <dreimark> without the click it's much better, but I don't requesting a click
2008-04-20T17:39:06  <dreimark> don't like
2008-04-20T17:40:11  <ThomasWaldmann> did you test the bug scenarios? changing user name to existing user, writing to wrong profile?
2008-04-20T17:40:35  <dreimark> still trying was confused a bit too
2008-04-20T17:55:12  <dreimark> ThomasWaldmann: I do miss name2id cache/wikiconfig/user
2008-04-20T17:55:58  <dreimark> (wanted to do the tests with removed cache, user... again)
2008-04-20T18:04:31  <ThomasWaldmann> when a user profile is saved, that cache gets killed
2008-04-20T18:04:54  <dreimark> when is it created?
2008-04-20T18:05:14  <dreimark> ah ok, now i have one
2008-04-20T18:06:15  <ThomasWaldmann> created on demand (e.g. when a user logs in)
2008-04-20T18:07:55  <dreimark> it is not created with user creation / login
2008-04-20T18:08:20  <dreimark> I think that's ok
2008-04-20T18:09:10  <dreimark> seems the bugs are fixed by that patch
2008-04-20T18:10:37  <dreimark> I can't rename to an exising user or to an existing email address
2008-04-20T18:12:37  <ThomasWaldmann> did you try the .valid thing?
2008-04-20T18:16:19  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2629:fa7e99b19a43 1.6/wiki/underlay.tar: updated underlay
2008-04-20T18:19:28  <ThomasWaldmann> hmm, save() should make it valid
2008-04-20T18:21:15  <ThomasWaldmann> ah, self.request.user = theuser
2008-04-20T18:22:04  <dreimark> found that too it is already valid
2008-04-20T18:22:38  <ThomasWaldmann> ^^ works :)
2008-04-20T18:23:18  <dreimark> before or after moin_session ?
2008-04-20T18:23:58  <dreimark> does not matter for self ;)
2008-04-20T18:24:16  * dreimark tries
2008-04-20T18:24:25  *** irc.freenode.net sets mode: +o ChanServ
2008-04-20T18:26:39  <dreimark> if we don't have tests in 1.7 I promise I write some
2008-04-20T18:29:06  <ThomasWaldmann> see next commit in a few minutes
2008-04-20T18:31:18  <gizmach> moin
2008-04-20T18:31:26  <dreimark> hi gizmach
2008-04-20T18:31:42  * dreimark takes a coffee
2008-04-20T18:37:05  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2630:f405012e67af 1.6/ (MoinMoin/userform.py docs/CHANGES):
2008-04-20T18:37:05  <CIA-48> major security fix: a check in the userform processing was not working as
2008-04-20T18:37:05  <CIA-48> expected and could be abused for ACL and superuser priviledge escalation. New:
2008-04-20T18:37:05  <CIA-48> establish a session after user creation, no need to immediately enter same
2008-04-20T18:37:05  <CIA-48> name/password again.
2008-04-20T18:42:58  <ThomasWaldmann> everybody please do more tests on current 1.6 code while I continue preparing 1.6.3 release.
2008-04-20T19:08:08  <dreimark> johill: ping
2008-04-20T19:15:06  <ThomasWaldmann> Creating packages ...
2008-04-20T19:15:06  <ThomasWaldmann> /usr/lib/python2.5/zipfile.py:259: DeprecationWarning: struct integer overflow masking is deprecated
2008-04-20T19:15:09  <ThomasWaldmann> wtf?
2008-04-20T19:15:56  <TheSheep> lol
2008-04-20T19:16:27  <TheSheep> looks like deprecated code in stdlib %)
2008-04-20T19:18:57  <ThomasWaldmann> i never had that yet when doing make pagepacks
2008-04-20T19:19:21  <ThomasWaldmann> can somebody else try with current 1.6?
2008-04-20T19:20:32  * dreimark has it too
2008-04-20T19:31:02  <dreimark> ThomasWaldmann: http://bugs.python.org/issue1622
2008-04-20T20:09:47  <ThomasWaldmann> i think we can ignore that, zip -T is happy
2008-04-20T20:09:59  <ThomasWaldmann> how are other testing results?
2008-04-20T20:14:16  <ThomasWaldmann> http://static.moinmo.in/files/moin-1.6.3.tar.gz - please test
2008-04-20T20:26:08  <ThomasWaldmann> is anyone testing (except me :)?
2008-04-20T20:31:30  * dreimark too
2008-04-20T20:32:48  <dreimark> in some minutes
2008-04-20T20:54:04  <dreimark> ThomasWaldmann: do you have RC and not AA if you change your lang to german
2008-04-20T20:54:18  <dreimark> lang pack is installed
2008-04-20T20:55:19  <dreimark> seems I do miss AktuelleÄnderungen
2008-04-20T20:57:02  <dreimark> hehe my fault DE needs a restart
2008-04-20T21:06:32  <ThomasWaldmann> dreimark: not only DE
2008-04-20T21:07:13  <dreimark> i know I was wondering because the editbar was translated
2008-04-20T21:10:51  <dreimark> ThomasWaldmann: should py.test run ?
2008-04-20T21:16:23  <dreimark> it fails here with a missing underlay in  the test wiki
2008-04-20T21:23:14  <ThomasWaldmann> test wiki creation maybe depends on underlay.tar being present
2008-04-20T21:23:37  <ThomasWaldmann> (and that's not the case for the release archive)
2008-04-20T21:24:06  <ThomasWaldmann> but I ran the tests in the workdir and they worked here
2008-04-20T21:25:00  <dreimark> ok
2008-04-20T21:36:37  <ThomasWaldmann> ok, anything keeping me back from releasing?
2008-04-20T21:37:05  <dreimark> nothing yet, looks good for me played 45mins with it
2008-04-20T21:37:21  <ThomasWaldmann> ok, there we go
2008-04-20T21:38:59  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2631:b70e98cb53b8 1.6/ (9 files in 7 dirs): release 1.6.3 (bumping version, adding dummy mig scripts)
2008-04-20T21:39:51  <CIA-48> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2632:550373665133 1.6/.hgtags: tagged release 1.6.3
2008-04-20T21:40:52  <kikka> n8
2008-04-20T23:07:08  <dreimark> good night