MoinMoin: MoinMoinChat/Logs/moin-dev/2008-03-14

2008-03-14T00:05:52  <ThomasWaldmann> dreimark: ?
2008-03-14T00:09:18  <ThomasWaldmann> dreimark: are you talking about line 404 of your patch?
2008-03-14T00:09:55  <dreimark> ThomasWaldmann: yes
2008-03-14T00:10:16  <ThomasWaldmann> i don't see what sense that line makes
2008-03-14T00:11:12  <ThomasWaldmann> neither why the html formatter is used there
2008-03-14T00:12:35  <ThomasWaldmann> and not why it escapes the url before the macro call
2008-03-14T00:15:28  <dreimark> hmm, ok, will check
2008-03-14T00:15:42  <ThomasWaldmann> and please dont duplicate that code at 2 places
2008-03-14T00:15:49  <dreimark> the other one is in AttachFile 8
2008-03-14T00:15:59  <ThomasWaldmann> (but have it as a wrapper inside EmbedObject)
2008-03-14T00:16:51  <dreimark> ok, sure.
2008-03-14T00:17:59  <dreimark> I was wondering why macroo.formatter has no page object
2008-03-14T00:18:13  <ThomasWaldmann> s/ommit/omit/
2008-03-14T00:20:22  <dreimark> and recognized then that if i don't delete it in AttachFile I will get an exception in request end_include
2008-03-14T00:21:54  <ThomasWaldmann> AttachFile is an action
2008-03-14T00:22:10  <ThomasWaldmann> it does not render a wiki page using parser/formatter
2008-03-14T00:22:24  <ThomasWaldmann> thus the formatter is not initialized with a page being rendered
2008-03-14T00:35:19  <dreimark> gn
2008-03-14T11:21:35  <dreimark> moin
2008-03-14T11:35:06  <dreimark> I wonder a bit on how much test_source_code failures I get listed in built
2008-03-14T11:35:22  <dreimark> 13 failed
2008-03-14T11:37:35  <CIA-39> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3250:0f582c5d2b9f 1.7/MoinMoin/ (4 files in 4 dirs): EmbedObject refactored for new arg parser
2008-03-14T11:54:19  <dreimark> bbl
2008-03-14T13:34:48  <ThomasWaldmann> dreimark: +    request.write(EmbedObject.macro_EmbedObject(macro,  wikiutil.escape(filename), pagename=pagename)) why is that escape at that place?
2008-03-14T13:38:00  <ThomasWaldmann> +        mt_dict = wikiutil.MimeType(filename=fname)   - why is a MimeType object called "mt_dict". that is badly misleading.
2008-03-14T13:57:07  <CIA-39> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3251:ecbde828b812 1.7/MoinMoin/ (theme/__init__.py wikiutil.py): improved wikiutil.is_URL, use it also in theme code
2008-03-14T14:49:14  <mvirkkil> ThomasWaldmann: The transducer stuff outputs text past the formatter :(
2008-03-14T14:49:31  <mvirkkil> the "desc" string
2008-03-14T14:49:54  <ThomasWaldmann> mvirkkil: you know what a transducer is? :D
2008-03-14T14:51:38  <mvirkkil> yeah
2008-03-14T14:52:08  <mvirkkil> :)
2008-03-14T14:52:41  <mvirkkil> I meant transclusion of course
2008-03-14T14:54:19  <mvirkkil> In a lot of places self._transclude_description(desc, url) is returned directly, instead of going through formatter.text()
2008-03-14T14:54:43  <ThomasWaldmann> I'll have a look at it, after the passwords. :)
2008-03-14T15:01:32  <CIA-39> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3252:67cd62f8493f 1.7/MoinMoin/action/newaccount.py: avoid browsers filling in the user's password into first pw field (2)
2008-03-14T15:05:08  <ThomasWaldmann> mvirkkil: yes, that needs to get reviewed and fixed.
2008-03-14T15:05:55  <ThomasWaldmann> at some places, that desc ends up in a html attribute (of a img tag for example), this is why the fn does wikiutil.escape() at the end
2008-03-14T15:06:41  <ThomasWaldmann> but that should be removed from _transclude_description and done at the place where it is used (or in the formatter)
2008-03-14T15:12:57  <dreimark> ThomasWaldmann: a) it was escaped there before too and I have not thought about it  again if it is right or needed. and b) it happens because of pylint suggests more than two letter words. I try to find a better one.
2008-03-14T15:22:45  <dreimark> or is using "mt" as before ok?
2008-03-14T15:24:06  <dreimark> yep, I do move it back to mt. same is used in AttachFile
2008-03-14T15:30:10  <mvirkkil> The main thin for docbook is that it simplÃy doesn't output stuff past the formatter. That even simple one character strings go through formatter.text() because otherwise thedocbook formatter breaks
2008-03-14T15:34:13  <mvirkkil> or the formatter doesn't break, but the output cannot be valid
2008-03-14T15:35:12  <mvirkkil> The docbook formatter outputs nothing when the formatter methods are called, with the exception of endDocument which outputs the whole thing in one go.
2008-03-14T15:35:29  <mvirkkil> (serializes the xml tree to a string)
2008-03-14T15:37:26  <ThomasWaldmann> mvirkkil: i try to fix that stuff in the wiki parser
2008-03-14T15:42:09  <dreimark> uhh, when will someone start to refactor mimetypes
2008-03-14T15:52:47  <CIA-39> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3253:ba0707fe183d 1.7/MoinMoin/ (action/AttachFile.py macro/EmbedObject.py): EmbedObject: fixed some variable names, and escaping of target in AttachFile
2008-03-14T15:52:48  <CIA-39> Reimar Bauer <rb.proj AT googlemail DOT com> default * 3254:951eda3e45cd 1.7/MoinMoin/action/newaccount.py: merged main
2008-03-14T15:54:57  <ThomasWaldmann> mvirkkil: that stuff could get a bit a bigger refactoring...
2008-03-14T15:55:24  <mvirkkil> ThomasWaldmann: I agree
2008-03-14T15:55:37  <mvirkkil> A lot of moin could use some love
2008-03-14T15:56:20  <ThomasWaldmann> i can't just use formatter.text() in that function, because (for html) the description is only put into the alt tag (of an image)
2008-03-14T15:56:27  <dreimark> xorAxAx: if you have time can you refactor GetText2 to the new arg parser or try to give a hint how it could be done
2008-03-14T15:57:00  <mvirkkil> ThomasWaldmann: Not in all cases
2008-03-14T15:57:26  <ThomasWaldmann> sure, but in some :)
2008-03-14T15:58:31  <mvirkkil> ThomasWaldmann: But I mean it is ok, to call what ever formatter method with args etc
2008-03-14T15:58:32  <ThomasWaldmann> so that wikiutil.escape stuff for alt / title text should be done in the formatter
2008-03-14T16:21:24  <ThomasWaldmann> hmm, the html formatter calls wikiutil.escape() on its own for attributes
2008-03-14T16:22:05  <bolekk> moin
2008-03-14T16:22:40  <dreimark> moin bolekk
2008-03-14T16:36:39  <dreimark> how are you bolekk
2008-03-14T16:38:26  <bolekk> I
2008-03-14T16:39:12  <bolekk> I'm okay, thank you :) I've been quite busy preparing myself to some competitions during february
2008-03-14T16:40:42  <bolekk> now it's a short break and time to catch up in school :p
2008-03-14T16:41:52  <bolekk> I've received my t-shirt + certificate + money from GHOP a few hours ago :)
2008-03-14T16:43:49  <CIA-39> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3255:bf0e5f19be97 1.7/MoinMoin/parser/text_moin_wiki.py: moin wiki parser: fix escaping of transclusion description (the formatter does it!), use formatter.text to output a description as text
2008-03-14T16:43:51  <CIA-39> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3256:584d6376c465 1.7/MoinMoin/ (action/AttachFile.py macro/EmbedObject.py): merged main
2008-03-14T16:43:59  <ThomasWaldmann> mvirkkil: try now
2008-03-14T16:49:13  <dreimark> bolekk: great
2008-03-14T16:49:40  <dreimark> ThomasWaldmann: do mentors get a t-shirt too?
2008-03-14T16:49:51  <ThomasWaldmann> bolekk: are you going to europython?
2008-03-14T16:50:08  <ThomasWaldmann> dreimark: didnt receive anything yet, not sure if that is planned
2008-03-14T16:50:16  <bolekk> ThomasWaldmann: what is it ?
2008-03-14T16:50:39  <ThomasWaldmann> see europython.org
2008-03-14T16:50:58  <ThomasWaldmann> (it won't come much nearer :)
2008-03-14T16:52:10  <mvirkkil> ThomasWaldmann: Seems to still be broken for the case when the image doesn't exist.
2008-03-14T16:52:37  <mvirkkil> I have the code {{figures/clock_applet.png|Clock Applet}}The {{{Clock}}} applet displays the time and the date in a panel.
2008-03-14T16:53:01  <mvirkkil> And the text "Clock Applet" appears at the beginning of the docbook output, before the xml declaration
2008-03-14T16:53:10  * ThomasWaldmann looks
2008-03-14T16:53:19  <dreimark> ThomasWaldmann: I remember that I have read that there was a limit set not more than xx t-shirts per organisation
2008-03-14T16:53:47  <ThomasWaldmann> what is figures/x.png? attachment?
2008-03-14T16:53:53  <dreimark> bolekk: I do plan to be at europython  too
2008-03-14T16:54:43  <mvirkkil> ThomasWaldmann: it is nothing
2008-03-14T16:54:46  <mvirkkil> it doesn't exist
2008-03-14T16:55:04  <ThomasWaldmann> ok, what should it be, if it existed? :)
2008-03-14T16:55:29  <ThomasWaldmann> note that attachments are {{attachment:....}}
2008-03-14T16:55:33  <mvirkkil> I don't know :)
2008-03-14T16:55:41  <mvirkkil> I know that it breaks the docbook output
2008-03-14T16:56:37  <mvirkkil> You could make it a link, or an image, or just output an error text.
2008-03-14T16:56:52  <mvirkkil> but what ever it is, it should be done through the formatter :)
2008-03-14T16:57:21  <mvirkkil> at least 852, 859 and 869 look wrong
2008-03-14T16:57:29  <ThomasWaldmann> mvirkkil: i think it should be seen as a pagename for that markup
2008-03-14T16:57:30  <mvirkkil> lines
2008-03-14T16:57:33  <ThomasWaldmann> but I fixed that case
2008-03-14T16:58:27  <mvirkkil> and 880
2008-03-14T16:58:33  <ThomasWaldmann> those lines are link processing, not transclusion
2008-03-14T16:59:12  <mvirkkil> and?
2008-03-14T16:59:32  <ThomasWaldmann> and they are all correct :P
2008-03-14T16:59:52  <mvirkkil> I'm just quickly looking at stuff that seems to go past the formatter while the stuff around it use the formatter
2008-03-14T17:00:30  <ThomasWaldmann> but lets first discuss {{foo|desc}} - you are sure it doesnt work with current repo?
2008-03-14T17:01:18  <mvirkkil> I'll add the testcase to the test17 wiki
2008-03-14T17:02:21  <mvirkkil> http://test17.moinmo.in/Transclusion_test
2008-03-14T17:06:16  <mvirkkil> Seems fixed now
2008-03-14T17:06:21  <ThomasWaldmann> mvirkkil: wsgi is a long running process. after server restart it works now. :)
2008-03-14T17:06:34  <ThomasWaldmann> for debugging, better use moin.py on localhost
2008-03-14T17:07:07  <mvirkkil> I did. Didn't work there either
2008-03-14T17:07:26  <mvirkkil> strange..
2008-03-14T17:07:31  <bolekk> dreimark: ThomasWaldmann: sounds interesting but I have just a smattering of python and almost no experience with open source, I'm not sure I'm suitable for such event...
2008-03-14T17:07:41  <dreimark> ThomasWaldmann: the t-shirt announcement for mentors is in section 3. of the initial document on docs.google
2008-03-14T17:08:13  <ThomasWaldmann> i reduced # requests to 5, so it reloads new code faster
2008-03-14T17:08:15  <mvirkkil> ThomasWaldmann: and still doesn't work locally
2008-03-14T17:08:22  <bolekk> Are you going to code for moin in this development sprint ?
2008-03-14T17:08:30  <ThomasWaldmann> mvirkkil: hg pull -u ?
2008-03-14T17:09:01  <ThomasWaldmann> bolekk: if I am not alone coding, we can do a moin session :)
2008-03-14T17:09:16  <dreimark> bolekk: you will meet a lot of people there and very good talks
2008-03-14T17:10:29  <mvirkkil> ThomasWaldmann: I was 100% sure I did, but doing it again now updated some files
2008-03-14T17:10:33  <mvirkkil> Not my day.
2008-03-14T17:10:36  <mvirkkil> Sorry for the trouble
2008-03-14T17:11:25  <ThomasWaldmann> no problem, thanks for pointing me at it
2008-03-14T17:12:22  * ThomasWaldmann thinks we better review all wikiutil.escape usage
2008-03-14T17:14:43  <bolekk> dreimark: I'll think of it, thanks for info
2008-03-14T17:15:10  <ThomasWaldmann> meet guido in meatspace :D
2008-03-14T17:18:28  <dreimark> we have to check for macro_obj.execute(name, args) too
2008-03-14T17:22:45  <dreimark> args may not only be a string now
2008-03-14T17:24:07  <dreimark> bbl ~ some hours
2008-03-14T17:37:25  <ThomasWaldmann> mvirkkil: in the docbook formatter, do you make use of any kw args?
2008-03-14T17:37:38  <ThomasWaldmann> like alt=... title=... etc?
2008-03-14T17:41:34  <mvirkkil> ThomasWaldmann: Yes I do.
2008-03-14T17:41:49  <mvirkkil> For example all the comment/admonition handling is based on that
2008-03-14T17:41:57  <mvirkkil> And for images the alternative text
2008-03-14T17:42:19  <ThomasWaldmann> i am removing the escaping from the wiki parser's params processing
2008-03-14T17:42:22  <mvirkkil> and for tables the dimensions (one cell can span multiple rows/columns)
2008-03-14T17:42:30  <ThomasWaldmann> it was wrong and led to double-escaped stuff
2008-03-14T17:42:48  <ThomasWaldmann> also, escaping for html might be wrong for other output formats
2008-03-14T17:43:02  <mvirkkil> Sounds like a good idea
2008-03-14T17:43:37  <ThomasWaldmann> mvirkkil: so if you need some stuff not "as is", you may have to do it on your own
2008-03-14T17:43:57  * ThomasWaldmann will commit that soon
2008-03-14T17:44:51  <mvirkkil> I understand
2008-03-14T17:47:16  <mvirkkil> You might want to consider adding some uniformity to the way some attributes are presented to the formatter: valign vs vertical-align, text-align vs align in tables come to mind
2008-03-14T17:47:38  <mvirkkil> Maybe even split the css styles inside
2008-03-14T17:49:54  <mvirkkil> Currently I have this _convertStylesToDict function and elswhere i split up the class string to a tuple
2008-03-14T17:50:18  <mvirkkil> But its not really important.
2008-03-14T17:52:32  <mvirkkil> What would be nice though, is that a parser wouldn't be the one collecting the output. The formatter would do it internally, and then have some "serialize" function to produce the text.
2008-03-14T17:53:51  <CIA-39> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3257:7beffeb2e41f 1.7/MoinMoin/parser/text_moin_wiki.py: moin wiki parser: fix escaping of attributes (the formatter does it!)
2008-03-14T17:54:25  <mvirkkil> ok. I'll see how much broke :)
2008-03-14T17:55:16  <ThomasWaldmann> [[target|text|title=<foo!>]]
2008-03-14T17:57:53  <mvirkkil> Huh?
2008-03-14T17:58:01  <mvirkkil> What is that?
2008-03-14T17:58:09  <ThomasWaldmann> that's the test case for last changeset
2008-03-14T17:58:31  <ThomasWaldmann> (at least for the wiki parser with html formatter)
2008-03-14T17:59:27  <mvirkkil> Hmm.. What is title supposed to be?
2008-03-14T17:59:41  <ThomasWaldmann> the title of that link
2008-03-14T17:59:52  <mvirkkil> as in tooltip?
2008-03-14T17:59:56  <ThomasWaldmann> yes
2008-03-14T18:00:19  <ThomasWaldmann> if it makes no sense for DB, just ignore it
2008-03-14T18:00:28  <mvirkkil> Ok, that part is not supported  by the db output
2008-03-14T18:00:29  <mvirkkil> yah
2008-03-14T18:01:01  <ThomasWaldmann> (but the problem applies to all stuff key=value in the 3rd segment
2008-03-14T18:01:33  <ThomasWaldmann> key and value are not run through wikiutil.escape any more by the parser
2008-03-14T18:01:52  <mvirkkil> How about the table handling? I think I remember that syntax having the possibility of containing just about any style..
2008-03-14T18:01:56  * mvirkkil goes to check
2008-03-14T18:02:17  <ThomasWaldmann> read that code and get blind :P
2008-03-14T18:03:03  <mvirkkil> Heh.. I'm pretty happy with my docbook table code. It has so far survived everything I've thrown at it.
2008-03-14T18:03:16  * ThomasWaldmann meant the wiki parser
2008-03-14T18:04:04  <ThomasWaldmann> dreimark: we have to look at all wikiutil.escape calls later, including EmbedObject's usage of it
2008-03-14T18:04:47  <mvirkkil> ThomasWaldmann: Yeah, I had a quick look at it and realized what you meant :)
2008-03-14T18:06:08  <mvirkkil> Hmm.. Ok, so now it's broken
2008-03-14T18:06:46  <mvirkkil> Or actually, I found a case where I assume the user inputs sane css styling
2008-03-14T18:14:22  <mvirkkil> Ok, fixed it.
2008-03-14T18:14:37  <mvirkkil> Got to go.
2008-03-14T18:16:58  <ThomasWaldmann> cu :)
2008-03-14T19:31:34  <ThomasWaldmann> cb22: seen a story about you on planetpython.org :)
2008-03-14T19:47:10  <cb22> ThomasWaldmann: haha, cool, just saw it now :)
2008-03-14T19:47:21  <cb22> 'Federico has good taste - he likes FreeBSD and Python' hehehe
2008-03-14T19:58:04  <ThomasWaldmann> cb22: if you have some time: we need some code to make a non-verbose regex from a verbose regex
2008-03-14T19:59:06  <ThomasWaldmann> and also remove ?P<foo> stuff maybe
2008-03-14T19:59:18  <ThomasWaldmann> http://moinmo.in/MoinMoinBugs/GuiEditorSyntaxError
2008-03-14T20:42:17  <cb22> ThomasWaldmann: hmm, by convert do you just mean strip out whitespaces, comments, etc?
2008-03-14T21:01:14  <ThomasWaldmann> cb22: yeah, but is maybe a bit more difficult