MoinMoin: MoinMoinChat/Logs/moin-dev/2008-03-01

2008-03-01T09:04:55  <ThomasWaldmann> moin
2008-03-01T10:19:32  <dreimark> moin
2008-03-01T12:23:56  <johill> huh I just got a really weird bug
2008-03-01T12:24:17  <johill> http://johannes.sipsolutions.net/files/emailbug.html
2008-03-01T12:26:08  <johill> somehow it tried to save a traceback to stderr but that doesn't exist?
2008-03-01T12:26:10  <johill> I'm confused
2008-03-01T12:26:13  <johill> ThomasWaldmann: is that some logging change?
2008-03-01T12:28:25  <johill> looks like I get it for every page save that invokes email notify
2008-03-01T12:32:37  <ThomasWaldmann> re
2008-03-01T12:36:57  <ThomasWaldmann> strange traceback
2008-03-01T12:37:17  <johill> well it looks like the traceback module there tries to write to stderr
2008-03-01T12:37:25  <johill> and that isn't open so it gets 'endpoint not connected'
2008-03-01T12:37:26  <ThomasWaldmann> iirc the builtin logging config does output to file and stderr
2008-03-01T12:37:41  <ThomasWaldmann> but i dont see how it is related to what you get
2008-03-01T12:37:51  <johill> why it fails there in the first place is beyond me though
2008-03-01T12:38:29  <johill> maybe logging dup's the stderr file descriptor and closes the original?
2008-03-01T12:38:40  <johill> so the traceback module doesn't get it?
2008-03-01T12:39:04  <johill> why is that in there anyway?
2008-03-01T12:39:33  <johill> I guess the ultimate would be an except storer that later shows "we had an error but were able to continue"
2008-03-01T12:39:34  <ThomasWaldmann> does your setup have a working sys.stderr?
2008-03-01T12:39:43  <johill> I don't know, it might not have
2008-03-01T12:39:46  <johill> it's fastcgi
2008-03-01T12:40:13  <johill> I would have thought it does
2008-03-01T12:40:18  <johill> never ran into problems before
2008-03-01T12:40:48  <ThomasWaldmann> maybe just use the new moin.fcg and use the wiki/config/logging/logfile log config
2008-03-01T12:40:53  <johill> I do
2008-03-01T12:41:21  <johill> but traceback obviously tries to write directly to stderr
2008-03-01T12:41:35  <johill> I suppose it would be better anyway to have it log to logging
2008-03-01T12:41:50  <johill> i.e. use traceback print-to-string instead of print_exc
2008-03-01T12:41:59  <ThomasWaldmann> so the logging does not say it uses default builtin logging config (see log)?
2008-03-01T12:42:29  <johill> is that WARNING or higher?
2008-03-01T12:42:41  <johill> oh ERROR I mean
2008-03-01T12:42:53  * ThomasWaldmann looks
2008-03-01T12:42:59  <johill> anyway, I'm pretty sure it works and logconf is read
2008-03-01T12:43:09  <johill> I see
2008-03-01T12:43:20  <johill> 2008-02-27 17:59:17,226 MoinMoin.failure ERROR TypeError: not enough arguments f
2008-03-01T12:43:23  <johill> or format string
2008-03-01T12:43:26  <johill> in my log file
2008-03-01T12:43:42  <ThomasWaldmann>     l.warning('Using built-in fallback logging configuration!')
2008-03-01T12:44:15  <johill> ok let me set to warning and restart
2008-03-01T12:44:21  <johill> wait
2008-03-01T12:44:30  <johill> if it wasn't reading my logging config it would log it
2008-03-01T12:44:37  <johill> since then it wouldn't know to only log error and higher
2008-03-01T12:44:39  <johill> no?
2008-03-01T12:45:11  <johill> wow my log is full of redirect bugs
2008-03-01T12:47:30  <johill> eh
2008-03-01T12:47:35  <johill> how is request.theme.add_msg supposed to work?
2008-03-01T12:48:13  <ThomasWaldmann> cb22:
2008-03-01T12:49:05  <johill> http://johannes.sipsolutions.net/patches/moin/all/2008-03-01-11%3a48/001-fix-page-theme-message.patch
2008-03-01T12:50:41  <johill> please commit asap, I already have almost a thousand of those errors in my log
2008-03-01T12:52:40  <johill> I don't want to touch it though because I don't know how it should work
2008-03-01T12:52:55  <johill> in some cases it looks like the "info" text should be appended to the string? like in the first one?
2008-03-01T12:52:58  <johill> but that's weird
2008-03-01T12:53:27  <johill> ThomasWaldmann: about that other bug though. how about we just change it to log an error instead of doing the traceback.print_exc()?
2008-03-01T12:53:35  <ThomasWaldmann> the patch looks ok
2008-03-01T12:54:30  <johill> do we rely on python 2.4 now?
2008-03-01T12:55:28  <johill> guess not
2008-03-01T12:56:31  <johill> ThomasWaldmann: http://johannes.sipsolutions.net/patches/moin/all/2008-03-01-11%3a56/001-traceback-error.patch like that
2008-03-01T12:57:40  <CIA-38> Johannes Berg <johannes AT sipsolutions DOT net> default * 3154:c9ff5a31b5cd 1.7/MoinMoin/Page.py: fix some Page object theme.msg_add() calls
2008-03-01T12:57:55  <ThomasWaldmann> cb22: that stuff needs some fixes
2008-03-01T12:58:50  <ThomasWaldmann> johill: iirc logging has special support for traceback info logging
2008-03-01T13:00:01  <johill> you never used that in auth?
2008-03-01T13:00:08  <johill> I just copied this from the auth method ;)
2008-03-01T13:00:18  <ThomasWaldmann> i didnt use it yet
2008-03-01T13:00:48  <ThomasWaldmann> but if we change that stuff anyway, we could use the right call
2008-03-01T13:01:32  <johill> ok
2008-03-01T13:02:05  <johill> right it looks like
2008-03-01T13:02:45  <johill> http://johannes.sipsolutions.net/patches/moin/all/2008-03-01-12%3a02/001-traceback-error.patch
2008-03-01T13:04:02  <johill> guess I better test...
2008-03-01T13:05:21  <johill> 2008-03-01 12:59:33,479 MoinMoin.failure ERROR AttributeError: 'module' object has no attribute 'getAttachUploadUrl'
2008-03-01T13:05:24  <johill> huh
2008-03-01T13:05:27  <johill> that's new
2008-03-01T13:05:28  <ThomasWaldmann> exception(  msg[, *args])
2008-03-01T13:05:55  <johill> even easier
2008-03-01T13:06:04  <ThomasWaldmann> johill: there should be no call to getAUU any more
2008-03-01T13:06:06  <johill> guess that's a shortcut for error(msg, exc_info=True)
2008-03-01T13:06:15  <johill> File "/usr/local/src/moin/MoinMoin/formatter/text_html.py", line 631, in attachment_link
2008-03-01T13:06:34  * ThomasWaldmann fixes that
2008-03-01T13:07:28  <ThomasWaldmann> my src does not have that call
2008-03-01T13:07:34  <johill> huh
2008-03-01T13:07:49  <johill> neither does mine
2008-03-01T13:08:04  <ThomasWaldmann> pyc?
2008-03-01T13:08:05  <johill> confusing
2008-03-01T13:08:07  <johill> probably
2008-03-01T13:09:23  <johill> ok
2008-03-01T13:09:28  <johill> that logging.exception works
2008-03-01T13:09:31  <johill> and the bug is mine :)
2008-03-01T13:09:56  <CIA-38> Johannes Berg <johannes AT sipsolutions DOT net> default * 3155:7dd36ca5f4b3 1.7/MoinMoin/Page.py: use logging.exception instead of traceback
2008-03-01T13:10:48  <ThomasWaldmann> if that works ok (see log), feel free to change all of them
2008-03-01T13:11:15  <johill> yes it looks good in my log
2008-03-01T13:11:20  <johill> and now I fixed the bug that caused it :)
2008-03-01T13:13:34  <johill> it looks like this:
2008-03-01T13:13:35  <johill> 2008-03-01 13:09:02,014 MoinMoin.Page ERROR pagelinks formatter failed, traceback follows
2008-03-01T13:13:39  <johill> Traceback (most recent call last):
2008-03-01T13:13:41  <johill> [...]
2008-03-01T13:14:07  <ThomasWaldmann> cb22: the theme.msg could need some refactoring. also, some calls call it with "...<br>", but that maybe is rather superfluous as any msg gets into an own <p> anyway
2008-03-01T13:15:08  <johill> yeah, true, bu I only wanted to fix the glaringly obvious bug ;)
2008-03-01T13:15:34  <johill> ThomasWaldmann: don't have time right now to check all of the isntances, have to run. maybe on monday
2008-03-01T13:15:45  <johill> just wanted to quickly make sure my wiki isn't bugging out :)
2008-03-01T13:16:00  <ThomasWaldmann> i can have a look now
2008-03-01T14:46:49  <xorAxAx> ThomasWaldmann: the application looks fine, i added a question. so we mainly need to seek project ideas and mentor's account info
2008-03-01T14:47:23  <xorAxAx> from johill and TheSheep
2008-03-01T14:47:37  <xorAxAx> please hand your google account handle to ThomasWaldmann or me :)
2008-03-01T14:51:56  <xorAxAx> johill: any idea regarding the dispatch etc. stuff idea i put onto the soc ideas page?
2008-03-01T14:57:32  <johill> dispatch?
2008-03-01T14:57:44  <johill> my google account is jo.m.berg@gmail.com?
2008-03-01T14:57:56  <xorAxAx> was that a question? :)
2008-03-01T14:58:24  <xorAxAx> johill: well, there is only one task that includes the word "dispatch"
2008-03-01T15:02:28  <johill> well no I'm just not sure whether that's the handle you need ;)
2008-03-01T15:02:30  <johill> I have that account
2008-03-01T15:03:40  <johill> xorAxAx: ok gotcha
2008-03-01T15:03:54  <johill> that description looks ok and right now I don't have any more ideas
2008-03-01T15:06:58  <xorAxAx> ok
2008-03-01T15:07:36  <xorAxAx> its mainly a bit superficial because it involves design and i think we dont have any page on the wiki that already does something into that direction
2008-03-01T15:11:00  <johill> true
2008-03-01T16:32:30  <ThomasWaldmann> xorAxAx: for the dom based parser, did you look at sheep's creole parser?
2008-03-01T16:41:35  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3156:1508feb6dbbf 1.7/MoinMoin/ (auth/ldap_login.py auth/mysql_group.py failure.py): logging: use logging.exception
2008-03-01T16:50:04  <ThomasWaldmann> grzybacz: could you do (and test) the logging changes for the jabber bot also?
2008-03-01T17:10:37  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3157:b8cb12fa571b 1.7/MoinMoin/ (config/multiconfig.py xmlrpc/RemoteScript.py): logging: using more logging.exception
2008-03-01T18:32:27  <xorAxAx> ThomasWaldmann: no, but the point is that needs to be done more than a parser rewrite
2008-03-01T18:32:34  <xorAxAx> and this "more" should be done first
2008-03-01T19:03:08  <ThomasWaldmann> xorAxAx: the creole parser already has an emitter. we could check if it is usable for wiki, too.
2008-03-01T19:04:49  <xorAxAx> thats not very helpful compared to the full goal
2008-03-01T19:04:57  <xorAxAx> of course its a starting point
2008-03-01T19:36:40  <ThomasWaldmann> xorAxAx: at least it could fix lists and p generation
2008-03-01T19:36:57  <ThomasWaldmann> and enable us to write sane tests
2008-03-01T19:39:00  <ThomasWaldmann> wow, *moinmo* sites have 24GB Traffic per 4 weeks
2008-03-01T19:39:29  <ThomasWaldmann> (not including static.moinmo.in)
2008-03-01T20:02:23  <ThomasWaldmann> TheSheep: you already have a google account?
2008-03-01T20:15:31  <ThomasWaldmann> (you need one for the google apps, including the gsoc app)
2008-03-01T20:20:38  <TheSheep> ThomasWaldmann: radomir.dopieralski@gmail.com
2008-03-01T20:24:30  * ThomasWaldmann added it to the application page
2008-03-01T20:29:29  <TheSheep> now they can check allm y mails and see if I'm elligible? ;)
2008-03-01T20:33:18  <ThomasWaldmann> if you ever said something positive about MS, they won't take you :D
2008-03-01T20:35:27  <TheSheep> no worries
2008-03-01T21:39:31  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3158:3ea8d2e4af32 1.7/MoinMoin/formatter/text_docbook.py: minor whitespace fix
2008-03-01T22:24:52  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3159:915a431b663c 1.7/MoinMoin/ (3 files in 2 dirs): logging: security package refactored, moved frozenset to python_compatibility
2008-03-01T22:56:06  <CIA-38> Thomas Waldmann <tw AT waldmann-edv DOT de> default * 3160:eeb27d88d39b 1.7/MoinMoin/mail/sendmail.py: logging: better logging for sendmail module