MoinMoin: MoinMoinChat/Logs/moin-dev/2007-12-08

2007-12-08T02:43:39  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2401:0821cb6d5d26 1.6/MoinMoin/ (formatter/__init__.py parser/text_moin_wiki.py): wiki parser: fix end of parser/pre section detection for indented stuff, fix empty lines at beginning of rendered parser sections
2007-12-08T03:40:32  <starGaming> If someone is still awake, I'd really appreciate a review for task #70.
2007-12-08T03:40:44  <starGaming> http://code.google.com/p/google-highly-open-participation-moinmoin/issues/detail?id=70
2007-12-08T04:00:01  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2402:38892aa385be 1.6/MoinMoin/i18n/ (9 files): updated i18n
2007-12-08T04:05:44  <ThomasWaldmann> too late here for reviews (and jabber stuff is better done by karol)
2007-12-08T06:58:16  <Mitsaras> Should i ask a question about request objects here or on the other channel
2007-12-08T06:58:18  <Mitsaras> ?
2007-12-08T08:54:49  <dreimark> moin
2007-12-08T09:05:54  <ThomasWaldmann> moin
2007-12-08T09:06:21  <dreimark> ThomasWaldmann: I think we don't need to import macro in text_moin_wiki
2007-12-08T09:08:46  <ThomasWaldmann> it is used in _macro_repl()
2007-12-08T09:11:13  <dreimark> oops, i missed that
2007-12-08T09:12:18  <ThomasWaldmann> btw, i want to do some beta3/rc1 this weekend
2007-12-08T09:12:29  <dreimark> I know
2007-12-08T09:13:28  <ThomasWaldmann> rc1 rather
2007-12-08T09:14:23  <dreimark> how should we handle the ghop code then  ?
2007-12-08T09:15:10  <ThomasWaldmann> trivial bug fixes are ok, but not enhancements any more
2007-12-08T09:15:20  <dreimark> :)
2007-12-08T09:16:49  <ThomasWaldmann> new code can be committed to 1.7
2007-12-08T09:18:00  <ThomasWaldmann> s/this weekend/until sunday noon/
2007-12-08T09:19:51  * ThomasWaldmann hopes that the parser stuff works now for all cases
2007-12-08T09:20:25  <dreimark> did you have cleaned the page cache - its easier to review pages
2007-12-08T09:24:40  <dreimark> shebang in i18n.__init__ calling python2.4
2007-12-08T09:25:51  <ThomasWaldmann> no i didnt
2007-12-08T09:27:31  <ThomasWaldmann> shebang can be removed completely
2007-12-08T09:29:22  <ThomasWaldmann> btw, that None error is maybe caused by a missing or too late call to i18n_init
2007-12-08T09:49:16  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> default * 2403:259d24ac0068 1.6/MoinMoin/i18n/__init__.py: i18n.__init__: shebang removed
2007-12-08T09:50:33  <ninnnu> ...and so my patch for that file (made because of #59...) got outdated... I guess
2007-12-08T09:54:46  <dreimark> ninnnu: why?
2007-12-08T09:58:39  <ninnnu> dreimark: Because it is/was meant for the older i18n/__init__.py? (Well, I don't know how those diff-files exactly work and so on, but...)
2007-12-08T09:59:44  <dreimark> ninnnu: thats no problem see http://hg.moinmo.in/moin/1.6/rev/259d24ac0068
2007-12-08T09:59:52  <dreimark> thats an easy merge
2007-12-08T10:00:04  <dreimark> you dont need to add a new patch
2007-12-08T10:00:16  <ninnnu> Ok
2007-12-08T10:31:07  <cb22> moin
2007-12-08T10:32:54  <dreimark> moin cb22
2007-12-08T10:33:46  <dreimark> if there is no new page added to a wiki and one calls export package from the commandline
2007-12-08T10:34:31  <dreimark> it should not fail with a traceback
2007-12-08T10:36:43  <cb22> dreimark, it fails with 'raise ActionError(self.makeform(_('No pages like "%s"!', formatted=False) % wikiutil.escape(pagelist)))' correct?
2007-12-08T10:36:46  <cb22> i'll fix that now
2007-12-08T10:38:18  <dreimark> yep
2007-12-08T10:40:14  <dreimark> and probably add some more tests
2007-12-08T10:43:02  <cb22> hmm, some more tests?
2007-12-08T10:43:21  <cb22> what should i test
2007-12-08T10:43:38  <dreimark> I did some tests manual
2007-12-08T10:43:40  <cb22> (btw the tests i already did weree in a seperate patch)
2007-12-08T10:44:15  <cb22> ah, like creating a package with nothing in it?
2007-12-08T10:44:20  <dreimark> yeah
2007-12-08T10:47:57  <dreimark> ThomasWaldmann: MoinMoinBugs/cli_no_lang initialize request
2007-12-08T10:50:32  <ThomasWaldmann> gtg/bbl
2007-12-08T10:55:05  <dreimark> ninnnu: do you use mercurial (hg) ?
2007-12-08T10:59:34  <cb22> dreimark, ok sorted out the exception issue, and added a new test to test an invalid create, also edited the test that tries and packages everything to skip with a message if there are no pages created.
2007-12-08T11:00:21  <dreimark> cb22: will look at it soon
2007-12-08T11:00:33  <cb22> ok, putting it up
2007-12-08T11:00:44  <dreimark> ninnnu: language_ignore_browser is a config var - please don't kill it
2007-12-08T11:01:45  <dreimark> sorry - I should read all
2007-12-08T11:08:15  <dreimark> ninnnu: did you have modified languages.py or is it new
2007-12-08T11:08:41  <dreimark> I am asking because of the header and I can't find it
2007-12-08T11:19:08  <starGaming> http://moinmo.in/MoinMoinChat/Logs/moin-dev/2007-12-07 < huh?
2007-12-08T11:20:07  <ninnnu> dreimark: I modified it...
2007-12-08T11:21:35  <ninnnu> dreimark: Er... I just fetch the newest sources from there (hg clone), and generate diffs with hg diffs, that's quite much it...
2007-12-08T11:21:46  <dreimark> ThomasWaldmann: please can you check the crontab for importing the dev logs
2007-12-08T11:22:23  <dreimark> ninnnu: languages.py was not shown as diff
2007-12-08T11:22:34  <ninnnu> dreimark: Because languages.py was totally new file?
2007-12-08T11:23:09  <dreimark> then copyright is wrong
2007-12-08T11:23:16  <dreimark> ;)
2007-12-08T11:23:37  <ninnnu> But I used userbrowsers.py (or something) as a template
2007-12-08T11:23:47  <dreimark> then write it there
2007-12-08T11:28:40  <dreimark> cb22: currently you do create attachment dirs on the wrong place
2007-12-08T11:28:45  <dreimark> check wiki/data/pages
2007-12-08T11:28:57  <dreimark> you will find an attachments dir
2007-12-08T11:30:10  <xorAxAx> starGaming: ask ThomasWaldmann
2007-12-08T11:32:39  <rafael> should i make support for http://www.xmpp.org/extensions/xep-0054.html too?
2007-12-08T11:36:06  <dreimark> bbl
2007-12-08T11:37:56  <xorAxAx> rafael: hmm,can you already generate vcards?
2007-12-08T11:38:31  <rafael> xorAxAx: i don't need to generate them.. i just parse them with vobject and put them out as table
2007-12-08T11:40:18  <xorAxAx> rafael: you want to fetch vcards via jabber?
2007-12-08T11:40:23  <xorAxAx> what would be the point?
2007-12-08T11:41:35  <rafael> xorAxAx: no, there is a special vcard format for jabber.. (in XML) that could be supported, too
2007-12-08T11:43:27  <xorAxAx> rafael: but you will never see it on disk, only in the air
2007-12-08T11:43:47  <rafael> hm, that's right
2007-12-08T11:43:59  <rafael> but gajim saves them in files
2007-12-08T11:59:57  <ThomasWaldmann> re
2007-12-08T12:05:21  <rafael> so any suggestions what i can use to parse the hcard html? or can i take an external lib like html5lib/beautifulsoup
2007-12-08T12:06:25  <ThomasWaldmann> if possible, use stdlib stuff
2007-12-08T12:09:04  <ThomasWaldmann> if it is xhtml for sure, you can use a xml parser
2007-12-08T12:16:16  <starGaming> BTW, if anyone has got some free time I'd appreciate reviews for GHOP task #70 http://code.google.com/p/google-highly-open-participation-moinmoin/issues/detail?id=70
2007-12-08T12:17:34  <xorAxAx> starGaming: i will have a look at it today
2007-12-08T14:29:51  <ernestas> I have one question about "thinking aloud" task: should the person who will be testing moinmoin install it on his own computer or should he perform tasks in moinmo.in?
2007-12-08T14:34:12  <xorAxAx> ernestas: i think both is fine
2007-12-08T14:34:38  <ernestas> one of these would be enough?
2007-12-08T14:34:51  <xorAxAx> yes
2007-12-08T14:34:55  <ernestas> ok
2007-12-08T14:37:24  <ThomasWaldmann> ffesti: how about ffesti@shell.moinmo.in?
2007-12-08T14:59:33  <twaldmann>  /server chat.freenode.net 8000      <- works on shell.moinmo.in
2007-12-08T15:12:42  <xorAxAx> of course ..
2007-12-08T15:12:45  <ernestas> Should I give you everything the person has said or should I just summarize everything.
2007-12-08T15:13:41  <ernestas> the question is about "thinking aloud" task
2007-12-08T15:14:01  <xorAxAx> summarize and analyse it in the first place, but maybe you also want to see how others are doing it (see google or a good book about it)
2007-12-08T15:14:49  <ernestas> ok, I'll try to find out about that
2007-12-08T15:49:14  <ernestas> I get "500 - Internal Server Error" when I try to create an account in moinmo.in
2007-12-08T15:52:13  <xorAxAx> ThomasWaldmann:
2007-12-08T15:55:48  <ThomasWaldmann> ernestas: is that reproduceable?
2007-12-08T15:56:01  <ernestas> wait a sec
2007-12-08T15:56:44  <ernestas> yes, it is
2007-12-08T15:57:20  <ernestas> maybe because of my quite strong password?
2007-12-08T15:57:58  <ernestas> well, I can simplify it
2007-12-08T15:58:41  <ThomasWaldmann> account creation worked for me
2007-12-08T15:58:52  <ThomasWaldmann> what username did you use?
2007-12-08T15:59:18  <ernestas> yes, seems my strong password was causing the problem
2007-12-08T15:59:29  <ernestas> I made a simple one and it worked
2007-12-08T15:59:36  <ernestas> ErnestasLiubarskij
2007-12-08T15:59:42  <ernestas> is my username
2007-12-08T15:59:42  <ThomasWaldmann> is it non-ascii?
2007-12-08T15:59:56  <ernestas> it contains | \ /
2007-12-08T16:00:08  <ThomasWaldmann> that should be no problem
2007-12-08T16:00:23  <ernestas> wait a sec, I'll try again
2007-12-08T16:03:28  <ernestas> Hm, it worked with another username and the previos password
2007-12-08T16:03:34  <ernestas> *previous
2007-12-08T16:04:17  <ThomasWaldmann> argh, those bloody bots spider the calendars
2007-12-08T16:04:36  <ernestas> if you could delete my account, I could try again
2007-12-08T16:05:00  <ernestas> because it was really reproducible.
2007-12-08T16:06:20  <ernestas> well, but if it's so rare, then just never mind
2007-12-08T16:08:33  <ernestas> 500 - Internal Server Error
2007-12-08T16:08:41  <ernestas> I've tryed to change my password
2007-12-08T16:08:45  <xorAxAx> ernestas: its more likely that it was temporary
2007-12-08T16:09:00  <ernestas> ok, I'll leave it as it is then..
2007-12-08T16:11:38  <ernestas> This is the password I've been trying to change to: |\/|99b5Uy5
2007-12-08T16:12:10  <ernestas> I get error 500 when I try to do that
2007-12-08T16:12:52  <ernestas> I've tried with another similar password. It displays error 500 again.
2007-12-08T16:16:19  <ernestas> seems that my passwords are too strong for moinmoin ;)
2007-12-08T16:16:39  <johill> got a local setup where you could reproduce to get a better error message?
2007-12-08T16:16:45  <johill> I'm working on other stuff right now
2007-12-08T16:17:30  <ernestas> sorry, I don't have moinmoin istalled now. But it's not so criticall, so you can try to figure out what's wrong later
2007-12-08T16:18:18  <johill> maybe you can file a bug report anyway, if not I'll surely forget it
2007-12-08T16:18:39  <ernestas> ok
2007-12-08T16:19:15  * ThomasWaldmann looked in the error logs, but didnt find anything useful yet
2007-12-08T16:35:41  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2404:2ad3c563815c 1.6/MoinMoin/macro/MonthCalendar.py: MonthCalendar: added some rel=nofollow so that at least some well-behaved bots won't read the calendar forever
2007-12-08T16:35:43  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2405:b747be315718 1.6/MoinMoin/config/multiconfig.py: added yeti to ua_spiders bot list
2007-12-08T16:35:44  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2406:f794d47559ce 1.6/MoinMoin/i18n/__init__.py: merged main
2007-12-08T16:58:21  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2407:fea66d67e2da 1.6/MoinMoin/Page.py: do not send any 404 content to bots
2007-12-08T17:00:54  <ThomasWaldmann> (that saved some GB traffic)
2007-12-08T17:41:33  <ernestas> How many tasks should I give ("thinking aloud" task)? How difficult should they be?
2007-12-08T18:04:39  <TheSheep> ThomasWaldmann: lol
2007-12-08T18:06:23  <xorAxAx> so bots wont see calendar pages anymore?
2007-12-08T18:17:44  <ThomasWaldmann> xorAxAx: the problem is not solved, only some traffic reduced
2007-12-08T18:18:00  <xorAxAx> ?
2007-12-08T18:18:52  <ThomasWaldmann> it has rel=nofollow now on the calendar nav, but of course that does not help against bad bots
2007-12-08T18:19:11  <ThomasWaldmann> so i guess i'll add some shortcut like in misc other macros
2007-12-08T18:19:22  <xorAxAx> and it will let even less pages show up in google for sites that use the calendar heavily
2007-12-08T18:20:05  <ThomasWaldmann> well, one can't have everything
2007-12-08T18:20:25  <xorAxAx> sure, in this case its rather easy
2007-12-08T18:20:37  <ThomasWaldmann> the problem is that currently the bots do not terminate reading the cal
2007-12-08T18:21:05  <ThomasWaldmann> we could show the current month and the next and no more
2007-12-08T18:21:05  <xorAxAx> e.g. generate nofollow only if the date is pretty old and the selected month doesnt contain any entries
2007-12-08T18:21:25  <xorAxAx> (or pretty new)
2007-12-08T18:21:33  <xorAxAx> where pretty could be as much as +- 6 months
2007-12-08T18:22:26  <ThomasWaldmann> why show old stuff? it either already got indexed or is useless anyway
2007-12-08T18:25:58  <xorAxAx> imagine a birthday calendar ...
2007-12-08T18:26:05  <xorAxAx> or something like that :)
2007-12-08T18:26:35  <xorAxAx> also, those calendarpages have links into the wiki
2007-12-08T18:26:51  <xorAxAx> and generally, they are important (at least in the wiki where i am using the calendar)
2007-12-08T18:29:40  <ThomasWaldmann> i added rel=nofollow for nonexisting daypages
2007-12-08T18:30:00  <xorAxAx> ah
2007-12-08T18:30:11  <xorAxAx> but then the bot still navigates to the last/next month
2007-12-08T18:34:17  <ThomasWaldmann> if will show nofollow if the year is not current
2007-12-08T18:34:32  <ThomasWaldmann> that means year-1, year, year+1 will be reached
2007-12-08T18:35:14  <ThomasWaldmann> the problems are bot not following those rules
2007-12-08T18:35:41  <xorAxAx> why arent they caught by surge protection?
2007-12-08T18:36:08  <ThomasWaldmann> that yeti sucker does 1 request per 20s
2007-12-08T18:37:47  <ThomasWaldmann> i think I won't show anything for isspider and |year-currentyear|>1
2007-12-08T20:10:25  <dreimark> moin
2007-12-08T20:11:44  <rafael> ahoi dreimark
2007-12-08T20:14:43  <ninnnu> Moin
2007-12-08T20:20:36  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2408:1be42ebf3fc3 1.6/MoinMoin/macro/MonthCalendar.py: MonthCalendar: avoid even bad behaved bots reading more than current year +/- 1 in the calendar, rel=nofollow for links to nonexisting day pages
2007-12-08T20:20:37  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2409:78021d9cb020 1.6/MoinMoin/config/multiconfig.py: added more user agents to the spider list
2007-12-08T21:45:09  <ernestas> I have made "thinking aloud" task with one person. Tomorrow I will work with another one.
2007-12-08T21:45:30  <ernestas> And next week I will provide the results
2007-12-08T21:50:53  <starGaming> xorAxAx, already had a look on #70? :)
2007-12-08T21:51:36  <xorAxAx> no, still on my todoliste, though :)
2007-12-08T21:51:39  <xorAxAx> -e
2007-12-08T22:07:15  <cb22> dreimark, re attachment folder, afaik it is the right place
2007-12-08T22:08:03  <dreimark> cb22: hi
2007-12-08T22:09:07  <dreimark> there is one attachment dir created in the root folder of data and not below a page
2007-12-08T22:09:19  <cb22> yes
2007-12-08T22:11:43  <cb22> must it go in the root one? i thought it belongs in the page one
2007-12-08T22:12:48  * xorAxAx reviews starGamings code
2007-12-08T22:14:24  <dreimark> cb22: no it is wrong to create it.
2007-12-08T22:15:10  <dreimark> it's not a page
2007-12-08T22:16:02  <dreimark> a valid attachments dir is created below the folder of a page
2007-12-08T22:16:25  <xorAxAx> starGaming: very nice!
2007-12-08T22:16:44  <xorAxAx> starGaming: in moin, we have a module that collects compatiblity code. can you move your hashlib stuff there and generate a diff?
2007-12-08T22:17:43  <cb22> dreimark: ah, ok i'll fix that
2007-12-08T22:17:48  <cb22> thats how it was in the original code
2007-12-08T22:18:13  <dreimark> then you have found a bug, thanks for fixing it :)
2007-12-08T22:19:06  <starGaming> xorAxAx, ah I see, MoinMoin.support.python_compatibility -- give me a second.
2007-12-08T22:21:23  <xorAxAx> ?
2007-12-08T22:21:28  <xorAxAx> the original code handled it fine
2007-12-08T22:22:18  <cb22> xorAxAx @ dreimark + me?
2007-12-08T22:22:40  <dreimark> no at me
2007-12-08T22:23:36  <dreimark> because attachment weren't used
2007-12-08T22:23:43  <rafael> hm i'm thinking about a nice way to present hcards.. a table or just a css for the html..
2007-12-08T22:24:10  <xorAxAx> cb22: hmm?
2007-12-08T22:24:31  <cb22> rafael: tables tend to have a stigma around them, but for data they are perfect
2007-12-08T22:24:36  <cb22> just not for layout :)
2007-12-08T22:24:42  <xorAxAx> rafael: have a look at how other webapps do it :)
2007-12-08T22:24:45  <xorAxAx> rafael: design wise
2007-12-08T22:25:04  * cb22 thinks a ajax moin would be nice :)
2007-12-08T22:25:36  <rafael> xorAxAx: for example? i don't now any
2007-12-08T22:26:54  <ThomasWaldmann> dreimark: your bugcheck fails because you mix up 2 methods
2007-12-08T22:27:15  <ThomasWaldmann> it is either more {{{{{{{ xor {{{something, not both
2007-12-08T22:27:35  <rafael> if i put it in a table i must leave out the things you can put around the data
2007-12-08T22:28:12  <dreimark> ThomasWaldmann: ok,
2007-12-08T22:30:36  <dreimark> do you've seen the fix for http://moinmo.in/MoinMoinBugs/cli_no_lang too
2007-12-08T22:30:46  <xorAxAx> rafael: let me think
2007-12-08T22:31:05  <starGaming> xorAxAx, changed.
2007-12-08T22:31:14  <dreimark> ninnnu: I do need some help
2007-12-08T22:32:21  <ninnnu> dreimark: Yes?
2007-12-08T22:33:26  <dreimark> I have applied your patch on my local moin-1.6
2007-12-08T22:34:06  <dreimark> ninnnu: do I need languages.py and how do you call it
2007-12-08T22:34:27  <dreimark> if it is a macro it has no execute
2007-12-08T22:34:31  <ninnnu> dreimark: The patch is practically useless if you don't have languages.py
2007-12-08T22:35:10  <dreimark> ok, what did I have to do with this file, where to store
2007-12-08T22:35:14  <ninnnu> And it's called by <<StatsChart()>>
2007-12-08T22:35:27  <ninnnu> MoinMoin/stats/
2007-12-08T22:35:38  <xorAxAx> ninnnu: did you see my new comment?
2007-12-08T22:35:47  <ninnnu> xorAxAx: Yes, and replied
2007-12-08T22:36:13  <ninnnu> linkto is needed by StatsChart, I thought that it would be logical to make languages.py work like useragents.py and hitcounts.py...
2007-12-08T22:37:37  <xorAxAx> ninnnu: cant see any reply
2007-12-08T22:37:56  <xorAxAx> in my inbox ...
2007-12-08T22:37:58  <xorAxAx> google is slow
2007-12-08T22:38:01  <ninnnu> http://code.google.com/p/google-highly-open-participation-moinmoin/issues/detail?id=59&q=label:Code&colspec=ID%20Status%20ClaimedBy%20Summary#c16
2007-12-08T22:38:14  <xorAxAx> yes
2007-12-08T22:38:22  <xorAxAx> ninnnu: but where does the text name in linkto come from?
2007-12-08T22:38:36  <xorAxAx> ah, thats the function name
2007-12-08T22:38:41  <xorAxAx> can you please rename the function?
2007-12-08T22:39:06  <ninnnu> Can't
2007-12-08T22:39:54  <xorAxAx> hmm?
2007-12-08T22:39:55  <ninnnu> Again, it's called by <<StatsChart()>>...
2007-12-08T22:40:00  <xorAxAx> i mean the text function :)
2007-12-08T22:40:02  <xorAxAx> not linkto
2007-12-08T22:40:07  <ninnnu> Oh, that one..
2007-12-08T22:45:34  <rafael> xorAxAx: finished thinking?
2007-12-08T22:46:52  <xorAxAx> rafael: yes, cant think of any
2007-12-08T22:46:57  <xorAxAx> rafael: maybe chandler
2007-12-08T22:47:01  <MrBawb> Hello, I'm here on behalf of the fedora wiki.  Running moin-1.5.8, and we've had some speed problems related to finding the subscribers of a page.  Toshio Kuratomi did most of the work, and I have a page detailing the problem and possible solutions at: http://dan.drown.org/fedora/compare-storage.html
2007-12-08T22:47:05  <xorAxAx> but the chandler hub doesnt want to give me an account
2007-12-08T22:47:57  <MrBawb> I welcome any comments or critisim on it
2007-12-08T22:48:03  <xorAxAx> starGaming: ok, looks nice
2007-12-08T22:48:18  <MrBawb> and I'd like to know what to do to get this into your offical tree
2007-12-08T22:48:25  <starGaming> Thank you :)
2007-12-08T22:48:26  <xorAxAx> starGaming: i think i let karol commit the code but close the ticket now
2007-12-08T22:48:32  <xorAxAx> so you are finished
2007-12-08T22:49:16  <ninnnu> xorAxAx: Renamed version sent
2007-12-08T22:50:44  <xorAxAx> ninnnu: ok, fine
2007-12-08T22:51:00  <starGaming> Great. :) Perhaps I'll start working on the second/third part (veerz didn't show any further interest in them)
2007-12-08T22:51:02  <xorAxAx> ninnnu: let dreimark test it and if he doesnt find any issue, it can be closed IMHO
2007-12-08T22:51:07  <xorAxAx> starGaming: ok
2007-12-08T22:51:38  <ninnnu> xorAxAx: Great, thanks
2007-12-08T22:51:48  <dreimark> MrBawb: you have mixed tabs and blanks
2007-12-08T22:52:06  <MrBawb> dreimark: ok, I can fix that
2007-12-08T22:53:17  <xorAxAx> MrBawb: code is not PEP8 compliant
2007-12-08T22:53:28  <xorAxAx> wrt naming of methods, modules and functions
2007-12-08T22:53:58  <MrBawb> xorAxAx: ok, I'll go look up what PEP8 wants
2007-12-08T22:54:32  <xorAxAx> hmm, the locking uses fnctl locking which will fail on nfs
2007-12-08T22:54:37  <xorAxAx> but the fedora wiki is using nfs
2007-12-08T22:54:47  <xorAxAx> hmm, no, they tried but arent, indeed
2007-12-08T22:54:55  <xorAxAx> (and its not working on windows ...)
2007-12-08T22:55:04  <dreimark> ninnnu: if we have no real users on a wiki then only browser language could/is counted ?
2007-12-08T22:55:12  <xorAxAx> moin has already a locking system, its not using fnctl, though
2007-12-08T22:55:36  <cb22> dreimark: are there any other issues with my pach btw?
2007-12-08T22:55:59  <MrBawb> xorAxAx: do you have any pointers to where I should look in the code for the existing locking system?
2007-12-08T22:56:16  <xorAxAx> MrBawb: MoinMoin.util.lock* or something like that
2007-12-08T22:56:22  <dreimark> cb22: not now, I will do a final test later
2007-12-08T22:56:26  <MrBawb> ok
2007-12-08T22:56:48  <dreimark> cb22: I think we can close this task afterwards
2007-12-08T22:56:50  <MrBawb> I can switch to using an internal locking system pretty easy
2007-12-08T22:56:51  <cb22> ok, and thanks for looking at it so many times already dreimark :)
2007-12-08T22:57:06  <ninnnu> dreimark: Well... Umh... I guess that the code crashes on that point (divide by zero)... Visitors are ignored
2007-12-08T22:57:15  <xorAxAx> the claim rate has dropped down, we need to do more advertising :)
2007-12-08T22:57:38  <cb22> the same to xorAxAx and ThomasWaldmann, thanks for taking the time to review stuff :)
2007-12-08T22:58:00  <xorAxAx> cb22: no problem ... we will send the invoice at the end :)
2007-12-08T22:58:16  <xorAxAx> ( i guess thats how it works at the ASF :))
2007-12-08T22:59:23  * xorAxAx sends out some adverts now that we handled the initial student load
2007-12-08T22:59:37  <ninnnu> dreimark: No, the code returns ~empty table (only header) if there are no users. Should I make it to return "Browser setting - 100%" if there is no users?
2007-12-08T23:00:47  <dreimark> ninnnu: if the table is empty you should add a line to explain it
2007-12-08T23:01:58  * dreimark creates users on the testwiki now
2007-12-08T23:05:55  <dreimark> ninnnu: it would be nice if you tell how much users are 100%
2007-12-08T23:07:47  <ninnnu> I used to have that piece of code, but I didn't find any already-translated string for "Amount" or something similar.
2007-12-08T23:10:48  <dreimark> ninnnu: many ways possible: e.g. a column User
2007-12-08T23:11:20  <dreimark> so one knows "We do have 3 times Danish"
2007-12-08T23:17:17  <dreimark> ninnnu: I am not sure now if we should use the english name of a language
2007-12-08T23:17:34  <dreimark> opinions xorAxAx ?
2007-12-08T23:17:59  <dreimark> e.g. if you use hebrew only then this word is then alone in english
2007-12-08T23:19:16  <starshine> s/then this word is the only one in English/
2007-12-08T23:19:33  <dreimark> starshine: :) thanks
2007-12-08T23:19:51  <starshine> np
2007-12-08T23:20:24  <ninnnu> dreimark: I asked about the opinion here earlier, another possibility would be using a) using the ISO-code (en, fi, de etc) b) the language's native name... Or then give lots of new jobs to translators
2007-12-08T23:22:24  <dreimark> ninnnu: Hmm, the language native name is already used in UserPreferences
2007-12-08T23:22:24  <ThomasWaldmann> dreimark: as I have no time to review all scripts now, I suggest you do a local fix to fix the problem, not one in the base class
2007-12-08T23:22:58  <ThomasWaldmann> (put some comment into the base class, though, so we can do that later)
2007-12-08T23:23:05  <dreimark> ok
2007-12-08T23:27:03  <xorAxAx> dreimark: its the only possibility to make the macro usable
2007-12-08T23:27:22  <ninnnu> dreimark: Well, should I change it to the language's own native name, then?
2007-12-08T23:27:29  <xorAxAx> dreimark: or can you speak all 30 languages moin supports and know what the language means in the particular language?
2007-12-08T23:27:33  <xorAxAx> ninnnu: NO!
2007-12-08T23:27:45  <ninnnu> xorAxAx: Well, that's what I think, too...
2007-12-08T23:27:53  <xorAxAx> we dont have language translations :)
2007-12-08T23:28:04  <xorAxAx> ninnnu: dont do things that are obviously stupid :)
2007-12-08T23:28:26  <ninnnu> xorAxAx: Of course not, first I ask permissions to do them :)
2007-12-08T23:29:25  <dreimark> hehe, you are right that was stupid
2007-12-08T23:30:52  <ninnnu> So we keep the current way?
2007-12-08T23:31:05  <dreimark> ninnnu: yes !
2007-12-08T23:32:24  <dreimark> Can you add a user counter column?
2007-12-08T23:33:14  <ninnnu> Well, I tried it... Singular-form of "User" just looks stupid
2007-12-08T23:33:58  <ninnnu> Now I'm trying to build something that shows the count as "12,34% (<the amount of users>)"
2007-12-08T23:34:11  <xorAxAx> nice
2007-12-08T23:34:40  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> default * 2410:d32153d7ba6a 1.6/MoinMoin/script/__init__.py: script.__init__: ToDo added
2007-12-08T23:34:45  <dreimark> :)
2007-12-08T23:34:52  <ninnnu> Is that ok?
2007-12-08T23:34:58  <dreimark> yes
2007-12-08T23:35:04  <xorAxAx> no, use a point instead of a comma, ninnnu
2007-12-08T23:35:14  <xorAxAx> otherwise americans wont understand it
2007-12-08T23:35:46  <dreimark> thats true
2007-12-08T23:35:59  <ninnnu> Well, that wasn't really the point of the question...
2007-12-08T23:36:18  <ninnnu> I'm not changing the way of showing the percent, just adding stuff behind it
2007-12-08T23:39:13  <dreimark> ninnnu: It is not necessary to add a column you can add text too
2007-12-08T23:39:31  <ninnnu> dreimark: Yeah, that's what I'm doing..
2007-12-08T23:39:51  <ninnnu> It just refuses to work... "unsupported operand type(s) for %: 'NoneType' and 'dict'"
2007-12-08T23:40:04  <ninnnu> For code:                     languages.addRow((lang, "%(percent).2f (%(count)s)")) % {
2007-12-08T23:40:08  <ninnnu>                         'percent': 100.0 * cnt / sum,
2007-12-08T23:40:10  <ninnnu>                         'count': cnt}
2007-12-08T23:40:17  <ninnnu> (especially the last line)
2007-12-08T23:40:27  <ninnnu> What I'm doing wrong there?
2007-12-08T23:40:56  <xorAxAx> ninnnu: a parenthesis is at the wrong spot
2007-12-08T23:41:13  <xorAxAx> there needs to be at least one at the end of the statement (and one other removed)
2007-12-08T23:41:56  <dreimark> languages.addRow(......)
2007-12-08T23:45:29  <ninnnu> So it didn't work same way as elsewhere with _()...
2007-12-08T23:45:49  <xorAxAx> its always the same
2007-12-08T23:46:18  <xorAxAx> % should be applied to the string and not to the function call's result, though
2007-12-08T23:46:57  <ninnnu> userform.py, line 699, unless I've read something wrong (for some reason I've been doing that a lot lately...)
2007-12-08T23:51:55  <ninnnu> Updated file sent
2007-12-08T23:52:04  <ninnnu> Sleep, good night ->
2007-12-08T23:52:13  <dreimark> sleep well ninnnu
2007-12-08T23:52:15  <dreimark> gn