MoinMoin: MoinMoinChat/Logs/moin-dev/2007-10-21

2007-10-21T08:26:18  <dreimark> moin
2007-10-21T08:26:22  <dreimark> ThomasWaldmann:
2007-10-21T08:27:07  <dreimark> membergroups has only underlay pages in the dict
2007-10-21T09:08:42  <dreimark> I dont know where that code is used currently
2007-10-21T09:08:54  <dreimark> I do want to change it to http://paste.pocoo.org/show/6923/
2007-10-21T09:53:36  <dreimark> SystemPagesGroup - why second level for SystemPagesInIndonesianGroup and SystemPagesInKurdishGroup ?
2007-10-21T10:11:05  <dreimark> test.wikiutil.testSystemPagesGroupNotEmpty fails for me in a fresh clone
2007-10-21T10:11:15  <dreimark> do fix now the PEP 8 failures
2007-10-21T10:15:16  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> default * 2894:f009ead62bfd 1.7/MoinMoin/request/ (__init__.py _tests/test_request.py): PEP8 fixes
2007-10-21T10:16:21  <dreimark> _tests/test_caching.py not changed (looks not wrong to me)
2007-10-21T10:19:49  <dreimark> test_data = {1:2, 2:3, 3: [4, 5, ], } source tester tells E231 missing whitespace after ':'
2007-10-21T10:21:33  <ThomasWaldmann> sure
2007-10-21T10:21:49  <ThomasWaldmann> the first 2 items
2007-10-21T10:22:06  * ThomasWaldmann tries to fix i18n loading currently
2007-10-21T10:23:06  <ThomasWaldmann> some strings take forever, supposedly by some recursion
2007-10-21T10:30:05  <dreimark> ThomasWaldmann: Do you see a failing test in test_wikiutil too?
2007-10-21T10:36:28  <ThomasWaldmann> 4 failures, including 1 wikiutil and one still-not-fixed getval
2007-10-21T10:37:14  <dreimark> argh I dont get this getval failure (really)
2007-10-21T10:38:41  <dreimark> I dont get if that GroupDict class has ever worked or how it should work.
2007-10-21T10:39:29  <ThomasWaldmann> check if the functionality you are trying to use is used at other places in moin
2007-10-21T10:40:46  <dreimark> for that test in members it needs to be group = self.groupdict[groupname] and not group = self.dictdict[groupname]
2007-10-21T10:40:49  <dreimark> looking
2007-10-21T10:47:32  <dreimark> Do you remember that we wondered why the Group dicts werent refreshed by the eventhandler?
2007-10-21T10:48:43  <dreimark> its used in wikidictsrescan gd = wikidicts.GroupDict(request)
2007-10-21T10:49:14  <dreimark> it does not get Group pages so gd.scan_dicts() has not worked
2007-10-21T10:49:33  <dreimark> and I have added del request.dicts
2007-10-21T10:50:51  <dreimark> another place where it is used is mkpagepacks
2007-10-21T10:51:08  <dreimark>  self.gd = wikidicts.GroupDict(request)
2007-10-21T10:51:17  <dreimark> self.gd.reset()
2007-10-21T10:56:23  <ThomasWaldmann> sorry, i cant help much right now as I am busy trying to get i18n stuff working
2007-10-21T10:57:24  <dreimark> ok, currently I think its a kind of typo because on other methods of this class groupdict is used
2007-10-21T10:57:46  <ThomasWaldmann> only "fix" stuff you have proven incorrect
2007-10-21T10:58:02  <ThomasWaldmann> (not just because it looks different)
2007-10-21T10:58:37  <ThomasWaldmann> (and prove it is correct afterwards)
2007-10-21T11:00:39  <dreimark> yeah, adding tests currently
2007-10-21T11:00:57  <dreimark> internet radio plays soundtrack of "Fame"
2007-10-21T11:15:39  <ThomasWaldmann> bah, that i18n stuff is so twisted
2007-10-21T11:34:52  <ThomasWaldmann> xorAxAx: trying to use locks in the i18n code didnt really work, because it tries to recurse into the locked range
2007-10-21T11:35:13  <ThomasWaldmann> (due to wiki markup used in the i18n texts)
2007-10-21T11:36:18  <xorAxAx> ?
2007-10-21T11:36:26  <xorAxAx> then you misplaced the locks :)
2007-10-21T11:36:35  <xorAxAx> the idea is that the init func is locked
2007-10-21T11:36:46  <xorAxAx> and not the gettext etc. one
2007-10-21T11:37:00  <ThomasWaldmann> gettext calls loadlanguage, loadlanguage formats wiki text, wiki parser calls gettext...
2007-10-21T11:38:04  <xorAxAx> doesnt loadlanguage happen at moin startup time just once?
2007-10-21T11:38:20  <ThomasWaldmann> i also tried that, didnt work either
2007-10-21T11:38:39  <ThomasWaldmann> I am thinking about dropping that i18n with wiki markup stuff
2007-10-21T11:38:53  <xorAxAx> just want to have html again?
2007-10-21T11:39:08  <xorAxAx> then how do you fixup paths etc.
2007-10-21T11:40:54  <ThomasWaldmann> or just plain text
2007-10-21T11:41:22  <xorAxAx> well, there are a few links in the i18n markup
2007-10-21T11:42:30  <ThomasWaldmann> the could be replaced by %(helpcontents_link)s
2007-10-21T11:46:22  <dreimark> if one has time to check if that gives more or less test failures http://paste.pocoo.org/show/6947/ it would be nice
2007-10-21T11:48:33  <dreimark> if i remove in wikidictsrescan the line  del request.dicts I get 4 test failures too (2 in test_GetVAL and 2 in test_wikidicts)
2007-10-21T11:51:00  <dreimark> bbl some hours
2007-10-21T12:25:58  <ThomasWaldmann> xorAxAx: http://hg.moinmo.in/moin/1.6/rev/93f0f9f62b2a I'll revert this (except if you have a better idea), it made things even worse
2007-10-21T12:26:31  <xorAxAx> why do you need a lock in load_lang?
2007-10-21T12:26:34  <ThomasWaldmann> loading a language that is not in the cache takes ages now, due to recursion that runs into same code
2007-10-21T12:27:21  <ThomasWaldmann> i tried to avoid doing things twice, letting the other caller just wait until it is finished
2007-10-21T12:28:46  <ThomasWaldmann> (btw, it doesn't get much better by using 1 lock per language)
2007-10-21T12:29:03  <xorAxAx> well, if it needs more than 60 secs, you had a deadloc
2007-10-21T12:29:04  <xorAxAx> k
2007-10-21T12:29:10  <xorAxAx> and the locks released themselves
2007-10-21T12:29:17  <xorAxAx> having a deadlock means that its broken :)
2007-10-21T12:30:09  <ThomasWaldmann> that recursive behaviour needs to get fixed, but I don't know how
2007-10-21T12:30:34  <xorAxAx> still, why do you need locks in load_lang?
2007-10-21T12:31:00  <ThomasWaldmann> you mean loadLanguage?
2007-10-21T12:31:04  <xorAxAx> yes
2007-10-21T12:31:47  <ThomasWaldmann> it is expensive, I wanted it done only once
2007-10-21T12:32:18  <ThomasWaldmann> (expensive if there is no cache yet)
2007-10-21T12:33:00  <ThomasWaldmann> i also tried to narrow that lock to the cache creating part of it, but that made new troubles
2007-10-21T12:34:01  <xorAxAx> well, first one needs an idea of how it should work, then locks can be sprinkled all over the place :)
2007-10-21T12:35:29  <ThomasWaldmann> the problem is that recursive behaviour
2007-10-21T12:35:46  <xorAxAx> well, one could use recursive locks
2007-10-21T12:36:01  <xorAxAx> but they are not implemented yet in the locking code that goes to disk
2007-10-21T12:36:35  <xorAxAx> (they would store the task id and only allow a lock if it matches, otherwise block)
2007-10-21T12:37:45  <ThomasWaldmann> i guess i would rather like something less twisted
2007-10-21T12:38:03  <xorAxAx> thats not twisted at all :)
2007-10-21T12:38:05  <ThomasWaldmann> for now, I just revert that stuff
2007-10-21T12:38:10  <xorAxAx> yeah
2007-10-21T12:38:18  <xorAxAx> well, you could have a queue+worker model
2007-10-21T12:38:27  <xorAxAx> like karol implemented for his jabber bot
2007-10-21T12:38:33  <ThomasWaldmann> and for 1.7, I'll remove it, except someone else works on it
2007-10-21T12:40:06  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2223:09ddb63d4e91 1.6/MoinMoin/i18n/__init__.py: revert changeset 2210:93f0f9f62b2a
2007-10-21T12:41:15  <xorAxAx> di dyou use backout?
2007-10-21T12:43:21  <xorAxAx> ThomasWaldmann:
2007-10-21T12:44:05  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2224:14ad31676a80 1.6/MoinMoin/ (9 files in 3 dirs): use standard xx-yy for languages now (not xx_yy), fixes zh-tw issue
2007-10-21T12:44:34  <ThomasWaldmann> xorAxAx: I committed a reverse patch
2007-10-21T12:44:42  <xorAxAx> backout is recommended
2007-10-21T12:46:00  <ThomasWaldmann> is it on our help page?
2007-10-21T12:48:38  <xorAxAx> no
2007-10-21T12:48:43  <xorAxAx> but even my student used it :)
2007-10-21T12:50:49  <ThomasWaldmann> how about adding it :)
2007-10-21T12:51:59  <xorAxAx> yes, feel free :)
2007-10-21T12:54:08  <ThomasWaldmann> it will save you lots of typing if you add it :)
2007-10-21T12:55:28  <xorAxAx> ?
2007-10-21T13:00:21  <ThomasWaldmann> then the other developers will also notice and you dont need to recommend it to each personally
2007-10-21T13:05:33  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2225:ba3bb2af870a 1.6/wiki/htdocs/applets/moinFCKplugins/macro/ (fckplugin.js macro.gif): fix gui editor to insert macros using new <<macro>> syntax
2007-10-21T13:36:02  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2226:67e67cf43555 1.6/MoinMoin/userform.py: avoid browsers filling in the user's password into UserPreferences first pw field
2007-10-21T13:42:22  <CIA-27> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2895:e24aaec5a557 1.7/MoinMoin/parser/ (_creole.py text_creole.py): Creole Parser: removed request from the Parser class
2007-10-21T13:42:23  <CIA-27> moin: Radomir Dopieralski <moindev@sheep.art.pl> default * 2896:179099ff37c8 1.7/MoinMoin/ (3 files in 3 dirs): merge main
2007-10-21T13:49:38  <TheSheep> I'm wondering, would it be possible in the future to display different editors for different mime types?
2007-10-21T13:50:18  <TheSheep> e.g. the twiki draw applet for drawing nodes
2007-10-21T13:58:19  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2227:2d027f72fec6 1.6/MoinMoin/ (auth/ldap_login.py config/multiconfig.py): don't overwrite email in userprofile with (empty) email addr from ldap
2007-10-21T14:00:13  <ThomasWaldmann> TheSheep: that's planned, but all that code still has to get written
2007-10-21T14:02:04  <TheSheep> ThomasWaldmann: I see, thanks
2007-10-21T14:06:07  <ThomasWaldmann> (we also need different display methods, different diffs, ...)
2007-10-21T14:07:25  <TheSheep> yup
2007-10-21T14:07:39  <TheSheep> well, display methods are kinda handled by parsers
2007-10-21T14:09:31  <xorAxAx> different editing
2007-10-21T14:30:01  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2228:ea84d07d8e03 1.6/MoinMoin/action/fckdialog.py: gui editor macro dialog: fix broken html, use new regex for parsing HelpOnMacros
2007-10-21T14:32:03  <ThomasWaldmann> brb
2007-10-21T14:51:56  <ThomasWaldmann> I guess I will migrate moinmo.in soon.
2007-10-21T15:25:09  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2229:8a5f24b5c80a 1.6/wiki/underlay.tar.bz2: updated underlay pages from master wiki
2007-10-21T15:25:33  <xorAxAx> hmm, still bz2
2007-10-21T15:25:52  <xorAxAx> and the hg repo will grow until eternity has come :)
2007-10-21T15:31:46  <ThomasWaldmann> feel free to fix it :)
2007-10-21T15:32:17  <xorAxAx> well, you updated it
2007-10-21T15:32:23  <xorAxAx> so you made the repo more fat
2007-10-21T15:32:27  <ThomasWaldmann> or any more important stuff on the todo
2007-10-21T15:32:38  <xorAxAx> thats pretty important :)
2007-10-21T15:32:46  <xorAxAx> yes, py.test is important as well
2007-10-21T15:32:51  <ThomasWaldmann> like HilfeZurSynchronisation
2007-10-21T15:33:00  <ThomasWaldmann> or that
2007-10-21T15:33:01  <xorAxAx> thats rather unimportant :)
2007-10-21T15:33:05  <ThomasWaldmann> or _ magic
2007-10-21T15:34:04  <ThomasWaldmann> user docs are unimportant :P
2007-10-21T15:34:29  <xorAxAx> no, thats something the language maintainer could do as well :)
2007-10-21T15:34:49  <ThomasWaldmann> i hope you dont expect me to translate your soc project docs
2007-10-21T15:35:06  <xorAxAx> no
2007-10-21T15:35:12  <xorAxAx> and i already said that i will do it
2007-10-21T15:37:02  * ThomasWaldmann runs a moinmoin wiki migration trial run
2007-10-21T16:05:19  * ThomasWaldmann .oO(copying the data dir takes ages)
2007-10-21T17:05:44  <ThomasWaldmann> johill: parse_quoted_separated makes some troubles
2007-10-21T18:05:09  <ThomasWaldmann> http://de.test.wikiwikiweb.de/MoinMoin16TestWiki if someone has time for checking the 1.6 conversion script output that we all will have to use sooner or later, see there :)
2007-10-21T18:44:53  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2230:da42525b9cef 1.6/MoinMoin/script/migration/_conv160_wiki.py: avoid mig script crashing on strange ImageLink macro calls
2007-10-21T20:34:26  <dreimark> ThomasWaldmann: http://paste.pocoo.org/show/7007/
2007-10-21T20:34:58  <dreimark> only that line changed has the same effect as the other idea I have had before
2007-10-21T20:35:57  <dreimark> so the question is what does update different
2007-10-21T20:36:48  * ThomasWaldmann looks
2007-10-21T20:42:44  <ThomasWaldmann> what exactly does that fix?
2007-10-21T20:44:30  <dreimark> without that it looks like dictdict does not know created Group pages
2007-10-21T20:45:44  <ThomasWaldmann> the patch is wrong (but you are getting to the cause of the problem)
2007-10-21T20:46:36  <ThomasWaldmann> what it should do there is create a expanded group and write it to the dictdict
2007-10-21T20:46:47  <ThomasWaldmann> your code is not creating a expanded group
2007-10-21T20:48:12  <ThomasWaldmann> try grp.name = name in the old code
2007-10-21T20:49:13  <dreimark> ok
2007-10-21T21:43:35  <dreimark> needs more examination
2007-10-21T22:22:09  <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> default * 2231:db1985a9f971 1.6/MoinMoin/i18n/__init__.py: i18n: improved debug logging
2007-10-21T22:23:20  <dreimark> with that change test_wikiutil.py  has one failing tests too but membergroups does work as I suppose
2007-10-21T22:42:20  <dreimark> gn
2007-10-21T22:42:48  <ThomasWaldmann> gn dreimark