MoinMoin: MoinMoinChat/Logs/moin-dev/2007-09-14

2007-09-14T00:04:53  <dreimark> :)
2007-09-14T00:44:20  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2835:9c4c20145a1f 1.7/MoinMoin/ (_tests/test_PageEditor.py events/_tests/test_events.py): test_PageEditor, test_events: skip broken test
2007-09-14T00:45:19  <dreimark> ThomasWaldmann: I will continue with both skipped tests, may be xorAxAx could help with test_send_event
2007-09-14T00:46:47  <dreimark> seems pages ending with Dict could not be created and just deleted afterwards.
2007-09-14T00:47:12  <dreimark> in my test
2007-09-14T00:47:43  <dreimark> gn
2007-09-14T08:22:44  <dreimark> I try to figure out and solve a but in Dict pages
2007-09-14T08:37:44  <dreimark> bug
2007-09-14T08:57:48  <ThomasWaldmann> moin
2007-09-14T08:57:57  <dreimark> moin
2007-09-14T08:59:23  <ThomasWaldmann> dreimark: you may need to call scan_dicts
2007-09-14T09:01:58  <dreimark> scan_dicts does not reload the resulting dict
2007-09-14T09:02:25  <dreimark> DictDict has no load_dict as GroupDict has
2007-09-14T09:12:15  <ThomasWaldmann> it calls adddict and addgroup for every dict/group page
2007-09-14T09:16:22  <ThomasWaldmann> maybe you need to add some force_reload=False param to load_dicts
2007-09-14T12:53:31  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2836:f5049c4cbf6e 1.7/MoinMoin/ (3 files in 3 dirs): wikidicts.dict: loads current dict. fixed and new tests
2007-09-14T13:04:08  <ThomasWaldmann> dreimark: when and how often is that load_dicts() executed?
2007-09-14T13:05:31  <dreimark> ThomasWaldmann: I tested with pages ending Dict. Its called when they are changed or deleted or created.
2007-09-14T13:06:23  <dreimark> my testwiki seems not to be slowed down on using the same var from  other pages
2007-09-14T13:08:28  <ThomasWaldmann> we have that wikidictsrescan event plugin, why isnt it working?
2007-09-14T13:08:56  <ThomasWaldmann> it should be enough to reload the dicts/groups when some dicts/groups page is changed
2007-09-14T13:11:07  <ThomasWaldmann> hmm, maybe not, due to multiple processes (and only the process doing the change gets that event)
2007-09-14T13:11:22  <dreimark>  without that line the behaviour is. It writes the new dict down and uses the old one. The next request gets the dict new,
2007-09-14T13:11:50  <dreimark> it is always one behind
2007-09-14T13:12:26  <ThomasWaldmann> that wouldnt be a big problem, except for tests
2007-09-14T13:13:01  <dreimark> If the dict is empty the first attempt of GetVal gives an empty string
2007-09-14T13:18:28  <ThomasWaldmann> dreimark: that fix is incorrect and incomplete
2007-09-14T13:18:35  <dreimark> oops
2007-09-14T13:18:41  <dreimark> why
2007-09-14T13:18:51  <ThomasWaldmann> you are calling a method self.load_dicts(), there is no such method in that class
2007-09-14T13:19:24  <ThomasWaldmann> and the other methods there are doing almost the same thing, but you didnt modify them
2007-09-14T13:20:06  <ThomasWaldmann> so before continuing, you have to get clearer about what the problem is and where the right place to fix it is
2007-09-14T13:21:33  <dreimark> ThomasWaldmann: which other method ?
2007-09-14T13:22:27  <ThomasWaldmann> values(), keys(), has_key()
2007-09-14T13:26:19  <dreimark> class DictDict is parameter of GroupDict.
2007-09-14T13:27:39  <ThomasWaldmann> you mean that GroupDict is dervied from DictDict
2007-09-14T13:27:48  <ThomasWaldmann> derived
2007-09-14T13:27:53  <dreimark> yeah
2007-09-14T13:31:21  <dreimark> Its not good style to call a method from a derived class by self?
2007-09-14T13:34:48  <dreimark> load_dicts is different to values, keys it validates the cache and updates it if necessary
2007-09-14T13:39:59  <ThomasWaldmann> the method is simply not there if you use the base class
2007-09-14T13:40:44  <ThomasWaldmann> load_dicts is the correct thing to call. but I think you need to find a better place to call it.
2007-09-14T13:41:11  <dreimark> ok
2007-09-14T13:41:56  <dreimark> I will continue searching, do you want me reverting this routine since I am ready?
2007-09-14T13:43:05  <ThomasWaldmann> you can remove that single line once you've found a better place. just dont forget it.
2007-09-14T13:44:16  <dreimark> :)
2007-09-14T13:46:32  <ThomasWaldmann> dreimark: look at request.getDicts/delDicts
2007-09-14T13:47:10  <ThomasWaldmann> i guess you just want to call "del request.dicts" from your test
2007-09-14T13:48:45  <dreimark> ThomasWaldmann: I have that problem with missing Values not only in tests
2007-09-14T13:49:49  <ThomasWaldmann> as you see in getDicts, it calls load_dicts on first access
2007-09-14T13:50:18  <ThomasWaldmann> (first access in a request, the next request will call it again)
2007-09-14T13:57:27  <ThomasWaldmann> dreimark: when do you see a problem outside of tests?
2007-09-14T14:08:30  <dreimark> ThomasWaldmann: if you create from a macro dict pages for example
2007-09-14T14:10:06  <ThomasWaldmann> well, if you want to see changes in same result, you have to call del request.dicts
2007-09-14T14:10:13  <dreimark> and sometimes I see it if I create a new Dict page in a wiki, then sometimes I have to reload the page with the value twice times
2007-09-14T14:10:14  <ThomasWaldmann> well, if you want to see changes in same request, you have to call del request.dicts
2007-09-14T14:11:13  <ThomasWaldmann> and if you are too fast changing stuff, maybe mtime granularity is another problem
2007-09-14T14:12:12  <dreimark> hmm, yeah that's true
2007-09-14T14:13:35  <dreimark> I try fixing only tests and removing that load_dicts call if I don't find a good place for it.
2007-09-14T14:14:15  <dreimark> have to go to the lab
2007-09-14T14:14:26  <ThomasWaldmann> cu :)
2007-09-14T18:20:49  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2837:9fdc81419de7 1.7/MoinMoin/ (events/wikidictsrescan.py wikidicts.py): wikidicts: removed load_dicts wikidictsrescan: added del request.dicts
2007-09-14T18:23:21  <dreimark> and here is an example as macro http://test17.wikiwikiweb.de/ReimarBauer?action=AttachFile&do=get&target=Example.py
2007-09-14T18:23:27  <dreimark> which is now ok too
2007-09-14T18:23:58  <dreimark> that place now is much better :)
2007-09-14T18:24:09  <dreimark> bbl some shopping
2007-09-14T20:48:43  <ThomasWaldmann> moin
2007-09-14T21:56:41  * ThomasWaldmann upgraded to hg 0.9.4