2007-08-14T00:00:09  <RaphaelBossek> who will fix this ? can I do that and provide a patch against the implementation ?
2007-08-14T00:01:44  <RaphaelBossek> I hope someone give me a feedback until tomorrow... I'll check the log...
2007-08-14T00:01:47  <RaphaelBossek> bye
2007-08-14T00:04:40  <ThomasWaldmann> huh? that testcase would be nice for a bug report.
2007-08-14T00:06:53  <grzywacz> night
2007-08-14T00:07:15  <ThomasWaldmann> gn grzywacz
2007-08-14T01:16:50  <nwp> ThomasWaldmann: http://moinmo.in/MoinMoinBugs/ModPySupportBroken and http://moinmo.in/MoinMoinBugs/LDAPDoesntAlwaysProvideNames
2007-08-14T01:17:10  <nwp> Will work on logging improvement separately when I get a little time.
2007-08-14T01:18:05  <nwp> Most people will expect logging to appear in apache log at least by default when running with modpy, but I want to just get it working first :-)
2007-08-14T01:18:16  <ThomasWaldmann> you tested the stuff well enough?
2007-08-14T01:18:32  <ThomasWaldmann> then I just commit that patch to 1.6 :)
2007-08-14T01:19:50  <ThomasWaldmann> cool, ldap work.
2007-08-14T01:23:52  <nwp> ThomasWaldmann: I tested that it works for me :-)
2007-08-14T01:24:03  <nwp> IOW, I couldn't log in without it and now I can
2007-08-14T01:24:22  <ThomasWaldmann> ok
2007-08-14T01:24:51  <nwp> I don't have an LDAP server that actually does provide that info to test against
2007-08-14T01:25:30  <nwp> Modpython was completely horked, so applying that one can't make it any worse ;-)
2007-08-14T01:27:08  <ThomasWaldmann> hehe, ok
2007-08-14T01:30:42  <ThomasWaldmann> nwp: server_modpython is (c) by me? :)
2007-08-14T01:31:06  <nwp> oops
2007-08-14T01:31:24  <nwp> probably me too
2007-08-14T01:32:02  <nwp> but maybe simpler to leave it as you
2007-08-14T01:32:27  <CIA-14> moin: nwp@mrrush.otago.ac.nz * 2131:8ee7ecd61574 1.6/ (3 files in 3 dirs): imported patch fix-modpython-patch
2007-08-14T01:33:15  <nwp> after all, I clearly copied it from somewhere ;-)
2007-08-14T01:34:02  <xorAxAx> oh i spot a missing name :)
2007-08-14T01:34:33  <xorAxAx> being reminded at the "industrial grade programmer" from the uk we had last year
2007-08-14T01:34:36  <xorAxAx> :-)
2007-08-14T01:35:36  <nwp> huh?
2007-08-14T01:36:16  <xorAxAx> does that refer to the first or second line?
2007-08-14T01:36:32  <nwp> both, really :-)
2007-08-14T01:36:37  <xorAxAx> oh well
2007-08-14T01:36:45  <xorAxAx> compare:
2007-08-14T01:36:46  <xorAxAx> 23:53:56 < CIA-14> moin: Karol Nowak <grzywacz@sul.uni.lodz.pl> * 2667:9e1a05495686 1.7-jabber-knowak/jabberbot/main.py: Remove a debugging print.
2007-08-14T01:36:49  <xorAxAx> 01:32:27 < CIA-14> moin: nwp@mrrush.otago.ac.nz * 2131:8ee7ecd61574 1.6/ (3 files in 3 dirs): imported patch fix-modpython-patch
2007-08-14T01:36:54  <nwp> ah
2007-08-14T01:36:57  <xorAxAx> look for names :)
2007-08-14T01:37:11  <nwp> that's just what mercurial seems to put in there for me
2007-08-14T01:37:23  <nwp> is there some environment variable I should be setting to make it put my name in?
2007-08-14T01:37:23  <xorAxAx> yes, our docs in the wiki explain how to set the name, though
2007-08-14T01:37:34  <xorAxAx> see MercurialGuide or something like that
2007-08-14T01:37:47  <nwp> ok, cool, thanks
2007-08-14T01:37:53  <nwp> still learning mercurial
2007-08-14T01:38:02  <xorAxAx> and the second line refers to an old legend of fame
2007-08-14T01:38:09  <nwp> I know enough to like it and use it, but not the bells and whistles
2007-08-14T01:38:13  <xorAxAx> called keppy. maybe you remember him
2007-08-14T01:38:17  <nwp> nope
2007-08-14T01:38:26  <xorAxAx> i think you were joined at that time
2007-08-14T01:38:32  <xorAxAx> in this channel
2007-08-14T01:38:34  <nwp> just learnt how to use mercurial queues yesterday - nice
2007-08-14T01:38:38  <nwp> don't remember though
2007-08-14T01:38:59  <xorAxAx> yeah, mq is rather nice if you know how it works and have learned workarounds for its deficies :
2007-08-14T01:39:03  <xorAxAx> -)
2007-08-14T01:39:17  <nwp> which deficiencies are you thinking of?
2007-08-14T01:39:49  <xorAxAx> well, sometimes you need to touch the series file with an editor to fix up some scenarios
2007-08-14T01:39:58  <nwp> I first read it through when I was learning to use hg and reading the section on queues made absolutely no sense, so left it for a while
2007-08-14T01:40:08  <xorAxAx> and it breaks on windows if your patch.exe behaves differently than it expects
2007-08-14T01:40:14  <nwp> come back to it later and *bang* it all makes sense
2007-08-14T01:40:17  <xorAxAx> hehe
2007-08-14T01:42:04  <nwp> as I've been telling the guy sitting next to me worrying about whether the updates he's been doing (e.g. WGA) on a bunch of windows laptops will break our videoconferencing - you pays your money and takes your choice. If you chose windows, you get to live with the issues.
2007-08-14T01:42:19  <nwp> I do kind of sympathise, but...
2007-08-14T01:42:32  <nwp> ...I'm bloody glad I don't really have to use it much any more
2007-08-14T01:42:56  <xorAxAx> oh video conferencing
2007-08-14T01:43:30  <xorAxAx> my 1000 peeps big employee doesnt even know how its spelled except if you are in the upper management
2007-08-14T01:44:07  <xorAxAx> telecommuniting is used once a week at most
2007-08-14T01:44:18  <CIA-14> moin: nwp@mrrush.otago.ac.nz * 2132:82dd8d2d68aa 1.6/MoinMoin/auth/ldap_login.py: imported patch fix-ldap-patch
2007-08-14T01:44:20  <CIA-14> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2133:b065fa55cb3f 1.6/MoinMoin/ (auth/ldap_login.py config/multiconfig.py): ldap auth: set attribute names' default to None
2007-08-14T01:44:45  <xorAxAx> again i spot a missing name :)
2007-08-14T01:44:53  <ThomasWaldmann> nwp: i did some minor change (defaults None now)
2007-08-14T01:45:12  <nwp> I thought you might
2007-08-14T01:49:01  <nwp> but wasn't sure, so thought I might as well leave it to you if you felt like it :-)
2007-08-14T01:50:10  <ThomasWaldmann> i already had add some defaults before, but I was unsure if it was correct for everybody or many people
2007-08-14T01:50:26  <ThomasWaldmann> so just None will work for everyone somehow
2007-08-14T08:28:10  <ThomasWaldmann> moin
2007-08-14T08:33:48  <ThomasWaldmann> lanius: moin
2007-08-14T08:34:09  <ThomasWaldmann> lanius: still 11 failures to fix
2007-08-14T09:01:32  <grzywacz> moin
2007-08-14T09:27:50  <grzywacz> ... I fail at using gmail.
2007-08-14T10:08:41  <ThomasWaldmann> for?
2007-08-14T10:12:25  <grzywacz> For sending mail. ;)
2007-08-14T10:13:35  <ThomasWaldmann> from moin?
2007-08-14T10:14:48  <ThomasWaldmann> grzywacz:
2007-08-14T10:14:54  <grzywacz> No, my private using a web browser. Sounds like some kind of retardation. ;)
2007-08-14T10:16:05  <ThomasWaldmann> we have a bug about rfc incompliance of google's smtp
2007-08-14T10:41:57  <grzywacz> oh crap, design error :S
2007-08-14T10:43:37  <grzywacz> or maybe...
2007-08-14T11:00:17  * ThomasWaldmann reported http://moinmo.in/MoinAndGmail to gmail team
2007-08-14T11:13:05  <lanius> ThomasWaldmann: 11 failures?
2007-08-14T11:19:18  <ThomasWaldmann> yeah
2007-08-14T11:20:39  <ThomasWaldmann> lanius: 9 of them in your backend tests
2007-08-14T11:23:43  <ThomasWaldmann> don't you see them?
2007-08-14T11:33:54  <ThomasWaldmann> lanius: names in news() do not have "fixed" length, but a "maximum" length (and you should document how much and check against max_path on win32 and linux)
2007-08-14T11:34:31  <ThomasWaldmann> s/see external.py/see MoinMoin/storage/external.py/
2007-08-14T11:34:44  <ThomasWaldmann> (add backslashes where needed :)
2007-08-14T11:36:01  <ThomasWaldmann> "logfile classes are now always reverse" sounds funny
2007-08-14T11:37:44  <ThomasWaldmann> "convert attachements ..."  -> -e
2007-08-14T11:42:58  <ThomasWaldmann> lanius: add to the TODO: editlog.add has 1.6 fs storage code in it, while the rest of editlog uses the storage api
2007-08-14T11:45:27  <ThomasWaldmann> lanius: please renice your moin_coding_process and mentor_interface_process to a much higher priority :)
2007-08-14T11:45:35  <ThomasWaldmann> gtg, bbl
2007-08-14T11:47:20  <CIA-14> moin: Karol Nowak <grzywacz@sul.uni.lodz.pl> * 2674:9817a90b6fde 1.7-jabber-knowak/MoinMoin/ (4 files in 2 dirs): Fix subscriptions when there's no smtp host set, only notification bot.
2007-08-14T11:47:22  <CIA-14> moin: Karol Nowak <grzywacz@sul.uni.lodz.pl> * 2675:37449fd9e70a 1.7-jabber-knowak/MoinMoin/ (action/subscribe.py xmlrpc/__init__.py): Whitespace/pep8 fixes.
2007-08-14T12:25:02  <grzywacz> xorAxAx: ping?
2007-08-14T12:32:41  <xorAxAx> grzywacz: pong
2007-08-14T12:38:18  <grzywacz> xorAxAx: ok
2007-08-14T12:38:43  <grzywacz> xorAxAx: I've just realised that I need one more piece of information to be carried in notifications
2007-08-14T12:38:57  <grzywacz> xorAxAx: that is, what kind of action (edit, revert, user creation) triggered it
2007-08-14T12:39:23  <grzywacz> xorAxAx: this doesn't matter with text notifications
2007-08-14T12:39:42  <grzywacz> xorAxAx: but for data forms I need to know the context, so that I can add lists of available operations and so on ;S
2007-08-14T12:40:02  <grzywacz> (like revert to page changes)
2007-08-14T12:40:35  <xorAxAx> yes
2007-08-14T12:41:59  <grzywacz> xorAxAx: and I can't decide, whether I should create separate xmlrpc functions, or add just an another arg to send_notification(). And following that, does creating separate command classes for each case makes sense, or should I stick with adding one attribute? :o I'd prefer to keep send_notification with one arg and add attributes to NotificationCommand, but... what do you think? 8)
2007-08-14T12:42:22  <xorAxAx> ah, thats in the jabber bot?
2007-08-14T12:42:27  <grzywacz> yes
2007-08-14T12:44:42  <xorAxAx> i would add an item to the notification dict
2007-08-14T12:44:53  <xorAxAx> and an attrib, yes
2007-08-14T12:45:20  <grzywacz> Ok, good
2007-08-14T12:46:12  <grzywacz> Will be afk for some time now, I have to buy something for dinner. :\
2007-08-14T12:51:35  <TheSheep> eating is sooo oldskool
2007-08-14T12:53:28  <grzywacz> Yeah, but I've been obliged to keep myself from starving to death. :P
2007-08-14T12:55:17  <lanius> ThomasWaldmann: sorry, my internet connectino is very bad currently
2007-08-14T12:55:29  <lanius> ThomasWaldmann: i don't have the failures
2007-08-14T12:58:44  <xorAxAx> not even on linux?
2007-08-14T12:59:10  <lanius> can't test on linux currently becaue of my bad connection
2007-08-14T13:02:18  <xorAxAx> well, the failures have been known for days :)
2007-08-14T13:03:28  <lanius> well, i don't usually check on linux
2007-08-14T13:06:07  <xorAxAx> and you dont seem to read this channel regularly :)
2007-08-14T13:06:26  <lanius> i do
2007-08-14T13:06:39  <xorAxAx> well, thomas has been talking about it for a few days
2007-08-14T13:07:14  <lanius> and i already said that my internet connection is very bad and i thought i fixed the errors two days ago, after that nobody mentioned failing tests again
2007-08-14T13:07:37  <lanius> untilnow
2007-08-14T13:08:21  <xorAxAx> ok
2007-08-14T13:08:34  <xorAxAx> why is bad, btw?
2007-08-14T13:08:47  <lanius> only umts
2007-08-14T13:09:54  <lanius> sometimes only gprs
2007-08-14T13:10:09  <xorAxAx> ah, well
2007-08-14T13:10:47  <xorAxAx> a 1 sec. latency shouldnt stop you from running py.test on a remote system :)
2007-08-14T13:11:33  <lanius> if latency is too bad it does
2007-08-14T13:11:37  <lanius> but currently it is ok
2007-08-14T13:26:36  <CIA-14> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2817:5a92e393d74f 1.7-storage-hwendel/ (MoinMoin/storage/backends/filesystem.py docs/CHANGES.storage): fix failing tests; update CHANGES.storage
2007-08-14T14:34:06  <ThomasWaldmann> re
2007-08-14T14:34:57  <ThomasWaldmann> lanius: does py.test output help you?
2007-08-14T14:36:19  <ThomasWaldmann> ok, with an existing test wiki, it succeeds now with 0 errors
2007-08-14T14:37:49  <ThomasWaldmann> and running it with a fresh test wiki also succeeds, so you fixed it for now :)
2007-08-14T14:38:33  <ThomasWaldmann> finally I can try some practical tests (I hope you also did and not only rely on the automatic tests)
2007-08-14T14:39:16  <ThomasWaldmann> lanius: did you read my other comments/questions from 11:19+ today?
2007-08-14T14:48:40  <ThomasWaldmann> lanius: I hope you will have a normal dsl connection for the rest of the week.
2007-08-14T15:12:40  <CIA-14> moin: Karol Nowak <grzywacz@sul.uni.lodz.pl> * 2676:ea982442f84a 1.7-jabber-knowak/docs/CHANGES.jabber: Added a CHANGES file specific to my branch.
2007-08-14T15:19:59  <ThomasWaldmann> grzywacz: you will extend that file quite a bit, right?
2007-08-14T15:24:16  <grzywacz> ThomasWaldmann: probably. What exactly do you want me to add in there?
2007-08-14T15:24:36  <grzywacz> ThomasWaldmann: mind that there aren't many changes since 1.7 yet ;-)
2007-08-14T15:24:47  <ThomasWaldmann> CHANGES describes what has been changed :)
2007-08-14T15:24:58  <ThomasWaldmann> currently you just have installation hints there
2007-08-14T15:25:42  <ThomasWaldmann> also, you should not assume that your CHANGES.jabber text stays in that file, so you have to mention that this stuff is jabber related.
2007-08-14T15:25:42  <grzywacz> ThomasWaldmann: because nothing has been changes since the last release with jabber support :P
2007-08-14T15:26:09  <ThomasWaldmann> what last release?
2007-08-14T15:26:15  <grzywacz> Well, headline mentiones that atm. So if it gets copied to another file, it should be ok.
2007-08-14T15:26:19  <ThomasWaldmann> last release is 1.5.8 :)
2007-08-14T15:26:27  <grzywacz> That's why I'm joking about CHANGES.:P
2007-08-14T15:26:58  <ThomasWaldmann> the point is to be able to just copy those * entries to the main changes files without having to edit everything again.
2007-08-14T15:27:26  <grzywacz> Why can't I just modify the main CHANGES file directly, then?
2007-08-14T15:27:50  <ThomasWaldmann> and it will go into 1.7.0 changes description, so you will have to describe there that there is jabber support now, what that means and what help page is to be read to find more
2007-08-14T15:27:59  <grzywacz> ack
2007-08-14T15:28:09  <ThomasWaldmann> because that would just make lots of trouble when merging everything
2007-08-14T15:28:49  <grzywacz> ThomasWaldmann: any idea when 1.6 or 1.7 might be released?
2007-08-14T15:28:49  <ThomasWaldmann> it is easier to just read in that file into CHANGES when doing the merge and then delete the file
2007-08-14T15:28:58  <ThomasWaldmann> 1.6 = 2007
2007-08-14T15:29:07  <ThomasWaldmann> 1.7 = 2008
2007-08-14T15:29:23  <grzywacz> Ages. :(
2007-08-14T15:29:42  <ThomasWaldmann> with some more active developers, maybe 1.7 will be end 2007, but I don't think we can do it earlier.
2007-08-14T15:30:25  <grzywacz> Is there anything specific to 1.6 that's not in 1.7?
2007-08-14T15:30:28  <grzywacz> I mean...
2007-08-14T15:30:41  <grzywacz> Does it make any sense to release 1.6? ;p
2007-08-14T15:31:24  <xorAxAx> yes
2007-08-14T15:31:45  <xorAxAx> the whole soc branches, auth refactoring, thomas completly changed the parser
2007-08-14T15:32:57  <grzywacz> mhm
2007-08-14T15:35:10  <ThomasWaldmann> the best thing we can try is to make 1.6 short lived
2007-08-14T15:35:28  <ThomasWaldmann> but skipping it would just make it take even longer as it already takes
2007-08-14T15:36:19  <ThomasWaldmann> release schedule mostly depend on developer time available for making it releasable.
2007-08-14T15:37:20  <xorAxAx> and people constraining themselves to their own rules
2007-08-14T15:39:19  <ThomasWaldmann> heh, yes :)
2007-08-14T15:39:39  <ThomasWaldmann> sometimes it just doesnt work as planned :)
2007-08-14T15:40:05  <ThomasWaldmann> btw, I am not writing this parser for 1.7
2007-08-14T15:41:16  <grzywacz> ?_?;
2007-08-14T15:43:29  <xorAxAx> ThomasWaldmann: ah
2007-08-14T15:43:35  <xorAxAx> grzywacz: hmm? :)
2007-08-14T15:43:59  <ThomasWaldmann> I used quite some time on this converter stuff the last weeks.
2007-08-14T15:44:08  <ThomasWaldmann> It even has tests. :D
2007-08-14T15:44:44  <xorAxAx> well, 1.6 is even worse somehow
2007-08-14T15:44:47  <ThomasWaldmann> But the problem is that moin 1.5 link markup is so fscked, I had to introduce some extended markup (quoting).
2007-08-14T15:45:07  <ThomasWaldmann> that means converter has to convert many links
2007-08-14T15:45:34  <ThomasWaldmann> so if I have to convert that stuff anyway, I can also really fix the link markup.
2007-08-14T15:46:46  <ThomasWaldmann> I guess I am half done with all of it, using [[target|text]] markup and parser code got lots easier and better (inspired by TheSheep's creole parser).
2007-08-14T15:47:33  <ThomasWaldmann> Of course it won't fix every problem we have with the parser, but at least all that link crap will be gone.
2007-08-14T15:47:57  <ThomasWaldmann> and even parts of ImageLink might get superfluous
2007-08-14T15:50:12  <ThomasWaldmann> see test17.wikiwikiweb.de
2007-08-14T15:53:44  <ThomasWaldmann> (I won't commit this stuff to main branch until soc is finished, no worries :)
2007-08-14T15:58:11  <ThomasWaldmann> btw, if someone has some development time: we need a fix for that editor crash when edit-locking is mandatory.
2007-08-14T16:12:07  <vpv> I've looked into the docbook branch and it doesn't support docbook refentry :(
2007-08-14T16:12:36  <vpv> which basically is man/info files formatted in docbook
2007-08-14T16:14:39  <vpv> I'm currently considering of leaving docbook as the storage format for man/info pages in wiki for now. I'll have to talk it through with my mentor yet.
2007-08-14T16:16:00  <vpv> But if I do that, then I'd have (hopefully) enough time to do the docbook->man/info->upstream diff part well and we'd have a wiki with editing capabilities, even if it wasn't in wiki markup
2007-08-14T16:28:40  <ThomasWaldmann> vpv: what means "leaving docbook as the storage format"?
2007-08-14T16:29:18  <vpv> like it is now, that pages are saved (and edited) in docbook
2007-08-14T16:30:44  <vpv> docbook refentry -> wiki markup would probably be possible, but I'm more worried about the wiki markup -> docbook refentry part
2007-08-14T16:32:46  <ThomasWaldmann> vpv: that means the man pages you get from fedora are already in docbook format?
2007-08-14T16:34:08  <vpv> no, they are converted with doclifter, which does a good job at that btw.
2007-08-14T16:34:31  <ThomasWaldmann> btw, the format detection for xml based stuff could be improved. currently it is just something like if raw.startswith('<xml'): parser = text_xslt
2007-08-14T16:34:45  <ThomasWaldmann> (but you rather want text_docbook)
2007-08-14T16:35:11  <ThomasWaldmann> vpv: so the src format is what?
2007-08-14T16:35:21  <ThomasWaldmann> *roff?
2007-08-14T16:35:25  <vpv> yes
2007-08-14T16:48:23  <vpv> oh yeah, I forgot to mention, converting from docbook to man works great with docbook2x. of course the diff between man pages before and after  man -> docbook -> man is a bit ugly, but when viewed with man, the result looks pretty much exactly as the source
2007-08-14T16:59:34  <ThomasWaldmann> ok
2007-08-14T17:00:27  * ThomasWaldmann wonders about man page authors really using *roff or if they not rather use docbook src as the edit format
2007-08-14T17:02:12  <vpv> I've noticed it's a bit of a grey area, some really use *roff (based on VCS logs, even), some use docbook, some use POD or whatever the perl thing is called etc.
2007-08-14T17:03:12  <vpv> there are people like ESR who think all man pages should be in docbook now, but I guess there are habits/conventions that come all the way from the 1980s here ;)
2007-08-14T17:12:32  <ThomasWaldmann> if not 197x :)
2007-08-14T17:13:01  <TheSheep> let's rock like it's 1977!
2007-08-14T17:13:59  <ThomasWaldmann> aka the pre-microsoft era :)
2007-08-14T17:14:14  <TheSheep> legends!
2007-08-14T17:20:02  <grzywacz> pictures or it didn't happen!
2007-08-14T17:26:24  <TheSheep> grzywacz: http://folklore.org/ProjectView.py?project=Macintosh&characters=George+Crow
2007-08-14T17:26:32  * ThomasWaldmann .oO(1976, when micro-soft wrote basic for 8bit machines :)
2007-08-14T17:28:29  <TheSheep> they look happy, surely no MS there: http://folklore.org/projects/Macintosh/gallery/pyramid.jpg
2007-08-14T17:29:18  <TheSheep> http://folklore.org/projects/Macintosh/gallery/Mac_Design_Team.jpg <-- here they were told about MS for the first time ;)
2007-08-14T17:31:25  <ThomasWaldmann> zenhase: when will you finish your stuff? soc deadline is in 6 days.
2007-08-14T17:35:09  <grzywacz> TheSheep: ok, looks realistic. ;p
2007-08-14T17:40:31  <ThomasWaldmann> lanius: why do you need that *-news.mtime hack?
2007-08-14T17:41:07  <ThomasWaldmann> granularity?
2007-08-14T17:42:38  <ThomasWaldmann> and the news file also contains those timestamps, why don't you just read the last record to get the latest mtime?
2007-08-14T17:43:37  <ThomasWaldmann> reading 512bytes from same file (that are like in a buffer) might be much cheaper than opening another file just for 10 bytes).
2007-08-14T17:44:02  <ThomasWaldmann> s/like/likely/
2007-08-14T18:02:26  <grzywacz> oh crap...
2007-08-14T18:02:43  <grzywacz> I wasted another hour+ hunting a stupid mistake.
2007-08-14T18:02:45  <grzywacz> Tea time.
2007-08-14T18:07:36  <lanius> ThomasWaldmann: because it is faster
2007-08-14T18:08:01  <ThomasWaldmann> it is?
2007-08-14T18:08:20  <lanius> ThomasWaldmann: yes i read everything and also did some pratical tests
2007-08-14T18:08:41  <lanius> ThomasWaldmann: i'm afraid that my connection won't be better
2007-08-14T18:08:47  <ThomasWaldmann> what do you mean by "read everything"?
2007-08-14T18:08:54  <lanius> ThomasWaldmann: yes i tried it
2007-08-14T18:09:00  <lanius> ThomasWaldmann: your comments
2007-08-14T18:09:09  <ThomasWaldmann> ah
2007-08-14T18:09:27  <ThomasWaldmann> that's a bad plan for last soc week
2007-08-14T18:10:01  <lanius> i know, but i told you that and if there are missing things afterwards i can stil lfix them
2007-08-14T18:10:31  <ThomasWaldmann> you should rather have most stuff fixed until the deadline
2007-08-14T18:10:37  <lanius> that's what i try to
2007-08-14T18:10:50  <lanius> do
2007-08-14T18:11:42  <ThomasWaldmann> maybe try doing a fresh clone of you stuff, untar underlay and start moin.py. then go to localhost:8080/RecentChanges to see what I see currently.
2007-08-14T18:12:31  <lanius> you mean the changes of the underlay?
2007-08-14T18:13:02  <ThomasWaldmann> a looooong rc page, showing 2006-04-15 and xxxx changes from 19:49
2007-08-14T18:13:53  <lanius> yes
2007-08-14T18:14:55  <ThomasWaldmann> if I go to /TestSeite, I see a KeyError
2007-08-14T18:16:20  <ThomasWaldmann> calling action=edit and saving gives an AttributeError
2007-08-14T18:17:01  <lanius> strange things happening here, will fix them
2007-08-14T18:17:18  <ThomasWaldmann> ehrm, calling that page again shows an empty page
2007-08-14T18:17:49  <ThomasWaldmann> calling info action there shows backtrace with NoSuchRevisionError
2007-08-14T18:17:57  <ThomasWaldmann> Revision -2 of item u'TestSeite' does not exist.
2007-08-14T18:18:08  <ThomasWaldmann> the -2 is also a bit strange :D
2007-08-14T18:20:18  <ThomasWaldmann> PageSize works \o/
2007-08-14T18:20:35  <ThomasWaldmann> except that: PageSize (last edited 0 by )
2007-08-14T18:20:47  <ThomasWaldmann> (not sure if it was MUCH better with old backend :)
2007-08-14T18:21:24  <ThomasWaldmann> please first fix editing, so we can do more tests
2007-08-14T18:22:18  <ThomasWaldmann> standalone server is nice for testing, lots of backtraces in my xterm...
2007-08-14T18:23:06  <lanius> sure, can only be small bugs
2007-08-14T18:24:01  <ThomasWaldmann> btw, after that editor crash, i now have current == 1 and revisions/00000001 == ''
2007-08-14T18:25:08  <ThomasWaldmann> and no edit-log entry for it
2007-08-14T18:25:15  <lanius> that's why it crashes
2007-08-14T18:26:11  <ThomasWaldmann> new file has an entry for <timestamp> -1 TestSeite
2007-08-14T18:26:52  <ThomasWaldmann> one tmpXXXXX file left over in data/tmp
2007-08-14T18:27:10  <ThomasWaldmann> looooong underlay.new file :D
2007-08-14T18:28:03  <ThomasWaldmann> and a empty TestSeite dir under tmp
2007-08-14T18:29:41  <ThomasWaldmann> UserPreferences macro seems broken (the page shows it as plain text, it does not get executed -> import problem!?)
2007-08-14T18:30:06  <xorAxAx> macro?
2007-08-14T18:30:13  <xorAxAx> its an action, isnt it?
2007-08-14T18:30:46  <TheSheep> xorAxAx: there is both an action and a macro by that name
2007-08-14T18:31:04  <xorAxAx> what does the macro do?
2007-08-14T18:31:07  <CIA-14> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2818:f3f305fd12ea 1.7-storage-hwendel/MoinMoin/ (4 files in 4 dirs): fix some small bugs
2007-08-14T18:31:49  <TheSheep> xorAxAx: displays the user perferences form on a page
2007-08-14T18:31:52  <grzywacz> Working on windows is so annoying. :(
2007-08-14T18:32:30  <TheSheep> xorAxAx: while the action only displays the system page
2007-08-14T18:32:44  <ThomasWaldmann> ignore my UserPreferences comment. we should note to delete that page from 1.7 underlay, it is not used any more.
2007-08-14T18:33:12  <xorAxAx> TheSheep: are you very very sure? :)
2007-08-14T18:33:22  <TheSheep> xorAxAx: I wrote the action
2007-08-14T18:33:35  <grzywacz> TheSheep: I'm afraid it may be a little bit different in 1.7 now
2007-08-14T18:33:42  <TheSheep> xorAxAx: although it probably depends on the version
2007-08-14T18:33:45  <xorAxAx> anyway, you lost, there is no macro :)
2007-08-14T18:33:49  <TheSheep> grzywacz: gotcha
2007-08-14T18:33:58  <TheSheep> aww
2007-08-14T18:34:43  <ThomasWaldmann> lanius: the user login/settings/etc. stuff seems to work
2007-08-14T18:35:30  <ThomasWaldmann> (pretty nice now, btw :)
2007-08-14T18:36:17  <ThomasWaldmann> although the change password stuff maybe should ask for the old one (except if current user came from superuser - can we check that?)
2007-08-14T18:49:36  * ThomasWaldmann waits for OrphanedPages
2007-08-14T18:50:00  <ThomasWaldmann> AttributeError: 'GlobalEditLog' object has no attribute 'size'
2007-08-14T18:51:08  <ThomasWaldmann>   File "/usr/lib/python2.4/random.py", line 248, in choice
2007-08-14T18:51:08  <ThomasWaldmann>     return seq[int(self.random() * len(seq))]  # raises IndexError if seq is empty
2007-08-14T18:51:11  <ThomasWaldmann> TypeError: unindexable object
2007-08-14T18:52:15  <ThomasWaldmann> hmm, ctrl-c does not work?
2007-08-14T18:55:32  <grzywacz> Might not. ;)
2007-08-14T21:51:30  <neagulm> hello
2007-08-14T21:54:41  <grzywacz> hi neagulm!
2007-08-14T22:05:53  <ThomasWaldmann> moin neagulm
2007-08-14T22:06:05  <neagulm> moin TheSheep
2007-08-14T22:06:15  <neagulm> moin ThomasWaldmann
2007-08-14T22:06:45  * neagulm is trying to auto-complete thoughts 
2007-08-14T22:16:38  <ThomasWaldmann> GNA
2007-08-14T22:17:01  <ThomasWaldmann> in 1.5 wiki:/somepage is a invalid interwiki link
2007-08-14T22:17:28  <ThomasWaldmann> in 1.5 [wiki:/somepage sometext] is a valid link to CurrentPage/somepage
2007-08-14T23:05:52  <xorAxAx> grzywacz: are you planning to clean the micro-mess you introduced in 9bc7d2c14e1f?
2007-08-14T23:07:58  <xorAxAx> grzywacz: please describe added features in the CHANGES file and refer to a help page for details
2007-08-14T23:09:09  <xorAxAx> lanius: f3f305fd12ea uses send_page in the info action - can you add an error message as wel?
2007-08-14T23:09:59  <xorAxAx> grzywacz: it would be nice if you could follow up on your weekly reports
2007-08-14T23:14:34  <grzywacz> xorAxAx: one moment, looking at the commit
2007-08-14T23:15:32  <grzywacz> xorAxAx: what micro-mess do you have in mind?
2007-08-14T23:15:41  <grzywacz> xorAxAx: will do with CHANGES
2007-08-14T23:15:43  <xorAxAx> the revert change
2007-08-14T23:15:49  <grzywacz> xorAxAx: will report tomorrow
2007-08-14T23:15:57  <xorAxAx> tests are still breaking without pyxmpp
2007-08-14T23:16:05  <grzywacz> ah, right...
2007-08-14T23:16:16  <grzywacz> xorAxAx: hm
2007-08-14T23:16:30  <grzywacz> xorAxAx: any suggestions how to fix that without messing things up?
2007-08-14T23:16:56  <xorAxAx>  try: import ... except ImportError: py.test.skip("...")(
2007-08-14T23:17:10  <grzywacz> xorAxAx: no no, I mean the revert stuff
2007-08-14T23:17:25  <xorAxAx> ah, well, you need to pull out the revert code :)
2007-08-14T23:17:58  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2626:a791fc964e09 1.7/jabberbot/ (commands.py xmlrpcbot.py xmppbot.py): Attempt to move i18n from xmlrpc to xmpp thread.
2007-08-14T23:18:00  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2627:8e767010c418 1.7/MoinMoin/ (17 files in 11 dirs): Merge main.
2007-08-14T23:18:01  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2628:35690680ecac 1.7/MoinMoin/events/__init__.py: Use event's "name" attribute instead of class name.
2007-08-14T23:18:02  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2629:5dac44252ca6 1.7/jabberbot/ (commands.py xmlrpcbot.py xmppbot.py): Whitespace fixes.
2007-08-14T23:18:03  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2630:d1658035d233 1.7/MoinMoin/macro/Action.py: Merge main.
2007-08-14T23:18:06  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2631:80ec0bb44cb2 1.7/jabberbot/oob.py: Add a partial implementation Out Of Band Data (XEP-066)
2007-08-14T23:18:06  <grzywacz> łót?
2007-08-14T23:18:11  <CIA-14> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2632:584e1714aa05 1.7/jabberbot/xmlrpcbot.py: Fix a missing __init__ argument in ConfigurationError exception.
2007-08-14T23:18:16  <grzywacz> Why does this get displayed?
2007-08-14T23:18:16  <xorAxAx> grzywacz: hmm?
2007-08-14T23:18:28  <xorAxAx> because thats old and i am just pushing to main :)
2007-08-14T23:19:10  <grzywacz> xorAxAx: you mean the code in revert *action*?
2007-08-14T23:20:12  <xorAxAx> yes, it needs to move to PageEditor
2007-08-14T23:20:24  <grzywacz> hm
2007-08-14T23:20:26  <grzywacz> :-)
2007-08-14T23:20:37  <xorAxAx> (not everything of course)
2007-08-14T23:21:03  <grzywacz> Ok, so plan for tonight is: CHANGES, fixing revert, fixing mess I have here atm
2007-08-14T23:21:10  <grzywacz> Should be doable before I fall asleep. @_@
2007-08-14T23:21:46  <xorAxAx> lanius: do you still disagree to suggest changes in wikisync that i will review later on? still getpagepath there
2007-08-14T23:22:25  <xorAxAx> lanius: also i think that you need to change caching to use the storage backend, right?
2007-08-14T23:22:50  <xorAxAx> and ACLs are still missing as well
2007-08-14T23:29:31  <grzywacz> After 2 months with eclipse, editing this code in vim is painful...
2007-08-14T23:30:43  <xorAxAx> hehe
2007-08-14T23:31:00  <grzywacz> I can't even find stuff because I'm used to different layout / screen size.
2007-08-14T23:31:01  <grzywacz> -_-;
2007-08-14T23:40:15  <grzywacz> Cool, found a stupid error at last...
2007-08-14T23:41:44  <xorAxAx> write a unit test :)
2007-08-14T23:41:54  <grzywacz> hm
2007-08-14T23:41:56  <xorAxAx> then the stupid task of bug finding is deferred :)
2007-08-14T23:42:37  <grzywacz> I think that an in-code check will be better in this case.
2007-08-14T23:42:47  <grzywacz> I passed a wrongly formatted jid.
2007-08-14T23:44:48  <xorAxAx> how about both?
2007-08-14T23:45:42  <grzywacz> I'm not sure it's easy to write a unittest for a function call with wrong parameter.
2007-08-14T23:46:24  <xorAxAx> well, the unittest would simply use the code that calls the other code incorrectly
2007-08-14T23:47:17  <xorAxAx> see an exception and fail
2007-08-14T23:47:44  <grzywacz> There was no exception.
2007-08-14T23:47:49  <grzywacz> Problem appeared afterwards.
2007-08-14T23:48:04  <grzywacz> After two-way communication between threads.
2007-08-14T23:48:07  <grzywacz> Not pretty.
2007-08-14T23:50:01  <xorAxAx> ah
2007-08-14T23:50:13  <xorAxAx> well, somewhere the exception must have gone
2007-08-14T23:50:32  <xorAxAx> a unittest could monkeypatch the stuff so that it doesnt disappear between pyxmpp interaction and normal code
2007-08-14T23:54:02  <grzywacz> Sure, there was a KeyError when xmpp code tried to access a non-existent resource.
2007-08-14T23:54:05  <grzywacz> aha
2007-08-14T23:54:17  <grzywacz> Right, there's even a race condition there, superb...
2007-08-14T23:54:27  <grzywacz> I should start taking notes.

MoinMoin: MoinMoinChat/Logs/moin-dev/2007-08-14 (last edited 2007-10-29 19:08:54 by localhost)