MoinMoin: MoinMoinChat/Logs/moin-dev/2007-08-10

2007-08-10T03:19:22  <ThomasWaldmann> http://www.youtube.com/watch?v=OYvynmK0Slo
2007-08-10T08:31:21  <ThomasWaldmann> moin
2007-08-10T08:36:35  <starshine> hi TW
2007-08-10T08:36:56  <starshine> I might wear the moinshirt to the linuxpicnic this year :)
2007-08-10T08:50:50  <ThomasWaldmann> hey :)
2007-08-10T08:52:23  <ThomasWaldmann> I guess I will also have them with me in case I visit CA later this year. :)
2007-08-10T09:46:14  <ThomasWaldmann> lanius: please have a look at the failing tests
2007-08-10T11:32:19  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2798:b3edb1dbd579 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: Set size limit for files
2007-08-10T11:38:01  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2799:01325ef370dc 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: argh, fix power
2007-08-10T11:44:39  <CIA-14> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2621:6bb7cad1a039 1.7/MoinMoin/parser/_tests/test_text_moin_wiki.py: tests: simplify parser test
2007-08-10T11:44:41  <CIA-14> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2622:1b2078bafdaa 1.7/MoinMoin/parser/_tests/test_text_moin_wiki.py: wiki parser tests: fixed line_anchor problems and some other broken tests
2007-08-10T11:44:42  <CIA-14> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2623:5c6d61bf88c5 1.7/MoinMoin/parser/_tests/test_text_moin_wiki.py: wiki parser tests: fixed some other broken tests
2007-08-10T11:47:06  <grzywacz> moin
2007-08-10T11:47:10  <xorAxAx> moin grzywacz
2007-08-10T11:47:57  <grzywacz> hi xorAxAx :)
2007-08-10T11:48:13  <grzywacz> I have to leave soon, will be back in 2 hours or so, I think.
2007-08-10T12:10:42  <CIA-14> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2624:3d30e923448f 1.7/MoinMoin/parser/_tests/test_text_moin_wiki.py: wiki parser tests: convert to py.test
2007-08-10T12:28:37  <ThomasWaldmann> johill: btw, that push_id(?) stuff is crashing if startContent was never called
2007-08-10T12:28:46  <johill> hm
2007-08-10T12:28:50  <ThomasWaldmann> i worked around it by calling start/endContent
2007-08-10T12:28:52  <johill> makes sense
2007-08-10T12:29:03  <johill> but is it legal to output something without content?
2007-08-10T12:29:28  <xorAxAx> no
2007-08-10T12:29:32  <ThomasWaldmann> good questions. i tried when making the parser test easier
2007-08-10T12:29:58  <ThomasWaldmann> put the crash could be avoided by if not ....include_stack: ....
2007-08-10T12:30:16  <johill> yeah but then you have to probably stick that condition into a lot of places
2007-08-10T12:30:24  <johill> because otherwise the whole id generation will most likely mess up
2007-08-10T12:30:25  <ThomasWaldmann> (it crashes with index error at that [-1] because it is empty then)
2007-08-10T12:30:38  <johill> it's not the greatest code, it's somewhat fragile
2007-08-10T13:32:25  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2800:94d4a1a979fa 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: output cleanups, no use displaying the timer, since there's no problem there anymore
2007-08-10T13:32:27  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2801:1a4b40451cd5 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: More status output, make rpm removal more obvious
2007-08-10T13:32:28  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2802:2b848fbc366a 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: fix package count print
2007-08-10T17:50:55  <ThomasWaldmann> vpv: +            if os.path.getsize(filename) > 2**10:   please not that 2**10 is 1024 (bytes)
2007-08-10T17:51:04  <ThomasWaldmann> +e
2007-08-10T17:52:14  <xorAxAx> thats a wrong comment :)
2007-08-10T17:52:18  <ThomasWaldmann> ah, you fixed it. btw, what was wrong with ** so you use pow now?
2007-08-10T17:53:00  <ThomasWaldmann> xorAxAx: ?
2007-08-10T17:53:40  <xorAxAx> it is 10**3 and not 2**10
2007-08-10T17:53:51  <xorAxAx> cf. iso foo
2007-08-10T17:54:14  <ThomasWaldmann> 2**10 is 1024, this is not wrong
2007-08-10T17:54:25  <xorAxAx> hmm, indeed
2007-08-10T17:54:30  <ThomasWaldmann> but he wanted 2**20
2007-08-10T17:54:51  <ThomasWaldmann> and it doesnt care at that place whether it is M or Mi
2007-08-10T17:55:10  <ThomasWaldmann> (it just sucks that it is so slow)
2007-08-10T17:56:25  <ThomasWaldmann> vpv:        13     Needs doclifter.py in MoinMoin/script.
2007-08-10T17:56:44  <ThomasWaldmann> vpv: if you want to ADD that code to moin, it has to be in MoinMoin/support.
2007-08-10T17:57:03  <ThomasWaldmann> vpv: if not, it has to work if it is in sys.path
2007-08-10T17:59:01  <ThomasWaldmann> vpv:        35 import tarfile        <- from MoinMoin.support import tarfile (if you want a working one)
2007-08-10T17:59:35  <ThomasWaldmann> vpv:        40 import MoinMoin.user     <- from MoinMoin import user
2007-08-10T18:00:14  <ThomasWaldmann> vpv:       107         if status is not 0:     This works, but I bet you do not know why. :D
2007-08-10T18:00:47  <ThomasWaldmann> vpv: so please just use: if status != 0:
2007-08-10T18:01:42  <ThomasWaldmann> vpv:       142                 if i.find("diff") is not -1:          if "diff" in i:    (and same comment about usage of "is not")
2007-08-10T18:02:40  <ThomasWaldmann> vpv: read PEP8 and indent using 4 blanks. also please run py.test in your tree so you see some failures
2007-08-10T18:03:32  <ThomasWaldmann> vpv:       203             cpio_arg = ""
2007-08-10T18:03:32  <ThomasWaldmann>       204             for mfile in manfilelist:
2007-08-10T18:03:32  <ThomasWaldmann>       205                 cpio_arg += "."
2007-08-10T18:03:32  <ThomasWaldmann>       206                 cpio_arg += mfile
2007-08-10T18:03:32  <ThomasWaldmann>       207                 cpio_arg += " "
2007-08-10T18:04:08  <ThomasWaldmann> The big python would EAT you for that. :D
2007-08-10T18:04:44  <ThomasWaldmann> vpv: is your mentor looking into your stuff?
2007-08-10T18:05:36  <ThomasWaldmann> vpv:       229                 (shortname, extension) = os.path.splitext(line)     you dont need the parantheses on the left side of =
2007-08-10T18:06:27  <ThomasWaldmann> vpv:       295         cacheflistpath = os.path.join(self.cachedir + "/filelists.xml.gz")    # look at it again
2007-08-10T18:08:48  <ThomasWaldmann> vpv:       444         except:
2007-08-10T18:08:48  <ThomasWaldmann>       445             pass
2007-08-10T18:09:32  <ThomasWaldmann> one does usually NOT catch all exceptions and ignores them
2007-08-10T18:09:52  <ThomasWaldmann> vpv:       453         if len(mlist) == 0:         if not mlist:
2007-08-10T18:11:40  <ThomasWaldmann> vpv: you should do the imports in any function you write. There are reasons to do such stuff, but in your case, I guess you mostly want to import them one time at top of the module.
2007-08-10T18:14:00  <ThomasWaldmann> vpv: i suggest you also run pychecker / pylinst / eclipse / whatever over your stuff
2007-08-10T18:18:58  <ThomasWaldmann> s/you should do/you should NOT do/
2007-08-10T20:44:46  <ThomasWaldmann> re
2007-08-10T21:34:55  <vpv> ThomasWaldmann: I know there are issues in my code style, I have not spent time fixing them yet, as there are other problems too, like I spent the whole of today trying to find out why doclifter goes mad and eats 2 gigs of memory when handling one particular man file with my script, but it doesn't do that if I run it on it's own with the same file. Also no other file has ever caused anything like this before and I must have tested with hundreds of files...
2007-08-10T21:37:40  <vpv> also, I'll be away from tomorrow morning to some time in Sunday, I have saved your comments and I'll try to fix those points then, I may even start now :)
2007-08-10T21:39:59  <ThomasWaldmann> may some issues vanish after cleaning up :)
2007-08-10T21:44:19  <vpv> hopefully, that's so strange though, that I'll doubt it'll disappear... I'm thinking of making a filter to bypass problematic files if I can't find the reasons.
2007-08-10T22:02:34  <ThomasWaldmann> if it only happens in single files, maybe dont waste too much time on it now
2007-08-10T22:02:48  <ThomasWaldmann> but the src definitely need major cleanup
2007-08-10T22:03:50  <vpv> I agree
2007-08-10T23:15:53  <vpv> yay, I went from 6.something to 8.something with pylint, one hour of work :)
2007-08-10T23:23:21  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2803:894451144d02 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: rearrange imports
2007-08-10T23:23:23  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2804:f113dc813032 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: Coding style changes as suggested by ThomasWaldmann and pylint
2007-08-10T23:23:27  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2814:174bd9c594ee 1.7-maninfo-vpv/ (5 files in 5 dirs): merge from main
2007-08-10T23:32:02  <CIA-14> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2815:cf026915f8ae 1.7-maninfo-vpv/MoinMoin/script/import/manimport.py: make test_sourcecode not fail
2007-08-10T23:39:19  <vpv> I'm trying to track the weird man page stuff, apparently I have 10 python processes running when this occurs, all of them so futex(something) with strace
2007-08-10T23:41:58  <vpv> oh those are the moin server threads I assume, so that didn't help much ;)
2007-08-10T23:59:57  <vpv> ok I really think the "big bug" here is a doclifter problem so I need to just set up an exclude filter and maybe contact ESR if he's interested. I'm not gonna start debugging that 8000 line beast on summercode time.