MoinMoin: MoinMoinChat/Logs/moin-dev/2007-07-06

2007-07-06T00:34:57  * ThomasWaldmann updated test.wikiwikiweb.de
2007-07-06T08:50:03  <xorAxAx> dreimark: in b902f2397c68, you simply added the files instead of renaming them. please fix that! (This message has been postponed.)
2007-07-06T08:52:20  <dreimark> xorAxAx:I thought I've done this with 505991ec14f3
2007-07-06T08:55:56  <dreimark> xorAxAx: Can you please think about a flag for enabling / disabling wikisync
2007-07-06T08:57:49  <dreimark> so that it could be controlled from wikiconfig
2007-07-06T09:00:19  <dreimark> http://moinmoin.wikiwikiweb.de/UmlSequence
2007-07-06T09:02:50  <dreimark> bbl
2007-07-06T09:20:37  <lanius> xorAxAx: what do you mean with duck typing
2007-07-06T09:23:21  <dreimark> bb
2007-07-06T10:02:34  <ThomasWaldmann> dreimark: if you don't use hg mv, but hg add newname and hg rm oldname, mercurial doesnt know about the rename and you lose the connection in the file history
2007-07-06T10:03:50  <vpv> ThomasWaldmann: did you see this, is it worth going to 1.7 main? http://hg.moinmo.in/moin/1.7-maninfo-vpv/rev/5179d0075f57
2007-07-06T10:04:24  <vpv> xorAxAx told me to make a named branch in my own repo, but it just seemed a bit complicated...
2007-07-06T10:06:12  <ThomasWaldmann> i can put that into main. for what is the div?
2007-07-06T10:08:39  <vpv> it isn't valid html without a container like that
2007-07-06T10:11:16  <dreimark> ThomasWaldmann: indeed, sick :(
2007-07-06T10:12:59  <vpv> I did a test without the div, w3 validator says document type does not allow element "INPUT" here; missing one of "P", "H1", "H2", "H3", "H4", "H5", "H6", "PRE", "DIV", "ADDRESS" start-tag.
2007-07-06T10:13:17  <ThomasWaldmann> vpv: did you test that change for function?
2007-07-06T10:14:56  <vpv> it does work, now the self.method in ActionBase actually gets used (if that's what you meant?)
2007-07-06T10:18:36  <lanius> ThomasWaldmann: did you already look through my last commits?
2007-07-06T11:10:41  <xorAxAx> lanius: well, in python you usually check via hasattr if a certain method is supported
2007-07-06T11:11:01  <xorAxAx> lanius: this is pretty important here because you dont have abstract base classes in the interfaces module, right?
2007-07-06T11:12:05  <xorAxAx> dreimark: in 505991ec14f3, you simply deleted files
2007-07-06T11:12:48  <xorAxAx> dreimark: its important to fix this to make merging and annotate work
2007-07-06T11:13:52  <lanius> xorAxAx: you mean for the backends.py ?
2007-07-06T11:13:57  <dreimark> ThomasWaldmann: xorAxAx: my next commit fixes that, sorry that was really stupid
2007-07-06T11:14:22  <xorAxAx> lanius: i mean for the data classes, as i already said
2007-07-06T11:14:43  <lanius> lanius: and what do you want to check there
2007-07-06T11:14:54  <xorAxAx> ?
2007-07-06T11:15:23  <lanius> i don't understand what you want to do with hasattr
2007-07-06T11:16:33  <xorAxAx> lanius: the caller wants to know what kind of data object he has got
2007-07-06T11:16:42  <lanius> who is the caller
2007-07-06T11:16:48  <xorAxAx> he cannot do that currently without calling the method and catching the exception
2007-07-06T11:17:02  <xorAxAx> imagine some third party piece of code that gets handed in some data object
2007-07-06T11:17:23  <lanius> and what is your suggestion here
2007-07-06T11:17:42  <xorAxAx> to remove the methods that only raise exceptions in those data classes, as i already said before :)
2007-07-06T11:17:55  <xorAxAx> you get the messages that are sent when you offline, dont you? :)
2007-07-06T11:18:10  <lanius> well the caller can just do an isinstance
2007-07-06T11:18:31  <xorAxAx> and what should h supply as the class?
2007-07-06T11:18:53  <lanius> ReadonlyData / WriteonlyData
2007-07-06T11:19:01  <xorAxAx> in which module?
2007-07-06T11:19:15  <lanius> external.py
2007-07-06T11:19:29  <xorAxAx> hmm
2007-07-06T11:19:47  <xorAxAx> so you think that there wont be other subclasses?
2007-07-06T11:19:51  <xorAxAx> umm, classes?
2007-07-06T11:19:58  <xorAxAx> ok, then its maybe ok to have these methods
2007-07-06T11:19:58  <lanius> no i don't think so currently
2007-07-06T12:37:08  <ThomasWaldmann> lanius: only had a quick look
2007-07-06T12:37:16  <ThomasWaldmann> +        if not self.lock == True:
2007-07-06T12:37:17  <ThomasWaldmann> +            raise AccessError(_("This item is readonly"))
2007-07-06T12:38:13  <ThomasWaldmann> the more precise reason would be "This item is currently locked, you can only use it read-only.", right?
2007-07-06T12:38:48  <ThomasWaldmann> xorAxAx already commented on the == True.
2007-07-06T12:40:22  <ThomasWaldmann> ehrm, or rather "could not lock item, ..."
2007-07-06T12:42:54  <ThomasWaldmann> +                self._body = ""   # should be u""
2007-07-06T12:45:53  <ThomasWaldmann> lanius: currently 12 tests are failing in your branch. some can be fixed by merging main branch.
2007-07-06T12:47:08  <lanius> ThomasWaldmann: i didn't look at the general tests yet, only at mine, but merging main will be my next step
2007-07-06T12:51:58  <ThomasWaldmann> +            del self.locks[string]  # dont use string as variable name, it is saying nothing and it collides with stdlib module name
2007-07-06T12:52:17  <ThomasWaldmann> ok
2007-07-06T12:56:00  <ThomasWaldmann> lanius: after the merge, if it fails tests due to trailing space, you can use code located in
2007-07-06T12:56:21  <ThomasWaldmann> test_sourcecode to fix them all at once. see the comments there.
2007-07-06T13:09:26  <dreimark> ThomasWaldmann: can you have al look at http://moinmoin.wikiwikiweb.de/ReimarBauer/PlanForUndoingAnUnwantedCommiting so I don't do the next failure ;)
2007-07-06T13:10:16  <xorAxAx> dreimark: you dont need to undo the commit, you just need to rebase your modifications and merge both brances
2007-07-06T13:14:20  <ThomasWaldmann> btw, there is no hg extract - you mean export maybe?
2007-07-06T13:14:28  <dreimark> right
2007-07-06T13:17:07  <ThomasWaldmann> and I guess I would not import 2291, but use patch
2007-07-06T13:17:45  <dreimark> xorAxAx: sounds interesting  I do search for that on mercurial or can you instruct me
2007-07-06T13:17:49  <ThomasWaldmann> then fix everything like it should be, then commit
2007-07-06T13:18:32  <dreimark> ThomasWaldmann: the differnce is that I don't get that log entry or more ?
2007-07-06T13:20:11  <ThomasWaldmann> if you use import, you get that changeset again (and it auto commits it, if it doesnt need manual merging)
2007-07-06T13:43:09  <grzywacz> off to catch a train ...
2007-07-06T14:12:27  <zenhase_> moin
2007-07-06T14:16:36  <ThomasWaldmann> hi zenhase_
2007-07-06T14:22:11  <zenhase_> oh
2007-07-06T14:23:05  * zenhase zip-closes his fly and hides his underscore
2007-07-06T14:57:31  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2343:4825c2a3ec30 1.7-maninfo-vpv/MoinMoin/script/xmlrpc/manimport.py: Add a warning, especially necessary when I start doing RPM integration
2007-07-06T15:43:10  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2344:0c63e06a9876 1.7-maninfo-vpv/MoinMoin/ (action/SisterDiff.py script/xmlrpc/manimport.py): Basics of rpm importing (a do-nothing function still), some code restructuring, some PEP8 fixes
2007-07-06T18:34:21  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2293:318ab53c9d2a 1.7/MoinMoin/_tests/test_sourcecode.py: backout 2290:49188b1e803c
2007-07-06T18:34:24  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2294:d6f44eaf5bdc 1.7/ (36 files in 12 dirs): renamed request and server implementations by adding a prefix (using hg)
2007-07-06T18:34:25  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2295:3118d71074db 1.7/MoinMoin/ (11 files in 2 dirs): merged main
2007-07-06T18:38:03  <xorAxAx> dreimark: that was unsuccessful
2007-07-06T18:38:08  <xorAxAx> http://hg.alexanderweb.de/moin-1.7-main/log/3118d71074db/MoinMoin/request/request_cgi.py
2007-07-06T18:38:11  <xorAxAx> history still lost
2007-07-06T18:38:38  <xorAxAx> it would be nice if you could test that before pushing
2007-07-06T18:38:44  <xorAxAx> now its a two-level-mess
2007-07-06T18:38:54  <dreimark>  have that tested
2007-07-06T18:41:39  <dreimark> xorAxAx: I have seen parent using hg serve
2007-07-06T18:42:24  <xorAxAx> well, obviously its broken
2007-07-06T18:42:48  <xorAxAx> hmm
2007-07-06T18:42:56  <xorAxAx> it shows the wrong ancestry graph
2007-07-06T18:43:10  <xorAxAx> i thought that it was symmetric
2007-07-06T18:43:19  <dreimark> yeah and I hate me for using mv in eclipse instead of hg mv
2007-07-06T18:43:38  <xorAxAx> hehe
2007-07-06T18:44:10  <dreimark> learning by accident isn't fun
2007-07-06T18:44:46  <xorAxAx> hmm, indeed, i think its not possible to get it better than that
2007-07-06T18:45:12  <xorAxAx> (except if it was done correctly from the first attempt on :))
2007-07-06T18:53:29  <dreimark> arrg what a pain
2007-07-06T18:54:09  <dreimark> I did another mistake sorry ThomasWaldmann
2007-07-06T18:55:08  <dreimark> Its not my day
2007-07-06T18:56:05  <xorAxAx> hmm?
2007-07-06T18:57:17  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2345:cd0184768575 1.7-maninfo-vpv/MoinMoin/script/xmlrpc/manimport.py: Remove unneeded line of code, left from the first tests...
2007-07-06T18:57:18  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2346:59f90fb67309 1.7-maninfo-vpv/MoinMoin/script/xmlrpc/manimport.py: some rpm improvements
2007-07-06T18:57:32  <dreimark> I have used  backout wrong so I reverted MoinMoin/_tests/test_sourcecode.py
2007-07-06T18:59:03  <xorAxAx> ah
2007-07-06T19:49:57  <dreimark> xorAxAx: I have read http://hgbook.red-bean.com/hgbookch9.html (9.3.3  Backing out a non-tip change) but I have some questions do you have some time ?
2007-07-06T20:05:04  <xorAxAx> i am rather busy learning for an exam, sorry
2007-07-06T20:05:09  <xorAxAx> but i will be free on monday
2007-07-06T20:05:24  <dreimark> what is it about?
2007-07-06T20:06:20  <dreimark> its ok
2007-07-06T20:06:33  <xorAxAx> "digitale welten, bewegte bilder" :)
2007-07-06T20:07:24  <dreimark> wow sounds interesting
2007-07-06T20:09:03  <xorAxAx> yes
2007-07-06T20:22:06  <ThomasWaldmann> re
2007-07-06T20:29:09  <ThomasWaldmann> students, please DON'T merge 1.7 now until i have reviewed repo state
2007-07-06T20:41:37  <ThomasWaldmann> hmm, too late for karol
2007-07-06T20:46:47  <dreimark> ThomasWaldmann: I have decided to revert to 2290 and doing the changes again on 1.7
2007-07-06T20:49:50  <ThomasWaldmann> maybe wait until i have checked the backups
2007-07-06T20:49:57  <dreimark> ok
2007-07-06T20:51:07  <xorAxAx> "backups"?
2007-07-06T20:51:15  <xorAxAx> why do you need any backups ...
2007-07-06T20:51:15  <xorAxAx> ThomasWaldmann:
2007-07-06T20:54:21  <ThomasWaldmann> maybe that's easier as doing another few tries and having the repo look bad afterwards
2007-07-06T20:54:32  <xorAxAx> ?
2007-07-06T20:54:43  <xorAxAx> its much easier just to clone the repos
2007-07-06T20:54:48  <xorAxAx> if you want to drop changesets
2007-07-06T20:55:39  <ThomasWaldmann> ah, clone -r. ok, then I'll clone some past rev.
2007-07-06T20:56:25  <xorAxAx> but that will leave all mirroring repos with a second head
2007-07-06T20:59:01  <ThomasWaldmann> well, i guess they just should do a fresh clone also?
2007-07-06T21:00:01  <ThomasWaldmann> the clone is 20mb smaller?
2007-07-06T21:00:03  <xorAxAx> they dont need to reclone remotely but need to rebase their repos and changesets, yes
2007-07-06T21:00:12  <xorAxAx> cant be :)
2007-07-06T21:00:32  <xorAxAx> hmm
2007-07-06T21:00:32  <ThomasWaldmann> 115104  1.7
2007-07-06T21:00:32  <ThomasWaldmann> 95220   1.7-2290
2007-07-06T21:00:38  <xorAxAx> maybe a new repo format
2007-07-06T21:00:55  <xorAxAx> umm, how does it count hardlinks?
2007-07-06T21:01:01  <xorAxAx> most of the repo should be hardlinks
2007-07-06T21:02:51  <dreimark> ThomasWaldmann: 1.6 too please
2007-07-06T21:03:21  <dreimark> I'll redo (using hg mv) the changes tomorrow
2007-07-06T21:03:49  <ThomasWaldmann> ok, so i exchange the 1.7 repo for a clone of rev 2290 now
2007-07-06T21:06:17  <ThomasWaldmann> ok, so i exchange the 1.6 repo for a clone of rev 2111 now
2007-07-06T21:24:48  <ThomasWaldmann> the 1.6 repo also has 20mb less
2007-07-06T22:53:27  <johill> ThomasWaldmann: I'll reply to Joey's mail tomorrow, for now I'm off
2007-07-06T23:32:49  <ThomasWaldmann> gn johill