MoinMoin: MoinMoinChat/Logs/moin-dev/2007-07-05

2007-07-05T00:00:37  <grzywacz> night
2007-07-05T00:00:39  <dreimark> my opinion too
2007-07-05T00:01:46  <dreimark> and i think I will open a market place too
2007-07-05T00:04:44  <dreimark> with that you get immediatly a result which tells someone has missed to do a unit test
2007-07-05T00:05:02  <dreimark> and therefore I want that
2007-07-05T00:05:16  <dreimark> or not someone
2007-07-05T00:05:27  <dreimark> just only there is a unit test missing
2007-07-05T00:06:39  <dreimark> for me its an helper
2007-07-05T00:07:45  <dreimark> we should continue tomorrow
2007-07-05T00:07:52  <dreimark> good night
2007-07-05T00:09:48  <xorAxAx> code coverage says you, where a test is missing
2007-07-05T00:13:41  <dreimark> believe me it helps to get people to test theire code and write tests before publishing
2007-07-05T00:15:18  <dreimark> cu
2007-07-05T08:27:08  <ThomasWaldmann>  moin
2007-07-05T08:32:57  <lanius> moin Thomas
2007-07-05T10:14:04  <ThomasWaldmann> dreimark: maybe we could try to find out whether the new eclipse release still has those search troubles
2007-07-05T10:15:15  <lanius> ThomasWaldmann: i have the new eclipse installed, how can i try out?
2007-07-05T10:17:32  <ThomasWaldmann> just do a bigger refactoring, renaming lots of stuff
2007-07-05T10:18:05  <ThomasWaldmann> ctrl-h should find all occurences of some name x, but sometimes doesn't
2007-07-05T10:18:37  <lanius> ok, have to finish my stuff here first to commit it so it doesn't get lost ;)
2007-07-05T10:19:25  <ThomasWaldmann> lanius: new == europa release?
2007-07-05T10:19:48  <lanius> yes
2007-07-05T10:19:57  <lanius> with latest pydev + extensions
2007-07-05T10:20:11  * ThomasWaldmann didnt install europa yet, the big new features didnt seem useful to me.
2007-07-05T10:20:31  <ThomasWaldmann> did I miss something new and important for py dev?
2007-07-05T10:20:39  <lanius> don't think so
2007-07-05T10:20:52  <xorAxAx> umm
2007-07-05T10:20:53  <lanius> the new maximize mode is nice, it shows icons for the surrounding views for quick access
2007-07-05T10:21:29  <xorAxAx> are you using file- or python-search?
2007-07-05T10:21:32  <lanius> and the console pops up if something is happening there
2007-07-05T10:24:45  <ThomasWaldmann> lanius: did you find any things that got worse in europa?
2007-07-05T10:37:25  <lanius> other than the maximize stuff not yet
2007-07-05T10:39:04  <xorAxAx> they have pretty many unit tests :)
2007-07-05T10:46:13  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2338:3603700ad8ac 1.7-maninfo-vpv/MoinMoin/action/SisterDiff.py: SisterDiff finds sister pages now, but the code is not in the right place yet
2007-07-05T10:46:19  <dreimark> ThomasWaldmann: we will have server_cgi and request_cgi. Both were named CGI in theire subdirs.  I'll push them today, I will have more time in the evening as yesterday
2007-07-05T10:47:19  <ThomasWaldmann> did you only rename the cgi stuff?
2007-07-05T10:47:47  <dreimark> No all the others too, :)
2007-07-05T10:48:00  <ThomasWaldmann> ok
2007-07-05T10:48:34  <ThomasWaldmann> dont forget the code under wiki/
2007-07-05T10:49:22  <ThomasWaldmann> and if this affects function of 1.6 on win32, we need it there, too
2007-07-05T10:54:25  <dreimark> I'llt add it to 1.6 too. the docu needs to be checked too
2007-07-05T11:09:16  <ThomasWaldmann> bbl
2007-07-05T11:20:47  <xorAxAx> lanius: +        py.test.raises(NotImplementedError, self.backend.get_data_backend, names[0], 1, "rw")
2007-07-05T11:20:56  <xorAxAx> lanius: that should go into the base class, right?
2007-07-05T11:23:04  <xorAxAx> lanius: i strongly suggest to drop all methods from the pagedata classes that would throw exceptions
2007-07-05T11:23:08  <xorAxAx> so that duck typing is possible
2007-07-05T11:26:46  <dreimark> hehe search on google apache2 fcg, first entry is about moin
2007-07-05T11:41:00  <lanius> xorAxAx: this would only assume that the test data is the same
2007-07-05T11:43:39  <xorAxAx> lanius: why does it raise NotImplementedError?
2007-07-05T11:45:19  <lanius> because the user stuff has no data
2007-07-05T11:46:26  <xorAxAx> hmm, ok
2007-07-05T12:37:13  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2339:5c58dc65e6a8 1.7-maninfo-vpv/MoinMoin/action/SisterDiff.py: Move the sisterpages code to a more appropriate place, make the UI. Crashes if no sisterpage available, that needs to be fixed.
2007-07-05T13:55:33  <lanius> i have a problem with the edit-lock
2007-07-05T13:55:55  <lanius> since i implemented it as metadata it does not work when creating a new item, because this item has no metadata yet
2007-07-05T13:58:26  <lanius> xorAxAx: ThomasWaldmann any idea?
2007-07-05T14:15:46  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2340:f896e301de00 1.7-maninfo-vpv/MoinMoin/action/SisterDiff.py: Handle the error if the form doesn't have the required field. Still shows an empty form, that should be fixed next
2007-07-05T14:20:28  <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2130:67af66f7f61e 1.7-storage-hwendel/MoinMoin/ (7 files in 3 dirs): a lot of cleanups; move metadata to the storage backend
2007-07-05T14:23:10  <xorAxAx> lanius: hehe, old problem :)
2007-07-05T14:23:18  <xorAxAx> lanius: well, you need to create an item without a revision
2007-07-05T14:23:19  <xorAxAx> first
2007-07-05T14:23:57  <lanius> that would be possible, but if the user does not finish the edit and does not click cancel it will never be removed
2007-07-05T14:25:14  <xorAxAx> yes, old problem
2007-07-05T14:26:17  <xorAxAx> you could ignore edit locks for non-existant items
2007-07-05T14:26:31  <xorAxAx> merging will work nevertheless
2007-07-05T14:26:38  <xorAxAx> just the warning would be gone
2007-07-05T14:39:41  <vpv> I think I found a bug in the action code and form printing
2007-07-05T14:40:21  <vpv> If I print a form via get_form_html, it makes a form that has two method="" arguments
2007-07-05T14:41:02  <vpv> and then it doesn't matter what you put in self.method, since the first one is preferred anyway
2007-07-05T14:42:28  <xorAxAx> write a test and fix the bug, prefarably in a separate branch that branched from main
2007-07-05T14:42:32  <xorAxAx> :)
2007-07-05T14:46:58  <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2131:1718ada65354 1.7-storage-hwendel/MoinMoin/ (Page.py PageEditor.py): fix edit-log problems
2007-07-05T14:51:36  <zenhase> moin
2007-07-05T14:54:17  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2341:5179d0075f57 1.7-maninfo-vpv/MoinMoin/action/__init__.py: Fix two ActionBase form bugs: two method arguments in same form tag, input tag without a div (or any else 'container' around it)
2007-07-05T14:54:19  <zenhase> ThomasWaldmann: i talked to ffesti on the phone yesterday and we decided as the next step (for today) i will document in detail what has been giving me the headaches/problems
2007-07-05T14:55:10  <vpv> xorAxAx: that previous commit should apply to main without any "man/info" stuff
2007-07-05T14:58:22  <xorAxAx> vpv: well, it would be nice if you can do the cherry picking for us :)
2007-07-05T15:00:07  <vpv> how does that happen exactly? I clone 1.7 main, patch it, can I push to main too?
2007-07-05T15:13:04  <vpv> seems I can't hg push to main
2007-07-05T15:44:50  <CIA-27> moin: Ville-Pekka Vainio <vpivaini AT cs DOT helsinki DOT fi> * 2342:a093fe9518e9 1.7-maninfo-vpv/MoinMoin/action/SisterDiff.py: Show a message if there are no sister pages, not an empty form
2007-07-05T15:45:34  <xorAxAx> vpv: no, you push into your repo
2007-07-05T15:45:41  <xorAxAx> you can create a new named branch
2007-07-05T15:47:21  <vpv> I'll have to read on that then... So I can have many branches in the maninfo repo?
2007-07-05T16:35:15  <xorAxAx> yep
2007-07-05T17:46:47  <dreimark> bbl
2007-07-05T18:10:12  <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2132:62fdde3178d5 1.7-storage-hwendel/MoinMoin/storage/ (_tests/test_external.py external.py): implement write lock
2007-07-05T18:10:27  <lanius> xorAxAx: can you please take a look at my code especially the write locks if this is sufficient?
2007-07-05T18:10:32  <lanius> have to go now, bye
2007-07-05T18:32:37  <xorAxAx> lanius: well, its not easy to review that kind of code completly
2007-07-05T18:32:46  <xorAxAx> tests are best for such kind of code
2007-07-05T20:33:08  <ThomasWaldmann> moin
2007-07-05T20:33:43  <dreimark> moin
2007-07-05T21:06:39  <grzywacz> re
2007-07-05T21:06:51  <xorAxAx> hi grzywacz
2007-07-05T21:06:55  <xorAxAx> how was the exam? :)
2007-07-05T21:10:35  <xorAxAx> so you will get money by western union, the scam catalyst?
2007-07-05T21:14:46  <grzywacz> heh ;]
2007-07-05T21:14:52  <grzywacz> xorAxAx, passed
2007-07-05T21:16:01  <xorAxAx> cool
2007-07-05T21:29:31  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2291:b902f2397c68 1.7/ (25 files in 12 dirs): rename server and request Implementations by adding a prefix server_, request_
2007-07-05T21:29:34  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2292:505991ec14f3 1.7/MoinMoin/ (11 files in 2 dirs): removed renamed request and server implementations
2007-07-05T21:35:23  <ThomasWaldmann> ?
2007-07-05T21:36:18  <dreimark> so now for 1.6
2007-07-05T21:40:54  <grzywacz> xorAxAx and others: http://groups.google.com/group/google-summer-of-code-announce/browse_thread/thread/c6c38ed3622d7682
2007-07-05T21:43:32  <xorAxAx> i have seen it already, thanks :)
2007-07-05T21:43:54  <grzywacz> Ok. :)
2007-07-05T21:44:05  * grzywacz catching up with email
2007-07-05T22:12:44  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2322:b902f2397c68 1.7-jabber-knowak/ (25 files in 12 dirs): rename server and request Implementations by adding a prefix server_, request_
2007-07-05T22:12:46  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2323:505991ec14f3 1.7-jabber-knowak/MoinMoin/ (11 files in 2 dirs): removed renamed request and server implementations
2007-07-05T22:12:48  <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2324:dbfe98af770a 1.7-jabber-knowak/ (36 files in 12 dirs): Merge with main.
2007-07-05T23:09:14  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2112:e42ef9cb87e4 1.6/MoinMoin/ (22 files in 2 dirs): rename server and request Implementations by adding a prefix server_, request_
2007-07-05T23:09:16  <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2113:75b047096dae 1.6/ (13 files in 10 dirs): renamed call of server and request Implementations by adding a prefix server_, request_
2007-07-05T23:11:12  <dreimark> gn
2007-07-05T23:39:42  <grzywacz> xorAxAx, I'll be somewhat away during this weekend, because I have to do some family visiting and such. I have a few small tasks started, like making the jabber bot a little bit more verbose about some warning-level conditions and i18n of its messages, so these will get in soon, I hope.
2007-07-05T23:40:00  <grzywacz> xorAxAx, if there's anything with higher priority - let me know...
2007-07-05T23:41:09  <xorAxAx> lanius: did you honor my duck typing hint already?
2007-07-05T23:41:26  <xorAxAx> grzywacz: nothing i can think of currently
2007-07-05T23:42:56  <grzywacz> xorAxAx, ok, I'll progress with the stuff I already have started.
2007-07-05T23:43:26  <xorAxAx> lanius: +        if not self.lock == True:
2007-07-05T23:44:00  <xorAxAx> the last time i wrote such code was 8 years ago
2007-07-05T23:45:05  <xorAxAx> OMG
2007-07-05T23:45:17  <xorAxAx> b902f2397c68 is broken wrt file renaming
2007-07-05T23:45:19  <xorAxAx> ARGH