2007-06-22T00:14:20 <ThomasWaldmann> lanius: please use new style classes for new stuff
2007-06-22T00:21:23 <ThomasWaldmann> lanius: why this?: + return os.path.join(self.request.cfg.data_dir, "file")
2007-06-22T00:23:12 <ThomasWaldmann> shouldnt that be just file or rather fname?
2007-06-22T00:28:07 <lanius> ThomasWaldmann: of course
2007-06-22T00:28:52 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2084:adf664b982ba 1.7-storage-hwendel/MoinMoin/Page.py: small fixes
2007-06-22T00:30:06 <lanius> gn8
2007-06-22T00:30:30 <ThomasWaldmann> gn lanius
2007-06-22T00:34:17 <grzywacz> Hm.
2007-06-22T00:34:20 <grzywacz> What was my todo list?
2007-06-22T00:35:13 <xorAxAx> grzywacz: see the logs
2007-06-22T00:36:31 <grzywacz> Event handlers in config and a failing test. rgr.
2007-06-22T00:37:50 <xorAxAx> yes, generally failing tests :)
2007-06-22T00:38:02 <xorAxAx> there wont be any merge to trunk with failing tests in the branch .)
2007-06-22T00:38:52 <grzywacz> Good. :)
2007-06-22T00:40:20 <grzywacz> Hm, I see only two test failing.
2007-06-22T00:40:40 <grzywacz> Both in test_wikiutil.
2007-06-22T00:40:57 <grzywacz> And they don't seem to be related to my code... >_>
2007-06-22T00:41:01 <zenhase> hmm
2007-06-22T00:41:20 <zenhase> logging.info does not seem to work in moin.fcg
2007-06-22T00:41:37 <xorAxAx> grzywacz: pull from main
2007-06-22T00:41:53 <xorAxAx> grzywacz: if you still see failing tests, its because of you :)
2007-06-22T00:42:03 <zenhase> (i wanted to log the actual rendering of genshi, since i can't output it to the page anymore then)
2007-06-22T00:42:33 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2243:eca5a27e3eef 1.7/MoinMoin/_tests/test_formatter.py: Changed the formatter test to be py.test style, skip the docbook formatter test.
2007-06-22T00:42:38 <xorAxAx> zenhase: it doesnt go to your httpd's log?
2007-06-22T00:43:26 <xorAxAx> grzywacz: i am seeing a lot of failing tests
2007-06-22T00:43:32 <xorAxAx> grzywacz: 7 failing ones
2007-06-22T00:44:08 <CIA-27> moin: Florian Krupicka <florian.krupicka@googlemail.com> * 2064:efffaba4ed38 1.7-template-fkrupicka/MoinMoin/ (formatter/__init__.py theme/_genshitheme.py): Fixed missing clock.stop()s and added some more clocks
2007-06-22T00:44:15 <xorAxAx> grzywacz: looking forward to your push
2007-06-22T00:44:22 <xorAxAx> that will hopefully fix the 7
2007-06-22T00:44:29 <zenhase> xorAxAx: oh, i will look there then ;>
2007-06-22T00:44:47 <zenhase> xorAxAx: but as it's started as an external process i thought it would log to console as well
2007-06-22T00:44:57 <xorAxAx> hmm
2007-06-22T00:44:58 <xorAxAx> no idea
2007-06-22T00:45:08 <xorAxAx> i think it redirects both
2007-06-22T00:45:38 <zenhase> nothing in lightys logs
2007-06-22T00:45:54 <zenhase> and nothing on the console either
2007-06-22T00:46:06 <zenhase> well, i start a standalone instance on 8080 too
2007-06-22T00:46:35 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2244:d31998cd251c 1.7/wikiconfig.py: use wikiconfig_local.py for development config changes
2007-06-22T00:46:36 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2245:1b8b4e7bfba5 1.7/MoinMoin/_tests/test_formatter.py: merged main
2007-06-22T00:48:48 <zenhase> hmm
2007-06-22T00:49:46 <zenhase> with standalone i get 0.054s for HelpContents on modern and 0.032s + 0.031s for genshi
2007-06-22T00:50:31 <zenhase> but still it's not quite comparable, since there is still too much Markup(foo)-wrapped stuff in the template
2007-06-22T00:51:42 <ThomasWaldmann> if it stays like this or improves, that would be great :)
2007-06-22T00:52:20 <zenhase> we'll see when the actual templates evolve too
2007-06-22T00:52:49 <zenhase> but actually i have quite a good feeling about it
2007-06-22T00:53:11 <zenhase> and genshi 0.5 will bring c-speedup html-escaping
2007-06-22T00:54:20 <zenhase> those .replace('<','<').replace('>','>')... chains are always worth several calls in python
2007-06-22T00:54:50 <zenhase> and are done for every object not marked safe for html-output
2007-06-22T00:55:56 <zenhase> tomorrow i will start transplanting genshitheme away from the plugins
2007-06-22T00:57:01 <xorAxAx> zenhase: its not much faster in C
2007-06-22T00:57:23 <xorAxAx> because genshi operates on unicode
2007-06-22T00:59:51 <grzywacz> xorAxAx, weird.
2007-06-22T01:00:01 <xorAxAx> grzywacz: what? :)
2007-06-22T01:00:02 <grzywacz> I've pulled from main before reporting only two failing tests.
2007-06-22T01:00:21 <xorAxAx> grzywacz: did you push that already?
2007-06-22T01:00:27 <xorAxAx> i didnt pull from main locally yet
2007-06-22T01:00:33 <xorAxAx> i dont want to merge your stuff :)
2007-06-22T01:00:51 <grzywacz> I did "hg pull -u http://hg.thinkmo.de/moin/1.7"
2007-06-22T01:00:57 <xorAxAx> but did you push?
2007-06-22T01:01:14 <grzywacz> No.
2007-06-22T01:01:45 <grzywacz> fear
2007-06-22T01:02:13 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2167:b97040fcd8e1 1.7-jabber-knowak/MoinMoin/ (8 files in 2 dirs): added some new tests, move util tests to MoinMoin/util/_tests
2007-06-22T01:02:15 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2168:93e8ba421a88 1.7-jabber-knowak/ (10 files in 6 dirs): merge jabber branch
2007-06-22T01:02:16 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2169:7fed5edaa2a5 1.7-jabber-knowak/MoinMoin/_tests/ (test_formatter.py test_wikiutil.py): tests: some fixes
2007-06-22T01:02:18 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2170:eed1c7da25eb 1.7-jabber-knowak/MoinMoin/ (_tests/test_user.py user.py): test_user: fix wrong subscription tests and a few other problems
2007-06-22T01:02:19 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2171:a3a19bdc0b9a 1.7-jabber-knowak/ (5 files in 4 dirs): merge jabber branch
2007-06-22T01:02:21 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2172:c15ec6a2c69e 1.7-jabber-knowak/MoinMoin/_tests/ (test_request.py test_security.py test_wikiutil.py): reduce number of failing tests
2007-06-22T01:02:24 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2173:789c1a37e4ab 1.7-jabber-knowak/MoinMoin/_tests/ (test_formatter.py test_wikiutil.py): don't run docbook formatter test when we have no 4suite installed, add test for non-empty SystemPagesGroup
2007-06-22T01:02:28 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2174:f5f4dbbd0c51 1.7-jabber-knowak/MoinMoin/ (_tests/maketestwiki.py action/backup.py support/tarfile.py): added tarfile.py from py 2.5.1 (backported to work with py 2.3/2.4), fix imports to use it for tests/backup (ported from 1.6)
2007-06-22T01:02:36 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2175:7a3f7ac4f6e0 1.7-jabber-knowak/MoinMoin/ (_tests/test_formatter.py conftest.py formatter/text_xml.py): fix formatter setup for tests, skip broken dom_xml formatter test, add small/big to text_xml formatter (ported from 1.6)
2007-06-22T01:02:40 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2176:7917222e0e05 1.7-jabber-knowak/MoinMoin/util/_tests/test_util.py: MoinMoin.util: some tests added
2007-06-22T01:02:43 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2177:3719548ae9a2 1.7-jabber-knowak/MoinMoin/_tests/ (macro/test_Action.py macro/test_Hits.py test_macro_Hits.py): test of Hits moved to macro and converted for py.test, a test for the Action macro added
2007-06-22T01:02:47 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2178:e35adb666eca 1.7-jabber-knowak/MoinMoin/_tests/macro/test_ImageLink.py: test_ImageLink: some tests for ImageLink
2007-06-22T01:03:00 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2179:e81af778f99d 1.7-jabber-knowak/MoinMoin/logfile/editlog.py: fixed cleaning of edit comments
2007-06-22T01:03:03 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2180:80fc914af5c8 1.7-jabber-knowak/docs/ (CHANGES CHANGES.fpletz): integrated CHANGES.fpletz into main CHANGES, TODOs/unclear stuff went to MoinMoin:XapianIntegration
2007-06-22T01:03:07 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2181:340ae0e7529e 1.7-jabber-knowak/ (3 files in 3 dirs): replace xmlrpc getUser by getUserProfile, auth can be done by getAuthToken/applyAuthToken in the same multicall, use for interwiki auth
2007-06-22T01:03:11 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2182:261d406b560f 1.7-jabber-knowak/MoinMoin/_tests/ (4 files in 2 dirs): merged main
2007-06-22T01:03:14 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2183:d133bf86ed58 1.7-jabber-knowak/MoinMoin/macro/MonthCalendar.py: MonthCalendar: fix wrong relative links
2007-06-22T01:03:27 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2184:b3dc2a7d1cce 1.7-jabber-knowak/MoinMoin/i18n/Makefile: i18n Makefile fixes
2007-06-22T01:03:30 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2185:ca3e7fdab76e 1.7-jabber-knowak/moin.spec: fix date format in moin.spec file
2007-06-22T01:03:33 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2186:87cdbb744f1b 1.7-jabber-knowak/ (MoinMoin/parser/text_moin_wiki.py docs/CHANGES): revert the rest of changeset 1694: fdf01f9f3143 (except the bugfix)
2007-06-22T01:03:36 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2187:15c11fe8f6b2 1.7-jabber-knowak/MoinMoin/config/ (__init__.py multiconfig.py): config/multiconfig: minor cleanup
2007-06-22T01:03:39 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2188:30a153cfa8f8 1.7-jabber-knowak/MoinMoin/script/maint/mkpagepacks.py: Make testwiki check in mkpagepacks windows-compatible.
2007-06-22T01:03:52 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2189:a37491dbb605 1.7-jabber-knowak/MoinMoin/ (PageEditor.py security/__init__.py): Correctly check the ACL lists in the PageEditor for the admin check instead of the wrapping objects, reordered some comments and doc strings, return None instead of 0 in may if applicable. Should be ported to 1.7.
2007-06-22T01:03:57 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2190:a34d054835d3 1.7-jabber-knowak/MoinMoin/security/__init__.py: Added some documentation to the docstrings of MoinMoin.security, reordered some lines of code. Should be ported to 1.7.
2007-06-22T01:04:01 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2191:fc90d8319bba 1.7-jabber-knowak/MoinMoin/ (config/multiconfig.py security/__init__.py): Add hierarchical ACLs, clean the module doc string of MoinMoin.security.
2007-06-22T01:04:07 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2192:ab895b8095c4 1.7-jabber-knowak/MoinMoin/security/__init__.py: security: fix spelling, remove unneeded import
2007-06-22T01:04:12 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2193:cb913c851e91 1.7-jabber-knowak/MoinMoin/config/multiconfig.py: credits: added title attr, added some comments, added GPL credit
2007-06-22T01:04:15 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2194:3ae6b91e4f72 1.7-jabber-knowak/wiki/htdocs/ (3 files in 3 dirs): fixed order of .comment and .red/green/blue css definitions, copied them to classic and rightsidebar, fixes missing pre.comment css in rightsidebar
2007-06-22T01:04:21 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2195:386caaa698d8 1.7-jabber-knowak/MoinMoin/ (3 files in 2 dirs): comments: moved the check for the user setting to the formatter, fixes caching issue
2007-06-22T01:04:26 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2196:45cf51902c61 1.7-jabber-knowak/MoinMoin/parser/text_moin_wiki.py: wiki comment divs: fix caching behaviour
2007-06-22T01:04:29 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2197:9b404a43e59c 1.7-jabber-knowak/MoinMoin/theme/__init__.py: use standard RSS icon
2007-06-22T01:04:34 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2198:c3e140e98158 1.7-jabber-knowak/ (MANIFEST.in ChangeLog.15 ChangeLog): remove old tla ChangeLog from distribution
2007-06-22T01:04:37 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2199:2560c2182307 1.7-jabber-knowak/MoinMoin/macro/Action.py: macro.Action: link only if action is valid
2007-06-22T01:04:38 <xorAxAx> grzywacz: 2 failing tests
2007-06-22T01:04:42 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2200:e60ae8a23a49 1.7-jabber-knowak/MoinMoin/macro/Action.py: macro.Action: getValidAction uses builtin actions too
2007-06-22T01:04:44 <xorAxAx> grzywacz: and main has no failing tests
2007-06-22T01:04:47 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2201:4ef3b19e11e5 1.7-jabber-knowak/docs/CHANGES: Added CHANGES remark about hierarchical ACLs.
2007-06-22T01:04:50 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2202:f1972e32313a 1.7-jabber-knowak/MoinMoin/logfile/editlog.py: for SAVE/RENAME log entries we also announce the old pagename in news()
2007-06-22T01:04:55 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2203:7f76fff062c8 1.7-jabber-knowak/MoinMoin/macro/Action.py: macro.Action: fixed bug in getValidActions (don't nest lists)
2007-06-22T01:04:58 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2204:6a37ecdd79d5 1.7-jabber-knowak/MoinMoin/support/cgitb.py: fix cgitb XSS vulnerability (ported from 1.5 repo)
2007-06-22T01:05:03 <CIA-27> (41 lines omitted)
2007-06-22T01:05:22 <xorAxAx> grzywacz: now we may wonder why :)
2007-06-22T01:05:38 <grzywacz> :D
2007-06-22T01:05:44 <xorAxAx> we == you
2007-06-22T01:05:49 <xorAxAx> good luck and good night
2007-06-22T01:05:54 <grzywacz> Yeah, good night.
2007-06-22T01:05:58 <xorAxAx> ;-)
2007-06-22T01:16:27 <grzywacz> ...
2007-06-22T01:17:17 <grzywacz> I haven't changed anything (?), and now 2 other tests fail, namely testSyntaxReferenceDocBook and TestUnsafePackage().testBasicPackageThings
2007-06-22T01:17:52 <grzywacz> xorAxAx, and 1 test fails in main ;)
2007-06-22T01:18:10 <grzywacz> (the TestUnsafePackage)
2007-06-22T01:28:30 <grzywacz> None fail after I've re-emerged pyxml. -_-;
2007-06-22T01:28:39 <grzywacz> s/ne//
2007-06-22T01:31:38 <grzywacz> Hm, even better. One seems to be failing randomly.
2007-06-22T01:33:34 <grzywacz> "TestUnsafePackage().testBasicPackageThing" seems to be dying only when it's run after untaring a fresh underlay.
2007-06-22T01:33:38 <grzywacz> (In main 1.7)
2007-06-22T01:43:19 <ThomasWaldmann> btw, 1 test fails only for the first py.test run
2007-06-22T01:43:50 <ThomasWaldmann> yeah, that package thing
2007-06-22T01:44:44 <grzywacz> None fail in my branch atm.
2007-06-22T01:44:57 <grzywacz> Haven't changed anything besides re-emerging pyxml and deleting the old underlay.
2007-06-22T01:45:24 <ThomasWaldmann> the old underlay untaring code was broken
2007-06-22T01:45:33 <ThomasWaldmann> thanks to broken stdlib tarfile.py
2007-06-22T01:46:17 <grzywacz> Oh. Then no bufgixing per se to be done, good.
2007-06-22T09:53:53 <ThomasWaldmann> moin
2007-06-22T10:19:18 <vpv> I solved the weird problem with old paths raising errors, it was about the db_compiled.dat file that 4suite makes...
2007-06-22T10:31:41 <xorAxAx> grzywacz: yeah, wikidicts have been sucking for years :)
2007-06-22T10:54:07 <vpv> How should I handle authorization when doing the man page importing? support.BasicAuthTransport maybe?
2007-06-22T10:54:21 <xorAxAx> vpv: no
2007-06-22T10:54:28 <xorAxAx> vpv: do a multicall with applytoken
2007-06-22T10:59:31 <ffesti> zenhase, what did you do?
2007-06-22T11:00:14 <ffesti> my test page is now rendered in 0.011s which is 3 times faster than modern
2007-06-22T11:00:30 <ffesti> you are not cheating anywhere, aren't you?
2007-06-22T11:02:20 <xorAxAx> well, moins caching is pretty weird sometimes
2007-06-22T11:02:52 <ffesti> *argl* the total time is stopped to early...
2007-06-22T11:04:11 <xorAxAx> yes
2007-06-22T11:04:33 <xorAxAx> and the old code is also slowed down by transmission
2007-06-22T11:04:36 <xorAxAx> the new one isnt
2007-06-22T11:04:47 <xorAxAx> because the clocks are displayed before any transmission happens
2007-06-22T11:23:56 <grzywacz> *yawn*
2007-06-22T11:23:58 <grzywacz> Morning. ;)
2007-06-22T11:35:41 <zenhase> ffesti: i did nothing
2007-06-22T11:36:08 <zenhase> ffesti: also this does not include the actual genshi render
2007-06-22T11:36:10 <ffesti> ok, timing the output is a bit fishy
2007-06-22T11:36:13 <zenhase> wait a second
2007-06-22T11:36:19 <zenhase> and moin btw
2007-06-22T11:36:23 <ffesti> moin
2007-06-22T11:37:15 <ffesti> zenhase, did you get any results what is using up the time in the old MoinMoin?
2007-06-22T11:37:19 <xorAxAx> the actual rendering is most expensive in genshi after matching
2007-06-22T11:37:33 <xorAxAx> esp. because it does whitespace elimination
2007-06-22T11:37:58 <ffesti> That's stupid
2007-06-22T11:38:12 <xorAxAx> and other tasks
2007-06-22T11:38:17 <ffesti> and should be avoidable
2007-06-22T11:39:32 <xorAxAx> yes, thats one aspect of it ... i am just saying that using the clock values in its current form is bonkers
2007-06-22T11:40:27 <ffesti> and they won't get better
2007-06-22T11:40:43 <xorAxAx> yes
2007-06-22T11:47:34 <zenhase> well i added another clock around the actual .generate().render() call
2007-06-22T11:48:46 <zenhase> it currently uses up 0.030s on moin-standalone (still did not get fcgi to log this values to stdout)
2007-06-22T11:48:53 <ffesti> can you move the "total" and "run" clock down, please
2007-06-22T11:49:21 <ffesti> zenhase, IIRC stdout is redirected into the logfiles
2007-06-22T11:49:39 <zenhase> ffesti: which logfile?
2007-06-22T11:49:49 <ffesti> don't remember
2007-06-22T11:49:49 <zenhase> it's an external process to lighty
2007-06-22T11:50:04 <ffesti> xorAxAx, any idea?
2007-06-22T11:50:08 <zenhase> meaning it is not even started by lighty
2007-06-22T11:50:46 <zenhase> perhaps logging.basicConfig() is not called on FCGI?
2007-06-22T11:51:17 <zenhase> don't remember if this affects if the logging module outputs anything at all
2007-06-22T11:51:38 <xorAxAx> zenhase: well, then fix the logging first
2007-06-22T11:51:46 <xorAxAx> zenhase: reading the "logging" docs :)
2007-06-22T12:05:31 <zenhase> hmm
2007-06-22T12:15:01 <zenhase> ok, it was a strange combination of FCGI not having a real server (server-base configures std moin logging) and default loglevel being to high
2007-06-22T12:15:16 <zenhase> no i have output with .fcg too
2007-06-22T12:15:23 <zenhase> s/no/now
2007-06-22T12:15:58 <zenhase> hmm, funny
2007-06-22T12:16:19 <zenhase> for the same page it's 0.020s slower than a moin standalone server o_O
2007-06-22T12:18:18 <xorAxAx> because of buffering behaviour
2007-06-22T12:21:55 <xorAxAx> grzywacz: have you checked if there are really no difference between main and your branch wrt those wikiutil failures?
2007-06-22T12:30:21 <xorAxAx> dreimark: hmm, neagulm isnt using the event framework ... he should aim for that
2007-06-22T12:30:21 <grzywacz> xorAxAx, I haven't changed any wikiutil code, iirc. :)
2007-06-22T12:30:31 <grzywacz> xorAxAx, and no test fails, so I conclude that nothing should be broken.
2007-06-22T12:30:42 <xorAxAx> grzywacz: thats irrelevant :) for me, 2 tests are still failing
2007-06-22T12:31:01 <xorAxAx> because the test failures could be caused by other modules as well
2007-06-22T12:31:08 <grzywacz> xorAxAx, remove your old test/wiki directory and start it again
2007-06-22T12:31:10 <xorAxAx> the idea is that somebody could have done a broken merge
2007-06-22T12:31:14 <xorAxAx> grzywacz: ok
2007-06-22T12:31:23 <grzywacz> *tests/wiki
2007-06-22T12:31:47 <ThomasWaldmann> btw, test_packages still fails
2007-06-22T12:31:59 <grzywacz> On the first run, I presume?
2007-06-22T12:32:06 <ThomasWaldmann> yes
2007-06-22T12:32:14 <xorAxAx> ThomasWaldmann: yes, its on my list
2007-06-22T12:32:30 <xorAxAx> grzywacz: ok, so its the usual wikidicts breakage
2007-06-22T12:38:58 <xorAxAx> ThomasWaldmann: the packages test was broken by reimar in 10c60d1131dd
2007-06-22T12:39:21 <xorAxAx> i will find a fix
2007-06-22T12:52:30 <zenhase> xorAxAx: what do you mean by buffering behaviour?
2007-06-22T12:53:06 <zenhase> standalone does no buffering, fcgi does?
2007-06-22T12:54:54 <xorAxAx> zenhase: well, they buffer differently and the time used for transmission of data is included
2007-06-22T12:54:57 <xorAxAx> in the clock
2007-06-22T12:56:20 <zenhase> hmm
2007-06-22T12:56:38 <zenhase> standalone just writes to the stream directly i suppose
2007-06-22T12:56:59 <zenhase> and fcgi packages those strange fcgi records and gives them to the httpd
2007-06-22T12:57:52 <zenhase> yeah, this sounds reasonable ... kind of awful that a standalone server can actually perform better than fcgi :>
2007-06-22T13:07:37 <xorAxAx> grzywacz: how do you think about merging main and i will push your branch?
2007-06-22T13:07:44 <xorAxAx> grzywacz: or is it broken wrt the userform?
2007-06-22T13:13:19 * ThomasWaldmann fixed the user browser breakage
2007-06-22T13:13:44 <xorAxAx> yeah, thats something else
2007-06-22T13:40:47 <grzywacz> xorAxAx, what's wrong with userform?
2007-06-22T13:41:15 <xorAxAx> no idea, did you already include the event type selection?
2007-06-22T13:41:32 <grzywacz> Yes.
2007-06-22T13:42:17 <xorAxAx> cool
2007-06-22T13:42:25 <xorAxAx> so whats your next step?
2007-06-22T13:43:12 <grzywacz> Moving the event handlers to config, adding notification type selection maybe, adding more notification events.
2007-06-22T13:43:24 <grzywacz> Then general message class for event handlers to return their data.
2007-06-22T13:43:46 <grzywacz> Then, I think, I should do something about promised wiki editing via jabber. ;)
2007-06-22T13:43:51 <xorAxAx> yes
2007-06-22T13:44:09 <grzywacz> First text interface for core xmpp, then (probably in July) I'll start working on the data-forms based one.
2007-06-22T13:44:21 <grzywacz> I'm going to have a few exams soon, so it will be slow.
2007-06-22T13:44:49 <grzywacz> And now, I need to visit my uni to get some grades recorded, will be back in 2 hours or so.
2007-06-22T13:44:50 <grzywacz> :)
2007-06-22T14:02:55 <xorAxAx> grzywacz: ah, your branch is already completly pushed in main
2007-06-22T14:03:19 <xorAxAx> not a big unexpected result of nearly 3 days on inactivity :)
2007-06-22T15:12:36 <lanius> ThomasWaldmann: xorAxAx: Load.py:88-90 does it try to get the current revision of the page?
2007-06-22T15:15:28 <ThomasWaldmann> it just want to load new content into the item
2007-06-22T15:15:43 <lanius> into the current revision?
2007-06-22T15:16:45 <ThomasWaldmann> no, into the next (hopefully :)
2007-06-22T15:17:16 <lanius> pagedir = page.getPagePath("", check_create=0)
2007-06-22T15:17:17 <lanius> rev = Page.get_current_from_pagedir(page, pagedir)
2007-06-22T15:18:12 <ThomasWaldmann> iirc, rev is used here to tell the revision the "edit" is based on
2007-06-22T15:18:31 <ThomasWaldmann> if that is NOT current rev, PageEditor will think someone else saved in between
2007-06-22T15:18:42 <lanius> but this strange construct just gets the current revno?
2007-06-22T15:18:56 <ThomasWaldmann> looks like written after midnight :)
2007-06-22T15:19:05 <lanius> :-)
2007-06-22T15:20:51 <ThomasWaldmann> just try to do it less strange. either it will work or you'll notice why not :D
2007-06-22T15:21:50 <ThomasWaldmann> that Load action will have to get generalized to work with any sort of items anyway
2007-06-22T15:21:52 <lanius> ThomasWaldmann: what is the difference between get_current_from_pagedir and current_rev then
2007-06-22T15:22:08 <ThomasWaldmann> first is very lowlevel iirc
2007-06-22T15:22:15 <ThomasWaldmann> direct disk access
2007-06-22T15:22:47 <lanius> wherefor
2007-06-22T15:23:04 <ThomasWaldmann> maybe he wanted to avoid caching
2007-06-22T15:23:43 <lanius> you think that is needed?
2007-06-22T15:24:18 <ThomasWaldmann> maybe caching was broken at the time it was implemented
2007-06-22T15:25:22 <ThomasWaldmann> if you just make sure that it doesnt overwrite data, i guess it is fine
2007-06-22T15:26:08 <lanius> i want to remove the method :D
2007-06-22T15:46:27 <grzywacz> back
2007-06-22T15:50:47 <grzywacz> 3 days, huh. Weird.
2007-06-22T15:51:50 <grzywacz> xorAxAx, I'm going to move both lists: subscribable events and event handlers, to config class.
2007-06-22T15:52:05 <xorAxAx> sounds good
2007-06-22T15:59:28 <grzywacz> xorAxAx, the subscribable events list should be lazy-initialized, as it won't be needed often. This makes me wonder if I should use a wrapping object.
2007-06-22T16:00:16 <grzywacz> Hm, maybe explicit method would be more pythonish?
2007-06-22T16:01:35 <xorAxAx> grzywacz: a property
2007-06-22T16:02:03 <grzywacz> hm
2007-06-22T16:02:58 <grzywacz> Thanks. :)
2007-06-22T16:03:40 <xorAxAx> see the iwid property :)
2007-06-22T16:04:12 <grzywacz> I've already found it. :)
2007-06-22T16:54:40 <grzywacz> Hm.
2007-06-22T16:55:17 <grzywacz> I have to do it like this with event_handlers as well, because loading plugins depends on having a config object.
2007-06-22T16:55:29 <grzywacz> Obviously registering plugins i __init__ is not the best idea. ;)
2007-06-22T16:55:34 <grzywacz> s/plugins/handlers/
2007-06-22T16:55:58 <xorAxAx> ?
2007-06-22T16:56:04 <xorAxAx> grzywacz: self is your config object
2007-06-22T16:56:26 <grzywacz> But its state is not ready if I call it from __init__.
2007-06-22T16:56:33 <grzywacz> Well, maybe if I do this at the end...
2007-06-22T16:56:52 <xorAxAx> yeah, its an ordering question
2007-06-22T16:57:23 <grzywacz> Still, this seems quite messy.
2007-06-22T16:57:36 <grzywacz> Hm.
2007-06-22T16:57:37 <grzywacz> No.
2007-06-22T16:57:42 <xorAxAx> well, if you are using a separate function, you shouldnt touch __init__ at all, no?
2007-06-22T16:57:48 <xorAxAx> i mean such a lazy property thing
2007-06-22T16:57:49 <grzywacz> This won't work, sorry.
2007-06-22T16:58:02 <xorAxAx> hmm?
2007-06-22T16:58:26 * grzywacz has confused himself, wait a minute
2007-06-22T17:02:05 <grzywacz> xorAxAx, I'm not touching init for subscribable events.
2007-06-22T17:02:18 <xorAxAx> and i dont see why you would need to
2007-06-22T17:02:32 <grzywacz> But if we are to use the event system for more tasks, then having it initialised with config is perfectly ok.
2007-06-22T17:02:56 <xorAxAx> so when do you want to init it? in the property?
2007-06-22T17:03:16 <grzywacz> At the end of init seems to be safe.
2007-06-22T17:03:29 <xorAxAx> 17:02:05 < grzywacz> xorAxAx, I'm not touching init for subscribable events.
2007-06-22T17:03:32 <xorAxAx> ?
2007-06-22T17:03:49 <grzywacz> I'm talking about event handlers. Not the list of events that user can subscribe to.
2007-06-22T17:04:06 <grzywacz> These are separate.
2007-06-22T17:05:22 <xorAxAx> ah
2007-06-22T17:05:42 <xorAxAx> so you dont want to make events extensible?
2007-06-22T17:06:15 <grzywacz> Why?
2007-06-22T17:06:34 <xorAxAx> you mean why i think that you wont or why it would be interesting?
2007-06-22T17:07:54 <grzywacz> I mean why you think that I don't want. :)
2007-06-22T17:08:21 <xorAxAx> because you cannot do the init at module level if you want to have it extensible
2007-06-22T17:08:31 <xorAxAx> so it must be at config init time
2007-06-22T17:09:09 <grzywacz> It will be done in config. :o That's what I'm changing right now.
2007-06-22T17:09:26 <xorAxAx> ok :)
2007-06-22T17:17:58 <grzywacz> Ok, I'm going to push this. Please take a look if there are any obvious mistakes in there...
2007-06-22T17:19:19 <grzywacz> Hm, hg seems to be waiting forever again...
2007-06-22T17:22:16 <grzywacz> Ah, CIA's not here...
2007-06-22T17:22:41 <xorAxAx> and i can imagine why :)
2007-06-22T17:22:49 <grzywacz> :-D
2007-06-22T17:30:08 <xorAxAx> grzywacz: nameerror register_handlers while readin the source
2007-06-22T17:31:02 <xorAxAx> grzywacz: please write a unittest for that
2007-06-22T17:33:44 <grzywacz> weird
2007-06-22T17:33:56 <grzywacz> Could you paste me a traceback?
2007-06-22T17:34:06 <xorAxAx> i have none
2007-06-22T17:34:15 <xorAxAx> i cant find the place where the name comes from
2007-06-22T17:34:29 <grzywacz> I don't understand.
2007-06-22T17:34:56 <xorAxAx> MoinMoin/events/__init__.py contains register_handlers(cfg)
2007-06-22T17:35:01 <xorAxAx> where does register_handlers come from?
2007-06-22T17:35:08 <grzywacz> k
2007-06-22T17:35:35 <grzywacz> Why would that need a unittest? It's like a syntax error...
2007-06-22T17:35:43 <xorAxAx> its not a syntax error
2007-06-22T17:35:50 <xorAxAx> it would need a unittest that covers that line
2007-06-22T17:36:03 <xorAxAx> the moin test framework has code coverage support
2007-06-22T17:36:06 <grzywacz> This line is going away, I forgot to remove it.
2007-06-22T17:36:10 <xorAxAx> i know
2007-06-22T17:36:26 <xorAxAx> it would be nice if you could use code coverage testing
2007-06-22T17:36:30 <xorAxAx> see MoinMoin.conftest
2007-06-22T17:38:03 <grzywacz> Looking.
2007-06-22T17:38:29 <xorAxAx> some code coverage solutions print all module names
2007-06-22T17:38:39 <xorAxAx> this one wants to know which modules are covered by a unittest
2007-06-22T18:00:41 <grzywacz> xorAxAx, please take a look.
2007-06-22T18:06:26 <xorAxAx> grzywacz: please bail out if the secret is false
2007-06-22T18:06:58 <xorAxAx> assert is not a function
2007-06-22T18:07:27 <xorAxAx> in the tests, you get a request by adding a reqeust parameter to the function's sig
2007-06-22T18:07:56 <xorAxAx> and you still havent added the necessary bits for code coverage (its explained in conftest :))
2007-06-22T18:08:15 <grzywacz> :S
2007-06-22T18:13:50 <grzywacz> I fail to see what that is...
2007-06-22T18:14:16 <xorAxAx> we can do that together in a minute after you have addressed the other issues :)
2007-06-22T18:15:09 <grzywacz> xorAxAx, can I bail out on an empty secret string, rather than setting it to false? It would make it easier to edit the template for someone who doesn't know python's syntax.
2007-06-22T18:15:17 <grzywacz> s/false/None/
2007-06-22T18:16:06 <xorAxAx> grzywacz: just test for it with "if not cfg.foo:"
2007-06-22T18:16:17 <grzywacz> Yes, that's how it is now. Just not commited. ;)
2007-06-22T18:17:03 <xorAxAx> ok :)
2007-06-22T18:20:30 <xorAxAx> grzywacz: have you read the large comment in the conftest?
2007-06-22T18:20:39 <xorAxAx> it says how to enable code coverage testing
2007-06-22T18:21:20 <grzywacz> Actually, secret check should be in config.
2007-06-22T18:21:33 <grzywacz> xorAxAx, I did.
2007-06-22T18:21:52 <xorAxAx> have you downloaded the code coverage module?
2007-06-22T18:22:02 <grzywacz> Not yet.
2007-06-22T18:22:26 <xorAxAx> and then you need to add a global to your unit test according to:
2007-06-22T18:22:27 <xorAxAx> It prints a coverage report for the modules specified in all
2007-06-22T18:22:27 <xorAxAx> module globals (of the test modules) named "coverage_modules".
2007-06-22T18:23:03 <grzywacz> Does any other test file do that? :S
2007-06-22T18:23:13 <xorAxAx> no
2007-06-22T18:23:34 <xorAxAx> 99% of the unittests are legacy code
2007-06-22T18:24:03 <grzywacz> I see. I ended up browsing them for clues.
2007-06-22T18:24:30 <xorAxAx> :-)
2007-06-22T18:25:35 <grzywacz> So a list of functions?
2007-06-22T18:25:51 <grzywacz> I find this comment hard to understand, frankly.
2007-06-22T18:26:26 <xorAxAx> no, just module names
2007-06-22T18:26:33 <xorAxAx> like MoinMoin.events
2007-06-22T18:27:29 <grzywacz> As a string, I presume? ;)
2007-06-22T18:27:35 <xorAxAx> a list of strings :)
2007-06-22T18:27:47 <xorAxAx> btw, you can infer it from the few lines of code in the module :)
2007-06-22T18:27:54 <grzywacz> A list of modules names that this test is supposed to test?
2007-06-22T18:28:32 <xorAxAx> yes
2007-06-22T18:28:56 <xorAxAx> and then it builds a set of all module names and filters the code coverage report by those modules
2007-06-22T18:31:25 <grzywacz> So a strange looking line like: coverage_modules = ["MoinMoin.events"]
2007-06-22T18:31:28 <grzywacz> should be ok.
2007-06-22T18:31:53 <xorAxAx> why strange? :)
2007-06-22T18:32:19 <grzywacz> Because reading it aside from the code coverage framework is confusing. ;)
2007-06-22T18:33:03 <xorAxAx> well, people will get used to it :)
2007-06-22T18:33:42 <grzywacz> I guess...
2007-06-22T18:34:26 <xorAxAx> but maybe you have ideas for improvement, feel free :)
2007-06-22T18:35:24 <grzywacz> Not at the moment. ;)
2007-06-22T18:36:35 <grzywacz> Looks like raising exceptions in DefaultConfig's __init__ is not a good idea.
2007-06-22T18:37:37 <xorAxAx> if they are config errors, it should work out fine
2007-06-22T18:37:50 <xorAxAx> but even if they are not, it should be fine as well
2007-06-22T18:37:54 <xorAxAx> what doesnt work?
2007-06-22T18:38:16 <grzywacz> It ended with a nasty traceback.
2007-06-22T18:38:28 <grzywacz> Instead of Moin's Configuration Error page.
2007-06-22T18:38:31 <xorAxAx> a cgitb one in blue?
2007-06-22T18:38:38 <xorAxAx> well, then its a bug :)
2007-06-22T18:39:27 <grzywacz> Yes, no blue at all.
2007-06-22T18:51:34 <dreimark> bbl, shopping
2007-06-22T18:56:12 <grzywacz> xorAxAx, do you want me to put this check in DefaultConfig anyway, even if it produces an awful result? ;-)
2007-06-22T18:56:29 <xorAxAx> grzywacz: well, maybe you feel motivated enough to find the bug :)
2007-06-22T18:57:10 <grzywacz> Um... not. Not at the moment. I want to focus on my part for now. ;)
2007-06-22T18:57:46 <xorAxAx> then put it on the todo list :)
2007-06-22T19:00:35 <grzywacz> Done. For now I'm putting this in jabbernotification.py
2007-06-22T19:05:58 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2087:1c5a1a41c3c4 1.7-storage-hwendel/MoinMoin/storage/ (7 files in 2 dirs): introduce backend.name to identify where an item comes from; has_item now returns the backend on success
2007-06-22T19:07:12 <xorAxAx> +++ b/MoinMoin/_tests/test_events.py Fri Jun 22 18:54:13 2007 +0200
2007-06-22T19:07:13 <xorAxAx> @@ -9,13 +9,12 @@ from MoinMoin.request.CLI import Request from MoinMoin.request.CLI import Request
2007-06-22T19:07:13 <moinBot> xorAxAx: Error: "@" is not a valid command.
2007-06-22T19:07:18 <xorAxAx> grzywacz: useless import
2007-06-22T19:10:58 <grzywacz> ack...
2007-06-22T19:11:06 <grzywacz> Oh no, CIA is back. ;)
2007-06-22T19:12:17 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2088:109d3be088bf 1.7-storage-hwendel/MoinMoin/ (8 files in 6 dirs): create_item also returns the backend
2007-06-22T19:14:34 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2089:c85082a7c721 1.7-storage-hwendel/MoinMoin/ (Page.py action/Load.py): revert page.py and load.py, not ready to commit yet
2007-06-22T19:14:35 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2090:08725e0d22ca 1.7-storage-hwendel/MoinMoin/script/maint/mkpagepacks.py: revert mkpagepacks.py, not ready to commit yet
2007-06-22T19:17:43 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2091:4b879287ca91 1.7-storage-hwendel/MoinMoin/Page.py: fix the set_body property
2007-06-22T19:20:25 <grzywacz> xorAxAx, do you think that login failures (possibly only of SuperUsers) are interesting stuff to send notifications about? ;)
2007-06-22T19:20:43 <xorAxAx> hm, no
2007-06-22T19:20:54 <xorAxAx> it should be logged ... but thats unrelated to your work
2007-06-22T19:22:41 <grzywacz> Indeed. /me thinks about other possible notifications
2007-06-22T19:24:05 <xorAxAx> (nevertheless you can implement unrelated stuff or fix bugs :))
2007-06-22T19:24:08 <ThomasWaldmann> grzywacz: i guess it would be interesting
2007-06-22T19:24:36 <xorAxAx> but if i look into my auth.log and see how many people attempt to brute force my accounts every day ...
2007-06-22T19:24:47 <xorAxAx> i dont want to DOS a jabber server by that
2007-06-22T19:25:02 <ThomasWaldmann> you dont need to use it :)
2007-06-22T19:25:19 <xorAxAx> sure
2007-06-22T19:27:40 <ThomasWaldmann> lanius: {} :)
2007-06-22T19:28:46 <lanius> ThomasWaldmann: what is the difference?
2007-06-22T19:30:01 <ThomasWaldmann> less to type
2007-06-22T19:30:27 <lanius> ^^
2007-06-22T19:30:57 <lanius> but more difficult to type :-)
2007-06-22T19:31:50 <ThomasWaldmann> only if you have the wrong keyboard :)
2007-06-22T19:33:10 * ThomasWaldmann is reminded to reactivate .Xmodmap
2007-06-22T19:42:15 <xorAxAx> lanius: it makes sense to pool the special metadata keys somewhere as "constants"
2007-06-22T19:43:58 <ThomasWaldmann> xorAxAx: I suggest to either return backend.name or None (not False)
2007-06-22T19:44:16 <xorAxAx> ThomasWaldmann: do you mean lanius? :)
2007-06-22T19:44:43 <ThomasWaldmann> ehrm, sure %)
2007-06-22T19:45:20 <ThomasWaldmann> somehow your nick matched to None
2007-06-22T19:45:47 <xorAxAx> none? %-)
2007-06-22T19:48:43 <lanius> xorAxAx: yes, indeed
2007-06-22T19:49:18 <lanius> ThomasWaldmann: it won't make a difference, would it?
2007-06-22T19:50:09 <ThomasWaldmann> s/backend.name/backend/
2007-06-22T19:50:36 <ThomasWaldmann> well, it's a matter of style
2007-06-22T19:51:05 <ThomasWaldmann> if there is False, one would expect that it is boolean and also would return True sometimes
2007-06-22T19:51:35 <ThomasWaldmann> but if you either have some object or you have no object, None fits better
2007-06-22T19:52:24 <zenhase> hmm
2007-06-22T19:52:44 <zenhase> i tried to think of a way to speed up rendering of genshi
2007-06-22T19:54:13 <zenhase> actually almost all of the time is eaten in the serializer
2007-06-22T19:55:04 <xorAxAx> 19:53:33 < jgustak> arigato: i would like someone to show mi: do THIS now
2007-06-22T19:55:15 <zenhase> i will try to gain some performance by serializing in one complete step
2007-06-22T19:55:36 <xorAxAx> the student that we sold to pypy isnt very ... self-reliant :)
2007-06-22T19:55:45 <zenhase> not the unicode-yielding approach
2007-06-22T19:55:55 <xorAxAx> zenhase: serializing? :)
2007-06-22T19:56:11 <zenhase> xorAxAx: stream to output :>
2007-06-22T19:56:12 <lanius> ThomasWaldmann: ok, have to go now, if you have further comments i will read them later on
2007-06-22T19:56:28 <xorAxAx> zenhase: which steps are there currently?
2007-06-22T19:58:11 <zenhase> xorAxAx: for every stream event the build a buffer, build-up the element by appending, ''.join it and yield it then
2007-06-22T19:58:35 <xorAxAx> "the build a buffer"?
2007-06-22T19:58:45 <zenhase> well, it's a list
2007-06-22T19:58:53 <zenhase> wait a second
2007-06-22T19:59:03 <xorAxAx> the sentence is missing a word, isnt it?
2007-06-22T19:59:19 <zenhase> hmm no .. the the is missing a y
2007-06-22T19:59:20 <xorAxAx> 19:59:07 < jgustak> i think i have to create todo prority list
2007-06-22T19:59:22 <xorAxAx> hah
2007-06-22T19:59:28 <xorAxAx> zenhase: ah
2007-06-22T19:59:31 <zenhase> :>
2007-06-22T19:59:51 <xorAxAx> maybe jakob should learn from karol :)
2007-06-22T20:00:45 <grzywacz> ;-)
2007-06-22T20:01:29 <zenhase> everyone can learn from him ;>
2007-06-22T20:02:05 <grzywacz> :S
2007-06-22T20:02:19 <xorAxAx> 20:02:03 < arigato> jgustak: do you see what I mean?
2007-06-22T20:02:24 <xorAxAx> sounds pretty desperate
2007-06-22T20:10:45 <dreimark> #pypy
2007-06-22T20:15:07 <dreimark> ThomasWaldmann: don't peek with vim into py/test/collect.py -> red red red ;)
2007-06-22T20:15:33 <xorAxAx> dreimark: yes, thats the hpk drm system :)
2007-06-22T20:15:45 <xorAxAx> holger p. krekel was the author of most of py
2007-06-22T20:15:59 <xorAxAx> somehow his editor appends spaces everywhere
2007-06-22T20:16:54 <grzywacz> Looks good in my vim?
2007-06-22T20:17:04 <dreimark> and he uses l as var
2007-06-22T20:17:07 <grzywacz> This being: VIM - Vi IMproved 7.0 (2006 May 7, compiled May 9 2007 18:51:15)
2007-06-22T20:17:21 <dreimark> grzywacz: then you don't have the python pep8 extension
2007-06-22T20:17:23 <xorAxAx> grzywacz: then you dont have matching and colouring rules for spaces at th eend, and not toms PEP8 plugin
2007-06-22T20:17:42 <grzywacz> xorAxAx, indeed, I don't have them. :)
2007-06-22T20:18:02 <ThomasWaldmann> hehe
2007-06-22T20:18:02 <grzywacz> xorAxAx, where can I get 'em?
2007-06-22T20:18:13 <xorAxAx> grzywacz: ask ThomasWaldmann :)
2007-06-22T20:18:19 <grzywacz> ThomasWaldmann, I'm asking you. ;-)
2007-06-22T20:18:23 <dreimark> http://moinmoin.wikiwikiweb.de/CodingStyle
2007-06-22T20:18:24 <xorAxAx> and add this:
2007-06-22T20:18:26 <xorAxAx> highlight RedundantSpaces ctermbg=red guibg=red
2007-06-22T20:18:27 <xorAxAx> match RedundantSpaces /\s\+$\| \+\ze\t/
2007-06-22T20:18:27 <xorAxAx> highlight Tabs ctermbg=yellow guibg=yellow
2007-06-22T20:18:27 <xorAxAx> match Tabs /^\t\+/
2007-06-22T20:18:27 <ThomasWaldmann> grzywacz: it is in the wiki, page CodingStyle (or so)
2007-06-22T20:18:40 <dreimark> grzywacz: CodingStyle
2007-06-22T20:18:51 <xorAxAx> dreimark: yes, the l is by holger :)
2007-06-22T20:19:13 <ThomasWaldmann> best is to use ll and l1 mixed
2007-06-22T20:19:24 <grzywacz> :D
2007-06-22T20:19:41 <dreimark> 1l does not work
2007-06-22T20:19:45 <dreimark> ;)
2007-06-22T20:20:08 <ThomasWaldmann> dreimark: it does, on the right side
2007-06-22T20:20:30 <ThomasWaldmann> ll = l1 + 1l
2007-06-22T20:20:37 <grzywacz> oh god...
2007-06-22T20:21:29 <ThomasWaldmann> later: ll *= 2
2007-06-22T20:21:50 <xorAxAx> but not in that file :)
2007-06-22T20:22:28 * grzywacz 2nd coffee
2007-06-22T20:42:37 * zenhase is an idiot
2007-06-22T20:42:58 <zenhase> it is not .render that eats up the time o_O
2007-06-22T20:43:06 <xorAxAx> but? :)
2007-06-22T20:43:07 <zenhase> it's .generate
2007-06-22T20:43:12 <xorAxAx> ah
2007-06-22T20:43:26 <zenhase> i forgot that .generate gives a generator
2007-06-22T20:43:37 <xorAxAx> hah
2007-06-22T20:43:37 <zenhase> so measuring time always yielded 0.000s
2007-06-22T20:43:41 <xorAxAx> hah
2007-06-22T20:43:45 * grzywacz implementing the generic message class
2007-06-22T20:43:55 <zenhase> if i expand the generator it's 0.035s for helpcontents
2007-06-22T20:43:56 <grzywacz> Coffee is working, I feel alive again. ;)
2007-06-22T20:44:00 <xorAxAx> grzywacz: for return values? :)
2007-06-22T20:44:04 <grzywacz> xorAxAx, yes.
2007-06-22T20:44:09 <zenhase> the actual render is 0.005s
2007-06-22T20:50:15 * grzywacz falls in love with unit tests
2007-06-22T20:50:34 <xorAxAx> on june 22th :)
2007-06-22T20:50:54 <grzywacz> I should make a note of this date. ;-)
2007-06-22T20:51:17 <xorAxAx> and celebrate it every year :)
2007-06-22T20:51:53 <grzywacz> As an Unit Test Day. World-wide. ;-)
2007-06-22T20:52:11 <xorAxAx> no, just in poland :)
2007-06-22T20:52:16 <grzywacz> :<
2007-06-22T20:52:17 <grzywacz> Why?
2007-06-22T20:52:38 <xorAxAx> no idea
2007-06-22T21:01:45 <grzywacz> ImportError: cannot import name packages
2007-06-22T21:01:46 <grzywacz> erm
2007-06-22T21:01:50 <xorAxAx> grzywacz: do you want to see some Kaczynski parody? :)
2007-06-22T21:01:56 <grzywacz> xorAxAx, always. ;-)
2007-06-22T21:02:00 <xorAxAx> (in german, no idea how good your german is :))
2007-06-22T21:02:09 <xorAxAx> mms://213.254.239.51/ndr/msmedia/2007/0621/TV-20070621-2334-0801.wm.hi.wmv
2007-06-22T21:02:14 <grzywacz> It's not, but our government is funny in all languages. :P
2007-06-22T21:02:42 <xorAxAx> there two 2 twins called Schlüterinsky which are allegedly more important than the Kaczynski twins
2007-06-22T21:05:30 <grzywacz> Looks funny. [;
2007-06-22T21:07:27 <xorAxAx> esp. the teletubby
2007-06-22T21:09:12 <xorAxAx> grzywacz: how much did you understand?
2007-06-22T21:10:07 <grzywacz> Very little.
2007-06-22T21:10:49 <xorAxAx> hehe
2007-06-22T21:11:08 <xorAxAx> but the images were very expressive
2007-06-22T21:11:11 <grzywacz> Like: "very little language".
2007-06-22T21:11:21 <grzywacz> Yes, more of the clip than of the language itself.
2007-06-22T21:11:26 <grzywacz> It's sad in a way, though. ;)
2007-06-22T21:17:58 <grzywacz> I've broken py.test. It fails to collect more than 1 test... wtf?
2007-06-22T21:18:06 <xorAxAx> hmm
2007-06-22T21:18:16 <xorAxAx> did you modify conftest?
2007-06-22T21:18:24 <grzywacz> No.
2007-06-22T21:18:25 <xorAxAx> in which directory are you currently?
2007-06-22T21:18:27 <grzywacz> E from MoinMoin import config, wikiutil, packages
2007-06-22T21:18:27 <grzywacz> > ImportError: cannot import name packages
2007-06-22T21:18:29 <grzywacz> ?!?!!
2007-06-22T21:18:47 <grzywacz> In _tests
2007-06-22T21:18:58 <xorAxAx> hmm
2007-06-22T21:19:04 <xorAxAx> maybe a recursive include?
2007-06-22T21:19:23 <grzywacz> Maybe, let me check it.
2007-06-22T21:25:33 <grzywacz> Can't find any...
2007-06-22T21:30:19 <grzywacz> I'm totally confused.
2007-06-22T21:32:38 <xorAxAx> hmm
2007-06-22T21:32:46 <xorAxAx> paste the traceback into a pastebin
2007-06-22T21:34:17 <grzywacz> http://rafb.net/p/Du2Hur67.html
2007-06-22T21:42:32 <grzywacz> oh
2007-06-22T21:43:52 <grzywacz> There was one... -_-;
2007-06-22T21:44:01 <xorAxAx> a recursive import :)
2007-06-22T21:44:18 <xorAxAx> put the getAttachUrl import into the function
2007-06-22T21:44:24 <xorAxAx> that is using it
2007-06-22T21:44:56 <grzywacz> Did so.
2007-06-22T21:58:50 <xorAxAx> Omoikane(思兼) is a Shinto god of knowledge. His name means "serving one's thoughts."
2007-06-22T21:58:54 <xorAxAx> ah
2007-06-22T21:59:48 <grzywacz> :)
2007-06-22T22:01:02 <grzywacz> Also: Omoikane (思兼) is the artificially intelligent ship's computer of the Nadesico. It is named after the Shinto god Omoikane.
2007-06-22T22:01:16 <xorAxAx> my backup server is called memoire
2007-06-22T22:01:17 <grzywacz> Also: The Japanese phrase "重い鐘", which has the same pronunciation "omoi-kane", means "heavy bell".
2007-06-22T22:01:18 <grzywacz> ;-)
2007-06-22T22:01:29 <grzywacz> Fine name. :)
2007-06-22T22:01:43 <xorAxAx> Omoikane (Linux) is a Japanese linux distribution.
2007-06-22T22:01:49 <grzywacz> Yes. :)
2007-06-22T22:05:11 <grzywacz> Oooh, I've just found some stupid design.
2007-06-22T22:05:13 * grzywacz fixes
2007-06-22T22:17:34 <grzywacz> If someone decides to get notified by email *and* jabber, should his name appear twice on the recipient list displayed after, for example, saving a page, or should I filter it and leave only unique ones?
2007-06-22T22:18:56 <xorAxAx> hmm, is it very personal to see the notification method?
2007-06-22T22:19:07 <xorAxAx> i dont think so, so show both and differentiate them somehow
2007-06-22T22:20:12 <grzywacz> Notification method doesn't matter at all.
2007-06-22T22:20:25 <grzywacz> And I doubt if many users will decide to get notifications twice.
2007-06-22T22:21:45 <xorAxAx> hmm, then show it once
2007-06-22T23:01:25 <dreimark> gn
2007-06-22T23:25:11 <Fabi> zenhase, can you write down the results of your timings in the wiki, please?
2007-06-22T23:27:10 <Fabi> especially the details of the non Genshi half
2007-06-22T23:28:14 <grzywacz> xorAxAx, what logging facility should I use to report stuff like errors in communication with the notification bot?
2007-06-22T23:28:22 <grzywacz> They are not critical enough to let the exception through.
2007-06-22T23:28:48 <grzywacz> But they may be annoying, so at least *some* logging in verbose/debug mode is necessary...
2007-06-22T23:30:04 <xorAxAx> grzywacz: the logging module :)
2007-06-22T23:30:58 <Fabi> zenhase, its not surprising that generate uses up the time. Render does only simple assembling of the single elements.
2007-06-22T23:31:11 <zenhase> Fabi: yep
2007-06-22T23:31:21 <grzywacz> xorAxAx, which one? I kind of lost track of it. MoinMoin.logfile doesn't look like the thing I'm looking for? ;)
2007-06-22T23:31:22 <Fabi> while all the replacements are done in generate
2007-06-22T23:31:23 <zenhase> i tried hotshotting genshi too
2007-06-22T23:31:32 <xorAxAx> grzywacz: "logging" it is called
2007-06-22T23:31:37 <xorAxAx> zenhase: DO NOT USE HOTSHOT
2007-06-22T23:31:41 <zenhase> to find what's eating in genshi itself
2007-06-22T23:31:43 <xorAxAx> or you will fail SOC
2007-06-22T23:31:50 <zenhase> xorAxAx: AHHH!
2007-06-22T23:31:54 <Fabi> Hey!
2007-06-22T23:31:56 <xorAxAx> but cprofile
2007-06-22T23:32:01 <zenhase> xorAxAx: have a good suggestion for profiling?
2007-06-22T23:32:01 <grzywacz> lol
2007-06-22T23:32:08 <zenhase> ok
2007-06-22T23:32:12 * Fabi writes the reports
2007-06-22T23:32:13 <xorAxAx> :-)
2007-06-22T23:32:23 <Fabi> for whatever reason
2007-06-22T23:32:25 <grzywacz> xorAxAx, ah, the stdlib one, ok. ;)
2007-06-22T23:32:43 <xorAxAx> grzywacz: somebody introduced it sometime in moin and it might be working some bit
2007-06-22T23:33:37 <grzywacz> xorAxAx, ok. I'll start tomorrow morning and add this to both the jabber bot (because it's time to get rid of prints) and my notification code where it's needed.
2007-06-22T23:33:56 <grzywacz> Right now vision is getting blurry, so commit, push and break...
2007-06-22T23:34:00 <grzywacz> *my vision
2007-06-22T23:34:10 <xorAxAx> well
2007-06-22T23:34:19 <xorAxAx> on the jabber side, i suggested having some callback to the wiki
2007-06-22T23:34:21 <xorAxAx> via XMLRPC
2007-06-22T23:34:28 * Fabi -> bed
2007-06-22T23:34:30 <Fabi> n8
2007-06-22T23:34:35 <xorAxAx> which gets dispatched via events to e.g. the admin
2007-06-22T23:34:39 <zenhase> hmm
2007-06-22T23:34:57 <grzywacz> xorAxAx, yes, but the xmlrpc call may not even get there. This is when casual logging is going to help.
2007-06-22T23:35:00 <grzywacz> ;)
2007-06-22T23:35:09 <xorAxAx> grzywacz: well, that should go to the ordinary console
2007-06-22T23:35:14 <zenhase> seems i don't have cprofile
2007-06-22T23:35:18 <xorAxAx> but i think thats ok
2007-06-22T23:35:21 <xorAxAx> zenhase: you need 2.5
2007-06-22T23:35:23 <zenhase> *scratches head*
2007-06-22T23:35:29 <xorAxAx> or download lsprof from arigo-hack
2007-06-22T23:35:29 <zenhase> xorAxAx: ok, that explains
2007-06-22T23:36:06 <grzywacz> xorAxAx, can't logging log to syslog as well?
2007-06-22T23:36:22 <xorAxAx> grzywacz: yes
2007-06-22T23:36:29 <xorAxAx> grzywacz: but you need to sync the logging setups somehow
2007-06-22T23:36:33 <xorAxAx> or make it configurable
2007-06-22T23:36:49 <grzywacz> Right, I'll try to figure out the right way.
2007-06-22T23:47:02 <xorAxAx> gn Fabi
2007-06-22T23:50:39 <grzywacz> Hm.
2007-06-22T23:50:47 <grzywacz> I might have broken something performance wise.
2007-06-22T23:50:54 <grzywacz> Will take a closer look at it tomorrow as well.
2007-06-22T23:50:56 <xorAxAx> why?
2007-06-22T23:51:03 <grzywacz> Tests are taking much longer to complete.
2007-06-22T23:51:31 <xorAxAx> because you are using code covergae? :)
2007-06-22T23:51:48 <grzywacz> ok, right.
2007-06-22T23:51:58 <grzywacz> Forgot about this silly thing in my python path.
2007-06-22T23:51:58 <grzywacz> ;)
2007-06-22T23:52:10 <xorAxAx> but its only active if you use the option
2007-06-22T23:55:11 <grzywacz> Blearh, I've commited a broken bot config again.
2007-06-22T23:55:12 <grzywacz> :S MoinMoin: MoinMoinChat/Logs/moin-dev/2007-06-22 (last edited 2007-10-29 19:20:30 by localhost)
