2007-06-17T00:00:34 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2136:42b85d3d3f8f 1.7/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: unittest for macro Hits
2007-06-17T00:00:39 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2137:3741d741113e 1.7/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: change in comments
2007-06-17T00:00:40 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2138:0fe9e533f00e 1.7/MoinMoin/_tests/test_macro_Hits.py: test_macro_Hits: removed some unused imports
2007-06-17T00:00:41 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2139:3accd05a36f3 1.7/ (22 files in 10 dirs): Merge with my branch
2007-06-17T00:00:53 <xorAxAx> lanius: '%r'
2007-06-17T00:01:00 <xorAxAx> lanius: just %r is better
2007-06-17T00:02:04 <ThomasWaldmann> grzywacz: soon, there might be 2 kinds of logs less anyway
2007-06-17T00:04:07 <xorAxAx> ThomasWaldmann: if body.startswith('<?xml'): # check for XML content
2007-06-17T00:04:13 <xorAxAx> ThomasWaldmann: how was that handled in 1.6?
2007-06-17T00:04:18 <xorAxAx> why is it necessary now
2007-06-17T00:04:47 <ThomasWaldmann> i didnt change that part
2007-06-17T00:05:24 <ThomasWaldmann> i just added some empty acl, so it doesnt trigger keyerror
2007-06-17T00:05:44 <ThomasWaldmann> and a comment, that this stuff should be removed when we have separate metadata
2007-06-17T00:05:47 <xorAxAx> yes, who added it?
2007-06-17T00:06:19 <xorAxAx> you did :)
2007-06-17T00:06:22 <xorAxAx> http://hg.alexanderweb.de/moin-1.7-jabber-knowak/annotate/b07b4c102d3d/MoinMoin/Page.py
2007-06-17T00:06:39 <xorAxAx> better, http://hg.alexanderweb.de/moin-1.7-jabber-knowak/rev/b07b4c102d3d
2007-06-17T00:07:06 <xorAxAx> ah, before it was in the pi parser
2007-06-17T00:07:22 <xorAxAx> but i wonder why it needs an xml default
2007-06-17T00:07:28 <xorAxAx> it worked without before
2007-06-17T00:08:02 <ThomasWaldmann> it is just refactored old code
2007-06-17T00:08:16 <xorAxAx> well ...
2007-06-17T00:08:30 <xorAxAx> maybe its returning too early
2007-06-17T00:08:34 <xorAxAx> the parse function
2007-06-17T00:09:09 <dreimark> isnt't that needed to determine the mime type
2007-06-17T00:09:23 <ThomasWaldmann> if content starts with <?xml there is nothing else there to see
2007-06-17T00:09:44 <xorAxAx> yes, but you have to duplicate the default values :)
2007-06-17T00:09:48 <lanius> xorAxAx: i thought i eliminated all '', have to look again
2007-06-17T00:10:08 <xorAxAx> lanius: reading the diff helps :)
2007-06-17T00:10:22 <lanius> not neccessarily
2007-06-17T00:10:43 <xorAxAx> increasing the font size helps sometimes as well :)
2007-06-17T00:11:00 <ThomasWaldmann> heh
2007-06-17T00:11:06 <lanius> he, it's really small on 1400x1050 with 14"
2007-06-17T00:11:22 <xorAxAx> on windows you have a problem, indeed
2007-06-17T00:11:36 <xorAxAx> better font hinting but no free scalable fonts
2007-06-17T00:11:38 <ThomasWaldmann> mine is smaller :-P
2007-06-17T00:11:44 <lanius> :D
2007-06-17T00:12:15 <xorAxAx> (generally i mean. of course in this case you can adjust the font size of the console or use a better console)
2007-06-17T00:14:32 <lanius> anymore comments on my last commit
2007-06-17T00:15:55 * ThomasWaldmann starts reading
2007-06-17T00:24:08 <ThomasWaldmann> lanius: try: return self.__revision_objects[revno]; except KeyError: ...
2007-06-17T00:26:46 <ThomasWaldmann> some lines below: try: del ... except KeyError: pass
2007-06-17T00:28:03 <lanius> k
2007-06-17T00:32:50 <ThomasWaldmann> + _handle_error(self, err, name, message = "Failed to remove item %r.") remove blanks around = please
2007-06-17T00:33:22 <lanius> oh, yeah
2007-06-17T00:34:46 <ThomasWaldmann> + data = open(os.path.join(self.path, name, "current"), "r") of course this works, but maybe rather use file()
2007-06-17T00:35:08 <lanius> is there any differenz?
2007-06-17T00:37:41 <ThomasWaldmann> open is the old way, file is the file object constructor
2007-06-17T00:38:12 <ThomasWaldmann> + file_descriptor = open(real_path, "w") <- no, it is a file_object :)
2007-06-17T00:39:05 <ThomasWaldmann> fd is what you get in C from a open call
2007-06-17T00:41:02 <ThomasWaldmann> btw, when using those errno.XX constants, is this portable to win32 then?
2007-06-17T00:41:27 <xorAxAx> hopefully he has tests :)
2007-06-17T00:41:40 <xorAxAx> in that case, the answer is yes because he is using windows :)
2007-06-17T00:42:02 <lanius> :-) both is true
2007-06-17T00:44:27 <lanius> btw. what happens to open files that are not closed like those ones:
2007-06-17T00:44:30 <lanius> data = codecs.open(os.path.join(self.path, name, "revisions", get_rev_string(revno)), "r", config.charset).readlines()
2007-06-17T00:47:48 <ThomasWaldmann> they get garbage collected
2007-06-17T00:48:16 <ThomasWaldmann> but better avoid
2007-06-17T00:48:21 <johill> grzywacz: how can 'global server' work with multiple wikis?
2007-06-17T00:48:31 <johill> anyway, I probably need sleep to see through this
2007-06-17T00:49:19 <grzywacz> # Implement user creation notification event handlers.
2007-06-17T00:49:32 <grzywacz> Actually, I think I have this ready in my devel branch since this morning. :-D
2007-06-17T00:51:17 <xorAxAx> grzywacz: you still havent fixed the server global?
2007-06-17T00:54:59 <ThomasWaldmann> http://www.surbl.org/ nice
2007-06-17T00:55:47 <xorAxAx> oooold
2007-06-17T00:57:14 <lanius> ThomasWaldmann: seems you are done reading the diff ,)
2007-06-17T00:59:05 <ThomasWaldmann> yes
2007-06-17T01:00:56 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2074:bd9dbdd91116 1.7-storage-hwendel/MoinMoin/storage/backends.py: fix left over '%r'
2007-06-17T01:00:57 <CIA-27> moin: Heinrich Wendel <h_wendel@cojobo.net> * 2075:3affa69273fa 1.7-storage-hwendel/MoinMoin/storage/ (external.py fs_moin16.py): small fixes
2007-06-17T01:01:40 <dreimark> gn
2007-06-17T01:05:22 <ThomasWaldmann> hmmm, surbl recognizes none of the recent spams
2007-06-17T01:43:34 <ThomasWaldmann> http://www.youtube.com/watch?v=9SUA7C0cBd8 hehe
2007-06-17T01:58:24 <grzywacz> xorAxAx, I think I don't understand how multiple wikis play together (in regard to a global server)
2007-06-17T02:09:32 <xorAxAx> grzywacz: just use the request.cfg object
2007-06-17T02:09:42 <xorAxAx> grzywacz: or better, init your ServerProxy in the multiconfig class
2007-06-17T02:10:02 <xorAxAx> and then fetch it via request.cfg
2007-06-17T02:10:50 <grzywacz> xorAxAx, multiconfig.DefaultConfig?
2007-06-17T02:11:57 <xorAxAx> yes
2007-06-17T02:46:08 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2136:05557f1ce219 1.7-jabber-knowak/MoinMoin/events/emailnotify.py: Fix sending of email notifications after changes to messages.py
2007-06-17T02:46:09 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2137:f153b3155240 1.7-jabber-knowak/ (4 files in 3 dirs): Send notifications about creation of users to Superusers with JID set.
2007-06-17T02:46:10 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2138:85854afc1aa2 1.7-jabber-knowak/ (5 files in 3 dirs): Merge with my devel branch.
2007-06-17T02:48:08 <grzywacz> Hm, I think I was supposed to write a test case for the broken xmlrpc multicall code. ;S
2007-06-17T02:49:34 <zenhase> hmm, i am still looking where to put the template-listing and -loading in the current plugin-loading infrastructure
2007-06-17T02:49:56 <grzywacz> What exactly do you mean?
2007-06-17T02:49:59 <zenhase> but it's really confusing me right now :>
2007-06-17T02:50:26 <grzywacz> MoinMoin/wiki/data/plugin?
2007-06-17T02:50:48 <grzywacz> I'm not sure if I got your question right, though. ^^;
2007-06-17T02:52:03 <zenhase> more like wikiutil.py and RequestBase.loadTheme
2007-06-17T02:52:44 <grzywacz> Then I did not. :)
2007-06-17T02:54:46 <zenhase> since my prototype theme shall behave more like something like a multi-theme (it shall serve multiple different layouts) those additional themes provided by different html-templates don't really go well with the plugin infrastructure i suppose
2007-06-17T02:55:38 <zenhase> btw. reading the plugin-loading and module importer code raised a question:
2007-06-17T02:56:16 <zenhase> was this code there from the beginnings of moinmoin?
2007-06-17T03:23:52 <grzywacz> ThomasWaldmann, is there any way I could edit HelpOnConfiguration in the main wiki/moinmaster? It displays to me as a "static pages", so I can't do any editing?
2007-06-17T03:36:29 <zenhase> *yawn* i will catch some sleep now and tomorrow will take on the problems with a fresh view
2007-06-17T03:36:47 <zenhase> gn8 then
2007-06-17T03:37:28 <grzywacz> Night. I'm going to take a nap as well.
2007-06-17T08:06:23 <ThomasWaldmann> grzywacz: just read MoinMoin:EditingOnMoinMaster
2007-06-17T12:09:47 <grzywacz> I did.
2007-06-17T13:14:27 <johill> grzywacz: moinmaster is supposed to be 1.6 right now anyway
2007-06-17T13:15:25 <johill> I already put some doc updates onto http://moinmoin.wikiwikiweb.de/MoinMoinTodo/Release_1.7
2007-06-17T13:33:12 <johill> ThomasWaldmann: uh, please make the email notifications use moinmoin.wikiwikiweb.de again, nobody's going to be logged in to moinmo.in
2007-06-17T13:33:35 <xorAxAx> johill: hmm?
2007-06-17T13:33:46 <xorAxAx> johill: then you have to login :)
2007-06-17T13:34:10 <xorAxAx> and i think the notifications will use the URL the editor used
2007-06-17T13:35:37 <johill> oh
2007-06-17T13:36:07 <johill> I thought they used the sort of canonical url
2007-06-17T13:36:21 <johill> moinmoi.in is a nice hack but I don't think it should be the canonical url
2007-06-17T13:36:36 <xorAxAx> why?
2007-06-17T13:36:46 <johill> because moinmaster, test, ...
2007-06-17T13:37:04 <xorAxAx> master.moinmo.in
2007-06-17T13:37:09 <xorAxAx> test.moinmo.in etc.
2007-06-17T13:37:28 <johill> hm
2007-06-17T13:37:34 <johill> oh well
2007-06-17T13:37:53 <johill> I think it's really hard to change the canonical urls now, but hey
2007-06-17T13:40:14 <xorAxAx> as long as both work, who cares? :)
2007-06-17T13:40:22 <xorAxAx> the canonical URL starts with purl.org anyway
2007-06-17T13:40:34 <xorAxAx> and nobody is using it anymore :)
2007-06-17T13:41:37 <johill> heh
2007-06-17T15:14:56 <ThomasWaldmann> moin
2007-06-17T15:15:12 <grzywacz> moin
2007-06-17T15:27:22 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2139:b01a6ef1be4c 1.7-jabber-knowak/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Get rid of the global xmlrpc Server object. Instantiate one in config.
2007-06-17T15:27:29 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2140:8181ec5cd86c 1.7-jabber-knowak/MoinMoin/ (config/multiconfig.py events/jabbernotify.py): Merge with my devel branch.
2007-06-17T16:45:21 <zenhase> hi there
2007-06-17T16:46:00 <grzywacz> hello zenhase
2007-06-17T16:46:26 <zenhase> hello grzywacz :>
2007-06-17T16:46:30 <dreimark> moin zenhase and grzywacz
2007-06-17T16:47:04 <grzywacz> hi dreimark :)
2007-06-17T16:49:00 <dreimark> I ve got a bad cold and we have so nice weather here.
2007-06-17T16:50:12 <grzywacz> Oh, poor you... I recommend some tea with honey and lemon juice in this case. 8)
2007-06-17T16:51:04 <dreimark> yeah and some pure vitamine C
2007-06-17T16:51:34 <grzywacz> Yes, that too.
2007-06-17T16:53:57 <dreimark> grzywacz: are there some docs available how to start with jabber and your merged branch
2007-06-17T16:54:23 <grzywacz> dreimark, not yet.
2007-06-17T16:54:30 <grzywacz> Maybe by evening there will be some. :)
2007-06-17T16:57:42 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2141:7def1e49e757 1.7-jabber-knowak/jabberbot/config.py: Add a sample config for the notification bot.
2007-06-17T16:57:56 <dreimark> :)
2007-06-17T16:58:05 <grzywacz> dreimark, basically, you have to supply some valid values to the jabber bot config and you wikiconfig.
2007-06-17T16:58:31 <grzywacz> You may want to look at wiki/config/more_samples/jabber_wikiconfig.py
2007-06-17T16:59:00 <grzywacz> Also, you need a jabber account for bot to use.
2007-06-17T16:59:12 <grzywacz> Then all is left, is starting the bot&wiki.
2007-06-17T17:04:36 <grzywacz> I think that one day wiki might start the bot automatically, if configured to do so. A little bit easier than getting both started manually.
2007-06-17T17:06:53 <grzywacz> dreimark, I'd be glad if you actually tested this. 8)
2007-06-17T17:09:25 <dreimark> grzywacz: i will peak into it in the next days
2007-06-17T17:09:49 <dreimark> currently I better not try to be productive
2007-06-17T17:10:33 <grzywacz> Sure. :) You'll have some step-by-step installation docs by then.
2007-06-17T17:28:34 <grzywacz> johill, ok, added: http://moinmoin.wikiwikiweb.de/MoinMoinTodo/Release_1.7/HelpOnNotification
2007-06-17T17:41:18 <ThomasWaldmann> grzywacz: how does this xmlrpc_server work for multiple or shortrunning moin processes?
2007-06-17T17:42:19 <grzywacz> ThomasWaldmann, you mean in bot's config?
2007-06-17T17:42:44 <ThomasWaldmann> multiconfig
2007-06-17T17:43:11 <grzywacz> Ah. It only affects CGI.
2007-06-17T17:43:21 <grzywacz> And it only parses the url, according to xorAxAx.
2007-06-17T17:43:29 <grzywacz> So not much of a performance hit.
2007-06-17T17:44:31 <ThomasWaldmann> ah, so this is a ServerProxy (not a server itself)
2007-06-17T17:45:25 <ThomasWaldmann> sorry, that bad naming confused me
2007-06-17T17:45:42 <grzywacz> Yes, doesn't serve anything.
2007-06-17T17:45:48 <grzywacz> No problem, my bad naming did this. ;)
2007-06-17T17:47:18 <ThomasWaldmann> (and the one in xmlrpclib)
2007-06-17T17:48:02 <ThomasWaldmann> can jabber stuff work without bot_host?
2007-06-17T17:50:54 <ThomasWaldmann> Server is retained as an alias for ServerProxy for backwards compatibility. New code should use ServerProxy.
2007-06-17T17:51:17 <Fabi> moin
2007-06-17T17:51:26 <ThomasWaldmann> hi Fabi
2007-06-17T17:51:39 <grzywacz> ThomasWaldmann, you're asking if moin can send notifications without bot? No, not atm. But with the event system in place - it should be fairly easy to add this.
2007-06-17T17:53:36 <ThomasWaldmann> then you could (atm) just use cfg.jabber_bot_uri (default None) and just check if cfg.jabber_bot_uri: ...
2007-06-17T17:54:45 <ThomasWaldmann> and don't magically add http: for the case someone wants to use https (is that possible from bot side?)
2007-06-17T17:56:00 <grzywacz> Both sides use xmlrpclib so yes, it is possible.
2007-06-17T17:56:50 <grzywacz> Magically added http will, of course, go away.
2007-06-17T17:57:40 <dreimark> ThomasWaldmann: what is the interwiki name of t.www.de? en ?
2007-06-17T17:59:11 <ThomasWaldmann> iirc there is none
2007-06-17T18:00:16 <dreimark> ahh, therefore wikisync does not work, neagulm has reported trouble to sync too
2007-06-17T18:02:35 <ThomasWaldmann> xx.test.wikiwikiweb.de use xx internally for interwiki name, xx in de,en,fr
2007-06-17T18:08:19 <ThomasWaldmann> (I was testing some simple multilang setup with sistersites there)
2007-06-17T18:10:18 <ThomasWaldmann> vpv: btw, such a setup might be interesting for you (not for multi-lang maybe, but rather for multi-releases)
2007-06-17T18:11:20 <ThomasWaldmann> vpv: http://en.test.wikiwikiweb.de/TestWiki click on de, fr
2007-06-17T18:19:50 <ThomasWaldmann> vpv: you need sisterdiff then
2007-06-17T19:20:43 <grzywacz> Could someone point me to an area of code, which handles setting arbitrary values in user's preferences?
2007-06-17T19:20:59 <grzywacz> I need something like that to store a list of events an user wants to subscribe to.
2007-06-17T19:21:26 <grzywacz> I see something like decodeDict() and encodeDict(), but where else should I look?
2007-06-17T19:27:09 <dreimark> grzywacz: userform._save_user_prefs
2007-06-17T19:27:41 <grzywacz> Looking. :)
2007-06-17T19:31:21 <dreimark> and user.User.__init__
2007-06-17T20:48:18 <dreimark> http://moinmoin.wikiwikiweb.de/FeatureRequests/TextEditorShouldUseButtonsForCommonSyntax
2007-06-17T21:25:11 <xorAxAx> interesting, prepaid credit cards seem to be cheaper than wiretransfers for google
2007-06-17T21:42:52 <vpv> ThomasWaldmann: Definitely, that's nice :) I won't be working tomorrow or Tuesday, I'm going to see the rock band Evanescence. But I'll make up the hours next weekend...
2007-06-17T22:00:57 <ThomasWaldmann> vpv: have fun :)
2007-06-17T22:01:33 <vpv> thanks!
2007-06-17T22:37:27 <neagulm> hello dreimark
2007-06-17T22:40:46 <dreimark> hi neagulm, how are you?
2007-06-17T22:41:00 <xorAxAx> neagulm: have you seen the events that are in 1.7 now?
2007-06-17T22:41:06 <xorAxAx> they will simplify your code
2007-06-17T22:41:21 <neagulm> dreimark, nervous. I don't manage to get my local wiki to sync with the Moin test wiki
2007-06-17T22:41:33 <xorAxAx> neagulm: dreimark found the reason
2007-06-17T22:41:56 <neagulm> dreimark, xorAxAx: something wrong on my side ?
2007-06-17T22:42:01 <xorAxAx> no
2007-06-17T22:42:03 <dreimark> neagulm: I have not tried but ThomasWaldmann tells [18:03] <ThomasWaldmann> xx.test.wikiwikiweb.de use xx internally for interwiki name, xx in de,en,fr
2007-06-17T22:43:36 <xorAxAx> but wikisync should support anonymous wikis
2007-06-17T22:43:45 <xorAxAx> so this shouldnt be a bug
2007-06-17T22:43:53 <xorAxAx> neagulm: and you dont get an error?
2007-06-17T22:43:59 <neagulm> dreimark, ok. I will try. Now I broke my test wiki... I will play around with lighttpd regex for 5 minutes and then try to sync gsoc.info.uvt.ro with en.text.wikiwikiweb.de
2007-06-17T22:44:41 <neagulm> xorAxAx, dreimark I found another strange behavior with IPv6 addresses that do not have a reverse DNS entry
2007-06-17T22:46:00 <dreimark> xorAxAx: the docu says InterWiki moniker/name of the remote wiki. Note that it has to match the interwiki name that has been configured by the admin of the remote wiki. You will see an error message if this is not the case.
2007-06-17T22:46:42 <xorAxAx> dreimark: but it has a special case for anonymous wikis
2007-06-17T22:46:46 <neagulm> xorAxAx, dreimark I will play a bit around to find whether is MM's fault or lighttpd's
2007-06-17T22:46:55 <xorAxAx> anonymous wikis dont need a matching IWname
2007-06-17T22:47:42 <dreimark> xorAxAx: then the bug is in the description
2007-06-17T22:48:23 <xorAxAx> dreimark: "description"?
2007-06-17T22:48:44 <xorAxAx> if that error message appears when attemping to sync, somebody broke the particular xmlrpc function
2007-06-17T22:49:07 <dreimark> HelpOnSynchronisation at moinmaster there is nothing about anonymous wikis
2007-06-17T22:49:13 <xorAxAx> yes
2007-06-17T22:49:43 <xorAxAx> its not a bug, its just an additionally supported undocumented scenario
2007-06-17T22:49:51 <neagulm> dreimark, xorAxAx Now I will test again the sync... I need a few minutes to configure the live test wiki
2007-06-17T22:49:54 <xorAxAx> and the code still looks correct
2007-06-17T22:51:23 <dreimark> xorAxAx: py.test -v test_wikisync.py shows a failure
2007-06-17T22:51:50 <dreimark> xorAxAx: grzywacz: Config instance has no attribute 'bot_host',
2007-06-17T22:54:18 <dreimark> xorAxAx: ok, it would be nice if we can get it documented too.
2007-06-17T22:54:46 <dreimark> another thing I am not sure if we need it is a protection flag against sync
2007-06-17T23:11:18 <neagulm> ok. I got it working...
2007-06-17T23:11:35 <xorAxAx> ah, what was the problem?
2007-06-17T23:12:38 <neagulm> but, Ok tried on the new server, a clean version of wikiconfig and everything. This time I used en as Interwikiname of the remote system
2007-06-17T23:13:46 <neagulm> i still have a problem, 100% a configuration problem by me: I started the sync and I got: KeyError: 'acl' In the Page.py
2007-06-17T23:14:11 <neagulm> if self.exists() and self.rev == 0: return self.pi['acl'] raises the exception
2007-06-17T23:14:21 <xorAxAx> thats a bug introduced by thomas :)
2007-06-17T23:14:28 <xorAxAx> (and pretty unrelated to wikisync)
2007-06-17T23:14:37 <neagulm> aha, ok
2007-06-17T23:15:38 <neagulm> how can I fix it in my test wiki?
2007-06-17T23:16:35 <ThomasWaldmann> neagulm: that acl keyerror has been fixed already
2007-06-17T23:16:42 <dreimark> neagulm: do you get a traceback? can you file that to a 1.6dev Bug report?
2007-06-17T23:17:03 <dreimark> neagulm: then you should merge with 1.7 main branch
2007-06-17T23:19:40 <dreimark> ThomasWaldmann: thanks for the vitamine C, it does help me currently to be alive :)
2007-06-17T23:22:45 <ThomasWaldmann> :)
2007-06-17T23:22:54 <ThomasWaldmann> hope you get better
2007-06-17T23:28:37 <CIA-27> moin: Thomas Waldmann <tw AT waldmann-edv DOT de> * 2034:e15f1c62ac51 1.7-classify-mneagul/ (MoinMoin/version.py docs/CHANGES moin.spec): bumped version to 1.7.0
2007-06-17T23:28:39 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2035:79a88ae22544 1.7-classify-mneagul/MoinMoin/widget/html.py: html widget: allow colspan/rowspan for TD
2007-06-17T23:28:40 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2036:37c1b2b49c2d 1.7-classify-mneagul/wikiconfig.py: wikiconfig: fix logo URL for 1.7
2007-06-17T23:28:42 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2037:511924c36086 1.7-classify-mneagul/MoinMoin/userform.py: refactor userform
2007-06-17T23:28:43 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2038:1339d6fdc4ff 1.7-classify-mneagul/ (35 files in 6 dirs): Changed tests to use py.test. Also changed the semantics a bit - the test wiki directory is only created freshly if it does not exist.
2007-06-17T23:28:46 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2039:6cc2e0544657 1.7-classify-mneagul/MoinMoin/request/ (WSGI.py __init__.py):
2007-06-17T23:28:49 <CIA-27> moin: add finish handlers
2007-06-17T23:28:51 <CIA-27> moin: finish handlers can be added to the request by any part of the code
2007-06-17T23:28:53 <CIA-27> moin: to do some work when the request has been handled.
2007-06-17T23:28:55 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2040:52c474b8c02f 1.7-classify-mneagul/MoinMoin/ (i18n/__init__.py request/__init__.py):
2007-06-17T23:29:04 <CIA-27> moin: allow translating things early
2007-06-17T23:29:06 <CIA-27> moin: Authentication methods sometimes need to show strings to the user.
2007-06-17T23:29:08 <CIA-27> moin: These can be translated using the browser language but obviously
2007-06-17T23:29:10 <CIA-27> moin: not using user preferences (since no user object is present yet.)
2007-06-17T23:29:12 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2041:1b14cc05a54a 1.7-classify-mneagul/ (18 files in 8 dirs): refactor authentication and split out session handling
2007-06-17T23:29:15 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2042:d234621dbf2f 1.7-classify-mneagul/MoinMoin/user.py:
2007-06-17T23:29:18 <CIA-27> moin: don't store trail for first request
2007-06-17T23:29:20 <CIA-27> moin: avoids storing sessions to disk for requests from users
2007-06-17T23:29:22 <CIA-27> moin: that won't send back the session cookie anyway
2007-06-17T23:29:24 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2043:6cd0e4cc8e18 1.7-classify-mneagul/MoinMoin/user.py:
2007-06-17T23:29:39 <CIA-27> moin: refactor user.getUserId
2007-06-17T23:29:41 <CIA-27> moin: makes looking up by other keys easier (in the future)
2007-06-17T23:29:43 <CIA-27> moin: email lookup could use this as well
2007-06-17T23:29:45 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2044:b2c71d9f95e7 1.7-classify-mneagul/MoinMoin/userform.py: split out userform to avoid using it with the enter key
2007-06-17T23:29:48 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2045:c4cbabe9a02d 1.7-classify-mneagul/MoinMoin/conftest.py: Added a small comment
2007-06-17T23:29:51 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2046:b8de0a47ad95 1.7-classify-mneagul/ (21 files in 9 dirs): Merge with main.
2007-06-17T23:29:54 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2047:41995fbf3d92 1.7-classify-mneagul/MoinMoin/action/AttachFile.py: AttachFile: bug fixed packages are not restricted to zip extension
2007-06-17T23:30:07 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2048:e55ae6646935 1.7-classify-mneagul/MoinMoin/parser/text_moin_wiki.py: text_moin_wiki: fixed nested {{{ bug
2007-06-17T23:30:09 <neagulm> dreimark, I think that I will merge more often
2007-06-17T23:30:10 <CIA-27> moin: Reimar Bauer <rb.proj AT googlemail DOT com> * 2049:dd3a1da58c28 1.7-classify-mneagul/MoinMoin/action/AttachFile.py: AttachFile: now really fixed extensions for packages
2007-06-17T23:30:15 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2050:dbf06dea00aa 1.7-classify-mneagul/MoinMoin/auth/__init__.py: MoinLogin auth: continue if a previous auth was successful
2007-06-17T23:30:16 <neagulm> dreimark, :)
2007-06-17T23:30:20 <CIA-27> moin: Johannes Berg <johannes AT sipsolutions DOT net> * 2051:149573c7ecaf 1.7-classify-mneagul/MoinMoin/session.py: session must store user.auth_attribs
2007-06-17T23:30:35 <CIA-27> (105 lines omitted)
2007-06-17T23:30:37 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2132:0dbf808a6e42 1.7-classify-mneagul/ (10 files in 2 dirs): Move jabber bot to a top-level package.
2007-06-17T23:30:40 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2133:3b0fca14c14c 1.7-classify-mneagul/JabberBot/xmppbot.py: Add basic handling of new presence stanzas, type=subscribe and type=unsubscribe
2007-06-17T23:30:45 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2134:b32f88c46f57 1.7-classify-mneagul/MoinMoin/parser/text_moin_wiki.py: Merged changes from main.
2007-06-17T23:30:48 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2135:42a4a659968a 1.7-classify-mneagul/MoinMoin/_tests/ (_test_template.py test_security.py): Merge with main?!
2007-06-17T23:30:51 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2136:c2114faf540e 1.7-classify-mneagul/JabberBot/xmppbot.py: Fix the case when pyxmpp returns None instead of "available" as presence type.
2007-06-17T23:31:00 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2137:cc5067ea1235 1.7-classify-mneagul/MoinMoin/ (events/JabberNotification.py userform.py): Fix brain-damaged behaviour I introduced yestarday.
2007-06-17T23:31:02 <xorAxAx> maybe somebody should think about filtering duplicate hashes in the hg-CIA conncetor
2007-06-17T23:31:03 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2138:1577663f6354 1.7-classify-mneagul/ (15 files in 4 dirs): Notify when a new attachment is added to a page. s/JabberBot/jabberbot/.
2007-06-17T23:31:10 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2139:645bbc7fe2b5 1.7-classify-mneagul/MoinMoin/events/__init__.py: Add forgotten invocation of parent constructor.
2007-06-17T23:31:13 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2140:c0c7c4cd4eee 1.7-classify-mneagul/jabberbot/main.py: Fix more relative imports.
2007-06-17T23:31:16 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2141:b39379ab47d3 1.7-classify-mneagul/MoinMoin/ (4 files in 2 dirs): Send notifications when page is deleted + some small fixes.
2007-06-17T23:31:23 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2142:1ede132a9d38 1.7-classify-mneagul/ (5 files in 2 dirs): Suggested fixes.
2007-06-17T23:31:26 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2143:a3377b242e21 1.7-classify-mneagul/MoinMoin/events/ (JabberNotification.py messages.py): First try to reduce code duplication. More tomorrow after some sleep...
2007-06-17T23:31:34 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2144:a4d95b9d8f37 1.7-classify-mneagul/jabberbot/main.py: Fix a relative import.
2007-06-17T23:31:37 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2145:20124633e8b4 1.7-classify-mneagul/MoinMoin/events/messages.py: Fix generation of "comments" notification.
2007-06-17T23:31:40 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2146:38ef27ddaa66 1.7-classify-mneagul/MoinMoin/events/ (4 files): Makes file names pep-8 compatible.
2007-06-17T23:31:45 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2147:260d0dbded44 1.7-classify-mneagul/jabberbot/ (commands.py xmppbot.py): Checkpoint commit, to record progress on implementation of user commands.
2007-06-17T23:31:48 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2148:7f579f5fd44b 1.7-classify-mneagul/ (3 files in 2 dirs): Improve docstrings. s/type/msgtype/ to avoid name conflict with builtin.
2007-06-17T23:31:51 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2149:38c8f31be12e 1.7-classify-mneagul/MoinMoin/events/messages.py: Don't add newlines at the end of message.
2007-06-17T23:31:56 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2150:805d56ccbea7 1.7-classify-mneagul/jabberbot/ (xmlrpcbot.py xmppbot.py): Don't import each command by hand, rather used a shortened module name.
2007-06-17T23:31:59 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2151:9d497d976218 1.7-classify-mneagul/MoinMoin/xmlrpc/__init__.py: Fix bad names of parameters in wiki xmlrpc code. Looks like bug to me.
2007-06-17T23:32:02 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2152:2223b127380a 1.7-classify-mneagul/jabberbot/multicall.py: Copy the multicall used by MoinMoin. It's not present in Python 2.3.
2007-06-17T23:32:07 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2153:ae2134211ac1 1.7-classify-mneagul/jabberbot/ (commands.py main.py xmlrpcbot.py xmppbot.py): XMPP -> wiki XML RPC, the beginning...
2007-06-17T23:32:10 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2154:69412724ce93 1.7-classify-mneagul/MoinMoin/ (request/__init__.py xmlrpc/__init__.py): Make it possible to get an auth token using jid and shared secret.
2007-06-17T23:32:16 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2155:184975c4b86f 1.7-classify-mneagul/jabberbot/xmlrpcbot.py: Fix GetPage, make it use the token obtained using jid and shared secret.
2007-06-17T23:32:19 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2156:005938143378 1.7-classify-mneagul/MoinMoin/request/__init__.py: Initialize theme eariler, so that it works with xmlrpc getPageHTML
2007-06-17T23:32:22 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2157:9d5f4ba23a54 1.7-classify-mneagul/jabberbot/ (commands.py xmlrpcbot.py xmppbot.py): Add a GetPageList command. Some code duplication to be refactored later.
2007-06-17T23:32:28 <CIA-27> moin: Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl> * 2158:8b7d6d70fc95 1.7-classify-mneagul/MoinMoin/xmlrpc/__init__.py:
2007-06-17T23:32:31 <CIA-27> moin: Fix reporting of faults in xmlrpc multicall code.
2007-06-17T23:32:33 <CIA-27> (16 lines omitted)
2007-06-17T23:33:17 <xorAxAx> hahaha, the funniest part is that omitted line
2007-06-17T23:39:44 <xorAxAx> neagulm: please dont write new test files that are using the unittest module
2007-06-17T23:39:53 <xorAxAx> neagulm: please read the py.test docs and please convert your unittest file
2007-06-17T23:41:24 <xorAxAx> neagulm: this will simplify your life a lot
2007-06-17T23:42:16 <xorAxAx> oops
2007-06-17T23:42:19 <xorAxAx> that commit is by dreimark
2007-06-17T23:42:33 <xorAxAx> and its from yesterday
2007-06-17T23:42:38 <xorAxAx> dreimark: see above :)
2007-06-17T23:43:04 <dreimark> already reading, I used the wrong example, but it works with py.test
2007-06-17T23:43:18 <xorAxAx> thats irrelevant
2007-06-17T23:43:34 <xorAxAx> i dont want to see the words "import unittest" :)
2007-06-17T23:43:51 <xorAxAx> maybe i should stick LEGACY TEST badges into every old file
2007-06-17T23:44:26 <dreimark> good idea
2007-06-17T23:44:35 <xorAxAx> oh well
2007-06-17T23:44:54 <xorAxAx> our developer base isnt that large
2007-06-17T23:44:58 <dreimark> I was inspired from test_macro.py
2007-06-17T23:45:26 <xorAxAx> and you arent that old :-)
2007-06-17T23:46:08 <xorAxAx> ok, will add the badges ...
2007-06-17T23:47:42 <dreimark> do you want unittest completly not used?
2007-06-17T23:49:00 <dreimark> from unittest import TestCase "in test for packages"
2007-06-17T23:49:49 <CIA-27> moin: Alexander Schremmer <alex AT alexanderweb DOT de> * 2140:ff428fa12e3c 1.7/MoinMoin/_tests/ (19 files): Added legacy warning to old unittests.
2007-06-17T23:49:51 <xorAxAx> yes, completly not used
2007-06-17T23:49:57 <xorAxAx> no TestCase
2007-06-17T23:50:08 <xorAxAx> i converted your last unittest
2007-06-17T23:50:26 * xorAxAx loves sed: sed -i -e '/^import.*unittest/s/$/ # LEGACY UNITTEST, PLEASE DO NOT IMPORT unittest IN NEW TESTS, PLEASE CONSULT THE py.test DOCS/' *.py
2007-06-17T23:50:52 <xorAxAx> have a look at it if you dislike reading the docs
2007-06-17T23:51:55 <ThomasWaldmann> grzywacz: http://hg.moinmo.in/moin/1.7/rev/005938143378 - it crashes without this fix?
2007-06-17T23:52:32 <xorAxAx> ThomasWaldmann: yes
2007-06-17T23:52:47 <dreimark> hehe, it was the first real macro test if we don't count test_macro
2007-06-17T23:52:59 <xorAxAx> ThomasWaldmann: because the rpc method calls the page rendering stuff which calls stuff in the theme
2007-06-17T23:53:23 <xorAxAx> dreimark: but i cant remember which unitcase you wrote ~ 6 weeks ago
2007-06-17T23:53:27 <xorAxAx> maybe you do
2007-06-17T23:54:30 <dreimark> xorAxAx: that was not a completly new one, it was always an extension
2007-06-17T23:56:01 <neagulm> dreimark, against what should I sync to get some test spam ?
2007-06-17T23:57:04 <xorAxAx> dreimark: hmm
2007-06-17T23:57:12 <xorAxAx> dreimark: maybe you remember the file :)
2007-06-17T23:57:25 <xorAxAx> neagulm: i fear that there is no wiki with 1.6 and spam in it
2007-06-17T23:57:58 <dreimark> neagulm: good question, ThomasWaldmann could we have some of the pages of MM which got regular spammed linked into testwiki?
2007-06-17T23:58:14 <xorAxAx> well
2007-06-17T23:58:25 <xorAxAx> somebody would have to find them and copy the old page contents into the test wiki MoinMoin: MoinMoinChat/Logs/moin-dev/2007-06-17 (last edited 2007-10-29 19:13:48 by localhost)
