MoinMoin: MoinMoinChat/Logs/moin-dev/2006-08-18

2006-08-18T01:39:11  <ThomasWaldmann> xorAxAx: we have quite some chmod calls in src
2006-08-18T01:39:32  <ThomasWaldmann> on posix, there is os.umask()
2006-08-18T01:39:34  <xorAxAx> yes
2006-08-18T01:39:46  <xorAxAx> on windows, it doesnt do anything
2006-08-18T01:39:50  <xorAxAx> i mean chmod
2006-08-18T01:39:56  <ThomasWaldmann> and on windows, our chmods dont have an effect anyway, right
2006-08-18T01:40:09  <xorAxAx> yep
2006-08-18T01:40:18  <xorAxAx> besides setting +r
2006-08-18T01:40:28  <xorAxAx> which isnt used by moin :)
2006-08-18T01:40:35  <ThomasWaldmann> so we could use a single os.umask(~config.umask)
2006-08-18T01:40:39  <xorAxAx> yes
2006-08-18T01:42:06  <ThomasWaldmann> ok, I will review src, but currently I think nothing speaks again saving some chmod calls
2006-08-18T01:42:14  <ThomasWaldmann> +st
2006-08-18T01:42:43  <xorAxAx> yes
2006-08-18T02:31:36  <ThomasWaldmann> ok, i guess we need only 1 chmod in copystat()
2006-08-18T02:33:07  <ThomasWaldmann> i removed some of the performance critical chmods in the code running on mm site, so we'll know soon.
2006-08-18T09:37:35  <ThomasWaldmann> moin
2006-08-18T09:37:38  <ThomasWaldmann> +    REGEX_VERIFY_USERNAME = re.compile(r'^\d+\.\d+(\.\d+)?$')
2006-08-18T09:38:08  <ThomasWaldmann> that's slighty irritating. maybe call it REGEX_VERIFY_USERID.
2006-08-18T09:40:39  <ThomasWaldmann>         if not self.__dict__.has_key("item_dictionary"):
2006-08-18T09:40:39  <ThomasWaldmann> +            self._item_dictionary = {}
2006-08-18T09:40:56  <ThomasWaldmann> is that name difference on purpose?
2006-08-18T09:41:48  <ThomasWaldmann> Kepplar: see above
2006-08-18T09:42:29  <Kepplar> ah ok
2006-08-18T09:42:32  <ThomasWaldmann> fpletz: you really should get going on the UI stuff and your other TODOS. Next monday is deadline.
2006-08-18T09:42:59  <Kepplar> different?
2006-08-18T09:43:09  <ThomasWaldmann> the leading underscore
2006-08-18T09:43:19  <Kepplar> ohh
2006-08-18T09:43:30  <Kepplar> strange as it works
2006-08-18T09:44:06  <ThomasWaldmann> and better use "in" instead of "has_key()"
2006-08-18T09:44:31  <ThomasWaldmann> if key in mydict:
2006-08-18T09:45:15  <Kepplar> whats the diff?
2006-08-18T09:46:12  <Kepplar> : testSyntaxReference is breaking for completly non-storage related issues
2006-08-18T09:46:29  <Kepplar>     raise ValueError, "closing of <%s> expected, but <%s> closed" % (last_tag, tag)
2006-08-18T09:46:33  <Kepplar> ValueError: closing of <li> expected, but <p> closed
2006-08-18T09:55:23  <ThomasWaldmann> Kepplar: this is normal, not your task
2006-08-18T09:55:34  <ThomasWaldmann> move it to broken/ if it annoys you
2006-08-18T10:44:13  <Kepplar> ThomasWaldmann: I'm wondering if it is fixed - as the test might have storage related things later on that it is not reaaching
2006-08-18T10:53:57  <xorAxAx> no, dont move it
2006-08-18T10:54:05  <xorAxAx> enable the exception code for the dom_xml formatter
2006-08-18T11:14:28  <Kepplar> hm?
2006-08-18T11:24:44  <xorAxAx> Kepplar: there are two lines that are commented out
2006-08-18T11:24:58  <Kepplar> ah ok
2006-08-18T11:25:03  <Kepplar> that will fix it?
2006-08-18T11:25:32  <xorAxAx> yes
2006-08-18T11:25:41  <Kepplar> cool :)
2006-08-18T11:26:05  <xorAxAx> it will workaround the problem
2006-08-18T11:26:16  <Kepplar> hows sync going?
2006-08-18T11:26:37  <xorAxAx> oh, besides rename handling, it looks good
2006-08-18T11:27:00  <xorAxAx> but it wasnt in my initial specs :)
2006-08-18T17:13:06  <ThomasWaldmann> fpletz: are you still alife?
2006-08-18T22:01:23  * ThomasWaldmann changes url_prefix ...
2006-08-18T23:33:54  <xorAxAx> fpletz: some "include system pages" filter would be nice
2006-08-18T23:34:04  <xorAxAx> and syntax for that as well#