MoinMoin: MoinMoinChat/Logs/moin-dev/2006-08-05

2006-08-05T00:15:54  <ThomasWaldmann> xorAxAx: if you have time, see my latest changeset. almost works, just the diff button is a problem, because of the nesting of forms.
2006-08-05T00:17:42  <ThomasWaldmann> (just change if 0: -> if 1:)
2006-08-05T00:21:26  <xorAxAx> hmm, the problem of this widget stuff is that it can be just used in actions ... and that it shouldnt be used in macros. i think its misused somewhere
2006-08-05T00:24:38  <xorAxAx> hmm, there can be just one form per table
2006-08-05T00:25:42  <xorAxAx> it could be done by renaming the radio boxes and dispatching ...
2006-08-05T00:25:50  <xorAxAx> ThomasWaldmann: but why do you want to have buttons there?
2006-08-05T00:25:57  <xorAxAx> they have disadvantages
2006-08-05T00:26:33  <ThomasWaldmann> like?
2006-08-05T00:26:38  <xorAxAx> if you just need a possibility to post, i suggest an action similar to deletepage which does ticketing
2006-08-05T00:26:55  <xorAxAx> ThomasWaldmann: less accessible (e.g. i cannot easily navigate there by keyboard)
2006-08-05T00:27:09  <xorAxAx> and they look bad in matrix (somehow redundant)
2006-08-05T00:27:43  <xorAxAx> and they are even more wide - even larger rows in that info table
2006-08-05T00:28:21  <ThomasWaldmann> i guess the look can be fixed by css
2006-08-05T00:28:25  <xorAxAx> and introducing a comment to the revert action would be nice as well (hmm, one of those things on my todo list ...)
2006-08-05T00:28:34  <xorAxAx> ThomasWaldmann: not with CSS1
2006-08-05T00:29:24  <ThomasWaldmann> http://test.wikiwikiweb.de/TestWiki?action=info
2006-08-05T00:29:59  <ThomasWaldmann> the are selected by TAB
2006-08-05T00:30:08  <xorAxAx> are they supposed to align in 3 rows separated by large whitespace?
2006-08-05T00:30:22  <ThomasWaldmann> i didnt do any styling yet
2006-08-05T00:30:23  <xorAxAx> umm, i should press tab 300 times to print revision 5?
2006-08-05T00:30:27  <xorAxAx> ok
2006-08-05T00:31:13  <ThomasWaldmann> i just want to get rid of spiders
2006-08-05T00:31:58  <xorAxAx> actually, it should be possible withoput any dispatching or nested forms as well
2006-08-05T00:32:10  <xorAxAx> submit buttons can have names and values
2006-08-05T00:34:07  <ThomasWaldmann> the problem is getting all k,v pairs posted
2006-08-05T00:34:24  <xorAxAx> yes
2006-08-05T00:34:39  <ThomasWaldmann> i did a more radical change, but reverted it because of attachments stuff
2006-08-05T00:34:57  <xorAxAx> then you need a dispatcher for them maybe :)
2006-08-05T00:34:58  <ThomasWaldmann> (only using one set of buttons total, not per rev)
2006-08-05T00:35:17  <xorAxAx> all goes to action/info and action/info redirects to the "unmarshalled" URL :)
2006-08-05T00:36:09  <xorAxAx> maybe i have some time for it tomorrow
2006-08-05T09:53:54  <ThomasWaldmann> moin
2006-08-05T15:39:34  <Kepplar> moin
2006-08-05T15:46:31  <Kepplar> 
2006-08-05T15:46:31  <Kepplar>     # XXX TODO clean up the mess, rewrite _last_edited, last_edit, lastEditInfo for new logs,
2006-08-05T15:46:34  <Kepplar>     # XXX TODO do not use mtime() calls any more
2006-08-05T15:46:37  <Kepplar> can someone please explain this?
2006-08-05T15:48:24  <xorAxAx> Kepplar: those functions have duplicated code blocks
2006-08-05T15:48:38  <xorAxAx> Kepplar: one function might even still use stat calls to determine the mtime of a page
2006-08-05T15:48:54  <xorAxAx> Kepplar: it would make sense to refactor it into 1 or 2 function
2006-08-05T15:48:55  <xorAxAx> s
2006-08-05T15:50:52  <Kepplar> whats it all suppose to achieve?
2006-08-05T15:52:52  <xorAxAx> people want to know when a page was last modified
2006-08-05T15:53:43  <Kepplar> seriously dont think i can refactor all this in time, its such a mess :/
2006-08-05T15:54:39  <xorAxAx> you dont have to
2006-08-05T15:55:09  <Kepplar> ...
2006-08-05T15:55:25  <xorAxAx> as long as it works :)
2006-08-05T15:55:28  <Kepplar> i do because storage can't provide half this info (notably a page uri)
2006-08-05T15:55:37  <xorAxAx> ?
2006-08-05T15:55:49  <xorAxAx> the page class is not only about storage
2006-08-05T15:56:11  <xorAxAx> it controls the representation of a page
2006-08-05T15:56:31  <Kepplar> true
2006-08-05T15:56:39  <Kepplar> but most of it still needs info it cant have
2006-08-05T15:56:47  <xorAxAx> for example?
2006-08-05T15:57:37  <Kepplar> such as asking for a uri of the page!
2006-08-05T15:57:41  <Kepplar> (which is quite big!)
2006-08-05T15:57:53  <Kepplar> asking for last edit
2006-08-05T15:57:55  <Kepplar> asking for size
2006-08-05T15:57:59  <Kepplar> this is things that storage cannot do
2006-08-05T15:58:18  <xorAxAx> the URI of a page is completly storage-unrelated
2006-08-05T15:58:29  <xorAxAx> it is mainly basepage + pagename
2006-08-05T15:58:39  <xorAxAx> s/page/path/
2006-08-05T15:58:42  <Kepplar> sorry?
2006-08-05T15:58:47  <Kepplar> how did you come to that conclusion?
2006-08-05T15:58:57  <Kepplar> it is completly storage related
2006-08-05T15:59:03  <xorAxAx> Kepplar: explain why
2006-08-05T15:59:16  <Kepplar> Because a) everything that touches the filesystem goes through stroage
2006-08-05T15:59:24  <Kepplar> and b) it might not actually BE on a filesystem
2006-08-05T15:59:47  <xorAxAx> the URI is completly unrelated to the filesystem
2006-08-05T16:00:16  <Kepplar> ...
2006-08-05T16:00:17  <Kepplar> why?
2006-08-05T16:00:27  <xorAxAx> please explain why the URI should be related in any way to the filesystem
2006-08-05T16:00:38  <Kepplar> File paths = URI
2006-08-05T16:00:43  <Kepplar> thats what I'm talking about
2006-08-05T16:00:50  <xorAxAx> duh, please be more specific
2006-08-05T16:00:56  <xorAxAx> a file path is not an URI
2006-08-05T16:01:05  <Kepplar> yes it is
2006-08-05T16:01:10  <xorAxAx> no, it is not
2006-08-05T16:01:18  <xorAxAx> please read the following RFCs:
2006-08-05T16:01:30  <xorAxAx> 3986
2006-08-05T16:01:35  <Kepplar> God sake this is hardly the point
2006-08-05T16:01:41  <xorAxAx> next problem - last modified time
2006-08-05T16:01:45  <Kepplar> orry?
2006-08-05T16:01:50  <Kepplar> You actually listening?
2006-08-05T16:02:10  <Kepplar> How am I suppose to supply a file path to Page?!
2006-08-05T16:02:20  <xorAxAx> yeah, i think we already discussed that file paths are not a public method anymore
2006-08-05T16:02:29  <Kepplar> My grep begs to differ
2006-08-05T16:02:51  <xorAxAx> last modified, this is essential meta-data that should be available by looking at the last revision
2006-08-05T16:03:14  <Kepplar> wheres the last modified time stored, I assume metadata
2006-08-05T16:03:40  <xorAxAx> yes
2006-08-05T16:03:53  <xorAxAx> its the modification time of the last revision
2006-08-05T16:04:59  <Kepplar> Theres absolutly not chance I can migrate this in three weeks
2006-08-05T16:05:08  <Kepplar> especially since i'm unavailable on the last SOC weekend
2006-08-05T16:05:12  <xorAxAx> heh
2006-08-05T16:05:55  <xorAxAx> i guess thomas will find a solution
2006-08-05T16:06:04  <Kepplar> Page is badly written, undocumented and furthermore private methods are written as public and some ones declared as private are used elsewhere
2006-08-05T16:06:36  <xorAxAx> now guess why the task is called "refactoring" :)
2006-08-05T16:06:51  <Kepplar> Page.isWritable
2006-08-05T16:07:12  <Kepplar> does that mean the page it already written and the revision unchangable or that new revisions can't be changed?
2006-08-05T16:07:31  <xorAxAx> is there no doc string?
2006-08-05T16:08:39  <Kepplar> xorAxAx: unprecise :/
2006-08-05T16:08:59  <xorAxAx> have you looked at the callers?
2006-08-05T16:11:14  <Kepplar> not in great depth yet
2006-08-05T16:11:43  <xorAxAx> i dont think that there are many
2006-08-05T16:11:49  <xorAxAx> so there isnt much depth either :)
2006-08-05T16:14:48  <xorAxAx> 6 callers
2006-08-05T16:14:56  <xorAxAx> in 3 files
2006-08-05T16:15:03  <xorAxAx> 4 files
2006-08-05T16:17:51  <xorAxAx> Kepplar: you still dont have a correct username setting in your hg :-(
2006-08-05T16:18:02  <xorAxAx>  see: http://moin.pocoo.org:8080/moin-1.6-storage-a
2006-08-05T16:19:50  <xorAxAx> its even documented in our wiki
2006-08-05T16:19:54  <xorAxAx> on how to do that :)
2006-08-05T18:38:10  <Kepplar> xorAxAx: yea, it kinda broke I did set it up. At the moment its not my primary concern
2006-08-05T18:38:49  <Kepplar> Bah, it looks like the Page object is used as a representation of the page as well as a library class.Very strange (read: non-existant) design.
2006-08-05T18:52:06  <Kepplar> Hehe, guys you'll love this
2006-08-05T18:52:27  <Kepplar> else where in Page it uses the value -1,0,1 for auto,underlay and data
2006-08-05T18:52:45  <Kepplar> except for this one method that uses None,"underlay","standard" haha!
2006-08-05T21:04:31  <Kepplar> fpletz: Didn't anyone teach you inline HTML is bad :)?
2006-08-05T21:08:54  <fpletz> Kepplar: that was inline before, didn't change it yet ;)
2006-08-05T21:09:00  <Kepplar> ah :)
2006-08-05T21:09:08  <Kepplar> fpletz: hows it all going?
2006-08-05T21:09:22  <fpletz> good, I'm now working on the google-like paging
2006-08-05T21:09:31  <Kepplar> google-like?
2006-08-05T21:09:34  <fpletz> with the fancy goooogle gfx :)
2006-08-05T21:09:38  <Kepplar> hehe
2006-08-05T21:10:42  <fpletz> well, if my instand messenger would stop interruptin :)
2006-08-05T21:10:42  <fpletz> s/instand/instant/
2006-08-05T21:10:59  *** irc.freenode.net sets mode: +o ChanServ
2006-08-05T21:12:45  <Kepplar> heh
2006-08-05T23:38:43  <ThomasWaldmann> moin