MoinMoin: MoinMoinChat/Logs/moin-dev/2006-06-11

2006-06-11T00:07:50  <ThomasWaldmann> mvirkkil: maybe ask florian festi, i think he has thought about related stuff
2006-06-11T00:09:21  <mvirkkil> ThomasWaldmann: What's his nick?
2006-06-11T00:32:35  <ThomasWaldmann> fabi or ffesti
2006-06-11T00:40:53  <Kepplar> moin
2006-06-11T00:43:32  <ThomasWaldmann> moin Kepplar
2006-06-11T01:21:48  <ThomasWaldmann> [target text] and [target] would make too many false hits, right?
2006-06-11T01:24:18  <ThomasWaldmann> i have extended link markup to ["target" text] and ['target' text]
2006-06-11T01:24:31  <ThomasWaldmann> target can have blanks inside
2006-06-11T01:25:11  <ThomasWaldmann> a logical consequence would be, that if target has no blanks inside, the quotes can be omitted
2006-06-11T01:25:28  <ThomasWaldmann> but this would mean that [A] is a link to page A
2006-06-11T01:27:11  <ThomasWaldmann> and [1, 2] is a link to page "1," with 2 as link text
2006-06-11T01:28:25  <ThomasWaldmann> that would be less an issue if it was [[A]], but this is already a macro call 8(
2006-06-11T11:29:26  <ThomasWaldmann> moin
2006-06-11T11:30:44  <Kepplar> moin
2006-06-11T11:30:50  * Kepplar gets new ssh key
2006-06-11T11:31:02  <Kepplar> firstly i need to install pil on my server
2006-06-11T13:02:32  <nwp> ThomasWaldmann: sorry, got rather busy. will look again tomorrow at work...
2006-06-11T13:14:33  <ThomasWaldmann> nwp: :)
2006-06-11T13:15:18  <richardb> Morning.
2006-06-11T13:15:25  <richardb> Oh, afternoon here, just.
2006-06-11T13:31:14  <ThomasWaldmann> say "moin", that is valid whole day :)
2006-06-11T14:17:56  <xorAxAx> ThomasWaldmann: does the quoting suppoert escaping?
2006-06-11T14:56:31  <ThomasWaldmann> not yet
2006-06-11T14:56:54  <ThomasWaldmann> i'll first put some basic quoting at the places needed
2006-06-11T14:58:32  <ThomasWaldmann> (triggered by _ hack removal)
2006-06-11T18:09:31  <xorAxAx> ThomasWaldmann: without quoting, it will be as painful as the search parser, which doesnt support it either
2006-06-11T18:09:41  * xorAxAx stabs fpletz - maybe you can fix it :)
2006-06-11T18:09:49  <xorAxAx> (in the search parser)
2006-06-11T18:10:46  <ThomasWaldmann> xorAxAx: you mean escaping?
2006-06-11T18:10:59  <xorAxAx> umm, yes
2006-06-11T18:11:28  <ThomasWaldmann> you can use ' and ", so the problem case reduces to string containing both
2006-06-11T18:12:21  <xorAxAx> yes, but its still a problem :)
2006-06-11T18:12:31  <ThomasWaldmann> sure, but a small :)
2006-06-11T18:23:00  *** irc.freenode.net sets mode: +o ChanServ
2006-06-11T19:50:21  <Kepplar> shocking
2006-06-11T19:50:27  <Kepplar> i've found a use for a lamda function
2006-06-11T19:50:33  <Kepplar> +b
2006-06-11T19:52:23  <ThomasWaldmann> hehe
2006-06-11T20:03:00  <Kepplar> does a Lambda have to take a parameter?
2006-06-11T20:06:01  <ThomasWaldmann> try it
2006-06-11T20:06:43  <ThomasWaldmann> btw, I prefer readable code :)
2006-06-11T20:24:33  <xorAxAx> "the student hasnt passed the first half of soc because he used lambda functions"
2006-06-11T21:00:30  <Kepplar> it is readable :)
2006-06-11T21:00:35  <Kepplar> im just customising a file access method
2006-06-11T21:00:43  <Kepplar> so you send via lamda parameter
2006-06-11T21:00:48  <Kepplar> what to do.. read, write etc
2006-06-11T21:01:06  <Kepplar> and it takes in the file pointer as an argument
2006-06-11T21:01:21  <Kepplar> code reduction =)
2006-06-11T21:22:30  <Kepplar> kepplar@c:~/dev/moinmoin/storage/MoinMoin$ hg add storage/
2006-06-11T21:22:30  <Kepplar> adding storage/flatfile.py
2006-06-11T21:22:30  <Kepplar> kepplar@c:~/dev/moinmoin/storage/MoinMoin$ cd ../
2006-06-11T21:22:30  <Kepplar> kepplar@c:~/dev/moinmoin/storage$ hg commit -m "Additional work on implementation of new flatfile storage module."
2006-06-11T21:22:33  <Kepplar> kepplar@c:~/dev/moinmoin/storage$ hg push pushing to ssh://hg@hg.thinkmo.de/moin/1.6-storage-a
2006-06-11T21:22:36  <Kepplar> searching for changes
2006-06-11T21:22:39  <Kepplar> eh?
2006-06-11T21:22:41  <Kepplar> (it didnt work)
2006-06-11T22:06:54  <ThomasWaldmann> Kepplar: it works now?
2006-06-11T22:08:52  <Kepplar> nope :/
2006-06-11T22:11:22  <ThomasWaldmann> what doesnt work exactly?
2006-06-11T22:12:02  <Kepplar> ive added the new file
2006-06-11T22:12:08  <Kepplar> and tried to commit and push
2006-06-11T22:12:13  <Kepplar> but its not doing anything
2006-06-11T22:12:25  <ThomasWaldmann> http://hg.thinkmo.de/moin/1.6-storage-a
2006-06-11T22:13:05  <Kepplar> eh!
2006-06-11T22:13:08  <Kepplar> it worked O_o
2006-06-11T22:14:21  <ThomasWaldmann> +# Python module imports.
2006-06-11T22:14:35  <ThomasWaldmann> i guess we can live without that sort of comments
2006-06-11T22:17:00  <Kepplar> I noticed xapian's been making modifications on page.py
2006-06-11T22:17:04  <Kepplar> ok
2006-06-11T22:21:25  <ThomasWaldmann> PAGEDIR = "page/"
2006-06-11T22:21:56  <Kepplar> yea, im bringing the notation out of hardcoded
2006-06-11T22:22:00  <Kepplar> as it would be easier to alter
2006-06-11T22:22:05  <Kepplar> in the future
2006-06-11T22:22:45  <ThomasWaldmann> compare it with a real data_dir content :)
2006-06-11T22:23:20  <Kepplar> i have
2006-06-11T22:23:35  <Kepplar> data/ is stated in the open uri
2006-06-11T22:23:48  <Kepplar> revision hasnt been implemented as TODO states
2006-06-11T22:24:14  <ThomasWaldmann> it is "pages"
2006-06-11T22:24:58  <ThomasWaldmann> and you never have to include "/"
2006-06-11T22:25:11  <Kepplar> doh
2006-06-11T22:25:13  <Kepplar> :)
2006-06-11T22:25:16  <Kepplar> thanks
2006-06-11T22:29:34  <ThomasWaldmann> +        if (itrv_revision.int_revision < 1):
2006-06-11T22:30:05  <Kepplar> +?
2006-06-11T22:30:21  <Kepplar> that lines for the "latest" special case
2006-06-11T22:30:25  <ThomasWaldmann> how much C/C++ are you coding currently? :)
2006-06-11T22:30:58  <Kepplar> none at the moment, I've postpond my slice on our game project till after moin ;)
2006-06-11T22:31:14  <Kepplar> whats wrong?
2006-06-11T22:31:40  <ThomasWaldmann> the brackets are rather superfluous :)
2006-06-11T22:32:12  <Kepplar> ok, removed it :)
2006-06-11T22:32:33  <Kepplar> (btw, theres been another commit since you started looking at it)
2006-06-11T22:32:48  <Kepplar> set_data is now implemented
2006-06-11T22:33:13  <ThomasWaldmann> what editor are you using?
2006-06-11T22:33:29  <Kepplar> eric
2006-06-11T22:33:30  <Kepplar> 3
2006-06-11T22:33:45  <Kepplar> .9
2006-06-11T22:33:47  <ThomasWaldmann> it shows indenting errors, right?
2006-06-11T22:33:48  <Kepplar> :)
2006-06-11T22:34:07  <Kepplar> i think so
2006-06-11T22:34:38  <ThomasWaldmann> the / is still there
2006-06-11T22:34:44  <Kepplar> oh
2006-06-11T22:34:51  <Kepplar> i used that one on a line i split
2006-06-11T22:35:32  <Kepplar> cant see it though
2006-06-11T22:37:13  <ThomasWaldmann> pages/ is wrong, it has to be "pages" and the / (or \) being added by os.path.join
2006-06-11T22:37:40  <Kepplar> Oh, i removed that just now
2006-06-11T22:37:46  <Kepplar> (see latest version) :)
2006-06-11T22:37:52  <ThomasWaldmann>          return str(int_revision).rjust(8,"0")
2006-06-11T22:37:59  <Kepplar> yep
2006-06-11T22:38:02  <Kepplar> thats to create
2006-06-11T22:38:12  <ThomasWaldmann> what was wrong with return "%08d" % int_revision ?
2006-06-11T22:38:33  <Kepplar> not familar with that notation
2006-06-11T22:38:39  <Kepplar> % = modulus?
2006-06-11T22:38:53  <ThomasWaldmann> it is the one used in the code you are refactoring :)
2006-06-11T22:39:04  <Kepplar> ah i couldnt see where it did it
2006-06-11T22:39:35  <Kepplar> probably faster too that actually.. ill alter it
2006-06-11T22:39:35  <ThomasWaldmann> %d = format string for integer, 8 digits, leading 0s
2006-06-11T22:40:41  <ThomasWaldmann> and (minor detail) rather use file(fname, mode) than open(fname, mode)
2006-06-11T22:41:13  <Kepplar> whats the difference?
2006-06-11T22:41:27  <ThomasWaldmann> file is more modern :)
2006-06-11T22:41:59  <Kepplar> ah ok
2006-06-11T22:42:53  <Kepplar> commited :)
2006-06-11T22:44:22  <ThomasWaldmann> +        str_location = generate_rev_location(self, itrv_revision, str_location)
2006-06-11T22:44:56  <Kepplar> oh, they have the same variable O_o
2006-06-11T22:45:00  <ThomasWaldmann> a more OO way to do this is ... self.generate_rev_location(itrv...
2006-06-11T22:45:18  <Kepplar> ah good point, completly forgot about that
2006-06-11T22:46:09  <ThomasWaldmann> private methods should be named _xxx
2006-06-11T22:46:56  <Kepplar> yep, was leaving that blank as some of those might be shoved onto the interface
2006-06-11T22:47:04  <Kepplar> until i was completly sure
2006-06-11T22:47:29  <ThomasWaldmann> ok
2006-06-11T22:47:36  <ThomasWaldmann> last line is indented wrong
2006-06-11T22:47:58  <Kepplar> thanks, 1 too far :)
2006-06-11T22:48:27  <ThomasWaldmann> if eric shows a red flag left of the code, that should warn you
2006-06-11T22:48:48  <Kepplar> for some reason if didnt that time
2006-06-11T22:48:52  <Kepplar> maybe because it was the last line?
2006-06-11T22:50:15  <Kepplar> i think the next stage is to study metadata and implment that :)
2006-06-11T22:50:42  <Kepplar> then unit test it
2006-06-11T22:51:12  <Kepplar> then move back onto the abstraction layer (i've had to reverse the implimentation because adapters won't work as fully as intended because of the OO approach over the access object
2006-06-11T22:57:51  <ThomasWaldmann> btw, 1.6 main has quite some changes, merge them into yours
2006-06-11T23:09:57  <Kepplar> how?
2006-06-11T23:10:12  <Kepplar> i didnt think i had access to main
2006-06-11T23:15:43  <ThomasWaldmann> hg pull http://hg.thinkmo.de/moin/1.6
2006-06-11T23:44:56  <richardb> Woohoo!
2006-06-11T23:45:08  <richardb> My first python package put together and added to PyPI. :)
2006-06-11T23:45:40  <richardb> Fpletz: there's a good Python interface to the snowball stemming algorithms now.
2006-06-11T23:46:00  <richardb> Oh, he's not really here.  Still, he might read this later. :)
2006-06-11T23:51:02  <ThomasWaldmann> you hacked it today? :)