MoinMoin: MoinMoinChat/Logs/moin-dev/2006-05-16

2006-05-16T04:30:18  <nwp_> ThomasWaldmann: you need to lose the 'MoinMoin.processor' line in setup.py I think
2006-05-16T04:30:31  <nwp_> (in 1.6)
2006-05-16T04:50:07  <nwp_> and add MoinMoin.request, from the look of it. Although I know next to nothing about how this stuff is supposed to work
2006-05-16T04:56:37  <nwp_> yuk. plenty of other crap wrong too from the look of it
2006-05-16T04:56:56  <nwp_> MODPY vs. MODPYTHON, 'config' not defined somewhere or other
2006-05-16T05:14:57  <nwp_> I think you have big problems from splitting request.py
2006-05-16T05:15:30  <nwp_> config is not getting imported where it needs to be, the exceptions shouldn't exist where they need to etc.
2006-05-16T05:15:50  <nwp_> I don't know enough about how python does these things yet to be able to say how best to fix it all up
2006-05-16T05:16:44  <nwp_> but as an example, look at the TWISTED __init__ -- it has "except MoinMoinFinish:"... how is that supposed to exist?
2006-05-16T05:17:03  <nwp_> similarly for config.charset in MODPYTHON
2006-05-16T05:17:10  <nwp_> how is config supposed to exist
2006-05-16T05:17:29  <nwp_> In 1.5 it was all imported at the top of the same file, so no problems.
2006-05-16T05:17:49  <nwp_> now, do all the separate files need to import config etc. separately? or what?
2006-05-16T09:15:46  <ThomasWaldmann> nwp_: thanks for the hints
2006-05-16T09:16:04  <ThomasWaldmann> this is why CHANGES says it needs fixes/testing
2006-05-16T09:16:42  <ThomasWaldmann> my test wiki runs as cgi, the tests run as cli, so this is all i have tested
2006-05-16T09:26:17  <ThomasWaldmann> nwp_: see my latest 1.6 changeset
2006-05-16T09:34:04  <ThomasWaldmann> (and those problems are numerous maybe, but very small. usually just add some from MoinMoin.request import xxx
2006-05-16T10:11:11  <xorAxAx> ThomasWaldmann: CLI was broken as well, you couldnt have tested it :)
2006-05-16T10:11:22  <xorAxAx> hmm, no, it was just my import
2006-05-16T10:11:38  <xorAxAx> one point i dont like about that "refactoring" is that it breaks old code
2006-05-16T10:11:58  <xorAxAx> you could have constructed a solution (using demandload etc.) that doesnt break old code
2006-05-16T10:12:23  <xorAxAx> i tried yesterday but it didnt work out because all Request classes are called "Request" and demandload doesnt support renaming
2006-05-16T23:34:25  <nwp_> ThomasWaldmann: yeah -- I was trying to work out which setup you had tested to copy however you'd made it work in there.
2006-05-16T23:34:58  <nwp_> But I was guessing twisted, and then I noticed that that looked broken too (albeit only in a minor way), so I thought I'd just wait until you woke up :-)
2006-05-16T23:36:49  <nwp_> pulling your changes now...