MoinMoin: MoinMoinChat/Logs/moin-dev/2006-02-10

2006-02-10T00:05:13  <xorAxAx> [PERIODIC ANNOUNCEMENT] Logs can be found on http://moinmoin.wikiwikiweb.de/MoinMoinChat/Logs/moin-dev
2006-02-10T11:34:20  <ThomasWaldmann> the problem with _ in URLs is that it gets replaced by a blank when making the page name
2006-02-10T11:34:53  <ThomasWaldmann> so if you have a file letter_1.sxw, it will end up as letter 1.sxw
2006-02-10T11:35:04  <xorAxAx> hmm, no
2006-02-10T11:35:17  <xorAxAx> the correct solution is to use %CodeForUnderScore
2006-02-10T11:35:19  <starshine> right, it would need to be a urlencoded _ if you want it to stay
2006-02-10T11:35:21  <ThomasWaldmann> and even escaping it to letter%5f1.sxw in url does not help
2006-02-10T11:35:28  <xorAxAx> starshine: ^5 :)
2006-02-10T11:35:32  <starshine> or moincoded in this case :)
2006-02-10T11:35:32  <xorAxAx> ThomasWaldmann: thats a bug
2006-02-10T11:35:56  <xorAxAx> starshine: no, it should be simple urlencoding, nothing special
2006-02-10T11:36:08  <ThomasWaldmann> because we first decode %xx and then replace _
2006-02-10T11:36:30  <starshine> hrmm can we just change the order of that operation?
2006-02-10T11:36:53  <ThomasWaldmann> i looked at the unquote, decode, normalize... stuff yesterday
2006-02-10T11:37:02  <ThomasWaldmann> it is a mess
2006-02-10T11:37:46  <ThomasWaldmann> i think i need to make a picture on a piece of paper to analyze it
2006-02-10T11:38:10  <xorAxAx> yeah, all people kept adding decode, replace, etc. at many places in the code
2006-02-10T11:38:18  <xorAxAx> which is bad and error prone
2006-02-10T11:39:47  <ThomasWaldmann> esp. i didnt really understand the calls done by those non-posix fixes
2006-02-10T11:40:02  * starshine drags out a whiteboard.  this twikidraw thing ought to do...
2006-02-10T11:40:55  <starshine> first you figure out what it does, then you checklist the things it was trying to do, then design doing all those things a better way
2006-02-10T11:41:03  <starshine> am I missing anything :)
2006-02-10T11:41:25  <ThomasWaldmann> fixURI needs more comments
2006-02-10T11:41:40  <xorAxAx> ThomasWaldmann: you mean request.py?
2006-02-10T11:41:43  <ThomasWaldmann> yes
2006-02-10T11:41:46  <xorAxAx> ThomasWaldmann: nir refactored them ...
2006-02-10T11:42:08  <ThomasWaldmann>             self.path_info = wikiutil.url_unquote(path, want_unicode=False)
2006-02-10T11:42:08  <xorAxAx> but he didnt refactor my explanation back then (the comment block explaining the problem)
2006-02-10T11:42:16  <ThomasWaldmann> this is done for nonposix only
2006-02-10T11:42:24  <xorAxAx> hmm, not my code
2006-02-10T11:43:53  <ThomasWaldmann> the complete stuff under # Fix path info   is strange
2006-02-10T11:44:45  <ThomasWaldmann> the problem is that i can't fix that as I can't test it
2006-02-10T11:46:41  <xorAxAx> there is currently just one bug report against IIS
2006-02-10T11:46:47  <xorAxAx> which i couldnt fix yet
2006-02-10T11:47:08  <xorAxAx> file a bug describing the problems and i will look at it
2006-02-10T12:15:55  <ThomasWaldmann> filed
2006-02-10T12:33:40  <ThomasWaldmann> http://moinmoin.wikiwikiweb.de/MoinMoinBugs/UnderScoreQuotingProblem
2006-02-10T21:27:43  <starshine> * ThomasWaldmann tries (in refactor branch) to work around the _ problem
2006-02-10T23:27:55  <ThomasWaldmann> shit, PATH_INFO is decoded already by the server
2006-02-10T23:28:52  <ThomasWaldmann> so I can't do the _ -> %20 -> " " and %5f -> _ trick
2006-02-10T23:33:32  <xorAxAx> umm, of course
2006-02-10T23:35:18  <ThomasWaldmann>  /?A%20B%5fC_D works, though
2006-02-10T23:39:25  <ThomasWaldmann> maybe we should simply use that method to avoid the server interfering with our stuff
2006-02-10T23:39:42  <xorAxAx> --> worse URLs
2006-02-10T23:39:44  <xorAxAx> less usability
2006-02-10T23:39:53  <xorAxAx> --> third world war
2006-02-10T23:40:10  <xorAxAx> how about doing it like kensanata?
2006-02-10T23:40:18  <xorAxAx> he simply has a config option for that
2006-02-10T23:40:27  <ThomasWaldmann> for what?
2006-02-10T23:40:33  <xorAxAx> for the kind of url generation
2006-02-10T23:40:55  <ThomasWaldmann> broken_urls = True
2006-02-10T23:41:04  <xorAxAx> btw, your initial problem were attachments
2006-02-10T23:41:22  <ThomasWaldmann> no, getting _ through
2006-02-10T23:42:48  <ThomasWaldmann> so we either revert that _ cosmetics or have /?
2006-02-10T23:45:07  <xorAxAx> default-pathinfo urls is a nono
2006-02-10T23:45:20  <xorAxAx> umm, query-string-urls i mean
2006-02-10T23:45:42  <ThomasWaldmann> ok, better ideas?
2006-02-10T23:46:11  <xorAxAx> for your problem?
2006-02-10T23:46:18  <xorAxAx> simply encode _ differently
2006-02-10T23:46:33  <ThomasWaldmann> to make another problem? X)
2006-02-10T23:46:39  <xorAxAx> i dont see another problem
2006-02-10T23:46:48  <starshine> storage remapping fun?
2006-02-10T23:46:50  <xorAxAx> as long as the function is bijective