Description

Whenever a user edits a page and clicks "Save Changes" without actually changing the page, the edit is cancelled. ("You did not change the page content, not saved!") However, if another user wants to edit this page afterwards, he's prohibited to it, cause the first user's lock is still in place.

Steps to reproduce

1. User A has to edit a page, press "Save Changes" w/o changing anything
2. User B should now try to edit the page

Example

Component selection

• editing

Details

Workaround

• Wait for the lock to expire..

Discussion

• I guess one only needs to change PageEditor.saveText from

        elif newtext == self.get_raw_body():
            msg = _('You did not change the page content, not saved!')
            raise self.Unchanged, msg

to

        elif newtext == self.get_raw_body():
            msg = _('You did not change the page content, not saved!')
            self.lock.release()
            raise self.Unchanged, msg

Plan

• Priority:
• Assigned to:

• Status: fixed by http://hg.moinmo.in/moin/1.7/rev/d8049de69c4f (will be pulled into 1.8/1.9 repo later)

CategoryMoinMoinBugFixed