Description
This has annoyed me forever. When you are finished with a page and save it, you get the 'thank you' message. All messages of course contain the 'Clear message' link, and that one always contains ?action=show. That hinders copying the URL after that because you can't just select all but have to take care to strip off the ?action=show.
It'd be good if that ?action=show could be removed, and here's a patch to do so:
diff -r c31126b9733d MoinMoin/theme/__init__.py
--- a/MoinMoin/theme/__init__.py Wed Jul 19 23:41:01 2006 +0100
+++ b/MoinMoin/theme/__init__.py Wed Jul 19 23:45:41 2006 +0100
@@ -487,7 +487,7 @@ class ThemeBase:
# Render simple strings with a close link
close = d['page'].link_to(self.request,
text=_('Clear message'),
- querystr={'action': 'show'})
+ querystr={})
html = u'<p>%s</p>\n<div class="buttons">%s</div>\n' % (msg, close)
else:
# msg is a widget
Discussion
action=show is there for a reason - it let you show redirect pages after you edit them. Without it, you will be redirected to the target page after you save.
Yeah, this is the reason it is like it is. But: even if we would remove action=show, you would get a hint on the target page that you were redirected from source page (and that hint is including action=show). Considering that I am doing a change currently that will make action URLs even a bit uglier (thanks to too-simple robots.txt standard), I think I will remove the action=show if we don't have other reasons against that. -- ThomasWaldmann 2006-08-20 10:54:01
A better solution is to remove the message, or make it much smaller so you don't have to close it, or close it by javascript (if available).
Plan
- Priority:
Assigned to: ThomasWaldmann
- Status: is fixed in 1.6 branch