Description

If I do in this wiki start editing a page and do click cancel then the title is written without trailing separating slashes.

tested in konqueror and firefox

I think this should look like ParserMarket/sctable

This does not only occure by Cancel, this was only the first attempt to get it reproducable, which wasn't successful.

Steps to reproduce

edit a subpage and cancel this and look at the new loaded title of the page

Example

see above

Details

this wiki

Workaround

Discussion

This is only one example to get the slash removed. I got it back if I do a browser reload of the page.

Its not a bug, its the correct way to normalize page names. "Foo/" is equal to "Foo". Pointless slashes are stripped before, within and after page names. See PageNames.

I thought result should be PageName/SubPage and not PageNameSubPage or am I wrong?

• You wrote : "the title is written without trailing slashes", which is no bug, but PageName/SubPage must remain the same. I can't reproduce this bug in this wiki.

Here is the steps I tried, using Safari:

1. Visit ParserMarket/NewPage

2. Click on "Create new page"
3. Click "Cancel"

Or:

1. Visit ParserMarket/NewPage?action=edit

2. Click "Cancel"

The page display the correct title.

Nir, now it works for me in firefox 1.5 too but not in konqueror. The image above was taken from firefox which hasn't worked before too. I loaded this page again in firefox and the slash was gone. After a reload it was there. Probably this is a page cache problem for the static html code?

probably reproducable this way

1. click on http://moinmoin.wikiwikiweb.de/ReimarBauer/BugExamination2#preview

2. do a browser reload

It is not easy to get it. Probably try more than once this example

• I tried several times with Safari and Firefox, no luck, I don't see the problem.

  Should it be that's I am alone with this problem, I do have it in this wiki and in the local wiki here (tla update) new instance too

Patch

see MoinMoinBugs/CSSBugForLogoNoInterwikiLink too -- ReimarBauer 2006-01-03 18:18:34

This is a cummulative patch for several things for theme/__init__.py and for modern,classic and rightsidebar screen.css file.

•    1 --- __init__.py	2005-12-21 18:41:23.000000000 +0100
     2 +++ __init__.py.reimar	2005-12-21 19:23:24.702670384 +0100
     3 @@ -177,7 +177,7 @@
     4              segments = d['page_name'].split('/') # was: title_text
     5              for s in segments[:-1]:
     6                  curpage += s
     7 -                content.append("<li>%s</li>" % Page(self.request, curpage).link_to(self.request, s))
     8 +                content.append("<span>%s</span>" % Page(self.request, curpage).link_to(self.request, s))
     9                  curpage += '/'
    10              content.append(('<li><a class="backlink" title="%(title)s" href="%(href)s">%(text)s</a></li>') % {
    11                  'title': _('Click to do a full-text search for this title'),
    12 @@ -185,7 +185,7 @@
    13                  'text': wikiutil.escape(segments[-1]),
    14                  })
    15          else:
    16 -            content.append('<li>%s</li>' % wikiutil.escape(d['title_text']))
    17 +            content.append('<span>%s</span>' % wikiutil.escape(d['title_text']))
    18  
    19          html = '''
    20  <ul id="pagelocation">
    21 @@ -525,7 +525,7 @@
    22                                  True, interwiki, page) +
    23                                      self.shortenPagename(page) +
    24                                      self.request.formatter.interwikilink(False))
    25 -                            items.append('<li>%s</li>' % link)
    26 +                            items.append('<span>%s</span>' % link)
    27                              continue
    28                          else:
    29                              pagename = page
    30 @@ -536,7 +536,7 @@
    31                      title = page.split_title(request)
    32                      title = self.shortenPagename(title)
    33                      link = page.link_to(request, title)
    34 -                    items.append('<li>%s</li>' % link)
    35 +                    items.append('<span>%s</span>' % link)
    36                  html = '''
    37  <ul id="pagetrail">
    38  %s
  

  __init__.patch
My versions

• __init__.py.reimar

The following things are solved:

• / in titel for konqueror and firefox always if needed for PageName/SubPage

• Symbols between pagetrail entries (has not been worked for konqueror)

• for no logo, logo and text,text titel, only logo username, interwiki line and pagetrail is fine formatted

konqueror

firefox

Questions

• why do you mix em and px?

  • It does happen, it's changed.

• can you remove hunks which do nothing?

  • I hope, I've done this complete - this is not easy

• maybe make a single patch file by using diff -ur oldtree newtree

  • I've done this for htdocs, __init__.py is the only one of the lib tree I've changed for that patch.

Tests

• goes well in firefox 1.5 (linux)
• goes well in konqueror 3.3.2 (linux)

Plan

• Priority:

• Assigned to: ThomasWaldmann

• Status: patches applied to moin 1.5 patch-363

CategoryMoinMoinBugFixed