Description

The logfile is buffered but it should be unbuffered.

Steps to reproduce

Enable logPath parameter in moin.py and access the wiki. The output is buffered so that the file will be empty for a while. The content will be written, if the buffer is full or the wiki will be ended.

Details

A buffered file object will be created in standalone.py. But this file should be created unbuffered.

May be that other code (e.g. the twisted server) is also affected.

MoinMoin Version

1.5.3

OS and Version

Linux 2.4.21

Python Version

2.4.2

Solution

--- old/standalone.py.20060821_130235   2006-08-21 13:02:35.000000000 +0200
+++ standalone.py       2006-08-21 13:04:10.000000000 +0200
@@ -502,7 +502,7 @@
             MoinRequestHandler.serve_moin, config.memoryProfile)

     if config.logPath:
-        sys.stderr = file(config.logPath, 'at')
+        sys.stderr = file(config.logPath, 'at', 0)
     registerSignalHandlers(quit)
     httpd = makeServer(config)

Discussion

Plan


CategoryMoinMoinBugFixed

MoinMoin: MoinMoinBugs/BufferedLogFile (last edited 2007-10-29 19:19:05 by localhost)