Description

In 1.7 alpha release (see traceback below for details), uploading an attachment gives error. The upload actually works, but the error would suggest it didn't work.

Steps to reproduce

1. Select Attachment link from a page
2. Browse to desired file (e.g., .jpg) and select it
3. Select Upload
4. See error (see Traceback below)
5. Return to Attachment page
6. Refresh view
7. Notice file has been uploaded successfully

Example

Component selection

• general

Details

Traceback

• A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred.

  1. /home/moin/moin-1.7-docbook/MoinMoin/request/__init__.py in run (self=<MoinMoin.request.request_fcgi.Request object>)

  2. 1273 self.page.send_page()
  3. 1274 else:
  4. 1275 handler(self.page.page_name, self)
  5. 1276

  6. 1277 # every action that didn't use to raise MoinMoinFinish must call this now:

  7. handler = <function execute>

  8. self = <MoinMoin.request.request_fcgi.Request object>

  9. self.page = <MoinMoin.Page.Page object>

  10. self.page.page_name = u'DataImportTool'

• /home/moin/moin-1.7-docbook/MoinMoin/action/AttachFile.py in execute (pagename=u'DataImportTool', request=<MoinMoin.request.request_fcgi.Request object>)

  1. 512 handler = globals().get('_do_%s' % do[0])
  2. 513 if handler:
  3. 514 msg = handler(pagename, request)
  4. 515 else:

  5. 516 msg = _('Unsupported AttachFile sub-action: %s') % (wikiutil.escape(do[0]), )

  6. msg undefined

  7. handler = <function _do_upload>

  8. pagename = u'DataImportTool'

  9. request = <MoinMoin.request.request_fcgi.Request object>

• /home/moin/moin-1.7-docbook/MoinMoin/action/AttachFile.py in _do_upload (pagename=u'DataImportTool', request=<MoinMoin.request.request_fcgi.Request object>)

  1. 589 # add the attachment
  2. 590 try:
  3. 591 add_attachment(request, pagename, target, filecontent, overwrite=overwrite)
  4. 592
  5. 593 bytes = len(filecontent)

  6. global add_attachment = <function add_attachment>

  7. request = <MoinMoin.request.request_fcgi.Request object>

  8. pagename = u'DataImportTool'

  9. target = u'csvimp1.JPG'

  10. filecontent = "\xff\xd8\xff\xe0\x00\x10JFIF\x00\x01\x01\x01\x00\x00\x00\x00\xff\xdb\x00C\x00\x08\x06\x06\x07\x06\x05\x08\x07\x07\x07\t\t\x08\n\x0c\x14\r\x0c\x0b\x0b\x0c\x19\x12...\x00\x9f\xa8\xff\x00\xef\xaa?\xe1'\xb0\xff\x00\x9f\xa8\xff\x00\xef\xaa9@\xe8h\xae{\xfe\x12{\x0f\xf9\xfa\x8f\xfe\xfa\xa3\xfe\x12{\x0f\xf9\xfa\x8f\xfe\xfa\xa2\xcc\x0f\xff\xd9"

  11. overwrite = 0

• /home/moin/moin-1.7-docbook/MoinMoin/action/AttachFile.py in add_attachment (request=<MoinMoin.request.request_fcgi.Request object>, pagename=u'DataImportTool', target=u'csvimp1.JPG', filecontent="\xff\xd8\xff\xe0\x00\x10JFIF\x00\x01\x01\x01\x00\x00\x00\x00\xff\xdb\x00C\x00\x08\x06\x06\x07\x06\x05\x08\x07\x07\x07\t\t\x08\n\x0c\x14\r\x0c\x0b\x0b\x0c\x19\x12...\x00\x9f\xa8\xff\x00\xef\xaa?\xe1'\xb0\xff\x00\x9f\xa8\xff\x00\xef\xaa9@\xe8h\xae{\xfe\x12{\x0f\xf9\xfa\x8f\xfe\xfa\xa3\xfe\x12{\x0f\xf9\xfa\x8f\xfe\xfa\xa2\xcc\x0f\xff\xd9", overwrite=0)

  1. 197

  2. 198 event = FileAttachedEvent(request, pagename, target, len(filecontent))

  3. 199 send_event(event)
  4. 200
  5. 201 return target

  6. global send_event = <function send_event>

  7. event = <MoinMoin.events.FileAttachedEvent object>

• /home/moin/moin-1.7-docbook/MoinMoin/events/__init__.py in send_event (event=<MoinMoin.events.FileAttachedEvent object>)

  1. 240 # Try to handle the event with each available handler (for now)
  2. 241 for handle in cfg.event_handlers:
  3. 242 retval = handle(event)
  4. 243

  5. 244 assert retval is None or isinstance(retval, EventResult)

  6. retval undefined

  7. handle = <function handle>

  8. event = <MoinMoin.events.FileAttachedEvent object>

• /home/moin/moin-1.7-docbook/MoinMoin/events/emailnotify.py in handle (event=<MoinMoin.events.FileAttachedEvent object>)

  1. 162 return notify_subscribers(event.request, event.page, event.comment, True)

  2. 163 elif isinstance(event, ev.UserCreatedEvent):

  3. 164 return handle_user_created(event)

  4. 165 elif isinstance(event, ev.FileAttachedEvent):

  5. 166 return handle_file_attached(event)

  6. global handle_file_attached = <function handle_file_attached>

  7. event = <MoinMoin.events.FileAttachedEvent object>

• /home/moin/moin-1.7-docbook/MoinMoin/events/emailnotify.py in handle_file_attached (event=<MoinMoin.events.FileAttachedEvent object>)

  1. 141
  2. 142 data = notification.attachment_added(request, _, event.pagename, event.filename, event.size)
  3. 143 data['body'] = data['body'] + links
  4. 144
  5. 145 emails = [usr.email for usr in subscribers[lang]]

  6. data = {'attach_name': u'csvimp1.JPG', 'attach_size': 74364, 'editor': u'ptyler', 'page_name': u'DataImportTool', 'subject': u'New attachment added to page DataImportTool on xTuple', 'text': u'Dear Wiki user,\n\nYou have subscribed to a wiki p...achment name: csvimp1.JPG\nAttachment size: 74364\n'}

  7. links = 'Attachment link: http://office.openmfg.com:88/Da...ink: http://office.openmfg.com:88/DataImportTool\n'

KeyError

• 'body'
  • args = ('body',)

System Details

• Date: Mon, 21 Apr 2008 13:32:29 +0000
• Platform: Linux batch.openmfg.com 2.6.20-1.2320.fc5smp #1 SMP Tue Jun 12 19:40:16 EDT 2007 i686
• Python: Python 2.4.3 (/usr/bin/python)

• MoinMoin: Release 1.7.0alpha (release)

Workaround

It basically works. Just hit Refresh on attachment page.

Discussion

Plan

• Priority:
• Assigned to:
• Status: can't reproduce in current version

CategoryMoinMoinBugFixed