MoinMoin: DiogenesAugusto/GSoC2010/Diary/2010-07-29

• replaced theme.add_msg to flash of flask
• removed actions and wsgiapp tests
• refactored blocks of templates

• do a systematic review of all href() / url_for() / url usage in your templates - you need to escape URLs in html

• link to url_for('feed.atom') on global history view (use feed icon for it)
• link to url_for('feed.atom', item_name=item_name) on local (item) history view (use feed icon for it) + announce it in the show view's html in the usual way
  • improve block usage
    • you currently try to render a link to the ITEMs atom feed in base template (which is the most fundamental template that is EVER used when we generate html output, not only when rendering item related views, but also when rendering other stuff, like user login/logout/prefs and others - there is no item_name in those cases, thus it will be broken for these cases).
    • How about an empty block "feeds" there, that is filled with a link to item's atom feed from item views and filled with a link to global atom feed from global changes view?

• read this and use it to systematically cleanup whitespace in your templates: http://jinja.pocoo.org/2/documentation/templates#whitespace-control

  • look at the current html output to see why
• make the atom feeds work (currently there is just a stub at the right place, more code is in action/atom_feed.py - move it to a better place and use it)
  • after code is working at new/right place, remove the code at the old/unused place.

TODO until 2010-07-31 or earlier